)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b3cc7219cf5bfea3671045b546df6145235814e6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"the basic group functionalities in this spec."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I89eb60f80e846a30cfcde910a775ed42288bfccd"},{"line_number":19,"context_line":"blueprint: generic-volume-group"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_8c43c541","line":19,"updated":"2016-04-14 19:01:38.000000000","message":"I think this needs to be:\n\nImplements: blueprint generic-volume-group\n\nto be linked properly.\n\nActually, nevermind. It did update the whiteboard with a link to this. Might be good to change for consistency sake if you do an update.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"}],"specs/newton/generic-volume-group.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7576b62fa6955400b4ba2dc95ea6de5297c83bf5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  * Add an API that allows a tenant to delete a volume group."},{"line_number":75,"context_line":"  * Add a Volume Driver API accordingly."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* List groupa"},{"line_number":78,"context_line":"  * Add an API to list volume groups."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Show a group"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_90a3739e","line":77,"range":{"start_line":77,"start_character":7,"end_line":77,"end_character":13},"updated":"2016-04-11 13:44:07.000000000","message":"s/groupa/groups","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"281475986c5b8a0bab2708089b9f61c39d8ae7a3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  * Add an API that allows a tenant to delete a volume group."},{"line_number":75,"context_line":"  * Add a Volume Driver API accordingly."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* List groupa"},{"line_number":78,"context_line":"  * Add an API to list volume groups."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Show a group"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_4fd81154","line":77,"range":{"start_line":77,"start_character":7,"end_line":77,"end_character":13},"in_reply_to":"7a1b2928_90a3739e","updated":"2016-04-11 15:55:34.000000000","message":"Done","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7576b62fa6955400b4ba2dc95ea6de5297c83bf5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  * A new group_type table will be created and will contain the following:"},{"line_number":99,"context_line":"    * uuid of the group_type"},{"line_number":100,"context_line":"    * name"},{"line_number":101,"context_line":"    * description"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  * A new group table will be created and will contain the following:"},{"line_number":104,"context_line":"    * uuid of the group"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_b0ef8faf","line":101,"range":{"start_line":101,"start_character":6,"end_line":101,"end_character":17},"updated":"2016-04-11 13:44:07.000000000","message":"Don\u0027t we need group_type_extra_specs as well? Or is the plan to link group types with volume types? (i guess that\u0027s what\u0027s suggested by the tables below)","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"281475986c5b8a0bab2708089b9f61c39d8ae7a3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  * A new group_type table will be created and will contain the following:"},{"line_number":99,"context_line":"    * uuid of the group_type"},{"line_number":100,"context_line":"    * name"},{"line_number":101,"context_line":"    * description"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  * A new group table will be created and will contain the following:"},{"line_number":104,"context_line":"    * uuid of the group"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_2fc95579","line":101,"range":{"start_line":101,"start_character":6,"end_line":101,"end_character":17},"in_reply_to":"7a1b2928_b0ef8faf","updated":"2016-04-11 15:55:34.000000000","message":"Done","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7576b62fa6955400b4ba2dc95ea6de5297c83bf5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"Alternatives"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Without these propsed changes, we can add replication support to the existing"},{"line_number":121,"context_line":"consistency group but won\u0027t have a generic volume group that can serve more"},{"line_number":122,"context_line":"purposes."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_b0a78f4e","line":120,"range":{"start_line":120,"start_character":14,"end_line":120,"end_character":21},"updated":"2016-04-11 13:44:07.000000000","message":"s/propsed/proposed","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"281475986c5b8a0bab2708089b9f61c39d8ae7a3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"Alternatives"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Without these propsed changes, we can add replication support to the existing"},{"line_number":121,"context_line":"consistency group but won\u0027t have a generic volume group that can serve more"},{"line_number":122,"context_line":"purposes."},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_4fcc9135","line":120,"range":{"start_line":120,"start_character":14,"end_line":120,"end_character":21},"in_reply_to":"7a1b2928_b0a78f4e","updated":"2016-04-11 15:55:34.000000000","message":"Done","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7576b62fa6955400b4ba2dc95ea6de5297c83bf5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Delete Group Type"},{"line_number":167,"context_line":"  * V3/\u003ctenant id of admin\u003e/group_types/\u003cgroup_type_uuid\u003e"},{"line_number":168,"context_line":"  * Method: POST"},{"line_number":169,"context_line":"  * This API has no body."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"New Group APIs"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_b02cafac","line":169,"range":{"start_line":169,"start_character":24,"end_line":169,"end_character":25},"updated":"2016-04-11 13:44:07.000000000","message":"How do you add volume_types to group_types?\n\nOr\n\nHow do you add extra_specs to group_types","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"281475986c5b8a0bab2708089b9f61c39d8ae7a3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Delete Group Type"},{"line_number":167,"context_line":"  * V3/\u003ctenant id of admin\u003e/group_types/\u003cgroup_type_uuid\u003e"},{"line_number":168,"context_line":"  * Method: POST"},{"line_number":169,"context_line":"  * This API has no body."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"New Group APIs"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_4ff3f173","line":169,"range":{"start_line":169,"start_character":24,"end_line":169,"end_character":25},"in_reply_to":"7a1b2928_b02cafac","updated":"2016-04-11 15:55:34.000000000","message":"We\u0027ll have group_type_specs.","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7576b62fa6955400b4ba2dc95ea6de5297c83bf5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        }"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  * This method can update name, description, as well as volumes in the group."},{"line_number":223,"context_line":"    The list after \"addv_olumes\" will contain UUIDs of volumes to be added to"},{"line_number":224,"context_line":"    the group and the list after \"remove_volumes\" will contain UUIDs of volumes"},{"line_number":225,"context_line":"    to be removed from the group. The API will validate the input name,"},{"line_number":226,"context_line":"    description, UUIDs in add_volumes and remove_volumes fields against the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a1b2928_3a799d94","line":223,"range":{"start_line":223,"start_character":20,"end_line":223,"end_character":31},"updated":"2016-04-11 13:44:07.000000000","message":"s/addv_olumes/add_volumes","commit_id":"98d7879787adae74c36d7689f3b90647fa4119bf"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f76376a438575b4f45ba5f170c8412ca9d345902","unresolved":false,"context_lines":[{"line_number":20,"context_line":"In Cinder, the only group construct available today is Consistency Group."},{"line_number":21,"context_line":"Consistency Group only supports consistent group snapshot today. When we"},{"line_number":22,"context_line":"started to look at extending this support for group replication, lots of"},{"line_number":23,"context_line":"issues came up. Consistency Group implies data consistency. For some drivers,"},{"line_number":24,"context_line":"a group replication can ensure data consistency across the volumes in the"},{"line_number":25,"context_line":"group, but for other drivers, group replication does not imply data"},{"line_number":26,"context_line":"consistency."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In this spec, we are designing a generic volume group. This group construct"},{"line_number":29,"context_line":"can form a base for adding group replication support which will be discussed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_79cabb6e","line":26,"range":{"start_line":23,"start_character":16,"end_line":26,"end_character":12},"updated":"2016-04-18 21:17:18.000000000","message":"Is this really just re-implementation of consistency groups with a different name?  This seems confusing.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"46a3afbcbc37de72d091ca8f80f966a81b066b7b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"In Cinder, the only group construct available today is Consistency Group."},{"line_number":21,"context_line":"Consistency Group only supports consistent group snapshot today. When we"},{"line_number":22,"context_line":"started to look at extending this support for group replication, lots of"},{"line_number":23,"context_line":"issues came up. Consistency Group implies data consistency. For some drivers,"},{"line_number":24,"context_line":"a group replication can ensure data consistency across the volumes in the"},{"line_number":25,"context_line":"group, but for other drivers, group replication does not imply data"},{"line_number":26,"context_line":"consistency."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In this spec, we are designing a generic volume group. This group construct"},{"line_number":29,"context_line":"can form a base for adding group replication support which will be discussed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_f00ef48a","line":26,"range":{"start_line":23,"start_character":16,"end_line":26,"end_character":12},"in_reply_to":"1a122d0e_79cabb6e","updated":"2016-04-22 22:57:20.000000000","message":"Yea kinda, but more generic and not implicitly consistent.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"In Cinder, the only group construct available today is Consistency Group."},{"line_number":21,"context_line":"Consistency Group only supports consistent group snapshot today. When we"},{"line_number":22,"context_line":"started to look at extending this support for group replication, lots of"},{"line_number":23,"context_line":"issues came up. Consistency Group implies data consistency. For some drivers,"},{"line_number":24,"context_line":"a group replication can ensure data consistency across the volumes in the"},{"line_number":25,"context_line":"group, but for other drivers, group replication does not imply data"},{"line_number":26,"context_line":"consistency."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"In this spec, we are designing a generic volume group. This group construct"},{"line_number":29,"context_line":"can form a base for adding group replication support which will be discussed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_6dec19c8","line":26,"range":{"start_line":23,"start_character":16,"end_line":26,"end_character":12},"in_reply_to":"1a122d0e_f00ef48a","updated":"2016-05-06 15:34:16.000000000","message":"Described in the Proposed Changes section on how to migrate the existing consistency groups to use the new group construct over several releases to make it doesn\u0027t break existing deployment.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b3cc7219cf5bfea3671045b546df6145235814e6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  A tenant may want to put volumes used in the same application together in"},{"line_number":44,"context_line":"  a group so that it is easier to manage them together."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Update group"},{"line_number":47,"context_line":"  This is the ability to add an existing volume to a group or remove a volume"},{"line_number":48,"context_line":"  from a group without deleting it. This ability is useful for some tenants"},{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_ac5041d5","line":46,"updated":"2016-04-14 19:01:38.000000000","message":"This one seems more like an implementation detail than a use case.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  A tenant may want to put volumes used in the same application together in"},{"line_number":44,"context_line":"  a group so that it is easier to manage them together."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Update group"},{"line_number":47,"context_line":"  This is the ability to add an existing volume to a group or remove a volume"},{"line_number":48,"context_line":"  from a group without deleting it. This ability is useful for some tenants"},{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_cdca654f","line":46,"in_reply_to":"1a122d0e_8aca12a0","updated":"2016-05-06 15:34:16.000000000","message":"Done","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"5ee1f0ad5a892721e02d4b1226287275bdb95385","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  A tenant may want to put volumes used in the same application together in"},{"line_number":44,"context_line":"  a group so that it is easier to manage them together."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Update group"},{"line_number":47,"context_line":"  This is the ability to add an existing volume to a group or remove a volume"},{"line_number":48,"context_line":"  from a group without deleting it. This ability is useful for some tenants"},{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_8aca12a0","line":46,"in_reply_to":"5a18252c_ac5041d5","updated":"2016-04-17 00:37:20.000000000","message":"agree with Sean here","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b3cc7219cf5bfea3671045b546df6145235814e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Update group"},{"line_number":47,"context_line":"  This is the ability to add an existing volume to a group or remove a volume"},{"line_number":48,"context_line":"  from a group without deleting it. This ability is useful for some tenants"},{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"},{"line_number":50,"context_line":"  out that not all drivers can support this functionality. For example, if a"},{"line_number":51,"context_line":"  driver puts all volumes in the same pool in a group, it cannot remove"},{"line_number":52,"context_line":"  a volume from the pool without deleting it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_2cf6f1f8","line":49,"updated":"2016-04-14 19:01:38.000000000","message":"nit: /flexilbly/flexibly/","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Update group"},{"line_number":47,"context_line":"  This is the ability to add an existing volume to a group or remove a volume"},{"line_number":48,"context_line":"  from a group without deleting it. This ability is useful for some tenants"},{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"},{"line_number":50,"context_line":"  out that not all drivers can support this functionality. For example, if a"},{"line_number":51,"context_line":"  driver puts all volumes in the same pool in a group, it cannot remove"},{"line_number":52,"context_line":"  a volume from the pool without deleting it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_8d35fd47","line":49,"in_reply_to":"5a18252c_2cf6f1f8","updated":"2016-05-06 15:34:16.000000000","message":"Done","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"},{"line_number":50,"context_line":"  out that not all drivers can support this functionality. For example, if a"},{"line_number":51,"context_line":"  driver puts all volumes in the same pool in a group, it cannot remove"},{"line_number":52,"context_line":"  a volume from the pool without deleting it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* Group replication"},{"line_number":55,"context_line":"  Group replication will not be addressed in this spec. Once a volume group"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_ea90e6ee","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":45},"updated":"2016-04-17 03:57:19.000000000","message":"Pointed out how? If a driver does not support removal from a group.... how is this limitation expected to be advertised?\n\nAs Sean said, this could be implementation detail.. but I would really like to understand this if it were designed as part of this feature..","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  to manage the volumes in a group flexilbly. However, it should be pointed"},{"line_number":50,"context_line":"  out that not all drivers can support this functionality. For example, if a"},{"line_number":51,"context_line":"  driver puts all volumes in the same pool in a group, it cannot remove"},{"line_number":52,"context_line":"  a volume from the pool without deleting it."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* Group replication"},{"line_number":55,"context_line":"  Group replication will not be addressed in this spec. Once a volume group"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_ed4649be","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":45},"in_reply_to":"1a122d0e_ea90e6ee","updated":"2016-05-06 15:34:16.000000000","message":"Moved to Proposed Changes section. Driver should report capabilities on this.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  * One group can support only one group type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Group type specs"},{"line_number":93,"context_line":"  * Add group type specs to describe a group\u0027s characteristics just like"},{"line_number":94,"context_line":"    volume type extra specs to a volume type."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Changes in the scheduler."},{"line_number":97,"context_line":"  * Make changes in the scheduler so that an appropiate backend will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_0afd623a","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":45},"updated":"2016-04-17 03:57:19.000000000","message":"How are these group type specs reported by a backend to the scheduler? Currently, extra_specs of volume_types are reported as \"capabilities\".. do we have a distinction?","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"46a3afbcbc37de72d091ca8f80f966a81b066b7b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  * One group can support only one group type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Group type specs"},{"line_number":93,"context_line":"  * Add group type specs to describe a group\u0027s characteristics just like"},{"line_number":94,"context_line":"    volume type extra specs to a volume type."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Changes in the scheduler."},{"line_number":97,"context_line":"  * Make changes in the scheduler so that an appropiate backend will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_f05c347f","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":45},"in_reply_to":"1a122d0e_0afd623a","updated":"2016-04-22 22:57:20.000000000","message":"Good question, I would assume we could have new group capabilities reported by the drivers or key off of existing capabilities. Probably worth fleshing out a little bit here.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  * One group can support only one group type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* Group type specs"},{"line_number":93,"context_line":"  * Add group type specs to describe a group\u0027s characteristics just like"},{"line_number":94,"context_line":"    volume type extra specs to a volume type."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Changes in the scheduler."},{"line_number":97,"context_line":"  * Make changes in the scheduler so that an appropiate backend will be"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_d0967e93","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":45},"in_reply_to":"1a122d0e_f05c347f","updated":"2016-05-06 15:34:16.000000000","message":"Group type specs will be reported as capabilities as well.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    volume type extra specs to a volume type."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Changes in the scheduler."},{"line_number":97,"context_line":"  * Make changes in the scheduler so that an appropiate backend will be"},{"line_number":98,"context_line":"    chosen to create a group."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* DB Schema Changes"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_6aedf68a","line":97,"range":{"start_line":97,"start_character":45,"end_line":97,"end_character":55},"updated":"2016-04-17 03:57:19.000000000","message":"appropriate","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    volume type extra specs to a volume type."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Changes in the scheduler."},{"line_number":97,"context_line":"  * Make changes in the scheduler so that an appropiate backend will be"},{"line_number":98,"context_line":"    chosen to create a group."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* DB Schema Changes"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_ed2c89ad","line":97,"range":{"start_line":97,"start_character":45,"end_line":97,"end_character":55},"in_reply_to":"1a122d0e_6aedf68a","updated":"2016-05-06 15:34:16.000000000","message":"Done","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6ede7d3e51ad4ca1b94c4a126539cd150d350897","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * The volumes table will have a new column:"},{"line_number":124,"context_line":"    * uuid of the group as a foreign key"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Alternatives"},{"line_number":127,"context_line":"------------"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_1e99bf79","line":125,"updated":"2016-05-05 06:48:14.000000000","message":"So maybe we should also add volume group quota mechanism.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eee3d268d0126fa8bd4acda43d17d47c81922bc0","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * The volumes table will have a new column:"},{"line_number":124,"context_line":"    * uuid of the group as a foreign key"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Alternatives"},{"line_number":127,"context_line":"------------"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_d6739eb2","line":125,"in_reply_to":"1a122d0e_1e99bf79","updated":"2016-05-05 13:55:42.000000000","message":"Sure. We are doing it for CG so makes sense to have quota for generic groups.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    * uuid of a volume type"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  * The volumes table will have a new column:"},{"line_number":154,"context_line":"    * uuid of the group as a foreign key"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"REST API impact"},{"line_number":157,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_cab08a8e","line":154,"range":{"start_line":154,"start_character":37,"end_line":154,"end_character":40},"updated":"2016-04-17 03:57:19.000000000","message":"nit: you\u0027re missing the group_type_specs here.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    * uuid of a volume type"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  * The volumes table will have a new column:"},{"line_number":154,"context_line":"    * uuid of the group as a foreign key"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"REST API impact"},{"line_number":157,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_1335b0d9","line":154,"range":{"start_line":154,"start_character":37,"end_line":154,"end_character":40},"in_reply_to":"1a122d0e_cab08a8e","updated":"2016-05-06 15:34:16.000000000","message":"Done","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* Delete Group Type"},{"line_number":177,"context_line":"  * V3/\u003ctenant id of admin\u003e/group_types/\u003cgroup_type_uuid\u003e"},{"line_number":178,"context_line":"  * Method: POST"},{"line_number":179,"context_line":"  * This API has no body."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_0aaba21e","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":16},"updated":"2016-04-17 03:57:19.000000000","message":"DELETE","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eee3d268d0126fa8bd4acda43d17d47c81922bc0","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* Delete Group Type"},{"line_number":177,"context_line":"  * V3/\u003ctenant id of admin\u003e/group_types/\u003cgroup_type_uuid\u003e"},{"line_number":178,"context_line":"  * Method: POST"},{"line_number":179,"context_line":"  * This API has no body."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_9b02ef0a","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":16},"in_reply_to":"1a122d0e_0aaba21e","updated":"2016-05-05 13:55:42.000000000","message":"You are right. This is a copy and paste error from \"delete group\":). Thanks!","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  * The reason to include volume types when creating a group is to make sure"},{"line_number":241,"context_line":"    that the backend selected to place the group will be able to host a volume"},{"line_number":242,"context_line":"    of the specified volume type at a later time."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  * One group can support one group type and multiple volume types."},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_2a4f7e93","line":242,"range":{"start_line":242,"start_character":48,"end_line":242,"end_character":49},"updated":"2016-04-17 03:57:19.000000000","message":"Volume types are mutable.. So, should you allow removing a volume type after it is created with a volume type?\n\nEx:\nI have a \"gold\" volume_type that has a few extra_specs, at a later time, i remove one or more extra specs and add new ones.. i now know this disqualifies a few backends that it was previously compatible with... so can i update the groups that support this volume_type to stop supporting this volume_type?","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"46a3afbcbc37de72d091ca8f80f966a81b066b7b","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  * The reason to include volume types when creating a group is to make sure"},{"line_number":241,"context_line":"    that the backend selected to place the group will be able to host a volume"},{"line_number":242,"context_line":"    of the specified volume type at a later time."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  * One group can support one group type and multiple volume types."},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_d325c2ae","line":242,"range":{"start_line":242,"start_character":48,"end_line":242,"end_character":49},"in_reply_to":"1a122d0e_2a4f7e93","updated":"2016-04-22 22:57:20.000000000","message":"That seems pretty reasonable, and maybe exposes some pain points around modifying types in general. \n\nSomeone correct me if I\u0027m wrong on how this works, but....  When, in your example, you modify the gold type specs if the change would have disqualified the current group host all the volumes that are already in the group and are gold type are still there. You would probably never be able to create a volume in that group that is gold type again whether or not you remove gold from the group types. The scheduler should fail creating the volume failing the host check (or at least iirc thats how it works with cg\u0027s today).\n\nI\u0027m wondering if maybe we need some more general \u0027cleanup after type changes\u0027 kind of mechanism to allow for things to basically get re-scheduled and migrated based on new type information. Definitely falls outside the scope of this spec though... mainly just rambling so I find this later :D","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"  * The reason to include volume types when creating a group is to make sure"},{"line_number":241,"context_line":"    that the backend selected to place the group will be able to host a volume"},{"line_number":242,"context_line":"    of the specified volume type at a later time."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  * One group can support one group type and multiple volume types."},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_333c3493","line":242,"range":{"start_line":242,"start_character":48,"end_line":242,"end_character":49},"in_reply_to":"1a122d0e_d325c2ae","updated":"2016-05-06 15:34:16.000000000","message":"Yes, I think this is really a general topic on volume types beyond the scope of this spec. Currently we don\u0027t do any checks on existing volumes when deleting or modifying a type.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * This method can update name, description, as well as volumes in the group."},{"line_number":268,"context_line":"    The list after \"addv_olumes\" will contain UUIDs of volumes to be added to"},{"line_number":269,"context_line":"    the group and the list after \"remove_volumes\" will contain UUIDs of volumes"},{"line_number":270,"context_line":"    to be removed from the group. The API will validate the input name,"},{"line_number":271,"context_line":"    description, UUIDs in add_volumes and remove_volumes fields against the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_6ad696c6","line":268,"range":{"start_line":268,"start_character":20,"end_line":268,"end_character":31},"updated":"2016-04-17 03:57:19.000000000","message":"add_volumes","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7b96bbc468350c2b342b4f35f18a4b6529805de5","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * This method can update name, description, as well as volumes in the group."},{"line_number":268,"context_line":"    The list after \"addv_olumes\" will contain UUIDs of volumes to be added to"},{"line_number":269,"context_line":"    the group and the list after \"remove_volumes\" will contain UUIDs of volumes"},{"line_number":270,"context_line":"    to be removed from the group. The API will validate the input name,"},{"line_number":271,"context_line":"    description, UUIDs in add_volumes and remove_volumes fields against the"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_33bf14d2","line":268,"range":{"start_line":268,"start_character":20,"end_line":268,"end_character":31},"in_reply_to":"1a122d0e_6ad696c6","updated":"2016-05-06 15:34:16.000000000","message":"Done","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6ede7d3e51ad4ca1b94c4a126539cd150d350897","unresolved":false,"context_lines":[{"line_number":277,"context_line":"* Delete Group"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":280,"context_line":"  * Method: POST"},{"line_number":281,"context_line":"  * JSON schema definition for V3::"},{"line_number":282,"context_line":"        {"},{"line_number":283,"context_line":"            \"delete\":"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_de6f4790","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":16},"updated":"2016-05-05 06:48:14.000000000","message":"DELETE","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a5246fcd3221f85c48386d1fdb990bd6f049f11d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"* Delete Group"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":280,"context_line":"  * Method: POST"},{"line_number":281,"context_line":"  * JSON schema definition for V3::"},{"line_number":282,"context_line":"        {"},{"line_number":283,"context_line":"            \"delete\":"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_308601ba","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":16},"in_reply_to":"1a122d0e_5bb0578b","updated":"2016-05-06 02:32:41.000000000","message":"Thanks for clarification","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eee3d268d0126fa8bd4acda43d17d47c81922bc0","unresolved":false,"context_lines":[{"line_number":277,"context_line":"* Delete Group"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":280,"context_line":"  * Method: POST"},{"line_number":281,"context_line":"  * JSON schema definition for V3::"},{"line_number":282,"context_line":"        {"},{"line_number":283,"context_line":"            \"delete\":"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_5bb0578b","line":280,"range":{"start_line":280,"start_character":11,"end_line":280,"end_character":16},"in_reply_to":"1a122d0e_de6f4790","updated":"2016-05-05 13:55:42.000000000","message":"This is actually not a \"DELETE\" because the request body is not empty.  To use the force flag, I\u0027ll have to do a \"POST\". I\u0027ll add a note for this.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6003afe11f40a809e76eec4fb76b6498d130e23","unresolved":false,"context_lines":[{"line_number":431,"context_line":"Testing"},{"line_number":432,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"New unit tests will be added to test the changed code."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Documentation Impact"},{"line_number":437,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_aa226eb7","line":434,"range":{"start_line":434,"start_character":53,"end_line":434,"end_character":54},"updated":"2016-04-17 03:57:19.000000000","message":"Is there expected to be no reference driver support for this, as part of this work?","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eee3d268d0126fa8bd4acda43d17d47c81922bc0","unresolved":false,"context_lines":[{"line_number":431,"context_line":"Testing"},{"line_number":432,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"New unit tests will be added to test the changed code."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"Documentation Impact"},{"line_number":437,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_bb4ecb93","line":434,"range":{"start_line":434,"start_character":53,"end_line":434,"end_character":54},"in_reply_to":"1a122d0e_aa226eb7","updated":"2016-05-05 13:55:42.000000000","message":"LVM will be the reference driver.","commit_id":"3db08c5a8fc301021fbea7ffb37ff598127097d4"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"af1d8e939e12dd69ac36f667534b0833ceed4957","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_4a792efc","line":96,"updated":"2016-05-06 18:14:02.000000000","message":"I would request to add details in spec for group type relation with volume type, is there any dependency of group type on backends or group can create multiple type of backends?\n\nWhat i want to know is whether group can be created on single volume types or it can be linked intra-volume-types?\n\nIf these are specific to volume_type(one group can be created on same type of backends), then this group type specs are not required and direct volume type constructs can be used.\n\nPlease clear doubts here.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fd404512e2ed65a96ad9927d81a12dc0acfc36ca","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7aa08908_d36ff85d","line":96,"in_reply_to":"7aa08908_6f7adb89","updated":"2016-06-14 13:23:40.000000000","message":"Hi Duncan,\n\nI meant to have code ready for review so we have a more concrete idea on how it looks like.  I have implemented group types.  Please help with reviews:\n\nGroup types and specs: https://review.openstack.org/#/c/320165/\nGroups: https://review.openstack.org/#/c/322459/\n\nThanks!","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7310c2f72d3685d2c36e5cc447c7b329b5c5d052","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_3a55e11c","line":96,"in_reply_to":"dab17558_0b6423e3","updated":"2016-05-09 16:02:45.000000000","message":"Hi Sheel,\n\nI\u0027m afraid this kind of discussions on the spec will become endless as I know there are people who really like the idea of a group type. I\u0027m going to go ahead and implement it first. If by reviewing code, we decide jointly it is better not to add group type, we can drop it at that time.  Thanks.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"fa281f7ff89ac414d79dc3ad97649a2c3c0405fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_6e132ab9","line":96,"in_reply_to":"dab17558_3a55e11c","updated":"2016-05-09 16:19:35.000000000","message":"Dear xing-yang,\n\nAgree with your point.\nLets go ahead if others(team) want it.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_7c50205f","line":96,"in_reply_to":"dab17558_4a792efc","updated":"2016-05-09 03:00:05.000000000","message":"To be honest, I don\u0027t think group type is necessary. However, most people are in favor of it. I would be very happy to drop it if the team asks me to do so.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"c720db9d32e726486b96602aac5ff9d77b7a167e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7aa08908_6f7adb89","line":96,"in_reply_to":"dab17558_6e132ab9","updated":"2016-06-13 09:23:00.000000000","message":"I\u0027m not sure that dropping the discussion is useful - I (probably among others) don\u0027t see that much use for the group concept without a type. AFAICT the entire point of a group is that it supports some set of operations. Without a type, that set of operations is undefined, and might change when you add a volume to it! This is pretty fundamental stuff.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f41a08a7ddfb89795838956bd4a90cb2ec5c25f1","unresolved":false,"context_lines":[{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_0b6423e3","line":96,"in_reply_to":"dab17558_7c50205f","updated":"2016-05-09 07:32:13.000000000","message":"could we keep it in meeting agenda if need discussions on it?","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"af1d8e939e12dd69ac36f667534b0833ceed4957","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  * Add group type specs to describe a group\u0027s characteristics just like"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_6ad6b2c6","line":97,"updated":"2016-05-06 18:14:02.000000000","message":"Also if groups can contain single type of backends only, then these should be node groups(backends/nodes of same type) and should provide API to add/remove volumes/snapshot from node group.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  * Add a group type for a group just like a volume type for a volume."},{"line_number":96,"context_line":"  * One group can support only one group type."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Group type specs"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  * Add group type specs to describe a group\u0027s characteristics just like"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_fc98901d","line":97,"in_reply_to":"dab17558_6ad6b2c6","updated":"2016-05-09 03:00:05.000000000","message":"No, it is not node group. It is a group of volumes with the same capabilities and should not be tied to a node.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"af1d8e939e12dd69ac36f667534b0833ceed4957","unresolved":false,"context_lines":[{"line_number":105,"context_line":"* Changes in the scheduler."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  * Make changes in the scheduler so that an appropriate backend will be"},{"line_number":108,"context_line":"    chosen to create a group."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* DB Schema Changes"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_ead8e21f","line":108,"updated":"2016-05-06 18:14:02.000000000","message":"why scheduler will come into picture to create group?\nIt must be directly handled by group_type as group_type itself would be having details about baends where group exists.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":105,"context_line":"* Changes in the scheduler."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  * Make changes in the scheduler so that an appropriate backend will be"},{"line_number":108,"context_line":"    chosen to create a group."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* DB Schema Changes"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_7c2140b4","line":108,"in_reply_to":"dab17558_ead8e21f","updated":"2016-05-09 03:00:05.000000000","message":"See \"Create a Group\" section.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"af1d8e939e12dd69ac36f667534b0833ceed4957","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    * uuid of the group"},{"line_number":127,"context_line":"    * uuid of a group_type as a foreign key"},{"line_number":128,"context_line":"    * name"},{"line_number":129,"context_line":"    * description"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * A new volume_group_mapping table will be created and will contain the"},{"line_number":132,"context_line":"    following columns. This is needed because one volume could be in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_eaf9024f","line":129,"updated":"2016-05-06 18:14:02.000000000","message":"from this DB Schema, it seems we are creating clone of volume_types. Almost same things.\nCant we use volume_type_group with existing volume type, volume type extra specs etc?","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    * uuid of the group"},{"line_number":127,"context_line":"    * uuid of a group_type as a foreign key"},{"line_number":128,"context_line":"    * name"},{"line_number":129,"context_line":"    * description"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  * A new volume_group_mapping table will be created and will contain the"},{"line_number":132,"context_line":"    following columns. This is needed because one volume could be in"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_fc1b707e","line":129,"in_reply_to":"dab17558_eaf9024f","updated":"2016-05-09 03:00:05.000000000","message":"As I mentioned above, I don\u0027t like adding a group_type either, but this is a team decision.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"08b6adee75c470b9719f91fd8ebfd12cb72ad35d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    * uuid of a group"},{"line_number":138,"context_line":"    * Alternatively, we can restrict a volume can only belong to one group."},{"line_number":139,"context_line":"      If so, we do not need this mapping table. We only need to add the"},{"line_number":140,"context_line":"      uuid of the group as a foreign key in the volumes table."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  * A new group_volumetypes_mapping table will be created and will contain"},{"line_number":143,"context_line":"    3 columns:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_4f81404a","line":140,"updated":"2016-05-06 17:28:02.000000000","message":"I think we need to stick with allowing volumes to be in more than one group -- restricting that would really limit what we can build with the generic group construct in the future, since nothing would be able to overlap.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    * uuid of a group"},{"line_number":138,"context_line":"    * Alternatively, we can restrict a volume can only belong to one group."},{"line_number":139,"context_line":"      If so, we do not need this mapping table. We only need to add the"},{"line_number":140,"context_line":"      uuid of the group as a foreign key in the volumes table."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  * A new group_volumetypes_mapping table will be created and will contain"},{"line_number":143,"context_line":"    3 columns:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_bcc0c82b","line":140,"in_reply_to":"dab17558_4a600e36","updated":"2016-05-09 03:00:05.000000000","message":"Removed the alternative.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e295c53647e6debb80243eea6a9853c10710ef44","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    * uuid of a group"},{"line_number":138,"context_line":"    * Alternatively, we can restrict a volume can only belong to one group."},{"line_number":139,"context_line":"      If so, we do not need this mapping table. We only need to add the"},{"line_number":140,"context_line":"      uuid of the group as a foreign key in the volumes table."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  * A new group_volumetypes_mapping table will be created and will contain"},{"line_number":143,"context_line":"    3 columns:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_4a600e36","line":140,"in_reply_to":"dab17558_4f81404a","updated":"2016-05-06 18:11:39.000000000","message":"I agree. I added the alternative because the Etherpad notes from the summit stated that more people wanted to limit it to one group to avoid complexity.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"af1d8e939e12dd69ac36f667534b0833ceed4957","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    CG."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"* Changes will be made to make sure new group contruct can support CG."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  * In the Newton release, we should be able to create a CG using the"},{"line_number":155,"context_line":"    new API and preserve the existing behavior of the CG API."},{"line_number":156,"context_line":"  * In the Ocata release, a group will be created in both the new and old"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_0a828694","line":153,"updated":"2016-05-06 18:14:02.000000000","message":"what type of support for CG, could you please explain in brief?\nThanks!!","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"df0ebdd04bf77517ea1a7099532cf6ed657ed977","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    CG."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"* Changes will be made to make sure new group contruct can support CG."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  * In the Newton release, we should be able to create a CG using the"},{"line_number":155,"context_line":"    new API and preserve the existing behavior of the CG API."},{"line_number":156,"context_line":"  * In the Ocata release, a group will be created in both the new and old"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_6f307b57","line":153,"in_reply_to":"dab17558_0a828694","updated":"2016-05-06 21:47:22.000000000","message":"Sheel, there are notes on this in the etherpad from the summit.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"f41a08a7ddfb89795838956bd4a90cb2ec5c25f1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    CG."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"* Changes will be made to make sure new group contruct can support CG."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  * In the Newton release, we should be able to create a CG using the"},{"line_number":155,"context_line":"    new API and preserve the existing behavior of the CG API."},{"line_number":156,"context_line":"  * In the Ocata release, a group will be created in both the new and old"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_6b4ccf70","line":153,"in_reply_to":"dab17558_6f307b57","updated":"2016-05-09 07:32:13.000000000","message":"Oh thanks, will refer same.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"08b6adee75c470b9719f91fd8ebfd12cb72ad35d","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            }"},{"line_number":355,"context_line":"        }"},{"line_number":356,"context_line":"  * Set force flag to True to delete a group with volumes. Deleting an"},{"line_number":357,"context_line":"    empty group does not need the force flag to be True."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"* List Groups"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_afdd4c72","line":357,"updated":"2016-05-06 17:28:02.000000000","message":"Does it delete the volumes, or detach them from the group?  I assume the latter -- which means this should not be called \"force\".\n\n(In general, we are trying to stop adding this word everywhere as an API parameter because it\u0027s so ambiguous.)","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e295c53647e6debb80243eea6a9853c10710ef44","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            }"},{"line_number":355,"context_line":"        }"},{"line_number":356,"context_line":"  * Set force flag to True to delete a group with volumes. Deleting an"},{"line_number":357,"context_line":"    empty group does not need the force flag to be True."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"* List Groups"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_ea90e2ee","line":357,"in_reply_to":"dab17558_afdd4c72","updated":"2016-05-06 18:11:39.000000000","message":"It deletes all the volumes from the group along with the group itself. The update group command can remove a volume from a group without deleting it. We can change \"force\" to something else that is more appropriate. What do you suggest?\n\nSome backends cannot support removing a volume from the group without deleting the volume.","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9afbc791f0fff0e20d1028bcd25380a8fadae7ee","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            }"},{"line_number":355,"context_line":"        }"},{"line_number":356,"context_line":"  * Set force flag to True to delete a group with volumes. Deleting an"},{"line_number":357,"context_line":"    empty group does not need the force flag to be True."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"* List Groups"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_3c9df859","line":357,"in_reply_to":"dab17558_ea90e2ee","updated":"2016-05-09 03:00:05.000000000","message":"Changed \"force\" to \"delete-volumes\".","commit_id":"db97f0b1c9b67ee15c7ea59aaf66a7ae5e05ba46"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cdbafe093fe3121ce42e659b753972190f7d9c43","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Group replication"},{"line_number":47,"context_line":"  Group replication will not be addressed in this spec. Once a volume group"},{"line_number":48,"context_line":"  construct is available, it provides the base for adding support for group"},{"line_number":49,"context_line":"  replication."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Group snapshot"},{"line_number":52,"context_line":"  Group snapshot will not be addressed in this spec. Once a volume group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_f909d532","line":49,"updated":"2016-06-20 20:13:31.000000000","message":"I think this spec needs to cover it enough to get some idea of things like \"what happens when you enable replication for an existing group?\".","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9ac1b68862f58397fc8c2d28e21f13fda0c1ce94","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Group replication"},{"line_number":47,"context_line":"  Group replication will not be addressed in this spec. Once a volume group"},{"line_number":48,"context_line":"  construct is available, it provides the base for adding support for group"},{"line_number":49,"context_line":"  replication."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Group snapshot"},{"line_number":52,"context_line":"  Group snapshot will not be addressed in this spec. Once a volume group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_210f7b2f","line":49,"in_reply_to":"5a9d85d2_f909d532","updated":"2016-06-21 15:10:53.000000000","message":"A group needs to have group_replication_enabled or consistent_group_replication_enabled spec set to True in order to run replication functions.   Added in the updated spec.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cdbafe093fe3121ce42e659b753972190f7d9c43","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  construct is available, it provides the base for adding support for group"},{"line_number":54,"context_line":"  snapshot. We also need to change the existing Consistency Group snapshot"},{"line_number":55,"context_line":"  API to adopt the new group construct and make sure it does not break"},{"line_number":56,"context_line":"  rolling upgrades."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Proposed change"},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_74520c15","line":56,"updated":"2016-06-20 20:13:31.000000000","message":"This spec should really discuss a bit about group snapshot vs CG snapshot.  I\u0027m concerned that giving people a \"group snapshot\" operation is going to be used as if they have CGs, when the snapshots are not consistent.\n\nWill we end up with a group-snapshot command?\n\nWill we end up with a group-cgsnapshot command?  How is it different from consisgroup-create?","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9ac1b68862f58397fc8c2d28e21f13fda0c1ce94","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  construct is available, it provides the base for adding support for group"},{"line_number":54,"context_line":"  snapshot. We also need to change the existing Consistency Group snapshot"},{"line_number":55,"context_line":"  API to adopt the new group construct and make sure it does not break"},{"line_number":56,"context_line":"  rolling upgrades."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Proposed change"},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_cfacdda2","line":56,"in_reply_to":"5a9d85d2_74520c15","updated":"2016-06-21 15:10:53.000000000","message":"Added more explanation in the updated spec.\n\nExisting work flow:\n\n1. consisgroup-create creates a CG which is a group of volumes.  Some drivers call array APIs to put volumes in a group on the array so that it can take a consistent snapshot later, but other drivers don\u0027t really have an array API in this step so it is just that Cinder puts the volumes in a group in the db.  The next command cgsnapshot-create is the one that guarantees consistency.\n2. cgsnapshot-create creates a CG snapshot which is consistent group snapshot.\n\nNew work flow:\n1. group-create\n2. group-snapshot-create\nWhether the group is consistent or not depends on capabilities reported by the driver.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cdbafe093fe3121ce42e659b753972190f7d9c43","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    For example, if a driver puts all volumes in the same pool in a group, it"},{"line_number":89,"context_line":"    cannot remove a volume from the pool without deleting it. Driver needs to"},{"line_number":90,"context_line":"    report update_group_support to be True for False to indicate whether this"},{"line_number":91,"context_line":"    is supported."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_949b38c9","line":91,"updated":"2016-06-20 20:13:31.000000000","message":"Won\u0027t the driver need to do much more complex things than this?\n\nSome drivers would allow you to add a volume to a group for group snapshots, but not to a \"consistent group\" for CG snapshots.\n\nThis doesn\u0027t sound fine-grained enough, and I\u0027m not sure your proposed driver API below (update_group) gives enough info to figure this kind of thing out.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"91104256bf3f4585d197bf2fcdf87f6f30775dbd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    For example, if a driver puts all volumes in the same pool in a group, it"},{"line_number":89,"context_line":"    cannot remove a volume from the pool without deleting it. Driver needs to"},{"line_number":90,"context_line":"    report update_group_support to be True for False to indicate whether this"},{"line_number":91,"context_line":"    is supported."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_38489e2d","line":91,"in_reply_to":"5a9d85d2_03799e2f","updated":"2016-06-21 20:48:48.000000000","message":"So we could have driver figure it out by checking the group type specs?","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1dd79dc4e62fa2963c3c7dc2bb32bb6edec43074","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    For example, if a driver puts all volumes in the same pool in a group, it"},{"line_number":89,"context_line":"    cannot remove a volume from the pool without deleting it. Driver needs to"},{"line_number":90,"context_line":"    report update_group_support to be True for False to indicate whether this"},{"line_number":91,"context_line":"    is supported."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_03799e2f","line":91,"in_reply_to":"5a9d85d2_8b948ee2","updated":"2016-06-21 15:25:52.000000000","message":"I\u0027m not sure why it matters at this level which drivers can do what exactly.  The point is that \"does this driver support updating group \u003cx\u003e with volume \u003cy\u003e?\" does not have a simple boolean answer.  I think the driver API needs to reflect that, or it won\u0027t work in a reasonable way.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9ac1b68862f58397fc8c2d28e21f13fda0c1ce94","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    For example, if a driver puts all volumes in the same pool in a group, it"},{"line_number":89,"context_line":"    cannot remove a volume from the pool without deleting it. Driver needs to"},{"line_number":90,"context_line":"    report update_group_support to be True for False to indicate whether this"},{"line_number":91,"context_line":"    is supported."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Group type"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_8b948ee2","line":91,"in_reply_to":"5a9d85d2_949b38c9","updated":"2016-06-21 15:10:53.000000000","message":"I do need suggestions on how to handle this better.  Currently there are two drivers with CG support that cannot implement this.  They are both filesystem based drivers.  I\u0027ve posted question on why this function cannot be supported and was given an answer below.  So I\u0027ll leave this to driver maintainers on whether to implement this or not. \n\nhttps://review.openstack.org/#/c/327043/4/cinder/volume/drivers/hitachi/hnas_iscsi.py@939\n\nI\u0027d like to hear your thoughts on how to handle this better.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"14a842b633b81c43395da5b8e8fba86017bc7927","unresolved":false,"context_lines":[{"line_number":343,"context_line":"* Delete Group"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":346,"context_line":"  * Method: POST (We need to use \"POST\" not \"DELETE\" here because the request"},{"line_number":347,"context_line":"    body has a flag and therefore is not empty.)"},{"line_number":348,"context_line":"  * JSON schema definition for V3::"},{"line_number":349,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_0c8b65c4","line":346,"range":{"start_line":346,"start_character":12,"end_line":346,"end_character":16},"updated":"2016-06-13 09:15:15.000000000","message":"Hi, xing-yang:\n    I am not sure whether I am right. So this is just a question.\n    The POST method is not idempotent.\n    That means if we send the same POST request twice, the second request will make sense.\n    But the PUT method is idempotent, that means no matter how many times we send the same PUT request, it will not cause different outcomes.\n    Should we use PUT here for a delete action?\n\nhttp://restcookbook.com/HTTP%20Methods/idempotency/\nThanks","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"387ba39dcd115e597b39bdc9f30e7e78373878cf","unresolved":false,"context_lines":[{"line_number":343,"context_line":"* Delete Group"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":346,"context_line":"  * Method: POST (We need to use \"POST\" not \"DELETE\" here because the request"},{"line_number":347,"context_line":"    body has a flag and therefore is not empty.)"},{"line_number":348,"context_line":"  * JSON schema definition for V3::"},{"line_number":349,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_0fd0771e","line":346,"range":{"start_line":346,"start_character":12,"end_line":346,"end_character":16},"in_reply_to":"7aa08908_0c8b65c4","updated":"2016-06-13 09:32:09.000000000","message":"We use POST extensively for delete requests, and an HTTP DELETE is *not* idempotent. Not other entity delete I can see in the cinder API is idempotent either.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"c09300d6b2055f145c63b69267c7ea5c6fcc997d","unresolved":false,"context_lines":[{"line_number":343,"context_line":"* Delete Group"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"  * V3/\u003ctenant id\u003e/groups/\u003cgroup uuid\u003e/action"},{"line_number":346,"context_line":"  * Method: POST (We need to use \"POST\" not \"DELETE\" here because the request"},{"line_number":347,"context_line":"    body has a flag and therefore is not empty.)"},{"line_number":348,"context_line":"  * JSON schema definition for V3::"},{"line_number":349,"context_line":"        {"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7aa08908_123c1ec7","line":346,"range":{"start_line":346,"start_character":12,"end_line":346,"end_character":16},"in_reply_to":"7aa08908_0fd0771e","updated":"2016-06-13 09:51:29.000000000","message":"Hi Duncan Thomas:\n     Thanks for teaching me!","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d67f0ae41aa624ec6573f2b889f5bf9fbbed255e","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"* Delete Group"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"  cinder group-delete --force \u003cgroup uuid\u003e [\u003cgroup uuid\u003e ...]"},{"line_number":452,"context_line":"  The force flag is needed when a group is not empty."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"* List Group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_197821c4","line":451,"updated":"2016-06-20 20:05:48.000000000","message":"Per comments on patchset 7, we shouldn\u0027t call this force.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9ac1b68862f58397fc8c2d28e21f13fda0c1ce94","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"* Delete Group"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"  cinder group-delete --force \u003cgroup uuid\u003e [\u003cgroup uuid\u003e ...]"},{"line_number":452,"context_line":"  The force flag is needed when a group is not empty."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"* List Group"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_7d99231f","line":451,"in_reply_to":"5a9d85d2_197821c4","updated":"2016-06-21 15:10:53.000000000","message":"Oops.  Fixed it.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d67f0ae41aa624ec6573f2b889f5bf9fbbed255e","unresolved":false,"context_lines":[{"line_number":449,"context_line":"* Delete Group"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"  cinder group-delete --force \u003cgroup uuid\u003e [\u003cgroup uuid\u003e ...]"},{"line_number":452,"context_line":"  The force flag is needed when a group is not empty."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"* List Group"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_5982a995","line":452,"updated":"2016-06-20 20:05:48.000000000","message":"And the flag causes this command to do \u003cx\u003e.","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9ac1b68862f58397fc8c2d28e21f13fda0c1ce94","unresolved":false,"context_lines":[{"line_number":449,"context_line":"* Delete Group"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"  cinder group-delete --force \u003cgroup uuid\u003e [\u003cgroup uuid\u003e ...]"},{"line_number":452,"context_line":"  The force flag is needed when a group is not empty."},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"* List Group"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_1d8bbfc4","line":452,"in_reply_to":"5a9d85d2_5982a995","updated":"2016-06-21 15:10:53.000000000","message":"Done","commit_id":"2732a75ff6b4c59b55020178895ef2a939a3ef35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"639b60025964d5601468a2b1b576585459c547bc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    maintainers for some filesystem-based drivers have reported that their"},{"line_number":123,"context_line":"    drivers cannot support this because this means moving files between"},{"line_number":124,"context_line":"    filesystems. So driver maintainers need to evaluate and decide whether"},{"line_number":125,"context_line":"    this function can be supported or not."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Group type"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"5a9d85d2_c3a3164e","line":125,"updated":"2016-06-21 15:31:22.000000000","message":"What \"function\" is referred to here?\n\nThis seems to say that asking \"can the driver support adding a volume to a CG?\" is the same thing as asking \"can the driver allow us to add a volume to a snapshot group?\", which is not the case.\n\nIs the expectation that drivers will have enough group info passed in to calculate whether a group can be changed based on the current driver state and information like \"is this group replicated consistently\", \"is this group a CG\", etc?\n\nWhy would a generic \"snapshot\" group that isn\u0027t a CG or consistently-replicated need to call a driver API at all?","commit_id":"96743d990e35f5d11f08a625478277bab7808fe5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0b9e714db4e8ec27a826064803288434ab2f8311","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    maintainers for some filesystem-based drivers have reported that their"},{"line_number":123,"context_line":"    drivers cannot support this because this means moving files between"},{"line_number":124,"context_line":"    filesystems. So driver maintainers need to evaluate and decide whether"},{"line_number":125,"context_line":"    this function can be supported or not."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Group type"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_3e440773","line":125,"in_reply_to":"5a9d85d2_c3a3164e","updated":"2016-06-21 20:51:58.000000000","message":"\"function\" means \"update group\". Removed \"function\" as it is not clear.  Added a line to have driver maintainer evaluate whether backend can support it or not (like in HNAS iSCSI driver CG case) and also check group type specs to decide whether update group can be supported.","commit_id":"96743d990e35f5d11f08a625478277bab7808fe5"}]}
