)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"28c7810ce7cae3555c44f6ae87e07c3318d54f96","unresolved":false,"context_lines":[{"line_number":13,"context_line":"changes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9ed8a9591d9d1098686a0836b08d30020916b6c4"},{"line_number":16,"context_line":"Implements: https://blueprints.launchpad.net/cinder/+spec/update-attachment-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_7101e637","line":16,"updated":"2016-04-14 18:39:17.000000000","message":"This should be:\n\nImplements: blueprint update-attachment-api\n\nto be properly associated.","commit_id":"989b255e3bd0232b18e8a8c7a7143c56e2fb753b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d28842b21ff575427ffb425474e06bec15b00374","unresolved":false,"context_lines":[{"line_number":13,"context_line":"changes."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9ed8a9591d9d1098686a0836b08d30020916b6c4"},{"line_number":16,"context_line":"Implements: https://blueprints.launchpad.net/cinder/+spec/update-attachment-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_830ef338","line":16,"in_reply_to":"5a18252c_7101e637","updated":"2016-04-14 19:45:07.000000000","message":"Done","commit_id":"989b255e3bd0232b18e8a8c7a7143c56e2fb753b"}],"specs/newton/update-attachment.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Add new REST API for update_attachment"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* update_attachment"},{"line_number":58,"context_line":"** v3/{tenant_id}/volumes/{volume_id}/action"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_90e3eea3","line":55,"updated":"2016-04-19 23:38:36.000000000","message":"This is going to be microversioned right? Would be good to provide an example curl request with the microversion.","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"Add new REST API for update_attachment"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* update_attachment"},{"line_number":58,"context_line":"** v3/{tenant_id}/volumes/{volume_id}/action"},{"line_number":59,"context_line":"** method: POST"},{"line_number":60,"context_line":"** JSON schema"},{"line_number":61,"context_line":"    { \u0027connector\u0027:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_f08502cf","line":58,"updated":"2016-04-19 23:38:36.000000000","message":"Don\u0027t you need the attachment ID here somewhere?","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027ip\u0027: ip,"},{"line_number":64,"context_line":"            \u0027initiator\u0027: initiator,"},{"line_number":65,"context_line":"        },"},{"line_number":66,"context_line":"      \u0027old_host\u0027:"},{"line_number":67,"context_line":"       {"},{"line_number":68,"context_line":"           \u0027hostname\u0027: hostname"},{"line_number":69,"context_line":"       },"},{"line_number":70,"context_line":"      \u0027new_host\u0027:"},{"line_number":71,"context_line":"       {"},{"line_number":72,"context_line":"           \u0027hostname\u0027: hostname"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_502836e2","line":69,"range":{"start_line":66,"start_character":6,"end_line":69,"end_character":9},"updated":"2016-04-19 23:38:36.000000000","message":"Does Cinder have the old host in the attachment already? If so, why would Nova need to specify it again on the update?","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"       {"},{"line_number":68,"context_line":"           \u0027hostname\u0027: hostname"},{"line_number":69,"context_line":"       },"},{"line_number":70,"context_line":"      \u0027new_host\u0027:"},{"line_number":71,"context_line":"       {"},{"line_number":72,"context_line":"           \u0027hostname\u0027: hostname"},{"line_number":73,"context_line":"       }"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"** Normal http response: 200"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_704452b6","line":73,"range":{"start_line":70,"start_character":6,"end_line":73,"end_character":8},"updated":"2016-04-19 23:38:36.000000000","message":"Isn\u0027t this already in the connector dict in practice? Unless the hostname here is instance.host and the volume connector host could be different?","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"       }"},{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"** Normal http response: 200"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Security impact"},{"line_number":79,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_904c8ec9","line":76,"updated":"2016-04-19 23:38:36.000000000","message":"Does this need to cast off to the volume drivers to do anything? Or is this purely about updating the information in the Cinder DB? Aren\u0027t there any other operations in these flows where we\u0027re terminating connections to the old host and initializing connections to the new host? I\u0027d think the attachment could be updated during one of those operations, unless they are separate attachments in the Cinder DB?","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Notifications impact"},{"line_number":84,"context_line":"--------------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Logging to the event will occur."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Other end user impact"},{"line_number":89,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_d0c8c624","line":86,"updated":"2016-04-19 23:38:36.000000000","message":"Logging or sending a notification?","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Developer impact"},{"line_number":105,"context_line":"----------------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Related Nova calls will need to be aware of this change, most likely"},{"line_number":108,"context_line":"via microversions, and will need to change accordingly to use it."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Implementation"},{"line_number":111,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_30881ac5","line":108,"range":{"start_line":107,"start_character":0,"end_line":108,"end_character":65},"updated":"2016-04-19 23:38:36.000000000","message":"Before going off and adding a new Cinder API under the assumption that Nova is going to use it, I think we probably need to explain what the current issues are with not having this API today - what bugs exist and how does this solve them?  And we probably want to know how this is going to be used in Nova - arguably that\u0027s for the Nova change (spec?) that plans to use this, but it seems wherever we document that plan we should think the flow through first. Especially considering the discussions with jgriffith about changing os-initialize_connection to create the attachment.","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"586d474ffd600a8674f8385026037c9f97a8b9d1","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Documentation Impact"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_507956c7","line":139,"updated":"2016-04-19 23:38:36.000000000","message":"api-site docs changes for sure (or wherever the cinder api docs are located now, nova is moving them in tree).","commit_id":"c93464edb051d1872ad5677960d9a4dd3bf17678"}]}