)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1c59f1e6a7cab11739d53ac31963d0c90d6e0d19","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Programmatic discovery of system capabilities allows Horizon UI to"},{"line_number":15,"context_line":"enable UI widgets that exercise these capabilities."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6c3a4ed00ec05e1b51063576b65a330be13d75ce"},{"line_number":18,"context_line":"blueprint: discovering-system-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_8ae0b6ce","line":16,"updated":"2016-04-20 14:15:36.000000000","message":"APIImpact flag would make it easier to catch API WG attention. :)","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Programmatic discovery of system capabilities allows Horizon UI to"},{"line_number":15,"context_line":"enable UI widgets that exercise these capabilities."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6c3a4ed00ec05e1b51063576b65a330be13d75ce"},{"line_number":18,"context_line":"blueprint: discovering-system-capabilities"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_aca45308","line":16,"in_reply_to":"1a122d0e_8ae0b6ce","updated":"2016-04-22 05:00:40.000000000","message":"Done","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d6604613b1cd09111ecb7f4e2e1a8c6565826ef6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Programmatic discovery of system capabilities allows Horizon UI to"},{"line_number":15,"context_line":"enable UI widgets that exercise these capabilities."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"After this spec is implemented, we need to update the documentation to"},{"line_number":19,"context_line":"include the new API and the corresponding client changes. Also, the"},{"line_number":20,"context_line":"changes to Horizon config needs to be documented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dab17558_384908b8","line":17,"updated":"2016-05-11 09:30:44.000000000","message":"There is no need to add DocImpact and APIImpact flags to the specs","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"e6c6a3d32079da1fa9ea06e03d1e1c1b4f3f2ae3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Programmatic discovery of system capabilities allows Horizon UI to"},{"line_number":15,"context_line":"enable UI widgets that exercise these capabilities."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"After this spec is implemented, we need to update the documentation to"},{"line_number":19,"context_line":"include the new API and the corresponding client changes. Also, the"},{"line_number":20,"context_line":"changes to Horizon config needs to be documented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bab6814e_e1cc228b","line":17,"in_reply_to":"dab17558_384908b8","updated":"2016-05-26 07:57:38.000000000","message":"Removed DocImpact. But Michal had suggested to add APIImpact flag so it would be easier to get API WG attention.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"}],"specs/newton/discovering-system-capabilities.rst":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1c59f1e6a7cab11739d53ac31963d0c90d6e0d19","unresolved":false,"context_lines":[{"line_number":69,"context_line":"process. No longer will the operator need to set the \"enable_backup\" in"},{"line_number":70,"context_line":"Horizon config; Horizon will programmatically get the status using the"},{"line_number":71,"context_line":"proposed API."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_b7b87b76","line":72,"updated":"2016-04-20 14:15:36.000000000","message":"If you\u0027re looking for other use cases - similar thing goes for CGs.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3c4f252d3795fb9200a491ddc6f7f4d4d146223","unresolved":false,"context_lines":[{"line_number":69,"context_line":"process. No longer will the operator need to set the \"enable_backup\" in"},{"line_number":70,"context_line":"Horizon config; Horizon will programmatically get the status using the"},{"line_number":71,"context_line":"proposed API."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_e3333ef4","line":72,"in_reply_to":"1a122d0e_b7b87b76","updated":"2016-04-20 22:23:09.000000000","message":"Yes, this could be generalized to a number of use cases.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":69,"context_line":"process. No longer will the operator need to set the \"enable_backup\" in"},{"line_number":70,"context_line":"Horizon config; Horizon will programmatically get the status using the"},{"line_number":71,"context_line":"proposed API."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_f10bc429","line":72,"in_reply_to":"1a122d0e_e3333ef4","updated":"2016-04-22 05:00:40.000000000","message":"Thanks, I have noted this info in the spec.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A programmatic way of knowing the capabilities of a cinder deployment seems"},{"line_number":77,"context_line":"like a general problem. Volume backup is one capability but there could be"},{"line_number":78,"context_line":"more in the future. So, we propose adding a new, public Cinder extension API"},{"line_number":79,"context_line":"which returns the list of all \"system capabilities\". To avoid confusion with"},{"line_number":80,"context_line":"the existing unrelated \"volume capabilities\" extension API [6]_, we could name"},{"line_number":81,"context_line":"it \"available system services\". This will return only \"volume backup\" for now"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_db957033","line":78,"range":{"start_line":78,"start_character":63,"end_line":78,"end_character":72},"updated":"2016-04-20 10:32:17.000000000","message":"We decided to get rid of extension APIs. This would be a new core API.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"A programmatic way of knowing the capabilities of a cinder deployment seems"},{"line_number":77,"context_line":"like a general problem. Volume backup is one capability but there could be"},{"line_number":78,"context_line":"more in the future. So, we propose adding a new, public Cinder extension API"},{"line_number":79,"context_line":"which returns the list of all \"system capabilities\". To avoid confusion with"},{"line_number":80,"context_line":"the existing unrelated \"volume capabilities\" extension API [6]_, we could name"},{"line_number":81,"context_line":"it \"available system services\". This will return only \"volume backup\" for now"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_3106dc20","line":78,"range":{"start_line":78,"start_character":63,"end_line":78,"end_character":72},"in_reply_to":"1a122d0e_db957033","updated":"2016-04-22 05:00:40.000000000","message":"Sure, I have changed this to core API everywhere in the spec.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1c59f1e6a7cab11739d53ac31963d0c90d6e0d19","unresolved":false,"context_lines":[{"line_number":78,"context_line":"more in the future. So, we propose adding a new, public Cinder extension API"},{"line_number":79,"context_line":"which returns the list of all \"system capabilities\". To avoid confusion with"},{"line_number":80,"context_line":"the existing unrelated \"volume capabilities\" extension API [6]_, we could name"},{"line_number":81,"context_line":"it \"available system services\". This will return only \"volume backup\" for now"},{"line_number":82,"context_line":"but can be augmented as new capabilities are added to Cinder. Both admin and"},{"line_number":83,"context_line":"non-admin will be able to call this API."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_b76fdbfa","line":81,"range":{"start_line":81,"start_character":21,"end_line":81,"end_character":29},"updated":"2016-04-20 14:15:36.000000000","message":"Maybe features? Services can be confused with cinder services instances like c-sch.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":78,"context_line":"more in the future. So, we propose adding a new, public Cinder extension API"},{"line_number":79,"context_line":"which returns the list of all \"system capabilities\". To avoid confusion with"},{"line_number":80,"context_line":"the existing unrelated \"volume capabilities\" extension API [6]_, we could name"},{"line_number":81,"context_line":"it \"available system services\". This will return only \"volume backup\" for now"},{"line_number":82,"context_line":"but can be augmented as new capabilities are added to Cinder. Both admin and"},{"line_number":83,"context_line":"non-admin will be able to call this API."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_2c904395","line":81,"range":{"start_line":81,"start_character":21,"end_line":81,"end_character":29},"in_reply_to":"1a122d0e_63560e07","updated":"2016-04-22 05:00:40.000000000","message":"Given that we are defining a system level API, I decided to stick with the well know term \"capability\".","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b3c4f252d3795fb9200a491ddc6f7f4d4d146223","unresolved":false,"context_lines":[{"line_number":78,"context_line":"more in the future. So, we propose adding a new, public Cinder extension API"},{"line_number":79,"context_line":"which returns the list of all \"system capabilities\". To avoid confusion with"},{"line_number":80,"context_line":"the existing unrelated \"volume capabilities\" extension API [6]_, we could name"},{"line_number":81,"context_line":"it \"available system services\". This will return only \"volume backup\" for now"},{"line_number":82,"context_line":"but can be augmented as new capabilities are added to Cinder. Both admin and"},{"line_number":83,"context_line":"non-admin will be able to call this API."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_63560e07","line":81,"range":{"start_line":81,"start_character":21,"end_line":81,"end_character":29},"in_reply_to":"1a122d0e_b76fdbfa","updated":"2016-04-20 22:23:09.000000000","message":"++","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Make the existing os-services extension public: It is probably not a good"},{"line_number":94,"context_line":"  idea to expose status of backend services to any caller."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Split the existing os-services extension API into public and private halves,"},{"line_number":97,"context_line":"  with the public part exposing limited information."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_3b0aa479","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":58},"updated":"2016-04-20 10:32:17.000000000","message":"This exposes private cloud internals to the tenant. That\u0027s a no-go.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"* Make the existing os-services extension public: It is probably not a good"},{"line_number":94,"context_line":"  idea to expose status of backend services to any caller."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"* Split the existing os-services extension API into public and private halves,"},{"line_number":97,"context_line":"  with the public part exposing limited information."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_0c3107ed","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":58},"in_reply_to":"1a122d0e_3b0aa479","updated":"2016-04-22 05:00:40.000000000","message":"Noted this point in the spec.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  For this to reflect the state of available services, the operator needs to"},{"line_number":116,"context_line":"  prune cinder.conf so that it lists only those extensions that are actually"},{"line_number":117,"context_line":"  supported. As explained in [2]_, there is no easy way to do that. Also, we"},{"line_number":118,"context_line":"  will just be replacing one manual operation by another."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Data model impact"},{"line_number":121,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_7bfa5c76","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":57},"updated":"2016-04-20 10:32:17.000000000","message":"Not a good idea since that breaks the existing semantics - many deployments have the API extension enabled (since it is by default) without the service actually being running, so the check return value would mean different things on different systems.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":115,"context_line":"  For this to reflect the state of available services, the operator needs to"},{"line_number":116,"context_line":"  prune cinder.conf so that it lists only those extensions that are actually"},{"line_number":117,"context_line":"  supported. As explained in [2]_, there is no easy way to do that. Also, we"},{"line_number":118,"context_line":"  will just be replacing one manual operation by another."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Data model impact"},{"line_number":121,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_cc3d4fbd","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":57},"in_reply_to":"1a122d0e_7bfa5c76","updated":"2016-04-22 05:00:40.000000000","message":"Noted this point in the spec.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Other end user impact"},{"line_number":164,"context_line":"---------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"None. This change is transparent to the user. Only the operator is affected."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_1ba2484b","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":76},"updated":"2016-04-20 10:32:17.000000000","message":"User can use this in their own scripts or frontends if desired, for similar reasons to why horizon uses it.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Other end user impact"},{"line_number":164,"context_line":"---------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"None. This change is transparent to the user. Only the operator is affected."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_6c735bb5","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":76},"in_reply_to":"1a122d0e_1ba2484b","updated":"2016-04-22 05:00:40.000000000","message":"Thanks for pointing, noted this in the spec.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"None as it is a new extension API. Also, as its implementation will mimic the"},{"line_number":172,"context_line":"existing os-services implementation, the performance of this API should be be"},{"line_number":173,"context_line":"along expected lines."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_f64e836d","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":33},"updated":"2016-04-20 10:32:17.000000000","message":"That statement makes no sense. I can write any number of extension APIs with any performance impact you like.\n\nThe rest of the impact is correct though - it mimics an existing api and only does a simple DB lookup, so there should be no performance impact.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Performance Impact"},{"line_number":169,"context_line":"------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"None as it is a new extension API. Also, as its implementation will mimic the"},{"line_number":172,"context_line":"existing os-services implementation, the performance of this API should be be"},{"line_number":173,"context_line":"along expected lines."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_cc642fe7","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":33},"in_reply_to":"1a122d0e_f64e836d","updated":"2016-04-22 05:00:40.000000000","message":"What I intended, but didn\u0027t put it across well, was that existing code paths won\u0027t change since this is a \"new API\". Rephrased.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"58c8af98db53fe88e53f80a71679ea6c303fbec0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"---------------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Operator no longer has to manually set \"enable_backup\" in Horizon config"},{"line_number":179,"context_line":"settings file."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Developer impact"},{"line_number":182,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_1b152848","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":14},"updated":"2016-04-20 10:32:17.000000000","message":"I guess the back-compatability story for that option is out of the scope of cinder","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1c59f1e6a7cab11739d53ac31963d0c90d6e0d19","unresolved":false,"context_lines":[{"line_number":176,"context_line":"---------------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Operator no longer has to manually set \"enable_backup\" in Horizon config"},{"line_number":179,"context_line":"settings file."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Developer impact"},{"line_number":182,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_aa7012a5","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":14},"in_reply_to":"1a122d0e_1b152848","updated":"2016-04-20 14:15:36.000000000","message":"IMO it\u0027s Horizon\u0027s job to solve that. BTW can a newer Horizon work with older Cinder or vice versa…?","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":176,"context_line":"---------------------"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Operator no longer has to manually set \"enable_backup\" in Horizon config"},{"line_number":179,"context_line":"settings file."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Developer impact"},{"line_number":182,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_2c6203d9","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":14},"in_reply_to":"1a122d0e_aa7012a5","updated":"2016-04-22 05:00:40.000000000","message":"Noted this point in the spec.\n\nMichal, you bring up a good point. I would like to know the answer to it as well.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1c59f1e6a7cab11739d53ac31963d0c90d6e0d19","unresolved":false,"context_lines":[{"line_number":196,"context_line":"Work Items"},{"line_number":197,"context_line":"----------"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* Write API extension"},{"line_number":200,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":201,"context_line":"* Add test cases"},{"line_number":202,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_6aef1a1e","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":21},"updated":"2016-04-20 14:15:36.000000000","message":"I think you\u0027ll need to write a new core API microversion instead of an extension as explained by Duncan.","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"321b8db39662d78d730d196872f12672de83ce37","unresolved":false,"context_lines":[{"line_number":196,"context_line":"Work Items"},{"line_number":197,"context_line":"----------"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* Write API extension"},{"line_number":200,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":201,"context_line":"* Add test cases"},{"line_number":202,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_0c5f470f","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":21},"in_reply_to":"1a122d0e_6aef1a1e","updated":"2016-04-22 05:00:40.000000000","message":"Done","commit_id":"a63838ef09c683e08aa49a962e670947811dc85d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a9c9902e6b17a334abfb27bc69aa78b6a44f3e86","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The solution proposed in this spec allows building a dynamic, self-configuring"},{"line_number":69,"context_line":"Horizon UI. This unburdens the operator from manually configuring Hoizon and"},{"line_number":70,"context_line":"constantly keeping it in sync with the capabilities of the Cinder deployment."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"This solution can be immediately applied to solve the volume backup enable"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_8f8184fe","line":69,"range":{"start_line":69,"start_character":66,"end_line":69,"end_character":72},"updated":"2016-04-22 09:11:18.000000000","message":"Horizon","commit_id":"b063e9346a45e1ece7437d336edb9a6e27a52f0b"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"478cc43dab8f1b8a6a6ab1a0667268dc7c03916f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The solution proposed in this spec allows building a dynamic, self-configuring"},{"line_number":69,"context_line":"Horizon UI. This unburdens the operator from manually configuring Hoizon and"},{"line_number":70,"context_line":"constantly keeping it in sync with the capabilities of the Cinder deployment."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"This solution can be immediately applied to solve the volume backup enable"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_a420cb4a","line":69,"range":{"start_line":69,"start_character":66,"end_line":69,"end_character":72},"in_reply_to":"1a122d0e_8f8184fe","updated":"2016-04-22 17:58:45.000000000","message":"Done","commit_id":"b063e9346a45e1ece7437d336edb9a6e27a52f0b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a9c9902e6b17a334abfb27bc69aa78b6a44f3e86","unresolved":false,"context_lines":[{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"},{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this extension would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_4fb5acce","line":95,"range":{"start_line":95,"start_character":36,"end_line":95,"end_character":45},"updated":"2016-04-22 09:11:18.000000000","message":"This shouldn\u0027t be an API extension, but new core API in v3 dir.","commit_id":"b063e9346a45e1ece7437d336edb9a6e27a52f0b"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"478cc43dab8f1b8a6a6ab1a0667268dc7c03916f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"},{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this extension would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_44b737f5","line":95,"range":{"start_line":95,"start_character":36,"end_line":95,"end_character":45},"in_reply_to":"1a122d0e_4fb5acce","updated":"2016-04-22 17:58:45.000000000","message":"Thanks for pointing, thought I had fixed it in all places :)","commit_id":"b063e9346a45e1ece7437d336edb9a6e27a52f0b"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0eacf2d6cb6a34f941ae6cf02d8f6f112b6c4084","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"A new, public Cinder core API that returns the set of all"},{"line_number":87,"context_line":"\"system capabilities\", namely optional block storage functionalities supported"},{"line_number":88,"context_line":"by a Cinder deployment. This should not be confused with the existing,"},{"line_number":89,"context_line":"unrelated \"volume capabilities\" extension API [6]_."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_e7f2c599","line":89,"range":{"start_line":88,"start_character":24,"end_line":89,"end_character":51},"updated":"2016-04-22 18:38:17.000000000","message":"They are going to probably have some overlap though, right? If, for example, we want to dynamically show horizon ui widgets for creating consistency groups or whether a volume can or can\u0027t be added to one the information from that other API is going to be important, or we have to duplicate some of it in this new one. Same thing for stuff like replication and (hopefully not many) new features that aren\u0027t really supported by all deployment scenarios.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"c4d50345c3af6e449e8e24f3b94e156b5dd299f9","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"A new, public Cinder core API that returns the set of all"},{"line_number":87,"context_line":"\"system capabilities\", namely optional block storage functionalities supported"},{"line_number":88,"context_line":"by a Cinder deployment. This should not be confused with the existing,"},{"line_number":89,"context_line":"unrelated \"volume capabilities\" extension API [6]_."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a9d85d2_459f5250","line":89,"range":{"start_line":88,"start_character":24,"end_line":89,"end_character":51},"in_reply_to":"1a122d0e_7a135665","updated":"2016-06-21 02:00:34.000000000","message":"Michal, PTAL at the revamped BP, especially the \"Proposed change\" section. It should address these concerns.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a01591ae299ba0c75bc43428e9aac84729cb199e","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"A new, public Cinder core API that returns the set of all"},{"line_number":87,"context_line":"\"system capabilities\", namely optional block storage functionalities supported"},{"line_number":88,"context_line":"by a Cinder deployment. This should not be confused with the existing,"},{"line_number":89,"context_line":"unrelated \"volume capabilities\" extension API [6]_."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_7a135665","line":89,"range":{"start_line":88,"start_character":24,"end_line":89,"end_character":51},"in_reply_to":"1a122d0e_e7f2c599","updated":"2016-04-28 20:38:47.000000000","message":"It _may_ be a sane idea to squeeze that into existing backend capabilities API. In backups case for now it would return same result for all of the backends, but I can totally imagine that changing in the future to let administrator decides that some volume types are non-backupable.\n\nBut wait, volume types list and backends list may differ, so the abstraction layer here isn\u0027t really perfect…","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"1fe9a02b72123fd00e08e22bc067f93847184452","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"If this API is successful, it could even be replicated across other OpenStack"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_70db497e","line":97,"range":{"start_line":97,"start_character":32,"end_line":97,"end_character":40},"updated":"2016-04-30 21:44:19.000000000","message":"I guess it will better to word this as \"services table from cinder database\"","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"c4d50345c3af6e449e8e24f3b94e156b5dd299f9","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"If this API is successful, it could even be replicated across other OpenStack"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a9d85d2_e5b63edb","line":97,"range":{"start_line":97,"start_character":32,"end_line":97,"end_character":40},"in_reply_to":"1a122d0e_70db497e","updated":"2016-06-21 02:00:34.000000000","message":"Done","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"f23ae81dd077e9035bece77c56c696d509479c82","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_d601746c","line":139,"updated":"2016-05-23 20:01:18.000000000","message":"I think it could instead be cool to have an api that basically returns the actions the user can perform based on the policies. So using the policy.json the api will calculate what the requesting user can do and return that. This will require that policies are setup to correctly represent what actions can be performed, as they should be anyway.\n\nThis would be less complex than adding a new API where we have to defined every capability over again, and maybe only some users can do backups, etc.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"c4d50345c3af6e449e8e24f3b94e156b5dd299f9","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a9d85d2_b709112f","line":139,"in_reply_to":"7aa08908_6a098295","updated":"2016-06-21 02:00:34.000000000","message":"Alex, PTAL at the revamped BP, especially the \"Proposed change\" section. It specifically addresses the role of policy.json file.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"b76b3eb4c40e304c91531f4f53a3f6cafe38492a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_11a71b50","line":139,"in_reply_to":"9abb7d3a_0a2bbc83","updated":"2016-05-31 01:54:44.000000000","message":"Are you suggesting that the proposed API include both the dynamic status of the service and the policies while computing capabilities OR are you saying that the API should rely solely on the policies under the assumption that the admin sets it up appropriately?\n\nIf the latter, is it good to couple two independent concepts of authorization and service availability? Even if we did, how do we disseminate the requirement to keep the policy.json file in sync with capabilities? At what time do we get rid of the current manual config in Horizon and depend on the policy-based API?\n\nI feel that a capability API that incorporated both the dynamic service status and the static policy information is the right approach. It keeps independent concepts independent, does not require manual effort on the operator and provides immediate benefits without a wait time.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"7778bed5ff49f04a8cbd7e2295407300362ebca2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_6a098295","line":139,"in_reply_to":"9abb7d3a_11a71b50","updated":"2016-06-06 14:52:37.000000000","message":"As I see it, the two concepts are exactly the same. Policies dictate what a user can do and that\u0027s what we should use to discriminate what Horizon shows the user. The policy.json config should always be accurate and if it isn\u0027t then that\u0027s a problem. Keeping that configured correctly isn\u0027t any *extra* effort for the operator.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"e6c6a3d32079da1fa9ea06e03d1e1c1b4f3f2ae3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_7b815a4d","line":139,"in_reply_to":"bab6814e_764d28c4","updated":"2016-05-26 07:57:38.000000000","message":"Alex, AFAIU, the policies are static. They tell us what APIs can be called by a user but not whether those APIs are actually implemented by the system. An admin could decide to not support backup and thereby turn down the backup service. In this case, the policies will still say that user X can call the backup API but calling it will fail since it is not supported underneath.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"aef35e60683a8288d69b3bbf41fdfd20f836a7aa","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9abb7d3a_0a2bbc83","line":139,"in_reply_to":"bab6814e_7b815a4d","updated":"2016-05-27 14:21:08.000000000","message":"Yes that\u0027s true but it can go the other way as well. Just having a service doesn\u0027t mean the user can do it. Policies also have much more granularity. I think if I dont have a backup service, I should probably set my backup policies so that nobody can perform those actions.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"124c86be460469758562280201d67f65332cc728","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  deployments have the API extensions enabled (as it comes by default) without"},{"line_number":137,"context_line":"  the service being actually running. So the check return value would mean"},{"line_number":138,"context_line":"  different things on different systems."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Data model impact"},{"line_number":141,"context_line":"-----------------"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_764d28c4","line":139,"in_reply_to":"bab6814e_d601746c","updated":"2016-05-23 20:02:19.000000000","message":"It would also be more accurate. Just having a running backup service does not mean the user can create backups. This would also be easier to extend to other openstack services in a consistent manner.","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0eacf2d6cb6a34f941ae6cf02d8f6f112b6c4084","unresolved":false,"context_lines":[{"line_number":147,"context_line":"REST API impact"},{"line_number":148,"context_line":"---------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* ``GET /v2/{tenant id}/os-system-capabilities``"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  Returns the set of capabilities of the underlying block storage deployment."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a122d0e_67351545","line":150,"range":{"start_line":150,"start_character":9,"end_line":150,"end_character":11},"updated":"2016-04-22 18:38:17.000000000","message":"v3, now I think","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"c4d50345c3af6e449e8e24f3b94e156b5dd299f9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"REST API impact"},{"line_number":148,"context_line":"---------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* ``GET /v2/{tenant id}/os-system-capabilities``"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  Returns the set of capabilities of the underlying block storage deployment."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a9d85d2_6527ee12","line":150,"range":{"start_line":150,"start_character":9,"end_line":150,"end_character":11},"in_reply_to":"1a122d0e_67351545","updated":"2016-06-21 02:00:34.000000000","message":"Done","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d6604613b1cd09111ecb7f4e2e1a8c6565826ef6","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Work Items"},{"line_number":225,"context_line":"----------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Implement the proposed public core API"},{"line_number":228,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":229,"context_line":"* Add test cases"},{"line_number":230,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":6,"id":"dab17558_382aa890","line":227,"updated":"2016-05-11 09:30:44.000000000","message":"It should me implemented as a new microversion","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"c4d50345c3af6e449e8e24f3b94e156b5dd299f9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Work Items"},{"line_number":225,"context_line":"----------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Implement the proposed public core API"},{"line_number":228,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":229,"context_line":"* Add test cases"},{"line_number":230,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a9d85d2_4522b202","line":227,"in_reply_to":"bab6814e_618e722f","updated":"2016-06-21 02:00:34.000000000","message":"Done","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"e6c6a3d32079da1fa9ea06e03d1e1c1b4f3f2ae3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Work Items"},{"line_number":225,"context_line":"----------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Implement the proposed public core API"},{"line_number":228,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":229,"context_line":"* Add test cases"},{"line_number":230,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_618e722f","line":227,"in_reply_to":"dab17558_382aa890","updated":"2016-05-26 07:57:38.000000000","message":"Should it be a new microversion or a new v3 API as suggested by Patrick earlier?","commit_id":"7b0cf37b317a7916e2b057fc0f622d30d8ca96b4"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2180471fd8c9d7761fea8abbc5d7bdd2404ce18","unresolved":false,"context_lines":[{"line_number":147,"context_line":"REST API impact"},{"line_number":148,"context_line":"---------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* ``GET /v2/{tenant id}/os-system-capabilities``"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  Returns the set of capabilities of the underlying block storage deployment."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_ab1494e8","line":150,"updated":"2016-05-26 18:15:40.000000000","message":"Patrick is right in his PS#6 comment that this should be on the /v3 endpoint.\nAnd Ivan is right that this should have a new microversion.\nBoth are correct.","commit_id":"de49924c49452ab2810f6ed9f4b0902b5a344437"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"691ba681f8ca29b757ac67978509b046ba069a5b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"REST API impact"},{"line_number":148,"context_line":"---------------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* ``GET /v2/{tenant id}/os-system-capabilities``"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  Returns the set of capabilities of the underlying block storage deployment."},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_55198e87","line":150,"in_reply_to":"bab6814e_ab1494e8","updated":"2016-05-31 01:54:22.000000000","message":"Done","commit_id":"de49924c49452ab2810f6ed9f4b0902b5a344437"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"e2180471fd8c9d7761fea8abbc5d7bdd2404ce18","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Work Items"},{"line_number":225,"context_line":"----------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Implement the proposed public core API"},{"line_number":228,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":229,"context_line":"* Add test cases"},{"line_number":230,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bab6814e_8be8b0e3","line":227,"updated":"2016-05-26 18:15:40.000000000","message":"Patrick is right in his PS#6 comment that this should be on the /v3 endpoint.\nAnd Ivan is right that this should have a new microversion.\nBoth are correct.","commit_id":"de49924c49452ab2810f6ed9f4b0902b5a344437"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"691ba681f8ca29b757ac67978509b046ba069a5b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"Work Items"},{"line_number":225,"context_line":"----------"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"* Implement the proposed public core API"},{"line_number":228,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":229,"context_line":"* Add test cases"},{"line_number":230,"context_line":"* Update Horizon to use this new API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9abb7d3a_351cca76","line":227,"in_reply_to":"bab6814e_8be8b0e3","updated":"2016-05-31 01:54:22.000000000","message":"Done","commit_id":"de49924c49452ab2810f6ed9f4b0902b5a344437"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"59871d51043005cceccf024651d79ed04cc38b61","unresolved":false,"context_lines":[{"line_number":34,"context_line":"server side does not have any restrictions on who can invoke it as evidenced"},{"line_number":35,"context_line":"by the following policy [4]_ in etc/cinder/policy.json::"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\"backup:create\" : \"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The volume backup API is implemented on the server side by the cinder-backup"},{"line_number":40,"context_line":"service. This service is absent when the cinder deployment does not support"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_1d564a29","line":37,"updated":"2016-06-06 15:07:59.000000000","message":"This is the default we ship with, but the deployer may choose to edit this policy to meet their needs. The check would need to take into account whether this is allowed through policy or not.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"server side does not have any restrictions on who can invoke it as evidenced"},{"line_number":35,"context_line":"by the following policy [4]_ in etc/cinder/policy.json::"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\"backup:create\" : \"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"The volume backup API is implemented on the server side by the cinder-backup"},{"line_number":40,"context_line":"service. This service is absent when the cinder deployment does not support"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_779b29ca","line":37,"in_reply_to":"7aa08908_1d564a29","updated":"2016-06-21 02:07:46.000000000","message":"Ack. PTAL at the BP, especially the \"Proposed change\" section. It has been revamped.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"afe58126d154ed9de6c5958bf67f6fe68b2c8fea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"status problem in Horizon. No longer will the operator need to set the"},{"line_number":74,"context_line":"\"enable_backup\" in Horizon config; Horizon will programmatically get the"},{"line_number":75,"context_line":"status using the proposed API. Another capability which can similarly gain"},{"line_number":76,"context_line":"is the consistency group feature (which is only supported by certain volume"},{"line_number":77,"context_line":"backends)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The proposed API can also be used in custom UIs or user scripts for the same"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_df4d363f","line":76,"updated":"2016-06-14 15:10:07.000000000","message":"This applies to replication as well, though Cheesecake is admin only API.  So the Horizon GUI options should only be visible to the admin\u0027s if replication is supported by the backends.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"status problem in Horizon. No longer will the operator need to set the"},{"line_number":74,"context_line":"\"enable_backup\" in Horizon config; Horizon will programmatically get the"},{"line_number":75,"context_line":"status using the proposed API. Another capability which can similarly gain"},{"line_number":76,"context_line":"is the consistency group feature (which is only supported by certain volume"},{"line_number":77,"context_line":"backends)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"The proposed API can also be used in custom UIs or user scripts for the same"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_25de863f","line":76,"in_reply_to":"7aa08908_df4d363f","updated":"2016-06-21 02:07:46.000000000","message":"Included replication in the list of features that benefit from capabilities API.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"afe58126d154ed9de6c5958bf67f6fe68b2c8fea","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"},{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_7fffe265","line":93,"updated":"2016-06-14 15:10:07.000000000","message":"If a specific feature is for admin only, i.e., Cheesecake, then non-admin should not be able to see it.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8ba60599be9544d36072180b628c795ce9c22fc2","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"},{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_e2282088","line":93,"in_reply_to":"7aa08908_7fffe265","updated":"2016-06-15 13:00:13.000000000","message":"IMO it should depend on the policy settings. If someone has a use case to expose replication to normal users - why block him?","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"This will return only \"volume backup\" for now but can be augmented as new"},{"line_number":92,"context_line":"capabilities are added to Cinder. Both admin and non-admin will be able to"},{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_176aa580","line":93,"in_reply_to":"7aa08908_e2282088","updated":"2016-06-21 02:07:46.000000000","message":"PTAL at the revamped BP, especially the \"Proposed change\" section. It should address all these concerns.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"afe58126d154ed9de6c5958bf67f6fe68b2c8fea","unresolved":false,"context_lines":[{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_9f58ce8b","line":96,"updated":"2016-06-14 15:10:07.000000000","message":"Given that we have decided to move extension APIs to core (we discussed at Cinder IRC meeting), this new API should be implemented as a core API under api/v3, rather than as os-services extension.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"call this API."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"For now, the implementation of this core API would be similar to the"},{"line_number":96,"context_line":"os-services extension. It will check if the cinder-backup service is enabled"},{"line_number":97,"context_line":"or not by checking the services database and if so return \"volume backup\" in"},{"line_number":98,"context_line":"the response."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_d71dbd10","line":96,"in_reply_to":"7aa08908_9f58ce8b","updated":"2016-06-21 02:07:46.000000000","message":"Yes Xing-Yang, proposed API will be a core and not an extension API.\n\nI was referring to the existing os-services extension API, not proposing a new extension API.","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"afe58126d154ed9de6c5958bf67f6fe68b2c8fea","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"If this API is successful, it could even be replicated across other OpenStack"},{"line_number":101,"context_line":"projects as the problem it tries to solve is generic and just as applicable"},{"line_number":102,"context_line":"to these other projects."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_ffa3d240","line":102,"updated":"2016-06-14 15:10:07.000000000","message":"Are there any cross-project specs or meetings discussing about this subject?  API WG?","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"If this API is successful, it could even be replicated across other OpenStack"},{"line_number":101,"context_line":"projects as the problem it tries to solve is generic and just as applicable"},{"line_number":102,"context_line":"to these other projects."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Alternatives"},{"line_number":105,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_d792dd56","line":102,"in_reply_to":"7aa08908_ffa3d240","updated":"2016-06-21 02:07:46.000000000","message":"Alex was roped in for exactly this. I don\u0027t know what cross-project discussions happend, but perhaps Alex can chime in.\n\nI do know that Sean Dague from Nova started a discussion on the mailing thread few months ago on something similar around capabilities for Nova. http://lists.openstack.org/pipermail/openstack-dev/2016-March/090927.html","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"59871d51043005cceccf024651d79ed04cc38b61","unresolved":false,"context_lines":[{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"This change is transparent to the user although the user can use this API in"},{"line_number":189,"context_line":"a similar way as Horizon for custom UIs or management scrips."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Performance Impact"},{"line_number":192,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7aa08908_dd8682b8","line":189,"range":{"start_line":189,"start_character":54,"end_line":189,"end_character":60},"updated":"2016-06-06 15:07:59.000000000","message":"scripts","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"32a1e02e60a38fc02a099c19fbf52738b1397fdd","unresolved":false,"context_lines":[{"line_number":186,"context_line":"---------------------"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"This change is transparent to the user although the user can use this API in"},{"line_number":189,"context_line":"a similar way as Horizon for custom UIs or management scrips."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"Performance Impact"},{"line_number":192,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a9d85d2_f796f992","line":189,"range":{"start_line":189,"start_character":54,"end_line":189,"end_character":60},"in_reply_to":"7aa08908_dd8682b8","updated":"2016-06-21 02:07:46.000000000","message":"Done","commit_id":"87f497d8b86d6b39495aee8fd5bae3e548f4fcd8"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1bd00e6cd9d56ae1378be69e54077edcbe185c4b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This blueprint grew out of the design discussion in [1]_ and [2]_ for the bug"},{"line_number":26,"context_line":"#1334856 [3]_ filed by jgriffith."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Problem description"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Horizon allows users to create volume backups via the UI, if the underlying"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_8403f341","line":28,"updated":"2016-06-21 07:50:55.000000000","message":"Would be nice if you mention orchestration here too:\n\nThere\u0027s another angle to this problem, namely orchestration and interoperability of orchestration templates between clouds.\n\nExample: in Heat, we have \"delete_policy: snapshot\" available for volume resources, enabling which in the template makes a backup of the volume upon deletion of the corresponding volume resource in the template. Also, we have \"stack snapshot\" actions that would also use cinderclient.backups API. As backup service is AFAIU optional and currently there is no way to deduce with unprivileged user-scoped token whether such service exists, Heat can not forbid creating such resources in the case the backup service is not available, which might lead to late failures during delete/snapshot of the stack.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This blueprint grew out of the design discussion in [1]_ and [2]_ for the bug"},{"line_number":26,"context_line":"#1334856 [3]_ filed by jgriffith."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Problem description"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Horizon allows users to create volume backups via the UI, if the underlying"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_6d6ba7b7","line":28,"in_reply_to":"5a9d85d2_8403f341","updated":"2016-06-27 21:42:02.000000000","message":"Thank you for letting me know of this problem, as it occurs in a non-UI domain. Included it in the BP.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"status using the proposed API."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":72,"context_line":"replication features which are only supported by certain volume types. Note"},{"line_number":73,"context_line":"that these two features will be listed by a different capabilities API than"},{"line_number":74,"context_line":"the one that lists the backup feature. See details below."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_82291a8c","line":72,"range":{"start_line":72,"start_character":49,"end_line":72,"end_character":70},"updated":"2016-06-21 12:02:53.000000000","message":"Actually it\u0027s more like \"certain volume backends\" and normally volume backends are more or less tied with volume types.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"status using the proposed API."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":72,"context_line":"replication features which are only supported by certain volume types. Note"},{"line_number":73,"context_line":"that these two features will be listed by a different capabilities API than"},{"line_number":74,"context_line":"the one that lists the backup feature. See details below."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_0da7830b","line":72,"range":{"start_line":72,"start_character":49,"end_line":72,"end_character":70},"in_reply_to":"5a9d85d2_82291a8c","updated":"2016-06-27 21:42:02.000000000","message":"Done. Clarified the text.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"b861a4a7f2627033ab3a92646fc1d934657e496c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"status using the proposed API."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":72,"context_line":"replication features which are only supported by certain volume types. Note"},{"line_number":73,"context_line":"that these two features will be listed by a different capabilities API than"},{"line_number":74,"context_line":"the one that lists the backup feature. See details below."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_ecb19ce1","line":72,"range":{"start_line":72,"start_character":49,"end_line":72,"end_character":70},"in_reply_to":"5a9d85d2_82291a8c","updated":"2016-06-30 07:57:16.000000000","message":"From the API consumer\u0027s point of view, it is per volume type.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"we need to ask \"Does the volume type xyz have the replication capability?\"."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":96,"context_line":"be required only a small number of resource."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"It is not possible to avoid multiple levels of capability APIs. The"},{"line_number":99,"context_line":"lower level capability APIs require input (the resource type) which is not"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_a25ed6e6","line":96,"range":{"start_line":96,"start_character":35,"end_line":96,"end_character":43},"updated":"2016-06-21 12:02:53.000000000","message":"resources","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":93,"context_line":"we need to ask \"Does the volume type xyz have the replication capability?\"."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":96,"context_line":"be required only a small number of resource."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"It is not possible to avoid multiple levels of capability APIs. The"},{"line_number":99,"context_line":"lower level capability APIs require input (the resource type) which is not"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_4d94eb89","line":96,"range":{"start_line":96,"start_character":35,"end_line":96,"end_character":43},"in_reply_to":"5a9d85d2_a25ed6e6","updated":"2016-06-27 21:42:02.000000000","message":"Done","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"whether a particular deployment/resource implements a particular capability"},{"line_number":119,"context_line":"varies by the capability itself. For the backup capability, it could be the"},{"line_number":120,"context_line":"presence of the cinder-backup service. For consistency group and replication"},{"line_number":121,"context_line":"features, it could be statically set when the volume type is created."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"It is not possible to implement the capabilities API based solely on the info"},{"line_number":124,"context_line":"in the policy.json file as the policy file does not allow defining rules per"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_2d4c9741","line":121,"range":{"start_line":121,"start_character":22,"end_line":121,"end_character":68},"updated":"2016-06-21 12:02:53.000000000","message":"I think we should be able to get that from driver capabilities. Somehow.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":118,"context_line":"whether a particular deployment/resource implements a particular capability"},{"line_number":119,"context_line":"varies by the capability itself. For the backup capability, it could be the"},{"line_number":120,"context_line":"presence of the cinder-backup service. For consistency group and replication"},{"line_number":121,"context_line":"features, it could be statically set when the volume type is created."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"It is not possible to implement the capabilities API based solely on the info"},{"line_number":124,"context_line":"in the policy.json file as the policy file does not allow defining rules per"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_edd2f75a","line":121,"range":{"start_line":121,"start_character":22,"end_line":121,"end_character":68},"in_reply_to":"5a9d85d2_2d4c9741","updated":"2016-06-27 21:42:02.000000000","message":"Done. Added this as an option.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"OpenStack projects as the problem it tries to solve is generic and just as"},{"line_number":141,"context_line":"applicable to these other projects."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"A brief note on the presence of capabilities like APIs in Cinder today. There"},{"line_number":144,"context_line":"is a \"volume capabilities\" extension API [6]_, but it is defined at the"},{"line_number":145,"context_line":"service level (``/v2/{tenant_id}/capabilities/{hostname}``) rather than at"},{"line_number":146,"context_line":"the volume type level. The \"show volume type details\" API [8]_ stuffs the"},{"line_number":147,"context_line":"capabilities in a catch-all \"extra_specs\" property. If this BP is approved,"},{"line_number":148,"context_line":"we will need to rationalize these existing APIs with the new capabilities"},{"line_number":149,"context_line":"APIs that will be defined. This is not in scope for this sepc."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Alternatives"},{"line_number":152,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_8877799e","line":149,"range":{"start_line":143,"start_character":0,"end_line":149,"end_character":62},"updated":"2016-06-21 12:02:53.000000000","message":"The API you mention is admin only anyway…","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":140,"context_line":"OpenStack projects as the problem it tries to solve is generic and just as"},{"line_number":141,"context_line":"applicable to these other projects."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"A brief note on the presence of capabilities like APIs in Cinder today. There"},{"line_number":144,"context_line":"is a \"volume capabilities\" extension API [6]_, but it is defined at the"},{"line_number":145,"context_line":"service level (``/v2/{tenant_id}/capabilities/{hostname}``) rather than at"},{"line_number":146,"context_line":"the volume type level. The \"show volume type details\" API [8]_ stuffs the"},{"line_number":147,"context_line":"capabilities in a catch-all \"extra_specs\" property. If this BP is approved,"},{"line_number":148,"context_line":"we will need to rationalize these existing APIs with the new capabilities"},{"line_number":149,"context_line":"APIs that will be defined. This is not in scope for this sepc."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Alternatives"},{"line_number":152,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_ed0797c7","line":149,"range":{"start_line":143,"start_character":0,"end_line":149,"end_character":62},"in_reply_to":"5a9d85d2_8877799e","updated":"2016-06-27 21:42:02.000000000","message":"Yes, but my point is that we need to coalesce existing capability APIs into one coherent whole. And my \"a capability API per resource\" pattern can be used as the structure for that. So, eventually, we need to move the existing capability APIs onto some resource and make them public.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"REST API impact"},{"line_number":196,"context_line":"---------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":201,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_881bf97f","line":198,"range":{"start_line":198,"start_character":26,"end_line":198,"end_character":38},"updated":"2016-06-21 12:02:53.000000000","message":"So we do already have API called capabilities on following endpoint:\n\nGET v3/{tenant_id}/capabilities/vagrant-ubuntu-trusty-64.localdomain@lvmdriver-2\n\n {\n     \"description\": null,\n     \"display_name\": null,\n     \"driver_version\": \"3.0.0\",\n     \"namespace\": \"OS::Storage::Capabilities::vagrant-ubuntu-trusty-64.localdomain@lvmdriver-2\",\n     \"pool_name\": null,\n     \"properties\": {\n         \"compression\": {\n             \"description\": \"Enables compression.\",\n             \"title\": \"Compression\",\n             \"type\": \"boolean\"\n         },\n         \"qos\": {\n             \"description\": \"Enables QoS.\",\n             \"title\": \"QoS\",\n             \"type\": \"boolean\"\n         },\n         \"replication\": {\n             \"description\": \"Enables replication.\",\n             \"title\": \"Replication\",\n             \"type\": \"boolean\"\n         },\n         \"thin_provisioning\": {\n             \"description\": \"Sets thin provisioning.\",\n             \"title\": \"Thin Provisioning\",\n             \"type\": \"boolean\"\n         }\n     },\n     \"replication_targets\": [],\n     \"storage_protocol\": \"iSCSI\",\n     \"vendor_name\": \"Open Source\",\n     \"visibility\": null,\n     \"volume_backend_name\": \"lvmdriver-2\"\n }\n\nIntroducing another one named like that sounds confusing.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":195,"context_line":"REST API impact"},{"line_number":196,"context_line":"---------------"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":201,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_edbcb7dd","line":198,"range":{"start_line":198,"start_character":26,"end_line":198,"end_character":38},"in_reply_to":"5a9d85d2_881bf97f","updated":"2016-06-27 21:42:02.000000000","message":"They are similar, but they don\u0027t overlap. I think that should be ok. Given that this BP proposes a capabilities API pattern as opposed to a single API, I would rather stick with the \"capabilities\" moniker than give it up because some one-off API calls itself by the same name.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  {"},{"line_number":233,"context_line":"    \"capabilities\": ["},{"line_number":234,"context_line":"      {"},{"line_number":235,"context_line":"        \"name\": \"consistency groups\","},{"line_number":236,"context_line":"        \"description\": \"Allows operating on collections of volumes for"},{"line_number":237,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":238,"context_line":"      },"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_68c96d78","line":235,"range":{"start_line":235,"start_character":17,"end_line":235,"end_character":35},"updated":"2016-06-21 12:02:53.000000000","message":"To keep it consistent with how drivers define this capability - consistencygroup_support.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  {"},{"line_number":233,"context_line":"    \"capabilities\": ["},{"line_number":234,"context_line":"      {"},{"line_number":235,"context_line":"        \"name\": \"consistency groups\","},{"line_number":236,"context_line":"        \"description\": \"Allows operating on collections of volumes for"},{"line_number":237,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":238,"context_line":"      },"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_edb837ca","line":235,"range":{"start_line":235,"start_character":17,"end_line":235,"end_character":35},"in_reply_to":"5a9d85d2_68c96d78","updated":"2016-06-27 21:42:02.000000000","message":"We don\u0027t have the problem of backward compatibility as this is a new API. I don\u0027t mind what naming scheme we use for individual capabilities, but I would like to follow some scheme. \"consitencygroup_support\" and \"replication_enabled\" don\u0027t seem to follow any common scheme (why not \"replication_support\" or \"consistencygroup_enabled\"?).\n\nIt seems like a simple noun or hyphenated compound noun works best. So:\n1) consistency-group\n2) replication\n3) cool-feature\n\nI included this naming scheme suggestion as part of the BP.\n\nWhat do you say?","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a687febb8f63d40faf7434e41d46c8926046360c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":238,"context_line":"      },"},{"line_number":239,"context_line":"      {"},{"line_number":240,"context_line":"        \"name\": \"replication\","},{"line_number":241,"context_line":"        \"description\": \"Allows replication of volumes.\""},{"line_number":242,"context_line":"      },"},{"line_number":243,"context_line":"      {"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a9d85d2_0891c952","line":240,"range":{"start_line":240,"start_character":17,"end_line":240,"end_character":28},"updated":"2016-06-21 12:02:53.000000000","message":"Same reasons - replication_enabled.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"ba2be3a61785225d3fdc4ba32aa4db8df4dee9ca","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":238,"context_line":"      },"},{"line_number":239,"context_line":"      {"},{"line_number":240,"context_line":"        \"name\": \"replication\","},{"line_number":241,"context_line":"        \"description\": \"Allows replication of volumes.\""},{"line_number":242,"context_line":"      },"},{"line_number":243,"context_line":"      {"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3aaa91ec_6dcd6765","line":240,"range":{"start_line":240,"start_character":17,"end_line":240,"end_character":28},"in_reply_to":"5a9d85d2_0891c952","updated":"2016-06-27 21:42:02.000000000","message":"See my reply to that comment.","commit_id":"5fdcde69edcbe6206ecbb56fbf56e942cda3b0ca"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":15,"context_line":"that exercise those capabilities. Consider the volume backup functionality"},{"line_number":16,"context_line":"which may or may not be supported by a cinder deployment. If Horizon could"},{"line_number":17,"context_line":"programmatically detect the presence of this capability, it can enable the"},{"line_number":18,"context_line":"volume backup actions in the UI. This will obviate the need for the operator"},{"line_number":19,"context_line":"to manually set appropriate fields in Horizon\u0027s config to signal the"},{"line_number":20,"context_line":"availability of this feature, which is the case today. We propose adding"},{"line_number":21,"context_line":"a set of APIs that would return the \"capabilities\" available to the current"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_4a9c8d69","line":18,"range":{"start_line":18,"start_character":43,"end_line":18,"end_character":50},"updated":"2016-07-08 17:24:30.000000000","message":"Think you mean \u0027alleviate\u0027 here.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":15,"context_line":"that exercise those capabilities. Consider the volume backup functionality"},{"line_number":16,"context_line":"which may or may not be supported by a cinder deployment. If Horizon could"},{"line_number":17,"context_line":"programmatically detect the presence of this capability, it can enable the"},{"line_number":18,"context_line":"volume backup actions in the UI. This will obviate the need for the operator"},{"line_number":19,"context_line":"to manually set appropriate fields in Horizon\u0027s config to signal the"},{"line_number":20,"context_line":"availability of this feature, which is the case today. We propose adding"},{"line_number":21,"context_line":"a set of APIs that would return the \"capabilities\" available to the current"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_be4f0e69","line":18,"range":{"start_line":18,"start_character":43,"end_line":18,"end_character":50},"in_reply_to":"1aa78d24_4a9c8d69","updated":"2016-07-11 05:11:51.000000000","message":"The dictionary defined \"obviate\" as \"remove a need\". That is the sense in which I used it here.\n\n\"Alleviate\" - defined as \"make a problem less severe\" - means that we would not be completely eliminating this piece of config which is not true.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1221650c967ca78233ac1b61d6481b63d10f0631","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Horizon allows users to create volume backups via the UI, if the underlying"},{"line_number":32,"context_line":"cinder deployment supports the same. Not all cinder deployments support this"},{"line_number":33,"context_line":"functionality, so Horizon needs to way to know when it is supported so that"},{"line_number":34,"context_line":"it can show the UI elements for backup."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Today, Horizon uses [5]_ a config setting \"enable_backup\" for controlling the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_1e51eed8","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":35},"updated":"2016-06-29 05:39:27.000000000","message":"s/to/a","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Horizon allows users to create volume backups via the UI, if the underlying"},{"line_number":32,"context_line":"cinder deployment supports the same. Not all cinder deployments support this"},{"line_number":33,"context_line":"functionality, so Horizon needs to way to know when it is supported so that"},{"line_number":34,"context_line":"it can show the UI elements for backup."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Today, Horizon uses [5]_ a config setting \"enable_backup\" for controlling the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_fe599636","line":33,"range":{"start_line":33,"start_character":32,"end_line":33,"end_character":35},"in_reply_to":"3aaa91ec_1e51eed8","updated":"2016-07-11 05:11:51.000000000","message":"Done","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b0adaab1202eb415f6b0cacd6aef661626783d50","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":80,"context_line":"replication features which are only supported by certain volume types"},{"line_number":81,"context_line":"(actually \"volume backends\", but normally volume backends are more or less"},{"line_number":82,"context_line":"tied to volume types. Note that these two features will be listed by a"},{"line_number":83,"context_line":"different capabilities API than the one that lists the backup feature. See"},{"line_number":84,"context_line":"details below."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_331d3167","line":82,"updated":"2016-06-28 11:41:02.000000000","message":"Missing ending parenthesis.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":80,"context_line":"replication features which are only supported by certain volume types"},{"line_number":81,"context_line":"(actually \"volume backends\", but normally volume backends are more or less"},{"line_number":82,"context_line":"tied to volume types. Note that these two features will be listed by a"},{"line_number":83,"context_line":"different capabilities API than the one that lists the backup feature. See"},{"line_number":84,"context_line":"details below."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_2a54a152","line":82,"range":{"start_line":82,"start_character":69,"end_line":82,"end_character":70},"updated":"2016-07-08 17:24:30.000000000","message":"Remove \u0027a\u0027 .","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Other capabilities which can similarly gain are the consistency group and"},{"line_number":80,"context_line":"replication features which are only supported by certain volume types"},{"line_number":81,"context_line":"(actually \"volume backends\", but normally volume backends are more or less"},{"line_number":82,"context_line":"tied to volume types. Note that these two features will be listed by a"},{"line_number":83,"context_line":"different capabilities API than the one that lists the backup feature. See"},{"line_number":84,"context_line":"details below."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_3e3cbebe","line":82,"range":{"start_line":82,"start_character":69,"end_line":82,"end_character":70},"in_reply_to":"1aa78d24_2a54a152","updated":"2016-07-11 05:11:51.000000000","message":"Michal: Added the missing paraenthesis\n\nJay: Rephrased it from \"a different capabilities API\" to \"a different capability API\"","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1221650c967ca78233ac1b61d6481b63d10f0631","unresolved":false,"context_lines":[{"line_number":101,"context_line":"consistency groups and replication are defined on a volume type. So, it"},{"line_number":102,"context_line":"doesn\u0027t make sense to ask \"Does this cinder service instance have the"},{"line_number":103,"context_line":"replication capability?\"; instead, we need to ask \"Does the volume type xyz"},{"line_number":104,"context_line":"have the replication capability?\"."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":107,"context_line":"be required only a small number of resources. For the Cinder API, it is only"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_be837acb","line":104,"updated":"2016-06-29 05:39:27.000000000","message":"FYI, we do not require a volume type for a consistency group to have \"consistencygroup_support\": \"\u003cis\u003e True\" in extra_specs.\n\nI removed it to address a review comment when CG was introduced.\n\nSo this won\u0027t work for CG reliably because it is not required.\n\nMoving forward with Generic Volume Groups, we should require this.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":101,"context_line":"consistency groups and replication are defined on a volume type. So, it"},{"line_number":102,"context_line":"doesn\u0027t make sense to ask \"Does this cinder service instance have the"},{"line_number":103,"context_line":"replication capability?\"; instead, we need to ask \"Does the volume type xyz"},{"line_number":104,"context_line":"have the replication capability?\"."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":107,"context_line":"be required only a small number of resources. For the Cinder API, it is only"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_7ee2c630","line":104,"in_reply_to":"1aa78d24_0331e2ec","updated":"2016-07-11 05:11:51.000000000","message":"xing-yang, I suppose your are referring to the discussion in https://review.openstack.org/#/c/104732/. \n\nSo it seems that different drivers for a given volume type can have different capabilities. Even if so, why does the scheduler depend on properties that cannot be queried through an API?\n\nIn any case, I removed consistency groups as an example from this spec.\n\nBTW, does/should the existing \"backend capabilities\" API (http://developer.openstack.org/api-ref-blockstorage-v2.html#showBackendCapabilities) include consistencygroup_support in its results?","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d05a5a6bf665ef1d02406629ec2d801e8dde9cbf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"consistency groups and replication are defined on a volume type. So, it"},{"line_number":102,"context_line":"doesn\u0027t make sense to ask \"Does this cinder service instance have the"},{"line_number":103,"context_line":"replication capability?\"; instead, we need to ask \"Does the volume type xyz"},{"line_number":104,"context_line":"have the replication capability?\"."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":107,"context_line":"be required only a small number of resources. For the Cinder API, it is only"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_0331e2ec","line":104,"in_reply_to":"1aa78d24_1d5b1130","updated":"2016-07-08 13:21:28.000000000","message":"We can ask but a type with or without this extra spec can create CG as long as the driver supports it.  Here is why.\n\nThe current implementation goes like this: If user wants to create a CG, the scheduler will add {\"consistencygroup_support\": \"\u003cis\u003e True\"} in the filter to make sure we are looking for a driver that reports this capability.\n\nThis change was recommended during the code review of the first consistency group support patch.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f55d9b96f41c838dd6b0fba6c18c2be26f8e9781","unresolved":false,"context_lines":[{"line_number":101,"context_line":"consistency groups and replication are defined on a volume type. So, it"},{"line_number":102,"context_line":"doesn\u0027t make sense to ask \"Does this cinder service instance have the"},{"line_number":103,"context_line":"replication capability?\"; instead, we need to ask \"Does the volume type xyz"},{"line_number":104,"context_line":"have the replication capability?\"."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"While we can define a capabilities API for every resource, in practice it will"},{"line_number":107,"context_line":"be required only a small number of resources. For the Cinder API, it is only"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_1d5b1130","line":104,"in_reply_to":"3aaa91ec_be837acb","updated":"2016-07-08 06:11:59.000000000","message":"WE can ask the scheduler if a specific type supports CGs though, right?","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":121,"context_line":"configure itself at every level."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Note that a cinder instance may implement a particular feature but may not"},{"line_number":124,"context_line":"allow a particular user from accessing the same. So, the capabilities API"},{"line_number":125,"context_line":"should not only consider whether the service implements the particular feature"},{"line_number":126,"context_line":"but also if the current user is privileged to access the same."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_6aaa291b","line":124,"range":{"start_line":124,"start_character":24,"end_line":124,"end_character":28},"updated":"2016-07-08 17:24:30.000000000","message":"to","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":121,"context_line":"configure itself at every level."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Note that a cinder instance may implement a particular feature but may not"},{"line_number":124,"context_line":"allow a particular user from accessing the same. So, the capabilities API"},{"line_number":125,"context_line":"should not only consider whether the service implements the particular feature"},{"line_number":126,"context_line":"but also if the current user is privileged to access the same."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_7e15a6e3","line":124,"range":{"start_line":124,"start_character":24,"end_line":124,"end_character":28},"in_reply_to":"1aa78d24_6aaa291b","updated":"2016-07-11 05:11:51.000000000","message":"Done","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":125,"context_line":"should not only consider whether the service implements the particular feature"},{"line_number":126,"context_line":"but also if the current user is privileged to access the same."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The \"privilege\" information is already available in the policy.json file that"},{"line_number":129,"context_line":"maps different operations to the users that can access them. The detection of"},{"line_number":130,"context_line":"whether a particular deployment/resource implements a particular capability"},{"line_number":131,"context_line":"varies by the capability itself. For the backup capability, it could be the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_6a81898f","line":128,"range":{"start_line":128,"start_character":5,"end_line":128,"end_character":14},"updated":"2016-07-08 17:24:30.000000000","message":"priviledge","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":125,"context_line":"should not only consider whether the service implements the particular feature"},{"line_number":126,"context_line":"but also if the current user is privileged to access the same."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"The \"privilege\" information is already available in the policy.json file that"},{"line_number":129,"context_line":"maps different operations to the users that can access them. The detection of"},{"line_number":130,"context_line":"whether a particular deployment/resource implements a particular capability"},{"line_number":131,"context_line":"varies by the capability itself. For the backup capability, it could be the"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_5ee70a12","line":128,"range":{"start_line":128,"start_character":5,"end_line":128,"end_character":14},"in_reply_to":"1aa78d24_6a81898f","updated":"2016-07-11 05:11:51.000000000","message":"NOT DONE\nDictionary only has an entry on \"privilege\".","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1221650c967ca78233ac1b61d6481b63d10f0631","unresolved":false,"context_lines":[{"line_number":156,"context_line":"\"volume-backup\" in the response."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"A brief note on the presence of capabilities like APIs in Cinder today. There"},{"line_number":161,"context_line":"is a \"volume capabilities\" extension API [6]_, but it is defined at the"},{"line_number":162,"context_line":"service level (``/v2/{tenant_id}/capabilities/{hostname}``) rather than at"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_3e82ea94","line":159,"updated":"2016-06-29 05:39:27.000000000","message":"nit: too many blank lines.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":156,"context_line":"\"volume-backup\" in the response."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"A brief note on the presence of capabilities like APIs in Cinder today. There"},{"line_number":161,"context_line":"is a \"volume capabilities\" extension API [6]_, but it is defined at the"},{"line_number":162,"context_line":"service level (``/v2/{tenant_id}/capabilities/{hostname}``) rather than at"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_3ee2fe01","line":159,"in_reply_to":"3aaa91ec_3e82ea94","updated":"2016-07-11 05:11:51.000000000","message":"Done","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":194,"context_line":"* Re-use the existing \"list extensions\" public API [7]_. This was proposed by"},{"line_number":195,"context_line":"  dulek in [2]_. First, there may not be a 1:1 correspondence between"},{"line_number":196,"context_line":"  capabilities and extensions (although it is true for the volume backup"},{"line_number":197,"context_line":"  case). Even if it were the always true, the operator would need to prune"},{"line_number":198,"context_line":"  cinder.conf (manually!) so that it lists only those extensions that are"},{"line_number":199,"context_line":"  actually supported. As explained in [2]_, there is no easy way to do that."},{"line_number":200,"context_line":"  Also, as noted by duncant, this breaks the existing semantics - many"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_b55bd22d","line":197,"range":{"start_line":197,"start_character":25,"end_line":197,"end_character":28},"updated":"2016-07-08 17:24:30.000000000","message":"remove \u0027the\u0027","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":194,"context_line":"* Re-use the existing \"list extensions\" public API [7]_. This was proposed by"},{"line_number":195,"context_line":"  dulek in [2]_. First, there may not be a 1:1 correspondence between"},{"line_number":196,"context_line":"  capabilities and extensions (although it is true for the volume backup"},{"line_number":197,"context_line":"  case). Even if it were the always true, the operator would need to prune"},{"line_number":198,"context_line":"  cinder.conf (manually!) so that it lists only those extensions that are"},{"line_number":199,"context_line":"  actually supported. As explained in [2]_, there is no easy way to do that."},{"line_number":200,"context_line":"  Also, as noted by duncant, this breaks the existing semantics - many"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_9ef172d0","line":197,"range":{"start_line":197,"start_character":25,"end_line":197,"end_character":28},"in_reply_to":"1aa78d24_b55bd22d","updated":"2016-07-11 05:11:51.000000000","message":"Done","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b0adaab1202eb415f6b0cacd6aef661626783d50","unresolved":false,"context_lines":[{"line_number":216,"context_line":"including the service itself."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":222,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_4e8c9635","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":40},"updated":"2016-06-28 11:41:02.000000000","message":"I think that this API actually is overlapping with already existing capabilities extension. It is a poor API design if a resource accessible on a lower level is totally non-related to top level:\n\n /v3.x/{tenant_id}/capabilities - new API\n\n /v3.x/{tenant_id}/capabilities/{hostname} - irrelevant old API\n\nImplementing this API in that way violates analogy we have in other places, like:\n\n /v3.x/{tenant_id}/volumes - volume list\n\n /v3.x/{tenant_id}/volumes/{volume_id} - volume details","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":216,"context_line":"including the service itself."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":222,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_3e779e3c","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":40},"in_reply_to":"3aaa91ec_4e8c9635","updated":"2016-07-11 05:11:51.000000000","message":"I agree about the inconsistency part. Do you have an idea on how to fix it? Is changing capabilities to os-capabilities or something else enough? Or do you propose changing the path structure as well (that would violate the \"one capability API per resource\" pattern proposed in this spec though)\n\nIf the API pattern is adopted widely, then we will see \"os-capabilities\" used with multiple resource and perhaps even multiple OpenStack APIs. Which would be a bummer since \"capabilities\" suits such a pattern so well.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1221650c967ca78233ac1b61d6481b63d10f0631","unresolved":false,"context_lines":[{"line_number":242,"context_line":"  }"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"* ``GET /v3.x/{tenant_id}/types/{volume_type_id}/capabilities``"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  Returns the set of capabilities of a particular volume type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  Normal http response code(s): 200"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_fe0ce243","line":245,"updated":"2016-06-29 05:39:27.000000000","message":"We already have the following API that shows extra specs.  It does look redundant with this new one.\n\n/v2/​{tenant_id}​/types/​{volume_type_id}​\n\nWhy can\u0027t we modify the existing one to get what we want?  All extra_specs are already reported in the existing API.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":242,"context_line":"  }"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"* ``GET /v3.x/{tenant_id}/types/{volume_type_id}/capabilities``"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"  Returns the set of capabilities of a particular volume type."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"  Normal http response code(s): 200"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_9ec85276","line":245,"in_reply_to":"3aaa91ec_fe0ce243","updated":"2016-07-11 05:11:51.000000000","message":"xing-yang, the discussion is not about missing information in the extra_specs, it is about what is generic way of returning such information. We can propose an API pattern where we say that every resource should expose its capabilities inside the extra_specs property. If such a proposal is found to be useful for all resources in Cinder and other OpenStack APIs, then we don\u0027t have touch /v2/​{tenant_id}​/types/​{volume_type_id}​. But if the proposal in this patch, namely /v?/{tenant_id}/types/{volume_type_id}/capabilities is accepted, then we will need to deprecate the extra_specs and start using the capability API on volume types resource.\n\nIn any case, I only plan to implement the top-level (i.e. service level) capabilities as the detection of the \"backup\" capability is an immediate requirement. I don\u0027t plan to implement the volume types capability API.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b0adaab1202eb415f6b0cacd6aef661626783d50","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  {"},{"line_number":255,"context_line":"    \"capabilities\": ["},{"line_number":256,"context_line":"      {"},{"line_number":257,"context_line":"        \"name\": \"consistency-groups\","},{"line_number":258,"context_line":"        \"description\": \"Allows operating on collections of volumes for"},{"line_number":259,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":260,"context_line":"      },"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3aaa91ec_8ef79ef4","line":257,"range":{"start_line":257,"start_character":17,"end_line":257,"end_character":35},"updated":"2016-06-28 11:41:02.000000000","message":"We\u0027re naming these resources consistencygroups in any other place in the API if we\u0027re not using consistencygroup_support (I\u0027m still not sure if reusing names from other places wouldn\u0027t be better, but I would love to know what other think).","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":254,"context_line":"  {"},{"line_number":255,"context_line":"    \"capabilities\": ["},{"line_number":256,"context_line":"      {"},{"line_number":257,"context_line":"        \"name\": \"consistency-groups\","},{"line_number":258,"context_line":"        \"description\": \"Allows operating on collections of volumes for"},{"line_number":259,"context_line":"                        Data Protection \u0026 Disaster Recovery.\""},{"line_number":260,"context_line":"      },"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_7ec3e657","line":257,"range":{"start_line":257,"start_character":17,"end_line":257,"end_character":35},"in_reply_to":"3aaa91ec_8ef79ef4","updated":"2016-07-11 05:11:51.000000000","message":"I removed this item since xing-yang mentions that it was decided long ago to not make this a capability of a volume type.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"673cf057c78c60f7ea450447cbfb832f38a6acab","unresolved":false,"context_lines":[{"line_number":334,"context_line":"* Implement the proposed public microversion capabilities API at the"},{"line_number":335,"context_line":"  service level"},{"line_number":336,"context_line":"* Implement at least the backup capability detection"},{"line_number":337,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":338,"context_line":"* Add test cases"},{"line_number":339,"context_line":"* Update Horizon to use this new API for backup capability detection"},{"line_number":340,"context_line":"* Deprecate/remove enable_backup setting from Horizon config"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_75d4ca46","line":337,"range":{"start_line":337,"start_character":2,"end_line":337,"end_character":49},"updated":"2016-07-08 17:24:30.000000000","message":"I don\u0027t remember seeing this discussed in the earlier documentation.  Can you add an example of how this will work with cinderclient please.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"a78a22f4d262e9b614e9a81110b79619ababf937","unresolved":false,"context_lines":[{"line_number":334,"context_line":"* Implement the proposed public microversion capabilities API at the"},{"line_number":335,"context_line":"  service level"},{"line_number":336,"context_line":"* Implement at least the backup capability detection"},{"line_number":337,"context_line":"* Add corresponding option to python-cinderclient"},{"line_number":338,"context_line":"* Add test cases"},{"line_number":339,"context_line":"* Update Horizon to use this new API for backup capability detection"},{"line_number":340,"context_line":"* Deprecate/remove enable_backup setting from Horizon config"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1aa78d24_1eabc28a","line":337,"range":{"start_line":337,"start_character":2,"end_line":337,"end_character":49},"in_reply_to":"1aa78d24_75d4ca46","updated":"2016-07-11 05:11:51.000000000","message":"I removed this and other work items related to *utilizing* the new API. That is not in scope of *this* spec. Once this API is implemented, I will be creating a new one for making Horizon use the new API.","commit_id":"85ddb2f6d186089c1dc1421402f429479546d6fb"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d1bb7663d16f31c4e50eb89e29ca85e067402aaf","unresolved":false,"context_lines":[{"line_number":145,"context_line":"The key contribution of this BP is identifying and proposing an API pattern,"},{"line_number":146,"context_line":"namely \"one capability API per resource\" (of course if some resource doesn\u0027t"},{"line_number":147,"context_line":"need it, we don\u0027t need to define a capability API for it). This idea is simple"},{"line_number":148,"context_line":"but powerful and also reusable across all OpenStack projects."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"While this BP proposes an API pattern, we will only implement the top level"},{"line_number":151,"context_line":"capabilities API. This will return only \"volume-backup\" for now but can be"}],"source_content_type":"text/x-rst","patch_set":12,"id":"bacf61ea_b91d3964","line":148,"updated":"2016-08-04 18:41:00.000000000","message":"I was just directed towards this spec as we\u0027re talking about doing a similar thing in Nova. And I agree with the assessment that this is a simple but powerful approach to the problem.\n\nWhat we\u0027ve been focused on is the exposure of capabilities at an instance level. So given a request to /servers/\u003cuuid\u003e/capabilities what actions are available to that instance. This ends up being a combination of policy, configuration, host abilities, and possibly metadata on the flavor or image used. But a top level capabilities resource for the deployment likely also makes sense.","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"5efc4ca809ac2a65254d8f83168cc0c3ff5cf3bc","unresolved":false,"context_lines":[{"line_number":214,"context_line":"including the service itself."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":220,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":12,"id":"1aa78d24_900d7f40","line":217,"updated":"2016-07-12 18:40:00.000000000","message":"typo: tenant_id","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"7e04ff932317c9e5aea487fd8e1764693eefc91f","unresolved":false,"context_lines":[{"line_number":214,"context_line":"including the service itself."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"* ``GET /v3.x/{tenant id}/capabilities``"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"  Returns the set of capabilities of the underlying block storage deployment"},{"line_number":220,"context_line":"  at the service level."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9ad45d7e_5e3ad5e7","line":217,"in_reply_to":"1aa78d24_900d7f40","updated":"2016-08-11 19:03:17.000000000","message":"we don\u0027t actually put the microversion into the URL...\nit will always be \"GET /v3/\u003ctenant_id\u003e/...\"","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d1bb7663d16f31c4e50eb89e29ca85e067402aaf","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \"description\": \"Other capability description.\""},{"line_number":238,"context_line":"      },"},{"line_number":239,"context_line":"    ]"},{"line_number":240,"context_line":"  }"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* ``GET /v3.x/{tenant_id}/types/{volume_type_id}/capabilities``"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"bacf61ea_b9a259fa","line":240,"updated":"2016-08-04 18:41:00.000000000","message":"We haven\u0027t put enough thought into a useful representation on the Nova side, but I\u0027m not sure this will be right for us there. There\u0027s a strong desire for a capability to indicate the actual API that it aligns with. So rather than a name and description maybe a link. I\u0027m not sure, as I said we haven\u0027t thought enough about it yet.","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"7e04ff932317c9e5aea487fd8e1764693eefc91f","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    ]"},{"line_number":240,"context_line":"  }"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"* ``GET /v3.x/{tenant_id}/types/{volume_type_id}/capabilities``"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"  Returns the set of capabilities of a particular volume type."},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9ad45d7e_7e2359bd","line":242,"updated":"2016-08-11 19:03:17.000000000","message":"we don\u0027t actually put the microversion into the URL...\nit will always be \"GET /v3/\u003ctenant_id\u003e/...\"","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"7e04ff932317c9e5aea487fd8e1764693eefc91f","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"     .. code-block:: json"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        GET /v3.x/{tenant_id}/\u003csome-resource-collection\u003e/"},{"line_number":270,"context_line":"        {some-resource-instance}/capabilities"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"  Returns the set of capabilities of some-resource-instance."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9ad45d7e_fe1d8973","line":269,"updated":"2016-08-11 19:03:17.000000000","message":"we don\u0027t actually put the microversion into the URL...\nit will always be \"GET /v3/\u003ctenant_id\u003e/...\"","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"7e04ff932317c9e5aea487fd8e1764693eefc91f","unresolved":false,"context_lines":[{"line_number":341,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Unit and functional test cases need to be added to validate this new API."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"Documentation Impact"},{"line_number":347,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9ad45d7e_7e0a3927","line":344,"updated":"2016-08-11 19:03:17.000000000","message":"New API should have Tempest tests.","commit_id":"74bc9946aab2bd587bfa803e1a3a7debf866bf83"}]}
