)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transfer snapshots with volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users can transfer"},{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_5c8f8a74","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":29},"updated":"2017-06-14 20:07:21.000000000","message":"to","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Transfer snapshots with volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users can transfer"},{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_7f432e6d","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":29},"in_reply_to":"7f231b9d_5c8f8a74","updated":"2017-06-16 03:42:41.000000000","message":"Done","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Transfer snapshots with volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users can transfer"},{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API Impact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_7cdb667b","line":10,"updated":"2017-06-14 20:07:21.000000000","message":"at same time -\u003e at the same time","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Transfer snapshots with volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature allows users can transfer"},{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API Impact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_9f528a3a","line":10,"in_reply_to":"7f231b9d_7cdb667b","updated":"2017-06-16 03:42:41.000000000","message":"Done","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API Impact"},{"line_number":14,"context_line":"Add an optional argument \u0027--with-snapshots\u0027 in transfer API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_bcce9eb1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2017-06-14 20:07:21.000000000","message":"APIImpact","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"snapshots with volumes at same time if"},{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"API Impact"},{"line_number":14,"context_line":"Add an optional argument \u0027--with-snapshots\u0027 in transfer API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_bf4d469b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"7f231b9d_bcce9eb1","updated":"2017-06-16 03:42:41.000000000","message":"Done","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dd74d61cf3edb0816bb8a45a1a491d724af1f567","unresolved":false,"context_lines":[{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Add an optional argument \u0027--with-snapshots\u0027 in transfer API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f1a1f67_d42a15d9","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":60},"updated":"2017-07-18 18:02:57.000000000","message":"Needs to be updated to match the current spec text.","commit_id":"61357040446db7555ad4d5b5dd6e0c3663816300"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f103485ceeb1369274e408f9c00edb4cb80a8d2d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"they want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"Add an optional argument \u0027--with-snapshots\u0027 in transfer API."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f1a1f67_464e52c1","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":60},"in_reply_to":"1f1a1f67_d42a15d9","updated":"2017-07-19 01:01:48.000000000","message":"Sure","commit_id":"61357040446db7555ad4d5b5dd6e0c3663816300"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0aa037f70c939324135ad438a261ba8f4d047ec","unresolved":false,"context_lines":[{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"Add an optional argument \u0027--no-snapshots\u0027 in transfer API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I287209404a31df91586bbe6bb86daed5c9a7f884"},{"line_number":20,"context_line":"Implements: blueprint transfer-snps-with-vols"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ff346bd7_d41a897b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":9},"updated":"2017-07-25 07:39:03.000000000","message":"I don\u0027t think the spec has a DocImpact. The code implementing the spec will, and now that docs are in-tree, that should include any necessary updates to documentation.","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c7624fb46d790457ffd6cad82a4b80676895a69a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"Add an optional argument \u0027--no-snapshots\u0027 in transfer API."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I287209404a31df91586bbe6bb86daed5c9a7f884"},{"line_number":20,"context_line":"Implements: blueprint transfer-snps-with-vols"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ff346bd7_c9a5d5a3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":9},"in_reply_to":"ff346bd7_d41a897b","updated":"2017-07-28 01:47:49.000000000","message":"yes, sure.","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"}],"specs/newton/transfer-snapshots-with-volumes.rst":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"abc38804b7de14a4b191ea6666a364257d24086b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Notifications impact"},{"line_number":69,"context_line":"--------------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"None"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Other end user impact"},{"line_number":74,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_31343849","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"updated":"2016-05-24 07:44:54.000000000","message":"The transfer notification should be amended to include this flag","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"88bd0266ae2116b602533e9004e91e808614e606","unresolved":false,"context_lines":[{"line_number":68,"context_line":"Notifications impact"},{"line_number":69,"context_line":"--------------------"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"None"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Other end user impact"},{"line_number":74,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_69dc1847","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":4},"in_reply_to":"bab6814e_31343849","updated":"2016-05-24 08:49:35.000000000","message":"Sure.","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"abc38804b7de14a4b191ea6666a364257d24086b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Developer impact"},{"line_number":90,"context_line":"----------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_118774d8","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":4},"updated":"2016-05-24 07:44:54.000000000","message":"Drivers that implement some form of volume ownership tracking on the backend (Solidfire does this, I think there are others) will need to be fixed to track this change too.","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"88bd0266ae2116b602533e9004e91e808614e606","unresolved":false,"context_lines":[{"line_number":89,"context_line":"Developer impact"},{"line_number":90,"context_line":"----------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_89e33c05","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":4},"in_reply_to":"bab6814e_118774d8","updated":"2016-05-24 08:49:35.000000000","message":"Done","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"abc38804b7de14a4b191ea6666a364257d24086b","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The cinder API documention will need to be updated to reflect the REST"},{"line_number":131,"context_line":"API changes."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_d1632c40","line":132,"updated":"2016-05-24 07:44:54.000000000","message":"Devref entry on the volume transfer driver entry point should be created / updated","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"88bd0266ae2116b602533e9004e91e808614e606","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The cinder API documention will need to be updated to reflect the REST"},{"line_number":131,"context_line":"API changes."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bab6814e_09be2cd4","line":132,"in_reply_to":"bab6814e_d1632c40","updated":"2016-05-24 08:49:35.000000000","message":"Done","commit_id":"a6b00e31de78d11a4902281a1dac9c73ab378cef"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"40379c269a1da5b0985251f8dabd2b7ad97bac01","unresolved":false,"context_lines":[{"line_number":26,"context_line":"When transferring volume which has snapshots, user have choice to decide"},{"line_number":27,"context_line":"whether to transfer those snapshots with volume at same time, if not, nothing"},{"line_number":28,"context_line":"different happen, if yes, snapshots are transferred to other project and other"},{"line_number":29,"context_line":"user can delete the volume or snapshots as him/her wish."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_b9691f28","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":56},"updated":"2016-06-27 22:29:30.000000000","message":"Suggested update to above paragraph for clarification:\n\nWhen transferring volume with snapshots, a user will now have a choice whether or not to transfer those snapshots along with a volume.  Currently no snapshots are transferred, but selecting this option will allow snapshots to be transferred to another project. Note that these can be deleted by the remote user if not necessary.","commit_id":"18780b0a04feee43b3b33ec7be4be1ee67eb4e6e"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ea8b94f342b36665953e4a069355e19e48a0ee61","unresolved":false,"context_lines":[{"line_number":26,"context_line":"When transferring volume which has snapshots, user have choice to decide"},{"line_number":27,"context_line":"whether to transfer those snapshots with volume at same time, if not, nothing"},{"line_number":28,"context_line":"different happen, if yes, snapshots are transferred to other project and other"},{"line_number":29,"context_line":"user can delete the volume or snapshots as him/her wish."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_7ba87220","line":29,"range":{"start_line":29,"start_character":55,"end_line":29,"end_character":56},"in_reply_to":"3aaa91ec_b9691f28","updated":"2016-07-01 12:45:11.000000000","message":"Done","commit_id":"18780b0a04feee43b3b33ec7be4be1ee67eb4e6e"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"4aaf29331bb627fa41d5103db09fd32cd6ad6868","unresolved":false,"context_lines":[{"line_number":26,"context_line":"When transferring volume with snapshots, a user will now have a choice whether"},{"line_number":27,"context_line":"or not to transfer those snapshots along with a volume. Currently no snapshots"},{"line_number":28,"context_line":"are transferred, but selecting this option will allow snapshots to be"},{"line_number":29,"context_line":"transferred to another project. Note that these can be deleted by the remote user if necessary."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3aaa91ec_3593925e","line":29,"range":{"start_line":29,"start_character":77,"end_line":29,"end_character":94},"updated":"2016-07-01 14:04:44.000000000","message":"You need to shorten this line by wrapping over into a new line (\u003c80 chars)","commit_id":"e6a45b87dfb1500d45e1f45e6afb1c4e1e1802f8"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"ff445a1b3c940e6c463186fd0e64079e066dc075","unresolved":false,"context_lines":[{"line_number":26,"context_line":"When transferring volume with snapshots, a user will now have a choice whether"},{"line_number":27,"context_line":"or not to transfer those snapshots along with a volume. Currently no snapshots"},{"line_number":28,"context_line":"are transferred, but selecting this option will allow snapshots to be"},{"line_number":29,"context_line":"transferred to another project. Note that these can be deleted by the remote user if necessary."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_25d3493a","line":29,"range":{"start_line":29,"start_character":77,"end_line":29,"end_character":94},"in_reply_to":"3aaa91ec_3593925e","updated":"2016-08-08 23:18:30.000000000","message":"Done","commit_id":"e6a45b87dfb1500d45e1f45e6afb1c4e1e1802f8"}],"specs/ocata/transfer-snapshots-with-volumes.rst":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"78d9b28b1f3945f87a166e8e4206b52a1c552b94","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots True/False\" in transfer API and"},{"line_number":36,"context_line":"  CLI."},{"line_number":37,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":38,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_7860e1cf","line":36,"range":{"start_line":35,"start_character":2,"end_line":36,"end_character":5},"updated":"2016-10-07 13:00:41.000000000","message":"This look like a design bug to me. If the admin transfer a volume to a new user, the user should be perform any operation in the volume. So, the possibility of left snapshots behind should not be allowed, furthermore, what would be the reasons why someone would want that (--with-snapshots False)? Both snapshot and volume operation would be compromised.\nSo, my suggestion is that if the volume has snapshots we warn the user and always transfer them.\nAnother option, is fail the operation if the volume has snapshots and add a new option --force, that will transfer the snapshots if the volume has it.","commit_id":"ac89c943304ae150abedffa562f5ee21f6f6990b"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9e21d10efb9c4d7f5a54badc3c4fd5d5dd6282ca","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots True/False\" in transfer API and"},{"line_number":36,"context_line":"  CLI."},{"line_number":37,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":38,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_03dc5b17","line":36,"range":{"start_line":35,"start_character":2,"end_line":36,"end_character":5},"in_reply_to":"1a95cdbc_7860e1cf","updated":"2016-10-18 03:38:03.000000000","message":"The purpose of this parameter is for API forward compatibility, but I agree with you that we could fail the operation if volume has snapshots. Thanks Erlon.","commit_id":"ac89c943304ae150abedffa562f5ee21f6f6990b"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"ee19c9d729e5c8312c113a44e60182fa35d141ef","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Performance Impact"},{"line_number":81,"context_line":"------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Other deployer impact"},{"line_number":86,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_1e7fc566","line":83,"updated":"2016-10-07 13:44:49.000000000","message":"If there are a lot of snapshots associated with a given volume when the end user chooses to accept the snapshots, there may be a network performance issue during the transfer.","commit_id":"ac89c943304ae150abedffa562f5ee21f6f6990b"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9e21d10efb9c4d7f5a54badc3c4fd5d5dd6282ca","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Performance Impact"},{"line_number":81,"context_line":"------------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Other deployer impact"},{"line_number":86,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa6399be_e38f67ca","line":83,"in_reply_to":"1a95cdbc_1e7fc566","updated":"2016-10-18 03:38:03.000000000","message":"Thanks bruce, but sorry I didn\u0027t get why there is network performance issue, I think there could be a db performance issue since we need to change a lot of snapshots project id, user id, etc.","commit_id":"ac89c943304ae150abedffa562f5ee21f6f6990b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e4bdc73805c1d27a2e8649a6d057b90b01c293ba","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--force\" in transfer API and CLI. If user didn\u0027t"},{"line_number":36,"context_line":"  specify it, cinder will fail the transfer operation if volume has snapshots."},{"line_number":37,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":38,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_52e8e37c","line":35,"updated":"2016-11-07 16:48:20.000000000","message":"Do not add an argument called \"--force\".  This term has been overused in Cinder, we need something more appropriate and meaningful for this operation.","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"72968fcdcd94cf353b19b1b809d84f5b28db5cd9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--force\" in transfer API and CLI. If user didn\u0027t"},{"line_number":36,"context_line":"  specify it, cinder will fail the transfer operation if volume has snapshots."},{"line_number":37,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":38,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_42af3fe3","line":35,"in_reply_to":"9a629dbe_52e8e37c","updated":"2016-11-15 01:38:09.000000000","message":"How about \"--with-snapshots\"? I think it\u0027s better than \"--force\".","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e4bdc73805c1d27a2e8649a6d057b90b01c293ba","unresolved":false,"context_lines":[{"line_number":53,"context_line":"REST API impact"},{"line_number":54,"context_line":"---------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"*Add an optional argumet \"force\"::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":59,"context_line":"  RESP BODY: {\"transfer\": {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_92027b3d","line":56,"updated":"2016-11-07 16:48:20.000000000","message":"Needs a different argument name.","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"72968fcdcd94cf353b19b1b809d84f5b28db5cd9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"REST API impact"},{"line_number":54,"context_line":"---------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"*Add an optional argumet \"force\"::"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":59,"context_line":"  RESP BODY: {\"transfer\": {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_62935ba4","line":56,"in_reply_to":"9a629dbe_92027b3d","updated":"2016-11-15 01:38:09.000000000","message":"Done","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e4bdc73805c1d27a2e8649a6d057b90b01c293ba","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":59,"context_line":"  RESP BODY: {\"transfer\": {"},{"line_number":60,"context_line":"                           ..."},{"line_number":61,"context_line":"                           force: True,"},{"line_number":62,"context_line":"                          }"},{"line_number":63,"context_line":"             }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_f2f9f74e","line":61,"updated":"2016-11-07 16:48:20.000000000","message":"^","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"72968fcdcd94cf353b19b1b809d84f5b28db5cd9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":59,"context_line":"  RESP BODY: {\"transfer\": {"},{"line_number":60,"context_line":"                           ..."},{"line_number":61,"context_line":"                           force: True,"},{"line_number":62,"context_line":"                          }"},{"line_number":63,"context_line":"             }"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_a28d737d","line":61,"in_reply_to":"9a629dbe_f2f9f74e","updated":"2016-11-15 01:38:09.000000000","message":"Done","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e4bdc73805c1d27a2e8649a6d057b90b01c293ba","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Notifications impact"},{"line_number":72,"context_line":"--------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Add \u0027force\u0027 information to transfer notificaiton."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a629dbe_b2869fb7","line":74,"updated":"2016-11-07 16:48:20.000000000","message":"^","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"72968fcdcd94cf353b19b1b809d84f5b28db5cd9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Notifications impact"},{"line_number":72,"context_line":"--------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Add \u0027force\u0027 information to transfer notificaiton."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Other end user impact"},{"line_number":77,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a77a97e_02f3870b","line":74,"in_reply_to":"9a629dbe_b2869fb7","updated":"2016-11-15 01:38:09.000000000","message":"Done","commit_id":"bb74497015ef60ff04a017fcc908317b1a96bd40"}],"specs/pike/transfer-snapshots-with-volumes.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f975e65e81b7324f41acada1ba9860b92ec6561a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_af24b70c","line":37,"updated":"2016-11-28 21:04:07.000000000","message":"So what\u0027s the use case where someone would want to ever do a transfer and not use --with-snapshots?\n\nShouldn\u0027t we do with-snapshots by default, if not always?  (When using a new microversion that supports this.)","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7a88fd0305872154cac9737811da197856022fae","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_415ff9e4","line":37,"in_reply_to":"3a71b18c_14a5e5a0","updated":"2017-01-04 09:05:23.000000000","message":"At begin, adding this option is for api backward compatibility， if user didn\u0027t specify this option, that will nothing be changed.  But I also agree with you, if using a new microversion, that could be default with transferring snapshots with volume.","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"675ddf29772cc268f389e8908cf64fe836712046","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a71b18c_14a5e5a0","line":37,"in_reply_to":"5a74a57a_af24b70c","updated":"2016-12-05 21:59:09.000000000","message":"Yes, maybe this should be discussed. It seems we should just transfer the snaps along with the volumes by default, and just do away with the option. If there were a use-case to not transfer the volumes, the default should still be \"transfer volumes with snapshots\" and an option for \"--no-snapshot\". I\u0027m having a hard time thinking of such a use case...","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"be09259cbcebb3a94d17579243005259ea3d273f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba2be162_d055b71d","line":37,"in_reply_to":"7a3c09a3_86af89e2","updated":"2017-03-01 02:54:40.000000000","message":"I can understand Duncan\u0027s concern about changing the default behavior in new microversion.  So Alternatives contain this change in next patch.  Eric and Scott, what you think?","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"d77f40e3c9be0262325cc10dcf140d6c53817b2b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a3c09a3_86af89e2","line":37,"in_reply_to":"9a57fde8_4ec12fe4","updated":"2017-01-13 10:38:27.000000000","message":"The thing is, even though we\u0027re adding a microversion, we should try to be minimal with the change, in order to make the client code more simple. Adding a new version that adds a new flag means the client code is simple:\n\nmin_version \u003d 1\nif (snaps_transfer_wanted) then\n     data +\u003d --with-snapshots\n     min_version \u003d 139\n\nIf you change the default then you end up with something requiring rather more knowledge to comprehend:\n\nif (snaps_transfer_wanted) then\n    min_version \u003d 139\nelse\n    min_version \u003d 0\n\nThe former can be comprehended (not written, but read and understood) without looking up the version numbers, where as the second version can\u0027t - it requires that you know the difference between the versions.","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"eff18d93972680ee06564da118e884cfa5574e65","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--with-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will fail the transfer operation if volume has"},{"line_number":37,"context_line":"  snapshots."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9a57fde8_4ec12fe4","line":37,"in_reply_to":"ba5201f7_415ff9e4","updated":"2017-01-12 18:58:16.000000000","message":"I don\u0027t think this is a sufficient reason, since adding this requires a new microversion anyway.","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f975e65e81b7324f41acada1ba9860b92ec6561a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"REST API impact"},{"line_number":55,"context_line":"---------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"*Add an optional argumet \"with_snapshots\"::"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  POST /v2/{project_id}/os-volume-transfer"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_ef1a2fc5","line":56,"updated":"2016-11-28 21:04:07.000000000","message":"New microversion.","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"7a88fd0305872154cac9737811da197856022fae","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"REST API impact"},{"line_number":55,"context_line":"---------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"*Add an optional argumet \"with_snapshots\"::"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  POST /v2/{project_id}/os-volume-transfer"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_215f550f","line":56,"in_reply_to":"5a74a57a_ef1a2fc5","updated":"2017-01-04 09:05:23.000000000","message":"yes","commit_id":"cf87777136e8343e3de0633d3c211a8eb4751521"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8be4c3917b4753c22b0783ba6790d2bcbe73c030","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a57fde8_6e443374","line":37,"updated":"2017-01-12 18:59:12.000000000","message":"What operations in Cinder will break if the snapshots attached to a volume have a different owner than the volume?","commit_id":"c7e0afe647700ea7a87dafa5f63ca1ce15de0210"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"08561702d1abdd8cbcb6010dcce27a88c0794050","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba2be162_abbe18fd","line":37,"in_reply_to":"9a57fde8_6e443374","updated":"2017-03-01 03:05:55.000000000","message":"Deletion operation, if there\u0027s different owner between volume and attached snapshot,  user can\u0027t delete this volume. And more worse, if using cascade deleting,  there could raise error in driver since Cinder can\u0027t find the snapshots which are belong to other owner in DB.","commit_id":"c7e0afe647700ea7a87dafa5f63ca1ce15de0210"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":29,"context_line":"transferred to another project."},{"line_number":30,"context_line":"Note those snapshots can be deleted by the remote user if necessary."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_5c00aaab","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":15},"updated":"2017-06-14 20:07:21.000000000","message":"What happens if the user transfers the volume without snapshots and then tries to delete it?  If they purposefully leave them behind do we want to enable deletion?  Guess we need to consider how to handle that situation.  Guessing it isn\u0027t as easy as just enabling deletion because some backends require the base volume to be kept.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"transferred to another project."},{"line_number":30,"context_line":"Note those snapshots can be deleted by the remote user if necessary."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_d51b41c7","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":15},"in_reply_to":"7f231b9d_5c00aaab","updated":"2017-06-16 03:42:41.000000000","message":"In normal deleting, Cinder will disallow the request since the volume has snapshots,  but unfortunate, Cinder has cascade deleting operation now,  the request will be passed down to driver, some driver will raise exception since snapshot is still existing.\n\nSo I think we should not enable the deletion, we should cover the normal and cascade deleting to check if the volume still has some snapshots in other project.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6df4cd67266262ad0ae725222fc5d2b86ca727be","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_1374d134","line":35,"updated":"2017-05-29 13:49:46.000000000","message":"I don\u0027t think that changing current behaviour is a good idea. We can break some automation tools which do volume transfers","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_35b3959a","line":35,"in_reply_to":"7f231b9d_9c752267","updated":"2017-06-16 03:42:41.000000000","message":"I also agree Eric, see my reply above,  now Cinder has cascading deleting for volume,  it will make the situation more worse I think.\n\nThe current owner of this volume may call the cascading deletion, and Cinder will pass the request to driver,  that will cause exception in some backend. It\u0027s a bug in cascading deletion process.\n\nWe should change the users or developers to use right behavior, if they choose the --no-snapshots explicitly,  they should know what will happen.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8325f307b288834bad0828de1cffc55779745d51","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_75f3ba74","line":35,"in_reply_to":"df140735_1374d134","updated":"2017-05-31 13:23:19.000000000","message":"I disagree -- not moving snapshots by default with transfer breaks things in Cinder and breaks the model of what a Cinder snapshot is.  (A child of a volume.)\n\nI don\u0027t think anyone is relying on this behavior.  At least, nobody should be.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_9c752267","line":35,"in_reply_to":"df140735_75f3ba74","updated":"2017-06-14 20:07:21.000000000","message":"Agree with Eric here.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_1c07d2cc","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":66},"updated":"2017-06-14 20:07:21.000000000","message":"that a volume","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Add an optional argument \"--no-snapshots\" in transfer API and CLI. If user"},{"line_number":36,"context_line":"  didn\u0027t specify it, cinder will transfer snapshots that if volume has by"},{"line_number":37,"context_line":"  default."},{"line_number":38,"context_line":"* Add a new field in transfer DB model to record this option."},{"line_number":39,"context_line":"* Update snapshot\u0027s information in DB like user id, project id, etc."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_15b09989","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":66},"in_reply_to":"7f231b9d_1c07d2cc","updated":"2017-06-16 03:42:41.000000000","message":"Done","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6df4cd67266262ad0ae725222fc5d2b86ca727be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Another option is cinder transfer the snapshots if user specifies an option"},{"line_number":46,"context_line":"argument \u0027--with-snapshots\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This option can be minimal with the change, in order to make the client code"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_f38efd25","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":23},"updated":"2017-05-29 13:49:46.000000000","message":"IMO, we should go in this way","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Another option is cinder transfer the snapshots if user specifies an option"},{"line_number":46,"context_line":"argument \u0027--with-snapshots\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This option can be minimal with the change, in order to make the client code"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_756a2ded","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":23},"in_reply_to":"7f231b9d_9c23e256","updated":"2017-06-16 03:42:41.000000000","message":"Agree too with Eric.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Another option is cinder transfer the snapshots if user specifies an option"},{"line_number":46,"context_line":"argument \u0027--with-snapshots\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This option can be minimal with the change, in order to make the client code"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_9c23e256","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":23},"in_reply_to":"df140735_55eaf674","updated":"2017-06-14 20:07:21.000000000","message":"Agree with Eric.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8325f307b288834bad0828de1cffc55779745d51","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Another option is cinder transfer the snapshots if user specifies an option"},{"line_number":46,"context_line":"argument \u0027--with-snapshots\u0027."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This option can be minimal with the change, in order to make the client code"}],"source_content_type":"text/x-rst","patch_set":10,"id":"df140735_55eaf674","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":23},"in_reply_to":"df140735_f38efd25","updated":"2017-05-31 13:23:19.000000000","message":"Disagree, see above.\n\nGoing this way is falling into the trap of adding a \"--please-make-this-work-correctly\" flag.  We should design things to work right by default.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e58c95c261518f34192fd485e09ad2abae2a5598","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_7ccec682","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":4},"updated":"2017-06-14 20:07:21.000000000","message":"There is kind of a security impact here depending on how the snapshots are affected in the case that the user transfers the volume without snapshots.  If they are still able to act upon the untransferred snapshots, that could look suspicious to the original owner.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c27f901033a59913f2304747178cb09260d788d2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Notifications impact"},{"line_number":78,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7f231b9d_18f7b0d5","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":4},"in_reply_to":"7f231b9d_7ccec682","updated":"2017-06-16 03:42:41.000000000","message":"Yes,  it could happen,  like COW in RBD,  that could act upon the untransferred snapshot.","commit_id":"9bfe7201d17d21a846e5f4be60056e2657fc4f00"}],"specs/queens/transfer-snapshots-with-volumes.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0aa037f70c939324135ad438a261ba8f4d047ec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In normal deleting, Cinder will disallow the request since the volume has"},{"line_number":36,"context_line":"snapshots,  but unfortunate, Cinder has cascade deleting operation now,"},{"line_number":37,"context_line":"the request will be passed down to driver, some driver will raise"},{"line_number":38,"context_line":"exception since snapshot is still existing. So it also should be changed in"},{"line_number":39,"context_line":"cascade deletion process."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_670c4d3b","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":27},"updated":"2017-07-25 07:39:03.000000000","message":"nit: unfortunately","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c7624fb46d790457ffd6cad82a4b80676895a69a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"In normal deleting, Cinder will disallow the request since the volume has"},{"line_number":36,"context_line":"snapshots,  but unfortunate, Cinder has cascade deleting operation now,"},{"line_number":37,"context_line":"the request will be passed down to driver, some driver will raise"},{"line_number":38,"context_line":"exception since snapshot is still existing. So it also should be changed in"},{"line_number":39,"context_line":"cascade deletion process."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_69982974","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":27},"in_reply_to":"ff346bd7_670c4d3b","updated":"2017-07-28 01:47:49.000000000","message":"Done","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0aa037f70c939324135ad438a261ba8f4d047ec","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"*Add an optional argumet \"no_snapshots\"::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":73,"context_line":"  RESP BODY: {\"transfer\": {"},{"line_number":74,"context_line":"                           ..."},{"line_number":75,"context_line":"                           no_snapshots: [True/False],"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_071d8165","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":10},"updated":"2017-07-25 07:39:03.000000000","message":"This would need to be a v3 microversioned API update.","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"c7624fb46d790457ffd6cad82a4b80676895a69a","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"*Add an optional argumet \"no_snapshots\"::"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  POST /v2/{project_id}/os-volume-transfer"},{"line_number":73,"context_line":"  RESP BODY: {\"transfer\": {"},{"line_number":74,"context_line":"                           ..."},{"line_number":75,"context_line":"                           no_snapshots: [True/False],"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ff346bd7_a9929155","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":10},"in_reply_to":"ff346bd7_071d8165","updated":"2017-07-28 01:47:49.000000000","message":"Done","commit_id":"2d27bdae0d2812b1fe575e942d3767e0cabb22da"}]}
