)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a70f95956422977afb1a973311a30854bd64a755","unresolved":false,"context_lines":[{"line_number":14,"context_line":"HealthCheck Middleware provides \u003cSERVER\u003e:\u003cPORT\u003e/healtcheck endpoint."},{"line_number":15,"context_line":"This endpoint behaves similar way as it does in Swift. Normal operation"},{"line_number":16,"context_line":"returns 200 \u0027OK\u0027, and if config option disable_path is enabled with"},{"line_number":17,"context_line":"existence of that path, it will return 503 \u0027DISABLED BY FILE\u0027."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0ef8018e5dad4b25635c8ae0f93f1e2ef3b5219a"},{"line_number":20,"context_line":"blueprint: healthcheck-middleware"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_c219cf23","line":17,"range":{"start_line":17,"start_character":24,"end_line":17,"end_character":62},"updated":"2016-06-26 18:43:50.000000000","message":"We already have a standard response for disabled by policy. If we\u0027re disabling this via a different mechanism then we should be clear which is which.","commit_id":"4666934751a9d2de96250f70a9e4eb2ba546504c"}],"specs/newton/healtcheck-middleware.rst":[{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8fb2758cd6b9190aca206e46ab70687c75482280","unresolved":false,"context_lines":[{"line_number":14,"context_line":"https://blueprints.launchpad.net/glance/+spec/healthcheck-middleware."},{"line_number":15,"context_line":"It\u0027s helpful for cinder to get this function."},{"line_number":16,"context_line":"HealthCheck Middleware provides \u003cSERVER\u003e:\u003cPORT\u003e/healtcheck endpoint."},{"line_number":17,"context_line":"This endpoint behaves similar way as it does in Swift. Normal operations"},{"line_number":18,"context_line":"returns 200 OK and if config option disable_path is enabled and that path"},{"line_number":19,"context_line":"exists it will return 503 DISABLED BY FILE."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7aa08908_3218a184","line":19,"range":{"start_line":17,"start_character":54,"end_line":19,"end_character":43},"updated":"2016-06-06 11:34:18.000000000","message":"Please keep consistent with commit message.","commit_id":"4666934751a9d2de96250f70a9e4eb2ba546504c"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a70f95956422977afb1a973311a30854bd64a755","unresolved":false,"context_lines":[{"line_number":14,"context_line":"https://blueprints.launchpad.net/glance/+spec/healthcheck-middleware."},{"line_number":15,"context_line":"It\u0027s helpful for cinder to get this function."},{"line_number":16,"context_line":"HealthCheck Middleware provides \u003cSERVER\u003e:\u003cPORT\u003e/healtcheck endpoint."},{"line_number":17,"context_line":"This endpoint behaves similar way as it does in Swift. Normal operations"},{"line_number":18,"context_line":"returns 200 OK and if config option disable_path is enabled and that path"},{"line_number":19,"context_line":"exists it will return 503 DISABLED BY FILE."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_a21483e8","line":19,"range":{"start_line":17,"start_character":54,"end_line":19,"end_character":43},"in_reply_to":"7aa08908_3218a184","updated":"2016-06-26 18:43:50.000000000","message":"See my note on commit message","commit_id":"4666934751a9d2de96250f70a9e4eb2ba546504c"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a70f95956422977afb1a973311a30854bd64a755","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Disabled functionality would allow using a file in the filesystem to return"},{"line_number":46,"context_line":"503 DISABLED BY FILE response dropping the node from the HAProxy. This would"},{"line_number":47,"context_line":"allow the nodes disabled to finish their current operations and improve"},{"line_number":48,"context_line":"maintenance experience in HA deployments."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_c2f0afcb","line":48,"range":{"start_line":48,"start_character":40,"end_line":48,"end_character":41},"updated":"2016-06-26 18:43:50.000000000","message":"How exactly are you proposing it is disabled? In cinder.conf? In paste.conf?\n\nHow is the update made? Poll the file on every request? Update on SIGHUP? Update on restart?","commit_id":"4666934751a9d2de96250f70a9e4eb2ba546504c"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a70f95956422977afb1a973311a30854bd64a755","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Alternatives"},{"line_number":51,"context_line":"------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"None"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_42dcbf45","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":4},"updated":"2016-06-26 18:43:50.000000000","message":"Stay as we are and use version discovery as the healthcheck URL","commit_id":"4666934751a9d2de96250f70a9e4eb2ba546504c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e606c141f531b041d3fe194162885c765044ec9c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Use Cases"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The scope of this spec is to provide health check information."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_34ce3963","line":34,"updated":"2016-07-21 11:00:20.000000000","message":"It\u0027s not a valid use case","commit_id":"5d5c865164bdcde6d565147784d770140ded98a3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e606c141f531b041d3fe194162885c765044ec9c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Performance Impact"},{"line_number":80,"context_line":"------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Potential performance improvement as healthcheck is done quite frequently"},{"line_number":83,"context_line":"and the middleware is lightweight filter at the start of the pipeline."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dada55a8_b407c980","line":82,"updated":"2016-07-21 11:00:20.000000000","message":"I don\u0027t see how it will improve performance","commit_id":"5d5c865164bdcde6d565147784d770140ded98a3"}]}
