)]}'
{"specs/newton/group-snapshots.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ee2465f010bb3f82760a0f9654ea3435ddca0c96","unresolved":false,"context_lines":[{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"As mentioned in the generic volume group spec, driver can report the"},{"line_number":74,"context_line":"following capabilites for the group snapshot support."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* consistent_group_snapshot_enabled"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a9d85d2_c83b60ea","line":74,"updated":"2016-06-20 21:03:23.000000000","message":"This is implementation detail, not a use case.","commit_id":"7ef201cc6ffc8d9f1e7bdf4a7c3eedd92ca21b9d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0690faf6e6738e2190f712b64c48f2d2fef9ed28","unresolved":false,"context_lines":[{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"As mentioned in the generic volume group spec, driver can report the"},{"line_number":74,"context_line":"following capabilites for the group snapshot support."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* consistent_group_snapshot_enabled"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_bd93e04e","line":74,"in_reply_to":"5a9d85d2_c83b60ea","updated":"2016-06-21 20:19:49.000000000","message":"Reworded this section.","commit_id":"7ef201cc6ffc8d9f1e7bdf4a7c3eedd92ca21b9d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ee2465f010bb3f82760a0f9654ea3435ddca0c96","unresolved":false,"context_lines":[{"line_number":84,"context_line":"want to protect all OpenStack resources. To backup an instance and its"},{"line_number":85,"context_line":"attached volumes, they typically issue a quiece command in the guest agent"},{"line_number":86,"context_line":"before taking snapshots, regardless of the storage backend. Therefore"},{"line_number":87,"context_line":"having a common API for the above two cases will be beneficial."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Proposed change"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a9d85d2_8b2672b8","line":87,"updated":"2016-06-20 21:03:23.000000000","message":"I don\u0027t think that group snapshots help this use case, it sounds like harmful advice to tell people to do a quiesce + group snapshot.\n\nThis is basically encouraging people to use group snapshots the same way that CGs are used and ignoring the fact that the snapshots may happen a number of seconds or minutes apart from each other.","commit_id":"7ef201cc6ffc8d9f1e7bdf4a7c3eedd92ca21b9d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0690faf6e6738e2190f712b64c48f2d2fef9ed28","unresolved":false,"context_lines":[{"line_number":84,"context_line":"want to protect all OpenStack resources. To backup an instance and its"},{"line_number":85,"context_line":"attached volumes, they typically issue a quiece command in the guest agent"},{"line_number":86,"context_line":"before taking snapshots, regardless of the storage backend. Therefore"},{"line_number":87,"context_line":"having a common API for the above two cases will be beneficial."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Proposed change"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3aaa91ec_9d4ee4bf","line":87,"in_reply_to":"5a9d85d2_8b2672b8","updated":"2016-06-21 20:19:49.000000000","message":"Reworded this section and removed the \"quiece\" language to avoid confusion.","commit_id":"7ef201cc6ffc8d9f1e7bdf4a7c3eedd92ca21b9d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f37e18b64682a273cb6846bbf29a401804f1a4d8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Changes will be made to make sure generic volume group and group snapshots"},{"line_number":128,"context_line":"  can support CG and CG snapshots."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  * Create a default CG group type and use it only for the existing CGs."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * Write a migration script to copy data from consistencygroups to"},{"line_number":133,"context_line":"    groups and from cgsnapshots to group_snapshots tables. All existing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_481fe3b6","line":130,"updated":"2016-07-12 20:05:57.000000000","message":"should this be \"default group type\" instead of \"default CG group type\"?","commit_id":"15c3362ebe75c00b4136a01340ee0416ea690921"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cbad38663b6981cb5d4cfa83c39dec46200cf931","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Changes will be made to make sure generic volume group and group snapshots"},{"line_number":128,"context_line":"  can support CG and CG snapshots."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"  * Create a default CG group type and use it only for the existing CGs."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  * Write a migration script to copy data from consistencygroups to"},{"line_number":133,"context_line":"    groups and from cgsnapshots to group_snapshots tables. All existing"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_dc971438","line":130,"in_reply_to":"1aa78d24_481fe3b6","updated":"2016-07-12 20:18:40.000000000","message":"Done","commit_id":"15c3362ebe75c00b4136a01340ee0416ea690921"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"f37e18b64682a273cb6846bbf29a401804f1a4d8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"New unit tests will be added to test the changed code."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Documentation Impact"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_9c28ec87","line":376,"updated":"2016-07-12 20:05:57.000000000","message":"This should have tempest tests, and probably could use functional testing as well.","commit_id":"15c3362ebe75c00b4136a01340ee0416ea690921"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cbad38663b6981cb5d4cfa83c39dec46200cf931","unresolved":false,"context_lines":[{"line_number":373,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"New unit tests will be added to test the changed code."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"Documentation Impact"},{"line_number":378,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_1ccd1c66","line":376,"in_reply_to":"1aa78d24_9c28ec87","updated":"2016-07-12 20:18:40.000000000","message":"Done","commit_id":"15c3362ebe75c00b4136a01340ee0416ea690921"}]}