)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a spec for supporting hidden consistency groups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Currently when consistency groups are created they are owned by the tenant and"},{"line_number":12,"context_line":"can be modified freely given the correct role. This means that if a consistency"},{"line_number":13,"context_line":"group exists that is part of a tenant policy the tenant can change it directly"},{"line_number":14,"context_line":"without going through the policy owner. This in turn can cause issues with the"},{"line_number":15,"context_line":"entity who manages the consistency group. Further more, the user might see"},{"line_number":16,"context_line":"consistency groups that they did not create and might choose to delete it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"blueprint cinder-hidden-consistency-groups"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_da4f8abb","line":16,"range":{"start_line":11,"start_character":67,"end_line":16,"end_character":73},"updated":"2016-07-28 16:53:28.000000000","message":"Body lines should be wrapped at 72 characters.","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"}],"specs/newton/hidden-consistency-groups.rst":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"1dcc0a7389d1c9c5f5eae04bf34282b0f907ddc9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   set up groups depending on policy defined in Smaug and would trust that the"},{"line_number":35,"context_line":"   configuration remains unchanged. If the user modifies or deletes it due to"},{"line_number":36,"context_line":"   confusion it might make recovery impossible or broken."},{"line_number":37,"context_line":"2. Point-in-time Backups: Smaug will create and update consistency groups as"},{"line_number":38,"context_line":"   needed. This might create clutter for the user since Smaug might create"},{"line_number":39,"context_line":"   numerous groups that will be displayed next to manually creates groups."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_8dcb1e53","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":74},"updated":"2016-07-28 17:03:41.000000000","message":"You would need to hide volumes and snapshots too. If you clone a CG you get a bunch of new volumes, and/or if you snapshot one you get a new cinder snapshot for each volume. All of them should be hidden too otherwise things get confusing since they would be assigned to a CG or CG snap that they can\u0027t operate on.\n\nEventually we would need to essentially have the hidden flag on every cinder object Smaug might want to protect...","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"groups would not return unless a special query argument ``show_all\u003dtrue``"},{"line_number":50,"context_line":"is given."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"We could use the unix convention of having names that start with ``\".\"`` be"},{"line_number":53,"context_line":"hidden for simplicity but this might cause existing groups to be hidden if"},{"line_number":54,"context_line":"users already have groups that start with ``\".\"`` due to some internal naming"},{"line_number":55,"context_line":"convention."}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_cd91969b","line":52,"range":{"start_line":52,"start_character":65,"end_line":52,"end_character":68},"updated":"2016-07-28 16:53:28.000000000","message":"Double quotes?","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"We could use the unix convention of having names that start with ``\".\"`` be"},{"line_number":53,"context_line":"hidden for simplicity but this might cause existing groups to be hidden if"},{"line_number":54,"context_line":"users already have groups that start with ``\".\"`` due to some internal naming"},{"line_number":55,"context_line":"convention."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"If this is considered to be a problem. A new field that is ``false`` by"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_4df486f1","line":54,"range":{"start_line":54,"start_character":42,"end_line":54,"end_character":44},"updated":"2016-07-28 16:53:28.000000000","message":"Double quotes?","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"1dcc0a7389d1c9c5f5eae04bf34282b0f907ddc9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"If this is considered to be a problem. A new field that is ``false`` by"},{"line_number":58,"context_line":"default called ``hidden``."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Alternatives"},{"line_number":61,"context_line":"------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Do nothing, application can add information in the description warning tenants"},{"line_number":64,"context_line":"not to modify those groups and trust that if the tenant has the appropriate"},{"line_number":65,"context_line":"permissions to modify the group they should be allowed to. It\u0027s their given"},{"line_number":66,"context_line":"right to shoot themselves in the foot."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Data model impact"},{"line_number":69,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_cda076a2","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":37},"updated":"2016-07-28 17:03:41.000000000","message":"+1 for this approach... I\u0027m not a fan of hidden objects in Cinder.","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7c6f38d844d44f83871f3843b7702da834e60df7","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"New query argument for listing consistency groups::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    GET/v2/{tenant_id}/consistencygroups?show_all\u003dtrue"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Security impact"},{"line_number":81,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_00acfaeb","line":78,"updated":"2016-07-29 04:45:06.000000000","message":"This should be built on the new generic groups API:\n\n/v3/{tenant_id}/groups?show_all\u003dtrue","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"Notifications impact"},{"line_number":86,"context_line":"--------------------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"We\u0027ll want to augment the CG creation and any other relevant notifications with the hidden flag"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Other end user impact"},{"line_number":91,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_faf1ae6b","line":88,"updated":"2016-07-28 16:53:28.000000000","message":"\u0027.\u0027 at EOL","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"Performance Impact"},{"line_number":96,"context_line":"------------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Filtering the results might cause a slight performance impact for the REST API"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Other deployer impact"},{"line_number":101,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_3aece68e","line":98,"updated":"2016-07-28 16:53:28.000000000","message":"\u0027.\u0027 at EOL","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5fa2bc794e2797376afe611ceb3d6bcd90e574f8","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Work Items"},{"line_number":119,"context_line":"----------"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_ad68a288","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":0},"updated":"2016-07-28 16:53:28.000000000","message":"Write the API, add to the cinder client, write tests, add documentation.","commit_id":"8f409e9a1940fde9bb439953333cf9762f71809f"}]}
