)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"037fc6de9793ddbc88dbc5d50dcd270bf7acb9f6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean McGinnis \u003csean_mcginnis@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-26 23:30:00 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement polcies in code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Leverage oslo.policy to register default policies in the code similar"},{"line_number":10,"context_line":"to how config options are handled."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_b65c79ee","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":17},"updated":"2016-08-28 17:09:36.000000000","message":"/polcies/policies/\n\nWill address next update.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"}],"specs/ocata/policy-in-code.rst":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a27b3569b86fc1bee43db3cac8e06a22f46603e7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This would simplify our policy.json file by only needing to have those entries"},{"line_number":27,"context_line":"that differ from the defaults. It would also allow us to generate a sample"},{"line_number":28,"context_line":"policy file similar to how we do for cinder.conf to show all the possible"},{"line_number":29,"context_line":"settings with the defaults commented out for easy reference."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa7ab95a_a03c2fe3","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":48},"updated":"2016-08-28 14:27:02.000000000","message":"This is a process that has gone from nice and simple to a horrible mess, so I\u0027m not sure it should be held up as an example of something we want to try to emulate. cinder/opts.py is an abomination.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"037fc6de9793ddbc88dbc5d50dcd270bf7acb9f6","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This would simplify our policy.json file by only needing to have those entries"},{"line_number":27,"context_line":"that differ from the defaults. It would also allow us to generate a sample"},{"line_number":28,"context_line":"policy file similar to how we do for cinder.conf to show all the possible"},{"line_number":29,"context_line":"settings with the defaults commented out for easy reference."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa7ab95a_365229de","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":48},"in_reply_to":"fa7ab95a_a03c2fe3","updated":"2016-08-28 17:09:36.000000000","message":"I agree. On the other hand, we are now able to programmatically generate the sample, so in my opinion that is far better than having to manually update it. And to have to remember to do so in the first place.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"20027c471faac88d78556b136fc6a7fd9b5a15bf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"1. The rule name, e.g. \"volume:get\""},{"line_number":52,"context_line":"2. The rule, e.g. \"rule:admin_or_owner\" or \"role:admin\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The rule name is needed for later liijups. The rule is necessary in order to"},{"line_number":55,"context_line":"set the defaults and generate a sample file."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A third optional description can also be provided and should be used in most"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_9eef42e8","line":54,"range":{"start_line":54,"start_character":34,"end_line":54,"end_character":41},"updated":"2016-09-26 17:36:13.000000000","message":"liijups?","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"776355a119774da56f989ab10d0b6aac63778564","unresolved":false,"context_lines":[{"line_number":51,"context_line":"1. The rule name, e.g. \"volume:get\""},{"line_number":52,"context_line":"2. The rule, e.g. \"rule:admin_or_owner\" or \"role:admin\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"The rule name is needed for later liijups. The rule is necessary in order to"},{"line_number":55,"context_line":"set the defaults and generate a sample file."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"A third optional description can also be provided and should be used in most"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_92749336","line":54,"range":{"start_line":54,"start_character":34,"end_line":54,"end_character":41},"in_reply_to":"5a8bc5a2_9eef42e8","updated":"2016-09-26 18:14:45.000000000","message":"Yeah, you know, liijups.\n\n:)\n\nWill fix with the right finger positions on my keyboard.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"20027c471faac88d78556b136fc6a7fd9b5a15bf","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Other deployer impact"},{"line_number":103,"context_line":"---------------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"End user admins will no longer need to have all settings defined in the"},{"line_number":106,"context_line":"policy.json file, only those that they want different than the defaults."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Developer impact"},{"line_number":109,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_7e76f6d7","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":72},"updated":"2016-09-26 17:36:13.000000000","message":"This can also make obscure to admins what are the current policies active in the system. Is there a way to generate the policy file with all default policies comment out? This will make easier to add/change new policies.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"776355a119774da56f989ab10d0b6aac63778564","unresolved":false,"context_lines":[{"line_number":102,"context_line":"Other deployer impact"},{"line_number":103,"context_line":"---------------------"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"End user admins will no longer need to have all settings defined in the"},{"line_number":106,"context_line":"policy.json file, only those that they want different than the defaults."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Developer impact"},{"line_number":109,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_f21877d5","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":72},"in_reply_to":"5a8bc5a2_7e76f6d7","updated":"2016-09-26 18:14:45.000000000","message":"Yes, see line 132. I should call this out in the proposed change section to make sure it\u0027s clear that this would be used to generate a sample policy.json file with the defaults.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e1bd2b91df129728b54d76373678a35f3eea5b2b","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If done correctly, no additional or different testing should be required."},{"line_number":144,"context_line":"Existing tests should detect if there are any changes in the expected policy"},{"line_number":145,"context_line":"behavior."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation Impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa7ab95a_07d6b4f0","line":145,"updated":"2016-09-01 18:21:25.000000000","message":"In our tests we\u0027ve got policy.json. Should we remove it?","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"776355a119774da56f989ab10d0b6aac63778564","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"If done correctly, no additional or different testing should be required."},{"line_number":144,"context_line":"Existing tests should detect if there are any changes in the expected policy"},{"line_number":145,"context_line":"behavior."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Documentation Impact"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_12588389","line":145,"in_reply_to":"fa7ab95a_07d6b4f0","updated":"2016-09-26 18:14:45.000000000","message":"We would be able to remove it if it\u0027s not being used for anything other than the defaults. Otherwise we can just explicitly override in code.","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e1bd2b91df129728b54d76373678a35f3eea5b2b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation should be updated to state that only policies which are changes"},{"line_number":151,"context_line":"to the default policy will be needed when configuring policy settings."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"References"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa7ab95a_47319c59","line":151,"updated":"2016-09-01 18:21:25.000000000","message":"It would be good to add to the documentation manual how to build sample policy.json","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"20027c471faac88d78556b136fc6a7fd9b5a15bf","unresolved":false,"context_lines":[{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation should be updated to state that only policies which are changes"},{"line_number":151,"context_line":"to the default policy will be needed when configuring policy settings."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"References"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_c18bab66","line":151,"in_reply_to":"fa7ab95a_47319c59","updated":"2016-09-26 17:36:13.000000000","message":"+1","commit_id":"0a1a320c88a010b891b7b9225e408dee653de60a"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"d4a841f39bdee8db92115db6fabaf898fe601c55","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Other deployer impact"},{"line_number":106,"context_line":"---------------------"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"End user admins will no longer need to have all settings defined in the"},{"line_number":109,"context_line":"policy.json file, only those that they want different than the defaults."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Developer impact"},{"line_number":112,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_6d441874","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":72},"updated":"2016-10-05 11:36:47.000000000","message":"Using an existing, fully defined policy file is however harmless, so there\u0027s no backwards compatibility issue","commit_id":"b6f91a2a8d2c32652e1f49795d22288695025755"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"d4a841f39bdee8db92115db6fabaf898fe601c55","unresolved":false,"context_lines":[{"line_number":143,"context_line":"Testing"},{"line_number":144,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"If done correctly, no additional or different testing should be required."},{"line_number":147,"context_line":"Existing tests should detect if there are any changes in the expected policy"},{"line_number":148,"context_line":"behavior."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation Impact"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_ed2f489f","line":148,"range":{"start_line":146,"start_character":0,"end_line":148,"end_character":9},"updated":"2016-10-05 11:36:47.000000000","message":"Maybe I\u0027m missing it, but I don\u0027t see a policy block test in our current end-to-end tests. We should ensure there is one, to smoke test the policy mechanism.","commit_id":"b6f91a2a8d2c32652e1f49795d22288695025755"}],"specs/queens/policy-in-code.rst":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"53536f49df5352bd412b448dcec6c212416c25b4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Security impact"},{"line_number":91,"context_line":"---------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"None. Although this touches our policy handling, this just enables preemprive"},{"line_number":94,"context_line":"policy checks and does not change the way we handle policy enforcement."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f1d235d_beea7da9","line":93,"range":{"start_line":93,"start_character":67,"end_line":93,"end_character":77},"updated":"2017-07-10 02:08:14.000000000","message":"preemptive?","commit_id":"79e13043279cedba5d32f897501c391ca626ad30"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c49721c9ab00530d02018465d4dc5d5aa85df0a3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"The rule name is needed for later lookups. The rule is necessary in order to"},{"line_number":64,"context_line":"set the defaults and generate a sample file."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"A third optional description can also be provided and should be used in most"},{"line_number":67,"context_line":"cases so it is available in any generated sample policy files."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"We can then use this code to add a job that will generate a sample policy.json"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_5feda0ed","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":16},"updated":"2017-08-09 18:24:55.000000000","message":"description should not be optional here. We should agree that we will provide a description for all policy checks going forward. Without a description, operators lack the information they need to know when/how to properly override a default rule.","commit_id":"30296b9d6619abec6354b79912b2f673ce953153"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c49721c9ab00530d02018465d4dc5d5aa85df0a3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"We can then use this code to add a job that will generate a sample policy.json"},{"line_number":70,"context_line":"file showing the commented out defaults directly from the code base."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[0] https://github.com/openstack/oslo.policy/blob/1.9.0/doc/source/usage.rst#registering-policy-defaults-in-code"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Alternatives"},{"line_number":75,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_1fe278d6","line":72,"updated":"2017-08-09 18:24:55.000000000","message":"this is a really old link, and things have changed since... please update to https://github.com/openstack/oslo.policy/blob/1.25.1/doc/source/user/usage.rst#registering-policy-defaults-in-code and plan to use DocumentedRuleDefault with the additional data that describes.","commit_id":"30296b9d6619abec6354b79912b2f673ce953153"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c49721c9ab00530d02018465d4dc5d5aa85df0a3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Dependencies"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Current requirements are for oslo.policy \u003e\u003d 1.9.0, so no extra dependencies"},{"line_number":150,"context_line":"are required."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f436f4f_3f63fc1c","line":149,"updated":"2017-08-09 18:24:55.000000000","message":"DocumentedRuleDefault (see earlier comment) was added with 1.21.0 https://github.com/openstack/oslo.policy/commit/a95606c1dfd7368a247c79d5f65a54c629ce29b2#diff-dfed0f2e6c2b5b9444b6b05744f0698b\n\nNova actually requires 1.23.0 or newer, and cinder should probably match that.","commit_id":"30296b9d6619abec6354b79912b2f673ce953153"}]}
