)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"7a635ffe0b0f4684874b9a0be67bc6dac5b0d1ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backup driver initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t initialize Cinder Backp driver during service startup. It means"},{"line_number":10,"context_line":"that we\u0027ve got cinder-backup service up and running even if it can\u0027t connect"},{"line_number":11,"context_line":"to the backup storage."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_c6033572","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":32},"updated":"2016-10-28 09:58:37.000000000","message":"backup","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"6f86e5f3e940067d57c426a54394ce309770186a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Backup driver initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t initialize Cinder Backp driver during service startup. It means"},{"line_number":10,"context_line":"that we\u0027ve got cinder-backup service up and running even if it can\u0027t connect"},{"line_number":11,"context_line":"to the backup storage."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I56f784f4f656f731dc53a51c1230b35ffd3c1409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5ff73747_9abd0e04","line":10,"range":{"start_line":10,"start_character":69,"end_line":10,"end_character":76},"updated":"2017-04-27 14:14:29.000000000","message":"Please wrap this too since you are already wrapping into another line.","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7518ea7b1abff22036f9c94034aa5ee6f9725d3f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backup driver initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t initialize Cinder Backp driver during service startup. It means"},{"line_number":10,"context_line":"that we\u0027ve got cinder-backup service up and running even if it can\u0027t connect"},{"line_number":11,"context_line":"to the backup storage."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"df140735_e4958341","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":32},"updated":"2017-06-02 19:20:41.000000000","message":"s/Backp/Backup","commit_id":"25800e14e0e9445cb73a038f2eb333561b83b894"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"22ced7f6cff7f977ef2152a43a76f2c0e0d0d3c2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Backup driver initialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We don\u0027t initialize Cinder Backp driver during service startup. It means"},{"line_number":10,"context_line":"that we\u0027ve got cinder-backup service up and running even if it can\u0027t connect"},{"line_number":11,"context_line":"to the backup storage."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I56f784f4f656f731dc53a51c1230b35ffd3c1409"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df140735_8f72e5e2","line":10,"updated":"2017-06-07 14:54:01.000000000","message":"nit: wrap at 72 chars.  Fix it only if you need to upload another patch set.","commit_id":"5d22e16a48cb50dfd764694ec7af73ca3387e0a1"}],"specs/ocata/backup-init.rst":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9d653d0031152605f0aedb7bfdec7776dc019f9c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Cinder backup manager does not verify that backup driver is initialized"},{"line_number":21,"context_line":"successfully. If cinder-backup is started successfully we can create a volume"},{"line_number":22,"context_line":"backup. Such backups always will be in \u0027error\u0027 status and tenant user won\u0027t be"},{"line_number":23,"context_line":"able to delete them."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_04aa9819","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":20},"updated":"2016-09-09 11:24:48.000000000","message":"Can you add a brief example what checks can be done in init_host in one of existing backend drivers?","commit_id":"370512ede8d31b590c35ac545a838f33ed0e9fb8"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1f613d2a6df276292828e8295897f3b88aaf586d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Check for backup storage is available on backup create call. If storage is not"},{"line_number":50,"context_line":"available, remove \u0027host\u0027 field from backup object. In such case, we will know"},{"line_number":51,"context_line":"about backup creation failure too late and scheduler could send another create"},{"line_number":52,"context_line":"command to this host."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Data model impact"},{"line_number":55,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_629298f8","line":52,"range":{"start_line":49,"start_character":0,"end_line":52,"end_character":20},"updated":"2016-09-08 20:48:04.000000000","message":"We should probably consider doing this as welll as the above. If our connection to the storage goes down, we should ideally mark ourselves as down (to avoid getting new work), but retry connecting to the storage periodically (so that transient network issues etc are transparently fixed). We can emit suitable notification events for alerting purposes.\n\nMaybe if we get a request we can\u0027t handle we could put it back on the queue so that another worker can pick it up?","commit_id":"370512ede8d31b590c35ac545a838f33ed0e9fb8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9d653d0031152605f0aedb7bfdec7776dc019f9c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Both unit and Tempest tests should be implemented to cover new APIs."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a89bdaa_c401903b","line":128,"range":{"start_line":128,"start_character":63,"end_line":128,"end_character":67},"updated":"2016-09-09 11:24:48.000000000","message":"This is proposing a new REST API?","commit_id":"370512ede8d31b590c35ac545a838f33ed0e9fb8"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f06ebf9578b76a91075c76bb0fb9a31acc075124","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/backup-init"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"We don\u0027t initialize Cinder Backp driver during service startup. It means that"},{"line_number":14,"context_line":"we\u0027ve got cinder-backup service up and running even if it can\u0027t connect to the"},{"line_number":15,"context_line":"backup storage."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_b24bdd2a","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":32},"updated":"2016-10-05 11:07:59.000000000","message":"Backup","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f06ebf9578b76a91075c76bb0fb9a31acc075124","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Cinder backup service should be marked as \u0027down\u0027 if it can\u0027t connect to the"},{"line_number":29,"context_line":"backup storage."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_d2e4e90e","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":15},"updated":"2016-10-05 11:07:59.000000000","message":"Should it periodically attempt to reconnect for self-healing purposes?","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"f06ebf9578b76a91075c76bb0fb9a31acc075124","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We should introduce for cinder backups the same mechanism as we\u0027ve got for"},{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: depends on"},{"line_number":39,"context_line":"  driver, we could check connection to storage, list of available backups. etc."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Introduce \u0027do_setup\u0027 method in backup drivers which will verify drivers"},{"line_number":42,"context_line":"  configuration and connection to storage."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":45,"context_line":"  as \u0027down\u0027."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_9246e121","line":42,"range":{"start_line":36,"start_character":0,"end_line":42,"end_character":42},"updated":"2016-10-05 11:07:59.000000000","message":"Why two new calls rather than one? All this work can be done in one call","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"850dbd4e80014d4bfa26b4f8995017cbf077359c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Introduce \u0027do_setup\u0027 method in backup drivers which will verify drivers"},{"line_number":42,"context_line":"  configuration and connection to storage."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":45,"context_line":"  as \u0027down\u0027."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_7886abba","line":43,"updated":"2016-11-07 15:56:14.000000000","message":"Why not follow the same model we use for volume drivers with do_setup(), check_for_setup_error()?","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a9bbee98b6ec78131c2208f25906e02b309a8db6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Introduce \u0027do_setup\u0027 method in backup drivers which will verify drivers"},{"line_number":42,"context_line":"  configuration and connection to storage."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":45,"context_line":"  as \u0027down\u0027."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_d2add389","line":43,"in_reply_to":"9a629dbe_7886abba","updated":"2016-11-07 16:44:53.000000000","message":"Again, why two methods? do_setup can happily raise an exception if there are any problems. What is the purpose of the second call?","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"a9bbee98b6ec78131c2208f25906e02b309a8db6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Notifications impact"},{"line_number":70,"context_line":"--------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Other end user impact"},{"line_number":75,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_72ec07c8","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":4},"updated":"2016-11-07 16:44:53.000000000","message":"Do we want to emit notifications as services come up and down? Makes some times of monitoring easier.","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5bc6979285f6943bb33f0e67999f16d6709f6e8c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"Testing"},{"line_number":126,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Both unit and Tempest tests should be implemented to cover new APIs."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_cece0f83","line":128,"range":{"start_line":128,"start_character":53,"end_line":128,"end_character":68},"updated":"2016-10-05 08:09:04.000000000","message":"Repeating the question about APIs that can be Tempest-tested in relationship with this blueprint.","commit_id":"11cde054413325d2abdea21872b6d7de18b76d09"}],"specs/pike/backup-init.rst":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"54fb265f3857755b6ce69fc23f20d89412971e43","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Cinder backup manager does not verify that backup driver is initialized"},{"line_number":21,"context_line":"successfully. If cinder-backup is started successfully we can create a volume"},{"line_number":22,"context_line":"backup. Such backups always will be in \u0027error\u0027 status and tenant user won\u0027t be"},{"line_number":23,"context_line":"able to delete them."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a22e58a_593ae5ce","line":23,"range":{"start_line":22,"start_character":8,"end_line":23,"end_character":20},"updated":"2017-03-14 13:44:21.000000000","message":"How it can be reproduced?\nOn devstack with swift as a backup backend (which all services were disabled) and non-admin user this issue couldn\u0027t be reproduced.","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9c396a8bcc056699d709d8281150865537a3416f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Cinder backup manager does not verify that backup driver is initialized"},{"line_number":21,"context_line":"successfully. If cinder-backup is started successfully we can create a volume"},{"line_number":22,"context_line":"backup. Such backups always will be in \u0027error\u0027 status and tenant user won\u0027t be"},{"line_number":23,"context_line":"able to delete them."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a1ff146_e5f90d4f","line":23,"range":{"start_line":22,"start_character":8,"end_line":23,"end_character":20},"in_reply_to":"5a22e58a_593ae5ce","updated":"2017-03-15 11:00:00.000000000","message":"Please, take a look on bug https://bugs.launchpad.net/cinder/+bug/1598709","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"54fb265f3857755b6ce69fc23f20d89412971e43","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Cinder backup service should be marked as \u0027down\u0027 if it can\u0027t connect to the"},{"line_number":29,"context_line":"backup storage."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a22e58a_797401cf","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":15},"updated":"2017-03-14 13:44:21.000000000","message":"Now backup service always is \u0027up\u0027 (actually, if the service was started is_working method in \u0027report_state\u0027\u0027s call [0] always returns True because of [1]).\n\nThe main problem that service could be marked as \u0027down\u0027 only after some time that defines by \u0027periodic_interval\u0027 opt (if I\u0027m now mistaken).\nSo still for this period we will be able to create a lot of backups.\n\nAlso now for backups if the service.is_up returns False, backup api will return 500 error response [2].\n\n[0] - https://github.com/openstack/cinder/blob/e8bbccd42b95894f6fe866ba26cbf069fdd5276c/cinder/service.py#L478\n\n[1] - https://github.com/openstack/cinder/blob/d4395bb53808bc3ce4fcfca8d2fe2703b9a35d8b/cinder/manager.py#L130\n\n[2] - https://github.com/openstack/cinder/blob/d4395bb53808bc3ce4fcfca8d2fe2703b9a35d8b/cinder/backup/api.py#L183","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9c396a8bcc056699d709d8281150865537a3416f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Use Cases"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Cinder backup service should be marked as \u0027down\u0027 if it can\u0027t connect to the"},{"line_number":29,"context_line":"backup storage."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Proposed change"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a1ff146_456d8103","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":15},"in_reply_to":"5a22e58a_797401cf","updated":"2017-03-15 11:00:00.000000000","message":"[2] I think it will be 404 error","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"54fb265f3857755b6ce69fc23f20d89412971e43","unresolved":false,"context_lines":[{"line_number":34,"context_line":"We should introduce for cinder backups the same mechanism as we\u0027ve got for"},{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: verify drivers"},{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a22e58a_fced3f26","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":48},"updated":"2017-03-14 13:44:21.000000000","message":"We have this method and it is called every time on service startup. We need to implement method called \u0027check_for_setup_errors\u0027 (if we want to have such mechanism as we have for c-vol).","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9c396a8bcc056699d709d8281150865537a3416f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"We should introduce for cinder backups the same mechanism as we\u0027ve got for"},{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: verify drivers"},{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a1ff146_08ff2002","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":48},"in_reply_to":"5a22e58a_fced3f26","updated":"2017-03-15 11:00:00.000000000","message":"init_host doesn\u0027t do anything related to backup driver initialization and verification","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: verify drivers"},{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_5660d0ce","line":38,"range":{"start_line":38,"start_character":71,"end_line":38,"end_character":78},"updated":"2017-02-20 19:58:17.000000000","message":"driver\u0027s","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: verify drivers"},{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_2610b84e","line":38,"range":{"start_line":38,"start_character":71,"end_line":38,"end_character":78},"in_reply_to":"da36d5c6_5660d0ce","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_f6af04e1","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":43},"updated":"2017-02-20 19:58:17.000000000","message":"fails","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_6631d0ec","line":42,"range":{"start_line":42,"start_character":34,"end_line":42,"end_character":43},"in_reply_to":"da36d5c6_f6af04e1","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"54fb265f3857755b6ce69fc23f20d89412971e43","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* If backup driver initialization is failed, manager will mark backup service"},{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodically_initialization\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a22e58a_1cddbb42","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":68},"updated":"2017-03-14 13:44:21.000000000","message":"If it is necessary to be implemented on the service level, we need to investigate this question thoroughly, because I think i can influence other services.","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodically_initialization\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_b6f3cc09","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":46},"updated":"2017-02-20 19:58:17.000000000","message":"Suggest:  backup_periodic_initialization Do we want this to be a numeric value for seconds or just a true/false value.  I am thinking providing a value for the interval wouldn\u0027t be all bad.","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodically_initialization\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_e65b002d","line":46,"range":{"start_line":46,"start_character":11,"end_line":46,"end_character":46},"in_reply_to":"da36d5c6_b6f3cc09","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"54fb265f3857755b6ce69fc23f20d89412971e43","unresolved":false,"context_lines":[{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Check for backup storage is available on backup create call. If storage is not"},{"line_number":52,"context_line":"available, remove \u0027host\u0027 field from backup object. We could try to re-schedule"},{"line_number":53,"context_line":"backup creation on the other host."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Data model impact"},{"line_number":56,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a22e58a_3c9ef756","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":34},"updated":"2017-03-14 13:44:21.000000000","message":"In such a variant it\u0027s very easy to implement, because we already have something like not a re-scheduler, but \u0027chooser\u0027 for hosts here [0].\n\n[0] - https://github.com/openstack/cinder/blob/d4395bb53808bc3ce4fcfca8d2fe2703b9a35d8b/cinder/backup/api.py#L163","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_7605d4c0","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":75},"updated":"2017-02-20 19:58:17.000000000","message":"Will this be for determining how long before the backup backend is considered down?","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_f6c46493","line":89,"range":{"start_line":89,"start_character":5,"end_line":89,"end_character":39},"updated":"2017-02-20 19:58:17.000000000","message":"backup_periodic_initialization","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_665f100f","line":89,"range":{"start_line":89,"start_character":46,"end_line":89,"end_character":75},"in_reply_to":"da36d5c6_7605d4c0","updated":"2017-03-16 16:24:07.000000000","message":"Yes, I\u0027ll add it to the spec","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"Other deployer impact"},{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_86732cb4","line":89,"range":{"start_line":89,"start_character":5,"end_line":89,"end_character":39},"in_reply_to":"da36d5c6_f6c46493","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":87,"context_line":"---------------------"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_763794b0","line":90,"range":{"start_line":90,"start_character":29,"end_line":90,"end_character":43},"updated":"2017-02-20 19:58:17.000000000","message":"Deployer will have","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_36bfdcfc","line":91,"range":{"start_line":91,"start_character":1,"end_line":91,"end_character":35},"updated":"2017-02-20 19:58:17.000000000","message":"back_periodic_initialization","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"New \u0027backup_periodically_initialization\u0027 and \u0027backup_initialization_timeout\u0027"},{"line_number":90,"context_line":"config option will be added. Deployer have to enable"},{"line_number":91,"context_line":"\u0027backup_periodically_initialization\u0027 if needed."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Developer impact"},{"line_number":94,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_a6ed8827","line":91,"range":{"start_line":91,"start_character":1,"end_line":91,"end_character":35},"in_reply_to":"da36d5c6_36bfdcfc","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Other contributors:"},{"line_number":109,"context_line":"  Backup drivers maintainers."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Work Items"},{"line_number":112,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_16cc9888","line":109,"range":{"start_line":109,"start_character":2,"end_line":109,"end_character":29},"updated":"2017-02-20 19:58:17.000000000","message":"What will happen with the drivers that don\u0027t yet have this implemented?  Current functionality maintained?","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9c396a8bcc056699d709d8281150865537a3416f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"  Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Other contributors:"},{"line_number":109,"context_line":"  Backup drivers maintainers."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Work Items"},{"line_number":112,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a1ff146_c8e7c83e","line":109,"range":{"start_line":109,"start_character":2,"end_line":109,"end_character":29},"in_reply_to":"da36d5c6_16cc9888","updated":"2017-03-15 11:00:00.000000000","message":"IMO, at least we can verify that all needed config options are available. I\u0027ll add it do the spec","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Implement \u0027init_host\u0027 method in a backup manager"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Implement \u0027do_setup\u0027 method in a base backup driver with won\u0027t do anything"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Implement \u0027do_setup\u0027 in the each backup driver."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_161e580c","line":116,"range":{"start_line":116,"start_character":54,"end_line":116,"end_character":58},"updated":"2017-02-20 19:58:17.000000000","message":"which","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"* Implement \u0027init_host\u0027 method in a backup manager"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Implement \u0027do_setup\u0027 method in a base backup driver with won\u0027t do anything"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Implement \u0027do_setup\u0027 in the each backup driver."},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_e6cea0b3","line":116,"range":{"start_line":116,"start_character":54,"end_line":116,"end_character":58},"in_reply_to":"da36d5c6_161e580c","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"726d6f44b210a2a9d1483ad6541986c875cf3178","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Implement \u0027do_setup\u0027 method in a base backup driver with won\u0027t do anything"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Implement \u0027do_setup\u0027 in the each backup driver."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_b6dd8c44","line":118,"range":{"start_line":118,"start_character":26,"end_line":118,"end_character":29},"updated":"2017-02-20 19:58:17.000000000","message":"remove","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d725cd683396221f557bed10edcf7ef73a5631b1","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"* Implement \u0027do_setup\u0027 method in a base backup driver with won\u0027t do anything"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Implement \u0027do_setup\u0027 in the each backup driver."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a1ced50_a662e8ab","line":118,"range":{"start_line":118,"start_character":26,"end_line":118,"end_character":29},"in_reply_to":"da36d5c6_b6dd8c44","updated":"2017-03-16 16:24:07.000000000","message":"Done","commit_id":"9122665d3de52308a8fa344219fad89befe515d7"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"We should introduce for cinder backups the same mechanism as we\u0027ve got for"},{"line_number":35,"context_line":"volume manager and drivers:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Introduce \u0027init_host\u0027 method in backup manager which will be called on"},{"line_number":38,"context_line":"  service startup and verify that backup driver is initialized: verify driver\u0027s"},{"line_number":39,"context_line":"  configuration is correct, depends on driver, we could check connection to"},{"line_number":40,"context_line":"  storage, list of available backups. etc."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_5fd99c82","line":38,"range":{"start_line":37,"start_character":2,"end_line":38,"end_character":17},"updated":"2017-04-06 11:11:53.000000000","message":"#mark1","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_32745135","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":41},"updated":"2017-04-06 11:11:53.000000000","message":"Also, due to this line [0] we can\u0027t set period less, that periodic_interval parameter and this parameter the same for all services.\n\n[0] - https://github.com/openstack/cinder/blob/08eb26589ed7867af5d8386b20d47480a9516379/cinder/service.py#L302","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_df8bcc1c","line":46,"range":{"start_line":46,"start_character":41,"end_line":46,"end_character":42},"updated":"2017-04-06 11:11:53.000000000","message":"nit: n missed","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fe8641213bc712f8e0e5b62c7b68ec5e5d7b11bd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_812fd53d","line":46,"range":{"start_line":46,"start_character":41,"end_line":46,"end_character":42},"in_reply_to":"1a1ced50_df8bcc1c","updated":"2017-05-23 12:49:22.000000000","message":"Done","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fe8641213bc712f8e0e5b62c7b68ec5e5d7b11bd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  as \u0027down\u0027."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_c1a94d7c","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":41},"in_reply_to":"bff0334d_32745135","updated":"2017-05-23 12:49:22.000000000","message":"Done","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_bf8ff021","line":48,"range":{"start_line":48,"start_character":72,"end_line":48,"end_character":76},"updated":"2017-04-06 11:11:53.000000000","message":"duplicated word","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fe8641213bc712f8e0e5b62c7b68ec5e5d7b11bd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_41af7d7c","line":48,"range":{"start_line":48,"start_character":72,"end_line":48,"end_character":76},"in_reply_to":"1a1ced50_bf8ff021","updated":"2017-05-23 12:49:22.000000000","message":"Done","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bff0334d_770acb26","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":42},"updated":"2017-04-06 11:11:53.000000000","message":"Now for all services we have opt called \u0027service_down_time\u0027. So  we can whether stay with this opt or change it just for c-bak service.","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fe8641213bc712f8e0e5b62c7b68ec5e5d7b11bd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In case of initialization failure, cinder will try to do it periodically"},{"line_number":46,"context_line":"depends on \u0027backup_periodic_initializatio\u0027 config option value."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backup service should be initialized in \u0027backup_initialization_timeout\u0027 time"},{"line_number":49,"context_line":"time interval or will be marked as \u0027down\u0027."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Alternatives"},{"line_number":52,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_e1c9f158","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":42},"in_reply_to":"bff0334d_770acb26","updated":"2017-05-23 12:49:22.000000000","message":"Done","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e35bf5b395b40249afafc625ea0e938c42b3b85d","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* Implement \u0027do_setup\u0027 in each backup driver."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Call driver\u0027s \u0027do_setup\u0027 during backup-manager \u0027init_host\u0027 call."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a1ced50_9fba3409","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":66},"updated":"2017-04-06 11:11:53.000000000","message":"#mark1 contradicts with this proposition.","commit_id":"82a66713e88382770f24d393ec53789508d514b4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"fe8641213bc712f8e0e5b62c7b68ec5e5d7b11bd","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"* Implement \u0027do_setup\u0027 in each backup driver."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"* Call driver\u0027s \u0027do_setup\u0027 during backup-manager \u0027init_host\u0027 call."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff0f0b1f_c1c26d34","line":121,"range":{"start_line":121,"start_character":2,"end_line":121,"end_character":66},"in_reply_to":"1a1ced50_9fba3409","updated":"2017-05-23 12:49:22.000000000","message":"Done","commit_id":"82a66713e88382770f24d393ec53789508d514b4"}]}