)]}'
{"specs/pike/generalized_list_filters.rst":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9e5bd290eb33afc307a64a8ba38b93b00eed6942","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Security impact"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":"None that I\u0027m aware of"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Notifications impact"},{"line_number":96,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a2f641d5","line":93,"updated":"2017-03-07 10:52:37.000000000","message":"nice comment :)","commit_id":"ee6c3a5b8fa84a5356a8f2836c98cf26a6953fcd"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9e5bd290eb33afc307a64a8ba38b93b00eed6942","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Other end user impact"},{"line_number":100,"context_line":"---------------------"},{"line_number":101,"context_line":"Life would be better"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Performance Impact"},{"line_number":104,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_022c6d49","line":101,"updated":"2017-03-07 10:52:37.000000000","message":"+2 :)","commit_id":"ee6c3a5b8fa84a5356a8f2836c98cf26a6953fcd"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9e5bd290eb33afc307a64a8ba38b93b00eed6942","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Testing"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Documentation Impact"},{"line_number":138,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a30ddce_a21d6111","line":135,"updated":"2017-03-07 10:52:37.000000000","message":"Let\u0027s users to test","commit_id":"ee6c3a5b8fa84a5356a8f2836c98cf26a6953fcd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af59f8bd126baf26f50bd6c6a5e89628432e2dfd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"We continue adding various filter options to the Cinder List API\u0027s.  Things"},{"line_number":16,"context_line":"like \"filter results by x\u003dy\".  This results in a good deal of code being"},{"line_number":17,"context_line":"added for one-off preferences or user convenience.  It also means that we"},{"line_number":18,"context_line":"continue to bump micro-versions for such additions and create more versions"},{"line_number":19,"context_line":"of the API than we probably care to document, test and maintain."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_1d5dfe46","line":16,"updated":"2017-03-22 15:50:45.000000000","message":"Can you give some examples of these additions?","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af59f8bd126baf26f50bd6c6a5e89628432e2dfd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"in the request body based on what micro-version is specified."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The biggest area of churn for this sort of thing is in the client side of"},{"line_number":26,"context_line":"things."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_38c9e859","line":26,"updated":"2017-03-22 15:50:45.000000000","message":"So is the implicit suggestion here to decide we aren\u0027t going to add certain kinds of filtering APIs on the server or client?\n\nThis section talks about churn and maintenance burden but it\u0027s not really clear how this gets solved, because the spec doesn\u0027t spell out specific things we will decide to not do going forward.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c8a248b88699a93a7c82c81bdea4373d488725f8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"in the request body based on what micro-version is specified."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The biggest area of churn for this sort of thing is in the client side of"},{"line_number":26,"context_line":"things."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ff73747_6a81798f","line":26,"in_reply_to":"1a1ced50_38c9e859","updated":"2017-04-26 14:18:12.000000000","message":"The proposed change area talks about how he is going to eliminate future additions in the same vein as what\u0027s been done, re: churn.   By making this generic, anyone can filter on anything using the new API, and thus avoiding all of the one off API microversion bumping, just to filter on yet another field.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af59f8bd126baf26f50bd6c6a5e89628432e2dfd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"------------"},{"line_number":73,"context_line":"* We could certainly continue doing what we\u0027re doing now and just adding"},{"line_number":74,"context_line":"  specific filter arguments to the clients and the API, but I don\u0027t think"},{"line_number":75,"context_line":"  that\u0027s sustainable."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* We could provide a generalized \"filters\" (pick a better name) controller"},{"line_number":78,"context_line":"  that could be called directly and then call the specified resource item"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_b8531816","line":75,"updated":"2017-03-22 15:50:45.000000000","message":"While adding pre-defined filters may be useful, I don\u0027t see how we can avoid supporting custom filter queries.\n\nIn a lot of cases it will be better to just be able to send a request for what info you want as a client, rather than have to create a filter on the server, maintain state/knowledge in your client that that filter exists, the id needed to use it, etc...","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"665f7b234b35296c76b9fe5acb6ef6f55f916986","unresolved":false,"context_lines":[{"line_number":72,"context_line":"------------"},{"line_number":73,"context_line":"* We could certainly continue doing what we\u0027re doing now and just adding"},{"line_number":74,"context_line":"  specific filter arguments to the clients and the API, but I don\u0027t think"},{"line_number":75,"context_line":"  that\u0027s sustainable."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* We could provide a generalized \"filters\" (pick a better name) controller"},{"line_number":78,"context_line":"  that could be called directly and then call the specified resource item"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ffe62b97_0108848f","line":75,"in_reply_to":"1a1ced50_6de71fac","updated":"2017-03-27 21:58:34.000000000","message":"Yeah, I think this confusion is rooted in the fact that this spec talks about \"filters\" but it doesn\u0027t really mean \"filters\" exactly: it means keys/fields that you can use to create filters.\n\nThat makes a lot more sense than how I initially read this.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"dbb053fa5d3dad837e00d8fe252f0dca9464749e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"------------"},{"line_number":73,"context_line":"* We could certainly continue doing what we\u0027re doing now and just adding"},{"line_number":74,"context_line":"  specific filter arguments to the clients and the API, but I don\u0027t think"},{"line_number":75,"context_line":"  that\u0027s sustainable."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* We could provide a generalized \"filters\" (pick a better name) controller"},{"line_number":78,"context_line":"  that could be called directly and then call the specified resource item"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_6de71fac","line":75,"in_reply_to":"1a1ced50_b8531816","updated":"2017-03-22 17:06:15.000000000","message":"I am not sure you and I understand what is being proposed in the same way, Eric.\n\nAs far as I can tell, John is basically bothered by the fact we keep bumping the API to add another field you can filter on. Rather than continuing down that path, he has added an API call to list what you can currently filter on, and made it configu8rable.\n\nI think this is a great idea (discoverable APIs for the win) but that we should think a bit harder about the default field list rather than sticking with the current one. This hasn\u0027t yet caused John any major upset as far as I can tell.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af59f8bd126baf26f50bd6c6a5e89628432e2dfd","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Performance Impact"},{"line_number":115,"context_line":"------------------"},{"line_number":116,"context_line":"None"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Other deployer impact"},{"line_number":119,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_d857f4c7","line":116,"updated":"2017-03-22 15:50:45.000000000","message":"There is a performance impact if we restrict what kinds of filters we are going to add to Cinder -- more data is processed from the db layer, more data ends up being transferred to the client, etc.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"af59f8bd126baf26f50bd6c6a5e89628432e2dfd","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Developer impact"},{"line_number":123,"context_line":"----------------"},{"line_number":124,"context_line":"Life would be better"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_38948841","line":124,"updated":"2017-03-22 15:50:45.000000000","message":"I think this needs input from the Horizon folks, because I suspect they will say they don\u0027t want to maintain state about lists of filters that are available, and would prefer to just request the desired info as they do currently.","commit_id":"18351a960b0167528620d515f045b3aaa6486ba8"}]}
