)]}'
{"specs/pike/add-like-filter.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a18b7bf764ed0c5bfe5973bfd1a3a313319a1c8e","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Although we can provide filtering resource based on regex filter, but there"},{"line_number":36,"context_line":"is a possibility that we could have ReDos `[3]`_ attack. Considering the"},{"line_number":37,"context_line":"\u0027LIKE\u0027 operator is flexible and safe enough for this case. We could only"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffe62b97_2c993f78","line":34,"updated":"2017-03-27 22:25:58.000000000","message":"Will it also support \"NOT LIKE\"?  I think this is worth mentioning in here.","commit_id":"b49a08ae86d076957af7b54ba405dc134ef58e26"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f5d46c0904936561b35091885279b0b7003be682","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Although we can provide filtering resource based on regex filter, but there"},{"line_number":36,"context_line":"is a possibility that we could have ReDos `[3]`_ attack. Considering the"},{"line_number":37,"context_line":"\u0027LIKE\u0027 operator is flexible and safe enough for this case. We could only"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ffe62b97_b128ee96","line":34,"in_reply_to":"ffe62b97_2c993f78","updated":"2017-03-28 12:34:12.000000000","message":"Thanks, that\u0027s definitely a great idea, I mentioned this case in the latest patch.","commit_id":"b49a08ae86d076957af7b54ba405dc134ef58e26"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0c15418eb6878c2b4d93596b5afff045299c94f1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\u0027volume_preserved_01\u0027, \u0027volume_preserved_02\u0027, usually we would get none of"},{"line_number":60,"context_line":"them if type this command::"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    cinder list --name volume_preserved"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"But within this feature merged, we would have both of them with the identical"},{"line_number":65,"context_line":"command."}],"source_content_type":"text/x-rst","patch_set":15,"id":"bff0334d_0821849f","line":62,"range":{"start_line":62,"start_character":4,"end_line":62,"end_character":39},"updated":"2017-04-11 17:27:16.000000000","message":"You\u0027re proposing we change semantics of an existing \"exact\" filter.... This may be confusing for users to use... \n\nHow would I use these filters to get specific records if the meaning of this filter is overloaded to say \"anything that includes the value i provide\"?\n\nI would suggest we leave existing filtering as is, and propose a different way to specify non-exact filters, something along the lines of:\n\n  cinder list --name-like volume_preserved\n\nand\n\n  cinder list --name volume_preserved\n\n\n  i.e, GET /volumes?name-like\u003dvolume_preserved\n \n\n\nThese could be derivative filters, i.e, not every filter will support \"-like\", and it works well with John\u0027s proposal if you can tag these filters as separate from the exact filters in the json file that administrators can control.","commit_id":"06bcd5df07eed7afdf5529ca891a532a53fd83f9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"399e254d75929d12d2d4f24cabba033b0f23588a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"below::"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"     cinder list --filters name\u003dvolume_preserved   #exact matches"},{"line_number":61,"context_line":"     cinder list --filters ~name\u003dvolume_preserved  #inexact matches"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"assuming we have two volumes in the name of \u0027volume_preserved_01\u0027,"},{"line_number":64,"context_line":"\u0027volume_preserved_02\u0027, so with first command we will get none of"}],"source_content_type":"text/x-rst","patch_set":16,"id":"9ff52f3f_5d737ce8","line":61,"updated":"2017-04-13 14:45:42.000000000","message":"Will this also support queries such as\n   name LIKE _a%\n\nWhere underscore is a single character, etc.?  (Standard SQL syntax.)\n\nHow much the end-user interface really matches SQL LIKE is not clear.","commit_id":"c65ec1b660d8b0352b6afe79693e7599385a2093"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d513ad9d69add865a55138b424b803098a692c9f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"There is an option that we can deploy searchlight which mainly focus on"},{"line_number":72,"context_line":"various cloud resource querying, and that\u0027s a more widely topic. But we"},{"line_number":73,"context_line":"should also consider the cloud environment that don\u0027t (don\u0027t wanna"},{"line_number":74,"context_line":"have a searchlight."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Also, there is another option that user can gather all the raw data and"}],"source_content_type":"text/x-rst","patch_set":16,"id":"bff0334d_407cd570","line":73,"range":{"start_line":73,"start_character":55,"end_line":73,"end_character":66},"updated":"2017-04-12 18:43:25.000000000","message":"I think Duncan\u0027s suggestion would be better to make this \"doesn\u0027t wish to\". Also, no closing )","commit_id":"c65ec1b660d8b0352b6afe79693e7599385a2093"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fc7ccc0a721d3c98ffb6b7942a26635b20f2865d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"\u0027~\u0027 here means the attribute \u0027name\u0027 supports query with like operator (not"},{"line_number":57,"context_line":"indicating the regex operator),  once this is configured, the input"},{"line_number":58,"context_line":"key-value pair ``name~\u003dvalue`` from API will finally be translated into this"},{"line_number":59,"context_line":"sql statement::"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # \u0027%\u0027 is automatically appended at both sides"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7ffa3b31_f5e26c2f","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":23},"updated":"2017-04-14 13:37:40.000000000","message":"+1 I like this format better thank leading with the ~","commit_id":"fb3609cd4cb88fc3b6e4fd021e7bef1a7c629f7b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fc7ccc0a721d3c98ffb6b7942a26635b20f2865d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"There is an option that we can deploy searchlight which mainly focus on"},{"line_number":79,"context_line":"various cloud resource querying, and that\u0027s a more widely topic. But we"},{"line_number":80,"context_line":"should also consider the cloud environment that doesn\u0027t wanna have a"},{"line_number":81,"context_line":"searchlight."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Also, there is another option that user can gather all the raw data and"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7ffa3b31_95f20806","line":80,"range":{"start_line":80,"start_character":56,"end_line":80,"end_character":61},"updated":"2017-04-14 13:37:40.000000000","message":"\"wanna\" is a very informal, almost slang form, of the more accurate \"want to\". English teachers would not approve. :)\n\nI\u0027m not an English teacher though.","commit_id":"fb3609cd4cb88fc3b6e4fd021e7bef1a7c629f7b"}],"specs/pike/regexp-based-filter.rst":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"82a75a46d6390e800374f9f7007e560a9e049e6b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Security impact"},{"line_number":98,"context_line":"---------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"None"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Other end user impact"},{"line_number":103,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_a4637619","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":4},"updated":"2017-03-08 10:28:32.000000000","message":"There is definitely a security impact here. Pathalogical regexs leading to DoS of the API service is a well known attack vector.\n\nhttps://en.wikipedia.org/wiki/ReDoS","commit_id":"7cbfd5288a34489431e6305a885901b49a571a87"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6c7c6aebddb2d266e01308c68208b5acb28d2d0a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Alternatives"},{"line_number":61,"context_line":"------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Do not add this feature, and user continually had an inconvenient experience"},{"line_number":64,"context_line":"of retrieving desired volumes."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Data model impact"},{"line_number":67,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_ee2de446","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":30},"updated":"2017-03-10 17:43:11.000000000","message":"Another alternative is to deploy searchlight, which already gives you this searching and more, and is build on top of a storage engine intended for this kind of searching","commit_id":"0a2661c98a19d61276eec39f5e507f1222eac2e3"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6c7c6aebddb2d266e01308c68208b5acb28d2d0a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"Security impact"},{"line_number":84,"context_line":"---------------"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"We could have ReDos `[5]`_ attack, so does nova and other projects"},{"line_number":87,"context_line":"that introduced this feature, but we can wrap the filter logic with"},{"line_number":88,"context_line":"timeout exception in order to quit querying before it consumes"},{"line_number":89,"context_line":"too many resources."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Notifications impact"},{"line_number":92,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_ceeca0f5","line":89,"range":{"start_line":86,"start_character":0,"end_line":89,"end_character":19},"updated":"2017-03-10 17:43:11.000000000","message":"How do you add a timeout to a query that is running in the database, not the local process? Simply terminating the local connection to the db generally does not immediately terminate the running query, particularly if that running query is stuck in some pathological search matching.","commit_id":"0a2661c98a19d61276eec39f5e507f1222eac2e3"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"12ec039aeac43ec77f5301c274d285354999e64e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"There is another option that we can deploy searchlight which mainly focus on"},{"line_number":64,"context_line":"various cloud resource querying, and that\u0027s a more widely topic. But we should"},{"line_number":65,"context_line":"also consider the cloud environment that don\u0027t (don\u0027t wanna) have a"},{"line_number":66,"context_line":"searchlight."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a30ddce_aa23abbb","line":65,"range":{"start_line":65,"start_character":54,"end_line":65,"end_character":59},"updated":"2017-03-13 08:39:50.000000000","message":"Nit: colloquialism: formal \"doesn\u0027t wish to\"","commit_id":"f9306a9b4f745be1425b1051043e3d7ecb86b054"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"f3debb3ecafda7d77d04fdda6fbb5a0e77e873df","unresolved":false,"context_lines":[{"line_number":64,"context_line":"various cloud resource querying, and that\u0027s a more widely topic. But we should"},{"line_number":65,"context_line":"also consider the cloud environment that don\u0027t (don\u0027t wanna) have a"},{"line_number":66,"context_line":"searchlight."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Data model impact"},{"line_number":70,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a30ddce_819ec060","line":67,"updated":"2017-03-13 14:04:14.000000000","message":"There\u0027s a 3\u0027rd option as well, use the API as an API to gather raw data and implement filtering/regex parsing yourself on top of that.","commit_id":"f9306a9b4f745be1425b1051043e3d7ecb86b054"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"12ec039aeac43ec77f5301c274d285354999e64e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"We could have ReDos `[5]`_ attack, so does nova and other projects"},{"line_number":90,"context_line":"that introduced this feature. Restrict this only to \u0027LIKE\u0027 operation"},{"line_number":91,"context_line":"would avoid this (any better suggestion?)."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Notifications impact"},{"line_number":94,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a30ddce_0a34b7f9","line":91,"range":{"start_line":91,"start_character":18,"end_line":91,"end_character":39},"updated":"2017-03-13 08:39:50.000000000","message":"Sorry I don\u0027t have a solution, only an awareness of the issue :-(","commit_id":"f9306a9b4f745be1425b1051043e3d7ecb86b054"}]}
