)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8251fc0ea0f5f44675e0a766edb41b1b4814ff9f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Provisioning Improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Spec to add support for standard over-provisioning calculations and make all"},{"line_number":10,"context_line":"drivers status reports consistent between different backends."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie709333d75fb8c1c4693eae7d09d7f4925dc3fca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf3e73b7_facb766f","line":9,"updated":"2017-08-05 14:14:32.000000000","message":"Wrap at 72 chars.\n\ns/standard/standardize","commit_id":"f05a7161e56352ef3d59ebba2daaa1dd03bec60d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a96ce5eb77a0bff46a5354e07988593f0b7c80a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Provisioning Improvements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Spec to add support for standard over-provisioning calculations and make all"},{"line_number":10,"context_line":"drivers status reports consistent between different backends."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie709333d75fb8c1c4693eae7d09d7f4925dc3fca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_a60dba3f","line":9,"in_reply_to":"bf3e73b7_facb766f","updated":"2017-08-23 10:54:38.000000000","message":"Done","commit_id":"f05a7161e56352ef3d59ebba2daaa1dd03bec60d"}],"specs/queens/provisioning-improvements.rst":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8251fc0ea0f5f44675e0a766edb41b1b4814ff9f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  if the volume is still there and will still be counted in the"},{"line_number":143,"context_line":"  `provisioned_capacity_gb`."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  This is an optional field, so if a driver does not report it the scheduler"},{"line_number":146,"context_line":"  will assume that the storage array\u0027s pool is only being used by Cinder and"},{"line_number":147,"context_line":"  will assign it the same value as `provisioned_capacity_gb`."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  The reason why we don\u0027t currently calculate this directly using the DB is to"},{"line_number":150,"context_line":"  avoid out of sync errors between the Cinder DB and the storage array\u0027s pool"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf3e73b7_7a7d46e6","line":147,"range":{"start_line":145,"start_character":2,"end_line":147,"end_character":61},"updated":"2017-08-05 14:14:32.000000000","message":"Actually driver should not be reporting this.  This should be calculated by the volume manager/scheduler.  This is used for the allocated capacity weigher only:\n\nhttps://github.com/openstack/cinder/commit/254e37ab3c995f6514084d38f2f797da9cf5e5a9","commit_id":"f05a7161e56352ef3d59ebba2daaa1dd03bec60d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a96ce5eb77a0bff46a5354e07988593f0b7c80a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  if the volume is still there and will still be counted in the"},{"line_number":143,"context_line":"  `provisioned_capacity_gb`."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  This is an optional field, so if a driver does not report it the scheduler"},{"line_number":146,"context_line":"  will assume that the storage array\u0027s pool is only being used by Cinder and"},{"line_number":147,"context_line":"  will assign it the same value as `provisioned_capacity_gb`."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  The reason why we don\u0027t currently calculate this directly using the DB is to"},{"line_number":150,"context_line":"  avoid out of sync errors between the Cinder DB and the storage array\u0027s pool"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f287b81_c65e86e5","line":147,"range":{"start_line":145,"start_character":2,"end_line":147,"end_character":61},"in_reply_to":"bf3e73b7_7a7d46e6","updated":"2017-08-23 10:54:38.000000000","message":"Thanks for the clarification!!  I didn\u0027t know that was supposed to be the case looking at the code because:\n\n- At least 7 drivers reporting allocated_capacity_gb with whatever data they think should go there (xio, storwize, remotefs, vmax, etc.)\n- Cinder core code doesn\u0027t properly handle reporting of allocated_capacity_gb on all cases, for example it doesn\u0027t work with RBD.\n\nI\u0027ll update the spec, write a bug for the reporting of the allocated_capacity_gb and fix it.","commit_id":"f05a7161e56352ef3d59ebba2daaa1dd03bec60d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This spec will build on those that preceded it on the same topic [1]_ [2]_ and"},{"line_number":23,"context_line":"others related to the subject [3]_ to bring a consolidated and updated view on"},{"line_number":24,"context_line":"the matter as well as add a some minor improvements and fix some issues a in"},{"line_number":25,"context_line":"hopes that we can provide a better experience for all involved."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_c65b242c","line":24,"range":{"start_line":24,"start_character":72,"end_line":24,"end_character":74},"updated":"2017-09-11 20:34:47.000000000","message":"Remove \"a\".","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This spec will build on those that preceded it on the same topic [1]_ [2]_ and"},{"line_number":23,"context_line":"others related to the subject [3]_ to bring a consolidated and updated view on"},{"line_number":24,"context_line":"the matter as well as add a some minor improvements and fix some issues a in"},{"line_number":25,"context_line":"hopes that we can provide a better experience for all involved."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_c85dc847","line":24,"range":{"start_line":24,"start_character":72,"end_line":24,"end_character":74},"in_reply_to":"5f2577a7_c65b242c","updated":"2017-09-29 11:42:11.000000000","message":"Done","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  and will be ignored for thick provisioned."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  This is currently being reported by the drivers as"},{"line_number":161,"context_line":"  `max_over_subscrition_ratio` with a greater or equal value to 1.0, preferably"},{"line_number":162,"context_line":"  with no more than a 2 decimal precision."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  This value is optional, and when missing from the driver\u0027s status report the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_86699c26","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":23},"updated":"2017-09-11 20:34:47.000000000","message":"s/subscrition/subscription","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  and will be ignored for thick provisioned."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  This is currently being reported by the drivers as"},{"line_number":161,"context_line":"  `max_over_subscrition_ratio` with a greater or equal value to 1.0, preferably"},{"line_number":162,"context_line":"  with no more than a 2 decimal precision."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  This value is optional, and when missing from the driver\u0027s status report the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_c82268b9","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":23},"in_reply_to":"5f2577a7_86699c26","updated":"2017-09-29 11:42:11.000000000","message":"Done","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":191,"context_line":"  least in their capabilities report."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  The way to report support for these is setting to true the boolean fields"},{"line_number":194,"context_line":"  `thin_provisioning_support` and/or `thick_provisioinin_support`.  And non"},{"line_number":195,"context_line":"  reported provisioning types will default to false."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  A Cinder backend may support both provisioning types at the same time."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_c6d564bb","line":194,"range":{"start_line":194,"start_character":44,"end_line":194,"end_character":56},"updated":"2017-09-11 20:34:47.000000000","message":"s/provisioinin/provisioning","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":191,"context_line":"  least in their capabilities report."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"  The way to report support for these is setting to true the boolean fields"},{"line_number":194,"context_line":"  `thin_provisioning_support` and/or `thick_provisioinin_support`.  And non"},{"line_number":195,"context_line":"  reported provisioning types will default to false."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  A Cinder backend may support both provisioning types at the same time."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_a82deca8","line":194,"range":{"start_line":194,"start_character":44,"end_line":194,"end_character":56},"in_reply_to":"5f2577a7_c6d564bb","updated":"2017-09-29 11:42:11.000000000","message":"Done","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":269,"context_line":"Use Cases"},{"line_number":270,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"The basic case for fixing the status report is were we would like to have"},{"line_number":273,"context_line":"consistent reporting from our backends for the admins to see in the logs and"},{"line_number":274,"context_line":"for the scheduler to use."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_bae6ece7","line":272,"range":{"start_line":272,"start_character":47,"end_line":272,"end_character":51},"updated":"2017-09-11 20:34:47.000000000","message":"?","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":269,"context_line":"Use Cases"},{"line_number":270,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"The basic case for fixing the status report is were we would like to have"},{"line_number":273,"context_line":"consistent reporting from our backends for the admins to see in the logs and"},{"line_number":274,"context_line":"for the scheduler to use."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_8828f096","line":272,"range":{"start_line":272,"start_character":47,"end_line":272,"end_character":51},"in_reply_to":"5f2577a7_bae6ece7","updated":"2017-09-29 11:42:11.000000000","message":"where","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"The new optional fields that drivers will be able report are:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- `total_used_capacity_gb`: Contains the physical capacity used in the storage"},{"line_number":298,"context_line":"  array by all the *volumes and snapshots* present in the pool that Cinder is"},{"line_number":299,"context_line":"  currently using.  Reported as a real number with a precision no greater than"},{"line_number":300,"context_line":"  2 decimals."},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"- `cinder_used_capacity_gb`: Contains the physical capacity used in the storage"},{"line_number":303,"context_line":"  array by all the *volumes and snapshots* that Cinder has created and are"},{"line_number":304,"context_line":"  present in the pool that is currently using.  Reported as a real number with"},{"line_number":305,"context_line":"  a precision no greater than 2 decimals."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Since reporting these fields could have performance penalties and not all"},{"line_number":308,"context_line":"admins may be willing to suffer it, we will also add a Cinder configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_da2f78f4","line":305,"range":{"start_line":297,"start_character":0,"end_line":305,"end_character":41},"updated":"2017-09-11 20:34:47.000000000","message":"I think adding new fields will make it more confusing to people.  We are not using these new fields in the scheduler, why reporting them?  Every new concept will add complexity so I don\u0027t support adding new ones if not absolutely necessary.","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"The new optional fields that drivers will be able report are:"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"- `total_used_capacity_gb`: Contains the physical capacity used in the storage"},{"line_number":298,"context_line":"  array by all the *volumes and snapshots* present in the pool that Cinder is"},{"line_number":299,"context_line":"  currently using.  Reported as a real number with a precision no greater than"},{"line_number":300,"context_line":"  2 decimals."},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"- `cinder_used_capacity_gb`: Contains the physical capacity used in the storage"},{"line_number":303,"context_line":"  array by all the *volumes and snapshots* that Cinder has created and are"},{"line_number":304,"context_line":"  present in the pool that is currently using.  Reported as a real number with"},{"line_number":305,"context_line":"  a precision no greater than 2 decimals."},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"Since reporting these fields could have performance penalties and not all"},{"line_number":308,"context_line":"admins may be willing to suffer it, we will also add a Cinder configuration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_4820b8ac","line":305,"range":{"start_line":297,"start_character":0,"end_line":305,"end_character":41},"in_reply_to":"5f2577a7_da2f78f4","updated":"2017-09-29 11:42:11.000000000","message":"OK, I\u0027ll remove all new fields and leave it as it is.","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b84b9e4ace94412909e03eb1db863b3a367b3ecf","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":328,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":329,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":330,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":331,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":332,"context_line":"one of the mechanism to use."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f2577a7_532133b4","line":329,"range":{"start_line":329,"start_character":29,"end_line":329,"end_character":58},"updated":"2017-09-11 20:34:47.000000000","message":"I think we are making this more confusing by adding another option.","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86b2d18abc49a7c4bc81e8ceb0ba36a3cf8be718","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":328,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":329,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":330,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":331,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":332,"context_line":"one of the mechanism to use."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_7b5d8013","line":329,"range":{"start_line":329,"start_character":29,"end_line":329,"end_character":58},"in_reply_to":"5f2577a7_532133b4","updated":"2017-09-29 11:42:11.000000000","message":"Considering how we have this discussion with operators and developers a couple of times per release I think it\u0027s best to stop the discussion and make it possible to have both mechanism.","commit_id":"9d8a0690588b27569a5ecf60a2dd3d02c96301ee"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  as the name indicates, should be reported in GB and with a precision no"},{"line_number":71,"context_line":"  greater than 2 decimals."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  If the storage array has 5TB of space but the pool used in Cinder has is"},{"line_number":74,"context_line":"  limited to 1TB then the driver should be reporting a `total_capacity_gb` of"},{"line_number":75,"context_line":"  1024GB."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_0a43d014","line":73,"range":{"start_line":73,"start_character":68,"end_line":73,"end_character":71},"updated":"2017-09-29 16:14:03.000000000","message":"remove \u0027has\u0027","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  as the name indicates, should be reported in GB and with a precision no"},{"line_number":71,"context_line":"  greater than 2 decimals."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  If the storage array has 5TB of space but the pool used in Cinder has is"},{"line_number":74,"context_line":"  limited to 1TB then the driver should be reporting a `total_capacity_gb` of"},{"line_number":75,"context_line":"  1024GB."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_106f572b","line":73,"range":{"start_line":73,"start_character":68,"end_line":73,"end_character":71},"in_reply_to":"7f515b1d_0a43d014","updated":"2017-10-03 08:27:22.000000000","message":"Done","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"eb6cbbe8946ab1ed4314a8eca60a2a504e2486dd","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  20GB each.  In this situation our reported `provisioned_capacity_gb` value"},{"line_number":120,"context_line":"  should be 924GB ((124 * 1GB) + (400 * 1GB) + (20 * 20GB))."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  If a driver does not reported the `provisioned_capacity_gb` data we\u0027ll use"},{"line_number":123,"context_line":"  the automatically calculated `allocated_capacity_gb` as described below."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Allocated capacity:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_9e202af9","line":122,"range":{"start_line":122,"start_character":2,"end_line":122,"end_character":61},"updated":"2017-11-21 12:11:29.000000000","message":"How is that? If this is a required field as described above we shouldn\u0027t need to use any other value right? I\u0027m assuming then that this (all drivers reporting provisioned_capacity_gb) is the way it should be, but some are not reporting right?","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  20GB each.  In this situation our reported `provisioned_capacity_gb` value"},{"line_number":120,"context_line":"  should be 924GB ((124 * 1GB) + (400 * 1GB) + (20 * 20GB))."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  If a driver does not reported the `provisioned_capacity_gb` data we\u0027ll use"},{"line_number":123,"context_line":"  the automatically calculated `allocated_capacity_gb` as described below."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Allocated capacity:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_aa015cb1","line":122,"range":{"start_line":122,"start_character":23,"end_line":122,"end_character":31},"updated":"2017-09-29 16:14:03.000000000","message":"report","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  20GB each.  In this situation our reported `provisioned_capacity_gb` value"},{"line_number":120,"context_line":"  should be 924GB ((124 * 1GB) + (400 * 1GB) + (20 * 20GB))."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"  If a driver does not reported the `provisioned_capacity_gb` data we\u0027ll use"},{"line_number":123,"context_line":"  the automatically calculated `allocated_capacity_gb` as described below."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Allocated capacity:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_f0695b24","line":122,"range":{"start_line":122,"start_character":23,"end_line":122,"end_character":31},"in_reply_to":"7f515b1d_aa015cb1","updated":"2017-10-03 08:27:22.000000000","message":"Done","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  But if our deployment is using a backend that is supporting both provisioning"},{"line_number":209,"context_line":"  types simultaneously we need to be explicit about the type of provisioning we"},{"line_number":210,"context_line":"  want for a volume using the volume type\u0027s the extra spec `provisioning:type`"},{"line_number":211,"context_line":"  and setting it to `thin` or `thick`."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"  If no `provisioning:type` is defined for a volume it will default to thin if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_ead2b427","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"updated":"2017-09-29 16:14:03.000000000","message":"remove \u0027the\u0027","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  But if our deployment is using a backend that is supporting both provisioning"},{"line_number":209,"context_line":"  types simultaneously we need to be explicit about the type of provisioning we"},{"line_number":210,"context_line":"  want for a volume using the volume type\u0027s the extra spec `provisioning:type`"},{"line_number":211,"context_line":"  and setting it to `thin` or `thick`."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"  If no `provisioning:type` is defined for a volume it will default to thin if"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_d0741f00","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"in_reply_to":"7f515b1d_ead2b427","updated":"2017-10-03 08:27:22.000000000","message":"Done","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":413,"context_line":"`allocated_capacity_gb` and `provisioned_capacity_gb` we may experience"},{"line_number":414,"context_line":"failures on creating volumes until we correct the values of"},{"line_number":415,"context_line":"`reserved_percentage` and `max_over_subscrition_ratio` in our cloud to the"},{"line_number":416,"context_line":"right values, since we may have been used incorrect ones."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"Two new configuration options will be added:"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_caf7f88a","line":416,"range":{"start_line":416,"start_character":37,"end_line":416,"end_character":51},"updated":"2017-09-29 16:14:03.000000000","message":"used to incorrect","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":413,"context_line":"`allocated_capacity_gb` and `provisioned_capacity_gb` we may experience"},{"line_number":414,"context_line":"failures on creating volumes until we correct the values of"},{"line_number":415,"context_line":"`reserved_percentage` and `max_over_subscrition_ratio` in our cloud to the"},{"line_number":416,"context_line":"right values, since we may have been used incorrect ones."},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"Two new configuration options will be added:"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_7067ab4e","line":416,"range":{"start_line":416,"start_character":37,"end_line":416,"end_character":51},"in_reply_to":"7f515b1d_caf7f88a","updated":"2017-10-03 08:27:22.000000000","message":"replaced with \"using incorrect\"","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":448,"context_line":"Work Items"},{"line_number":449,"context_line":"----------"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"* Fix drivers stat reporting"},{"line_number":452,"context_line":"* Add support for the 3 new fields, `provisioned_capacity_precission`,"},{"line_number":453,"context_line":"  `total_used_capacity_gb` and `cinder_used_capacity_gb` in the scheduler, the"},{"line_number":454,"context_line":"  `get_pools` API, and the client."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_0a1070a7","line":451,"range":{"start_line":451,"start_character":2,"end_line":451,"end_character":28},"updated":"2017-09-29 16:14:03.000000000","message":"Can you clarify here.  Are you planning to fix existing drivers that are doing this wrong or are you hoping we will get the developers to fix them?  \n\nIf you are planning to fix all the drivers can you make that more explicit here?\n\nIf you are not planning to fix all of them then we should have a work item to open bugs and attempt to contact those maintainers that are not in compliance.","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":448,"context_line":"Work Items"},{"line_number":449,"context_line":"----------"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"* Fix drivers stat reporting"},{"line_number":452,"context_line":"* Add support for the 3 new fields, `provisioned_capacity_precission`,"},{"line_number":453,"context_line":"  `total_used_capacity_gb` and `cinder_used_capacity_gb` in the scheduler, the"},{"line_number":454,"context_line":"  `get_pools` API, and the client."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_d0909fef","line":451,"range":{"start_line":451,"start_character":2,"end_line":451,"end_character":28},"in_reply_to":"7f515b1d_0a1070a7","updated":"2017-10-03 08:27:22.000000000","message":"I have fixed the RBD driver and assisted with NetApp\u0027s, but I wasn\u0027t planning on fixing all the drivers.  My idea was to make developers fix them: \"all driver maintainers will be urged to make their drivers compliant with it\".\n\nI\u0027ll add the item as the first item of the list.","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1aed7edc811bb7fc02365283534efbcaa3903346","unresolved":false,"context_lines":[{"line_number":457,"context_line":"* Modify `CapacityWeigher` to support standard over-provisioning calculations."},{"line_number":458,"context_line":"* Add to the volume manager the estimation mechanism for drivers that don\u0027t"},{"line_number":459,"context_line":"  report `provisioned_capacity_gb`."},{"line_number":460,"context_line":"* Update all the developers reference docs to ensure that there is no more"},{"line_number":461,"context_line":"  confusion on what the report stats need to return."},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"Dependencies"},{"line_number":464,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_2a5b2c87","line":461,"range":{"start_line":460,"start_character":2,"end_line":461,"end_character":52},"updated":"2017-09-29 16:14:03.000000000","message":"If this Spec is going to be the source of truth for the future can we also have a Work Item to include a link to it from https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver with an explanation of why this is important to understand before writing a driver?","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eb9e9e84c97b3733127cd9ddbe435c3abff8dec3","unresolved":false,"context_lines":[{"line_number":457,"context_line":"* Modify `CapacityWeigher` to support standard over-provisioning calculations."},{"line_number":458,"context_line":"* Add to the volume manager the estimation mechanism for drivers that don\u0027t"},{"line_number":459,"context_line":"  report `provisioned_capacity_gb`."},{"line_number":460,"context_line":"* Update all the developers reference docs to ensure that there is no more"},{"line_number":461,"context_line":"  confusion on what the report stats need to return."},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"Dependencies"},{"line_number":464,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_50b6ef8b","line":461,"range":{"start_line":460,"start_character":2,"end_line":461,"end_character":52},"in_reply_to":"7f515b1d_2a5b2c87","updated":"2017-10-03 08:27:22.000000000","message":"In my head it was included as part of the developers reference, but it\u0027s certainly better to say it explicitly.","commit_id":"918f831c6af3c54f5061aadc943d12d8e3186d59"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"eb6cbbe8946ab1ed4314a8eca60a2a504e2486dd","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  present*."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  This includes not only volumes created by Cinder but also all other existing"},{"line_number":112,"context_line":"  volumes in that backend, but *does not include snapshots*."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  Let\u0027s expand the earlier example from \"free capacity\" where 524GB of the"},{"line_number":115,"context_line":"  available 1TB had already been used, and say that the 124GB that were"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f485f77_ceceee58","line":112,"range":{"start_line":112,"start_character":30,"end_line":112,"end_character":60},"updated":"2017-11-21 12:11:29.000000000","message":"This is somewhat problematic. For some vendors, a snapshot is not different from a clone, and the backend does not have a clean way to calculate only the space allocated for volumes. So, it could have more sense to define the provisioned capacity as the \u0027capacity that would be consumed if all objects in the array where used to its maximum size\u0027.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  present*."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  This includes not only volumes created by Cinder but also all other existing"},{"line_number":112,"context_line":"  volumes in that backend, but *does not include snapshots*."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  Let\u0027s expand the earlier example from \"free capacity\" where 524GB of the"},{"line_number":115,"context_line":"  available 1TB had already been used, and say that the 124GB that were"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_b4271165","line":112,"range":{"start_line":112,"start_character":30,"end_line":112,"end_character":60},"in_reply_to":"1f485f77_ceceee58","updated":"2017-11-21 13:31:47.000000000","message":"I\u0027m just reflecting here what\u0027s been defined since the beginning of times, I haven\u0027t changed it here in any way, and drivers that have been incorrectly doing it should fix their code.\n\nFor example in the RBD driver we resolve this issue by listing the elements present in the pool, then filtering out snapshots based on the element\u0027s name, and use the remaining elements (volumes) to calculate the value we have to return.  (Implementation loop is slightly different, but it\u0027s just that).","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"eb6cbbe8946ab1ed4314a8eca60a2a504e2486dd","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Volume provisioning type:"},{"line_number":199,"context_line":"  For Cinder backends that only support one of the provisioning types all"},{"line_number":200,"context_line":"  volumes created on them will be of that type, and we can use the volume type"},{"line_number":201,"context_line":"  to make the scheduler filter out backends not supporting a specific"},{"line_number":202,"context_line":"  provisioning type:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_fe033a0c","line":200,"range":{"start_line":200,"start_character":67,"end_line":200,"end_character":78},"updated":"2017-11-21 12:11:29.000000000","message":"\u0027volume type extra specs\u0027\nJust to make this a bit more clear.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Volume provisioning type:"},{"line_number":199,"context_line":"  For Cinder backends that only support one of the provisioning types all"},{"line_number":200,"context_line":"  volumes created on them will be of that type, and we can use the volume type"},{"line_number":201,"context_line":"  to make the scheduler filter out backends not supporting a specific"},{"line_number":202,"context_line":"  provisioning type:"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_143cbd91","line":200,"range":{"start_line":200,"start_character":67,"end_line":200,"end_character":78},"in_reply_to":"ff82abbf_fe033a0c","updated":"2017-11-21 13:31:47.000000000","message":"Done","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"eb6cbbe8946ab1ed4314a8eca60a2a504e2486dd","unresolved":false,"context_lines":[{"line_number":236,"context_line":"and report the value directly instead of letting the Cinder core code take care"},{"line_number":237,"context_line":"of it.  Drivers have been known to report here the following information:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Sum of the Cinder volumes\u0027 physical disk usage, which is correct."},{"line_number":240,"context_line":"* Sum of the physical disk usage, which is wrong."},{"line_number":241,"context_line":"* Sum of all the volumes\u0027 max sizes, which is wrong."},{"line_number":242,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f485f77_c9e4a80f","line":239,"range":{"start_line":239,"start_character":29,"end_line":239,"end_character":49},"updated":"2017-11-21 12:11:29.000000000","message":"\"Max size\" which is what cinder uses to calculate this value.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":236,"context_line":"and report the value directly instead of letting the Cinder core code take care"},{"line_number":237,"context_line":"of it.  Drivers have been known to report here the following information:"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Sum of the Cinder volumes\u0027 physical disk usage, which is correct."},{"line_number":240,"context_line":"* Sum of the physical disk usage, which is wrong."},{"line_number":241,"context_line":"* Sum of all the volumes\u0027 max sizes, which is wrong."},{"line_number":242,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_34bf81fc","line":239,"range":{"start_line":239,"start_character":29,"end_line":239,"end_character":49},"in_reply_to":"1f485f77_c9e4a80f","updated":"2017-11-21 13:31:47.000000000","message":"I don\u0027t understand what you mean, I\u0027m listing here things that some drivers are incorrectly reporting in the allocated_capacity_gb field.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"eb6cbbe8946ab1ed4314a8eca60a2a504e2486dd","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Standard provisioning calculation to check if a volume of `volume_size` fits"},{"line_number":252,"context_line":"is::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  ((provisioned_capacity_gb + volume_size] \u003c\u003d"},{"line_number":255,"context_line":"   (total_capacity_gb"},{"line_number":256,"context_line":"    x (1 - (reserved_percentage / 100.0))"},{"line_number":257,"context_line":"    x max_over_subscription_ratio))"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_1ef05ec9","line":254,"range":{"start_line":254,"start_character":41,"end_line":254,"end_character":42},"updated":"2017-11-21 12:11:29.000000000","message":")","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":251,"context_line":"Standard provisioning calculation to check if a volume of `volume_size` fits"},{"line_number":252,"context_line":"is::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  ((provisioned_capacity_gb + volume_size] \u003c\u003d"},{"line_number":255,"context_line":"   (total_capacity_gb"},{"line_number":256,"context_line":"    x (1 - (reserved_percentage / 100.0))"},{"line_number":257,"context_line":"    x max_over_subscription_ratio))"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_34e6a146","line":254,"range":{"start_line":254,"start_character":41,"end_line":254,"end_character":42},"in_reply_to":"ff82abbf_1ef05ec9","updated":"2017-11-21 13:31:47.000000000","message":"Done","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":321,"context_line":"reference when the backend is empty and then, when there is data calculate the"},{"line_number":322,"context_line":"current value on each driver stats report with the following formula::"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  ratio \u003d `provisioned_capacity_gb` / `total_capacity_gb` - `free_capacity_gb`"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"If the driver is not reporting `provisioned_capacity_gb` then we\u0027ll proceed to"},{"line_number":327,"context_line":"use the `allocated_capacity_gb` instead::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_f961143b","line":324,"range":{"start_line":324,"start_character":2,"end_line":324,"end_character":78},"updated":"2017-11-21 13:36:50.000000000","message":"This looks simple at first, but when you think how the backends will behave thing are not so clear and Im pretty sure this will lead to a lot of confusion. So, you have a variable ratio, that will decrease with the space consumption? Will you report a negative value (when provisioned_capacity_gb \u003d 0, for example)?\n\nSome examples, like you did in the beggining would be of good help here.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"304924473e5348e57add1a0c8cf0af3358d6feaa","unresolved":false,"context_lines":[{"line_number":321,"context_line":"reference when the backend is empty and then, when there is data calculate the"},{"line_number":322,"context_line":"current value on each driver stats report with the following formula::"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  ratio \u003d `provisioned_capacity_gb` / `total_capacity_gb` - `free_capacity_gb`"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"If the driver is not reporting `provisioned_capacity_gb` then we\u0027ll proceed to"},{"line_number":327,"context_line":"use the `allocated_capacity_gb` instead::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_b6e532de","line":324,"updated":"2017-10-18 02:57:08.000000000","message":"This should consider reserved capacity as well.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":321,"context_line":"reference when the backend is empty and then, when there is data calculate the"},{"line_number":322,"context_line":"current value on each driver stats report with the following formula::"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"  ratio \u003d `provisioned_capacity_gb` / `total_capacity_gb` - `free_capacity_gb`"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"If the driver is not reporting `provisioned_capacity_gb` then we\u0027ll proceed to"},{"line_number":327,"context_line":"use the `allocated_capacity_gb` instead::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_3491c19a","line":324,"in_reply_to":"5f4e5783_b6e532de","updated":"2017-11-21 13:31:47.000000000","message":"Done","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"304924473e5348e57add1a0c8cf0af3358d6feaa","unresolved":false,"context_lines":[{"line_number":326,"context_line":"If the driver is not reporting `provisioned_capacity_gb` then we\u0027ll proceed to"},{"line_number":327,"context_line":"use the `allocated_capacity_gb` instead::"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  ratio \u003d `allocated_capacity_gb` / `total_capacity_gb` - `free_capacity_gb`"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"This new configuration option will be independent of the drivers and it will be"},{"line_number":332,"context_line":"part of Cinder\u0027s core code, so if `auto_max_over_subscription_ratio` is not"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_96e8f6b2","line":329,"updated":"2017-10-18 02:57:08.000000000","message":"Same here.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":326,"context_line":"If the driver is not reporting `provisioned_capacity_gb` then we\u0027ll proceed to"},{"line_number":327,"context_line":"use the `allocated_capacity_gb` instead::"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  ratio \u003d `allocated_capacity_gb` / `total_capacity_gb` - `free_capacity_gb`"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"This new configuration option will be independent of the drivers and it will be"},{"line_number":332,"context_line":"part of Cinder\u0027s core code, so if `auto_max_over_subscription_ratio` is not"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_94944d8d","line":329,"in_reply_to":"5f4e5783_96e8f6b2","updated":"2017-11-21 13:31:47.000000000","message":"Done","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":346,"context_line":"-------------------------"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":349,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":350,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":351,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_39e45cac","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":10},"updated":"2017-11-21 13:36:50.000000000","message":"What approaches are we talking about?","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7d7ad9e5fe6dd9d8c152f814eebea3f57f30b2f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"-------------------------"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":349,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":350,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":351,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_95bf64fa","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":10},"in_reply_to":"ff82abbf_39e45cac","updated":"2017-11-21 16:53:12.000000000","message":"These have been define in \"Provisioning calculations\" under \"Problem description\".","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":348,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":349,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":350,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":351,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":353,"context_line":"one of the mechanism to use."},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_79dae4e9","line":351,"range":{"start_line":351,"start_character":7,"end_line":351,"end_character":30},"updated":"2017-11-21 13:36:50.000000000","message":"Those are not good names. If Im using \u0027standard\u0027 in a cinder file I can assume that this is the standard cinder behavior, so, what does \u0027cinder\u0027 means?","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7d7ad9e5fe6dd9d8c152f814eebea3f57f30b2f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"Instead of keep fighting with admins and developers on which one of the"},{"line_number":349,"context_line":"approaches is best -standard calculation or Cinder\u0027s- we will be adding a new"},{"line_number":350,"context_line":"configuration option called `over_provisioning_calculation` which will take"},{"line_number":351,"context_line":"values `standard` and `cinder` and default to `cinder` for backward"},{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":353,"context_line":"one of the mechanism to use."},{"line_number":354,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_5560fca5","line":351,"range":{"start_line":351,"start_character":7,"end_line":351,"end_character":30},"in_reply_to":"ff82abbf_79dae4e9","updated":"2017-11-21 16:53:12.000000000","message":"I can replace standard with \"industry_standard\" if you want, though by now everybody knows that cinder calculations regarding provisioning differ from the rest of the industry.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":353,"context_line":"one of the mechanism to use."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"This configuration option will also affect `CapacityWeigher` as it will need to"},{"line_number":356,"context_line":"do the free space calculation according to the standard definition as well."},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"As one can assume thick provisioning will have no modifications on its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_39abfc1d","line":355,"range":{"start_line":355,"start_character":44,"end_line":355,"end_character":59},"updated":"2017-11-21 13:36:50.000000000","message":"Still not sure about what exactly is being proposed in this section, but, it seems that a new filter and weigher would be better here, so we would still keep the default behavior. New users could just configure to use the new ones.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7d7ad9e5fe6dd9d8c152f814eebea3f57f30b2f","unresolved":false,"context_lines":[{"line_number":352,"context_line":"compatibility and that will be used by the `CapacityFilter` to determine which"},{"line_number":353,"context_line":"one of the mechanism to use."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"This configuration option will also affect `CapacityWeigher` as it will need to"},{"line_number":356,"context_line":"do the free space calculation according to the standard definition as well."},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"As one can assume thick provisioning will have no modifications on its"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_b56aa87d","line":355,"range":{"start_line":355,"start_character":44,"end_line":355,"end_character":59},"in_reply_to":"ff82abbf_39abfc1d","updated":"2017-11-21 16:53:12.000000000","message":"This has been a constant discussion since I joined Cinder, and the 2 points of view are explained above in \"Provisioning calculations\" under \"Problem description\"","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":362,"context_line":"------------"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* Don\u0027t support standard over-provisioning calculations."},{"line_number":365,"context_line":"* Instead of modifying `CapacityFilter` and `CapacityWeigher` create 2 new"},{"line_number":366,"context_line":"  classes."},{"line_number":367,"context_line":"* Instead of adding the `over_provisioning_calculation` configuration option"},{"line_number":368,"context_line":"  make the filter use the options JSON file provided by"},{"line_number":369,"context_line":"  `scheduler_json_config_location` .  This data seems to be currently missing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_997328e8","line":366,"range":{"start_line":365,"start_character":0,"end_line":366,"end_character":10},"updated":"2017-11-21 13:36:50.000000000","message":"Thumbs up for this when Its clear the real need for this.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7d7ad9e5fe6dd9d8c152f814eebea3f57f30b2f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"------------"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"* Don\u0027t support standard over-provisioning calculations."},{"line_number":365,"context_line":"* Instead of modifying `CapacityFilter` and `CapacityWeigher` create 2 new"},{"line_number":366,"context_line":"  classes."},{"line_number":367,"context_line":"* Instead of adding the `over_provisioning_calculation` configuration option"},{"line_number":368,"context_line":"  make the filter use the options JSON file provided by"},{"line_number":369,"context_line":"  `scheduler_json_config_location` .  This data seems to be currently missing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_d5216c4f","line":366,"range":{"start_line":365,"start_character":0,"end_line":366,"end_character":10},"in_reply_to":"ff82abbf_997328e8","updated":"2017-11-21 16:53:12.000000000","message":"Most of the code will be the same, so we\u0027ll end up with 3 classes, the base and the 2 that will have just a bit of different code.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"dd0fcc64ba2c16011d38cfa5012fa8a2cf2e0ab6","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"The only affected API will be the `get_pools` API that will be able to return"},{"line_number":382,"context_line":"the 2 new fields, `total_used_capacity_gb` and `cinder_used_capacity_gb`, when"},{"line_number":383,"context_line":"they are being reported by the driver\u0027s `get_volume_stats` method.  Fields will"},{"line_number":384,"context_line":"not be present if the drivers are not reporting them."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"Security impact"},{"line_number":387,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_f9191488","line":384,"range":{"start_line":383,"start_character":68,"end_line":384,"end_character":51},"updated":"2017-11-21 13:36:50.000000000","message":"We should make sure that these APIs will return everything that the scheduler is using to take the scheduler decision, otherwise this won\u0027t be of much help.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c7d7ad9e5fe6dd9d8c152f814eebea3f57f30b2f","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"The only affected API will be the `get_pools` API that will be able to return"},{"line_number":382,"context_line":"the 2 new fields, `total_used_capacity_gb` and `cinder_used_capacity_gb`, when"},{"line_number":383,"context_line":"they are being reported by the driver\u0027s `get_volume_stats` method.  Fields will"},{"line_number":384,"context_line":"not be present if the drivers are not reporting them."},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"Security impact"},{"line_number":387,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_95c9a479","line":384,"range":{"start_line":383,"start_character":68,"end_line":384,"end_character":51},"in_reply_to":"ff82abbf_f9191488","updated":"2017-11-21 16:53:12.000000000","message":"If you read carefully that\u0027s what I\u0027m saying.  The API will return what the scheduler has, but if the driver doesn\u0027t report that information the API cannot return that data.","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"304924473e5348e57add1a0c8cf0af3358d6feaa","unresolved":false,"context_lines":[{"line_number":411,"context_line":"With the change of values returned by Cinder backends for"},{"line_number":412,"context_line":"`allocated_capacity_gb` and `provisioned_capacity_gb` we may experience"},{"line_number":413,"context_line":"failures on creating volumes until we correct the values of"},{"line_number":414,"context_line":"`reserved_percentage` and `max_over_subscrition_ratio` in our cloud to the"},{"line_number":415,"context_line":"right values, since we may have been using incorrect ones."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Two new configuration options will be added:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f4e5783_db0a17d0","line":414,"range":{"start_line":414,"start_character":36,"end_line":414,"end_character":47},"updated":"2017-10-18 02:57:08.000000000","message":"subscription","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ac1c4060e95c95236d211e9643500e0c607a5b31","unresolved":false,"context_lines":[{"line_number":411,"context_line":"With the change of values returned by Cinder backends for"},{"line_number":412,"context_line":"`allocated_capacity_gb` and `provisioned_capacity_gb` we may experience"},{"line_number":413,"context_line":"failures on creating volumes until we correct the values of"},{"line_number":414,"context_line":"`reserved_percentage` and `max_over_subscrition_ratio` in our cloud to the"},{"line_number":415,"context_line":"right values, since we may have been using incorrect ones."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"Two new configuration options will be added:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff82abbf_74974992","line":414,"range":{"start_line":414,"start_character":36,"end_line":414,"end_character":47},"in_reply_to":"5f4e5783_db0a17d0","updated":"2017-11-21 13:31:47.000000000","message":"Done","commit_id":"ac189eaa4c604099165e338bdea996173b9c9cd2"}]}
