)]}'
{"specs/queens/update-backup-size-when-backup-is-created.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7ecb08dc8f70c2bcf110c3bfc01251b1700aeb35","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Update backup\u0027s size when backup is created"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/where-is-the-blueprint"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to update backup with the size reported by"},{"line_number":14,"context_line":"backup backend when backup is created."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_35231708","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":68},"updated":"2017-09-25 16:11:56.000000000","message":"This needs to be updated to the actual blueprint. Or removed if we are not tracking with a blueprint.","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ab776c8e5b3b0bdff7de8011bbcc256f4ca98f36","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Update backup\u0027s size when backup is created"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/where-is-the-blueprint"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint proposes to update backup with the size reported by"},{"line_number":14,"context_line":"backup backend when backup is created."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_f1946446","line":11,"range":{"start_line":11,"start_character":46,"end_line":11,"end_character":68},"in_reply_to":"7f515b1d_35231708","updated":"2017-09-26 01:27:18.000000000","message":"Done","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7ecb08dc8f70c2bcf110c3bfc01251b1700aeb35","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Backup\u0027s size attribute will reflect the real size on the backend, the quota"},{"line_number":31,"context_line":"and charge would be more accurate."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This spec proposes that the backup driver should report the real size that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_5589f3c7","line":33,"updated":"2017-09-25 16:11:56.000000000","message":"I think it would be good to point out that the full volume size will be used for an initial check against quota first to make sure it is even possible, but then the final quota consumption will be updated to show what was actually consumed.\n\nJust to make it clear that even though an end user might know that they only need 1G out of a 10G volume, Cinder will have no way of knowing that until after it\u0027s performed the backup. So we have to assume worse case scenario that any backup will consume the full size of the volume initially.","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ab776c8e5b3b0bdff7de8011bbcc256f4ca98f36","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Backup\u0027s size attribute will reflect the real size on the backend, the quota"},{"line_number":31,"context_line":"and charge would be more accurate."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"This spec proposes that the backup driver should report the real size that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_a3d21f5b","line":33,"in_reply_to":"7f515b1d_5589f3c7","updated":"2017-09-26 01:27:18.000000000","message":"Done","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7ecb08dc8f70c2bcf110c3bfc01251b1700aeb35","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Performance Impact"},{"line_number":108,"context_line":"------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"There would be a slightly performance impact"},{"line_number":111,"context_line":"when committing quota reservations."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_b565c747","line":110,"range":{"start_line":110,"start_character":17,"end_line":110,"end_character":25},"updated":"2017-09-25 16:11:56.000000000","message":"slight","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ab776c8e5b3b0bdff7de8011bbcc256f4ca98f36","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Performance Impact"},{"line_number":108,"context_line":"------------------"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"There would be a slightly performance impact"},{"line_number":111,"context_line":"when committing quota reservations."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_83d5e345","line":110,"range":{"start_line":110,"start_character":17,"end_line":110,"end_character":25},"in_reply_to":"7f515b1d_b565c747","updated":"2017-09-26 01:27:18.000000000","message":"Done","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7ecb08dc8f70c2bcf110c3bfc01251b1700aeb35","unresolved":false,"context_lines":[{"line_number":134,"context_line":"----------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Update cinder to support update the backup size."},{"line_number":137,"context_line":"* Update chunked driver to report backup\u0027s real size."},{"line_number":138,"context_line":"* Add related unit testcases."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_5556935e","line":137,"range":{"start_line":137,"start_character":9,"end_line":137,"end_character":16},"updated":"2017-09-25 16:11:56.000000000","message":"Not just chunked, but all, right? Maybe just say \"Update existing backup drivers to report...\"","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ab776c8e5b3b0bdff7de8011bbcc256f4ca98f36","unresolved":false,"context_lines":[{"line_number":134,"context_line":"----------"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"* Update cinder to support update the backup size."},{"line_number":137,"context_line":"* Update chunked driver to report backup\u0027s real size."},{"line_number":138,"context_line":"* Add related unit testcases."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_a32e9f40","line":137,"range":{"start_line":137,"start_character":9,"end_line":137,"end_character":16},"in_reply_to":"7f515b1d_5556935e","updated":"2017-09-26 01:27:18.000000000","message":"Done","commit_id":"afdc17fbe7a530320b08dbea73cac0f962d91a19"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1e2da5d1a7cf1ae1a7840b7fcad1506f453e608","unresolved":false,"context_lines":[{"line_number":36,"context_line":"This spec proposes that the backup driver should report the real size that"},{"line_number":37,"context_line":"object holds on the backend when backup is created. So, when user requests to"},{"line_number":38,"context_line":"create a backup for a volume with 10G, Cinder will still generate the record"},{"line_number":39,"context_line":"with 10G as well as consume 10G fo quota reservation, but when the real size"},{"line_number":40,"context_line":"is reported, we will update the both the object and the quotas."},{"line_number":41,"context_line":"As Cinder has the unified unit G for every resource, that size should be"},{"line_number":42,"context_line":"rounded up to G too, for example, if we create an incremental backup whose"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f515b1d_d20283b4","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":34},"updated":"2017-09-26 04:51:02.000000000","message":"of","commit_id":"cff8a6f17d4f050d8967fb7b59710e8cd0d96e00"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cbb9dfaded9158d7c600b205721d190e0270a929","unresolved":false,"context_lines":[{"line_number":40,"context_line":"is reported, we will update the both the object and the quotas."},{"line_number":41,"context_line":"As Cinder has the unified unit G for every resource, that size should be"},{"line_number":42,"context_line":"rounded up to G too, for example, if we create an incremental backup whose"},{"line_number":43,"context_line":"real size is only 12 mb, driver should still report 1 G to Cinder service:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. code-block:: python"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_9302983c","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":73},"updated":"2017-09-27 15:21:12.000000000","message":"Might this rounding error cause problems for users who create many incremental backups?","commit_id":"ec408a0e8f6605a9df47017c6059893922566ad7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f210438b13c50a399323f7feb3c9d801389fb2ae","unresolved":false,"context_lines":[{"line_number":40,"context_line":"is reported, we will update the both the object and the quotas."},{"line_number":41,"context_line":"As Cinder has the unified unit G for every resource, that size should be"},{"line_number":42,"context_line":"rounded up to G too, for example, if we create an incremental backup whose"},{"line_number":43,"context_line":"real size is only 12 mb, driver should still report 1 G to Cinder service:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":".. code-block:: python"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7f515b1d_de0b7721","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":73},"in_reply_to":"7f515b1d_9302983c","updated":"2017-09-27 15:23:15.000000000","message":"I think it might, but it\u0027s still better than how things are today and should be safe.","commit_id":"ec408a0e8f6605a9df47017c6059893922566ad7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f892ed20da60430fc374dc8c5de72363b56e3d7b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Most clouds provide end user a convenient way to protect their data by"},{"line_number":20,"context_line":"creating a backup for their volume. User can create any backup copy at"},{"line_number":21,"context_line":"anytime, And the cloud providers charge them by the backup size in total."},{"line_number":22,"context_line":"As the basic volume service, Cinder supports creating, restoring and"},{"line_number":23,"context_line":"deleting backups plus the backup quotas, but our backup size isn\u0027t correct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_3e34a1fb","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":40},"updated":"2017-09-29 00:12:28.000000000","message":"Users","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a1ef70dc633c8a84c19c224e9d38c86463c966b9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Most clouds provide end user a convenient way to protect their data by"},{"line_number":20,"context_line":"creating a backup for their volume. User can create any backup copy at"},{"line_number":21,"context_line":"anytime, And the cloud providers charge them by the backup size in total."},{"line_number":22,"context_line":"As the basic volume service, Cinder supports creating, restoring and"},{"line_number":23,"context_line":"deleting backups plus the backup quotas, but our backup size isn\u0027t correct"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_c1fb6cbe","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":40},"in_reply_to":"7f515b1d_3e34a1fb","updated":"2017-09-29 00:37:40.000000000","message":"Done","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f892ed20da60430fc374dc8c5de72363b56e3d7b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Most clouds provide end user a convenient way to protect their data by"},{"line_number":20,"context_line":"creating a backup for their volume. User can create any backup copy at"},{"line_number":21,"context_line":"anytime, And the cloud providers charge them by the backup size in total."},{"line_number":22,"context_line":"As the basic volume service, Cinder supports creating, restoring and"},{"line_number":23,"context_line":"deleting backups plus the backup quotas, but our backup size isn\u0027t correct"},{"line_number":24,"context_line":"at present, the backup\u0027s size always equals to the original volume\u0027s size"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_7e58d954","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":12},"updated":"2017-09-29 00:12:28.000000000","message":"and","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a1ef70dc633c8a84c19c224e9d38c86463c966b9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Most clouds provide end user a convenient way to protect their data by"},{"line_number":20,"context_line":"creating a backup for their volume. User can create any backup copy at"},{"line_number":21,"context_line":"anytime, And the cloud providers charge them by the backup size in total."},{"line_number":22,"context_line":"As the basic volume service, Cinder supports creating, restoring and"},{"line_number":23,"context_line":"deleting backups plus the backup quotas, but our backup size isn\u0027t correct"},{"line_number":24,"context_line":"at present, the backup\u0027s size always equals to the original volume\u0027s size"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_21348092","line":21,"range":{"start_line":21,"start_character":9,"end_line":21,"end_character":12},"in_reply_to":"7f515b1d_7e58d954","updated":"2017-09-29 00:37:40.000000000","message":"Done","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f892ed20da60430fc374dc8c5de72363b56e3d7b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"object holds at the backend when backup is created. So, when user requests to"},{"line_number":38,"context_line":"create a backup for a volume with 10G, Cinder will still generate the record"},{"line_number":39,"context_line":"with 10G as well as consume 10G for quota reservation, but when the actual"},{"line_number":40,"context_line":"size is reported, we will update the both the object and the quotas."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"**Note**: The actual size here stands for the final size at the backend, that"},{"line_number":43,"context_line":"means if we create backup for a 1G volume which only has 200mb data and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_de3c6de2","line":40,"range":{"start_line":40,"start_character":33,"end_line":40,"end_character":36},"updated":"2017-09-29 00:12:28.000000000","message":"remove \u0027the\u0027","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a1ef70dc633c8a84c19c224e9d38c86463c966b9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"object holds at the backend when backup is created. So, when user requests to"},{"line_number":38,"context_line":"create a backup for a volume with 10G, Cinder will still generate the record"},{"line_number":39,"context_line":"with 10G as well as consume 10G for quota reservation, but when the actual"},{"line_number":40,"context_line":"size is reported, we will update the both the object and the quotas."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"**Note**: The actual size here stands for the final size at the backend, that"},{"line_number":43,"context_line":"means if we create backup for a 1G volume which only has 200mb data and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_01274466","line":40,"range":{"start_line":40,"start_character":33,"end_line":40,"end_character":36},"in_reply_to":"7f515b1d_de3c6de2","updated":"2017-09-29 00:37:40.000000000","message":"Done","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f892ed20da60430fc374dc8c5de72363b56e3d7b","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Now Cinder has the attribute ``size`` for backup object which"},{"line_number":85,"context_line":"only reflects the volume\u0027s size when created. In order to support"},{"line_number":86,"context_line":"updating the actual size of the backup, We will add one more attribute"},{"line_number":87,"context_line":"here."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1. **volume_size**: This is used to record the original volume\u0027s size"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_7e069922","line":86,"range":{"start_line":86,"start_character":40,"end_line":86,"end_character":42},"updated":"2017-09-29 00:12:28.000000000","message":"we","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a1ef70dc633c8a84c19c224e9d38c86463c966b9","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Now Cinder has the attribute ``size`` for backup object which"},{"line_number":85,"context_line":"only reflects the volume\u0027s size when created. In order to support"},{"line_number":86,"context_line":"updating the actual size of the backup, We will add one more attribute"},{"line_number":87,"context_line":"here."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"1. **volume_size**: This is used to record the original volume\u0027s size"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_e129c836","line":86,"range":{"start_line":86,"start_character":40,"end_line":86,"end_character":42},"in_reply_to":"7f515b1d_7e069922","updated":"2017-09-29 00:37:40.000000000","message":"Done","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f892ed20da60430fc374dc8c5de72363b56e3d7b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"link to the original volume size here because we could resize the volume"},{"line_number":92,"context_line":"after the volume is backed up."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"2. **size**: This will be used to store the reported value from driver"},{"line_number":95,"context_line":"rather the original volume size. And when backup is first created,"},{"line_number":96,"context_line":"this value would be equal to the ``volume_size`` and will be updated"},{"line_number":97,"context_line":"when backup is created at backend."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_01086425","line":94,"range":{"start_line":94,"start_character":5,"end_line":94,"end_character":9},"updated":"2017-09-29 00:12:28.000000000","message":"Could we make this backup_size or size_on_disk .  I think we are going to have one size explicitly named we should name both.","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a1ef70dc633c8a84c19c224e9d38c86463c966b9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"link to the original volume size here because we could resize the volume"},{"line_number":92,"context_line":"after the volume is backed up."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"2. **size**: This will be used to store the reported value from driver"},{"line_number":95,"context_line":"rather the original volume size. And when backup is first created,"},{"line_number":96,"context_line":"this value would be equal to the ``volume_size`` and will be updated"},{"line_number":97,"context_line":"when backup is created at backend."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_01dce443","line":94,"range":{"start_line":94,"start_character":5,"end_line":94,"end_character":9},"in_reply_to":"7f515b1d_01086425","updated":"2017-09-29 00:37:40.000000000","message":"I would like use ``backup_size`` here, but as it\u0027s an attribute of the backup object, I guess the prefix should be removed.","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d71806ff6ec9bc66e7dd57dada328e4b237eeeac","unresolved":false,"context_lines":[{"line_number":91,"context_line":"link to the original volume size here because we could resize the volume"},{"line_number":92,"context_line":"after the volume is backed up."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"2. **size**: This will be used to store the reported value from driver"},{"line_number":95,"context_line":"rather the original volume size. And when backup is first created,"},{"line_number":96,"context_line":"this value would be equal to the ``volume_size`` and will be updated"},{"line_number":97,"context_line":"when backup is created at backend."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f515b1d_c4b49a82","line":94,"range":{"start_line":94,"start_character":5,"end_line":94,"end_character":9},"in_reply_to":"7f515b1d_01dce443","updated":"2017-09-29 02:21:45.000000000","message":"Ok, if there isn\u0027t more we can do here, it isn\u0027t a big deal.","commit_id":"b7cbe9a0494d1451666b4645c9c990980aec6bf4"}]}
