)]}'
{"specs/queens/add-shared-targets-to-volume-ref.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd3c240842d36c7b486eb283c88bf93b44a87f63","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/example"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"One problematic thing about dealing with device attachments is that some"},{"line_number":16,"context_line":"devices share a single target for multiple volumes while others have a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_1d69328a","line":13,"updated":"2017-09-26 20:35:43.000000000","message":"I don\u0027t think we need a blueprint for this, but should probably add one and link to it, or just remove this link.","commit_id":"7adc6f7ab25c3a982bc6fb89a0f8dbe97db3b314"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd3c240842d36c7b486eb283c88bf93b44a87f63","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Add a column to the volume reference that indicates if the backend associated"},{"line_number":60,"context_line":"witht the volume utilizes shared-targets or not.  In addition add"},{"line_number":61,"context_line":"a backend-name member to the volume detail view.  When shared-targets is True,"},{"line_number":62,"context_line":"the consumer will know that they\u0027re dealing with a device that uses"},{"line_number":63,"context_line":"shared-targets and that it needs to take some extra precautions.  In addition,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_7d226654","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":5},"updated":"2017-09-26 20:35:43.000000000","message":"with","commit_id":"7adc6f7ab25c3a982bc6fb89a0f8dbe97db3b314"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-shared-targets-flag-to-volume"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"One problematic thing about dealing with device attachments is that some"},{"line_number":16,"context_line":"devices share a single target for multiple volumes while others have a"},{"line_number":17,"context_line":"single unique target for every volume.  This can be troublesome because in the"},{"line_number":18,"context_line":"case of shared targets extra care needs to be taken by consumers like Nova to"},{"line_number":19,"context_line":"make sure that the target it not being used by other volumes on a system when"},{"line_number":20,"context_line":"a delete/detach call is made."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_f94506b5","line":17,"range":{"start_line":16,"start_character":8,"end_line":17,"end_character":37},"updated":"2017-09-28 21:28:23.000000000","message":"We should say per attachment here, or explicitly mention the multi-attach case.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"111bb723e7fdcf42f294dc79d3bf3dcc4e139360","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-shared-targets-flag-to-volume"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"One problematic thing about dealing with device attachments is that some"},{"line_number":16,"context_line":"devices share a single target for multiple volumes while others have a"},{"line_number":17,"context_line":"single unique target for every volume.  This can be troublesome because in the"},{"line_number":18,"context_line":"case of shared targets extra care needs to be taken by consumers like Nova to"},{"line_number":19,"context_line":"make sure that the target it not being used by other volumes on a system when"},{"line_number":20,"context_line":"a delete/detach call is made."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_4fbe77ff","line":17,"range":{"start_line":16,"start_character":8,"end_line":17,"end_character":37},"in_reply_to":"7f515b1d_ca25b80a","updated":"2017-09-29 17:25:41.000000000","message":"Fair enough, I will sort it out in the Nova-side spec.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"32e6e484fdf44db8da96aaf23ed0de1d1262d6d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-shared-targets-flag-to-volume"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"One problematic thing about dealing with device attachments is that some"},{"line_number":16,"context_line":"devices share a single target for multiple volumes while others have a"},{"line_number":17,"context_line":"single unique target for every volume.  This can be troublesome because in the"},{"line_number":18,"context_line":"case of shared targets extra care needs to be taken by consumers like Nova to"},{"line_number":19,"context_line":"make sure that the target it not being used by other volumes on a system when"},{"line_number":20,"context_line":"a delete/detach call is made."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_ca25b80a","line":17,"range":{"start_line":16,"start_character":8,"end_line":17,"end_character":37},"in_reply_to":"7f515b1d_f94506b5","updated":"2017-09-29 16:12:00.000000000","message":"I disagree, this isn\u0027t a multi-attach spec and I don\u0027t think that adding wording aroudn multi-attach is useful for anything other than introducing *another* thing for people to try and sort out.  I\u0027d rather take one thing at a time here if possible.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"devices share a single target for multiple volumes while others have a"},{"line_number":17,"context_line":"single unique target for every volume.  This can be troublesome because in the"},{"line_number":18,"context_line":"case of shared targets extra care needs to be taken by consumers like Nova to"},{"line_number":19,"context_line":"make sure that the target it not being used by other volumes on a system when"},{"line_number":20,"context_line":"a delete/detach call is made."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_e3de73d8","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":28},"updated":"2017-09-28 21:28:23.000000000","message":"s/it/is/","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Currently when os-brick recieves a detach operation it attempts to inspect the"},{"line_number":26,"context_line":"system and determine if there are multiple volumes attached to the host sharing"},{"line_number":27,"context_line":"the same target.  Most of the time this works, however it tends to be a bit"},{"line_number":28,"context_line":"racey and sometimes attempting bus scans is not only ineffecient but"},{"line_number":29,"context_line":"unreliable."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"The other problem is that currently there is no indication for os-brick to know"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_a3f63b62","line":28,"range":{"start_line":28,"start_character":53,"end_line":28,"end_character":64},"updated":"2017-09-28 21:28:23.000000000","message":"s/ineffecient/efficient/","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"It\u0027s possible that the connection response for V-B is completed under the"},{"line_number":51,"context_line":"assumption that the target exists (due to V-B) but then the V-A detach process"},{"line_number":52,"context_line":"performs it\u0027s checks prior to the attachment of V-B being finalized, and as"},{"line_number":53,"context_line":"a result it remove the target and the connection of V-B will appear to have"},{"line_number":54,"context_line":"been succesful but the volume will not be accessible."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_59109aa8","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":18},"updated":"2017-09-28 21:28:23.000000000","message":"s/remove/removes/","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"unique targets as shared, it\u0027s just going to introduce some unnecessary locking"},{"line_number":77,"context_line":"but will not impact functionality.  Conversely if a device that actually uses"},{"line_number":78,"context_line":"shared targets is False and not locked we have a race condition between attach"},{"line_number":79,"context_line":"and detach calls that causes problems."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_196b421e","line":79,"range":{"start_line":79,"start_character":29,"end_line":79,"end_character":37},"updated":"2017-09-28 21:28:23.000000000","message":"And we have a multi-attach problem as well.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"32e6e484fdf44db8da96aaf23ed0de1d1262d6d9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"unique targets as shared, it\u0027s just going to introduce some unnecessary locking"},{"line_number":77,"context_line":"but will not impact functionality.  Conversely if a device that actually uses"},{"line_number":78,"context_line":"shared targets is False and not locked we have a race condition between attach"},{"line_number":79,"context_line":"and detach calls that causes problems."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_8a1b40c8","line":79,"range":{"start_line":79,"start_character":29,"end_line":79,"end_character":37},"in_reply_to":"7f515b1d_196b421e","updated":"2017-09-29 16:12:00.000000000","message":"Same note as above, I don\u0027t want to muttle with multi-attach discussions right now.  I just want to fix the existing problem we have to get the new attach api\u0027s merged and done.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"275318944e918af3e596c3d9fb2b4876516608b8","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"* What database migrations will accompany this change."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  We\u0027ll perform a DB migration that adds the column and sets it\u0027s value to"},{"line_number":100,"context_line":"  True.  Setting to True is safe for non-shared targets so while it\u0027s not"},{"line_number":101,"context_line":"  necessarily the most efficient way to do things, it\u0027s safe and reliable."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_636f23fc","line":99,"range":{"start_line":99,"start_character":61,"end_line":99,"end_character":65},"updated":"2017-09-28 21:28:23.000000000","message":"s/it\u0027s/its/","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"241d97012dac00987a95acb4daf3ebf6ac348f15","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Security impact"},{"line_number":128,"context_line":"---------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The only possible security concern is leaking the backend_name and whether it"},{"line_number":131,"context_line":"uses shared_targets.  This may or not be a concern, if it is a concern then we"},{"line_number":132,"context_line":"can easily address this by making the fields admin only viewable.  This would"},{"line_number":133,"context_line":"mean that we\u0027d need to modify Nova to provide an elevated context when calling"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_9e74b5d0","line":130,"range":{"start_line":130,"start_character":49,"end_line":130,"end_character":63},"updated":"2017-09-29 00:05:08.000000000","message":"Didn\u0027t you resolve this with making a UUID instead?  If so we should update the spec with that decision and then we can remove this concern.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"32e6e484fdf44db8da96aaf23ed0de1d1262d6d9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"Security impact"},{"line_number":128,"context_line":"---------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The only possible security concern is leaking the backend_name and whether it"},{"line_number":131,"context_line":"uses shared_targets.  This may or not be a concern, if it is a concern then we"},{"line_number":132,"context_line":"can easily address this by making the fields admin only viewable.  This would"},{"line_number":133,"context_line":"mean that we\u0027d need to modify Nova to provide an elevated context when calling"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f515b1d_4a7f88df","line":130,"range":{"start_line":130,"start_character":49,"end_line":130,"end_character":63},"in_reply_to":"7f515b1d_9e74b5d0","updated":"2017-09-29 16:12:00.000000000","message":"Yes, but I wrote this spec before doing that, will update.","commit_id":"8bfe2c99f7314bc8e5ff21dc0d78764281f9f208"}]}
