)]}'
{"specs/stein/add-volume-re-image-api.rst":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, users can create a volume with a specific image, but once this"},{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":24,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3c57592a","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":68},"updated":"2018-09-26 06:00:40.000000000","message":"Usually, the image volume would be used as a boot volume which makes the case more complicated and more inconvenient.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, users can create a volume with a specific image, but once this"},{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":24,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_05a32045","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":68},"in_reply_to":"3f79a3b5_3c57592a","updated":"2018-09-26 09:49:07.000000000","message":"Yes, I will plus more information in here.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":24,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":25,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":26,"context_line":"have to worry about types, quota problem."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"So, we need a API to re-image a volume more conveniently."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3c6e79fe","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":41},"updated":"2018-09-26 06:00:40.000000000","message":"This is kind of use case? Also, need to mention the PTG discussion result and include the link as well.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":24,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":25,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":26,"context_line":"have to worry about types, quota problem."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"So, we need a API to re-image a volume more conveniently."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_d0d16458","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":41},"in_reply_to":"3f79a3b5_3c6e79fe","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":"This spec proposes to add a new \"reimage\" action to volume actions api."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5c10155a","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":51},"updated":"2018-09-26 06:00:40.000000000","message":"What\u0027s the default policy for this new action?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":"This spec proposes to add a new \"reimage\" action to volume actions api."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b027081f","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":51},"in_reply_to":"3f79a3b5_5c10155a","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":37,"context_line":"This spec proposes to add a new \"reimage\" action to volume actions api."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_9c2d4db0","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":51},"updated":"2018-09-26 06:00:40.000000000","message":"specific","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":37,"context_line":"This spec proposes to add a new \"reimage\" action to volume actions api."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_10659caf","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":51},"in_reply_to":"3f79a3b5_9c2d4db0","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08b3efff5980a4df6bb642013d569ea244eab35a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3f050b16","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":15},"updated":"2018-09-26 05:20:00.000000000","message":"in-use","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_10403ca2","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":15},"in_reply_to":"3f79a3b5_3f050b16","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"607f70646cdfbcf35581368bf3cbc4da231c29f5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_426eeefe","line":43,"updated":"2018-09-26 06:02:55.000000000","message":"Do you mean you will add a new volume state \u0027reimage\u0027? And also need to consider to add error recovery in init_host function?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_5c37b5ff","line":43,"range":{"start_line":43,"start_character":14,"end_line":43,"end_character":21},"updated":"2018-09-26 06:00:40.000000000","message":"reimaging?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4b64c94d","line":43,"in_reply_to":"3f79a3b5_426eeefe","updated":"2018-09-26 09:49:07.000000000","message":"Yes, We need add \"reimaging\" to _is_cleanable\u0027s list","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  re-image API with new image id to reimage specfic volume."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  Only \"in-used\" and \"available\" volume can be re-imaged. The volume will be"},{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_0bded169","line":43,"range":{"start_line":43,"start_character":14,"end_line":43,"end_character":21},"in_reply_to":"3f79a3b5_5c37b5ff","updated":"2018-09-26 09:49:07.000000000","message":"yes, reimaging is better in here. \n\nI choose this \u0027reimage\u0027 because nova use \u0027rebuild\u0027 (not \u0027rebuilding\u0027), but we already have \"retyping\" \"downloading\" in cinder, so it\u0027s a good choice...","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":49,"context_line":"  cinder api to volume."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_bc192988","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":44},"updated":"2018-09-26 06:00:40.000000000","message":"get a 403 error","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  changed to \u0027reimage\u0027 first,"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  If the volume is attached to more than one server, this volume is not allowed"},{"line_number":46,"context_line":"  to re-image, and will get back a 403 error."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":49,"context_line":"  cinder api to volume."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_8b7d016f","line":46,"range":{"start_line":46,"start_character":24,"end_line":46,"end_character":44},"in_reply_to":"3f79a3b5_bc192988","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":48,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":49,"context_line":"  cinder api to volume."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":52,"context_line":"  manager which will be called \u0027reimage\u0027, this method will call driver\u0027s"},{"line_number":53,"context_line":"  \"copy_image_to_volume\" to re-write the specific volume with new image."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e2729a12","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":72},"updated":"2018-09-26 06:00:40.000000000","message":"This part needs more discussion and detail, including:\n1. what if this operation failed and what should nova do after that?\n2. what if the driver doesn\u0027t support this operation?\n3. should we have a generic implementation for this?\n4. what if the image doesn\u0027t exist?\n5. At least, we need have some of the drivers support this feature this time?\n.....","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":48,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":49,"context_line":"  cinder api to volume."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":52,"context_line":"  manager which will be called \u0027reimage\u0027, this method will call driver\u0027s"},{"line_number":53,"context_line":"  \"copy_image_to_volume\" to re-write the specific volume with new image."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Alternatives"},{"line_number":56,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_91b52ef0","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":72},"in_reply_to":"3f79a3b5_e2729a12","updated":"2018-09-26 09:49:07.000000000","message":"2.3.5 My current consideration is that there is no need to add a new driver interface like \"reimage\", we can do something like create volume from image(download image and then call driver_image_to_volume). Maybe we can get some idea from others.\n\n4. we need add a check in api","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":61,"context_line":"REST API impact"},{"line_number":62,"context_line":"---------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Add one volume action API \u0027reimage\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The rest API look like this in v3:"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_3f0aeb1d","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":37},"updated":"2018-09-26 06:00:40.000000000","message":"Microversion bump is required.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":61,"context_line":"REST API impact"},{"line_number":62,"context_line":"---------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* Add one volume action API \u0027reimage\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The rest API look like this in v3:"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_4b4da9c3","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":37},"in_reply_to":"3f79a3b5_3f0aeb1d","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"607f70646cdfbcf35581368bf3cbc4da231c29f5","unresolved":false,"context_lines":[{"line_number":72,"context_line":".. code-block:: python"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  {"},{"line_number":75,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":76,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\""},{"line_number":77,"context_line":"      }"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_42a90e23","line":75,"updated":"2018-09-26 06:02:55.000000000","message":"I think it\u0027s better to add \u0027force\u0027 for in-use volumes. This is a dangerous operation for an in-use volume.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":72,"context_line":".. code-block:: python"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  {"},{"line_number":75,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":76,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\""},{"line_number":77,"context_line":"      }"},{"line_number":78,"context_line":"  }"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_b6c38006","line":75,"in_reply_to":"3f79a3b5_42a90e23","updated":"2018-09-26 09:49:07.000000000","message":"Done， yes, good advice.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08b3efff5980a4df6bb642013d569ea244eab35a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      }"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 means the image id."},{"line_number":81,"context_line":"    No default value."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The response status is 202, and the response body of it is like:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e2185a77","line":80,"range":{"start_line":80,"start_character":28,"end_line":80,"end_character":46},"updated":"2018-09-26 05:20:00.000000000","message":"refers to the id of image","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      }"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 means the image id."},{"line_number":81,"context_line":"    No default value."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The response status is 202, and the response body of it is like:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_eb03550f","line":80,"range":{"start_line":80,"start_character":28,"end_line":80,"end_character":46},"in_reply_to":"3f79a3b5_e2185a77","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 means the image id."},{"line_number":81,"context_line":"    No default value."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The response status is 202, and the response body of it is like:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. code-block:: python"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_e28e1ad0","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":30},"updated":"2018-09-26 06:00:40.000000000","message":"Need to mention the un-successfull response code as well.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 means the image id."},{"line_number":81,"context_line":"    No default value."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"The response status is 202, and the response body of it is like:"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. code-block:: python"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_363d30bc","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":30},"in_reply_to":"3f79a3b5_e28e1ad0","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":119,"context_line":"          \"volume_type\": \"lvmdriver-1\""},{"line_number":120,"context_line":"      }"},{"line_number":121,"context_line":"  }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * The \u003cstring\u003e \u0027status\u0027 will be \u0027reimage\u0027."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data model impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a2ba626e","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":44},"updated":"2018-09-26 06:00:40.000000000","message":"Need to mention the new command in client as well.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":119,"context_line":"          \"volume_type\": \"lvmdriver-1\""},{"line_number":120,"context_line":"      }"},{"line_number":121,"context_line":"  }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  * The \u003cstring\u003e \u0027status\u0027 will be \u0027reimage\u0027."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Data model impact"},{"line_number":126,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1647d4a5","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":44},"in_reply_to":"3f79a3b5_a2ba626e","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":145,"context_line":"Performance Impact"},{"line_number":146,"context_line":"------------------"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"None"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Other deployer impact"},{"line_number":151,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_829e4604","line":148,"range":{"start_line":148,"start_character":0,"end_line":148,"end_character":4},"updated":"2018-09-26 06:00:40.000000000","message":"There could be some performance impact on our volume service if we end up to use dd command for some of our driver\u0027s implementation?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Developer impact"},{"line_number":156,"context_line":"----------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Implementation"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_a2c34206","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":4},"updated":"2018-09-26 06:00:40.000000000","message":"There would be a new interface for our drivers.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Developer impact"},{"line_number":156,"context_line":"----------------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Implementation"},{"line_number":161,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_966c4408","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":4},"in_reply_to":"3f79a3b5_a2c34206","updated":"2018-09-26 09:49:07.000000000","message":"There would not a new interface, we just use the copy_image_to_volume, like create volume from image.","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"08b3efff5980a4df6bb642013d569ea244eab35a","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* Add a new \"reimage\" cast rpc."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Add a new method for volume manager."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Adopt the new microversion in python-cinderclient."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_62ef6a1d","line":179,"range":{"start_line":179,"start_character":19,"end_line":179,"end_character":37},"updated":"2018-09-26 05:20:00.000000000","message":"in volume manager for \"reimage\"","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7980892a70b9a3abb652eba2240848a83e905a15","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"* Add a new \"reimage\" cast rpc."},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* Add a new method for volume manager."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"* Adopt the new microversion in python-cinderclient."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_f67c98b7","line":179,"range":{"start_line":179,"start_character":19,"end_line":179,"end_character":37},"in_reply_to":"3f79a3b5_62ef6a1d","updated":"2018-09-26 09:49:07.000000000","message":"Done","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":188,"context_line":"Testing"},{"line_number":189,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"* Unit-tests should be implemented"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Documentation Impact"},{"line_number":194,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_62cd2a2f","line":191,"range":{"start_line":191,"start_character":1,"end_line":191,"end_character":34},"updated":"2018-09-26 06:00:40.000000000","message":"Including unit tests and tempest as well?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aea051478efd13cefec642938416e5761608f710","unresolved":false,"context_lines":[{"line_number":193,"context_line":"Documentation Impact"},{"line_number":194,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"None"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"References"},{"line_number":199,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_22d732c3","line":196,"range":{"start_line":196,"start_character":0,"end_line":196,"end_character":4},"updated":"2018-09-26 06:00:40.000000000","message":"API document and driver support matrix need update as well?","commit_id":"a326941457eca8c82951b46dc78400cd33e20031"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add volume re-image API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/cinder/+spec/volume-re-image-api"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This blueprint proposes to add volume re-image API to enable the ability to"},{"line_number":13,"context_line":"re-image a specific volume."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f546bda7","line":10,"updated":"2018-09-27 00:43:27.000000000","message":"This is the wrong name:\n\nhttps://blueprints.launchpad.net/cinder/+spec/add-volume-re-image-api","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add volume re-image API"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"https://blueprints.launchpad.net/cinder/+spec/volume-re-image-api"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This blueprint proposes to add volume re-image API to enable the ability to"},{"line_number":13,"context_line":"re-image a specific volume."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_d8ef38af","line":10,"in_reply_to":"3f79a3b5_f546bda7","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Currently, users can create a volume with a specific image, but once this"},{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attach to"},{"line_number":23,"context_line":"server, it makes the case more complicated and more inconvenient."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":26,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_55cd312e","line":23,"range":{"start_line":21,"start_character":39,"end_line":23,"end_character":65},"updated":"2018-09-27 00:43:27.000000000","message":"I would probably mention the volume-backed server rebuild case earlier in the problem description. Deleting and creating a new bootable volume with a new image is fine. The problem is changing the image in an attached root volume is not supported.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Currently, users can create a volume with a specific image, but once this"},{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attach to"},{"line_number":23,"context_line":"server, it makes the case more complicated and more inconvenient."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":26,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_580a4879","line":23,"range":{"start_line":21,"start_character":39,"end_line":23,"end_character":65},"in_reply_to":"3f79a3b5_55cd312e","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":26,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":27,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":28,"context_line":"have to worry about types, quota problem."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As the discussion result during Stein PTG `[2]`_, we would propose to implement"},{"line_number":31,"context_line":"a new API to support this."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_15d7b9c2","line":28,"range":{"start_line":28,"start_character":40,"end_line":28,"end_character":41},"updated":"2018-09-27 00:43:27.000000000","message":", etc.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"In addition, as mentioned in nova bp \"volume-backend-server-rebuild\" `[1]`_,"},{"line_number":26,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":27,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":28,"context_line":"have to worry about types, quota problem."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"As the discussion result during Stein PTG `[2]`_, we would propose to implement"},{"line_number":31,"context_line":"a new API to support this."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_780dc48d","line":28,"range":{"start_line":28,"start_character":40,"end_line":28,"end_character":41},"in_reply_to":"3f79a3b5_15d7b9c2","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  Only \"in-use\" and \"available\" volume can be re-imaged, and the \"in-use\""},{"line_number":50,"context_line":"  volume can only be re-imaged when the \"force\" parameter is True. The volume"},{"line_number":51,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_55e691b2","line":50,"range":{"start_line":50,"start_character":31,"end_line":50,"end_character":65},"updated":"2018-09-27 00:43:27.000000000","message":"Why? What\u0027s the point in a force parameter if nova is just going to always use it?","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  Only \"in-use\" and \"available\" volume can be re-imaged, and the \"in-use\""},{"line_number":50,"context_line":"  volume can only be re-imaged when the \"force\" parameter is True. The volume"},{"line_number":51,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_7882a4c9","line":50,"range":{"start_line":50,"start_character":31,"end_line":50,"end_character":65},"in_reply_to":"3f79a3b5_55e691b2","updated":"2018-09-27 03:07:11.000000000","message":"See [1], this \"force\" parameter is want user to make sure: does they really want to reimage a volume which is already attached to a server?\n\nIs this \"force\" a over-designed parameter?\n\n[1] https://review.openstack.org/#/c/605317/1/specs/stein/add-volume-re-image-api.rst@75","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"127c40e6dfd755e9bb7f04bf0814251017a20a65","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  Only \"in-use\" and \"available\" volume can be re-imaged, and the \"in-use\""},{"line_number":50,"context_line":"  volume can only be re-imaged when the \"force\" parameter is True. The volume"},{"line_number":51,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8edff30a","line":50,"range":{"start_line":50,"start_character":31,"end_line":50,"end_character":65},"in_reply_to":"3f79a3b5_7882a4c9","updated":"2018-09-30 15:21:01.000000000","message":"It seems weird yes, but meh. Nova will just always call it with force\u003dTrue.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":54,"context_line":"  allowed to re-image, and will get a 403 error."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":57,"context_line":"  cinder api to volume."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_35fbd548","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":41},"updated":"2018-09-27 00:43:27.000000000","message":"nit: should probably be a 409 instead of a 403.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":54,"context_line":"  allowed to re-image, and will get a 403 error."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":57,"context_line":"  cinder api to volume."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f86d542f","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":41},"in_reply_to":"3f79a3b5_35fbd548","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  allowed to re-image, and will get a 403 error."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":57,"context_line":"  cinder api to volume."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":60,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_f5f47d57","line":57,"range":{"start_line":57,"start_character":16,"end_line":57,"end_character":22},"updated":"2018-09-27 00:43:27.000000000","message":"the cinder-volume service.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  allowed to re-image, and will get a 403 error."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":57,"context_line":"  cinder api to volume."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":60,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_985ea077","line":57,"range":{"start_line":57,"start_character":16,"end_line":57,"end_character":22},"in_reply_to":"3f79a3b5_f5f47d57","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":60,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":61,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":62,"context_line":"  re-write the specific volume with new image, it likes what we have done in"},{"line_number":63,"context_line":"  create volume from image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_559bf115","line":62,"range":{"start_line":62,"start_character":47,"end_line":62,"end_character":55},"updated":"2018-09-27 00:43:27.000000000","message":"similar to","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":60,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":61,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":62,"context_line":"  re-write the specific volume with new image, it likes what we have done in"},{"line_number":63,"context_line":"  create volume from image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_985f804c","line":62,"range":{"start_line":62,"start_character":47,"end_line":62,"end_character":55},"in_reply_to":"3f79a3b5_559bf115","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Let users first delete the volume and then re-create a volume with a specific"},{"line_number":72,"context_line":"new image."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b5bda568","line":73,"updated":"2018-09-27 00:43:27.000000000","message":"You could also mention that nova could orchestrate creating a new root volume with the new image, then replace it during the server rebuild operation, but there are several issues with that as mentioned above like quota and the questions about what nova should do about the old volume (delete it?) - several of those questions were raised and discussed in the ML:\n\nhttp://lists.openstack.org/pipermail/openstack-operators/2018-March/014952.html","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Let users first delete the volume and then re-create a volume with a specific"},{"line_number":72,"context_line":"new image."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"REST API impact"},{"line_number":75,"context_line":"---------------"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8b916cfa","line":73,"in_reply_to":"3f79a3b5_b5bda568","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":95,"context_line":"    No default value."},{"line_number":96,"context_line":"  * The \u003cboolean\u003e \u0027force\u0027 refers to force reimage a volume. A attached volume"},{"line_number":97,"context_line":"    can only be re-imaged when the \"force\" parameter is True."},{"line_number":98,"context_line":"    False."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_157339ea","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":21},"updated":"2018-09-27 00:43:27.000000000","message":"No default value since this is a required parameter.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":95,"context_line":"    No default value."},{"line_number":96,"context_line":"  * The \u003cboolean\u003e \u0027force\u0027 refers to force reimage a volume. A attached volume"},{"line_number":97,"context_line":"    can only be re-imaged when the \"force\" parameter is True."},{"line_number":98,"context_line":"    False."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_d8a73850","line":95,"range":{"start_line":95,"start_character":4,"end_line":95,"end_character":21},"in_reply_to":"3f79a3b5_157339ea","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    No default value."},{"line_number":96,"context_line":"  * The \u003cboolean\u003e \u0027force\u0027 refers to force reimage a volume. A attached volume"},{"line_number":97,"context_line":"    can only be re-imaged when the \"force\" parameter is True."},{"line_number":98,"context_line":"    False."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The response body of it is like:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b5628514","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":10},"updated":"2018-09-27 00:43:27.000000000","message":"Defaults to False.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    No default value."},{"line_number":96,"context_line":"  * The \u003cboolean\u003e \u0027force\u0027 refers to force reimage a volume. A attached volume"},{"line_number":97,"context_line":"    can only be re-imaged when the \"force\" parameter is True."},{"line_number":98,"context_line":"    False."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The response body of it is like:"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b8627c14","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":10},"in_reply_to":"3f79a3b5_b5628514","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The response body of it is like:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. code-block:: python"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  {"},{"line_number":105,"context_line":"      \"volume\": {"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_b54b6584","line":102,"updated":"2018-09-27 00:43:27.000000000","message":"Isn\u0027t there also a volume_image_metadata field in the volume response body? That contains information about the image backing the volume. Would that include metadata about the new image or the original image until the reimage operation is complete in cinder-volume?","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"The response body of it is like:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. code-block:: python"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  {"},{"line_number":105,"context_line":"      \"volume\": {"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ab830855","line":102,"in_reply_to":"3f79a3b5_b54b6584","updated":"2018-09-27 03:07:11.000000000","message":"Yes, there is a \"volume_image_metadata\" in the image volume response body. I will update the image volume response body as example in next PS.\n\nI prefer this metadata include the original image until the reimage operation is complete in c-vol, just like what we do when create image volume [1](first download and dd image to volume, and then refresh the volume_image_metadata).\n\n[1] https://github.com/openstack/cinder/blob/f67180d/cinder/volume/flows/manager/create_volume.py#L953","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d02f27f2025c458addb48dcc71bb824d087fc9d8","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - Normal response codes: 202"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  - Error response codes: 400, 403, 404"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Data model impact"},{"line_number":147,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_7545cd6e","line":144,"updated":"2018-09-27 00:43:27.000000000","message":"409 if trying to reimage a multiattach volume that is connected to \u003e1 server.","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9848e01269120618274cd8966896bb703ccd3cbd","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - Normal response codes: 202"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  - Error response codes: 400, 403, 404"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"Data model impact"},{"line_number":147,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_8bd96c29","line":144,"in_reply_to":"3f79a3b5_7545cd6e","updated":"2018-09-27 03:07:11.000000000","message":"Done","commit_id":"84f11967e4a2c4f50bfd7c8c96b7e567ff640a25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebfa58bb396ccbdce39c8219f1f626e3477d10b8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  will be introduced so a user can re-image the volume, the default policy"},{"line_number":48,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\" and \"available\" volume can be re-imaged, and the \"in-use\""},{"line_number":51,"context_line":"  volume can only be re-imaged when the \"force\" parameter is True. The volume"},{"line_number":52,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_eecd475e","line":50,"updated":"2018-09-30 15:23:52.000000000","message":"I believe nova\u0027s rebuild use case will need \u0027reserved\u0027 volumes to allow this as well (similar to in-use). This is because on the nova side, what we\u0027ll do I think is:\n\n1. create an empty volume attachment for the volume before we delete the VM - the empty attachment is meant to keep the volume \u0027reserved\u0027 by the server during the rebuild\n2. delete the existing volume attachment that has the host connector in it\n3. delete the VM\n4. re-image the volume\n5. update the volume attachment with the new host connector and complete the attachment so the volume is again \u0027in-use\u0027\n6. spawn the guest in the hypervisor and reconnect the root volume\n\n\u0027reserved\u0027 and \u0027in-use\u0027 could be treated the same from the cinder API perspective regarding the force parameter.","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4cea0a1e562a8889304002c95c11f2093447ef44","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  will be introduced so a user can re-image the volume, the default policy"},{"line_number":48,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\" and \"available\" volume can be re-imaged, and the \"in-use\""},{"line_number":51,"context_line":"  volume can only be re-imaged when the \"force\" parameter is True. The volume"},{"line_number":52,"context_line":"  state will be changed to \"reimaging\" first."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_fe9fa3b0","line":50,"in_reply_to":"3f79a3b5_eecd475e","updated":"2018-10-08 07:31:46.000000000","message":"Yes, right, thanks for your reminder.","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3be1b61f87b45e3734a0558f4e9e850b65b72e8a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  {"},{"line_number":95,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":96,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":97,"context_line":"          \u0027force\u0027: False"},{"line_number":98,"context_line":"      }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_a23c4530","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":24},"updated":"2018-09-30 06:55:30.000000000","message":"I\u0027m a little confused regarding the validity of this param:\n1) If we create a volume from image (status:available), will there occur a condition when its needed to be reimaged? (the case should be mentioned in the spec)\n\n2)Or is reimage being introduced only as a nova functionality for reimaging volumes when attached(status:in-use).\n\nIMO the force param should only exist if there are valid cases regarding [1]","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c133a03c836fb30bcdee5430fa0b333759c3732e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  {"},{"line_number":95,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":96,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":97,"context_line":"          \u0027force\u0027: False"},{"line_number":98,"context_line":"      }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_577c0a70","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":24},"in_reply_to":"3f79a3b5_68bb6f74","updated":"2018-10-01 04:28:20.000000000","message":"Ok, looking forward to the updated info in latest PS :)","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"546c9ba6276339eb19e9a5d90d5086f054f6223f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  {"},{"line_number":95,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":96,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":97,"context_line":"          \u0027force\u0027: False"},{"line_number":98,"context_line":"      }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e8d77fbf","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":24},"in_reply_to":"3f79a3b5_a23c4530","updated":"2018-09-30 09:28:05.000000000","message":"IMO, 2 is better, I will describe more clearly in next PS. \n\n1. The available volume can be re-imaged directly.\n2. The in-use volume can be re-imaged with force param, otherwise return 400.\n3. Another status volume can\u0027t be re-imaged, otherwise return 400.","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"45ff32125259f68dfbc38e8c350a5a94721ca634","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  {"},{"line_number":95,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":96,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":97,"context_line":"          \u0027force\u0027: False"},{"line_number":98,"context_line":"      }"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_68bb6f74","line":97,"range":{"start_line":97,"start_character":10,"end_line":97,"end_character":24},"in_reply_to":"3f79a3b5_e8d77fbf","updated":"2018-09-30 09:30:34.000000000","message":"I mean your 2nd point is better for me. :) and there would be 3 cases in my last comment.","commit_id":"0dad04cab370a6bc7f0623554adcec30186583a7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dd811ca1e805af0532ef3f0502a677f40b6b5ee2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"force\" parameter is \"True\". The volume state will be changed to \"reimaging\""},{"line_number":53,"context_line":"  first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_c5c8cf4e","line":53,"updated":"2018-10-08 14:19:06.000000000","message":"Can we name this something more specific than \"force\"?\n\n\"ignore_status\", \"reimage_attached\", or similar?\n\nThe problem with \"force\" is that it\u0027s too generic sounding, and everyone assumes it will allow different behaviors.  I still regularly see confusion around this with \"force delete\".\n\nPlease name it something else.","commit_id":"73022bfb7ee2566bdf877c2dde6af212d480de52"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"d06b1b6fbf43b8bab74811e71449c96ea4c21e6d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"force\" parameter is \"True\". The volume state will be changed to \"reimaging\""},{"line_number":53,"context_line":"  first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_59bc9c06","line":53,"in_reply_to":"3f79a3b5_c5c8cf4e","updated":"2018-10-09 02:28:56.000000000","message":"Yes, good suggestion, and I prefer \"ignore_status\" one. I will refresh in next PS.","commit_id":"73022bfb7ee2566bdf877c2dde6af212d480de52"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dd811ca1e805af0532ef3f0502a677f40b6b5ee2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":97,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":98,"context_line":"          \u0027force\u0027: False"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_85d2d7fc","line":98,"updated":"2018-10-08 14:19:06.000000000","message":"See above","commit_id":"73022bfb7ee2566bdf877c2dde6af212d480de52"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"d06b1b6fbf43b8bab74811e71449c96ea4c21e6d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  {"},{"line_number":96,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":97,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":98,"context_line":"          \u0027force\u0027: False"},{"line_number":99,"context_line":"      }"},{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_f9ba4809","line":98,"in_reply_to":"3f79a3b5_85d2d7fc","updated":"2018-10-09 02:28:56.000000000","message":"Done","commit_id":"73022bfb7ee2566bdf877c2dde6af212d480de52"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f8344c345935465d1d71fd0bfdfeac4026bb672b","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_status\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_3a309c55","line":52,"range":{"start_line":52,"start_character":3,"end_line":52,"end_character":16},"updated":"2018-10-09 19:53:13.000000000","message":"nit: this is kind of a weird parameter name, since it\u0027s really a selective ignore - if I\u0027m migrating / retyping a volume, I can\u0027t re-image and users could be confused that it didn\u0027t ignore *all* statuses. But then again \u0027force\u0027 isn\u0027t much better, but force would be more consistent with the other usage of that parameter in the cinder API wouldn\u0027t it? Maybe it should be called \"ignore_attached\"?","commit_id":"b3ab30f4eea36503efe8967924a11333ccc96e33"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"cf8045fc434a8c7459def1835153f8ebe1645bf6","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_status\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_8cb65025","line":52,"range":{"start_line":52,"start_character":3,"end_line":52,"end_character":16},"in_reply_to":"3f79a3b5_3a309c55","updated":"2018-10-10 09:57:54.000000000","message":"Done","commit_id":"b3ab30f4eea36503efe8967924a11333ccc96e33"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f8344c345935465d1d71fd0bfdfeac4026bb672b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":103,"context_line":"    No default value since this is a required parameter."},{"line_number":104,"context_line":"  * The \u003cboolean\u003e \u0027ignore_status\u0027 refers to reimage a volume and ignore its"},{"line_number":105,"context_line":"    status. The \"available\" volume can be re-imgaed directly, but the"},{"line_number":106,"context_line":"    \"reserved\" or \"in-use\" volume can only be re-imaged when this parameter is"},{"line_number":107,"context_line":"    True."},{"line_number":108,"context_line":"    Defaults to False, this is an optional parameter."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_da3e4825","line":105,"range":{"start_line":105,"start_character":45,"end_line":105,"end_character":51},"updated":"2018-10-09 19:53:13.000000000","message":"imaged","commit_id":"b3ab30f4eea36503efe8967924a11333ccc96e33"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"cf8045fc434a8c7459def1835153f8ebe1645bf6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":103,"context_line":"    No default value since this is a required parameter."},{"line_number":104,"context_line":"  * The \u003cboolean\u003e \u0027ignore_status\u0027 refers to reimage a volume and ignore its"},{"line_number":105,"context_line":"    status. The \"available\" volume can be re-imgaed directly, but the"},{"line_number":106,"context_line":"    \"reserved\" or \"in-use\" volume can only be re-imaged when this parameter is"},{"line_number":107,"context_line":"    True."},{"line_number":108,"context_line":"    Defaults to False, this is an optional parameter."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f79a3b5_ec3ca493","line":105,"range":{"start_line":105,"start_character":45,"end_line":105,"end_character":51},"in_reply_to":"3f79a3b5_da3e4825","updated":"2018-10-10 09:57:54.000000000","message":"Done","commit_id":"b3ab30f4eea36503efe8967924a11333ccc96e33"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8932b3d252f75d854dc89c7722822900f79a626d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_attached\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_64c97a77","line":52,"range":{"start_line":52,"start_character":3,"end_line":52,"end_character":18},"updated":"2018-10-10 21:15:09.000000000","message":"This is really bike-shedding, but I think I would prefer \"ignore_in_use\" instead.\n\nA reserved volume will not be attached, so ignore_attached doesn\u0027t seem right to me. Whereas whether something is \"in-use\" or \"reserved\", it can be considered \"in use\".","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7d83c2c8f081eca1f91458df77e70392ae672268","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_attached\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_999757eb","line":52,"range":{"start_line":52,"start_character":3,"end_line":52,"end_character":18},"in_reply_to":"3f79a3b5_64c97a77","updated":"2018-10-11 06:45:11.000000000","message":"Yes, it seems \"ignore_in_use\" is more reasonable, it\u0027s okay to me to change it in next PS.","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8932b3d252f75d854dc89c7722822900f79a626d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"          \"os-vol-tenant-attr:tenant_id\": \"ffc60994a7274553905e5e5a8f890ab3\","},{"line_number":138,"context_line":"          \"os-vol-mig-status-attr:migstat\": null,"},{"line_number":139,"context_line":"          \"metadata\": { },"},{"line_number":140,"context_line":"          \"status\": \"reimaging\","},{"line_number":141,"context_line":"          \"volume_image_metadata\": {"},{"line_number":142,"context_line":"              \"container_format\": \"bare\","},{"line_number":143,"context_line":"              \"min_ram\": \"0\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_241142f9","line":140,"range":{"start_line":140,"start_character":10,"end_line":140,"end_character":31},"updated":"2018-10-10 21:15:09.000000000","message":"I think we will have to be careful since there are a few places in the code that check for the status to see if something is allowed or not allowed and this will be a new state to consider.","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8932b3d252f75d854dc89c7722822900f79a626d","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e``, will be added to"},{"line_number":191,"context_line":"python-cinderclient. This command mirrors the underlying API function."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Performance Impact"},{"line_number":194,"context_line":"------------------"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_24e62215","line":192,"updated":"2018-10-10 21:15:09.000000000","message":"At some point this will also need to make it into python-openstackclient, but I don\u0027t think that handles microversions yet, so something for future consideration.","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8932b3d252f75d854dc89c7722822900f79a626d","unresolved":false,"context_lines":[{"line_number":229,"context_line":"* Add \"reimaging\" to volume cleanable list"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"* Adopt the new microversion in python-cinderclient."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Dependencies"},{"line_number":234,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_04976648","line":232,"updated":"2018-10-10 21:15:09.000000000","message":"This will be an async operation, so I think we also just need to make sure to set a user message in the event the reimage fails to give them a clue why, and hopefully a clue how they can recover from a potentially now corrupt boot volume.","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7d83c2c8f081eca1f91458df77e70392ae672268","unresolved":false,"context_lines":[{"line_number":229,"context_line":"* Add \"reimaging\" to volume cleanable list"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"* Adopt the new microversion in python-cinderclient."},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"Dependencies"},{"line_number":234,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f79a3b5_79ab5b1d","line":232,"in_reply_to":"3f79a3b5_04976648","updated":"2018-10-11 06:45:11.000000000","message":"Good suggestion, I will add it in next PS.","commit_id":"83e630c1961e20156cc104449f439e889472a31c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dac0a7dc070ed1c69bffad41d11e2ddf7a795f6d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. A new policy"},{"line_number":47,"context_line":"  will be introduced so a user can re-image the volume, the default policy"},{"line_number":48,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_fecf58af","line":48,"updated":"2018-10-23 14:50:34.000000000","message":"I think you want separate policies for reimaging an \"available\" volume vs. an in-use volume.  This would match how we handle these cases in some other operations, and would let deployers allow only the safe path of this feature.  It would also allow policies to be configured so that only Nova can re-image attached volumes.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. A new policy"},{"line_number":47,"context_line":"  will be introduced so a user can re-image the volume, the default policy"},{"line_number":48,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_56b74223","line":48,"in_reply_to":"3f79a3b5_2dada5e6","updated":"2018-10-24 08:11:42.000000000","message":"Done","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8950c1e566f4d3a496bfd44c56ef4f1325fdbfcf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. A new policy"},{"line_number":47,"context_line":"  will be introduced so a user can re-image the volume, the default policy"},{"line_number":48,"context_line":"  for this new action is \"RULE_ADMIN_OR_OWNER\"."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_2dada5e6","line":48,"in_reply_to":"3f79a3b5_fecf58af","updated":"2018-10-23 17:14:27.000000000","message":"+1","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8950c1e566f4d3a496bfd44c56ef4f1325fdbfcf","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ad5695cc","line":52,"updated":"2018-10-23 17:14:27.000000000","message":"I saw in previous patches that this option had different names, but I don\u0027t think \"ignore_in_use\" when you also accept reserved is correct.\n\nAny reason why we shouldn\u0027t reimagine a volume that\u0027s in error?  If we try to reimagine an available volume and it fails, then we need admin privileges to change the status of the volume to available before we can retry...","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dd19c9698da2d9e25e8a54dca92ec7690464c310","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_4dffc134","line":52,"in_reply_to":"3f79a3b5_ad5695cc","updated":"2018-10-23 17:24:30.000000000","message":"I think this was my suggestion. When a volume is \"reserved\", it is considered in use by something. So ignore_in_use was more accurate than other suggestions at the time.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_f60beed0","line":52,"in_reply_to":"3f79a3b5_ad5695cc","updated":"2018-10-24 08:11:42.000000000","message":"Yes, we have some candidate names:\n\"force\", \"ignore_in_use\", \"ignore_status\", \"reimage_attached\"...and in_use including the \"in_use\"、\"reserved\".\n\nEmm, there is nothing special for error volume, so it\u0027s okay to me to allow error status volume reimaging. :) I will add it in next patch.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ec939ee9c4792511e71bf2eec2ee7fc0922d858d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_b4897571","line":52,"in_reply_to":"3f79a3b5_bd23f5a9","updated":"2018-10-30 18:33:18.000000000","message":"How about ignore_reserved instead?\nThis is quite confusing. I can see users puzzled setting this option to True and receiving a negative response when the volume is in-use.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_bd23f5a9","line":52,"in_reply_to":"3f79a3b5_f60beed0","updated":"2018-10-25 11:20:50.000000000","message":"I can see the problems with the other names \"force\" has been misused too much in Cinder, \"ignore_status\" is misleading... So the \"ignore_in_use\" is probably the best one.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1563191ae8a07e446c14272ba790286f604b693","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_be1fa058","line":53,"updated":"2018-10-23 14:48:09.000000000","message":"Why do we need \"reimaging\" as a status?  I believe it\u0027s basically the same as \"downloading\".","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_16cf8a8b","line":53,"in_reply_to":"3f79a3b5_0df54952","updated":"2018-10-24 08:11:42.000000000","message":"Done","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dd19c9698da2d9e25e8a54dca92ec7690464c310","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_0df54952","line":53,"in_reply_to":"3f79a3b5_6dd5dd46","updated":"2018-10-23 17:24:30.000000000","message":"Agreed","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8950c1e566f4d3a496bfd44c56ef4f1325fdbfcf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  Only \"in-use\", \"reserved\" and \"available\" volume can be re-imaged,"},{"line_number":51,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":52,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":53,"context_line":"  \"reimaging\" first."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  If the volume is attached to more than one server, this volume is not"},{"line_number":56,"context_line":"  allowed to re-image, and will get a 409 error."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_6dd5dd46","line":53,"in_reply_to":"3f79a3b5_be1fa058","updated":"2018-10-23 17:14:27.000000000","message":"I agree, it would be good not to add a new state.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1563191ae8a07e446c14272ba790286f604b693","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_bea240fa","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"updated":"2018-10-23 14:48:09.000000000","message":"I think this is not sufficient to handle encrypted volumes and encrypted images.  This will have to do something like what is done in this patch:\n    https://review.openstack.org/#/c/453343/","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_dd37d1ae","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_b6f2569a","updated":"2018-10-25 11:20:50.000000000","message":"That\u0027s not how we do it in Cinder, we usually define the mechanism for the optimized mechanism and provide a default mechanism (the one explained here) so that drivers can opt in to the optimized one.\n\nIn this case the optimized case would not even require driver changes, as all we would have to do is check if there are snapshots and if there are not we could use the cloning like we normally do (if cached, if glance is using Cinder for storage, etc.).\n\nI\u0027m not saying that we have to do the optimization from the start, but the spec should lay out the mechanism that would allow us to do so in order for Nova to do the right implementation from the start.\n\nOtherwise Nova would assume that we will never change the connection information and we\u0027ll encounter a problem once we implement the optimized way, because now the connection information that Nova has is not good, and they don\u0027t know they have to re-attach the volume.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8950c1e566f4d3a496bfd44c56ef4f1325fdbfcf","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_cdce718e","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_bea240fa","updated":"2018-10-23 17:14:27.000000000","message":"If we are using cache we don\u0027t currently do it this way, and doing it this way would prevent us from using an optimized path in some cases.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7b2516120ac97104abeeb64e450bf0516bddbb2b","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_d72d3790","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_c72125b7","updated":"2018-10-29 08:44:22.000000000","message":"Thanks, @matt, and according the nova side flow, I think we can only support the \"reserved\" volume at first implementation.\n\nThe \"reserved\" volume is a simple case, because the volume doesn\u0027t attach to any host. So, we don\u0027t need consider the issue like: Can we attach this volume to a host (even this volume has been used by a server) to complete the \"copy_image_to_volume\"(attach, copy, detach).\n\nI describe this in recent PS.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_b6f2569a","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_cdce718e","updated":"2018-10-24 08:11:42.000000000","message":"@eharney, OK, I will add the encrypted_volume branch in next patch.\n\n@gorka Yes, and as your comments, This is the basic implementation, if we will add caching and cloning in the advanced implementation.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"75d766474ba47c52b8c7cd896d274feba88dcc84","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ece2089c","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_dd37d1ae","updated":"2018-10-26 11:54:25.000000000","message":"OK, I\u0027m agree with you, and very thanks for your explanation.\n\nI also have some question want to discuss:\n\n0. Should we change the volume id when re-image?\n\n   I think we can\u0027t.\n\n1. Which information should be returned in re-image API?\n\n   I think something like attachment_create response, including \n   the connector info. If nova found the connector is changed, \n   nova will do re-attach operations.\n\n   And if we want to return connection_information to nova, it \n   seems we need some time to wait reimage to finish, and then \n   tell nova the reimage result and new connection info(if have). \n\n2. How to tell nova the reimage result?\n\n   I think a sync API + call rpc is not possible, because we need \n   wait much time. So, it seems nova need to check the status if \n   the volume change from \"downloading\" to \"available\", and then \n   query something as result?\n\n\nSo, I think I need your help, let\u0027s discussed on [1]. Thanks.\n\n[1] https://etherpad.openstack.org/p/cinder-stein-volume-re-image-api","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0cebfe2c84f0082f6975461058dbb1a415bb3a39","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":62,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":63,"context_line":"  image from glance, and then will call driver\u0027s \"copy_image_to_volume\" to"},{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_c72125b7","line":63,"range":{"start_line":63,"start_character":34,"end_line":63,"end_character":71},"in_reply_to":"3f79a3b5_ece2089c","updated":"2018-10-26 12:31:38.000000000","message":"\u003e 0. Should we change the volume id when re-image?\n\nNo, otherwise it defeats a large reason for having the reimage API in cinder. If we didn\u0027t care about the volume ID changing (and quota for that matter), then nova could just orchestrate deleting the old root volume and creating a new root volume from the new image. But that\u0027s not something we wanted to do if we can help it because we also then have to deal with the delete_on_termination flag in the nova BDM record.\n\n\u003e 2. How to tell nova the reimage result?\n\nAgree it can\u0027t be a synchronous API call, it will timeout. The attachment_create/update API calls are already synchronous and we see those timeout in the gate intermittently on slower nodes.\n\n\u003e So, it seems nova need to check the status if the volume change from \"downloading\" to \"available\", and then query something as result?\n\nDuring a rebuild in nova, we expect the connection_info to change and I don\u0027t think this will be a problem. Here is the rebuild code as-is today in nova:\n\nhttps://github.com/openstack/nova/blob/6256c60716dd7cedfcaf1557ba44de80a8de3d91/nova/compute/manager.py#L3202\n\nYou\u0027ll see that before we destroy the guest VM, we detach volumes but before we do, we create a new empty attachment which is just a placeholder to keep the volume \"reserved\" while we\u0027re rebuilding the VM.\n\nThen when we spawn a new guest, we re-attach the same volumes:\n\nhttps://github.com/openstack/nova/blob/6256c60716dd7cedfcaf1557ba44de80a8de3d91/nova/compute/manager.py#L3234\n\nWhich will update the volume attachment record with the host connector dict:\n\nhttps://github.com/openstack/nova/blob/6256c60716dd7cedfcaf1557ba44de80a8de3d91/nova/virt/block_device.py#L532\n\nSo I think we\u0027re OK with the connection_info since we\u0027ll be updating the volume attachment record when spawning the guest during rebuild anyway.\n\nNote that we expect the volume status to be \u0027reserved\u0027 today while rebuilding, as noted so we don\u0027t lose the volume during the rebuild (we don\u0027t want another operation to take the volume from us).\n\nIf there is a new status while reimaging a volume, I think we\u0027d expect to just poll the state transitions of the volume to go from reserved -\u003e reimaging -\u003e reserved. Then the nova rebuild operation can proceed with re-attaching the volume and spawning the guest VM.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1563191ae8a07e446c14272ba790286f604b693","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"},{"line_number":67,"context_line":"  refreshed."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""},{"line_number":70,"context_line":"  cleanup works in init_host."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_1e3014e9","line":67,"updated":"2018-10-23 14:48:09.000000000","message":"What does refreshed mean here?  All previously existing volume_glance_metadata is replaced with the metadata from the new image?  This is not very specific.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6e2d568f1345dae81d1f572a2341e464e8a16b93","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"},{"line_number":67,"context_line":"  refreshed."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""},{"line_number":70,"context_line":"  cleanup works in init_host."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_649bba63","line":67,"in_reply_to":"3f79a3b5_1e3014e9","updated":"2018-10-23 15:27:09.000000000","message":"Also will have to validate image signatures again.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  re-write the specific volume with new image, similar to what we have done in"},{"line_number":65,"context_line":"  create volume from image. After the reimage operation is complete, the"},{"line_number":66,"context_line":"  volume will set back to original state, and the image metadata will be"},{"line_number":67,"context_line":"  refreshed."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""},{"line_number":70,"context_line":"  cleanup works in init_host."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_76f27e6b","line":67,"in_reply_to":"3f79a3b5_1e3014e9","updated":"2018-10-24 08:11:42.000000000","message":"Yes, I will reword more clearly.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8950c1e566f4d3a496bfd44c56ef4f1325fdbfcf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  refreshed."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""},{"line_number":70,"context_line":"  cleanup works in init_host."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":73,"context_line":"  to give a hints to user how they can recover from a potentially now corrupt"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_add9b555","line":70,"updated":"2018-10-23 17:14:27.000000000","message":"This would not be necessary if we use the same state as we do in create volume from image.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  refreshed."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"* Add \"reimaging\" to volume cleanable list `[3]`_ to enable the \"reimaging\""},{"line_number":70,"context_line":"  cleanup works in init_host."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":73,"context_line":"  to give a hints to user how they can recover from a potentially now corrupt"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_369646f1","line":70,"in_reply_to":"3f79a3b5_add9b555","updated":"2018-10-24 08:11:42.000000000","message":"Done","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"636d8aa5edb30f4a012151d67d6cea142f1ddf54","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Testing"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Unit-tests, tempest and other related test should be implemented"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Documentation Impact"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_7e8d887b","line":247,"updated":"2018-10-23 14:48:33.000000000","message":"Needs to be tested w/ encrypted volumes and encrypted images.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Testing"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Unit-tests, tempest and other related test should be implemented"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Documentation Impact"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_fca18ff7","line":247,"in_reply_to":"3f79a3b5_64765a42","updated":"2018-10-24 08:11:42.000000000","message":"I think the image signature verification can be considered as the advance implementations.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8c7ef580e4a0eb0ef58fb87a74282c28af2c887c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Testing"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Unit-tests, tempest and other related test should be implemented"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Documentation Impact"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_1c724bb1","line":247,"in_reply_to":"3f79a3b5_7e8d887b","updated":"2018-10-24 08:11:42.000000000","message":"The encrypted images will update next patch.","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6e2d568f1345dae81d1f572a2341e464e8a16b93","unresolved":false,"context_lines":[{"line_number":244,"context_line":"Testing"},{"line_number":245,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"* Unit-tests, tempest and other related test should be implemented"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"Documentation Impact"},{"line_number":250,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_64765a42","line":247,"in_reply_to":"3f79a3b5_7e8d887b","updated":"2018-10-23 15:27:09.000000000","message":"What about image signature verification?","commit_id":"b2180090c63e0b38f9510ca34c239793141d2282"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. Two separate"},{"line_number":47,"context_line":"  policies will be introduced, the one is for reimaging an \"available\" or"},{"line_number":48,"context_line":"  \"error\" volume and the other one is for reimageing an in-use (\"in-use\" and"},{"line_number":49,"context_line":"  \"reserve\") volume, the default policies for these new actions are"},{"line_number":50,"context_line":"  \"RULE_ADMIN_OR_OWNER\"."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_ba745b05","line":47,"range":{"start_line":47,"start_character":31,"end_line":47,"end_character":46},"updated":"2018-10-25 11:20:50.000000000","message":"nit: one for","commit_id":"1a44b682492253d51a9fc5bef8b66d40b8439ea9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":45,"context_line":"* Add a new \"reimage\" action to volume actions api. When users call this"},{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. Two separate"},{"line_number":47,"context_line":"  policies will be introduced, the one is for reimaging an \"available\" or"},{"line_number":48,"context_line":"  \"error\" volume and the other one is for reimageing an in-use (\"in-use\" and"},{"line_number":49,"context_line":"  \"reserve\") volume, the default policies for these new actions are"},{"line_number":50,"context_line":"  \"RULE_ADMIN_OR_OWNER\"."},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_7a7a43ef","line":48,"range":{"start_line":48,"start_character":19,"end_line":48,"end_character":37},"updated":"2018-10-25 11:20:50.000000000","message":"nit: another","commit_id":"1a44b682492253d51a9fc5bef8b66d40b8439ea9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  re-image API with new image id to reimage specific volume. Two separate"},{"line_number":47,"context_line":"  policies will be introduced, the one is for reimaging an \"available\" or"},{"line_number":48,"context_line":"  \"error\" volume and the other one is for reimageing an in-use (\"in-use\" and"},{"line_number":49,"context_line":"  \"reserve\") volume, the default policies for these new actions are"},{"line_number":50,"context_line":"  \"RULE_ADMIN_OR_OWNER\"."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Only \"in-use\", \"reserved\", \"available\" and \"error\" volume can be re-imaged,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_1a16afa2","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":10},"updated":"2018-10-25 11:20:50.000000000","message":"-1: \"reserved\"","commit_id":"1a44b682492253d51a9fc5bef8b66d40b8439ea9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c022ccfdddc211c26c61c45ab8a6b870228b6438","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  \"reserve\") volume, the default policies for these new actions are"},{"line_number":50,"context_line":"  \"RULE_ADMIN_OR_OWNER\"."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Only \"in-use\", \"reserved\", \"available\" and \"error\" volume can be re-imaged,"},{"line_number":53,"context_line":"  the \"in-use\" and \"reserved\" volume can only be re-imaged when the"},{"line_number":54,"context_line":"  \"ignore_in_use\" parameter is \"True\". The volume state will be changed to"},{"line_number":55,"context_line":"  \"downloading\" first."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3f79a3b5_9a42bf66","line":52,"updated":"2018-10-25 11:20:50.000000000","message":"for \"error\" we also need to check the host field to ensure that the volume actually exists, otherwise we could allow to reimagine a volume that failed on creation.","commit_id":"1a44b682492253d51a9fc5bef8b66d40b8439ea9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* The user wants to re-image a volume without re-creating a new volume with new"},{"line_number":37,"context_line":"  volume id."},{"line_number":38,"context_line":"* Nova wants a new API to re-image an attached volume when the server is"},{"line_number":39,"context_line":"  rebuild."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_62233c58","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":9},"updated":"2018-10-29 16:38:34.000000000","message":"rebuilt","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* The user wants to re-image a volume without re-creating a new volume with new"},{"line_number":37,"context_line":"  volume id."},{"line_number":38,"context_line":"* Nova wants a new API to re-image an attached volume when the server is"},{"line_number":39,"context_line":"  rebuild."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_2c769293","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":9},"in_reply_to":"3f79a3b5_62233c58","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached after VM is re-spawn."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only **\"reserved\"**, **\"available\"** and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_c2e810e1","line":51,"range":{"start_line":51,"start_character":49,"end_line":51,"end_character":70},"updated":"2018-10-29 16:38:34.000000000","message":"after the VM is re-spawned.","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached after VM is re-spawn."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only **\"reserved\"**, **\"available\"** and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_2c5212db","line":51,"range":{"start_line":51,"start_character":49,"end_line":51,"end_character":70},"in_reply_to":"3f79a3b5_c2e810e1","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \"copy_image_to_volume\" to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is an encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \"copy_image_to_encrypted_volume\". It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_62a6dcc1","line":72,"range":{"start_line":72,"start_character":59,"end_line":72,"end_character":71},"updated":"2018-10-29 16:38:34.000000000","message":"encrypted,","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \"copy_image_to_volume\" to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is an encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \"copy_image_to_encrypted_volume\". It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_0c8f1676","line":72,"range":{"start_line":72,"start_character":59,"end_line":72,"end_character":71},"in_reply_to":"3f79a3b5_62a6dcc1","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":81,"context_line":"  to give a hints to user how they can recover from a potentially now corrupt"},{"line_number":82,"context_line":"  boot volume."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"There are also some other optimized mechanisms should be considered to support"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_427c0021","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":25},"updated":"2018-10-29 16:38:34.000000000","message":"to give hints to the user","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":81,"context_line":"  to give a hints to user how they can recover from a potentially now corrupt"},{"line_number":82,"context_line":"  boot volume."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"There are also some other optimized mechanisms should be considered to support"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_cc84be59","line":81,"range":{"start_line":81,"start_character":2,"end_line":81,"end_character":25},"in_reply_to":"3f79a3b5_427c0021","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":85,"context_line":"in future, but will not be implemented in this spec:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Re-image an ``in-used`` volume. If we want to support it, we should make"},{"line_number":88,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":89,"context_line":"  a host to support copy image to volume. And also reimage a ``in-used``"},{"line_number":90,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_82b458d5","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":23},"updated":"2018-10-29 16:38:34.000000000","message":"in-use","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":85,"context_line":"in future, but will not be implemented in this spec:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Re-image an ``in-used`` volume. If we want to support it, we should make"},{"line_number":88,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":89,"context_line":"  a host to support copy image to volume. And also reimage a ``in-used``"},{"line_number":90,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_6ce56a3d","line":87,"range":{"start_line":87,"start_character":15,"end_line":87,"end_character":23},"in_reply_to":"3f79a3b5_82b458d5","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Re-image an ``in-used`` volume. If we want to support it, we should make"},{"line_number":88,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":89,"context_line":"  a host to support copy image to volume. And also reimage a ``in-used``"},{"line_number":90,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":91,"context_line":"  VMs before we complete reimaging, otherwise will damage the volume data. We"},{"line_number":92,"context_line":"  will not support this operation in this spec."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_22c3043b","line":89,"range":{"start_line":89,"start_character":63,"end_line":89,"end_character":70},"updated":"2018-10-29 16:38:34.000000000","message":"in-use","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* Re-image an ``in-used`` volume. If we want to support it, we should make"},{"line_number":88,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":89,"context_line":"  a host to support copy image to volume. And also reimage a ``in-used``"},{"line_number":90,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":91,"context_line":"  VMs before we complete reimaging, otherwise will damage the volume data. We"},{"line_number":92,"context_line":"  will not support this operation in this spec."}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_8ce80615","line":89,"range":{"start_line":89,"start_character":63,"end_line":89,"end_character":70},"in_reply_to":"3f79a3b5_22c3043b","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  {"},{"line_number":127,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":128,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":129,"context_line":"          \u0027ignore_in_use\u0027: True"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_22f1c496","line":129,"range":{"start_line":129,"start_character":26,"end_line":129,"end_character":31},"updated":"2018-10-29 16:38:34.000000000","message":"I think we should show the default value here?","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  {"},{"line_number":127,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":128,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":129,"context_line":"          \u0027ignore_in_use\u0027: True"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"  }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_ec465a22","line":129,"range":{"start_line":129,"start_character":26,"end_line":129,"end_character":31},"in_reply_to":"3f79a3b5_22f1c496","updated":"2018-10-30 03:08:56.000000000","message":"Done","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ce60230445fabef13a1cca4b3f53019f8d44bb6d","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Security impact"},{"line_number":209,"context_line":"---------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"None"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Notifications impact"},{"line_number":214,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_023b6838","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":4},"updated":"2018-10-29 16:38:34.000000000","message":"There is a very edge case here where data from the previous volume could be left in the case that something goes wrong with the re-imaging.  I don\u0027t know if that needs to be documented but it is a thought I have.","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"2358fb22727f85a38df1b2fc98f10adf3ef6c5aa","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Security impact"},{"line_number":209,"context_line":"---------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"None"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Notifications impact"},{"line_number":214,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f79a3b5_ac4ce23f","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":4},"in_reply_to":"3f79a3b5_023b6838","updated":"2018-10-30 03:08:56.000000000","message":"Yes, the dirty data after reimaging is a possible security problem, maybe we can add some mechanism to force to write zero before we reimage, or just tell user fill zero before reimage if user worries the left data?","commit_id":"33eee92de46dfe277724defc873e09f454870fbb"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ec939ee9c4792511e71bf2eec2ee7fc0922d858d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached after the VM is re-spawned."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only ``reserved``, ``available`` and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_114b9bb2","line":51,"range":{"start_line":51,"start_character":49,"end_line":51,"end_character":54},"updated":"2018-10-30 18:33:18.000000000","message":"before?","commit_id":"2e608c33e1499a4bf366a4fc71e691ccbfd05db6"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9851539738d3c344426aad7e4c6d6e10e47c4dd6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached after the VM is re-spawned."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only ``reserved``, ``available`` and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_0f592f28","line":51,"range":{"start_line":51,"start_character":49,"end_line":51,"end_character":54},"in_reply_to":"3f79a3b5_114b9bb2","updated":"2018-10-31 02:27:05.000000000","message":"Yes, before\n[1] https://github.com/openstack/nova/blob/6256c60716dd7cedfcaf1557ba44de80a8de3d91/nova/compute/manager.py#L2899","commit_id":"2e608c33e1499a4bf366a4fc71e691ccbfd05db6"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ec939ee9c4792511e71bf2eec2ee7fc0922d858d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  also a signature when we create volume from image, we will also support it"},{"line_number":101,"context_line":"  in the advanced implementation."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Let users first delete the volume and then re-create a volume with a specific"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_9117ab54","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":12},"updated":"2018-10-30 18:33:18.000000000","message":"Reverting the volume to a snapshot created after image also could be an alternative.","commit_id":"2e608c33e1499a4bf366a4fc71e691ccbfd05db6"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9851539738d3c344426aad7e4c6d6e10e47c4dd6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  also a signature when we create volume from image, we will also support it"},{"line_number":101,"context_line":"  in the advanced implementation."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Alternatives"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Let users first delete the volume and then re-create a volume with a specific"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_6f9d43b9","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"3f79a3b5_9117ab54","updated":"2018-10-31 02:27:05.000000000","message":"Yes, it could be an alternative when we want to reimage to the same image.","commit_id":"2e608c33e1499a4bf366a4fc71e691ccbfd05db6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attach to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_55549456","line":22,"range":{"start_line":22,"start_character":66,"end_line":22,"end_character":72},"updated":"2018-10-31 09:33:20.000000000","message":"attached","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attach to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_adb5871b","line":22,"range":{"start_line":22,"start_character":66,"end_line":22,"end_character":72},"in_reply_to":"3f79a3b5_55549456","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached before the VM is re-spawned."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_15fcdc3e","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":25},"updated":"2018-10-31 09:33:20.000000000","message":"can remove this","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, the Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached before the VM is re-spawned."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_6d352fa7","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":25},"in_reply_to":"3f79a3b5_15fcdc3e","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  cinder api to the cinder-volume service."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":68,"context_line":"  image from glance."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_403134ee","line":68,"range":{"start_line":67,"start_character":42,"end_line":68,"end_character":20},"updated":"2018-10-31 09:33:20.000000000","message":"this line doesn\u0027t seem complete, can this be added at the end :\n... from glance and then perform the reimage operation.","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  cinder api to the cinder-volume service."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":68,"context_line":"  image from glance."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_ed405f07","line":68,"range":{"start_line":67,"start_character":42,"end_line":68,"end_character":20},"in_reply_to":"3f79a3b5_403134ee","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":68,"context_line":"  image from glance."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_a045a84c","line":70,"range":{"start_line":70,"start_character":5,"end_line":70,"end_character":12},"updated":"2018-10-31 09:33:20.000000000","message":"propose to","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"},{"line_number":68,"context_line":"  image from glance."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_8d4d2b3e","line":70,"range":{"start_line":70,"start_character":5,"end_line":70,"end_character":12},"in_reply_to":"3f79a3b5_a045a84c","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_403614e2","line":72,"range":{"start_line":72,"start_character":56,"end_line":72,"end_character":75},"updated":"2018-10-31 09:33:20.000000000","message":"is an encrypted image\nor\nis encrypted","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_cd6c83a0","line":72,"range":{"start_line":72,"start_character":56,"end_line":72,"end_character":75},"in_reply_to":"3f79a3b5_403614e2","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  After the reimage operation is complete, the volume will set back to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_a06e08c9","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":6},"updated":"2018-10-31 09:33:20.000000000","message":"then it will","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  We propose only support the basic implementation in this spec, the"},{"line_number":71,"context_line":"  reimage method will call driver\u0027s \u0027copy_image_to_volume\u0027 to re-write the"},{"line_number":72,"context_line":"  specific volume with new image. If the specific image is encrypted images"},{"line_number":73,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":74,"context_line":"  have done when we create volume from image."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  After the reimage operation is complete, the volume will set back to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_8d668bbc","line":73,"range":{"start_line":73,"start_character":2,"end_line":73,"end_character":6},"in_reply_to":"3f79a3b5_a06e08c9","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e78b6be5348de369589824b6b3aae5356d70000e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":81,"context_line":"  to give hints to the user how they can recover from a potentially now"},{"line_number":82,"context_line":"  corrupt boot volume."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_5b012503","line":80,"range":{"start_line":80,"start_character":52,"end_line":80,"end_character":76},"updated":"2018-10-31 09:33:20.000000000","message":"this can be removed too","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"589983c279d294cc30c438cbe3fa08d8fda97b2e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give them a clue why,"},{"line_number":81,"context_line":"  to give hints to the user how they can recover from a potentially now"},{"line_number":82,"context_line":"  corrupt boot volume."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f79a3b5_4dfe33b6","line":80,"range":{"start_line":80,"start_character":52,"end_line":80,"end_character":76},"in_reply_to":"3f79a3b5_5b012503","updated":"2018-11-01 11:33:01.000000000","message":"Done","commit_id":"c1cf771aa4362db417087227f6a94173caa3b600"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attached to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_402fcda5","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":3},"updated":"2018-11-01 21:51:46.000000000","message":"if the image-backed volume is already used as...","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"volume is created, the image of this volume can\u0027t be changed anymore. If users"},{"line_number":20,"context_line":"want to re-image a specific volume, they can only create a new volume with new"},{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attached to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_7b6dda65","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":3},"in_reply_to":"3f79a3b5_402fcda5","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attached to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In addition, as mentioned in nova bp \u0027volume-backend-server-rebuild\u0027 `[1]`_,"},{"line_number":27,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_e00cd945","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":38},"updated":"2018-11-01 21:51:46.000000000","message":"Link to If4c5fb782bb7e7714fb44f8ca9875121e066bc10 for reference.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"image, and then delete the old volume, which is not very convenient. However,"},{"line_number":22,"context_line":"the image volume is always used as a boot volume which is already attached to"},{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In addition, as mentioned in nova bp \u0027volume-backend-server-rebuild\u0027 `[1]`_,"},{"line_number":27,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_bb73724f","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":38},"in_reply_to":"3f79a3b5_e00cd945","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In addition, as mentioned in nova bp \u0027volume-backend-server-rebuild\u0027 `[1]`_,"},{"line_number":27,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":28,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":29,"context_line":"have to worry about types, quota problem, etc."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_80fde50a","line":26,"range":{"start_line":26,"start_character":69,"end_line":26,"end_character":75},"updated":"2018-11-01 21:51:46.000000000","message":"Footnotes are built-in:\n\nhttp://docutils.sourceforge.net/docs/user/rst/quickref.html#footnotes","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"server, it makes the case more complicated, because changing the image in an"},{"line_number":24,"context_line":"attached root volume is not supported."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In addition, as mentioned in nova bp \u0027volume-backend-server-rebuild\u0027 `[1]`_,"},{"line_number":27,"context_line":"if users want to rebuild a volume-backed server, they can complete it by using"},{"line_number":28,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":29,"context_line":"have to worry about types, quota problem, etc."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_1b886618","line":26,"range":{"start_line":26,"start_character":69,"end_line":26,"end_character":75},"in_reply_to":"3f79a3b5_80fde50a","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":28,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":29,"context_line":"have to worry about types, quota problem, etc."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As the discussion result during Stein PTG `[2]`_, we would propose to implement"},{"line_number":32,"context_line":"a new API to support this."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_3bfd2207","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":49},"updated":"2018-11-01 21:51:46.000000000","message":"use a real footnote","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"re-image api, this way there is no new volume with new volume id, we don\u0027t"},{"line_number":29,"context_line":"have to worry about types, quota problem, etc."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"As the discussion result during Stein PTG `[2]`_, we would propose to implement"},{"line_number":32,"context_line":"a new API to support this."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_3b8d2229","line":31,"range":{"start_line":31,"start_character":41,"end_line":31,"end_character":49},"in_reply_to":"3f79a3b5_3bfd2207","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"* The user wants to re-image a volume without re-creating a new volume with new"},{"line_number":37,"context_line":"  volume id."},{"line_number":38,"context_line":"* Nova wants a new API to re-image an attached volume when the server is"},{"line_number":39,"context_line":"  rebuilt."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_9b0b1622","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":53},"updated":"2018-11-01 21:51:46.000000000","message":"root volume","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":"* The user wants to re-image a volume without re-creating a new volume with new"},{"line_number":37,"context_line":"  volume id."},{"line_number":38,"context_line":"* Nova wants a new API to re-image an attached volume when the server is"},{"line_number":39,"context_line":"  rebuilt."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_db918e47","line":38,"range":{"start_line":38,"start_character":47,"end_line":38,"end_character":53},"in_reply_to":"3f79a3b5_9b0b1622","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, Nova will first mark the volume as \u0027reserved\u0027 and"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_bb085225","line":46,"range":{"start_line":46,"start_character":47,"end_line":46,"end_character":50},"updated":"2018-11-01 21:51:46.000000000","message":"API","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes to add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, Nova will first mark the volume as \u0027reserved\u0027 and"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_dbaaee6b","line":46,"range":{"start_line":46,"start_character":47,"end_line":46,"end_character":50},"in_reply_to":"3f79a3b5_bb085225","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached before the VM is re-spawned."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_db1aee69","line":50,"range":{"start_line":49,"start_character":22,"end_line":50,"end_character":20},"updated":"2018-11-01 21:51:46.000000000","message":"nit: nova doesn\u0027t explicitly change the volume status to reserved, it happens implicitly by nova attaching an empty attachment (no host connector), and deleting the previous attachment. That leaves the volume in reserved status rather than in-use.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"* Add a new \u0027reimage\u0027 action to volume actions api."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  As mentioned above, the main purpose of this spec is for Nova\u0027s rebuild use"},{"line_number":49,"context_line":"  case. In this case, Nova will first mark the volume as \u0027reserved\u0027 and"},{"line_number":50,"context_line":"  detach the volume, and then call cinder api to re-image this \u0027reserved\u0027"},{"line_number":51,"context_line":"  volume, finally, the volume will be reattached before the VM is re-spawned."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fbafaa79","line":50,"range":{"start_line":49,"start_character":22,"end_line":50,"end_character":20},"in_reply_to":"3f79a3b5_db1aee69","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only ``reserved``, ``available`` and"},{"line_number":55,"context_line":"  ``error`` volume can be re-imaged, the ``reserved`` volume can only be"},{"line_number":56,"context_line":"  re-imaged when the ``ignore_reserved`` parameter is ``True``. The volume"},{"line_number":57,"context_line":"  state will be changed to ``downloading`` first."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_5b2ede8d","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":38},"updated":"2018-11-01 21:51:46.000000000","message":". The","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only ``reserved``, ``available`` and"},{"line_number":55,"context_line":"  ``error`` volume can be re-imaged, the ``reserved`` volume can only be"},{"line_number":56,"context_line":"  re-imaged when the ``ignore_reserved`` parameter is ``True``. The volume"},{"line_number":57,"context_line":"  state will be changed to ``downloading`` first."},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_1bff066a","line":55,"range":{"start_line":55,"start_character":35,"end_line":55,"end_character":38},"in_reply_to":"3f79a3b5_5b2ede8d","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  So, we propose to add a new micro version to support users to re-image a"},{"line_number":54,"context_line":"  specific volume with new image id. Only ``reserved``, ``available`` and"},{"line_number":55,"context_line":"  ``error`` volume can be re-imaged, the ``reserved`` volume can only be"},{"line_number":56,"context_line":"  re-imaged when the ``ignore_reserved`` parameter is ``True``. The volume"},{"line_number":57,"context_line":"  state will be changed to ``downloading`` first."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  Two separate policies will be introduced, one for reimaging an ``available``"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fb548aff","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":38},"updated":"2018-11-01 21:51:46.000000000","message":"I thought people wanted ``force`` for this, but OK.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  default policies for these new actions are ``RULE_ADMIN_OR_OWNER``."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":64,"context_line":"  cinder api to the cinder-volume service."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_9b39d6d1","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":12},"updated":"2018-11-01 21:51:46.000000000","message":"API (here and throughout)","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  default policies for these new actions are ``RULE_ADMIN_OR_OWNER``."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* Add a new reimage cast rpc. This rpc is used to cast an async message from"},{"line_number":64,"context_line":"  cinder api to the cinder-volume service."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":67,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_3b04427d","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":12},"in_reply_to":"3f79a3b5_9b39d6d1","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give hints to the user"},{"line_number":81,"context_line":"  how they can recover from a potentially now corrupt boot volume."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":84,"context_line":"in future, but will not be implemented in this spec:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fbf00aff","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":66},"updated":"2018-11-01 21:51:46.000000000","message":"In the case of a failure, does the volume status change to \"error\"? Nova will need to know when to stop polling the status and the terminal states I would expect, if starting from \"reserved\" would be \"reserved\" (success) or \"error\" (failure).","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":78,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"* Set a user message in the event the reimage fails to give hints to the user"},{"line_number":81,"context_line":"  how they can recover from a potentially now corrupt boot volume."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":84,"context_line":"in future, but will not be implemented in this spec:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_dbf8ae7f","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":66},"in_reply_to":"3f79a3b5_fbf00aff","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":96,"context_line":"  improvement in future when we do reimage operation."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add image signature verification support when reimageing a volume. There is"},{"line_number":99,"context_line":"  also a signature when we create volume from image, we will also support it"},{"line_number":100,"context_line":"  in the advanced implementation."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_7b595a27","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":33},"updated":"2018-11-01 21:51:46.000000000","message":"This is probably something that will need to be called out as a limitation in the API reference if it\u0027s not supported.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":96,"context_line":"  improvement in future when we do reimage operation."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Add image signature verification support when reimageing a volume. There is"},{"line_number":99,"context_line":"  also a signature when we create volume from image, we will also support it"},{"line_number":100,"context_line":"  in the advanced implementation."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Alternatives"},{"line_number":103,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fb800ac1","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":33},"in_reply_to":"3f79a3b5_7b595a27","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":110,"context_line":"creating a new root volume with the new image, then replace it during the"},{"line_number":111,"context_line":"server rebuild operation, but there are several issue with that as mentioned"},{"line_number":112,"context_line":"above like quota and the questions about what nova should do about the old"},{"line_number":113,"context_line":"volume, you can see more detail information in ML `[4]`_."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"REST API impact"},{"line_number":116,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_fba24afb","line":113,"range":{"start_line":113,"start_character":50,"end_line":113,"end_character":56},"updated":"2018-11-01 21:51:46.000000000","message":"footnote","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"creating a new root volume with the new image, then replace it during the"},{"line_number":111,"context_line":"server rebuild operation, but there are several issue with that as mentioned"},{"line_number":112,"context_line":"above like quota and the questions about what nova should do about the old"},{"line_number":113,"context_line":"volume, you can see more detail information in ML `[4]`_."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"REST API impact"},{"line_number":116,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_9b65564d","line":113,"range":{"start_line":113,"start_character":50,"end_line":113,"end_character":56},"in_reply_to":"3f79a3b5_fba24afb","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":220,"context_line":"Other end user impact"},{"line_number":221,"context_line":"---------------------"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e``, will be added to"},{"line_number":224,"context_line":"python-cinderclient. This command mirrors the underlying API function."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_bbbb720e","line":223,"range":{"start_line":223,"start_character":17,"end_line":223,"end_character":54},"updated":"2018-11-01 21:51:46.000000000","message":"Wouldn\u0027t you also have an --ignore-reserved option?","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":220,"context_line":"Other end user impact"},{"line_number":221,"context_line":"---------------------"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e``, will be added to"},{"line_number":224,"context_line":"python-cinderclient. This command mirrors the underlying API function."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_bb629240","line":223,"range":{"start_line":223,"start_character":17,"end_line":223,"end_character":54},"in_reply_to":"3f79a3b5_bbbb720e","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b80a023d5055b4d79c0592fb6739f0184e0b6f36","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e``, will be added to"},{"line_number":224,"context_line":"python-cinderclient. This command mirrors the underlying API function."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Performance Impact"},{"line_number":227,"context_line":"------------------"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_9b90f699","line":225,"updated":"2018-11-01 21:51:46.000000000","message":"It\u0027s probably worth mentioning here what the caller (e.g. nova) needs to do while the volume is being re-imaged. I think it means that nova will poll the volume status until it goes from \u0027downloading\u0027 to \u0027reserved\u0027 again, or \u0027error\u0027 if the re-image failed.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e``, will be added to"},{"line_number":224,"context_line":"python-cinderclient. This command mirrors the underlying API function."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Performance Impact"},{"line_number":227,"context_line":"------------------"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_5b481eb3","line":225,"in_reply_to":"3f79a3b5_9b90f699","updated":"2018-11-01 22:21:53.000000000","message":"Done","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9457fcaa87eef56aff2db262c08805d7074eaa2","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"_`[2]` https://wiki.openstack.org/wiki/CinderSteinPTGSummary#Nova_Cross_Project_Time"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"_`[3]` https://github.com/openstack/cinder/blob/2fa6fdd/cinder/objects/volume.py#L535"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"_`[4]` http://lists.openstack.org/pipermail/openstack-operators/2018-March/014952.html"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3f79a3b5_9b8d5638","line":289,"updated":"2018-11-01 22:21:53.000000000","message":"This isn\u0027t referenced above.","commit_id":"360a1c8b6a4fda6bc24296daf905fa24aaf204bf"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  #. Create an empty (no connector) volume attachment for the volume and"},{"line_number":56,"context_line":"     server. This ensures the volume remains ``reserved`` through the next"},{"line_number":57,"context_line":"     step."},{"line_number":58,"context_line":"  #. Delete the existing volume attachment."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API."},{"line_number":60,"context_line":"  #. Poll the volume status for completion (either success or failure)."},{"line_number":61,"context_line":"  #. Upon successful completion of the re-image operation, attach the root"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_fa0e768d","line":58,"updated":"2018-11-06 12:42:56.000000000","message":"At this point there are 2 existing volume attachments, we should explicitly say that we remove the old one, right?","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  #. Create an empty (no connector) volume attachment for the volume and"},{"line_number":56,"context_line":"     server. This ensures the volume remains ``reserved`` through the next"},{"line_number":57,"context_line":"     step."},{"line_number":58,"context_line":"  #. Delete the existing volume attachment."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API."},{"line_number":60,"context_line":"  #. Poll the volume status for completion (either success or failure)."},{"line_number":61,"context_line":"  #. Upon successful completion of the re-image operation, attach the root"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_e2047d6e","line":58,"in_reply_to":"3f79a3b5_fa0e768d","updated":"2018-11-07 03:33:18.000000000","message":"Yes, sure.","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  #. Delete the existing volume attachment."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API."},{"line_number":60,"context_line":"  #. Poll the volume status for completion (either success or failure)."},{"line_number":61,"context_line":"  #. Upon successful completion of the re-image operation, attach the root"},{"line_number":62,"context_line":"     volume when spawning the (rebuilt) guest VM and \"complete\" the attachment"},{"line_number":63,"context_line":"     which will make the volume ``in-use`` again."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_da305a57","line":61,"range":{"start_line":61,"start_character":59,"end_line":61,"end_character":65},"updated":"2018-11-06 12:42:56.000000000","message":"-1: I assume we mean to update the empty volume attachment in Cinder, and then do the attachment on the Nova host, right?  Then we should be explicit, since we usually use the attach word for different things.","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  #. Delete the existing volume attachment."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API."},{"line_number":60,"context_line":"  #. Poll the volume status for completion (either success or failure)."},{"line_number":61,"context_line":"  #. Upon successful completion of the re-image operation, attach the root"},{"line_number":62,"context_line":"     volume when spawning the (rebuilt) guest VM and \"complete\" the attachment"},{"line_number":63,"context_line":"     which will make the volume ``in-use`` again."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_e279ddf9","line":61,"range":{"start_line":61,"start_character":59,"end_line":61,"end_character":65},"in_reply_to":"3f79a3b5_da305a57","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  default policies for these new actions are ``RULE_ADMIN_OR_OWNER``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* Add a new ``reimage`` cast rpc. This rpc is used to cast an async message"},{"line_number":76,"context_line":"  from cinder API to the cinder-volume service."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":79,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_3aa38e9e","line":76,"range":{"start_line":76,"start_character":39,"end_line":76,"end_character":46},"updated":"2018-11-06 12:42:56.000000000","message":"-1: \"service or cluster\"\n\nWe tend to forget during the implementation and review that we may have to send the RPC call to a cluster of services.  That\u0027s why I think it\u0027s important to be explicit in the spec.","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  default policies for these new actions are ``RULE_ADMIN_OR_OWNER``."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"* Add a new ``reimage`` cast rpc. This rpc is used to cast an async message"},{"line_number":76,"context_line":"  from cinder API to the cinder-volume service."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Add a new method for volume manager. There will be a new method for volume"},{"line_number":79,"context_line":"  manager which will be called \u0027reimage\u0027, this method will first download the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_626dcd2e","line":76,"range":{"start_line":76,"start_character":39,"end_line":76,"end_character":46},"in_reply_to":"3f79a3b5_3aa38e9e","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* If the re-image operation fails, we will set a user message to give hints to"},{"line_number":93,"context_line":"  the user how they can recover from a potentially now corrupt boot volume and"},{"line_number":94,"context_line":"  the volume status will changed to ``error``. The latter part is important for"},{"line_number":95,"context_line":"  the caller to know when to stop polling for the operation to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There are also some other optimized mechanisms should be considered to support"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_9ac8a24d","line":94,"updated":"2018-11-06 12:42:56.000000000","message":"-1: I see no mention on the spec of the behavior if the new image has a different size than the original.\n\nShould it fail?  Should it extend if bigger?  Then it needs to go through the scheduler to ensure there\u0027s space, like the extend does, and we would need to check/adjust the quota.  And we could be returning \"error\" status sometimes, not always \"downloading\".","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* If the re-image operation fails, we will set a user message to give hints to"},{"line_number":93,"context_line":"  the user how they can recover from a potentially now corrupt boot volume and"},{"line_number":94,"context_line":"  the volume status will changed to ``error``. The latter part is important for"},{"line_number":95,"context_line":"  the caller to know when to stop polling for the operation to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There are also some other optimized mechanisms should be considered to support"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_a208c52d","line":94,"in_reply_to":"3f79a3b5_9ac8a24d","updated":"2018-11-07 03:33:18.000000000","message":"I prefer to it fail.\n\nJust like what we do when we create a volume from image, if the size is not suitable (bigger or smaller), we not allow this operation, and raise a 400 to user.\n\nI will add this part to spec. thanks!","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  the volume status will changed to ``error``. The latter part is important for"},{"line_number":95,"context_line":"  the caller to know when to stop polling for the operation to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":98,"context_line":"in future, but will not be implemented in this spec:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_3a64eeb3","line":97,"range":{"start_line":97,"start_character":47,"end_line":97,"end_character":53},"updated":"2018-11-06 12:42:56.000000000","message":"nit: \"that should\"","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":94,"context_line":"  the volume status will changed to ``error``. The latter part is important for"},{"line_number":95,"context_line":"  the caller to know when to stop polling for the operation to complete."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There are also some other optimized mechanisms should be considered to support"},{"line_number":98,"context_line":"in future, but will not be implemented in this spec:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_2837b7b0","line":97,"range":{"start_line":97,"start_character":47,"end_line":97,"end_character":53},"in_reply_to":"3f79a3b5_3a64eeb3","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_9af0a2dc","line":102,"range":{"start_line":102,"start_character":60,"end_line":102,"end_character":61},"updated":"2018-11-06 12:42:56.000000000","message":"nit: \"an\"","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_483c7390","line":102,"range":{"start_line":102,"start_character":60,"end_line":102,"end_character":61},"in_reply_to":"3f79a3b5_9af0a2dc","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_7a1ca613","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":76},"updated":"2018-11-06 12:42:56.000000000","message":"nit: \"IO, ongoing or cached\"","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_5af68ad7","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":50},"updated":"2018-11-06 12:42:56.000000000","message":"nit: remove","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_0842fb0d","line":103,"range":{"start_line":103,"start_character":48,"end_line":103,"end_character":50},"in_reply_to":"3f79a3b5_5af68ad7","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":100,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":101,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":102,"context_line":"  a host to support copy image to volume. And also re-image a ``in-use``"},{"line_number":103,"context_line":"  volume is a very dangerous operation, we must to make sure there is no IO on"},{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_285017d1","line":103,"range":{"start_line":103,"start_character":73,"end_line":103,"end_character":76},"in_reply_to":"3f79a3b5_7a1ca613","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports to"},{"line_number":108,"context_line":"  create a volume from image cache, which can improve the performance of"},{"line_number":109,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":110,"context_line":"  improvement in future when we do re-image operation."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_facd1692","line":108,"range":{"start_line":107,"start_character":65,"end_line":108,"end_character":8},"updated":"2018-11-06 12:42:56.000000000","message":"nit: \"creating\"","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  VMs before we complete re-imaging, otherwise will damage the volume data. We"},{"line_number":105,"context_line":"  will not support this operation in this spec."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports to"},{"line_number":108,"context_line":"  create a volume from image cache, which can improve the performance of"},{"line_number":109,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":110,"context_line":"  improvement in future when we do re-image operation."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_485553c0","line":108,"range":{"start_line":107,"start_character":65,"end_line":108,"end_character":8},"in_reply_to":"3f79a3b5_facd1692","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":107,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports to"},{"line_number":108,"context_line":"  create a volume from image cache, which can improve the performance of"},{"line_number":109,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":110,"context_line":"  improvement in future when we do re-image operation."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Add image signature verification support when re-imaging a volume. There is"},{"line_number":113,"context_line":"  also a signature when we create volume from image, we will also support it"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_bae0fe94","line":110,"updated":"2018-11-06 12:42:56.000000000","message":"Sorry, I don\u0027t understand what this means.  Will we consider doing it when doing the implementation?  Or at some point in a future spec if we want/have time?","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":107,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports to"},{"line_number":108,"context_line":"  create a volume from image cache, which can improve the performance of"},{"line_number":109,"context_line":"  creating a volume from an image, we can also consider to add this"},{"line_number":110,"context_line":"  improvement in future when we do re-image operation."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Add image signature verification support when re-imaging a volume. There is"},{"line_number":113,"context_line":"  also a signature when we create volume from image, we will also support it"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_e8f21fe4","line":110,"in_reply_to":"3f79a3b5_bae0fe94","updated":"2018-11-07 03:33:18.000000000","message":"Ha, I think it\u0027s a bad copy-paste. - -, I mean in the advanced implementation.","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2529b5858345c3ec2a51bc07e44b9363f3b9163","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  * The \u003cstring\u003e \u0027status\u0027 will be \u0027downloading\u0027."},{"line_number":212,"context_line":"  * The \u003cdict\u003e \u0027volume_image_metadata\u0027 refers to the image metadata of volume,"},{"line_number":213,"context_line":"    it will include the original image until the re-image operation is complete"},{"line_number":214,"context_line":"    in cinder-volume."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  - Normal response codes: 202"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_7a8fc62e","line":213,"range":{"start_line":212,"start_character":67,"end_line":213,"end_character":7},"updated":"2018-11-06 12:42:56.000000000","message":"nit: \"of the volume. It\"","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"106894b5fcc90c8334139ca9f6fc8f05dd1dbf63","unresolved":false,"context_lines":[{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  * The \u003cstring\u003e \u0027status\u0027 will be \u0027downloading\u0027."},{"line_number":212,"context_line":"  * The \u003cdict\u003e \u0027volume_image_metadata\u0027 refers to the image metadata of volume,"},{"line_number":213,"context_line":"    it will include the original image until the re-image operation is complete"},{"line_number":214,"context_line":"    in cinder-volume."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  - Normal response codes: 202"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3f79a3b5_a8f8a7c1","line":213,"range":{"start_line":212,"start_character":67,"end_line":213,"end_character":7},"in_reply_to":"3f79a3b5_7a8fc62e","updated":"2018-11-07 03:33:18.000000000","message":"Done","commit_id":"702fce67e23e56e76ea44c90ad895c4dda2c0088"}]}
