)]}'
{"specs/stein/add-user-id-attribute-to-backup-response.rst":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"363e118831d9ced296a486c496603d9649ce560b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, there is a ``user_id`` field in the ``backups`` table, this field"},{"line_number":19,"context_line":"are very useful for admin/user to manage the backup file, but this is not"},{"line_number":20,"context_line":"returned in response body. So it is difficult to manage the resources under"},{"line_number":21,"context_line":"the project. If there are multiple users under one project, it is impossible"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_7b6b6553","line":18,"range":{"start_line":18,"start_character":66,"end_line":18,"end_character":76},"updated":"2018-11-20 17:19:08.000000000","message":"these fields","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8cde0ca53f13b3e36daadb342cb604dafc4ecb72","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, there is a ``user_id`` field in the ``backups`` table, this field"},{"line_number":19,"context_line":"are very useful for admin/user to manage the backup file, but this is not"},{"line_number":20,"context_line":"returned in response body. So it is difficult to manage the resources under"},{"line_number":21,"context_line":"the project. If there are multiple users under one project, it is impossible"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_f2e1cf32","line":18,"range":{"start_line":18,"start_character":66,"end_line":18,"end_character":76},"in_reply_to":"3f79a3b5_7b6b6553","updated":"2018-11-21 01:38:36.000000000","message":"Done","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"c645e0a2dd234227ab33d21d97f34f3c1815794e","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_f191a69c","line":95,"updated":"2018-11-07 08:07:01.000000000","message":"We could mention something about policy. I think this new added field would be exposed if the BACKUP_ATTRIBUTES_POLICY is allowed, right?","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8cde0ca53f13b3e36daadb342cb604dafc4ecb72","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_125c8bed","line":95,"in_reply_to":"3f79a3b5_1b24b119","updated":"2018-11-21 01:38:36.000000000","message":"Yeah, I\u0027ll add some description of the  BACKUP_ATTRIBUTES_POLICY for this change.","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"363e118831d9ced296a486c496603d9649ce560b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_1b24b119","line":95,"in_reply_to":"3f79a3b5_cf44021d","updated":"2018-11-20 17:19:08.000000000","message":"I think adding the information in the REST API impact is sufficient.  It isn\u0027t really a security issue.  Just an implementation detail.","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"73d0ee251fb39db2f34a3bafd0dc4f9262570768","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Security impact"},{"line_number":94,"context_line":"---------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_cf44021d","line":95,"in_reply_to":"3f79a3b5_f191a69c","updated":"2018-11-07 11:55:02.000000000","message":"Yeah, it will be used the \u0027BACKUP_ATTRIBUTES_POLICY\u0027 as the same as \u0027os-backup-project-attr:project_id\u0027, that policy is not changed, so I am not sure if I need to add the description of the policy.\n\nIf it\u0027s needed, write this in \u0027REST API impact\u0027 or \u0027Security impact\u0027? From *template* if the policy is changed that should be written in \u0027REST API impact\u0027.","commit_id":"c6d75b1ec4004f8b200908a33c353f304c5916d5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9d51f0bc38a1374df0e2839715d01a4e022d2500","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, there is a ``user_id`` field in the ``backups`` table, these"},{"line_number":19,"context_line":"fields are very useful for admin/user to manage the backup file, but this"},{"line_number":20,"context_line":"is not returned in response body. So it is difficult to manage the resources"},{"line_number":21,"context_line":"under the project. If there are multiple users under one project, it is"},{"line_number":22,"context_line":"impossible to distinguish which user the backup file belongs to."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_4b030d0c","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":37},"updated":"2018-11-23 03:16:06.000000000","message":"As your description, only admin can check this use_id, so we could remove this \u0027/user\u0027","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a49e8b124ef26658942d1112b2db01867b8c9a2f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, there is a ``user_id`` field in the ``backups`` table, these"},{"line_number":19,"context_line":"fields are very useful for admin/user to manage the backup file, but this"},{"line_number":20,"context_line":"is not returned in response body. So it is difficult to manage the resources"},{"line_number":21,"context_line":"under the project. If there are multiple users under one project, it is"},{"line_number":22,"context_line":"impossible to distinguish which user the backup file belongs to."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_6e2137a1","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":37},"in_reply_to":"3f79a3b5_4b030d0c","updated":"2018-11-23 05:45:40.000000000","message":"Done","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9d51f0bc38a1374df0e2839715d01a4e022d2500","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    {"},{"line_number":71,"context_line":"        \"backups\": [{"},{"line_number":72,"context_line":"            ..."},{"line_number":73,"context_line":"            \"os-backup-user-attr:user_id\": \"515ba0dd59f84f25a6a084a45d8d93b2\","},{"line_number":74,"context_line":"        }]"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_c8f9631d","line":73,"range":{"start_line":73,"start_character":77,"end_line":73,"end_character":78},"updated":"2018-11-23 03:16:06.000000000","message":"nit: redundant \u0027,\u0027","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a49e8b124ef26658942d1112b2db01867b8c9a2f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    {"},{"line_number":71,"context_line":"        \"backups\": [{"},{"line_number":72,"context_line":"            ..."},{"line_number":73,"context_line":"            \"os-backup-user-attr:user_id\": \"515ba0dd59f84f25a6a084a45d8d93b2\","},{"line_number":74,"context_line":"        }]"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ce0e4b2f","line":73,"range":{"start_line":73,"start_character":77,"end_line":73,"end_character":78},"in_reply_to":"3f79a3b5_c8f9631d","updated":"2018-11-23 05:45:40.000000000","message":"Done","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9d51f0bc38a1374df0e2839715d01a4e022d2500","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    {"},{"line_number":82,"context_line":"        \"backups\": [{"},{"line_number":83,"context_line":"            ..."},{"line_number":84,"context_line":"            \"os-backup-user-attr:user_id\": \"515ba0dd59f84f25a6a084a45d8d93b2\","},{"line_number":85,"context_line":"        }]"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_6bf84917","line":84,"range":{"start_line":84,"start_character":77,"end_line":84,"end_character":78},"updated":"2018-11-23 03:16:06.000000000","message":"ditto","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a49e8b124ef26658942d1112b2db01867b8c9a2f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    {"},{"line_number":82,"context_line":"        \"backups\": [{"},{"line_number":83,"context_line":"            ..."},{"line_number":84,"context_line":"            \"os-backup-user-attr:user_id\": \"515ba0dd59f84f25a6a084a45d8d93b2\","},{"line_number":85,"context_line":"        }]"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_ee0b0720","line":84,"range":{"start_line":84,"start_character":77,"end_line":84,"end_character":78},"in_reply_to":"3f79a3b5_6bf84917","updated":"2018-11-23 05:45:40.000000000","message":"Done","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"9d51f0bc38a1374df0e2839715d01a4e022d2500","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Calling this method show a ``user_id`` for volume backup."},{"line_number":89,"context_line":"It is intended for admins to use, which is used to display the user to which"},{"line_number":90,"context_line":"the backup file belongs."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Data model impact"},{"line_number":93,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_08043b18","line":90,"range":{"start_line":90,"start_character":23,"end_line":90,"end_character":24},"updated":"2018-11-23 03:16:06.000000000","message":"and controlled by `BACKUP_ATTRIBUTES_POLICY`.","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a49e8b124ef26658942d1112b2db01867b8c9a2f","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Calling this method show a ``user_id`` for volume backup."},{"line_number":89,"context_line":"It is intended for admins to use, which is used to display the user to which"},{"line_number":90,"context_line":"the backup file belongs."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Data model impact"},{"line_number":93,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f79a3b5_4e031b0c","line":90,"range":{"start_line":90,"start_character":23,"end_line":90,"end_character":24},"in_reply_to":"3f79a3b5_08043b18","updated":"2018-11-23 05:45:40.000000000","message":"Done","commit_id":"620cadbca8c68339b1dc0eacd4b872d343b47b82"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2dce42f87d827ea27b34ec3a0180e81c110341c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"under the project. If there are multiple users under one project, it is"},{"line_number":22,"context_line":"impossible to distinguish which user the backup file belongs to."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So add ``os-backup-user-attr:user_id`` attribute to the response body of"},{"line_number":25,"context_line":"list backup with detail and show backup detail APIs. In this way, we can"},{"line_number":26,"context_line":"clearly record which user made the backup file, and that we can select the"},{"line_number":27,"context_line":"project and user when restoring the backup to a volume."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ecd86f52","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":55},"updated":"2018-11-30 14:17:59.000000000","message":"This goes into the proposed change, not the problem description. It can be removed and is already covered in the Problem Description section below.","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1692b7abcb421e6233bb58ba9132095f179f594b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"under the project. If there are multiple users under one project, it is"},{"line_number":22,"context_line":"impossible to distinguish which user the backup file belongs to."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So add ``os-backup-user-attr:user_id`` attribute to the response body of"},{"line_number":25,"context_line":"list backup with detail and show backup detail APIs. In this way, we can"},{"line_number":26,"context_line":"clearly record which user made the backup file, and that we can select the"},{"line_number":27,"context_line":"project and user when restoring the backup to a volume."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Use Cases"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e005b9c1","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":55},"in_reply_to":"3f79a3b5_ecd86f52","updated":"2018-12-03 01:42:41.000000000","message":"Done","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2dce42f87d827ea27b34ec3a0180e81c110341c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In large scale environment, lots of backups resources were created in system,"},{"line_number":33,"context_line":"that we can only see the project to which the backup file belongs, but we"},{"line_number":34,"context_line":"cannot know which user belongs to it."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"In order to better manage the backup files, add ``os-backup-user-attr:user_id``"},{"line_number":37,"context_line":"attribute to the response body of list backup with detail and show backup"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_4ce72312","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":36},"updated":"2018-11-30 14:17:59.000000000","message":"which user the backup belongs to","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1692b7abcb421e6233bb58ba9132095f179f594b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"In large scale environment, lots of backups resources were created in system,"},{"line_number":33,"context_line":"that we can only see the project to which the backup file belongs, but we"},{"line_number":34,"context_line":"cannot know which user belongs to it."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"In order to better manage the backup files, add ``os-backup-user-attr:user_id``"},{"line_number":37,"context_line":"attribute to the response body of list backup with detail and show backup"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e0d37935","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":36},"in_reply_to":"3f79a3b5_4ce72312","updated":"2018-12-03 01:42:41.000000000","message":"Done","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6dc1751028e8ec5edd6650e1955a83e264f24af6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes that add ``os-backup-user-attr:user_id`` attribute to the"},{"line_number":45,"context_line":"response body of list backup with detail and show backup detail APIs."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add a new microverion API to add ``os-backup-user-attr:user_id`` attribute"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ec9aaf10","line":44,"range":{"start_line":44,"start_character":30,"end_line":44,"end_character":50},"updated":"2018-11-30 14:38:14.000000000","message":"Does this really need the prefix? I assume the prefix was used in legacy extension APIs to signal it was new in an existing backup API, but with microversions we can determine the response parameter name, and therefore it would be cleaner, IMO, to just call it \"user_id\". Think of the various OS-SRV*:host type parameters in compute server response bodies - they are hard to remember by name, always need to be looked up - it would be simpler to just call it \"user_id\" and drop the prefix.","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1692b7abcb421e6233bb58ba9132095f179f594b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes that add ``os-backup-user-attr:user_id`` attribute to the"},{"line_number":45,"context_line":"response body of list backup with detail and show backup detail APIs."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add a new microverion API to add ``os-backup-user-attr:user_id`` attribute"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_00b23506","line":44,"range":{"start_line":44,"start_character":30,"end_line":44,"end_character":50},"in_reply_to":"3f79a3b5_e7040816","updated":"2018-12-03 01:42:41.000000000","message":"Thanks Sean, Matt. At the beginning I just thought about keeping up with the \"project_id\" attribute. The \"os-backup-user-attr\" prefix is not required, remove it.","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"10a9d1f736fbe5a8696b6717c56d78eb5d37f8cd","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This spec proposes that add ``os-backup-user-attr:user_id`` attribute to the"},{"line_number":45,"context_line":"response body of list backup with detail and show backup detail APIs."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add a new microverion API to add ``os-backup-user-attr:user_id`` attribute"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_e7040816","line":44,"range":{"start_line":44,"start_character":30,"end_line":44,"end_character":50},"in_reply_to":"3f79a3b5_ec9aaf10","updated":"2018-11-30 14:45:44.000000000","message":"That\u0027s a good point. Those prefixes were used with extensions in the past. I\u0027m not sure we need to use them anymore with microversions and agree just having user_id would be better.","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a2dce42f87d827ea27b34ec3a0180e81c110341c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Add a new microverion API to add ``os-backup-user-attr:user_id`` attribute"},{"line_number":48,"context_line":"to the response body of list backup with detail and show backup detail APIs:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   - List backups with detail GET /v3/{project_id}/backups/detail"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - Show backup detail GET /v3/{project_id}/backups/{backup_id}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_ccac93aa","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":3},"updated":"2018-11-30 14:17:59.000000000","message":"Indent should be removed, otherwise the rendered HTML makes this bullet list also be blockquoted.","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"1692b7abcb421e6233bb58ba9132095f179f594b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Add a new microverion API to add ``os-backup-user-attr:user_id`` attribute"},{"line_number":48,"context_line":"to the response body of list backup with detail and show backup detail APIs:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   - List backups with detail GET /v3/{project_id}/backups/detail"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   - Show backup detail GET /v3/{project_id}/backups/{backup_id}"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_c0c3dd58","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":3},"in_reply_to":"3f79a3b5_ccac93aa","updated":"2018-12-03 01:42:41.000000000","message":"Done","commit_id":"b7444a99f93c70b4de33e23ca9cd585d7fb1ccaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dc58ff658f00c9bd87916cbbf6c05142e4b81219","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Currently, there is a ``user_id`` field in the ``backups`` table, these"},{"line_number":19,"context_line":"fields are very useful for admin to manage the backup file, but this"},{"line_number":20,"context_line":"is not returned in response body. So it is difficult to manage the resources"},{"line_number":21,"context_line":"under the project. If there are multiple users under one project, it is"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_8cef307f","line":18,"range":{"start_line":18,"start_character":64,"end_line":18,"end_character":67},"updated":"2018-12-17 20:45:43.000000000","message":". These","commit_id":"17c7d6116a3e79bc1179645f271776f513a81b1f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dc58ff658f00c9bd87916cbbf6c05142e4b81219","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"In large scale environment, lots of backups resources were created in system,"},{"line_number":28,"context_line":"that we can only see the project to which the backup file belongs, but we"},{"line_number":29,"context_line":"cannot know which user the backup belongs to it."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to better manage the backup files, add ``user_id``"},{"line_number":32,"context_line":"attribute to the response body of list backup with detail and show backup"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_6c25f4bf","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":47},"updated":"2018-12-17 20:45:43.000000000","message":"to which user the backup belongs.","commit_id":"17c7d6116a3e79bc1179645f271776f513a81b1f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dc58ff658f00c9bd87916cbbf6c05142e4b81219","unresolved":false,"context_lines":[{"line_number":28,"context_line":"that we can only see the project to which the backup file belongs, but we"},{"line_number":29,"context_line":"cannot know which user the backup belongs to it."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"In order to better manage the backup files, add ``user_id``"},{"line_number":32,"context_line":"attribute to the response body of list backup with detail and show backup"},{"line_number":33,"context_line":"detail APIs, make the backup resources more visible to the users of the"},{"line_number":34,"context_line":"project."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_0c40005e","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":8},"updated":"2018-12-17 20:45:43.000000000","message":"This is describing an implementation. A use case would be something like:\n\n\"Administrators would like the ability to identify the users that have created backups.\"","commit_id":"17c7d6116a3e79bc1179645f271776f513a81b1f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dc58ff658f00c9bd87916cbbf6c05142e4b81219","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Proposed change"},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"This spec proposes that add ``user_id`` attribute to the"},{"line_number":40,"context_line":"response body of list backup with detail and show backup detail APIs."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a new microverion API to add ``user_id`` attribute"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_ac56ac2b","line":39,"range":{"start_line":39,"start_character":19,"end_line":39,"end_character":23},"updated":"2018-12-17 20:45:43.000000000","message":"to","commit_id":"17c7d6116a3e79bc1179645f271776f513a81b1f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dc58ff658f00c9bd87916cbbf6c05142e4b81219","unresolved":false,"context_lines":[{"line_number":56,"context_line":"REST API impact"},{"line_number":57,"context_line":"---------------"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* Add a new microversion in Cinder API."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* List backups with detail::"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_9209862b","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":2},"updated":"2018-12-17 20:45:43.000000000","message":"Better not to have this a bullet as the next two bullet items describe what that microversion change is.","commit_id":"17c7d6116a3e79bc1179645f271776f513a81b1f"}]}