)]}'
{"specs/train/untyped-volumes-to-default-volume-type.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"28ab6840fb6b677e8c48673a7ff995d4c8c009b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Volume type is required by all actions that can be performed on volumes."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_4f9bf671","line":26,"updated":"2019-04-10 13:33:32.000000000","message":"This isn\u0027t really a use case, but the use case for this change is kind of odd anyway, since it\u0027s somewhat developer-centric.\n\nBut, I think it\u0027s approximately: most users use volume types, and our code is simpler and less buggy if we just always attach volume types to volumes, so we should just force all deployments to use volume types.","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"134180db5f7068bb0b9fafb8c2a125a14f27d80c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Volume type is required by all actions that can be performed on volumes."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_45c6776a","line":26,"in_reply_to":"5fc1f717_4f9bf671","updated":"2019-04-10 14:50:25.000000000","message":"Done","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"28ab6840fb6b677e8c48673a7ff995d4c8c009b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec proposes the following changes :"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Create default volume type during cinder deployment"},{"line_number":34,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":35,"context_line":"  volume type"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6f6fd25f","line":33,"updated":"2019-04-10 13:33:32.000000000","message":"That has no extra specs assigned to it and is named \"default\".\n\nAnd then if a type named \"default\" already exists because a deployer created it, just use that.","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"134180db5f7068bb0b9fafb8c2a125a14f27d80c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec proposes the following changes :"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Create default volume type during cinder deployment"},{"line_number":34,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":35,"context_line":"  volume type"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_05a2afae","line":33,"in_reply_to":"5fc1f717_6f6fd25f","updated":"2019-04-10 14:50:25.000000000","message":"Done","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"28ab6840fb6b677e8c48673a7ff995d4c8c009b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Create default volume type during cinder deployment"},{"line_number":34,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":35,"context_line":"  volume type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_6fd272ff","line":35,"updated":"2019-04-10 13:33:32.000000000","message":"* If default_volume_type in cinder.conf is unset, use the type named \"default\" during volume creation when no type is requested\n* Don\u0027t allow deletion of the default volume type via type-delete (details on how to implement this need some thought...)","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"134180db5f7068bb0b9fafb8c2a125a14f27d80c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Create default volume type during cinder deployment"},{"line_number":34,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":35,"context_line":"  volume type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Alternatives"},{"line_number":38,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fc1f717_e5e683e7","line":35,"in_reply_to":"5fc1f717_6fd272ff","updated":"2019-04-10 14:50:25.000000000","message":"Done","commit_id":"0ce421288fe086aba9172da4fc14c55a1a7c7317"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8e690f5221c888fdd410c0bd5680e49c8bb908a0","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This spec proposes the following changes :"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Create a default volume type during cinder deployment that has no extra"},{"line_number":36,"context_line":"  specs assigned to it and is named ``default_vol_type`` and if a type named"},{"line_number":37,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":38,"context_line":"* Add an online migration to convert all untyped volumes to default"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_162dc094","line":35,"range":{"start_line":35,"start_character":38,"end_line":35,"end_character":55},"updated":"2019-04-12 10:21:58.000000000","message":"It\u0027s not during deployment, it\u0027s either on the migration or on start, because Cinder has no control over the deployment phase.  All we can tell is if the DB is empty and if this type exists.","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7356ec67d558e81791608ff2f3dafb66f1cb09b8","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This spec proposes the following changes :"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Create a default volume type during cinder deployment that has no extra"},{"line_number":36,"context_line":"  specs assigned to it and is named ``default_vol_type`` and if a type named"},{"line_number":37,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":38,"context_line":"* Add an online migration to convert all untyped volumes to default"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_4a5a9ff3","line":35,"range":{"start_line":35,"start_character":38,"end_line":35,"end_character":55},"in_reply_to":"3fce034c_162dc094","updated":"2019-04-15 10:15:32.000000000","message":"Done","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8e690f5221c888fdd410c0bd5680e49c8bb908a0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  specs assigned to it and is named ``default_vol_type`` and if a type named"},{"line_number":37,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":38,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":39,"context_line":"  volume type"},{"line_number":40,"context_line":"* If default_volume_type in cinder.conf is unset, use the type named"},{"line_number":41,"context_line":"  ``default_vol_type`` during volume creation when no type is specified"},{"line_number":42,"context_line":"  by user"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_563268f3","line":39,"updated":"2019-04-12 10:21:58.000000000","message":"We cannot do this automatically if default_vol_type already exists and has extra specs assigned.","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7356ec67d558e81791608ff2f3dafb66f1cb09b8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  specs assigned to it and is named ``default_vol_type`` and if a type named"},{"line_number":37,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":38,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":39,"context_line":"  volume type"},{"line_number":40,"context_line":"* If default_volume_type in cinder.conf is unset, use the type named"},{"line_number":41,"context_line":"  ``default_vol_type`` during volume creation when no type is specified"},{"line_number":42,"context_line":"  by user"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_aa08e3d8","line":39,"in_reply_to":"3fce034c_563268f3","updated":"2019-04-15 10:15:32.000000000","message":"I think we can handle this case by not allowing users to update default volume type, i\u0027ve added the point on L#44","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8e690f5221c888fdd410c0bd5680e49c8bb908a0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  volume type"},{"line_number":40,"context_line":"* If default_volume_type in cinder.conf is unset, use the type named"},{"line_number":41,"context_line":"  ``default_vol_type`` during volume creation when no type is specified"},{"line_number":42,"context_line":"  by user"},{"line_number":43,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_963d30bd","line":42,"updated":"2019-04-12 10:21:58.000000000","message":"We just need to change the default value for the default_vol_type configuration option.","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7356ec67d558e81791608ff2f3dafb66f1cb09b8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  volume type"},{"line_number":40,"context_line":"* If default_volume_type in cinder.conf is unset, use the type named"},{"line_number":41,"context_line":"  ``default_vol_type`` during volume creation when no type is specified"},{"line_number":42,"context_line":"  by user"},{"line_number":43,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fce034c_6a12fb0b","line":42,"in_reply_to":"3fce034c_963d30bd","updated":"2019-04-15 10:15:32.000000000","message":"Done","commit_id":"6a73ad9cf151cde99f5a66cb18138cd78bd3b514"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c371841643007662c0df8364eb2fe5ddcc12db48","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``default_vol_type`` and if a type named"},{"line_number":38,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":39,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":40,"context_line":"  volume type"},{"line_number":41,"context_line":"* Set a default value ``default_vol_type`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fce034c_a5f54d85","line":38,"updated":"2019-04-16 23:21:59.000000000","message":"We have to ensure that if we are automatically setting the volume type on untyped volumes, that the volume type we are using has no attributes.\n\nI think in the test to see if default_vol_type exists, that we ensure that it has no attributes set.   If there are attributes set on a volume type, then a retype might induce a migration and or major changes on a volume, especially if that volume is attached.","commit_id":"306a52d5ea96290d77858780198d53bdaffdcf3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d52ef9a46dab0db7379313f15b13e0b7299b72d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``default_vol_type`` and if a type named"},{"line_number":38,"context_line":"  ``default_vol_type`` already exists because a deployer created it, we use it"},{"line_number":39,"context_line":"* Add an online migration to convert all untyped volumes to default"},{"line_number":40,"context_line":"  volume type"},{"line_number":41,"context_line":"* Set a default value ``default_vol_type`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fce034c_60fe6caf","line":38,"in_reply_to":"3fce034c_a5f54d85","updated":"2019-04-17 07:22:14.000000000","message":"The probable solution i can think of is to not allow updating values for default volume type as mentioned in L#44.\nsince Gorka and Eric had the same concern, we can discuss this for more possible solutions.","commit_id":"306a52d5ea96290d77858780198d53bdaffdcf3b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"fecd2e481c2fabb04cf27b5bea018c37f981534b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Don\u0027t allow updating the default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dfbec78f_7db671dc","line":45,"updated":"2019-05-03 16:48:47.000000000","message":"When you have multiple backends, say for example ceph,unity. And you are using glance via cinder. Which backend is glance using ( default_volume_type, I guess)? I assumed you can make a volume_type for each back and assign the preferred backend to the default_volume_type...\n\n\u0027Don\u0027t allow updating the default volume type\" this statement is confusing","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5f91a625c5da22ee017d7699c10d91dd6e628a12","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Don\u0027t allow updating the default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_f596fb94","line":45,"in_reply_to":"bfb3d3c7_55b1e78e","updated":"2019-06-03 05:38:52.000000000","message":"I get your point, we can surely allow it but admins need to be careful and understand the risk that any volume created by any user without a type will be created with those properties.","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"274f87a8b63779c1709b2c6af5b85b3c0ce26590","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Don\u0027t allow updating the default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfb3d3c7_55b1e78e","line":45,"in_reply_to":"bfb3d3c7_ca0d4338","updated":"2019-05-20 17:30:05.000000000","message":"This idea of not allowing the default type to have specs assigned to it doesn\u0027t follow from the problem / use case description above.\n\nWhy restrict this?\n\nAdmins should be able to add specs to the default type when this is useful to do.\n\nI think there may be some confusion here between \"if Cinder creates this type, make it an empty type, therefore retypes are safe\" vs. \"it must be an empty type\".","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1cb294e06134ec7f390dada737329f5fc3631ac6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Don\u0027t allow updating the default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfb3d3c7_ca0d4338","line":45,"in_reply_to":"dfbec78f_7db671dc","updated":"2019-05-20 06:33:23.000000000","message":"\u0027__DEFAULT__\u0027 type won\u0027t have a field \u0027volume_backend_name\u0027, it will assign backend as was done previously with untyped volumes.\nThe current point \"Don\u0027t allow updating...\" states that the properties of default volume type cannot be modified so an admin won\u0027t assign an extra spec such as multiattach or replication to the default type (which some backends don\u0027t support)","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7ca9210001a5a813ae9029af716b2fb914919aea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Mandate specifying volume type while creating volumes."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfb3d3c7_1507ef1e","line":50,"updated":"2019-05-20 17:31:59.000000000","message":"There were definitely multiple alternatives discussed both in IRC meetings and the PTG session around this that aren\u0027t mentioned here.\n\n1. Do this as a behind-the-scenes DB migration rather than relying on manual intervention with upgrade checkers.\n\n2. Do this as a best-effort-if-it\u0027s-safe operation in the volume manager, which would migrate most deployments, and skip those that are ruled out for whatever reason.  (Same reason the upgrade checker might fail.)","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5f91a625c5da22ee017d7699c10d91dd6e628a12","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Mandate specifying volume type while creating volumes."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9fb8cfa7_f5db5b7a","line":50,"in_reply_to":"bfb3d3c7_1507ef1e","updated":"2019-06-03 05:38:52.000000000","message":"Done","commit_id":"2351643fd1567f699bebd999dcf371f3f719878f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12b4c8e6e11b6fe20cf7fee3a1def26f8d06e9ba","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently a user is able to create a volume without any volume type, since"},{"line_number":20,"context_line":"a volume characteristics are defined by a volume type, creating untyped"},{"line_number":21,"context_line":"volumes shouldn\u0027t be allowed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_ec06bfce","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":7},"updated":"2019-06-09 21:07:59.000000000","message":"volume\u0027s","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3333dfa5a179874ab0e7a95e03c4a0d26804c922","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently a user is able to create a volume without any volume type, since"},{"line_number":20,"context_line":"a volume characteristics are defined by a volume type, creating untyped"},{"line_number":21,"context_line":"volumes shouldn\u0027t be allowed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_d76b2d1b","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":7},"in_reply_to":"9fb8cfa7_ec06bfce","updated":"2019-06-11 06:28:35.000000000","message":"Done","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12b4c8e6e11b6fe20cf7fee3a1def26f8d06e9ba","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"most users use volume types, and our code is simpler and less buggy if we"},{"line_number":27,"context_line":"just always attach volume types to volumes, so we should just force all"},{"line_number":28,"context_line":"deployments to use volume types."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_0c0c73eb","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":4},"updated":"2019-06-09 21:07:59.000000000","message":"Most","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3333dfa5a179874ab0e7a95e03c4a0d26804c922","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Use Cases"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"most users use volume types, and our code is simpler and less buggy if we"},{"line_number":27,"context_line":"just always attach volume types to volumes, so we should just force all"},{"line_number":28,"context_line":"deployments to use volume types."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_7774c1fe","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":4},"in_reply_to":"9fb8cfa7_0c0c73eb","updated":"2019-06-11 06:28:35.000000000","message":"Done","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a8f8a7bb955669579ce9fb8ef967e1ee4385a844","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Only admins can update the properties of default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_698f1775","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":62},"updated":"2019-06-10 14:15:02.000000000","message":"This should be controlled by the standard cinder policy which defaults to admin-only updates, right?\n\nNot sure why this is called out for the default type in particular.","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3333dfa5a179874ab0e7a95e03c4a0d26804c922","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Only admins can update the properties of default volume type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_f759918d","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":62},"in_reply_to":"9fb8cfa7_698f1775","updated":"2019-06-11 06:28:35.000000000","message":"I was concerned if it was safe to update the default type by other users since every volume will no type will have its properties. I changed it to default update policy for volume types","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"12b4c8e6e11b6fe20cf7fee3a1def26f8d06e9ba","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* Create default volume type at the time of cinder db migration or service"},{"line_number":118,"context_line":"  start time"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add upgrade check to verify no type named ``__DEFAULT__`` exist before"},{"line_number":121,"context_line":"  upgrading"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_ac0c47ec","line":120,"range":{"start_line":120,"start_character":60,"end_line":120,"end_character":65},"updated":"2019-06-09 21:07:59.000000000","message":"exists","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3333dfa5a179874ab0e7a95e03c4a0d26804c922","unresolved":false,"context_lines":[{"line_number":117,"context_line":"* Create default volume type at the time of cinder db migration or service"},{"line_number":118,"context_line":"  start time"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add upgrade check to verify no type named ``__DEFAULT__`` exist before"},{"line_number":121,"context_line":"  upgrading"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9fb8cfa7_9771350f","line":120,"range":{"start_line":120,"start_character":60,"end_line":120,"end_character":65},"in_reply_to":"9fb8cfa7_ac0c47ec","updated":"2019-06-11 06:28:35.000000000","message":"Done","commit_id":"9af8e565e5f3164121c9bb5e244ea1daf304475e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"537f1a06d0e8a9fa12dfb6ad0a150445140cab36","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9fb8cfa7_597bcb8a","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":38},"updated":"2019-06-27 18:49:26.000000000","message":"Is the check always done with this name, or is it based on the default_volume_type setting?","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cc7811ea00fde1f493565f4a5bb5a326f9845a76","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9fb8cfa7_d799bfc3","line":38,"range":{"start_line":38,"start_character":27,"end_line":38,"end_character":38},"in_reply_to":"9fb8cfa7_597bcb8a","updated":"2019-06-28 05:52:49.000000000","message":"I\u0027m not sure if there exists relation between default_volume_type option with the upgrade check.\nIn the db migration, we create a new type named \u0027__DEFAULT__\u0027 so the goal of the upgrade check is to verify that when a user is upgrading from STEIN to TRAIN, they shouldn\u0027t have a volume type named \u0027__DEFAULT__\u0027 else the db migration would fail.\nWe discussed a case when we could reuse the volume type but it might be created for a backend specific purpose (backend related extra specs) so renaming or removing that type seems much safe IMO.","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"537f1a06d0e8a9fa12dfb6ad0a150445140cab36","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9fb8cfa7_1971d3a8","line":39,"updated":"2019-06-27 18:49:26.000000000","message":"What happens with this check on the second upgrade after we\u0027ve created this type?","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e0c05459476dc46245ec6ff7e4ada31d38a73a90","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7faddb67_98f6a2f9","line":39,"in_reply_to":"7faddb67_c29f554e","updated":"2019-07-09 10:05:25.000000000","message":"IIUC in a future scenario when someone will be upgrading from STEIN to \u0027U\u0027 release then the upgrade check won\u0027t run as it is valid for upgrading to stein and isn\u0027t needed too since we will be having the \u0027__DEFAULT__\u0027 type created during migrations that ran when upgrading to stein.","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cc7811ea00fde1f493565f4a5bb5a326f9845a76","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9fb8cfa7_f7d96382","line":39,"in_reply_to":"9fb8cfa7_1971d3a8","updated":"2019-06-28 05:52:49.000000000","message":"Second upgrade?\ndo you mean when the upgrade check runs for the second time after we\u0027ve removed/renamed the existing type?","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f4982a0d067224b55f16c273f1a8185473d2725c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7faddb67_c29f554e","line":39,"in_reply_to":"9fb8cfa7_f7d96382","updated":"2019-07-08 14:52:36.000000000","message":"No, if the upgrade check runs again on a later upgrade.  Does the check run again?","commit_id":"ed4ce1d6d8eb8233abc0538067c0adc57773ad72"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to rename or remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_c7c6589b","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":21},"updated":"2019-07-10 17:36:12.000000000","message":"Do you mean to __DEFAULT__ type or to default_volume_type ?  (I\u0027m thinking __DEFAULT__ but want to be sure.)","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to rename or remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_6596604f","line":41,"range":{"start_line":40,"start_character":2,"end_line":41,"end_character":21},"in_reply_to":"7faddb67_c7c6589b","updated":"2019-07-12 06:15:58.000000000","message":"``__DEFAULT__`` is the name of default volume type\ndefault_volume_type is the config option used in cinder.conf to specify the default type to be used when creating volumes\n\nhere ``__DEFAULT__`` is being referred\nMy initial intention was to refer\n\u0027default volume type\u0027  --\u003e \u0027__DEFAULT__\u0027\nand \u0027default_volume_type\u0027 --\u003e cinder.conf config option\n\nbut due to certain updates in the spec, the meanings have changed and it has become ambiguous.\n\nSince ``__DEFAULT__`` is just a name, i didn\u0027t want to overuse it to override the meaning of \u0027default volume type\u0027 but the updates need to be made now to make it specific and less confusing. :)","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_c7e73812","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":49},"updated":"2019-07-10 17:36:12.000000000","message":"Do you mean __DEFAULT__ or the type that\u0027s the value of default_volume_type (or both)?","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  default volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_657f4015","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":49},"in_reply_to":"7faddb67_c7e73812","updated":"2019-07-12 06:15:58.000000000","message":"Oh, this needs to be changed, the __DEFAULT__ type shouldn\u0027t be deleted but other types set as default can be.","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_a7a8fc76","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":35},"updated":"2019-07-10 17:36:12.000000000","message":"Do you mean __DEFAULT__ here?  If so, my first thought is that we don\u0027t allow any changes to it; if an operator wants to change it, they should create a new volume type and set it as default_volume_type in cinder.conf","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"303cc5287596d342e5798248d83f10b0680c63df","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_267b677b","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":35},"in_reply_to":"7faddb67_65a420a7","updated":"2019-07-16 00:45:10.000000000","message":"\u003e That was my initial thought too but seemingly Eric disagreed on it.\n\n@Eric: My thought was that for interoperability, it would be good to have __DEFAULT__ be the same in all deployments. An operator who would like something more complicated can create a new volume-type and set default_volume_type to that type.  Otherwise, I can see an operator changing the default by updating the __DEFAULT__ type -- could that cause a problem for already existing volumes with __DEFAULT__ type?  If the operator is required to modify default_volume_type, that would only change things for volumes created after the operator\u0027s change.  (Or am I misunderstanding how volume-type is used?)","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b153ece747ac2406db0b3eadbe9cd05ead2dda52","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_855efc41","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":35},"in_reply_to":"7faddb67_65a420a7","updated":"2019-07-12 06:21:16.000000000","message":"I meant ``__DEFAULT__`` here but since it also comes under the same policy as of other volume types, it isn\u0027t different from default_volume_type or any other volume type.","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"},{"line_number":43,"context_line":"  option so the default value is picked when it is unset in cinder.conf"},{"line_number":44,"context_line":"* Don\u0027t allow deletion of the default volume type via type-delete"},{"line_number":45,"context_line":"* Updating of volume type (default) will be handled by MANAGE_POLICY which"},{"line_number":46,"context_line":"  defaults to admin-only"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_65a420a7","line":45,"range":{"start_line":45,"start_character":26,"end_line":45,"end_character":35},"in_reply_to":"7faddb67_a7a8fc76","updated":"2019-07-12 06:15:58.000000000","message":"That was my initial thought too but seemingly Eric disagreed on it.\nI proposed to make the __DEFAULT__ type to not be altered. See previous review comments for reference.","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"---------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"All volumes created without specifying the volume-type parameter"},{"line_number":81,"context_line":"will be associated with the default volume type."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Performance Impact"},{"line_number":84,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_6718c4d2","line":81,"updated":"2019-07-10 17:36:12.000000000","message":"I think there are two impacts here, actually: (1) users whose volumes were untyped before the migration will show up as having a type after the migration; (2) users will no longer be able to create volumes that don\u0027t have a volume type.","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":78,"context_line":"---------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"All volumes created without specifying the volume-type parameter"},{"line_number":81,"context_line":"will be associated with the default volume type."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Performance Impact"},{"line_number":84,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_c5a15448","line":81,"in_reply_to":"7faddb67_6718c4d2","updated":"2019-07-12 06:15:58.000000000","message":"Done","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* Add an upgrade check to verify that current deployment doesn\u0027t contain"},{"line_number":115,"context_line":"  any volume type named ``__DEFAULT__`` else the upgrade will fail"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* Create default volume type at the time of cinder db migration or service"},{"line_number":118,"context_line":"  start time"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add upgrade check to verify no type named ``__DEFAULT__`` exists before"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_8750605f","line":117,"range":{"start_line":117,"start_character":9,"end_line":117,"end_character":16},"updated":"2019-07-10 17:36:12.000000000","message":"I think you mean __DEFAULT__ here?","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":114,"context_line":"* Add an upgrade check to verify that current deployment doesn\u0027t contain"},{"line_number":115,"context_line":"  any volume type named ``__DEFAULT__`` else the upgrade will fail"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* Create default volume type at the time of cinder db migration or service"},{"line_number":118,"context_line":"  start time"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add upgrade check to verify no type named ``__DEFAULT__`` exists before"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_8587dcb5","line":117,"range":{"start_line":117,"start_character":9,"end_line":117,"end_character":16},"in_reply_to":"7faddb67_8750605f","updated":"2019-07-12 06:15:58.000000000","message":"Done","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  upgrading"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":124,"context_line":"  default volume type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Related code changes to associate default volume type to volumes if no"},{"line_number":127,"context_line":"  volume type is specified by user"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_a7e0fc97","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":21},"updated":"2019-07-10 17:36:12.000000000","message":"see my question at line 40","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":121,"context_line":"  upgrading"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":124,"context_line":"  default volume type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Related code changes to associate default volume type to volumes if no"},{"line_number":127,"context_line":"  volume type is specified by user"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_458d64d1","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":21},"in_reply_to":"7faddb67_a7e0fc97","updated":"2019-07-12 06:15:58.000000000","message":"Done","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d432b1839a64ad42cf7a2f7f05c9ef4c12eef7e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":124,"context_line":"  default volume type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Related code changes to associate default volume type to volumes if no"},{"line_number":127,"context_line":"  volume type is specified by user"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_879380fa","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":55},"updated":"2019-07-10 17:36:12.000000000","message":"Here I think you mean default_volume_type ?  (I think the code is already in place, really, it\u0027s just a matter of no longer allowing default_volume_type to be None and having created the __DEFAULT__ type during the upgrade or at startup.)","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3ade9c685171ebeadc271ff1bbf14f514332fcac","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":124,"context_line":"  default volume type"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"* Related code changes to associate default volume type to volumes if no"},{"line_number":127,"context_line":"  volume type is specified by user"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7faddb67_c5bab46c","line":126,"range":{"start_line":126,"start_character":36,"end_line":126,"end_character":55},"in_reply_to":"7faddb67_879380fa","updated":"2019-07-12 06:15:58.000000000","message":"Done","commit_id":"0a6641374ecf65d390f4004d468929301fb5f178"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"c03b8524e4e1fc96740e06dc1590d979f8a06ad5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to rename or remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  ``__DEFAULT__`` volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7faddb67_43cf6755","line":39,"range":{"start_line":38,"start_character":1,"end_line":39,"end_character":47},"updated":"2019-07-16 16:58:32.000000000","message":"I do not think we should allow any user to create volume type named __DFEAULT__","commit_id":"99edb4e74cc3b1805dc234264387d43a6795302f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"cdd9284be890895a29e9a32aeb81afb80c4ec863","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Create a default volume type during cinder database migration or on cinder"},{"line_number":36,"context_line":"  services start time. The default volume type will have no extra specs"},{"line_number":37,"context_line":"  assigned to it and will be named ``__DEFAULT__``"},{"line_number":38,"context_line":"* If a volume type named ``__DEFAULT__`` already exists, the deployer"},{"line_number":39,"context_line":"  needs to rename or remove it before upgrading"},{"line_number":40,"context_line":"* Add an online migration to convert all untyped volumes and snapshots to"},{"line_number":41,"context_line":"  ``__DEFAULT__`` volume type"},{"line_number":42,"context_line":"* Set a default value ``__DEFAULT__`` for ``default_volume_type`` config"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7faddb67_54a4f1b9","line":39,"range":{"start_line":38,"start_character":1,"end_line":39,"end_character":47},"in_reply_to":"7faddb67_43cf6755","updated":"2019-07-17 15:24:43.000000000","message":"Possibly, but this doesn\u0027t help in the case that the type was created in the past.  So, regardless we would have to have this check.","commit_id":"99edb4e74cc3b1805dc234264387d43a6795302f"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"c03b8524e4e1fc96740e06dc1590d979f8a06ad5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"1. Mandate specifying volume type while creating volumes."},{"line_number":52,"context_line":"2. Do this as a behind-the-scenes DB migration rather than relying on manual"},{"line_number":53,"context_line":"   intervention with upgrade checkers."},{"line_number":54,"context_line":"3. Do this as a best-effort-if-it\u0027s-safe operation in the volume manager,"},{"line_number":55,"context_line":"   which would migrate most deployments, and skip those that are ruled out for whatever reason."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"REST API impact"},{"line_number":58,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7faddb67_6332a360","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":95},"updated":"2019-07-16 16:58:32.000000000","message":"We can specify that volumes with types cannot be used for anything but change volume type, query or deletion. Any other operation results in error.","commit_id":"99edb4e74cc3b1805dc234264387d43a6795302f"}]}