)]}'
{"id":"openstack%2Fcinder-specs~652275","triplet_id":"openstack%2Fcinder-specs~master~Ia9961f24c4ce78eec61601bd8308868a31a673d6","project":"openstack/cinder-specs","branch":"master","topic":"bp/proposes","hashtags":[],"change_id":"Ia9961f24c4ce78eec61601bd8308868a31a673d6","subject":"Leverage compression hardware accelerator","status":"MERGED","created":"2019-04-14 11:42:01.000000000","updated":"2019-07-25 13:10:42.000000000","submitted":"2019-07-25 13:10:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":60,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"652275-1564060242151-53055c7d","meta_rev_id":"48a7be33beadbd7bcb6b44b2a76b13999eb741d4","_number":652275,"virtual_id_number":652275,"owner":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":2,"date":"2019-07-25 13:10:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":2,"date":"2019-07-23 19:31:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2019-07-25 12:53:51.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-24 15:27:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"all":[{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-07-25 12:53:51.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-17 16:42:29.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-07-23 19:31:19.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-07-24 15:27:02.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-07-25 12:53:51.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2019-07-25 13:10:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3beacc107b7a3e301d266fe22f4c3e1bc8f8a77a","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-04-14 11:42:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"afaad770f77347ab82785fe94ee4f710858327a7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-14 11:50:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/1/check/openstack-tox-docs/6c2dd78/html/ : SUCCESS in 3m 42s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/1/check/openstack-tox-pep8/115bca8/ : FAILURE in 2m 43s","accounts_in_message":[],"_revision_number":1},{"id":"a44388d6086b53fe5622814378a146dae6acb742","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-04-14 11:54:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"21e8474809502e21405ed0000ab0b9060b58fb77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-14 11:58:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/2/check/openstack-tox-docs/1800039/html/ : SUCCESS in 3m 05s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/2/check/openstack-tox-pep8/f72de98/ : SUCCESS in 3m 04s","accounts_in_message":[],"_revision_number":2},{"id":"6220fd929f9d4e49870f49c9c277be814c6a12cf","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-15 14:16:27.000000000","message":"Patch Set 2: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"aeb9869306c9abf5cae3111d8839395a4d81d9c7","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-04-16 02:05:34.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"61ae8dd6e7b35a15dedd39ce2cc329a9164ac97f","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2019-05-03 15:46:53.000000000","message":"Patch Set 2: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"5f9b24cfe8f0472fe7d3bb95ff3f1cdac4bfd335","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-03 09:42:04.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c9145a2fa6b9e08b916bafc9fbb5250c7fff5109","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-03 09:42:28.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"5a91ab8c69674c955fbdc3b9f4cd546293a8c075","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 10:00:02.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/3/check/openstack-tox-docs/4c6b538/html/ : SUCCESS in 4m 33s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/3/check/openstack-tox-pep8/aba14a7/ : SUCCESS in 3m 08s","accounts_in_message":[],"_revision_number":3},{"id":"8e0a82b35b69824fc642f2304b63bd24ae4a8909","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-09 07:31:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"73ca95a566c4d6b7dcc580c9cd32f39b96cb32f7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-09 07:43:33.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/4/check/openstack-tox-docs/88005d4/html/ : SUCCESS in 5m 52s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/4/check/openstack-tox-pep8/b62f2b0/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":4},{"id":"f29fdd55336108c0b6eb82d8b90f07c1a954bcad","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-10 12:57:43.000000000","message":"Patch Set 4: Code-Review-1\n\n(5 comments)\n\nI have some questions inline.\n\nYou\u0027re going to have to convince the glance team to add a new container_format or disk_format for this.  You are thinking of it as a new disk_format for cinder volumes, but another way to think of it is as a new  container_format that will contain a raw-format image file when Cinder uploads an image, but could also contain other image formats for other purposes.  (My personal opinion is that this makes more sense as a container_format, but I\u0027m open to hearing contrary views.)","accounts_in_message":[],"_revision_number":4},{"id":"58972046cb75cfe72058136a979503cfc8a2516b","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-07-10 16:46:05.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"41461dd74aaa1a6cadf3ab2d34c94592df1663b1","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-07-10 17:06:09.000000000","message":"Patch Set 4:\n\nNeed to understand what happens w/ Ceph, NFS, etc backends","accounts_in_message":[],"_revision_number":4},{"id":"e1654b327c81a2093ebdabe98c123aa41e05be2b","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-12 03:42:31.000000000","message":"Patch Set 4:\n\n(6 comments)","accounts_in_message":[],"_revision_number":4},{"id":"7fe483d05bbd17f1980e300bc828e47d200c81bb","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-12 03:49:35.000000000","message":"Patch Set 4:\n\n@Eric Regarding Ceph, NFS, we setup these two as backend storage in our environment, took a test. These two has no difference in image conversion. \n\nSome Logs\n-----------------\nceph: qemu-img convert -O qcow2 /opt/stack/data/cinder/conversion/volume-a09964ce-6c33-49c3-bdd9-9b72beea8dbf-73f66bee-1a7b-498f-8ea0-3a3afca730d9 /opt/stack/data/cinder/conversion/tmpiZIyvb\n\nNFS:qzip -k /opt/stack/data/cinder/mnt/954b712a131a8f984fda77e5bf4d6c10/volume-38db9371-7879-4c50-b31a-46782f1e763d -o /opt/stack/data/cinder/conversion/tmpd91TTd\n\nThe volumes will be mounted to /opt/stack/data/cinder/… as a normal file(ceph) or blockfile(NFS). These are all supported.","accounts_in_message":[],"_revision_number":4},{"id":"5862b01107366e49be278a3228220c561a9400df","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-12 08:18:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"6c28f7c47601fefde766a25c939dfc206646e40e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 08:27:27.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/5/check/openstack-tox-docs/d18ec62/html/ : SUCCESS in 4m 56s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/5/check/openstack-tox-pep8/c321113/ : SUCCESS in 3m 41s","accounts_in_message":[],"_revision_number":5},{"id":"c5990655a4fe3e0eccf95c42fdd6106dd8428f59","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-07-17 16:42:29.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"cabd312c7c62841a911201da949fcd82e4f842ee","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-07-17 18:16:18.000000000","message":"Patch Set 5: Code-Review-1\n\n(8 comments)\n\nMostly looks good.  A few wording things and a few suggestions for additional content.","accounts_in_message":[],"_revision_number":5},{"id":"a679cb0c04205c6c6ad33a2e577ea6c0c3090497","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-17 21:10:27.000000000","message":"Patch Set 5: Code-Review-1\n\nThe original intent of this spec was to take advantage of a hardware accelerator if one exists, but after discussion, it\u0027s changed to something like: support upload of compressed volume-images to glance (because if there\u0027s no accelerator, we\u0027ll fall back to software compression).  What I\u0027m getting at, is the original proposal would fail image creation if a compressed image was requested but a hardware accelerator is not present.  Now, image creation will succeed even if there\u0027s no accelerator, and this may be undesirable with respect to CPU load.\n\nMy question is: do we want to add a config option, something like allow_compression_on_image_upload, to control this (similar to what Eric is doing on https://review.opendev.org/#/c/668943/)?  Another possibility is that operators could control this by removing \u0027gz\u0027 from the allowable container formats on the Glance side (it\u0027s controlled by a config option).\n\nMy request here is to address this issue either in the Proposed Change section (if adding a config option is a good idea) or in the Alternatives section if this is something we don\u0027t want to do.","accounts_in_message":[],"_revision_number":5},{"id":"d81047558ffd8f47d60e0891c0168eba8e0e5a2b","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-17 21:11:42.000000000","message":"Patch Set 5:\n\nOne other thing -- are there any incompatibilities between https://review.opendev.org/#/c/668943/ and this proposal?","accounts_in_message":[],"_revision_number":5},{"id":"6571c6c48d5712b3b137fbdab29b367fe6f1feca","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-17 21:25:12.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"41b598abae0e192900a1dd81f79fd37711a48dbf","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-18 07:59:50.000000000","message":"Patch Set 5:\n\n(10 comments)\n\n@rosmaita I think if user don\u0027t want compress the image, they can just select container_format as bare, then no compression will happen. So it seems we don\u0027t need the option \"allow_compression_on_image_upload\". This is different with Eric\u0027s solution where user would have no choice if without the option, the target disk format would always be qcow2.\n\nThis spec will not have any incompatibilities with Eric solution. Eric\u0027s solution is compression inside qcow2 format, after compressed, the disk format is still qcow2, this is transparent to outside world, and is disk format level. Just like we enabled the compression option in some filesystem such as btrfs, user can open/read/write files as usual, it\u0027s transparent to filesystem users. This spec is container format level. User may can group like these ways:\n\ncontainer_format: compressed, disk_format: qcow2(can be in compressed or not) If qcow2 in compressed, then it would be no benefit to select container_format also as compressed.\n\ncontainer_format: compressed disk_format: raw. This is the ideal choice","accounts_in_message":[],"_revision_number":5},{"id":"fab784145f48719d39e501a4ca19f4fb4d120bd0","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-18 08:12:15.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"d70ccd291920f5caad6d7203e78353322d340575","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-18 08:21:47.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/6/check/openstack-tox-docs/480de9d/html/ : SUCCESS in 4m 12s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/6/check/openstack-tox-pep8/557fade/ : SUCCESS in 3m 34s","accounts_in_message":[],"_revision_number":6},{"id":"b481296fb4a61e101e290ebf1ab187cb44fc6399","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-18 08:38:12.000000000","message":"Patch Set 6:\n\n@Eric About NFS with snapshot, we did test and it works well with compression.\n\nWhen uploading, the procedure is:\n1. First use .info file to merge all changes (merge all snapshots and base volume to create a complete volume), this process will source the .info file in dir, e.g. /opt/stack/data/cinder/mnt/954b712a131a8f984fda77e5bf4d6c10. The cmd is like:\n\nqemu-img convert -O raw /opt/stack/data/cinder/mnt/954b712a131a8f984fda77e5bf4d6c10/volume-0635fa23-9ce9-46d6-b178-bd0993fb5398.7c228ff3-5ba1-4c55-8b33-04f15724a3ce /opt/stack/data/cinder/conversion/0635fa23-9ce9-46d6-b178-bd0993fb5398.temp_image.ef76f39d-531a-4eb5-a2dd-35f28bcb2ac2rkNgzN.img\n\n2. Compress the merged volume. e.g.\nqzip -k /opt/stack/data/cinder/conversion/0635fa23-9ce9-46d6-b178-bd0993fb5398.temp_image.ef76f39d-531a-4eb5-a2dd-35f28bcb2ac2rkNgzN.img -o /opt/stack/data/cinder/conversion/tmprR3uPD","accounts_in_message":[],"_revision_number":6},{"id":"b7dea98a5ce3707bd1ca6cb907d9527642a3ad21","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-18 13:22:19.000000000","message":"Patch Set 6: Code-Review-1\n\n(7 comments)\n\n\u003e @rosmaita I think if user don\u0027t want compress the image, they can just select container_format as bare, then no compression will happen. So it seems we don\u0027t need the option \"allow_compression_on_image_upload\".\n\nSorry I wasn\u0027t clear.  The problem is that the user may very well want to use compression, but the *operator* may not want to allow this because of the performance impact on the cinder nodes.  (This is a problem because the spec is now specifying software fallback for compression/decompression.)  So I think we need to seriously consider whether this should be configurable or not.  If you think it should be configurable, please add to \"Proposed Change\" section; if you disagree, please explain in the \"Alternatives\" section.\n\nThanks for the analysis of compatibility with Eric\u0027s qcow2 compression patch.","accounts_in_message":[],"_revision_number":6},{"id":"8b51eaeb7a686e75b32c9c4c728ba61584b4a56b","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-19 04:01:22.000000000","message":"Patch Set 6:\n\n(6 comments)\n\n@rosmaita I get your point of adding an option to control enable/disable compression now. It makes sense. Thanks","accounts_in_message":[],"_revision_number":6},{"id":"48292eeb46ad82f161bce0ddafa5e72db7e360ff","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2019-07-19 04:04:34.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"56f78ec4b6e226863b45da6ba120f0f229b2e8b1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-19 04:14:54.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/7/check/openstack-tox-docs/c507c51/html/ : SUCCESS in 4m 40s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/7/check/openstack-tox-pep8/441a5a9/ : SUCCESS in 2m 26s","accounts_in_message":[],"_revision_number":7},{"id":"02a883bb19dcda09d6ebed2df4f1cbf751b8927d","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-07-23 19:31:19.000000000","message":"Patch Set 7: Code-Review+2\n\nAll my concerns have been addressed.  This looks worth doing.","accounts_in_message":[],"_revision_number":7},{"id":"258a242c0e3ef44a4608f53164d0cddc2cfe305c","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-07-24 15:27:02.000000000","message":"Patch Set 7: Code-Review+2\n\nMy issues have been addressed and I think this is a good solution.  Thanks!","accounts_in_message":[],"_revision_number":7},{"id":"9dd9eff44ecc495b626b41b0958db4ba89c79b28","author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"date":"2019-07-25 12:53:51.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1\n\nLooks good.","accounts_in_message":[],"_revision_number":7},{"id":"782ecb64b2be9c9e0ebdff665dceb46bfa5390ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 12:54:03.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":7},{"id":"6aa261a2d1551e3f771273582fe935fccdf73492","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 13:10:41.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/75/652275/7/gate/openstack-tox-docs/b711dc5/html/ : SUCCESS in 5m 02s\n- openstack-tox-pep8 http://logs.openstack.org/75/652275/7/gate/openstack-tox-pep8/56ee86b/ : SUCCESS in 5m 57s","accounts_in_message":[],"_revision_number":7},{"id":"dcf08ddb9f9c5f7084b7022959389faef7c64be4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-25 13:10:42.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"65d68b89fe08bde2ef8df7d7a84beaa8e74598c7","revisions":{"820355304ae4c494c748ba9ced756cb472beb037":{"kind":"REWORK","_number":1,"created":"2019-04-14 11:42:01.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/1"}}},"commit":{"parents":[{"commit":"e1aa893acfae5017f0e43611987d1a3f7948cc55","subject":"Merge \"Move Generic Backups spec to Train release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/e1aa893acfae5017f0e43611987d1a3f7948cc55"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:40:04.000000000","tz":480},"subject":"[WIP] Leverage compression hardware accelerator","message":"[WIP] Leverage compression hardware accelerator\n\nThis blueprint proposes to leverage hardware compression accelerator to\naccelerate the image compression when uploading volume to glance as image.\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/820355304ae4c494c748ba9ced756cb472beb037"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/820355304ae4c494c748ba9ced756cb472beb037"}]},"branch":"refs/heads/master"},"04e441983bd4a1b9bce24b7b3e0e9b6aec46d0cf":{"kind":"REWORK","_number":2,"created":"2019-04-14 11:54:33.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/2"}}},"commit":{"parents":[{"commit":"e1aa893acfae5017f0e43611987d1a3f7948cc55","subject":"Merge \"Move Generic Backups spec to Train release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/e1aa893acfae5017f0e43611987d1a3f7948cc55"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:52:56.000000000","tz":480},"subject":"[WIP] Leverage compression hardware accelerator","message":"[WIP] Leverage compression hardware accelerator\n\nThis blueprint proposes to leverage hardware compression accelerator to\naccelerate the image compression when uploading volume to glance as image.\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/04e441983bd4a1b9bce24b7b3e0e9b6aec46d0cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/04e441983bd4a1b9bce24b7b3e0e9b6aec46d0cf"}]},"branch":"refs/heads/master"},"5c305df679c42cc4c341d3dc4fb68ed90ed17648":{"kind":"REWORK","_number":3,"created":"2019-07-03 09:42:04.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/3"}}},"commit":{"parents":[{"commit":"605dd3d2847065a6e36aabefff137899e9f7d430","subject":"Merge \"Support multiple stores of Glance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/605dd3d2847065a6e36aabefff137899e9f7d430"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-07-03 17:40:07.000000000","tz":0},"subject":"Leverage compression hardware accelerator","message":"Leverage compression hardware accelerator\n\nThis blueprint proposes to leverage hardware compression accelerator to\naccelerate the image compression when uploading volume to glance as image.\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/5c305df679c42cc4c341d3dc4fb68ed90ed17648"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/5c305df679c42cc4c341d3dc4fb68ed90ed17648"}]},"branch":"refs/heads/master"},"55493da36669c2034cb39e856e5c436ffed3b978":{"kind":"REWORK","_number":4,"created":"2019-07-09 07:31:02.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/4"}}},"commit":{"parents":[{"commit":"605dd3d2847065a6e36aabefff137899e9f7d430","subject":"Merge \"Support multiple stores of Glance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/605dd3d2847065a6e36aabefff137899e9f7d430"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-07-09 07:29:28.000000000","tz":480},"subject":"Leverage compression hardware accelerator","message":"Leverage compression hardware accelerator\n\nThis blueprint proposes to leverage hardware compression accelerator to\naccelerate the image compression when uploading volume to glance as image.\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/55493da36669c2034cb39e856e5c436ffed3b978"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/55493da36669c2034cb39e856e5c436ffed3b978"}]},"branch":"refs/heads/master"},"ce129bc1819695e3fde8dd91febd682fc5e53cc7":{"kind":"REWORK","_number":5,"created":"2019-07-12 08:18:57.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/5"}}},"commit":{"parents":[{"commit":"605dd3d2847065a6e36aabefff137899e9f7d430","subject":"Merge \"Support multiple stores of Glance\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/605dd3d2847065a6e36aabefff137899e9f7d430"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-07-12 08:13:53.000000000","tz":480},"subject":"Leverage compression hardware accelerator","message":"Leverage compression hardware accelerator\n\nThis spec proposes to leverage hardware compression accelerator to accelerate:\n1) Image compression when uploading volume to glance as image.\n2) Image decompression when creating volume from image\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/ce129bc1819695e3fde8dd91febd682fc5e53cc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/ce129bc1819695e3fde8dd91febd682fc5e53cc7"}]},"branch":"refs/heads/master"},"93d4de55743795d220f96784e4cdda1ea97c7558":{"kind":"REWORK","_number":6,"created":"2019-07-18 08:12:15.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/6"}}},"commit":{"parents":[{"commit":"cae133139bd278b3ab4b159c78da2dea7db38d6c","subject":"Merge \"Remove backend async migrate spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/cae133139bd278b3ab4b159c78da2dea7db38d6c"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-07-18 08:08:37.000000000","tz":480},"subject":"Leverage compression hardware accelerator","message":"Leverage compression hardware accelerator\n\nThis spec proposes to leverage hardware compression accelerator to accelerate:\n1) Image compression when uploading volume to glance as image.\n2) Image decompression when creating volume from image\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/93d4de55743795d220f96784e4cdda1ea97c7558"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/93d4de55743795d220f96784e4cdda1ea97c7558"}]},"branch":"refs/heads/master"},"65d68b89fe08bde2ef8df7d7a84beaa8e74598c7":{"kind":"REWORK","_number":7,"created":"2019-07-19 04:04:34.000000000","uploader":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"ref":"refs/changes/75/652275/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/75/652275/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/75/652275/7"}}},"commit":{"parents":[{"commit":"cae133139bd278b3ab4b159c78da2dea7db38d6c","subject":"Merge \"Remove backend async migrate spec\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/cae133139bd278b3ab4b159c78da2dea7db38d6c"}]}],"author":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-04-14 11:36:29.000000000","tz":480},"committer":{"name":"Liang Fang","email":"liang.a.fang@intel.com","date":"2019-07-19 04:03:19.000000000","tz":480},"subject":"Leverage compression hardware accelerator","message":"Leverage compression hardware accelerator\n\nThis spec proposes to leverage hardware compression accelerator to accelerate:\n1) Image compression when uploading volume to glance as image.\n2) Image decompression when creating volume from image\n\nChange-Id: Ia9961f24c4ce78eec61601bd8308868a31a673d6\nSigned-off-by: Liang Fang \u003cliang.a.fang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/65d68b89fe08bde2ef8df7d7a84beaa8e74598c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/65d68b89fe08bde2ef8df7d7a84beaa8e74598c7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}