)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"afab0d3920f24aed9fc5de64a2abe31659663de3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xuanyandong \u003cxuanyandong@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-03 10:07:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id to table volumes;"},{"line_number":8,"context_line":"When the backup restore chooses to create a new volume, write backup_id to it"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id6cc95b39e8ab0d295624a6ea743de9113b09753"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_41b543cf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2020-01-03 02:29:00.000000000","message":"How about say \"Add backup_id field to volumes\"?","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"afab0d3920f24aed9fc5de64a2abe31659663de3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xuanyandong \u003cxuanyandong@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-03 10:07:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id to table volumes;"},{"line_number":8,"context_line":"When the backup restore chooses to create a new volume, write backup_id to it"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id6cc95b39e8ab0d295624a6ea743de9113b09753"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_017d0b1d","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":31},"updated":"2020-01-03 02:29:00.000000000","message":"Redundant\n\nYou should add a white line after the commit message tittle.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"afab0d3920f24aed9fc5de64a2abe31659663de3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-01-03 10:07:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id to table volumes;"},{"line_number":8,"context_line":"When the backup restore chooses to create a new volume, write backup_id to it"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id6cc95b39e8ab0d295624a6ea743de9113b09753"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_418c632d","line":8,"range":{"start_line":8,"start_character":56,"end_line":8,"end_character":77},"updated":"2020-01-03 02:29:00.000000000","message":"maybe say \"record \u0027backup_id\u0027 in it\".","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"afab0d3920f24aed9fc5de64a2abe31659663de3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id to table volumes;"},{"line_number":8,"context_line":"When the backup restore chooses to create a new volume, write backup_id to it"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id6cc95b39e8ab0d295624a6ea743de9113b09753"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_81a57ba2","line":9,"updated":"2020-01-03 02:29:00.000000000","message":"Add the hyperlinks for blueprints:\n\nImplements: blueprint add-volume-backup-id","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     xuanyandong \u003cxuanyandong@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-01-03 18:00:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id field to volumes;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the backup restore chooses to create a new volume, record \u0027backup_id\u0027 in it"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_db935b58","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":31},"updated":"2020-01-03 14:50:57.000000000","message":"Drop this.","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup_id field to volumes;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the backup restore chooses to create a new volume, record \u0027backup_id\u0027 in it"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint add-volume-backup-id"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_7b86e718","line":9,"updated":"2020-01-03 14:50:57.000000000","message":"Keep lines within 72 characters.","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f8ea9147b1d40d62d129731dd92e5da1186dea24","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add backup id to volume\u0027s metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the backup restore chooses to create a new volume,"},{"line_number":10,"context_line":"record \u0027backup_id\u0027 in it"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint add-volume-backup-id"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3fa7e38b_211c6e79","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":24},"updated":"2020-01-29 12:58:48.000000000","message":"would be worth updating this to reflect the current proposal:\n\nWhen the backup restore chooses to create a new volume, record \u0027src_backup_id\u0027 in the volume metadata.","commit_id":"8e5cfb0363a81fa8ca7fc6e622b666059a214310"}],"specs/untargeted/add_backup_id_to_volume.rst":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is not save to the volumes table"},{"line_number":17,"context_line":"Users want to know which backup this volume was created from."},{"line_number":18,"context_line":"Now we can know which snapshot, volume was created from, but there is"},{"line_number":19,"context_line":"no backup id record"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_fc0734c7","line":19,"updated":"2020-01-03 06:40:37.000000000","message":"\"Problem descript\" shuold be description the exist problem now. I think you want to say: \n\"Currently, the end user can see the source （source by snapshot or image etc.） from the new volume created. But when the end user was restored a backup volume, in the volume\u0027s response, we cannot see its source, this will cause a lot of confusion for end users.\"","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"1. Users wants to know which backup this volume was created from."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_5c30c89e","line":23,"updated":"2020-01-03 06:40:37.000000000","message":"As an end user, I would like to know the restored volume comes from which backup file.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"* Add the fileld \"backup_id\" to the table volumes, mark which backup"},{"line_number":28,"context_line":"  the volume from"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Add the new properties ``backup_id`` to the Object Volumes, and return to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_1cdb304e","line":27,"range":{"start_line":27,"start_character":10,"end_line":27,"end_character":16},"updated":"2020-01-03 06:40:37.000000000","message":"s/fileld/field/\n\nAdd a new field ``backup_id`` to the ``volumes`` table, to record where the new volume came from.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"* Add the fileld \"backup_id\" to the table volumes, mark which backup"},{"line_number":28,"context_line":"  the volume from"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Add the new properties ``backup_id`` to the Object Volumes, and return to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_7c14a4ea","line":27,"range":{"start_line":27,"start_character":36,"end_line":27,"end_character":49},"updated":"2020-01-03 06:40:37.000000000","message":"s/table volumes/``volumes`` table/","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* Add the fileld \"backup_id\" to the table volumes, mark which backup"},{"line_number":28,"context_line":"  the volume from"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Add the new properties ``backup_id`` to the Object Volumes, and return to"},{"line_number":31,"context_line":"  the user, let user know where the volume is from throuth the"},{"line_number":32,"context_line":"  api `` GET /v3/{project_id}/volumes/detail ``"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add the new properties ``backup_id`` to cinder show response"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_fcae549f","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":47},"updated":"2020-01-03 06:40:37.000000000","message":"In \"REST API impact\" you will describe the details, so here point the change is ok.\n\n* Add ``backup_id`` properties to the List accessible volumes with details API.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  the user, let user know where the volume is from throuth the"},{"line_number":32,"context_line":"  api `` GET /v3/{project_id}/volumes/detail ``"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add the new properties ``backup_id`` to cinder show response"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Vendor-specific changes"},{"line_number":37,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_fca3b4ae","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":62},"updated":"2020-01-03 06:40:37.000000000","message":"ditto\n\n* Add ``backup_id`` properties to the Show a volume’s details API.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Data model impact"},{"line_number":45,"context_line":"-----------------"},{"line_number":46,"context_line":"None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"REST API impact"},{"line_number":49,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_fc917446","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":4},"updated":"2020-01-03 06:40:37.000000000","message":"You will add column of ``backup_id`` to the ``volumes`` table, so if the user want to ues this feature, they should upgrade firstly, otherwise, the request will be rejected.","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"REST API impact"},{"line_number":49,"context_line":"---------------"},{"line_number":50,"context_line":"The rest API look like this in v3:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. code-block:: console"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_1ca9f08d","line":50,"updated":"2020-01-03 06:40:37.000000000","message":"This change will change the exist cinder API, so you should add a new microversion for this change, so\n\nAdd a new microversion to the Show a volume’s details and List accessible volumes with details APIs","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dbf9a677cb8524537daa1d804d2c743dcea7845c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. code-block:: console"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  GET /v3/{project_id}/volumes/detail"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. code-block:: python"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_3c870c15","line":54,"updated":"2020-01-03 06:40:37.000000000","message":"URL: /v3/{project_id}/volumes/detail\n\n* Request method: GET (List accessible volumes with details)\n\n  Add the ``backup_id`` parameter to the response body.\n\n* List accessible volumes with details API:\n\n  .. code-block:: json\n\n    {\n        \"volumes\": {\n           ...\n           \"backup_id\": \"cb49b381-9012-40cb-b8ee-80c19a4801b5\"\n        }\n    }\n\nURL: /v3/{project_id}/volumes/{volume_id}\n\n* Request method: GET (Show a volume’s details)\n\n  Add the ``backup_id`` parameter to the response body.\n\n* Show a volume’s details API:\n\n  .. code-block:: json\n\n    {\n        \"volumes\": {\n           ...\n           \"backup_id\": \"cb49b381-9012-40cb-b8ee-80c19a4801b5\"\n        }\n    }","commit_id":"c2658100ff1694b18b9f17224d865d4411bb4a39"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Select to create a new volume when the backup is restored, the backup_id"},{"line_number":16,"context_line":"is not save to the volumes table"},{"line_number":17,"context_line":"Users want to know which backup this volume was created from."},{"line_number":18,"context_line":"Now we can know which snapshot, volume was created from, but there is"},{"line_number":19,"context_line":"no backup id record"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_3b7cef20","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":32},"updated":"2020-01-03 14:50:57.000000000","message":"This needs to be reworded. I needed to reread it a couple times to figure out what it was saying. How about something like:\n\n\"When creating a new volume from a backup, there is no record of which backup was used.\"","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"1. Users wants to know which backup this volume was created from."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_5b81abf9","line":23,"range":{"start_line":23,"start_character":3,"end_line":23,"end_character":8},"updated":"2020-01-03 14:50:57.000000000","message":"User","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Proposed change"},{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":"* Add the fileld \"backup_id\" to the table volumes, mark which backup"},{"line_number":28,"context_line":"  the volume from"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Add the new properties ``backup_id`` to the Object Volumes, and return to"},{"line_number":31,"context_line":"  the user, let user know where the volume is from throuth the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_fb79772f","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":17},"updated":"2020-01-03 14:50:57.000000000","message":"\"the volume was created from\" ?","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":27,"context_line":"* Add the fileld \"backup_id\" to the table volumes, mark which backup"},{"line_number":28,"context_line":"  the volume from"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Add the new properties ``backup_id`` to the Object Volumes, and return to"},{"line_number":31,"context_line":"  the user, let user know where the volume is from throuth the"},{"line_number":32,"context_line":"  api `` GET /v3/{project_id}/volumes/detail ``"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add the new properties ``backup_id`` to cinder show response"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_7b8b4716","line":31,"range":{"start_line":30,"start_character":62,"end_line":31,"end_character":62},"updated":"2020-01-03 14:50:57.000000000","message":"\"and include the backup_id detail in the results from the api...\" maybe?","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":46,"context_line":"None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"REST API impact"},{"line_number":49,"context_line":"---------------"},{"line_number":50,"context_line":"The rest API look like this in v3:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_5b968b3f","line":49,"updated":"2020-01-03 14:50:57.000000000","message":"This doesn\u0027t mention it, but it should be clear that this will only be added in a new microversion.","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ae2fdde3d5def87c9584c39ccc871af793f86c95","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Testing"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":"* Add related unittest"},{"line_number":110,"context_line":"* Add related functional test"},{"line_number":111,"context_line":"* Add tempest tests"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_fb9e5753","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":22},"updated":"2020-01-03 14:50:57.000000000","message":"unit tests","commit_id":"6ace01508768c0959f183debfee3e1b5caca8a78"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4d1669593cc5a9eb5de1c5f6bb85ea15f0141197","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from the new volume created. But when the end user was"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source, this will cause a lot of"},{"line_number":19,"context_line":"confusion for end users"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_e73d5829","line":19,"range":{"start_line":19,"start_character":22,"end_line":19,"end_character":23},"updated":"2020-01-04 02:47:59.000000000","message":"\".\" Lack of a period end of the sentence.","commit_id":"efc7d3a9827cc77470a8226a38819c99b41fb23c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"4d1669593cc5a9eb5de1c5f6bb85ea15f0141197","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  to record where the new volume came from."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add ``backup_id`` properties to the List accessible volumes"},{"line_number":32,"context_line":"  with details API. `` GET /v3/{project_id}/volumes/detail ``"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add ``backup_id`` properties to the Show a volume’s details API."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_27385039","line":32,"range":{"start_line":32,"start_character":20,"end_line":32,"end_character":61},"updated":"2020-01-04 02:47:59.000000000","message":"You can remove this, because of some details in \"REST API impact\".","commit_id":"efc7d3a9827cc77470a8226a38819c99b41fb23c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e34320c457dab7ecdfe16327da32dcc99862c16f","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Other end user impact"},{"line_number":96,"context_line":"---------------------"},{"line_number":97,"context_line":"None."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_07c8b453","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":4},"updated":"2020-01-04 01:59:44.000000000","message":"It will add a column of ``backup_id`` to the ``volumes`` table, so if the user want to ues this feature, they should upgrade firstly, otherwise, the request will be rejected.","commit_id":"efc7d3a9827cc77470a8226a38819c99b41fb23c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e34320c457dab7ecdfe16327da32dcc99862c16f","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Testing"},{"line_number":131,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":132,"context_line":"* Add related unittest"},{"line_number":133,"context_line":"* Add related functional test"},{"line_number":134,"context_line":"* Add tempest tests"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_27c5b03d","line":132,"range":{"start_line":132,"start_character":14,"end_line":132,"end_character":22},"updated":"2020-01-04 01:59:44.000000000","message":"s/unittest/unit tests/","commit_id":"efc7d3a9827cc77470a8226a38819c99b41fb23c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* Add ``backup_id`` properties to the List accessible volumes"},{"line_number":32,"context_line":"  with details API."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add ``backup_id`` properties to the Show a volume’s details API."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Vendor-specific changes"},{"line_number":37,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_954cc740","line":34,"range":{"start_line":34,"start_character":51,"end_line":34,"end_character":52},"updated":"2020-01-06 07:02:49.000000000","message":"\"volume\u0027s\"  This need to be change the EN symbol.","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"REST API impact"},{"line_number":51,"context_line":"---------------"},{"line_number":52,"context_line":"This will be add a new microversion, if that"},{"line_number":53,"context_line":"env does not upgrade, the request will be rejected"},{"line_number":54,"context_line":"The List accessible volumes with details rest API look like"},{"line_number":55,"context_line":"this in v3:"},{"line_number":56,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_d5c1df82","line":53,"range":{"start_line":52,"start_character":35,"end_line":53,"end_character":50},"updated":"2020-01-06 07:02:49.000000000","message":"Remove this sentence, and add a while line.","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":"  * Add the ``backup_id`` parameter to the response body."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The Show a volume’s details rest API look like this in v3:"},{"line_number":71,"context_line":".. code-block:: console"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  GET: /v3/{project_id}/volumes/{volume_id}"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_15c45793","line":70,"range":{"start_line":70,"start_character":17,"end_line":70,"end_character":18},"updated":"2020-01-06 07:02:49.000000000","message":"ditto","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      \"backup_id\": \"cb49b381-9012-40cb-b8ee-80c19a4801b5\""},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":"  }"},{"line_number":83,"context_line":"  * Add the ``backup_id``parameter to the response body."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_95de0769","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":25},"updated":"2020-01-06 07:02:49.000000000","message":"lack of a space","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Other end user impact"},{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":"It will add a column of ``backup_id`` to the ``volumes`` table,"},{"line_number":97,"context_line":"so if the user want to ues this feature, they should upgrade"},{"line_number":98,"context_line":"firstly, otherwise, the request will be rejected."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_75382b9e","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":14},"updated":"2020-01-06 07:02:49.000000000","message":"a new","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Other end user impact"},{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":"It will add a column of ``backup_id`` to the ``volumes`` table,"},{"line_number":97,"context_line":"so if the user want to ues this feature, they should upgrade"},{"line_number":98,"context_line":"firstly, otherwise, the request will be rejected."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_95b7e722","line":97,"range":{"start_line":97,"start_character":23,"end_line":97,"end_character":26},"updated":"2020-01-06 07:02:49.000000000","message":"s/ues/use/","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0f94c3fe8252dcbba30d4c786a4306fd96cda536","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Other end user impact"},{"line_number":95,"context_line":"---------------------"},{"line_number":96,"context_line":"It will add a column of ``backup_id`` to the ``volumes`` table,"},{"line_number":97,"context_line":"so if the user want to ues this feature, they should upgrade"},{"line_number":98,"context_line":"firstly, otherwise, the request will be rejected."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Performance Impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3fa7e38b_5533afc4","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":19},"updated":"2020-01-06 07:02:49.000000000","message":"wants","commit_id":"ccae0d78ca015626b427300b3b7c9d171b6bc81f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"76fad4b65e65b14253122ea28b2a8e015500a599","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      \"backup_id\": \"cb49b381-9012-40cb-b8ee-80c19a4801b5\""},{"line_number":65,"context_line":"    }]"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":"  * Add the ``backup_id`` parameter to the response body."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"The Show a volume\u0027s details rest API look like this in v3:"},{"line_number":70,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_e4654be3","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":4},"updated":"2020-01-06 14:36:16.000000000","message":"These get formatted into the code block. If you want this a bullet item, you need to add a blank line after the closing } and remove the leading whitespace.","commit_id":"954b94a5191e2cd9a139c7630c7c13348f95101c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"76fad4b65e65b14253122ea28b2a8e015500a599","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other end user impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"It will add a new column of ``backup_id`` to the ``volumes`` table,"},{"line_number":96,"context_line":"so if the user wants to use this feature, they should upgrade"},{"line_number":97,"context_line":"firstly, otherwise, the request will be rejected."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_446d3fc9","line":97,"range":{"start_line":95,"start_character":0,"end_line":97,"end_character":49},"updated":"2020-01-06 14:36:16.000000000","message":"We don\u0027t really need to say someone needs to upgrade to get a new feature. That\u0027s just kind of how things work. No need to call that out.","commit_id":"954b94a5191e2cd9a139c7630c7c13348f95101c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ed7944340289dae65c508cfaab6827822f5b635a","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Other end user impact"},{"line_number":94,"context_line":"---------------------"},{"line_number":95,"context_line":"It will add a new column of ``backup_id`` to the ``volumes`` table,"},{"line_number":96,"context_line":"so if the user wants to use this feature, they should upgrade"},{"line_number":97,"context_line":"firstly, otherwise, the request will be rejected."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Performance Impact"},{"line_number":100,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3fa7e38b_f14c2141","line":97,"range":{"start_line":95,"start_character":0,"end_line":97,"end_character":49},"in_reply_to":"3fa7e38b_446d3fc9","updated":"2020-01-07 01:38:37.000000000","message":"Yeah, Sean. I think make a declare is good (At least to a new user). Maybe add \u0027None.\u0027, and then said *that* is better. Anyway, I\u0027m ok.","commit_id":"954b94a5191e2cd9a139c7630c7c13348f95101c"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"66fa4f5247b04225d7103bcb6617922b50ac2e4b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  GET: /v3/{project_id}/volumes/detail"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  {"},{"line_number":62,"context_line":"    \"volumes\": [{"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_042cf947","line":59,"updated":"2020-01-09 01:15:02.000000000","message":"* List accessible volumes with details API:","commit_id":"2397a861b6b525c3c4c159a8ce73d03968ee0e28"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"66fa4f5247b04225d7103bcb6617922b50ac2e4b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  GET: /v3/{project_id}/volumes/{volume_id}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. code-block:: json"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  {"},{"line_number":78,"context_line":"    \"volumes\": {"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3fa7e38b_c4210151","line":75,"updated":"2020-01-09 01:15:02.000000000","message":"* Show a volume\u0027s details API:","commit_id":"2397a861b6b525c3c4c159a8ce73d03968ee0e28"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"fbb131df464e575725c400e38df915e4ab1e30eb","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"REST API impact"},{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":"This will be add a new microversion."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"URL: /v3/{project_id}/volumes/detail"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_bb735bb3","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":36},"updated":"2020-01-16 07:13:26.000000000","message":"Remove this, as talked on IRC meeting, while add backup_id in the volume\u0027s metadata, we donot need to add a microversion, there is not a API will be changed.\n\nIf the GET response cannot return the metadata of the volume, or in the metadata dict, does not contain the backup_id, if so, you can push a new SPEC to implement that, and it\u0027s not contains in this spec. So you should check it after you completed this spec, or any way while you have time.","commit_id":"94f08e9d0b34640302ea62cedef07ddaab83806d"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"fbb131df464e575725c400e38df915e4ab1e30eb","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* Request method: GET (List accessible volumes with details)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Add the ``backup_id`` to metadata to the response body."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* List accessible volumes with details API:"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_bb811b4f","line":57,"range":{"start_line":57,"start_character":36,"end_line":57,"end_character":38},"updated":"2020-01-16 07:13:26.000000000","message":"in","commit_id":"94f08e9d0b34640302ea62cedef07ddaab83806d"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"fbb131df464e575725c400e38df915e4ab1e30eb","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Request method: GET (Show a volume\u0027s details)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  Add the ``backup_id`` to metadata to the response body."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* Show a volume\u0027s details API:"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3fa7e38b_9b7e9f6b","line":76,"range":{"start_line":76,"start_character":36,"end_line":76,"end_character":38},"updated":"2020-01-16 07:13:26.000000000","message":"in","commit_id":"94f08e9d0b34640302ea62cedef07ddaab83806d"}],"specs/ussuri/add_backup_id_to_volume.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Currently, the end user can see the source (source by snapshot or image etc.)"},{"line_number":16,"context_line":"from the new volume created. But when the end user was"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source, this will cause a lot of"},{"line_number":19,"context_line":"confusion for end users."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_445b4af8","line":16,"range":{"start_line":16,"start_character":51,"end_line":16,"end_character":54},"updated":"2020-01-17 23:00:55.000000000","message":"has","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Currently, the end user can see the source (source by snapshot or image etc.)"},{"line_number":16,"context_line":"from the new volume created. But when the end user was"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source, this will cause a lot of"},{"line_number":19,"context_line":"confusion for end users."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_645e86e9","line":18,"range":{"start_line":18,"start_character":31,"end_line":18,"end_character":35},"updated":"2020-01-17 23:00:55.000000000","message":"can","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add a new propertity ``backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add ``backup_id`` properties to the List accessible volumes"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_44002ab2","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":22},"updated":"2020-01-17 23:00:55.000000000","message":"the property\n\n(The reason why I want you to avoid saying that it\u0027s a \"new\" property is that it\u0027s not really a new volume property, it\u0027s just a piece of volume metadata.  Maybe what I say below will make this more clear.)","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"* Add a new propertity ``backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Add ``backup_id`` properties to the List accessible volumes"},{"line_number":32,"context_line":"  with details API in ``metadata``."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* Add ``backup_id`` properties to the Show a volume\u0027s details API"},{"line_number":35,"context_line":"  in ``metadata``."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Vendor-specific changes"},{"line_number":38,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_c4cada6d","line":35,"range":{"start_line":31,"start_character":0,"end_line":35,"end_character":18},"updated":"2020-01-17 23:00:55.000000000","message":"Instead of these, you can say:\n\nOnce added to the volume metadata, the ``backup_id`` will appear on any API response that displays volume metadata:\n\n* the volume-show response (GET /v3/{project_id}/volumes/{volume_id})\n* the volume-list-detail response  (GET /v3/{project_id}/volumes/detail)\n* the volume-metadata-show response (GET /v3/{project_id}/volumes/{volume_id}/metadata)\n* the volume-metadata-show-key response (GET/v3/{project_id}/volumes/{volume_id}/metadata/{key})","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"REST API impact"},{"line_number":50,"context_line":"---------------"},{"line_number":51,"context_line":"URL: /v3/{project_id}/volumes/detail"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* Request method: GET (List accessible volumes with details)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  Add the ``backup_id`` to metadata in the response body."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* List accessible volumes with details API:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  .. code-block:: json"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    {"},{"line_number":62,"context_line":"      \"volumes\": [{"},{"line_number":63,"context_line":"        ..."},{"line_number":64,"context_line":"        \"metadata\": {"},{"line_number":65,"context_line":"          \"backup_id\":\"cb49b381-9012-40cb-b8ee-80c19a4801b5\""},{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":"      }]"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"URL: GET: /v3/{project_id}/volumes/{volume_id}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* Request method: GET (Show a volume\u0027s details)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  Add the ``backup_id`` to metadata in the response body."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Show a volume\u0027s details API:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  .. code-block:: json"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    {"},{"line_number":81,"context_line":"      \"volume\": {"},{"line_number":82,"context_line":"          ..."},{"line_number":83,"context_line":"          \"metadata\": {"},{"line_number":84,"context_line":"            \"backup_id\":\"cb49b381-9012-40cb-b8ee-80c19a4801b5\""},{"line_number":85,"context_line":"          }"},{"line_number":86,"context_line":"      }"},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Security impact"},{"line_number":90,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_8499427b","line":87,"range":{"start_line":51,"start_character":0,"end_line":87,"end_character":5},"updated":"2020-01-17 23:00:55.000000000","message":"Instead, you can say:\n\nNone.  The volume-show, volume-list-detail, and volume-metadata-show responses are currently defined to contain a ``metadata`` element that is either JSON null or a JSON object consisting of a list of key/value pairs.  The ``backup_id`` will appear in this list for appropriate volumes, but this respects the current API and does not require a new microversion.\n\nThe same holds for the other volume metadata calls.","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edbd8d9bccf1d43dfd5e0241ba28e4a73f6c40e6","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Work Items"},{"line_number":120,"context_line":"----------"},{"line_number":121,"context_line":"* Add ``backup_id`` to the ``volumes`` metadata"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Dependencies"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3fa7e38b_047f9217","line":121,"range":{"start_line":121,"start_character":35,"end_line":121,"end_character":36},"updated":"2020-01-17 23:00:55.000000000","message":"volume (singular)","commit_id":"1f6b68076423210756c068b0ecdceee0db5ed3c2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99a07d9b834bb4652e275b90a9b9e26595ad0275","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the propertity ``backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Once added to the volume metadata, the ``backup_id`` will appear on"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_2bd04f52","line":28,"range":{"start_line":28,"start_character":10,"end_line":28,"end_character":20},"updated":"2020-01-20 12:58:02.000000000","message":"property","commit_id":"c57f4eff4da59348ac543ca299029cae357ddc8e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99a07d9b834bb4652e275b90a9b9e26595ad0275","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Once added to the volume metadata, the ``backup_id`` will appear on"},{"line_number":32,"context_line":"any API response that displays volume metadata:"},{"line_number":33,"context_line":"* the volume-show response (GET /v3/{project_id}/volumes/{volume_id})"},{"line_number":34,"context_line":"* the volume-list-detail response (GET /v3/{project_id}/volumes/detail)"},{"line_number":35,"context_line":"* the volume-metadata-show response"},{"line_number":36,"context_line":"(GET /v3/{project_id}/volumes/{volume_id}/metadata)"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_6bb5e718","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":69},"updated":"2020-01-20 12:58:02.000000000","message":"You need a blank line before line 33 or sphinx won\u0027t recognize this as a list.","commit_id":"c57f4eff4da59348ac543ca299029cae357ddc8e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99a07d9b834bb4652e275b90a9b9e26595ad0275","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* the volume-show response (GET /v3/{project_id}/volumes/{volume_id})"},{"line_number":34,"context_line":"* the volume-list-detail response (GET /v3/{project_id}/volumes/detail)"},{"line_number":35,"context_line":"* the volume-metadata-show response"},{"line_number":36,"context_line":"(GET /v3/{project_id}/volumes/{volume_id}/metadata)"},{"line_number":37,"context_line":"* the volume-metadata-show-key response"},{"line_number":38,"context_line":"(GET /v3/{project_id}/volumes/{volume_id}/metadata/{key})"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_2b35afa7","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":51},"updated":"2020-01-20 12:58:02.000000000","message":"I think this will have to be indented two spaces (to begin under the \u0027t\u0027 in the line above), or sphinx won\u0027t know that this is a continuation of the list item.","commit_id":"c57f4eff4da59348ac543ca299029cae357ddc8e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99a07d9b834bb4652e275b90a9b9e26595ad0275","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* the volume-metadata-show response"},{"line_number":36,"context_line":"(GET /v3/{project_id}/volumes/{volume_id}/metadata)"},{"line_number":37,"context_line":"* the volume-metadata-show-key response"},{"line_number":38,"context_line":"(GET /v3/{project_id}/volumes/{volume_id}/metadata/{key})"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Vendor-specific changes"},{"line_number":41,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_eb3eb788","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":57},"updated":"2020-01-20 12:58:02.000000000","message":"same here","commit_id":"c57f4eff4da59348ac543ca299029cae357ddc8e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"99a07d9b834bb4652e275b90a9b9e26595ad0275","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"REST API impact"},{"line_number":53,"context_line":"---------------"},{"line_number":54,"context_line":"None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3fa7e38b_cb097bdc","line":54,"updated":"2020-01-20 12:58:02.000000000","message":"I think it would be a good idea to explain why there\u0027s no API impact.  (See my comment here on PS 13.)  In particular, you want to state explicitly that no new microversion is needed.","commit_id":"c57f4eff4da59348ac543ca299029cae357ddc8e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"bf7c365e2c2f59de9f6ebb84668cf1c3eb98fbf5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Currently, the end user can see the source (source by snapshot or image etc.)"},{"line_number":16,"context_line":"from the new volume created. But when the end user has"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source, this can cause a lot of"},{"line_number":19,"context_line":"confusion for end users."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_ef96a3ee","line":18,"range":{"start_line":18,"start_character":24,"end_line":18,"end_character":30},"updated":"2020-01-22 00:50:11.000000000","message":". This","commit_id":"6e79ad7b8523ce2f5c8d0261a57498051a172516"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"798bd62ee3c18cba6f91b34aa8d7715d107e3156","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the property ``backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Once added to the volume metadata, the ``backup_id`` will appear on"},{"line_number":32,"context_line":"any API response that displays volume metadata:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_17a8e988","line":29,"updated":"2020-01-22 15:26:37.000000000","message":"This should describe the behavior when a backup is restored over an existing volume -- presumably backup_id gets updated to a new value?\n\nPresumably when restoring from a chain of incremental backups, backup_id is set to the last incremental backup used for the restore?","commit_id":"6e79ad7b8523ce2f5c8d0261a57498051a172516"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"798bd62ee3c18cba6f91b34aa8d7715d107e3156","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Documentation Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"References"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_b79eb552","line":110,"updated":"2020-01-22 15:26:37.000000000","message":"Should document that since users will be able to arbitrarily set this metadata field to whatever they want, it can\u0027t be relied on for programmatically analyzing where volumes came from etc. for admin/auditing purposes.","commit_id":"6e79ad7b8523ce2f5c8d0261a57498051a172516"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d3d9d429c5a89847cd82f0df9d55af41c966373d","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Documentation Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"References"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3fa7e38b_9775b9cb","line":110,"in_reply_to":"3fa7e38b_b79eb552","updated":"2020-01-22 15:46:45.000000000","message":"This is a good point.  End users can do whatever they like with this field, which is fine for the use case stated in this spec, but doesn\u0027t extend to any kind of auditing use case.","commit_id":"6e79ad7b8523ce2f5c8d0261a57498051a172516"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f8ea9147b1d40d62d129731dd92e5da1186dea24","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Documentation Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"References"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3fa7e38b_e173b6e3","line":110,"updated":"2020-01-29 12:58:48.000000000","message":"Let\u0027s put something here so we don\u0027t forget.\n\n* Release note should point out that since this is stored in the volume metadata, it can be modified or removed by end users, so operators should not rely upon it being present for administrative or auditing purposes.\n\n* Add a similar note somewhere in the admin docs, probably a page about volume metadata written by Cinder (which may not currently exist).  In addition to reminding admins that end users can overwrite volume metadata, should explain how to read the \u0027src_backup_id\u0027 (particularly the part you mention on line 30 about what id is used when restoring from incremental backups).","commit_id":"8e5cfb0363a81fa8ca7fc6e622b666059a214310"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"056297cbc8aae0ceb182dbf4002a36dd8a6bb4e0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"page about volume metadata written by Cinder (which may not"},{"line_number":117,"context_line":"currently exist). In addition to reminding admins that end users can overwrite"},{"line_number":118,"context_line":"volume metadata, should explain how to read the \u0027src_backup_id\u0027(particularly"},{"line_number":119,"context_line":"the part you mention on line 30 about what id is used when restoring from"},{"line_number":120,"context_line":"incremental backups)."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3fa7e38b_0c9f2951","line":119,"range":{"start_line":119,"start_character":9,"end_line":119,"end_character":31},"updated":"2020-01-29 13:25:13.000000000","message":"nit: delete this phrase!","commit_id":"649804778eaded41b19d2344abf5b6ada5ce8b50"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Currently, the end user can see the source (source by snapshot or image etc.)"},{"line_number":16,"context_line":"from the new volume created. But when the end user has"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source. This can cause a lot of"},{"line_number":19,"context_line":"confusion for end users."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_1a550220","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":50},"updated":"2020-01-30 17:44:54.000000000","message":"volume show response or volume json response\nnot sure if it really matters","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6db8cda8dcbe6a28953203d1b7d7405696157364","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Currently, the end user can see the source (source by snapshot or image etc.)"},{"line_number":16,"context_line":"from the new volume created. But when the end user has"},{"line_number":17,"context_line":"restored a backup volume, in the volume\u0027s response,"},{"line_number":18,"context_line":"we cannot see its source. This can cause a lot of"},{"line_number":19,"context_line":"confusion for end users."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_ca26b5cd","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":50},"in_reply_to":"3fa7e38b_1a550220","updated":"2020-01-31 02:31:54.000000000","message":"Done","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"As an end user, I would like to know the restored volume comes"},{"line_number":24,"context_line":"from which backup file."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_7a2996a0","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":22},"updated":"2020-01-30 17:44:54.000000000","message":"we consider backup as a resource, is file the right word here?","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6db8cda8dcbe6a28953203d1b7d7405696157364","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Use Cases"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"As an end user, I would like to know the restored volume comes"},{"line_number":24,"context_line":"from which backup file."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_8a12fd63","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":22},"in_reply_to":"3fa7e38b_7a2996a0","updated":"2020-01-31 02:31:54.000000000","message":"Done. Usually we call it like this, \"resource\" sounds more appropriate than \"file\".","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the property ``src_backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":"  When restoring from a chain of incremental backups, src_backup_id"},{"line_number":31,"context_line":"  is set to the last incremental backup used for the restore."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_5a385aec","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":17},"updated":"2020-01-30 17:44:54.000000000","message":"from which backup","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6db8cda8dcbe6a28953203d1b7d7405696157364","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the property ``src_backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":"  When restoring from a chain of incremental backups, src_backup_id"},{"line_number":31,"context_line":"  is set to the last incremental backup used for the restore."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_aa17b953","line":29,"range":{"start_line":29,"start_character":12,"end_line":29,"end_character":17},"in_reply_to":"3fa7e38b_5a385aec","updated":"2020-01-31 02:31:54.000000000","message":"Done","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the property ``src_backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":"  When restoring from a chain of incremental backups, src_backup_id"},{"line_number":31,"context_line":"  is set to the last incremental backup used for the restore."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Once added to the volume metadata, the ``src_backup_id`` will appear on"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_ba262ecc","line":30,"range":{"start_line":30,"start_character":54,"end_line":30,"end_character":67},"updated":"2020-01-30 17:44:54.000000000","message":"``src_backup_id``","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6db8cda8dcbe6a28953203d1b7d7405696157364","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"* Add the property ``src_backup_id`` to the volume\u0027s metadata,"},{"line_number":29,"context_line":"  to record where the new volume was created from."},{"line_number":30,"context_line":"  When restoring from a chain of incremental backups, src_backup_id"},{"line_number":31,"context_line":"  is set to the last incremental backup used for the restore."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Once added to the volume metadata, the ``src_backup_id`` will appear on"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_0a060d24","line":30,"range":{"start_line":30,"start_character":54,"end_line":30,"end_character":67},"in_reply_to":"3fa7e38b_ba262ecc","updated":"2020-01-31 02:31:54.000000000","message":"Done","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* the volume-list-detail response (GET /v3/{project_id}/volumes/detail)"},{"line_number":38,"context_line":"* the volume-metadata-show response"},{"line_number":39,"context_line":"  (GET /v3/{project_id}/volumes/{volume_id}/metadata)"},{"line_number":40,"context_line":"* the volume-metadata-show-key response"},{"line_number":41,"context_line":"  (GET /v3/{project_id}/volumes/{volume_id}/metadata/{key})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Vendor-specific changes"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_d53f3bb0","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":39},"updated":"2020-01-30 17:44:54.000000000","message":"only if the key is ``src_backup_id``","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6db8cda8dcbe6a28953203d1b7d7405696157364","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* the volume-list-detail response (GET /v3/{project_id}/volumes/detail)"},{"line_number":38,"context_line":"* the volume-metadata-show response"},{"line_number":39,"context_line":"  (GET /v3/{project_id}/volumes/{volume_id}/metadata)"},{"line_number":40,"context_line":"* the volume-metadata-show-key response"},{"line_number":41,"context_line":"  (GET /v3/{project_id}/volumes/{volume_id}/metadata/{key})"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Vendor-specific changes"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_c5146645","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":39},"in_reply_to":"3fa7e38b_d53f3bb0","updated":"2020-01-31 02:31:54.000000000","message":"Done","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eab7f9c7d9fbd89250c8771d6d959842212ba430","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Documentation Impact"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":110,"context_line":"Release note should point out that since this is stored in"},{"line_number":111,"context_line":"the volume metadata, it can be modified or removed by end"},{"line_number":112,"context_line":"users, so operators should not rely upon it being present"},{"line_number":113,"context_line":"for administrative or auditing purposes."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Add a similar note somewhere in the admin docs, probably a"},{"line_number":116,"context_line":"page about volume metadata written by Cinder (which may not"},{"line_number":117,"context_line":"currently exist). In addition to reminding admins that end users can overwrite"},{"line_number":118,"context_line":"volume metadata, should explain how to read the \u0027src_backup_id\u0027(particularly"},{"line_number":119,"context_line":"the part about what id is used when restoring from incremental backups)."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"References"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3fa7e38b_550cabea","line":119,"range":{"start_line":110,"start_character":0,"end_line":119,"end_character":72},"updated":"2020-01-30 17:44:54.000000000","message":"don\u0027t we want to make it protected in any way so the information remains original and authentic or we don\u0027t mind users modifying it to which this limits the use case to end users only and not admins (which is mentioned here).","commit_id":"0275b38aa48f7583498dc0f1e6e9430e5fd87081"}]}