)]}'
{"id":"openstack%2Fcinder-specs~726307","triplet_id":"openstack%2Fcinder-specs~master~I866bf7af44f975842271fdd70e19102c16f8f671","project":"openstack/cinder-specs","branch":"master","topic":"bp/support-modern-compression-algorithms-in-cinder-backup","hashtags":[],"change_id":"I866bf7af44f975842271fdd70e19102c16f8f671","subject":"Support modern compression algorithms in cinder backup","status":"MERGED","created":"2020-05-08 08:20:39.000000000","updated":"2020-07-15 22:52:45.000000000","submitted":"2020-07-15 22:50:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"726307-1594853443777-bfbdc47d","meta_rev_id":"a02f84518bdb923fec45d4396d29d96f4bc80484","_number":726307,"virtual_id_number":726307,"owner":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-15 22:50:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2020-07-15 14:17:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2020-07-15 22:39:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2020-07-14 01:28:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},{"value":1,"date":"2020-07-15 15:40:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-07-15 22:39:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},{"value":0,"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-18 13:12:27.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2020-07-14 01:28:29.000000000","updated_by":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"reviewer":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"state":"REVIEWER"},{"updated":"2020-07-15 14:17:27.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-07-15 15:40:41.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-07-15 22:39:32.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-07-15 22:50:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d1494709b5b3f3cf740d496978c96dc4d8ac79a0","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-05-08 08:20:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"08a9bda108d323a2f428ef17fe2c2ca5477ef18f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-08 08:27:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/49d72383f0174df5b8df8cf55785e825 : FAILURE in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e66f9417e3114f2b9206cd5a1970afa3 : FAILURE in 4m 17s","accounts_in_message":[],"_revision_number":1},{"id":"9f00edf7e31ad6a45deaec165d28c4e8ec790644","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-05-08 08:27:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"025ef542df23d79ced5d280046dba4e6694ff753","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-08 08:36:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6db43e2ca4d245109cdf849006cd3f28 : FAILURE in 3m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e6a65d8318f443ffb70a787a388403c8 : SUCCESS in 5m 19s","accounts_in_message":[],"_revision_number":2},{"id":"3a6f9c9667989fe613fca148ea334d87af944fc6","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-05-12 07:41:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e4ecd0ea5fe2b24bb41a1bfed8c350cb090f504f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-12 07:48:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/50bad2c7753b4a1fb115d775115c87a2 : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b13922a1c53e4cb39de176ddc6dab462 : SUCCESS in 4m 40s","accounts_in_message":[],"_revision_number":3},{"id":"1ed8727c643d9e3c96b8f8df040be830581c5e97","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2020-05-18 13:12:27.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f3cfcc790970c00c3886b0c9b960f4f4da4d8ef6","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-05-18 15:09:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3fb983effbd4a6fa5ad0bcc13436b4c19a8f18fa","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-06-29 16:07:09.000000000","message":"Patch Set 3: Code-Review-1\n\nSorry this has been sitting so long.\n\nI agree with you that our compression algo support could use an update.\n\nI agree with Eric that unless there are sufficient differences in the algos for the backup use case, we should just pick one.  (FWIW, I personally like zstandard, but that\u0027s just one opinion.)\n\nAs far as which algorithm ... the wildcard here is that we need to get the algo into global-requirements, which means that the requirements team gets a say.  So  you need to answer the questions on [0], which may help you determine what\u0027s the best algorithm from an openstack point of view.  (We didn\u0027t have to do this for zlib or bz2 because they\u0027re in the python standard library.)\n\nAs far as timing goes ... I\u0027m willing to grant a spec-freeze-exception for this one, because I think everyone will agree that we could use an update, it\u0027s just a matter of figuring out which algo.  Plus, the code change should be fairly straightforward.\n\n[0] https://docs.openstack.org/project-team-guide/dependency-management.html#for-new-requirements","accounts_in_message":[],"_revision_number":3},{"id":"7d27c8cac7b1c0139262ca0f273dcaecf22ddc1d","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2020-07-01 15:13:06.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"1f135619b6253fe00e4fa0cb5bcc5b1ce80875f2","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-01 16:03:08.000000000","message":"Patch Set 3:\n\nAs indicated in my earlier comment, and as discussed at today\u0027s Cinder meeting, this spec has a spec-freeze exception until 1600 UTC on 10 July.  Ideally, you\u0027ll have your revisions completed before next week\u0027s Cinder meeting on 8 July so we can discuss any issues at the meeting and give you time in case you need to make a final revision.\n\nThe revision we\u0027re requesting is for you to make a case for one of these algorithms using the criteria from [0].  (I think zstandard looks better overall, but I don\u0027t know if it meets all requirements or not.)\n\n[0] https://docs.openstack.org/project-team-guide/dependency-management.html#for-new-requirements","accounts_in_message":[],"_revision_number":3},{"id":"a446bf6184984d1fa2d54d3ae8a1bfc56cabbca0","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-04 12:05:04.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nHere\u0027s a note for library selection. (Sorry for long text..)\n\nThere\u0027s two major python binding for zstd (listed on [zstandard page](https://facebook.github.io/zstd/)), and I choosed python-zstd.\n\n- [python-ztandard](https://github.com/indygreg/python-zstandard)\n  - Library with rich interface to the underlying C API.\n  - The usage is different from zlib and bzip library. (Requires to instantiate compressor class, and decompressor class is separate from compressor class. This means we have to change more code if we choose this.)\n  - This library is [not thread-safe](https://python-zstandard.readthedocs.io/en/latest/api_usage.html#thread-safety).\n  - [The document](https://python-zstandard.readthedocs.io/en/latest/projectinfo.html#state-of-project) says it\u0027s in beta state, and there\u0027ll be some backwards incompatible chages befor 1.0 release.\n- [python-zstd](https://github.com/sergey-dryabzhinsky/python-zstd)\n  - Exposes only simple API for zstandard.\n  - Similar usage with zlib or bzip2.\n  - Has enough functionarity for cinder backup (compression, decompression).\n\nAnd for global-requirements,\n\n- Is the library actively maintained?\n  - The library follows release of zstandard, and updated periodically.\n  - Just fyi, zstandard itself is now facebook\u0027s project.\n- Is the library good code?\n  - It\u0027s relatively small and simple code, and tests included in the repository.\n- Is the library python 3 compatible?\n  - Yes. Both python3 and python2 are listed on pypi page.\n- Is the library license compatible?\n  - Yes. It\u0027s licensed with BSD-2-Clause License.\n- Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)?\n  - Unfortunately, currently ubuntu and fedora does not have the package of python bindings for zstd.\n  - It\u0027s available on pip.\n  - It\u0027ll be added as an optional algorithm in cinder backup and it\u0027s not used unless the user enabled it.\n- Is the function of this library already covered by other libraries in global-requirements.txt?\n  - No. Zstd support is not covered for now.\n- Is the library required for OpenStack project or related dev or infrastructure setup? (Answer to this should be Yes, of course) Which?\n  - Yes. It\u0027s required by [this blueprint](https://blueprints.launchpad.net/cinder/+spec/support-modern-compression-algorithms-in-cinder-backup).\n- If the library release is managed by the Openstack release process does it use the cycle-with-intermediary release type?\n  - The library release is not managed by openstck release process.","accounts_in_message":[],"_revision_number":3},{"id":"c7afd301989c3d31aefb6e77fc46fb1243cc033c","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-06 13:56:05.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"daae481b1044a4e7abc8c3393d7376e28bb1e836","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-06 14:02:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec9a33f54e37456fb5d37736cbc6511b : SUCCESS in 5m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/327f323c9fd447268b4cec1cf291c734 : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":4},{"id":"014c323284f01fb8d6be4e68805e742208c39fea","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-06 14:04:11.000000000","message":"Patch Set 4:\n\nThanks for commenting on this spec.\nMulti-thread compression/decompression support is added in zstd python module (version 1.4.4.1),\nso I measured the performance for each algorithm again and updated the table.\n\nBackup time was 251.0 sec on old single-thread module, but 196.2 sec on newer multi-thread module.\n(restore time was changed from 102.6 sec to 100.2 sec, small change.)\n\n(I have to say sorry that I\u0027ve mistaken the value of gzip\u0027s restore time. It was 144 sec, not 1440 sec.)\n\nAnd for CPU/Memory usage, I made charts and uploaded to imgur for now.\n(Please tell me if there\u0027s better place to put.) \n\nhttps://imgur.com/a/JFNRDTM\n\n(I tested 4 times, and each line shows cpu/mem usage for each backup/restore.)","accounts_in_message":[],"_revision_number":4},{"id":"77a4930af15b2286fd7dfbf0bebd1d40c3de1247","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-07 16:42:25.000000000","message":"Patch Set 4: Code-Review+2\n\n(3 comments)\n\nI think this is in good shape.\n\nA few minor comments inline.\n\nIt\u0027s too bad that python-zstd isn\u0027t packaged in distros yet, but it shouldn\u0027t be a problem.  As you point out, it will be optional and the default for the option is zlib.","accounts_in_message":[],"_revision_number":4},{"id":"c67d98b4b2f3e0d4570ea1c4dacef7bf4f1e62a8","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-09 12:30:11.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c66eb28695ae9fb139378504fdd63c7ed73f3b32","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-10 08:43:50.000000000","message":"Patch Set 4:\n\nHello, Could you someone take a look on this spec before the SPEC FREEZE?\nThanks in advance.","accounts_in_message":[],"_revision_number":4},{"id":"61c32287f7346ae2ed19f1aa65186bc95625e424","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-10 10:02:06.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"47d15c523785f4fa2e4c8b2e4c7409026ff632f0","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2020-07-13 09:20:15.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9ea2a27833a158eba7d7de36946ad33782860200","author":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"date":"2020-07-14 00:59:14.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fb5e6dd69d708a4e231e5f305565af007d3c34fb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 01:08:27.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f628d4c1c0774e67b5df425ec63d2074 : SUCCESS in 4m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/716cc8dd1c3945f1b7ba73f1716f5d84 : SUCCESS in 6m 06s","accounts_in_message":[],"_revision_number":5},{"id":"fda2a5a5f09982386f7ee6cb0900b4402cc8afab","author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"date":"2020-07-14 01:28:29.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"22477eea54052f0a27f8311cbe4926a40b16cdfa","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-15 13:59:56.000000000","message":"Patch Set 5:\n\nhttps://review.opendev.org/#/c/740259/ has been approved","accounts_in_message":[],"_revision_number":5},{"id":"de0fd69f192e8f45f9fcfc3a0af6173e0629e7fb","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-07-15 14:16:55.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"ae01954e952758161811c09b38fa7a6b2430b4bb","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-07-15 14:17:27.000000000","message":"Patch Set 5: Code-Review+2\n\nIssues noted can be done in a follow up.","accounts_in_message":[],"_revision_number":5},{"id":"747c775f827f1032fb4813e350c27cc4f967bffc","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-15 15:40:41.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"39f66392c51514766e6483bd282f46cbc4b38e73","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-15 22:39:32.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nI agree with Sean that we need to mention about backups not being restorable on older cinders.  Definitely in the release note accompanying the feature, and maybe as a patch to this spec just to get maximum visibility.\n\nI see that you\u0027ve already included the doc change on https://review.opendev.org/#/c/726765/ , so you probably don\u0027t need to mention it here.","accounts_in_message":[],"_revision_number":5},{"id":"fcb358c3e599c0e721b74ca459e0f0ef0dc2506b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 22:39:43.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"44edea4a392ceec0423002e712f19aac697bd76d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 22:50:43.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/89606d278b35464e8ab4170a5a63b9bd : SUCCESS in 4m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c8b238bd93d142848f60bd2046ae9e2b : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":5},{"id":"8e113fc590b00ef4c1c85a8b5ea1f2fd8f60dfb9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 22:50:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"9845e35811d49139169fe8aebda887c0c02834b1","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 22:52:45.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-specs https://zuul.opendev.org/t/openstack/build/5fa500ba7dd04d0ebd23e1495fc05365 : SUCCESS in 1m 40s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"035034fffc817c01eb57804567824e9ee4642d02","revisions":{"766a136013dda4a3600aaf3119f07d0ddbe96124":{"kind":"REWORK","_number":1,"created":"2020-05-08 08:20:39.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/07/726307/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/07/726307/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/1"}}},"commit":{"parents":[{"commit":"44988971ef8734e29aff51b788ed3ebad773582f","subject":"Cleanup py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/44988971ef8734e29aff51b788ed3ebad773582f"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 07:51:05.000000000","tz":540},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 08:15:34.000000000","tz":540},"subject":"Support modern compression algorithms in cinder backup","message":"Support modern compression algorithms in cinder backup\n\nChange-Id: I866bf7af44f975842271fdd70e19102c16f8f671\nImplements: blueprint support-modern-compression-algorithms-in-cinder-backup\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/766a136013dda4a3600aaf3119f07d0ddbe96124"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/766a136013dda4a3600aaf3119f07d0ddbe96124"}]},"branch":"refs/heads/master"},"964fcfdec6000db755ab4487d240e0f23df95726":{"kind":"REWORK","_number":2,"created":"2020-05-08 08:27:42.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/07/726307/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/07/726307/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/2"}}},"commit":{"parents":[{"commit":"44988971ef8734e29aff51b788ed3ebad773582f","subject":"Cleanup py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/44988971ef8734e29aff51b788ed3ebad773582f"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 07:51:05.000000000","tz":540},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 08:26:57.000000000","tz":540},"subject":"Support modern compression algorithms in cinder backup","message":"Support modern compression algorithms in cinder backup\n\nChange-Id: I866bf7af44f975842271fdd70e19102c16f8f671\nImplements: blueprint support-modern-compression-algorithms-in-cinder-backup\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/964fcfdec6000db755ab4487d240e0f23df95726"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/964fcfdec6000db755ab4487d240e0f23df95726"}]},"branch":"refs/heads/master"},"84ac1d3ba34a905497d34ea6d197e2fbab5c67eb":{"kind":"REWORK","_number":3,"created":"2020-05-12 07:41:43.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/07/726307/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/07/726307/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/3"}}},"commit":{"parents":[{"commit":"44988971ef8734e29aff51b788ed3ebad773582f","subject":"Cleanup py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/44988971ef8734e29aff51b788ed3ebad773582f"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 07:51:05.000000000","tz":540},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-12 07:41:00.000000000","tz":540},"subject":"Support modern compression algorithms in cinder backup","message":"Support modern compression algorithms in cinder backup\n\nChange-Id: I866bf7af44f975842271fdd70e19102c16f8f671\nImplements: blueprint support-modern-compression-algorithms-in-cinder-backup\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/84ac1d3ba34a905497d34ea6d197e2fbab5c67eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/84ac1d3ba34a905497d34ea6d197e2fbab5c67eb"}]},"branch":"refs/heads/master"},"6b0ddae39b184ea0d6e5a4119bf0f09c587685df":{"kind":"REWORK","_number":4,"created":"2020-07-06 13:56:05.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/07/726307/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/07/726307/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/4"}}},"commit":{"parents":[{"commit":"44988971ef8734e29aff51b788ed3ebad773582f","subject":"Cleanup py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/44988971ef8734e29aff51b788ed3ebad773582f"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 07:51:05.000000000","tz":540},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-07-06 13:54:18.000000000","tz":540},"subject":"Support modern compression algorithms in cinder backup","message":"Support modern compression algorithms in cinder backup\n\nChange-Id: I866bf7af44f975842271fdd70e19102c16f8f671\nImplements: blueprint support-modern-compression-algorithms-in-cinder-backup\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/6b0ddae39b184ea0d6e5a4119bf0f09c587685df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/6b0ddae39b184ea0d6e5a4119bf0f09c587685df"}]},"branch":"refs/heads/master"},"035034fffc817c01eb57804567824e9ee4642d02":{"kind":"REWORK","_number":5,"created":"2020-07-14 00:59:14.000000000","uploader":{"_account_id":25397,"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","username":"notok"},"ref":"refs/changes/07/726307/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-specs","ref":"refs/changes/07/726307/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-specs refs/changes/07/726307/5"}}},"commit":{"parents":[{"commit":"44988971ef8734e29aff51b788ed3ebad773582f","subject":"Cleanup py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/44988971ef8734e29aff51b788ed3ebad773582f"}]}],"author":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-05-08 07:51:05.000000000","tz":540},"committer":{"name":"Kazufumi Noto","email":"noto.kazufumi@gmail.com","date":"2020-07-14 00:56:37.000000000","tz":540},"subject":"Support modern compression algorithms in cinder backup","message":"Support modern compression algorithms in cinder backup\n\nChange-Id: I866bf7af44f975842271fdd70e19102c16f8f671\nImplements: blueprint support-modern-compression-algorithms-in-cinder-backup\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/035034fffc817c01eb57804567824e9ee4642d02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-specs/commit/035034fffc817c01eb57804567824e9ee4642d02"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}