)]}'
{"specs/wallaby/sizing-encrypted-volumes.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08fc2b53736009adc27e31f2ac9caf4c772422c2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"volume. This happens because an encrypted volume must have a header, which"},{"line_number":19,"context_line":"takes up some space."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In fact, the exact amount of space lost isn\u0027t clear, it may vary by luks (rbd)"},{"line_number":22,"context_line":"format and also iscsi (cryptsetup). It\u0027s probably on the order of 1-2 MB, but"},{"line_number":23,"context_line":"we allocate space in GB. Whether you can do really fine-grained space"},{"line_number":24,"context_line":"allocation or not probably depends on the backend containing the volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_eb9e70b6","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":51},"updated":"2020-11-04 19:36:46.000000000","message":"FWIW we\u0027ve got some basic logic in Nova that can help you work this out:\n\nhttps://github.com/openstack/nova/blob/edd8fefe3f6cb99bc244ffde0b83517456982356/nova/virt/libvirt/driver.py#L2064-L2088","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08fc2b53736009adc27e31f2ac9caf4c772422c2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"volume. This happens because an encrypted volume must have a header, which"},{"line_number":19,"context_line":"takes up some space."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In fact, the exact amount of space lost isn\u0027t clear, it may vary by luks (rbd)"},{"line_number":22,"context_line":"format and also iscsi (cryptsetup). It\u0027s probably on the order of 1-2 MB, but"},{"line_number":23,"context_line":"we allocate space in GB. Whether you can do really fine-grained space"},{"line_number":24,"context_line":"allocation or not probably depends on the backend containing the volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_eb2b107f","line":21,"range":{"start_line":21,"start_character":73,"end_line":21,"end_character":78},"updated":"2020-11-04 19:36:46.000000000","message":"LUKS isn\u0027t specific to RBD.","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"22e6950dfc1e3ce22aa6aae5fc2f2afed5c50372","unresolved":true,"context_lines":[{"line_number":18,"context_line":"volume. This happens because an encrypted volume must have a header, which"},{"line_number":19,"context_line":"takes up some space."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In fact, the exact amount of space lost isn\u0027t clear, it may vary by luks (rbd)"},{"line_number":22,"context_line":"format and also iscsi (cryptsetup). It\u0027s probably on the order of 1-2 MB, but"},{"line_number":23,"context_line":"we allocate space in GB. Whether you can do really fine-grained space"},{"line_number":24,"context_line":"allocation or not probably depends on the backend containing the volume."}],"source_content_type":"text/x-rst","patch_set":4,"id":"c0a035cb_a4aa7b84","line":21,"range":{"start_line":21,"start_character":8,"end_line":21,"end_character":51},"in_reply_to":"1f621f24_eb9e70b6","updated":"2020-11-25 02:26:07.000000000","message":"Thanks Lee, let me try it and update with the space.","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"08fc2b53736009adc27e31f2ac9caf4c772422c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"takes up some space."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"In fact, the exact amount of space lost isn\u0027t clear, it may vary by luks (rbd)"},{"line_number":22,"context_line":"format and also iscsi (cryptsetup). It\u0027s probably on the order of 1-2 MB, but"},{"line_number":23,"context_line":"we allocate space in GB. Whether you can do really fine-grained space"},{"line_number":24,"context_line":"allocation or not probably depends on the backend containing the volume."},{"line_number":25,"context_line":"However, we also need to keep the gigabyte boundaries for accounting purposes"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_eb50300d","line":22,"range":{"start_line":22,"start_character":23,"end_line":22,"end_character":33},"updated":"2020-11-04 19:36:46.000000000","message":"Again, cryptsetup isn\u0027t specific to iSCSI.\n\nJust refer to LUKSv1/LUKSv2 and PLAIN dm-crypt formats.","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8f7e9e9957a487dc918aec5caf91ba5cacd35c6f","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    Optional Arguments:"},{"line_number":67,"context_line":"    --migration-size \u003cnever|on-demand\u003e"},{"line_number":68,"context_line":"    \tIncreased volume size during migration. This argument"},{"line_number":69,"context_line":"        is recommended when retyping to an encryption type."},{"line_number":70,"context_line":"    ..."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_dff74ed4","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":5},"updated":"2020-10-28 15:34:05.000000000","message":"Tab needs to be changed to spaces.","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f9dc1486a01293e836c3cd73f9af1a7a44a26f8e","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Documentation Impact"},{"line_number":169,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Currently I’ve added some documentation notes warning about retyping an"},{"line_number":172,"context_line":"unencrypted/encrypted volume. However, these notes should be replaced with"},{"line_number":173,"context_line":"proper documentation."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f621f24_7fe1dafe","line":170,"updated":"2020-10-28 15:37:58.000000000","message":"We also need some explicit doc notes explaining how this works i guess.","commit_id":"7dbdf2384258d93e57351b74f0dd00c39370a6d6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":55,"context_line":"* RPC minor version for a new param"},{"line_number":56,"context_line":"  3.x - Add migration_size to retype method and new_size to migrate method."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate"},{"line_number":59,"context_line":"  commands:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - Retype: New flag \u0027--migration-size\u0027 indicating that it\u0027s OK for the volume"},{"line_number":62,"context_line":"    to be increased in size if it\u0027s required for the retype to succeed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ed8a5963_d04cdb12","line":59,"range":{"start_line":58,"start_character":2,"end_line":59,"end_character":10},"updated":"2020-12-10 21:16:27.000000000","message":"This is secondary to the REST API changes.  You should describe those first.  Something like:\n\n* Add a new optional field, \"allow_resize\", to the os-retype action.  Possible values will be \"on-demand\" or \"never\" (which are the same as the current \"migration_policy\" field).  If not specified, the default is \"never\" (unless new_size is specified).\n\n* Add a new optional field, \"new_size\", to the os-migrate action.  It takes a positive integer argument, the new size of the volume in GB.  This takes precedence over any value specified for \"allow_resize\".\n\nOn that note, I imagine that we only want to allow the new size to be larger (or you risk data loss).  Maybe the way this should work is to call the field \"increase_size\" and it takes a positive integer value which is the number of GB by which the volume will be increased in size?  Either way works for me as long as it\u0027s clear that you can\u0027t make a volume smaller with this new functionality.","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c4d590343a408236a0f65ec8d8e06c265e7e1379","unresolved":true,"context_lines":[{"line_number":55,"context_line":"* RPC minor version for a new param"},{"line_number":56,"context_line":"  3.x - Add migration_size to retype method and new_size to migrate method."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate"},{"line_number":59,"context_line":"  commands:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - Retype: New flag \u0027--migration-size\u0027 indicating that it\u0027s OK for the volume"},{"line_number":62,"context_line":"    to be increased in size if it\u0027s required for the retype to succeed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"6261a25b_48c5a1fa","line":59,"range":{"start_line":58,"start_character":2,"end_line":59,"end_character":10},"in_reply_to":"ed8a5963_d04cdb12","updated":"2020-12-14 21:26:58.000000000","message":"The  bullet points above should be:\n\n* Add a new optional field, \"allow_resize\", to the os-retype action.  Possible values will be \"on-demand\" or \"never\" (which are the same as the current \"migration_policy\" field).  If not specified, the default is \"never\".\n\n* Add a new optional field, \"new_size\", to the os-migrate action.  It takes a positive integer argument, the new size of the volume in GB.\n\n(I was in a hurry when I wrote them and forgot that allow_resize and new_size are defined for completely different actions, and they can\u0027t possibly be specified at the same time.  I still think increase_size might be a good idea, though.)","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":58,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate"},{"line_number":59,"context_line":"  commands:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - Retype: New flag \u0027--migration-size\u0027 indicating that it\u0027s OK for the volume"},{"line_number":62,"context_line":"    to be increased in size if it\u0027s required for the retype to succeed."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"section::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"99fc5475_b70384d8","line":61,"range":{"start_line":61,"start_character":21,"end_line":61,"end_character":39},"updated":"2020-12-10 21:16:27.000000000","message":"Maybe name this \u0027--allow-resize\u0027?  (Just needs to be consistent with what you use in the REST API.)","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":76,"context_line":"section::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    Optional Arguments:"},{"line_number":79,"context_line":"     --new-size [\u003csize\u003e]   New size of volume, in GiBs. This is recommended when"},{"line_number":80,"context_line":"                           migrating to an encrypted host."},{"line_number":81,"context_line":"    ..."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5cbed8b0_3ce2b044","line":79,"range":{"start_line":79,"start_character":5,"end_line":79,"end_character":15},"updated":"2020-12-10 21:16:27.000000000","message":"(Don\u0027t forget to change this if you decide to go the \"increase_size\" route above.)","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Leave everything as it is and don’t allow this kind of migration. To help users"},{"line_number":90,"context_line":"add some workaround to the documentation (i.e. backup the volume and then restore"},{"line_number":91,"context_line":"the volume to a bigger one)."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Data model impact"},{"line_number":94,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"349b751c_9dae8adf","line":91,"updated":"2020-12-10 21:16:27.000000000","message":"You might as well remind the reader that you already explained why you rejected allowing \u003c1GB size increases in the problem description, above.","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":99,"context_line":"---------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"New parameters should be passed to retype and migrate commands as explained in the"},{"line_number":102,"context_line":"‘proposed change’ section."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6b1212d3_4c819c1f","line":102,"updated":"2020-12-10 21:16:27.000000000","message":"It think it will also require a microversion bump.","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8117c20a0c3c34fa472be707ebdff860bbded97f","unresolved":true,"context_lines":[{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"* https://etherpad.opendev.org/p/sizing-encrypted-volumes"},{"line_number":184,"context_line":"* Victoria Mid Cycle"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"wiki.openstack.org/wiki/CinderVictoriaMidCycleSummary#Sizing_encrypted_volumes_.28continued.29"},{"line_number":187,"context_line":"* Victoria PTG https://wiki.openstack.org/wiki/CinderVictoriaPTGSummary#Sizing_encrypted_volumes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4f2b0180_cecc55ce","line":186,"range":{"start_line":184,"start_character":2,"end_line":186,"end_character":94},"updated":"2020-12-10 21:16:27.000000000","message":"this should probably all be on one line","commit_id":"bf4870b896acab85214c3d7e08a0707fd61d39f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"430fd87f5703eff0f5a5da297baf8ba868ad2c10","unresolved":true,"context_lines":[{"line_number":59,"context_line":"  values will be \"on-demand\" or \"never\" (which are the same as the current"},{"line_number":60,"context_line":"  \"migration_policy\" field).  If not specified, the default is \"never\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Add a new optional field, \"increase_size\", to the os-migrate action. It takes a"},{"line_number":63,"context_line":"  positive integer argument, the new size of the volume in GB."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"section::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"395c3f5b_88da1a94","line":63,"range":{"start_line":62,"start_character":71,"end_line":63,"end_character":62},"updated":"2020-12-15 14:22:37.000000000","message":"There are two ways to go on this:\n\n- new_size - the operator specifies the new size in GB for the volume; request will be rejected if new_size \u003c current size\n\n- increase_size - the operator specifies how many GB to grow the volume (so the final size is current size + increase_size)\n\nWhat I\u0027m getting at is if you think it\u0027s better to ask the operator to specify the final size up front, \u0027new_size\u0027 is a better name.  If you want the value to be an increment, then \u0027increase_size\u0027 is a better name.  What you have now is a mix of the two; I\u0027d like you to pick the one you think best.","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b2dd8b609df01f0a9fa5dd63d0baac77c81c9cf6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  values will be \"on-demand\" or \"never\" (which are the same as the current"},{"line_number":60,"context_line":"  \"migration_policy\" field).  If not specified, the default is \"never\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Add a new optional field, \"increase_size\", to the os-migrate action. It takes a"},{"line_number":63,"context_line":"  positive integer argument, the new size of the volume in GB."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"section::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"c1c41c55_d543e867","line":63,"range":{"start_line":62,"start_character":71,"end_line":63,"end_character":62},"in_reply_to":"395c3f5b_88da1a94","updated":"2020-12-15 16:11:12.000000000","message":"I\u0027m going with the second option: \u0027increase_size - the operator specifies how many GB to grow the volume (so the final size is current size + increase_size)\u0027. Thanks Brian for the clarification, I got confused.","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"430fd87f5703eff0f5a5da297baf8ba868ad2c10","unresolved":true,"context_lines":[{"line_number":62,"context_line":"* Add a new optional field, \"increase_size\", to the os-migrate action. It takes a"},{"line_number":63,"context_line":"  positive integer argument, the new size of the volume in GB."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"section::"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Optional Arguments:"},{"line_number":68,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3839e3c3_27481da2","line":65,"updated":"2020-12-15 14:22:37.000000000","message":"Before this section, you need to add back:\n\n  * Add the next parameters to Python-cinderclient for retype and migrate\n    commands:","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b2dd8b609df01f0a9fa5dd63d0baac77c81c9cf6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"* Add a new optional field, \"increase_size\", to the os-migrate action. It takes a"},{"line_number":63,"context_line":"  positive integer argument, the new size of the volume in GB."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"section::"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Optional Arguments:"},{"line_number":68,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"57cfc888_3322f769","line":65,"in_reply_to":"3839e3c3_27481da2","updated":"2020-12-15 16:11:12.000000000","message":"Ack","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"430fd87f5703eff0f5a5da297baf8ba868ad2c10","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Optional Arguments:"},{"line_number":68,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"},{"line_number":69,"context_line":"        Increased volume size during migration. This argument"},{"line_number":70,"context_line":"        is recommended when retyping to an encryption type."},{"line_number":71,"context_line":"    ..."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ec31b12f_1171ac80","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":46},"updated":"2020-12-15 14:22:37.000000000","message":"Maybe: Allow the volume to be increased in size during the retype if the system decides it is necessary.","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b2dd8b609df01f0a9fa5dd63d0baac77c81c9cf6","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Optional Arguments:"},{"line_number":68,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"},{"line_number":69,"context_line":"        Increased volume size during migration. This argument"},{"line_number":70,"context_line":"        is recommended when retyping to an encryption type."},{"line_number":71,"context_line":"    ..."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"e134b6f8_758ef6af","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":46},"in_reply_to":"ec31b12f_1171ac80","updated":"2020-12-15 16:11:12.000000000","message":"Ack","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"430fd87f5703eff0f5a5da297baf8ba868ad2c10","unresolved":true,"context_lines":[{"line_number":108,"context_line":"Security impact"},{"line_number":109,"context_line":"---------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Notifications impact"},{"line_number":114,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3d65d8bd_13464a5f","line":111,"updated":"2020-12-15 14:22:37.000000000","message":"You don\u0027t have to include this in the spec, I just thought I\u0027d ask.  I don\u0027t think we need any new policies for this change?  If you\u0027re allowed to migrate at all, you should be able to increase the size, and if you\u0027re allowed to retype, you should be able to allow_resize.  That makes sense to me.","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b2dd8b609df01f0a9fa5dd63d0baac77c81c9cf6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Security impact"},{"line_number":109,"context_line":"---------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Notifications impact"},{"line_number":114,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"029bcb31_8267ecd9","line":111,"in_reply_to":"3d65d8bd_13464a5f","updated":"2020-12-15 16:11:12.000000000","message":"Exactly as you say.","commit_id":"f59e2f5d4669b96e7c2c5f1af3475ea66e3def53"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22ed76f6e96a1ae2421fc193a3041c9606ced7d2","unresolved":true,"context_lines":[{"line_number":64,"context_line":"  size + increase_size)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate commands:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"section::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    Optional Arguments:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"811298b2_497ff23b","line":67,"updated":"2020-12-15 16:59:30.000000000","message":"You need to add back this part from an earlier patch set:\n\n  - Retype: New flag \u0027--allow-resize\u0027 indicating that it\u0027s OK for the volume\n    to be increased in size if it\u0027s required for the retype to succeed.","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a5fd4c6b3b98aee53a2175980744f93ac009cb83","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  size + increase_size)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate commands:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"section::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    Optional Arguments:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"530bd16b_72ed9519","line":67,"in_reply_to":"811298b2_497ff23b","updated":"2020-12-17 15:31:44.000000000","message":"Ack","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22ed76f6e96a1ae2421fc193a3041c9606ced7d2","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    Optional Arguments:"},{"line_number":71,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"},{"line_number":72,"context_line":"      Allow the volume to be increased in size during the retype if the system"},{"line_number":73,"context_line":"      decides it is necessary.. This argument is recommended when retyping to"},{"line_number":74,"context_line":"      an encryption type."},{"line_number":75,"context_line":"    ..."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"a242f921_e1a69fd0","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":31},"updated":"2020-12-15 16:59:30.000000000","message":"nit: duplicate period","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a5fd4c6b3b98aee53a2175980744f93ac009cb83","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    Optional Arguments:"},{"line_number":71,"context_line":"    --allow_resize \u003cnever|on-demand\u003e"},{"line_number":72,"context_line":"      Allow the volume to be increased in size during the retype if the system"},{"line_number":73,"context_line":"      decides it is necessary.. This argument is recommended when retyping to"},{"line_number":74,"context_line":"      an encryption type."},{"line_number":75,"context_line":"    ..."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d44a56c9_f16c9ee8","line":73,"range":{"start_line":73,"start_character":29,"end_line":73,"end_character":31},"in_reply_to":"a242f921_e1a69fd0","updated":"2020-12-17 15:31:44.000000000","message":"Ack","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"22ed76f6e96a1ae2421fc193a3041c9606ced7d2","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  - Migration: allow a new size to be specified during a volume migration. New"},{"line_number":79,"context_line":"    optional argument added \u0027--allow_resize\u0027."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"section::"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"45a7fbb6_c14be0d4","line":79,"range":{"start_line":79,"start_character":31,"end_line":79,"end_character":43},"updated":"2020-12-15 16:59:30.000000000","message":"I think this should be \u0027increase_size\u0027?\n\n(Also, I think in the cinderclient, the parameter names usually have dashes instead of underscores, so these should be \u0027--allow-resize\u0027 and \u0027--increase-size\u0027 in lines 66-86.  We usually use underscores in the names of JSON fields in volume actions, so the underscore is correct in lines 58-64.)","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"733a90c7890382cd0f76d015979e8b8f880c8a24","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  - Migration: allow a new size to be specified during a volume migration. New"},{"line_number":79,"context_line":"    optional argument added \u0027--allow_resize\u0027."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"section::"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"547e4ca8_1093aea8","line":79,"range":{"start_line":79,"start_character":31,"end_line":79,"end_character":43},"in_reply_to":"45a7fbb6_c14be0d4","updated":"2020-12-15 17:17:00.000000000","message":"\u003e We usually use underscores in the names of JSON fields in volume actions, so the underscore is correct in lines 58-64.)","commit_id":"230aafbd2e048b1c0fc2382be9eff43973df8eeb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"733a90c7890382cd0f76d015979e8b8f880c8a24","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  devices (i.e LVM will still use the actual _migrate_volume_generic). This method"},{"line_number":53,"context_line":"  will be called after _before_volume_copy during volume migration."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* RPC minor version for a new param"},{"line_number":56,"context_line":"  3.x - Add allow-resize to retype method and increase-size to migrate method."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Add a new optional field, \"allow-resize\", to the os-retype action. Possible"},{"line_number":59,"context_line":"  values will be \"on-demand\" or \"never\" (which are the same as the current"},{"line_number":60,"context_line":"  \"migration_policy\" field).  If not specified, the default is \"never\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Add a new optional field, \"increase-size\", to the os-migrate action. The"},{"line_number":63,"context_line":"  operator specifies how many GB to grow the volume (so the final size is current"},{"line_number":64,"context_line":"  size + increase-size)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate commands:"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5c6d96e3_11e5207e","line":64,"range":{"start_line":55,"start_character":0,"end_line":64,"end_character":24},"updated":"2020-12-15 17:17:00.000000000","message":"The underscores were correct here.  (It\u0027s the cinderclient CLI where you need to use the dashes.)","commit_id":"88c1b3d27f519a49c2fd88fbf695a9bd5829a2b9"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a5fd4c6b3b98aee53a2175980744f93ac009cb83","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  devices (i.e LVM will still use the actual _migrate_volume_generic). This method"},{"line_number":53,"context_line":"  will be called after _before_volume_copy during volume migration."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"* RPC minor version for a new param"},{"line_number":56,"context_line":"  3.x - Add allow-resize to retype method and increase-size to migrate method."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"* Add a new optional field, \"allow-resize\", to the os-retype action. Possible"},{"line_number":59,"context_line":"  values will be \"on-demand\" or \"never\" (which are the same as the current"},{"line_number":60,"context_line":"  \"migration_policy\" field).  If not specified, the default is \"never\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"* Add a new optional field, \"increase-size\", to the os-migrate action. The"},{"line_number":63,"context_line":"  operator specifies how many GB to grow the volume (so the final size is current"},{"line_number":64,"context_line":"  size + increase-size)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate commands:"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fea23ad_fb9f4ba9","line":64,"range":{"start_line":55,"start_character":0,"end_line":64,"end_character":24},"in_reply_to":"5c6d96e3_11e5207e","updated":"2020-12-17 15:31:44.000000000","message":"Ack","commit_id":"88c1b3d27f519a49c2fd88fbf695a9bd5829a2b9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab26932b516cf0992bcff40cff8763a020400ba7","unresolved":true,"context_lines":[{"line_number":63,"context_line":"  operator specifies how many GB to grow the volume (so the final size is current"},{"line_number":64,"context_line":"  size + increase_size)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Add the next parameters to Python-cinderclient for retype and migrate commands:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  - Retype: New flag \u0027--allow-resize\u0027 indicating that it\u0027s OK for the volume to be"},{"line_number":69,"context_line":"    increased in size if it\u0027s required for the retype to succeed."}],"source_content_type":"text/x-rst","patch_set":10,"id":"2abfb1e1_2e63436f","line":66,"updated":"2020-12-15 20:07:31.000000000","message":"Nit: the section from lines 66-89 doesn\u0027t display properly in HTML.  If you have to put up a new patch set, you can use http://paste.openstack.org/show/801069/ as a model (it was easier to copy \u0026 paste than try to explain what the problem is).","commit_id":"d598bb14e84c51f95ff74c0203208f6b6c42aa5d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3901534b5d0683dfa0e870dab307aa055ce6318","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    .. code-block:: bash"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"     Optional Arguments:"},{"line_number":86,"context_line":"     --increase-size [\u003csize\u003e] New size of volume, in GiBs. This is recommended"},{"line_number":87,"context_line":"                              when migrating to an encrypted host."},{"line_number":88,"context_line":"     ..."},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"49fb14a2_d3c62c59","line":86,"range":{"start_line":86,"start_character":30,"end_line":86,"end_character":58},"updated":"2020-12-16 19:41:04.000000000","message":"Number of GiBs to grow the volume during migration.","commit_id":"e2b971c1f14fd8b1d137417d263f8e249ba5bd7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b7e760c9744c93b4ba327d3080ca4b72ef95a0b7","unresolved":true,"context_lines":[{"line_number":77,"context_line":"      an encryption type."},{"line_number":78,"context_line":"      ..."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - Migration: allow a new size to be specified during a volume migration. New"},{"line_number":81,"context_line":"    optional argument added ``--increase-size\u0027``"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    .. code-block:: bash"}],"source_content_type":"text/x-rst","patch_set":12,"id":"60665b4e_92795b42","line":80,"updated":"2023-10-26 14:40:28.000000000","message":"-1: Migration command cannot change encryption, because encryption is defined on the volume type, and migration doesn\u0027t change the type of the volume.","commit_id":"bcdb3efdcf0f0d66f93ef0c64c247c21033ea213"}]}