)]}'
{"specs/xena/temp-resources.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4463b998814ac714da8275c010bd626648e9ca5","unresolved":true,"context_lines":[{"line_number":34,"context_line":"delete them manually, which messes up the quota, since the REST API delete call"},{"line_number":35,"context_line":"doesn\u0027t know it shouldn\u0027t touch the quota."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When we say that we don\u0027t have a reliably way of tracking snapshots we refer to"},{"line_number":38,"context_line":"the fact that even though snapshots have a name that helps identify them, such"},{"line_number":39,"context_line":"as ``[revert] volume %s backup snapshot`` and ``backup-snap-%s``, these are"},{"line_number":40,"context_line":"also valid snapshot names that a user can assign, so we cannot rely on them to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"247d5637_3b3efbde","line":37,"range":{"start_line":37,"start_character":33,"end_line":37,"end_character":41},"updated":"2021-06-19 00:42:04.000000000","message":"reliable","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"556878cfcc38c6df6d0c207fb1ca038ac2bac1c5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"delete them manually, which messes up the quota, since the REST API delete call"},{"line_number":35,"context_line":"doesn\u0027t know it shouldn\u0027t touch the quota."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When we say that we don\u0027t have a reliably way of tracking snapshots we refer to"},{"line_number":38,"context_line":"the fact that even though snapshots have a name that helps identify them, such"},{"line_number":39,"context_line":"as ``[revert] volume %s backup snapshot`` and ``backup-snap-%s``, these are"},{"line_number":40,"context_line":"also valid snapshot names that a user can assign, so we cannot rely on them to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"82cc02b1_e74861f9","line":37,"range":{"start_line":37,"start_character":33,"end_line":37,"end_character":41},"in_reply_to":"247d5637_3b3efbde","updated":"2021-06-22 14:58:17.000000000","message":"Done","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4463b998814ac714da8275c010bd626648e9ca5","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When we say that we don\u0027t have a reliably way of tracking snapshots we refer to"},{"line_number":38,"context_line":"the fact that even though snapshots have a name that helps identify them, such"},{"line_number":39,"context_line":"as ``[revert] volume %s backup snapshot`` and ``backup-snap-%s``, these are"},{"line_number":40,"context_line":"also valid snapshot names that a user can assign, so we cannot rely on them to"},{"line_number":41,"context_line":"differentiate temporary snapshots."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a7e6d86_45b17aa2","line":40,"range":{"start_line":39,"start_character":66,"end_line":40,"end_character":48},"updated":"2021-06-19 00:42:04.000000000","message":"Yes, you are entirely correct that we don\u0027t have a reliable way to track snapshots!","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"556878cfcc38c6df6d0c207fb1ca038ac2bac1c5","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"When we say that we don\u0027t have a reliably way of tracking snapshots we refer to"},{"line_number":38,"context_line":"the fact that even though snapshots have a name that helps identify them, such"},{"line_number":39,"context_line":"as ``[revert] volume %s backup snapshot`` and ``backup-snap-%s``, these are"},{"line_number":40,"context_line":"also valid snapshot names that a user can assign, so we cannot rely on them to"},{"line_number":41,"context_line":"differentiate temporary snapshots."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5fd5fd51_4cddc79a","line":40,"range":{"start_line":39,"start_character":66,"end_line":40,"end_character":48},"in_reply_to":"5a7e6d86_45b17aa2","updated":"2021-06-22 14:58:17.000000000","message":"Done","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4463b998814ac714da8275c010bd626648e9ca5","unresolved":true,"context_lines":[{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"There won\u0027t be any new REST API endpoing since the ``use_quota`` field is an"},{"line_number":104,"context_line":"internal field and we don\u0027t want users or administrators modifying it."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"But since this is useful information we will add this field to the volume\u0027s"}],"source_content_type":"text/x-rst","patch_set":1,"id":"8869812a_5b48d33b","line":103,"range":{"start_line":103,"start_character":32,"end_line":103,"end_character":40},"updated":"2021-06-19 00:42:04.000000000","message":"endpoint","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"556878cfcc38c6df6d0c207fb1ca038ac2bac1c5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"REST API impact"},{"line_number":101,"context_line":"---------------"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"There won\u0027t be any new REST API endpoing since the ``use_quota`` field is an"},{"line_number":104,"context_line":"internal field and we don\u0027t want users or administrators modifying it."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"But since this is useful information we will add this field to the volume\u0027s"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2a57a5b8_90e0b4d0","line":103,"range":{"start_line":103,"start_character":32,"end_line":103,"end_character":40},"in_reply_to":"8869812a_5b48d33b","updated":"2021-06-22 14:58:17.000000000","message":"Done","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4463b998814ac714da8275c010bd626648e9ca5","unresolved":true,"context_lines":[{"line_number":104,"context_line":"internal field and we don\u0027t want users or administrators modifying it."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"But since this is useful information we will add this field to the volume\u0027s"},{"line_number":107,"context_line":"JSON response for all endpoints that return it:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Create volume"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"12748a4c_c674d6a9","line":107,"updated":"2021-06-19 00:42:04.000000000","message":"What are you thinking of displaying?  I guess\n\n  use_quota: true\n\nIn that case, the display name should probably be something like\n\n  consumes_quota: true\n\nBut I wonder whether it would be better for users to assume that all resources count toward quota unless the response specifically indicates otherwise.  In other words, maybe only display \"consumes_quota: false\" to mark temporary resources, and not include the field at all on regular resources.","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e686a65e6d42a4f9d1c8a016d27536770959fa98","unresolved":true,"context_lines":[{"line_number":104,"context_line":"internal field and we don\u0027t want users or administrators modifying it."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"But since this is useful information we will add this field to the volume\u0027s"},{"line_number":107,"context_line":"JSON response for all endpoints that return it:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Create volume"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8e25d64b_cc988fc4","line":107,"in_reply_to":"016d37f6_7d013217","updated":"2021-06-22 15:27:01.000000000","message":"If it helps in testing, I\u0027m all for it!","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"556878cfcc38c6df6d0c207fb1ca038ac2bac1c5","unresolved":true,"context_lines":[{"line_number":104,"context_line":"internal field and we don\u0027t want users or administrators modifying it."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"But since this is useful information we will add this field to the volume\u0027s"},{"line_number":107,"context_line":"JSON response for all endpoints that return it:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"* Create volume"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"016d37f6_7d013217","line":107,"in_reply_to":"12748a4c_c674d6a9","updated":"2021-06-22 14:58:17.000000000","message":"As you have guessed the current proposal shows \"Use Quota\" on the client [1] and returns \"use_quota\" on the server side [2].\n\nI like the idea of changing the return and shown names to \"consumes_quota\" and \"Consumes Quota\" respectively, but I don\u0027t like the idea of only returning the value some times and not others, regardless of the expected value.  Besides my preference for explicit vs implicit here, it also helps in testing to be sure that the microversion is actually working (if all consume quota, then the microversion won\u0027t have a difference in the returned data), and it also simplifies the client code, both for the cinderclient and any other user using the rest api.\n\n[1]: https://review.opendev.org/c/openstack/python-cinderclient/+/787407/2/cinderclient/v3/shell.py\n[2]: https://review.opendev.org/c/openstack/cinder/+/786386/7/cinder/api/v3/views/volumes.py","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4463b998814ac714da8275c010bd626648e9ca5","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Developers will have an easier time marking which resources will not consume"},{"line_number":167,"context_line":"quota and won\u0027t have to be careful how or when these temporary resources are"},{"line_number":168,"context_line":"deleted."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fd7e5012_b913523e","line":168,"updated":"2021-06-19 00:42:04.000000000","message":"Developers will need to pay attention to the paradigm shift in that resources now \"opt in\" to quotas, whereas before it was an \"opt out\" model.  (I completely agree with you that opt in is better and should lead to better accuracy.)","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e686a65e6d42a4f9d1c8a016d27536770959fa98","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Developers will have an easier time marking which resources will not consume"},{"line_number":167,"context_line":"quota and won\u0027t have to be careful how or when these temporary resources are"},{"line_number":168,"context_line":"deleted."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e9b35e6c_a5057195","line":168,"in_reply_to":"52c38112_b35bbfae","updated":"2021-06-22 15:27:01.000000000","message":"Ack","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"556878cfcc38c6df6d0c207fb1ca038ac2bac1c5","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Developers will have an easier time marking which resources will not consume"},{"line_number":167,"context_line":"quota and won\u0027t have to be careful how or when these temporary resources are"},{"line_number":168,"context_line":"deleted."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"52c38112_b35bbfae","line":168,"in_reply_to":"fd7e5012_b913523e","updated":"2021-06-22 14:58:17.000000000","message":"I\u0027ll try to rephrase it, since there is no paradigm shift.\nBy default if you create a new OVO it will consume quota, but if you explicitly say it shouldn\u0027t, then that\u0027s it.  You won\u0027t have to check multiple fields when deleting to see if quota should be removed, and code like the sync won\u0027t forget about those cases either, since seeing a \"use_quota\" field is quite eye catching and easy to understand and see.","commit_id":"7e6808d4ad43dc7754179e5299f897f98217ec04"}]}