)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f322fd4a_ae76bed3","updated":"2021-11-10 13:57:43.000000000","message":"As with the Nova spec I don\u0027t think you should be `git mv`ing the originally accepted spec around in the tree. Some additional comments and questions in-line.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"480dc13e_22e770e1","updated":"2021-11-11 08:30:19.000000000","message":"Hi Lee, Thanks for the review. In cinder, we move the approved spec (or at least that has been followed in the past). Maybe we can discuss on it with Brian.\n\nI\u0027ve left the comments regarding passing the connector unanswered as I would like to get confirmation that this is what nova intends to do (that opposes the agreement in PTG). I will add a point to nova weekly meeting and try to attend it (since it\u0027s a little late for my timezone IST) to discuss the same..","commit_id":"d419253217186676013b0efc39a1c321d2276f34"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b038680f_ebc95411","updated":"2021-12-07 17:41:55.000000000","message":"A few questions inline.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f39908b76b7da0a1ac71d2dc226a8faf92472ae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19f78b92_efd3d831","updated":"2021-11-19 09:05:08.000000000","message":"Marking comments as resolved.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95d07d57cc300b508f210317c20b3a69cb5fbb35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e243c85e_f430e5f3","updated":"2021-12-19 15:54:19.000000000","message":"Revisions LGTM.  Suggestion inline for the documentation, but nothing worth holding up this spec over.","commit_id":"a5e710f8ba6cddf21dbc535d84e2b5792ade236c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e6df56bf_df18dd93","updated":"2021-12-10 10:53:35.000000000","message":"Thanks for the review Brian. please find my replies inline.","commit_id":"a5e710f8ba6cddf21dbc535d84e2b5792ade236c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3204f15c8350c39bd67df521b4a8434e03d2b743","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eeded550_196831c2","updated":"2021-12-21 20:39:34.000000000","message":"This includes the items we have previously discussed.  Good to merge for Yoga specs.","commit_id":"a5e710f8ba6cddf21dbc535d84e2b5792ade236c"}],"specs/yoga/add-volume-re-image-api.rst":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":56,"context_line":"     server. This ensures the volume remains ``reserved`` through the next"},{"line_number":57,"context_line":"     step."},{"line_number":58,"context_line":"  #. Delete the existing volume attachment (the old one)."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API and pass connector information."},{"line_number":60,"context_line":"  #. Add a new \u0027volume-reimaged\u0027 external event to wait for cinder to"},{"line_number":61,"context_line":"     complete the reimage. Like we use for volume-extend."},{"line_number":62,"context_line":"     See `perform_resize_volume_online`_ for details."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8756ecb6_e9cceac1","line":59,"range":{"start_line":59,"start_character":41,"end_line":59,"end_character":68},"updated":"2021-11-10 13:57:43.000000000","message":"As below I\u0027d like to remove this.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f39908b76b7da0a1ac71d2dc226a8faf92472ae8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"     server. This ensures the volume remains ``reserved`` through the next"},{"line_number":57,"context_line":"     step."},{"line_number":58,"context_line":"  #. Delete the existing volume attachment (the old one)."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API and pass connector information."},{"line_number":60,"context_line":"  #. Add a new \u0027volume-reimaged\u0027 external event to wait for cinder to"},{"line_number":61,"context_line":"     complete the reimage. Like we use for volume-extend."},{"line_number":62,"context_line":"     See `perform_resize_volume_online`_ for details."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6fce55b0_ffd42e96","line":59,"range":{"start_line":59,"start_character":41,"end_line":59,"end_character":68},"in_reply_to":"06f8ae44_37af38e7","updated":"2021-11-19 09:05:08.000000000","message":"Done","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":true,"context_lines":[{"line_number":56,"context_line":"     server. This ensures the volume remains ``reserved`` through the next"},{"line_number":57,"context_line":"     step."},{"line_number":58,"context_line":"  #. Delete the existing volume attachment (the old one)."},{"line_number":59,"context_line":"  #. Call the new ``os-reimage`` API and pass connector information."},{"line_number":60,"context_line":"  #. Add a new \u0027volume-reimaged\u0027 external event to wait for cinder to"},{"line_number":61,"context_line":"     complete the reimage. Like we use for volume-extend."},{"line_number":62,"context_line":"     See `perform_resize_volume_online`_ for details."}],"source_content_type":"text/x-rst","patch_set":3,"id":"06f8ae44_37af38e7","line":59,"range":{"start_line":59,"start_character":41,"end_line":59,"end_character":68},"in_reply_to":"8756ecb6_e9cceac1","updated":"2021-11-11 08:30:19.000000000","message":"I would again like to discuss this with the team since this was agreed upon during the PTG.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":60,"context_line":"  #. Add a new \u0027volume-reimaged\u0027 external event to wait for cinder to"},{"line_number":61,"context_line":"     complete the reimage. Like we use for volume-extend."},{"line_number":62,"context_line":"     See `perform_resize_volume_online`_ for details."},{"line_number":63,"context_line":"  #. After successful completion of the re-image operation, update the empty"},{"line_number":64,"context_line":"     volume attchment in Cinder with the connector info passed during re-image"},{"line_number":65,"context_line":"     call and return connection info to Nova, then do the attachment on the"},{"line_number":66,"context_line":"     Nova host when spawning the (rebuilt) guest VM and \"complete\" the"},{"line_number":67,"context_line":"     attachment which will make the volume ``in-use`` again."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. _perform_resize_volume_online: https://review.opendev.org/c/openstack/nova/+/454322"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"34484bc8_f1356992","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":60},"updated":"2021-11-10 13:57:43.000000000","message":"As I\u0027ve called out in the Nova spec I don\u0027t think c-api/c-vol should do this automatically and instead just leave it up to n-cpu to update and complete the volume attachment as part of the rebuild flow.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f39908b76b7da0a1ac71d2dc226a8faf92472ae8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  #. Add a new \u0027volume-reimaged\u0027 external event to wait for cinder to"},{"line_number":61,"context_line":"     complete the reimage. Like we use for volume-extend."},{"line_number":62,"context_line":"     See `perform_resize_volume_online`_ for details."},{"line_number":63,"context_line":"  #. After successful completion of the re-image operation, update the empty"},{"line_number":64,"context_line":"     volume attchment in Cinder with the connector info passed during re-image"},{"line_number":65,"context_line":"     call and return connection info to Nova, then do the attachment on the"},{"line_number":66,"context_line":"     Nova host when spawning the (rebuilt) guest VM and \"complete\" the"},{"line_number":67,"context_line":"     attachment which will make the volume ``in-use`` again."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. _perform_resize_volume_online: https://review.opendev.org/c/openstack/nova/+/454322"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"4e26ab96_b8758559","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":60},"in_reply_to":"34484bc8_f1356992","updated":"2021-11-19 09:05:08.000000000","message":"Done","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":97,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":98,"context_line":"  have done when we create volume from image."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  After the re-image operation is complete, the volume will set back to"},{"line_number":101,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":102,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* If the re-image operation fails, we will set a user message to give hints to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"531f1b35_85408f78","line":101,"range":{"start_line":100,"start_character":2,"end_line":101,"end_character":16},"updated":"2021-11-10 13:57:43.000000000","message":"I don\u0027t seem to see where you\u0027ve called out a new state while the volume is being reimaged above?","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":true,"context_lines":[{"line_number":97,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":98,"context_line":"  have done when we create volume from image."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  After the re-image operation is complete, the volume will set back to"},{"line_number":101,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":102,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* If the re-image operation fails, we will set a user message to give hints to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f224c2dd_6c32bfa5","line":101,"range":{"start_line":100,"start_character":2,"end_line":101,"end_character":16},"in_reply_to":"531f1b35_85408f78","updated":"2021-11-11 08:30:19.000000000","message":"This follows the same flow as of creating a new bootable volume so the states would be same as of that operation i.e. reserved -\u003e downloading","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af73474aee398bd75d52bb89fc8a2f10f0bd9d8a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  will call driver\u0027s \u0027copy_image_to_encrypted_volume\u0027. It\u0027s similar to what we"},{"line_number":98,"context_line":"  have done when we create volume from image."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"  After the re-image operation is complete, the volume will set back to"},{"line_number":101,"context_line":"  original state, and all previously existing volume_glance_metadata of this"},{"line_number":102,"context_line":"  volume will be replaced with the metadata from new image."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"* If the re-image operation fails, we will set a user message to give hints to"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d1d979dd_7fde3dd3","line":101,"range":{"start_line":100,"start_character":2,"end_line":101,"end_character":16},"in_reply_to":"f224c2dd_6c32bfa5","updated":"2021-11-17 11:24:10.000000000","message":"Ack","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"There are also some other optimized mechanisms that should be considered to"},{"line_number":109,"context_line":"support in future, but will not be implemented in this spec:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":112,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":113,"context_line":"  a host to support copy image to volume. And also re-image an ``in-use``"},{"line_number":114,"context_line":"  volume is a very dangerous operation, we must make sure there is no IO,"},{"line_number":115,"context_line":"  onging or cached on VMs before we complete re-imaging, otherwise will damage"},{"line_number":116,"context_line":"  the volume data. We will not support this operation in this spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports creating"},{"line_number":119,"context_line":"  a volume from image cache, which can improve the performance of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"630f37a6_bf517f82","line":116,"range":{"start_line":110,"start_character":0,"end_line":116,"end_character":67},"updated":"2021-11-10 13:57:43.000000000","message":"Yeah there\u0027s lots of issues and pitfalls here that I don\u0027t think we need to go anywhere near.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"There are also some other optimized mechanisms that should be considered to"},{"line_number":109,"context_line":"support in future, but will not be implemented in this spec:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":112,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":113,"context_line":"  a host to support copy image to volume. And also re-image an ``in-use``"},{"line_number":114,"context_line":"  volume is a very dangerous operation, we must make sure there is no IO,"},{"line_number":115,"context_line":"  onging or cached on VMs before we complete re-imaging, otherwise will damage"},{"line_number":116,"context_line":"  the volume data. We will not support this operation in this spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports creating"},{"line_number":119,"context_line":"  a volume from image cache, which can improve the performance of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b31265f9_574eeb58","line":116,"range":{"start_line":110,"start_character":0,"end_line":116,"end_character":67},"in_reply_to":"630f37a6_bf517f82","updated":"2021-11-11 08:30:19.000000000","message":"+1","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af73474aee398bd75d52bb89fc8a2f10f0bd9d8a","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"There are also some other optimized mechanisms that should be considered to"},{"line_number":109,"context_line":"support in future, but will not be implemented in this spec:"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* Re-image an ``in-use`` volume. If we want to support it, we should make"},{"line_number":112,"context_line":"  sure this volume can be multi-attached, so that we can attach this volume to"},{"line_number":113,"context_line":"  a host to support copy image to volume. And also re-image an ``in-use``"},{"line_number":114,"context_line":"  volume is a very dangerous operation, we must make sure there is no IO,"},{"line_number":115,"context_line":"  onging or cached on VMs before we complete re-imaging, otherwise will damage"},{"line_number":116,"context_line":"  the volume data. We will not support this operation in this spec."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"* Re-image a volume from image cache. Currently, Cinder supports creating"},{"line_number":119,"context_line":"  a volume from image cache, which can improve the performance of"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8ebfdde8_64d44922","line":116,"range":{"start_line":110,"start_character":0,"end_line":116,"end_character":67},"in_reply_to":"b31265f9_574eeb58","updated":"2021-11-17 11:24:10.000000000","message":"Ack","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  POST /v3/{project_id}/volumes/{volume_id}/action"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":".. code-block:: python"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  {"},{"line_number":155,"context_line":"      \u0027os-reimage\u0027: {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"89a86a72_aa942536","line":152,"range":{"start_line":152,"start_character":16,"end_line":152,"end_character":22},"updated":"2021-11-10 13:57:43.000000000","message":"json","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  POST /v3/{project_id}/volumes/{volume_id}/action"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":".. code-block:: python"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  {"},{"line_number":155,"context_line":"      \u0027os-reimage\u0027: {"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d0586b5c_9eb53ab5","line":152,"range":{"start_line":152,"start_character":16,"end_line":152,"end_character":22},"in_reply_to":"89a86a72_aa942536","updated":"2021-11-11 08:30:19.000000000","message":"Done","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":".. code-block:: python"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  {"},{"line_number":155,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":156,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":157,"context_line":"          \u0027ignore_reserved\u0027: false"},{"line_number":158,"context_line":"      }"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":162,"context_line":"    No default value since this is a required parameter."}],"source_content_type":"text/x-rst","patch_set":3,"id":"de871782_dfd8e2b8","line":159,"range":{"start_line":154,"start_character":0,"end_line":159,"end_character":3},"updated":"2021-11-10 13:57:43.000000000","message":"I obviously don\u0027t want this but you\u0027ve missed the connector out from the request.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f39908b76b7da0a1ac71d2dc226a8faf92472ae8","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":".. code-block:: python"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  {"},{"line_number":155,"context_line":"      \u0027os-reimage\u0027: {"},{"line_number":156,"context_line":"          \u0027image_id\u0027: \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":157,"context_line":"          \u0027ignore_reserved\u0027: false"},{"line_number":158,"context_line":"      }"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  * The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":162,"context_line":"    No default value since this is a required parameter."}],"source_content_type":"text/x-rst","patch_set":3,"id":"83470392_1763233b","line":159,"range":{"start_line":154,"start_character":0,"end_line":159,"end_character":3},"in_reply_to":"de871782_dfd8e2b8","updated":"2021-11-19 09:05:08.000000000","message":"Done","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":247,"context_line":"Other end user impact"},{"line_number":248,"context_line":"---------------------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e [--ignore-reserved]``,"},{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"103a4475_e620c8a5","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":9},"updated":"2021-11-10 13:57:43.000000000","message":"Is python-cinderclient still supported? Could you just rewrite this to target osc?","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":true,"context_lines":[{"line_number":247,"context_line":"Other end user impact"},{"line_number":248,"context_line":"---------------------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e [--ignore-reserved]``,"},{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff07afb4_20229fc3","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":9},"in_reply_to":"103a4475_e620c8a5","updated":"2021-11-11 08:30:19.000000000","message":"yes, it\u0027s supported. Because of lack of microversion support in OSC (for cinder), we add new feature commands in python-cinderclient only.","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af73474aee398bd75d52bb89fc8a2f10f0bd9d8a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"Other end user impact"},{"line_number":248,"context_line":"---------------------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"A new command, ``cinder reimage \u003cvolume_id\u003e \u003cimage_id\u003e [--ignore-reserved]``,"},{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."}],"source_content_type":"text/x-rst","patch_set":3,"id":"36ff72ad_e28d5ba0","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":9},"in_reply_to":"ff07afb4_20229fc3","updated":"2021-11-17 11:24:10.000000000","message":"Ack","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0dec2f5bb58e4f1c2ac524abee3ae3de75804924","unresolved":true,"context_lines":[{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Performance Impact"},{"line_number":258,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"13ffda5e_df5ae283","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":75},"updated":"2021-11-10 13:57:43.000000000","message":"As above I don\u0027t see a new interim  `reimaging` state called out above for the volume?","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df9064f1fc48024ac282fe7a3f8c6a3a924a651","unresolved":true,"context_lines":[{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Performance Impact"},{"line_number":258,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ae0b048_d70685c3","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":75},"in_reply_to":"13ffda5e_df5ae283","updated":"2021-11-11 08:30:19.000000000","message":"Replied on L#101","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af73474aee398bd75d52bb89fc8a2f10f0bd9d8a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"will be added to python-cinderclient. This command mirrors the underlying API"},{"line_number":252,"context_line":"function."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"Callers of the new API will need to poll the status of the volume until it"},{"line_number":255,"context_line":"goes back to its original status or ``error`` in case the operation failed."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Performance Impact"},{"line_number":258,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9d5e81ee_7169b88f","line":255,"range":{"start_line":254,"start_character":0,"end_line":255,"end_character":75},"in_reply_to":"7ae0b048_d70685c3","updated":"2021-11-17 11:24:10.000000000","message":"Ack","commit_id":"0d0321da0f6987b63941fb0d7e421f63dc4ec95e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Two separate policies will be introduced, one for re-imaging an ``available``"},{"line_number":84,"context_line":"or ``error`` volume and another for re-imaging an ``reserved`` volume, the"},{"line_number":85,"context_line":"default policies for these new actions are ``SYSTEM_ADMIN_OR_PROJECT_MEMBER``."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"If the image status is not ``active``, image size or image min_disk size is"},{"line_number":88,"context_line":"larger than volume size, will raise InvalidInput (400) error."}],"source_content_type":"text/x-rst","patch_set":6,"id":"e48e5cdc_8f44d69b","line":85,"updated":"2021-12-07 17:41:55.000000000","message":"Why two separate policies here?  And if re-imaging a \u0027reserved\u0027 volume is dangerous, why not make the default admin-only?","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95d07d57cc300b508f210317c20b3a69cb5fbb35","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Two separate policies will be introduced, one for re-imaging an ``available``"},{"line_number":84,"context_line":"or ``error`` volume and another for re-imaging an ``reserved`` volume, the"},{"line_number":85,"context_line":"default policies for these new actions are ``SYSTEM_ADMIN_OR_PROJECT_MEMBER``."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"If the image status is not ``active``, image size or image min_disk size is"},{"line_number":88,"context_line":"larger than volume size, will raise InvalidInput (400) error."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ee42669f_53a8d5e3","line":85,"in_reply_to":"dc8ea37e_62a50f88","updated":"2021-12-19 15:54:19.000000000","message":"Thanks for the explanation.  I did not read lines 54-73 closely enough.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Two separate policies will be introduced, one for re-imaging an ``available``"},{"line_number":84,"context_line":"or ``error`` volume and another for re-imaging an ``reserved`` volume, the"},{"line_number":85,"context_line":"default policies for these new actions are ``SYSTEM_ADMIN_OR_PROJECT_MEMBER``."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"If the image status is not ``active``, image size or image min_disk size is"},{"line_number":88,"context_line":"larger than volume size, will raise InvalidInput (400) error."}],"source_content_type":"text/x-rst","patch_set":6,"id":"dc8ea37e_62a50f88","line":85,"in_reply_to":"e48e5cdc_8f44d69b","updated":"2021-12-10 10:53:35.000000000","message":"I might not be very familiar with the original idea but my interpretation is there are 2 different ways this API could be invoked.\n1) via cinder: when the volume is in \u0027available\u0027 or \u0027error\u0027 state\n2) via nova: when the volume is in \u0027reserved\u0027 state\n\nSo 2 different policies governing different cases.\n\nRegarding the \u0027reserved\u0027 state, from nova\u0027s perspective, a normal user should be able to rebuild their instance and we\u0027re using the same personas here as done in nova i.e. PROJECT_MEMBER_OR_SYSTEM_ADMIN[1]. It\u0027s dangerous as it\u0027s wipes out all the data but that\u0027s the purpose of this operation and i think the user should be able to understand it before initiating the operation. On our part, we are going to document this.\n\n[1] https://github.com/openstack/nova/blob/master/nova/policies/servers.py#L392","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":160,"context_line":"    {"},{"line_number":161,"context_line":"        \"os-reimage\": {"},{"line_number":162,"context_line":"            \"image_id\": \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":163,"context_line":"            \"ignore_reserved\": \"true\""},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"d3e9881d_10c7bb4d","line":163,"range":{"start_line":163,"start_character":31,"end_line":163,"end_character":37},"updated":"2021-12-07 17:41:55.000000000","message":"For the example, please use a JSON boolean type, not a string.  (Our request schemas typically allow either, but we should set a good example.)","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    {"},{"line_number":161,"context_line":"        \"os-reimage\": {"},{"line_number":162,"context_line":"            \"image_id\": \"71543ced-a8af-45b6-a5c4-a46282108a90\","},{"line_number":163,"context_line":"            \"ignore_reserved\": \"true\""},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a211787_6b376e7c","line":163,"range":{"start_line":163,"start_character":31,"end_line":163,"end_character":37},"in_reply_to":"d3e9881d_10c7bb4d","updated":"2021-12-10 10:53:35.000000000","message":"Done","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":168,"context_line":"  No default value since this is a required parameter."},{"line_number":169,"context_line":"* The \u003cboolean\u003e \u0027ignore_reserved\u0027 refers to re-image a volume and ignore its"},{"line_number":170,"context_line":"  \u0027reserved\u0027 status. The \u0027available\u0027 and \u0027error\u0027 volume can be re-imaged"},{"line_number":171,"context_line":"  directly, but the \u0027reserved\u0027 volume can only be re-imaged when this"},{"line_number":172,"context_line":"  parameter is \u0027true\u0027."},{"line_number":173,"context_line":"  Defaults to \u0027false\u0027, this is an optional parameter."}],"source_content_type":"text/x-rst","patch_set":6,"id":"edb436a3_cdb69da4","line":170,"range":{"start_line":169,"start_character":2,"end_line":170,"end_character":20},"updated":"2021-12-07 17:41:55.000000000","message":"Please name this something else.  Users can easily interpret True to mean \"do not do this if the volume is in reserved status\", whereas it has precisely the opposite meaning.  Maybe \u0027force_reserved\u0027 or simply \u0027force\u0027?\n\nMore importantly, what is the point of having this flag?  Is the idea that most people will NOT want to re-image a reserved volume, and in between the last time they looked at the volume status and the time this request is being processed, the volume may have transitioned into \u0027reserved\u0027 state, and if so, the user wants the request to fail?  Do users understand the implications of re-imaging a reserved volume sufficiently, or are they just going to always add \u0027force: True to their requests?","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95d07d57cc300b508f210317c20b3a69cb5fbb35","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":168,"context_line":"  No default value since this is a required parameter."},{"line_number":169,"context_line":"* The \u003cboolean\u003e \u0027ignore_reserved\u0027 refers to re-image a volume and ignore its"},{"line_number":170,"context_line":"  \u0027reserved\u0027 status. The \u0027available\u0027 and \u0027error\u0027 volume can be re-imaged"},{"line_number":171,"context_line":"  directly, but the \u0027reserved\u0027 volume can only be re-imaged when this"},{"line_number":172,"context_line":"  parameter is \u0027true\u0027."},{"line_number":173,"context_line":"  Defaults to \u0027false\u0027, this is an optional parameter."}],"source_content_type":"text/x-rst","patch_set":6,"id":"8ab227c9_7bb7f454","line":170,"range":{"start_line":169,"start_character":2,"end_line":170,"end_character":20},"in_reply_to":"610cc2f9_408a0d98","updated":"2021-12-19 15:54:19.000000000","message":"Thanks for renaming the flag.  I think we should say something about this in the api-ref.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"* The \u003cstring\u003e \u0027image_id\u0027 refers to the id of image."},{"line_number":168,"context_line":"  No default value since this is a required parameter."},{"line_number":169,"context_line":"* The \u003cboolean\u003e \u0027ignore_reserved\u0027 refers to re-image a volume and ignore its"},{"line_number":170,"context_line":"  \u0027reserved\u0027 status. The \u0027available\u0027 and \u0027error\u0027 volume can be re-imaged"},{"line_number":171,"context_line":"  directly, but the \u0027reserved\u0027 volume can only be re-imaged when this"},{"line_number":172,"context_line":"  parameter is \u0027true\u0027."},{"line_number":173,"context_line":"  Defaults to \u0027false\u0027, this is an optional parameter."}],"source_content_type":"text/x-rst","patch_set":6,"id":"610cc2f9_408a0d98","line":170,"range":{"start_line":169,"start_character":2,"end_line":170,"end_character":20},"in_reply_to":"edb436a3_cdb69da4","updated":"2021-12-10 10:53:35.000000000","message":"Again, I might miss the original intention but my interpretation of this flag is when nova is NOT making this request.\nSo when nova calls this API, we are adding a new boolean parameter to the API ``reimage_boot_volume`` which users need to explicitly specify and will prevent them from accidentally reimaging a boot volume thinking it\u0027s ephemeral. So we can safely assume nova calling this API with the ignore_reserved parameter will be safe.\nIf an end user calls cinder\u0027s re-image API (via client or curl) and executes that on an reserved volume, they should explicitly specify if they want do this reimage or not.\nThis is just an additional layer of confirmation to the cinder API apart from the use case nova is trying to tackle.\n\nRegarding the naming, i think we\u0027ve a bad precedence of using force for everything and making it confusing for end users as well as developers. I will change this to ``reimage_reserved``, let me know what do you think about it.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":219,"context_line":"          \"consistencygroup_id\": null,"},{"line_number":220,"context_line":"          \"os-vol-mig-status-attr:name_id\": null,"},{"line_number":221,"context_line":"          \"name\": null,"},{"line_number":222,"context_line":"          \"bootable\": \"true\","},{"line_number":223,"context_line":"          \"created_at\": \"2018-09-26T01:55:38.735749\","},{"line_number":224,"context_line":"          \"volume_type\": \"lvmdriver-1\""},{"line_number":225,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"175a7625_e1d3b534","line":222,"range":{"start_line":222,"start_character":22,"end_line":222,"end_character":28},"updated":"2021-12-07 17:41:55.000000000","message":"This was made a string by If7460b1c8ab4af417 for v1-compatibility (but why??? it\u0027s v2!!!), but we don\u0027t want to encourage this kind of thing (compare to line 217).","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":true,"context_lines":[{"line_number":219,"context_line":"          \"consistencygroup_id\": null,"},{"line_number":220,"context_line":"          \"os-vol-mig-status-attr:name_id\": null,"},{"line_number":221,"context_line":"          \"name\": null,"},{"line_number":222,"context_line":"          \"bootable\": \"true\","},{"line_number":223,"context_line":"          \"created_at\": \"2018-09-26T01:55:38.735749\","},{"line_number":224,"context_line":"          \"volume_type\": \"lvmdriver-1\""},{"line_number":225,"context_line":"        }"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0d74ad73_55f17266","line":222,"range":{"start_line":222,"start_character":22,"end_line":222,"end_character":28},"in_reply_to":"175a7625_e1d3b534","updated":"2021-12-10 10:53:35.000000000","message":"I\u0027m also not sure why this was done but since this is outside the scope of this change, i can address that in a separate patch if required.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":261,"context_line":"goes back to its original status or ``error`` in case the operation failed."},{"line_number":262,"context_line":"The only exception here is Nova which will be notified via external events"},{"line_number":263,"context_line":"API and doesn\u0027t need to poll for the re-image to be completed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Performance Impact"},{"line_number":266,"context_line":"------------------"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"0a8efd9b_8212e140","line":264,"updated":"2021-12-07 17:41:55.000000000","message":"Is there any effect on backups or snapshots of the volume?  I guess it\u0027s obvious that if you restore an old backup, you will get the old image?  Since this is really a new volume, are existing snapshots invalid?","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":true,"context_lines":[{"line_number":261,"context_line":"goes back to its original status or ``error`` in case the operation failed."},{"line_number":262,"context_line":"The only exception here is Nova which will be notified via external events"},{"line_number":263,"context_line":"API and doesn\u0027t need to poll for the re-image to be completed."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Performance Impact"},{"line_number":266,"context_line":"------------------"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad294a8_a5ecea0e","line":264,"in_reply_to":"0a8efd9b_8212e140","updated":"2021-12-10 10:53:35.000000000","message":"This is a data path change so only the contents of the volume will be modified and dependent resources like backup and snapshots should not be affected.\nYou\u0027re correct, if we restore an old backup or snapshot, we will get the old image back but if we think irrespective of the volume being a boot volume or not, the purpose of a snapshot/backup is to return the content of a volume to that point when these resources were created so i think the functionally everything will behave correctly as they should.\nSince this is a valid concern, i will add a point regarding this.","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b1be815fe5906cd4c0a8e0661325f10418e244c","unresolved":true,"context_lines":[{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Need to document the new behavior of the volume re-image, as well"},{"line_number":319,"context_line":"as related client examples, etc."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"References"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"827fb663_74f0d17a","line":319,"updated":"2021-12-07 17:41:55.000000000","message":"Given that volumes are usually of much larger size than an image, it needs to be completely clear that this operation doesn\u0027t simply \"re-image\" the image part of a bootable volume -- it completely destroys all data in the volume and replaces it with the new image.  (Unless there\u0027s some way around that?  But from what I can tell, this proposal is wiping out all current volume data and writing the new image.)","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01893285fb42b7701796202b9c0d0608a0cb3efe","unresolved":false,"context_lines":[{"line_number":316,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Need to document the new behavior of the volume re-image, as well"},{"line_number":319,"context_line":"as related client examples, etc."},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"References"},{"line_number":322,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"becd96bc_0d9b50a9","line":319,"in_reply_to":"827fb663_74f0d17a","updated":"2021-12-10 10:53:35.000000000","message":"Done","commit_id":"159f6effd43a2307b185bee97e0423cf6822de00"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95d07d57cc300b508f210317c20b3a69cb5fbb35","unresolved":true,"context_lines":[{"line_number":327,"context_line":"is re-imaged, all current content on the volume will be *destroyed*."},{"line_number":328,"context_line":"This is important as cinder volumes are considered to be persistent,"},{"line_number":329,"context_line":"which is not the case with this operation."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"References"},{"line_number":332,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9f578d73_5f8fb5b7","line":330,"updated":"2021-12-19 15:54:19.000000000","message":"I think we should say something in the api-ref, probably in the description of the\n\u0027reimage_reserved\u0027 field) that reimaging a reserved volume should normally be done only by the Compute service, so we\u0027re requiring this flag to indicate that the caller understands that they are requesting reimaging of a reserved volume.","commit_id":"a5e710f8ba6cddf21dbc535d84e2b5792ade236c"}]}