)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     tushargite96 \u003ctushargite96@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-14 13:35:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating python testing as per Yoga testing runtime"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Yoga testing runtime[1] has been updated to add py39"},{"line_number":10,"context_line":"testing as voting and as we are testing py3.6 and py3.9"},{"line_number":11,"context_line":"we do not need to test py3.7|8 explicitly. Unit tests update are"},{"line_number":12,"context_line":"handled by the job template change in openstack-zuul-job"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"this commit makes other required changes in zuul.yaml and"},{"line_number":17,"context_line":"update the classifier in setup.cfg file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://governance.openstack.org/tc/reference/runtimes/yoga.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I82581f005566cb31c206fa8dff475dfa1bbcb2fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0e8123a8_c00c250e","line":20,"range":{"start_line":7,"start_character":0,"end_line":20,"end_character":0},"updated":"2021-12-21 14:46:17.000000000","message":"We don\u0027t run the testing template on this repo, so I don\u0027t think any of this applies.  I suggest changing it to:\n\n  Correct metadata in setup.cfg\n\n  Remove the python-language specific classifiers because they\n  don\u0027t apply to this repository.","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a3dad882e11880d5896c05120689a721965b89a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tushargite96 \u003ctushargite96@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-14 13:35:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating python testing as per Yoga testing runtime"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Yoga testing runtime[1] has been updated to add py39"},{"line_number":10,"context_line":"testing as voting and as we are testing py3.6 and py3.9"},{"line_number":11,"context_line":"we do not need to test py3.7|8 explicitly. Unit tests update are"},{"line_number":12,"context_line":"handled by the job template change in openstack-zuul-job"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"this commit makes other required changes in zuul.yaml and"},{"line_number":17,"context_line":"update the classifier in setup.cfg file."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://governance.openstack.org/tc/reference/runtimes/yoga.html"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I82581f005566cb31c206fa8dff475dfa1bbcb2fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"66030bae_eb26eabb","line":20,"range":{"start_line":7,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"0e8123a8_c00c250e","updated":"2021-12-22 07:35:33.000000000","message":"Done","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1a45dc3caca5ca07d99aa33d3f1b16e1a89168c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3cecfb8_d9da412d","updated":"2021-12-07 17:56:12.000000000","message":"Thanks for posting this, Tushar.  Question inline.  Do you know what are other projects doing about this for their specs repos?","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"3a213f06b418e68171faea35f3684e1ea5065cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88f3a61e_edfa59f4","in_reply_to":"e3cecfb8_d9da412d","updated":"2021-12-08 03:54:30.000000000","message":"no i\u0027ve no idea i\u0027ve push this to maintain consistency in all repos.\n\nlike this\nhttps://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/819263\nhttps://review.opendev.org/c/openstack/python-cinderclient/+/819259","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"324ef443_d715d4f3","updated":"2021-12-21 14:46:17.000000000","message":"I looked into this a bit and would like you to take it in a different direction.  I think our setup.cfg should be a minimal one like Nova and Glance use:\n\n* https://opendev.org/openstack/nova-specs/src/branch/master/setup.cfg\n* https://opendev.org/openstack/glance-specs/src/branch/master/setup.cfg\n\nThen we won\u0027t have to worry about updating this stuff in the future.  Thanks for getting this started, I think it was a mistake to have those python-language classifiers in there in the first place.","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dfb7ca82dcf56529b78e2492e4c24baa6cfa9572","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f894df4_5923fd6a","updated":"2021-12-22 15:38:32.000000000","message":"Thanks, Tushar.  LGTM.\n\nI have some suggestions for a follow-up.  See comment inline for a nit you can address, and also I notice that we are using some \"aliases\" that the setuptools docs say \"are supported for compatibility reasons, but their use is not advised.\"  So if you want, you can update those:\nhttps://setuptools.pypa.io/en/latest/userguide/declarative_config.html#metadata\n\nThe ones I noticed are:\n\nsummary -\u003e description\nhome_page -\u003e url\ndescription_file -\u003e long_description (the content should be: file: README.rst)\nclassifier -\u003e classifiers\n\nThe virtualenv setup.cfg looks like a good example of using setup metadata:\nhttps://github.com/pypa/virtualenv/blob/main/setup.cfg\n","commit_id":"22e1d3e592995594339f61c7f14695b215a52161"}],"setup.cfg":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3c85b61e970198946f468345950a54e42badce6f","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"623646d4_b6be2bb1","line":20,"range":{"start_line":20,"start_character":38,"end_line":20,"end_character":41},"updated":"2021-12-02 09:27:00.000000000","message":"-1: We support 3.8 and 3.9, so this is missing the 3.8 line","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b631a098ef48789963d9239bce77362b081179ba","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b0983e7a_24e6294f","line":20,"range":{"start_line":20,"start_character":38,"end_line":20,"end_character":41},"in_reply_to":"623646d4_b6be2bb1","updated":"2021-12-02 09:27:58.000000000","message":"Though now that I think about it, we don\u0027t really care for the specs... So I\u0027ll change the vote.","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1a45dc3caca5ca07d99aa33d3f1b16e1a89168c7","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b7666590_793f1b77","line":20,"range":{"start_line":20,"start_character":38,"end_line":20,"end_character":41},"in_reply_to":"b0983e7a_24e6294f","updated":"2021-12-07 17:56:12.000000000","message":"For the specs, maybe we should simply eliminate this line and leave only lines 18-19.  If the idea is that we are guaranteeing that you can build the specs docs with the version of python listed here, then we actually need 3.8, because that\u0027s what we\u0027re actually testing with:\n\nhttps://zuul.opendev.org/t/openstack/build/703a2154770e4b4293f732d6c381194a/log/job-output.txt#803\n\nBut if all we want to say is that you need some version of Python 3 to build the specs, then let\u0027s not specify a particular version that will go out of date.","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"3a213f06b418e68171faea35f3684e1ea5065cd9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    Programming Language :: Python :: Implementation :: CPython"},{"line_number":18,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":19,"context_line":"    Programming Language :: Python :: 3"},{"line_number":20,"context_line":"    Programming Language :: Python :: 3.9"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4ae6935e_5d457bef","line":20,"range":{"start_line":20,"start_character":38,"end_line":20,"end_character":41},"in_reply_to":"b7666590_793f1b77","updated":"2021-12-08 03:54:30.000000000","message":"Done","commit_id":"431e57e291cd236c2a681b783b78942d4a00e25f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d cinder-specs"},{"line_number":3,"context_line":"summary \u003d \"Cinder Specifications repository\""},{"line_number":4,"context_line":"description_file \u003d"},{"line_number":5,"context_line":"    README.rst"},{"line_number":6,"context_line":"author \u003d OpenStack"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"6f81412a_96f0d8cc","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":44},"updated":"2021-12-21 14:46:17.000000000","message":"Change to\n\n  OpenStack Cinder Project Development Specifications","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a3dad882e11880d5896c05120689a721965b89a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d cinder-specs"},{"line_number":3,"context_line":"summary \u003d \"Cinder Specifications repository\""},{"line_number":4,"context_line":"description_file \u003d"},{"line_number":5,"context_line":"    README.rst"},{"line_number":6,"context_line":"author \u003d OpenStack"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"e3fa1169_cff07e84","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":44},"in_reply_to":"6f81412a_96f0d8cc","updated":"2021-12-22 07:35:33.000000000","message":"Done","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":true,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d http://specs.openstack.org/openstack/cinder-specs/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9886b4de_3b1c4d9c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":23},"updated":"2021-12-21 14:46:17.000000000","message":"remove","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a3dad882e11880d5896c05120689a721965b89a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"author \u003d OpenStack"},{"line_number":7,"context_line":"author_email \u003d openstack-discuss@lists.openstack.org"},{"line_number":8,"context_line":"home_page \u003d http://specs.openstack.org/openstack/cinder-specs/"},{"line_number":9,"context_line":"python_requires \u003d \u003e\u003d3.6"},{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"c107285a_4ca340cb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":23},"in_reply_to":"9886b4de_3b1c4d9c","updated":"2021-12-22 07:35:33.000000000","message":"Done","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":true,"context_lines":[{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"},{"line_number":13,"context_line":"    Intended Audience :: System Administrators"},{"line_number":14,"context_line":"    License :: OSI Approved :: Apache Software License"},{"line_number":15,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":16,"context_line":"    Programming Language :: Python"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"8fc67929_c7259478","line":13,"updated":"2021-12-21 14:46:17.000000000","message":"add\n\n  Intended Audience :: Developers","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a3dad882e11880d5896c05120689a721965b89a7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"classifier \u003d"},{"line_number":11,"context_line":"    Environment :: OpenStack"},{"line_number":12,"context_line":"    Intended Audience :: Information Technology"},{"line_number":13,"context_line":"    Intended Audience :: System Administrators"},{"line_number":14,"context_line":"    License :: OSI Approved :: Apache Software License"},{"line_number":15,"context_line":"    Operating System :: POSIX :: Linux"},{"line_number":16,"context_line":"    Programming Language :: Python"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"ad7d40c3_127e5078","line":13,"in_reply_to":"8fc67929_c7259478","updated":"2021-12-22 07:35:33.000000000","message":"Done","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"829d48e05c598fd72e83d3a98436c54f1adbc9ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fa280c5_0164d1a7","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":0},"updated":"2021-12-21 14:46:17.000000000","message":"remove","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a3dad882e11880d5896c05120689a721965b89a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b83088a_261dbde4","line":23,"range":{"start_line":16,"start_character":0,"end_line":23,"end_character":0},"in_reply_to":"8fa280c5_0164d1a7","updated":"2021-12-22 07:35:33.000000000","message":"Done","commit_id":"1bc845ab751ee002ab34d138a584cd0911d3cd05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dfb7ca82dcf56529b78e2492e4c24baa6cfa9572","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[metadata]"},{"line_number":2,"context_line":"name \u003d cinder-specs"},{"line_number":3,"context_line":"summary \u003d \"Openstack Cinder Project Development Specifications\""},{"line_number":4,"context_line":"description_file \u003d"},{"line_number":5,"context_line":"    README.rst"},{"line_number":6,"context_line":"author \u003d OpenStack"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"854efc51_72704f40","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":63},"updated":"2021-12-22 15:38:32.000000000","message":"nit: don\u0027t need the quotes around this string, but you can address that in a followup patch.","commit_id":"22e1d3e592995594339f61c7f14695b215a52161"}]}
