)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"241a640479eeb6c796d52328635a6f51c8a2f3d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7577f33_cc154e99","updated":"2022-04-28 14:28:13.000000000","message":"This is an excellent suggestion...\nFix the nit and I\u0027ll +2 it","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86e05b82_cb1f43cc","updated":"2022-05-31 05:31:03.000000000","message":"one concern inline regarding the redundant fields being reported.","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4946927_29261fc8","updated":"2022-06-20 19:04:26.000000000","message":"Few comments inline but overall it looks good.","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a525f404e43f262839d45cd68b49c9097784acf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5555ab85_d8d135af","updated":"2022-06-22 15:37:59.000000000","message":"one grammatical nit","commit_id":"7e74dbc098a9f6ac67faaab2f2ae5446f97ec911"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d9d4794aa2ea4f785545298c122caba694384d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7fe6ae4_d6f36419","updated":"2022-06-22 18:31:19.000000000","message":"Thanks Walt for addressing all my comments, LGTM.","commit_id":"21b101a9ad88eed399339cc17b9969710917e796"}],"specs/zed/add-capacity-factors-to-get-pools.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":8,"context_line":"Add Capacity Factors to scheduler get pools api"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9014298e_0ee7944d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":44},"updated":"2022-05-31 05:31:03.000000000","message":"I think this line should be removed, it\u0027s a placeholder for the blueprint link","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9f2dc7dc3ad709d8645cf8e85b9e07496e852392","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add Capacity Factors to scheduler get pools api"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Include the URL of your launchpad blueprint:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"32ee7586_65d3c307","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":44},"in_reply_to":"9014298e_0ee7944d","updated":"2022-06-02 14:02:48.000000000","message":"Ack","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This spec proposes added the new capacity factors in the response to the"},{"line_number":16,"context_line":"get-pools API request."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0ec38e70_d4137071","line":15,"range":{"start_line":15,"start_character":19,"end_line":15,"end_character":24},"updated":"2022-05-31 05:31:03.000000000","message":"nit: adding","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9f2dc7dc3ad709d8645cf8e85b9e07496e852392","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This spec proposes added the new capacity factors in the response to the"},{"line_number":16,"context_line":"get-pools API request."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"4176f8e7_c3b4b0e9","line":15,"range":{"start_line":15,"start_character":19,"end_line":15,"end_character":24},"in_reply_to":"0ec38e70_d4137071","updated":"2022-06-02 14:02:48.000000000","message":"Done","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"241a640479eeb6c796d52328635a6f51c8a2f3d6","unresolved":true,"context_lines":[{"line_number":50,"context_line":"is unusable by customers to create/extend/migrate volumes to a pool.  So an"},{"line_number":51,"context_line":"administrator might be looking at the storage array pools and they all look"},{"line_number":52,"context_line":"like they have plenty of space, but the cinder setting hides the fact that"},{"line_number":53,"context_line":"only 50% of the pool is available.  For"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Use Cases"},{"line_number":56,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"63048081_94485047","line":53,"range":{"start_line":53,"start_character":36,"end_line":53,"end_character":39},"updated":"2022-04-28 14:28:13.000000000","message":"(not) bad cut/paste??","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":50,"context_line":"is unusable by customers to create/extend/migrate volumes to a pool.  So an"},{"line_number":51,"context_line":"administrator might be looking at the storage array pools and they all look"},{"line_number":52,"context_line":"like they have plenty of space, but the cinder setting hides the fact that"},{"line_number":53,"context_line":"only 50% of the pool is available.  For"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Use Cases"},{"line_number":56,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"aa7a43f8_2e04120d","line":53,"range":{"start_line":53,"start_character":36,"end_line":53,"end_character":39},"in_reply_to":"63048081_94485047","updated":"2022-05-31 05:31:03.000000000","message":"This looks incomplete, I think the purpose was to explain each of the factors above (or at least complete the reserved_percentage description).","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9f2dc7dc3ad709d8645cf8e85b9e07496e852392","unresolved":false,"context_lines":[{"line_number":50,"context_line":"is unusable by customers to create/extend/migrate volumes to a pool.  So an"},{"line_number":51,"context_line":"administrator might be looking at the storage array pools and they all look"},{"line_number":52,"context_line":"like they have plenty of space, but the cinder setting hides the fact that"},{"line_number":53,"context_line":"only 50% of the pool is available.  For"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Use Cases"},{"line_number":56,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c85a7fa6_27e2dd39","line":53,"range":{"start_line":53,"start_character":36,"end_line":53,"end_character":39},"in_reply_to":"aa7a43f8_2e04120d","updated":"2022-06-02 14:02:48.000000000","message":"Done","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":130,"context_line":"                  \"QoS_support\": false"},{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"44242b46_7043d0ac","line":133,"range":{"start_line":133,"start_character":19,"end_line":133,"end_character":33},"updated":"2022-05-31 05:31:03.000000000","message":"currently this is already reported as total_capacity_gb?","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                  \"QoS_support\": false"},{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"299008a9_5e1fa56d","line":133,"range":{"start_line":133,"start_character":19,"end_line":133,"end_character":33},"in_reply_to":"44242b46_7043d0ac","updated":"2022-06-20 19:04:26.000000000","message":"Done","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ee93e323_89c70181","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"updated":"2022-05-31 05:31:03.000000000","message":"same as free_capacity_gb?","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d760d63efb8f4cafbe410973b682b313b31121b4","unresolved":true,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"843f1c81_a9ffbb3d","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"in_reply_to":"73055b00_a3a51f5e","updated":"2022-06-03 13:06:39.000000000","message":"https://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L336-L353","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2762c6bff9e86158743ccba0b7270704245b71dc","unresolved":true,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"cb3305be_62ef7d80","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"in_reply_to":"843f1c81_a9ffbb3d","updated":"2022-06-03 13:45:51.000000000","message":"Just remember, everything in the capabilities is what\u0027s being reported by the driver and volume manager at the time the last get_volume_stats() was called.  What\u0027s in the capacity factors dictionary is modified from those capabilities values in between the stats call.  They can and will be different depending on when the call to cinder get-pools --detail was called.    They are labeled the same, but the values can be different.   As ad administrator I want to see what the scheduler sees at the time I call get-pools, not what the driver reported last time it was called.  Sometimes I want to see both of those.","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"05b92c9cbf45c9f64d475acea9716d2d68d5a972","unresolved":true,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"73055b00_a3a51f5e","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"in_reply_to":"850b926d_5bf9a95e","updated":"2022-06-03 13:05:22.000000000","message":"actually even the free_capacity_gb can be different in between calls to get_volume_stats() as the scheduler decrements this value when it marks the pool as having consumed a new volume.","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":false,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f240267_601b3fd6","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"in_reply_to":"cb3305be_62ef7d80","updated":"2022-06-20 19:04:26.000000000","message":"Ack","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7695b6d68b0179daae4d2c1571bf5ee8b19ff612","unresolved":true,"context_lines":[{"line_number":131,"context_line":"              },"},{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"850b926d_5bf9a95e","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":32},"in_reply_to":"ee93e323_89c70181","updated":"2022-06-03 12:57:10.000000000","message":"yes it\u0027s the same value, but this dict is the entire story of all of the capacity factors that that scheduler uses.  I don\u0027t want to leave out some simply because they are already in the capabilities.","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0bccc6f1ffc06871a30610720e635fe6e737af5a","unresolved":true,"context_lines":[{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"},{"line_number":138,"context_line":"                  \"total_available_capacity\": 973,"},{"line_number":139,"context_line":"                  \"provisioned_capacity\": 100,"},{"line_number":140,"context_line":"                  \"calculated_free_capacity\": 873,"},{"line_number":141,"context_line":"                  \"virtual_free_capacity\": 873,"},{"line_number":142,"context_line":"                  \"free_percent\": 89.72,"},{"line_number":143,"context_line":"                  \"provisioned_ratio\": 0.1028,"},{"line_number":144,"context_line":"                  \"provisioned_type\": \"thick\"}"},{"line_number":145,"context_line":"              ],"},{"line_number":146,"context_line":"          }"},{"line_number":147,"context_line":"      ]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ee45aaa_4c3aa2b5","line":144,"range":{"start_line":135,"start_character":0,"end_line":144,"end_character":46},"updated":"2022-05-31 05:31:03.000000000","message":"Given the parameters that are already reported in capabilities[1], some of them are redundant in this new dict. Can we only specify those parameters which are newly added?\n\n[1] https://github.com/openstack/cinder/blob/2937ef77028d6ed3e1ff992ad75a62cf96e8ebb1/cinder/interface/volume_driver.py#L68-L150","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":false,"context_lines":[{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"},{"line_number":138,"context_line":"                  \"total_available_capacity\": 973,"},{"line_number":139,"context_line":"                  \"provisioned_capacity\": 100,"},{"line_number":140,"context_line":"                  \"calculated_free_capacity\": 873,"},{"line_number":141,"context_line":"                  \"virtual_free_capacity\": 873,"},{"line_number":142,"context_line":"                  \"free_percent\": 89.72,"},{"line_number":143,"context_line":"                  \"provisioned_ratio\": 0.1028,"},{"line_number":144,"context_line":"                  \"provisioned_type\": \"thick\"}"},{"line_number":145,"context_line":"              ],"},{"line_number":146,"context_line":"          }"},{"line_number":147,"context_line":"      ]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a8535d9c_1eb93765","line":144,"range":{"start_line":135,"start_character":0,"end_line":144,"end_character":46},"in_reply_to":"3b758a7a_9419ba3f","updated":"2022-06-20 19:04:26.000000000","message":"Ack","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9f2dc7dc3ad709d8645cf8e85b9e07496e852392","unresolved":true,"context_lines":[{"line_number":132,"context_line":"              \"capacity_factors\": [{"},{"line_number":133,"context_line":"                  \"total_capacity\": 1024,"},{"line_number":134,"context_line":"                  \"free_capacity\": 100,"},{"line_number":135,"context_line":"                  \"reserved_capacity\": 51,"},{"line_number":136,"context_line":"                  \"total_reserved_available_capacity\": 973,"},{"line_number":137,"context_line":"                  \"max_over_subscription_ratio\": None,"},{"line_number":138,"context_line":"                  \"total_available_capacity\": 973,"},{"line_number":139,"context_line":"                  \"provisioned_capacity\": 100,"},{"line_number":140,"context_line":"                  \"calculated_free_capacity\": 873,"},{"line_number":141,"context_line":"                  \"virtual_free_capacity\": 873,"},{"line_number":142,"context_line":"                  \"free_percent\": 89.72,"},{"line_number":143,"context_line":"                  \"provisioned_ratio\": 0.1028,"},{"line_number":144,"context_line":"                  \"provisioned_type\": \"thick\"}"},{"line_number":145,"context_line":"              ],"},{"line_number":146,"context_line":"          }"},{"line_number":147,"context_line":"      ]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3b758a7a_9419ba3f","line":144,"range":{"start_line":135,"start_character":0,"end_line":144,"end_character":46},"in_reply_to":"5ee45aaa_4c3aa2b5","updated":"2022-06-02 14:02:48.000000000","message":"They look redundant but aren\u0027t.  \n\nThe capabilities are reported by the driver.\nThese values are modified in real time by the scheduler to be used for provisioning requests, which can be and are often different than what is reported by the driver, until the next time get_volume_stats() is called.","commit_id":"48e3e495b812a9d0b12003d8d443ca32beae33cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":true,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add Capacity Factors to scheduler get pools api"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"}],"source_content_type":"text/x-rst","patch_set":3,"id":"eec5fcd5_62db7667","line":8,"range":{"start_line":8,"start_character":44,"end_line":8,"end_character":47},"updated":"2022-06-20 19:04:26.000000000","message":"nit: API","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cc26ab116a48f734c85ab3a1bbad50c935afdb0f","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add Capacity Factors to scheduler get pools api"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/add-capacity-factors-to-pool"}],"source_content_type":"text/x-rst","patch_set":3,"id":"8e2d3fcf_bc645dc9","line":8,"range":{"start_line":8,"start_character":44,"end_line":8,"end_character":47},"in_reply_to":"eec5fcd5_62db7667","updated":"2022-06-21 19:16:11.000000000","message":"Done","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Add the dictionary that is created from calculate_capacity_factors() to each"},{"line_number":58,"context_line":"pool information in the get-pools response.  Depending on the capabilities"},{"line_number":59,"context_line":"in each pool: thin_provisioning_support, thick_provisioning_support, factors"}],"source_content_type":"text/x-rst","patch_set":3,"id":"230dd6f1_6a256ec7","line":56,"updated":"2022-06-20 19:04:26.000000000","message":"I would really like this to be pointed out in the spec that the new capacity factors being reported are not the ones currently returned in capabilities and are a reflection of current state of scheduler vs what is being reported by get_volume_stats()","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cc26ab116a48f734c85ab3a1bbad50c935afdb0f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Proposed change"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Add the dictionary that is created from calculate_capacity_factors() to each"},{"line_number":58,"context_line":"pool information in the get-pools response.  Depending on the capabilities"},{"line_number":59,"context_line":"in each pool: thin_provisioning_support, thick_provisioning_support, factors"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a653ea98_55d3e1d7","line":56,"in_reply_to":"230dd6f1_6a256ec7","updated":"2022-06-21 19:16:11.000000000","message":"Done","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c7ff0e5f9428cd40b0079a608e32e62b7d5f929","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  GET /v3/{project_id}/scheduler-stats/get_pools?detail\u003dTrue"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The response body would now include the availability_zone attribute:"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":".. code-block:: python"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"eb090d2b_60cec2be","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":68},"updated":"2022-06-20 19:04:26.000000000","message":"don\u0027t see this in the example below","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cc26ab116a48f734c85ab3a1bbad50c935afdb0f","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  GET /v3/{project_id}/scheduler-stats/get_pools?detail\u003dTrue"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"The response body would now include the availability_zone attribute:"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":".. code-block:: python"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"049a6c7a_97fb7af7","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":68},"in_reply_to":"eb090d2b_60cec2be","updated":"2022-06-21 19:16:11.000000000","message":"Done","commit_id":"fdf259886c120ac5cbb93dc975cf864d1037efe6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"351595f0f7228de1c04d3bfdc144f3064f0b01a2","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  GET /v3/{project_id}/scheduler-stats/get_pools?detail\u003dTrue"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The response body would now include the availability_zone attribute:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. code-block:: python"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"c5a1adfa_a6128261","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":68},"updated":"2022-06-22 04:52:30.000000000","message":"I think this line needs to be removed as well","commit_id":"91f43795de2ca6d308dc95f3af83627945f232cc"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1446f2b7b3c6d3892a5fe67806fee32549f962ed","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  GET /v3/{project_id}/scheduler-stats/get_pools?detail\u003dTrue"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"The response body would now include the availability_zone attribute:"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. code-block:: python"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"8f2cc73e_fb4e9e17","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":68},"in_reply_to":"c5a1adfa_a6128261","updated":"2022-06-22 13:58:02.000000000","message":"Done","commit_id":"91f43795de2ca6d308dc95f3af83627945f232cc"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a525f404e43f262839d45cd68b49c9097784acf9","unresolved":true,"context_lines":[{"line_number":59,"context_line":"same thing as the capabilities being reported now.  The capacity factors are"},{"line_number":60,"context_line":"the breakdown of the capacity calculations based on the driver\u0027s reported"},{"line_number":61,"context_line":"capabilities seen by the backend storage.  Depending on the capabilities"},{"line_number":62,"context_line":"in each pool: thin_provisioning_support, thick_provisioning_support, factors"},{"line_number":63,"context_line":"will be calculated for each thin and thick if the pool supports."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"05387003_270a2a03","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":13},"updated":"2022-06-22 15:37:59.000000000","message":"nit: maybe make this a comma or remove punctuation completely","commit_id":"7e74dbc098a9f6ac67faaab2f2ae5446f97ec911"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7f9a6f7132a4a3b01d05f0f71e52770fbc9e55e5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"same thing as the capabilities being reported now.  The capacity factors are"},{"line_number":60,"context_line":"the breakdown of the capacity calculations based on the driver\u0027s reported"},{"line_number":61,"context_line":"capabilities seen by the backend storage.  Depending on the capabilities"},{"line_number":62,"context_line":"in each pool: thin_provisioning_support, thick_provisioning_support, factors"},{"line_number":63,"context_line":"will be calculated for each thin and thick if the pool supports."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. code-block:: python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"cf849240_ec212cf7","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":13},"in_reply_to":"05387003_270a2a03","updated":"2022-06-22 17:13:21.000000000","message":"Done","commit_id":"7e74dbc098a9f6ac67faaab2f2ae5446f97ec911"}]}