)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e81a7cc758a3d7e5fa9fed54d21c45f87f9d400d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-28 20:16:30 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec to introduce a backup_status field for volumes and a split-up of backup"},{"line_number":8,"context_line":"status away from volume_status."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is intened to allow for less serialization or blocking"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"50c869b2_666182e0","line":7,"updated":"2023-01-05 14:35:25.000000000","message":"nit: line length is too long","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7835e38a190afa66eaddc59ffddbddd66bc55087","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-28 20:16:30 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec to introduce a backup_status field for volumes and a split-up of backup"},{"line_number":8,"context_line":"status away from volume_status."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is intened to allow for less serialization or blocking"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ab63bacf_81f086bd","line":7,"in_reply_to":"50c869b2_666182e0","updated":"2023-02-23 13:13:45.000000000","message":"Done","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-23 19:30:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec to introduce a backup_status field for volumes and a split-up of the"},{"line_number":8,"context_line":"backup status away from the volume_status."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is intened to allow for less serialization or blocking"},{"line_number":11,"context_line":"of volume actions such as re-attachments, resizing, ... by backup tasks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7758edf2_cdaad692","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":42},"updated":"2023-05-04 07:01:53.000000000","message":"The first line should be limited to 50 characters.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nSuggestion: We can break first line into two lines:\nSpec Introduce new backup_status field for volume\n\nThis also involves split-up of the backup status away from\nthe volume_status","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Rohmann \u003cchristian.rohmann@inovex.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-23 19:30:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Spec to introduce a backup_status field for volumes and a split-up of the"},{"line_number":8,"context_line":"backup status away from the volume_status."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This is intened to allow for less serialization or blocking"},{"line_number":11,"context_line":"of volume actions such as re-attachments, resizing, ... by backup tasks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4c2a1503_b0614fce","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":42},"in_reply_to":"7758edf2_cdaad692","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"3bf693be3e8803d6a2b31e96d1428c810cb656fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"864c1a6a_f689d645","updated":"2022-12-28 14:21:59.000000000","message":"Happy Holidays and sorry for the huge delay - Sickness(es) kept me away from consoles and specs for a while.\n\nHere you go with my first attempt at a spec to split away the backup status for volumes to their own field.\n\nWe discussed this at Antelope midcycle, see https://etherpad.opendev.org/p/cinder-antelope-midcycles#L79.\n\nI admit that I ripped and adopted  few sections off of https://review.opendev.org/c/openstack/cinder-specs/+/818551/ which was the previous attempt to decouple backups a little more.\n\n\n\nThanks for taking the time to review and refine this!","commit_id":"e6d53124282a0023336d3ae68e977379a30230c3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e81a7cc758a3d7e5fa9fed54d21c45f87f9d400d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4e7b2de_5b34e993","updated":"2023-01-05 14:35:25.000000000","message":"A few nits","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a7d089102ea2c848dd4c003e06288bb800f724c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfb42b43_283cb932","updated":"2023-01-05 14:26:22.000000000","message":"This was proposed after the spec deadline (23 December, 2022). As per discussion in the meeting yesterday[1], adding a procedural -2.\n\n[1] https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-01-04-14.00.log.html#l-22","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91ff6c643cbdb0be3dc0b09aba8ebdbe998e2b22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fab1b526_74f19641","updated":"2023-04-04 11:23:53.000000000","message":"2023.2 is open for development","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"0298d5cb84f009e1f67c9056d5dbd805ac21617d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"139e6eaf_9ac4d792","updated":"2023-04-13 10:08:54.000000000","message":"Could this be looked at and considered again see we know if it\u0027s work implementing?","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"32956455cde465d01797975a5654bb3fcae07cac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"898ca1ce_6e32473c","updated":"2023-02-23 14:27:19.000000000","message":"Looks good, but need additional technical review","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7835e38a190afa66eaddc59ffddbddd66bc55087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"afdfb664_47301899","updated":"2023-02-23 13:13:45.000000000","message":"Uploaded patchset 2, now targeting the 2023.2 (Bobcat) release.\nThis also includes some fixes to the kind review from Simon.","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"afeed5571983360778b8f36b8a477ceabdf41a76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18cd4e76_573ce444","updated":"2023-02-23 14:09:47.000000000","message":"recheck\n","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b45d11b_cacfca90","in_reply_to":"139e6eaf_9ac4d792","updated":"2024-04-16 09:08:19.000000000","message":"Done","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"492082b35ad2e5271dd6f773fc64b2eb0b6e9017","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bfbbdc41_2148cf67","updated":"2023-05-03 07:44:05.000000000","message":"Gorka, Sofia could you kindly give an update on where this spec / idea stands?\n\nI know there are other voices asking for (long) running backups to survive a restart of the cinder-backup service (e.g. if it\u0027s running on Kubernetes ;-) ). But firstly I believe externalizing the state machine for backups altogether would be a great first step.","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"539f07b4_cf3859bd","updated":"2023-05-04 07:01:53.000000000","message":"Minor typos inline","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"89802a00d10184797c3e6e89ed64eed032709618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e054c882_031734f1","updated":"2023-05-03 14:32:10.000000000","message":"Needs a detailed technical review as well","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3e64a3b_fbf9b43c","in_reply_to":"bfbbdc41_2148cf67","updated":"2024-04-16 09:08:19.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"88d88061d9663d69fe9dfafa42b20bb75b8eec41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"64d6b10c_2501cd8f","updated":"2023-05-05 04:19:33.000000000","message":"My comments have been addressed. Thanks.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"87220b73ce3e20991c5fe9f539ca84e4e4056021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c0873dc3_1b17bbba","updated":"2023-06-01 21:46:46.000000000","message":"Needs technical review.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b73dd8d75942f03ca904cbafe7e81d49210ec32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"91d2d453_b0aa4712","updated":"2023-06-09 20:01:10.000000000","message":"Question inline.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c355766_9a2f71e4","updated":"2023-05-04 19:12:05.000000000","message":"Thanks for your reviews and feedback. I tried to fix all of them typos.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ea4327b4_d003b51d","updated":"2023-06-09 15:21:30.000000000","message":"few comments inline","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ab2e79687e6de9aaa3294591a6a270daf87d37d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"865538c7_52eed3a6","updated":"2023-06-19 23:24:27.000000000","message":"Overall this looks okay, but it omits one question: do we have any back-ends remaining that have no snapshot capability, and thus run backups straight from a volume?\n\nIf the question is yes, a compatibility strategy must be outlined. If the answer is no, the word \"most\" must be removed.\n\nI also added some less significant comments and questions.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3c86229b_19fcbea3","updated":"2023-06-12 20:10:34.000000000","message":"Thank you very much for your intensive proof reading and review Brian and Rajat!\nI tried to use your feedback as best as I can to create a new revision.\n\nPlease kindly check out if you like the changes and please also let us get the last remaining discussions out of the way.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"63844585ff8fd78bb64503f66698abb0ac384538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eea3d0de_31ec4c0e","updated":"2023-06-21 13:24:10.000000000","message":"Thanks for yet another thorough review!\nI addressed the remarks from Pete.\n\nPlease let me know if there is anything else I can do.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a7d4919e_1714c9a4","updated":"2023-06-20 20:26:09.000000000","message":"this looks really good, few more comments inline","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"63844585ff8fd78bb64503f66698abb0ac384538","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8bd59bcd_ef774c90","in_reply_to":"865538c7_52eed3a6","updated":"2023-06-21 13:24:10.000000000","message":"From how far I remember this exact same question being discussed, I believe there will be a volume clone created instead and there are no backup backends actually requiring exclusive access or any locking of the volume.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"c4afe667293e5e1bd3d49b242cfa8454337137ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5195dd6d_a4bf2de5","updated":"2023-06-21 13:28:26.000000000","message":"Sorry I missed the remarks from Rajat ... but they should be addressed now.","commit_id":"cf528b6b5aae1994bb38bdea33f2cda3b5449595"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"614214f71ab6a6c2ecf5cf769fe27ca317c5fb99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"03b0fed0_f78d9630","updated":"2023-06-21 18:02:21.000000000","message":"I suspect Rajat meant double back quotes like ``xxx``, not just single like `xxx`. But I\u0027m okay with either.","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"55dc9135399556797a0005eb5e08c926b4fc6ed3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"45b3a777_2a1f7dd8","updated":"2023-06-21 15:22:43.000000000","message":"LGTM!","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7932e9f5eebb5e5c87911beffedb507031013463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1de2164e_bcd2673a","updated":"2024-04-12 15:17:52.000000000","message":"If we are still interesting in implementing this, can we repropose this for the 2024.2 Dalmatian cycle?","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cc25f255454c350d8ad9ff929aeb17da70d6fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ea3f261e_95a0bc1a","updated":"2023-06-22 11:11:44.000000000","message":"LGTM","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"5d321c6a69326ddea6969c3ec9145342eec09f82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"54ebce48_accc2a8c","updated":"2023-09-01 12:51:32.000000000","message":"May I ask if there are any plans to somehow tackle this in 2024.1 (Caracal)?","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"99e952956947e7cdd13b88882fc03b6393a0e9d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a5d19785_ea857155","updated":"2023-06-26 08:58:05.000000000","message":"Thanks for all the reviews and the resulting merge of this one.\nCan you maybe give a status update on how this change is going to be tackled code wise? \n\nWho will be working on this? I gladly help reviewing/testing/suggesting more, but I simply cannot write all the required changes and provide a patch for this one.","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0e2d3bd_970b4442","in_reply_to":"1de2164e_bcd2673a","updated":"2024-04-16 09:08:19.000000000","message":"I did just that in https://review.opendev.org/c/openstack/cinder-specs/+/915973","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5e33014f_1a78e091","in_reply_to":"54ebce48_accc2a8c","updated":"2024-04-16 09:08:19.000000000","message":"see https://review.opendev.org/c/openstack/cinder-specs/+/915973","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b41613dd_9e293de0","in_reply_to":"a5d19785_ea857155","updated":"2024-04-16 09:08:19.000000000","message":"Done","commit_id":"d99603a9ba6fe7d4de3bcd1d43410f21b153ca35"}],"specs/2023.1/dedicated-volume-backup-status-field.rst":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e81a7cc758a3d7e5fa9fed54d21c45f87f9d400d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove any blocking or serialization backup tasks pose on other"},{"line_number":13,"context_line":"tasks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"d20b36a3_477248d2","line":12,"range":{"start_line":12,"start_character":53,"end_line":12,"end_character":58},"updated":"2023-01-05 14:35:25.000000000","message":"?? is that the correct word, or is there something missing?","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7835e38a190afa66eaddc59ffddbddd66bc55087","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove any blocking or serialization backup tasks pose on other"},{"line_number":13,"context_line":"tasks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c2194f4f_890450dc","line":12,"range":{"start_line":12,"start_character":53,"end_line":12,"end_character":58},"in_reply_to":"d20b36a3_477248d2","updated":"2023-02-23 13:13:45.000000000","message":"\u003e ?? is that the correct word, or is there something missing?\n\nmeant to say \"impose\"","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e81a7cc758a3d7e5fa9fed54d21c45f87f9d400d","unresolved":true,"context_lines":[{"line_number":48,"context_line":"on a volume:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"1. For cloud operators - Currently the re-attachment change of a volume as it"},{"line_number":51,"context_line":"appens during an instance live-migration is blocked by a concurrently run volume"},{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"},{"line_number":54,"context_line":"such as the live-migration of all instances to others hosts to take a hypervisor"}],"source_content_type":"text/x-rst","patch_set":2,"id":"420285db_d309358b","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":7},"updated":"2023-01-05 14:35:25.000000000","message":"nit: typo","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7835e38a190afa66eaddc59ffddbddd66bc55087","unresolved":false,"context_lines":[{"line_number":48,"context_line":"on a volume:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"1. For cloud operators - Currently the re-attachment change of a volume as it"},{"line_number":51,"context_line":"appens during an instance live-migration is blocked by a concurrently run volume"},{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"},{"line_number":54,"context_line":"such as the live-migration of all instances to others hosts to take a hypervisor"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ac8782b2_8a137b5f","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":7},"in_reply_to":"420285db_d309358b","updated":"2023-02-23 13:13:45.000000000","message":"Done","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e81a7cc758a3d7e5fa9fed54d21c45f87f9d400d","unresolved":true,"context_lines":[{"line_number":325,"context_line":"Documentation Impact"},{"line_number":326,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"* Add release notes to"},{"line_number":329,"context_line":"* Document the state-machines for the volume itself and backup and"},{"line_number":330,"context_line":"  restore tasks."},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"6808945a_2b426271","line":328,"range":{"start_line":328,"start_character":20,"end_line":328,"end_character":22},"updated":"2023-01-05 14:35:25.000000000","message":"nit: add colon here and this line should not be a bullet-point","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7835e38a190afa66eaddc59ffddbddd66bc55087","unresolved":false,"context_lines":[{"line_number":325,"context_line":"Documentation Impact"},{"line_number":326,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"* Add release notes to"},{"line_number":329,"context_line":"* Document the state-machines for the volume itself and backup and"},{"line_number":330,"context_line":"  restore tasks."},{"line_number":331,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7ba3f4e9_4f423c7c","line":328,"range":{"start_line":328,"start_character":20,"end_line":328,"end_character":22},"in_reply_to":"6808945a_2b426271","updated":"2023-02-23 13:13:45.000000000","message":"\u003e nit: add colon here and this line should not be a bullet-point\n\nI change this to a proper bullet-point as the release notes clearly should cover this kind of change explicitly.","commit_id":"9631a2eca22be53de0f86277380eaa73b50c501c"}],"specs/2023.2/.vscode/settings.json":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"54f90eb794bf369a9cd01928b279e9495c2e68f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"755a56f4_6e09a6f2","updated":"2023-04-21 14:32:59.000000000","message":"Maybe I\u0027m missing something but do we need this file?","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e49bf58a7e0e31768da9c10cddb893d50747bdb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4bf0f427_9ba0e076","in_reply_to":"755a56f4_6e09a6f2","updated":"2023-04-23 17:33:36.000000000","message":"Ack, sorry about that.\n\nApart from this accidentally added file - is there any way forward reviewing and accepting this?","commit_id":"7bd171819bcdc09f91bf323fb539621279450881"}],"specs/2023.2/dedicated-volume-backup-status-field.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronisation mechanism to"},{"line_number":25,"context_line":"have only one task act on a volume at any one time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"While this is helpful for coordinating tasks affecting the volume itself,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"71dbf02b_86765827","line":24,"range":{"start_line":24,"start_character":50,"end_line":24,"end_character":65},"updated":"2023-05-04 07:01:53.000000000","message":"typo: synchronization","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronisation mechanism to"},{"line_number":25,"context_line":"have only one task act on a volume at any one time."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"While this is helpful for coordinating tasks affecting the volume itself,"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa91ca_2e09b440","line":24,"range":{"start_line":24,"start_character":50,"end_line":24,"end_character":65},"in_reply_to":"71dbf02b_86765827","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"  backed up in full and even if the backup was running at 1 GB/s the"},{"line_number":38,"context_line":"  volume backup will still take ~2.5 hrs to complete. Decoupling this from a state"},{"line_number":39,"context_line":"  machine perspective (since it already is for most drivers / implementations"},{"line_number":40,"context_line":"  which work via snapshots) seems be quite beneficial."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"08713760_6ca43ac4","line":40,"range":{"start_line":40,"start_character":28,"end_line":40,"end_character":36},"updated":"2023-05-04 07:01:53.000000000","message":"nit: seems to be","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  backed up in full and even if the backup was running at 1 GB/s the"},{"line_number":38,"context_line":"  volume backup will still take ~2.5 hrs to complete. Decoupling this from a state"},{"line_number":39,"context_line":"  machine perspective (since it already is for most drivers / implementations"},{"line_number":40,"context_line":"  which work via snapshots) seems be quite beneficial."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"675d8261_292a14a7","line":40,"range":{"start_line":40,"start_character":28,"end_line":40,"end_character":36},"in_reply_to":"08713760_6ca43ac4","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"},{"line_number":54,"context_line":"such as the live-migration of all instances to others hosts to take a hypervisor"},{"line_number":55,"context_line":"down for maintainance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provided sufficiently large volumes or slow backup transfer rates this could"},{"line_number":58,"context_line":"cause users to \"lock out\" administrative tasks indefinately."}],"source_content_type":"text/x-rst","patch_set":4,"id":"68055d82_bc5c2ad9","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":21},"updated":"2023-05-04 07:01:53.000000000","message":"typo: maintenance","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"},{"line_number":54,"context_line":"such as the live-migration of all instances to others hosts to take a hypervisor"},{"line_number":55,"context_line":"down for maintainance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provided sufficiently large volumes or slow backup transfer rates this could"},{"line_number":58,"context_line":"cause users to \"lock out\" administrative tasks indefinately."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fb5f1dd3_7c64820b","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":21},"in_reply_to":"68055d82_bc5c2ad9","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":55,"context_line":"down for maintainance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provided sufficiently large volumes or slow backup transfer rates this could"},{"line_number":58,"context_line":"cause users to \"lock out\" administrative tasks indefinately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"2. For cloud users - Urgent operational tasks are blocked by an active backup"},{"line_number":61,"context_line":"task currently. A running backup blocking the users ability to quickly resize a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e1891574_23795f35","line":58,"range":{"start_line":58,"start_character":47,"end_line":58,"end_character":59},"updated":"2023-05-04 07:01:53.000000000","message":"typo: indefinitely","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":55,"context_line":"down for maintainance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Provided sufficiently large volumes or slow backup transfer rates this could"},{"line_number":58,"context_line":"cause users to \"lock out\" administrative tasks indefinately."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"2. For cloud users - Urgent operational tasks are blocked by an active backup"},{"line_number":61,"context_line":"task currently. A running backup blocking the users ability to quickly resize a"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ab5d456d_bc82684f","line":58,"range":{"start_line":58,"start_character":47,"end_line":58,"end_character":59},"in_reply_to":"e1891574_23795f35","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":60,"context_line":"2. For cloud users - Urgent operational tasks are blocked by an active backup"},{"line_number":61,"context_line":"task currently. A running backup blocking the users ability to quickly resize a"},{"line_number":62,"context_line":"volume that is running low of available space or attach it to another instance."},{"line_number":63,"context_line":"This issue is worsend if the backup tasks is even triggered by the cloud"},{"line_number":64,"context_line":"provider or some automatic scheduling."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"4152d19f_9efeb21a","line":63,"range":{"start_line":63,"start_character":14,"end_line":63,"end_character":21},"updated":"2023-05-04 07:01:53.000000000","message":"worsened","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":60,"context_line":"2. For cloud users - Urgent operational tasks are blocked by an active backup"},{"line_number":61,"context_line":"task currently. A running backup blocking the users ability to quickly resize a"},{"line_number":62,"context_line":"volume that is running low of available space or attach it to another instance."},{"line_number":63,"context_line":"This issue is worsend if the backup tasks is even triggered by the cloud"},{"line_number":64,"context_line":"provider or some automatic scheduling."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"06ccc4f1_a39c6fac","line":63,"range":{"start_line":63,"start_character":14,"end_line":63,"end_character":21},"in_reply_to":"4152d19f_9efeb21a","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":88,"context_line":"------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"There was a discussion around a spec [1] moving all task"},{"line_number":91,"context_line":"status to a new field. This ended up being way to complex and not really"},{"line_number":92,"context_line":"suitable for the described use-cases of decoupling volume backups."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"08409af3_0230f88e","line":91,"range":{"start_line":91,"start_character":47,"end_line":91,"end_character":49},"updated":"2023-05-04 07:01:53.000000000","message":"too","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":88,"context_line":"------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"There was a discussion around a spec [1] moving all task"},{"line_number":91,"context_line":"status to a new field. This ended up being way to complex and not really"},{"line_number":92,"context_line":"suitable for the described use-cases of decoupling volume backups."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d26098c9_4922a946","line":91,"range":{"start_line":91,"start_character":47,"end_line":91,"end_character":49},"in_reply_to":"08409af3_0230f88e","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"989779883811f7e0b3f893571c1c8ef5510acdb1","unresolved":true,"context_lines":[{"line_number":259,"context_line":"Work Items"},{"line_number":260,"context_line":"----------"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* Split up the status filed to the above mentioned status and backup_status"},{"line_number":263,"context_line":"  fields"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Data model in python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ab6509b3_6fd8ac71","line":262,"range":{"start_line":262,"start_character":22,"end_line":262,"end_character":27},"updated":"2023-05-04 07:01:53.000000000","message":"field","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"438c081113e47322255e6eb22f032ba670821372","unresolved":false,"context_lines":[{"line_number":259,"context_line":"Work Items"},{"line_number":260,"context_line":"----------"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"* Split up the status filed to the above mentioned status and backup_status"},{"line_number":263,"context_line":"  fields"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Data model in python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"77bebaa8_7ef31ca4","line":262,"range":{"start_line":262,"start_character":22,"end_line":262,"end_character":27},"in_reply_to":"ab6509b3_6fd8ac71","updated":"2023-05-04 19:12:05.000000000","message":"Done","commit_id":"d09f77bc62f7074bdb1f98094b56a1e1f3924a8c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume tasks such as re-attachments currently."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"95b2860e_919c50bc","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":38},"updated":"2023-06-09 15:21:30.000000000","message":"what do we mean by re-attachments here?\nI think what we\u0027re trying to convey is the backup status \u0027backing-up\u0027 disallows volume to be used for attachment workflow i.e. \u0027reserved\u0027, \u0027attaching\u0027, \u0027in-use\u0027 etc for other operations","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume tasks such as re-attachments currently."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1bfdc575_35f9c62c","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":38},"in_reply_to":"95b2860e_919c50bc","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume tasks such as re-attachments currently."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2f2432dd_6f9934ca","line":15,"updated":"2023-06-09 15:21:30.000000000","message":"nit: too many blank lines","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume tasks such as re-attachments currently."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3aa4ddbd_61040e30","line":15,"in_reply_to":"2f2432dd_6f9934ca","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."}],"source_content_type":"text/x-rst","patch_set":5,"id":"be21016d_97a095ef","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":49},"updated":"2023-06-09 15:21:30.000000000","message":"do we have this as a convention anywhere? I think it\u0027s the \u0027status\u0027 field so we can say it as\n\nvolume\u0027s `status` field","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."}],"source_content_type":"text/x-rst","patch_set":5,"id":"f9833277_f6f3df3e","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":49},"in_reply_to":"6286d797_2dfcbd7c","updated":"2024-04-16 09:08:19.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Problem description"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."}],"source_content_type":"text/x-rst","patch_set":5,"id":"6286d797_2dfcbd7c","line":20,"range":{"start_line":20,"start_character":36,"end_line":20,"end_character":49},"in_reply_to":"be21016d_97a095ef","updated":"2023-06-12 20:10:34.000000000","message":"I am referring to this kind of logic in the API looking at expected status - https://opendev.org/openstack/cinder/src/commit/d7ae9610d765919660a9f7a8769478f0b6e0aadf/cinder/volume/api.py#L755","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronization mechanism to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a9b9235f_de9c6b2d","line":21,"range":{"start_line":21,"start_character":29,"end_line":21,"end_character":37},"updated":"2023-06-09 15:21:30.000000000","message":"maybe it\u0027s just me but this sounds like we are launching a service, container or something. Can we reword this sentence as,\n\nCurrently all cinder tasks use the `status` field to check for suitable\nvolume status while performing any particular operation.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronization mechanism to"}],"source_content_type":"text/x-rst","patch_set":5,"id":"831ca504_7281ab0c","line":21,"range":{"start_line":21,"start_character":29,"end_line":21,"end_character":37},"in_reply_to":"a9b9235f_de9c6b2d","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronization mechanism to"},{"line_number":25,"context_line":"have only one task act on a volume at any one time."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"fc417167_2cdf34a7","line":23,"range":{"start_line":23,"start_character":5,"end_line":23,"end_character":65},"updated":"2023-06-09 15:21:30.000000000","message":"This is not always the case. we also have attached-status and migration-status fields that are for specific operations. Although the modify the volume status, the volume status alone can\u0027t provide details about the whole operation.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Currently all cinder tasks use the `volume_status` field to check for suitable"},{"line_number":21,"context_line":"volume status prior to being launched. During the active phase of a task, its"},{"line_number":22,"context_line":"status is also held and updated via the same volume status field. And finally"},{"line_number":23,"context_line":"also errors thrown by a task are communicated back via this field."},{"line_number":24,"context_line":"This single field in essence creates a locking or synchronization mechanism to"},{"line_number":25,"context_line":"have only one task act on a volume at any one time."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"56ad26d3_63574b1c","line":23,"range":{"start_line":23,"start_character":5,"end_line":23,"end_character":65},"in_reply_to":"fc417167_2cdf34a7","updated":"2023-06-12 20:10:34.000000000","message":"True. But the argument is more about describing how the field covers quite a bit of the whole \"state machine\" for a volume and any tasks happening on it.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":27,"context_line":"While this is helpful for coordinating tasks affecting the volume itself,"},{"line_number":28,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups do"},{"line_number":31,"context_line":"  not techically relate to each other. The backup-driver and block device-driver"},{"line_number":32,"context_line":"  act independently and backups are read off a dedicated volume snapshot not"},{"line_number":33,"context_line":"  affecting the volume itself."}],"source_content_type":"text/x-rst","patch_set":5,"id":"a14d7164_8eac39b2","line":30,"range":{"start_line":30,"start_character":69,"end_line":30,"end_character":76},"updated":"2023-06-09 15:21:30.000000000","message":"can we also mention the state as an example here,\n\nbackups (backing-up)","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":27,"context_line":"While this is helpful for coordinating tasks affecting the volume itself,"},{"line_number":28,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups do"},{"line_number":31,"context_line":"  not techically relate to each other. The backup-driver and block device-driver"},{"line_number":32,"context_line":"  act independently and backups are read off a dedicated volume snapshot not"},{"line_number":33,"context_line":"  affecting the volume itself."}],"source_content_type":"text/x-rst","patch_set":5,"id":"2631394f_2a2712f9","line":30,"range":{"start_line":30,"start_character":69,"end_line":30,"end_character":76},"in_reply_to":"a14d7164_8eac39b2","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups do"},{"line_number":31,"context_line":"  not techically relate to each other. The backup-driver and block device-driver"},{"line_number":32,"context_line":"  act independently and backups are read off a dedicated volume snapshot not"},{"line_number":33,"context_line":"  affecting the volume itself."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":5,"id":"d836a361_24bab9d3","line":32,"range":{"start_line":32,"start_character":47,"end_line":32,"end_character":72},"updated":"2023-06-09 15:21:30.000000000","message":"actually we create a volume or snapshot from the main volume depending on the value of config option \u0027backup_use_temp_snapshot\u0027.\nIf it\u0027s true we create snapshots else we clone the volume.\n\nNot that it matters a lot here but i think it\u0027s useful to provide correct information relating to the workflow.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups do"},{"line_number":31,"context_line":"  not techically relate to each other. The backup-driver and block device-driver"},{"line_number":32,"context_line":"  act independently and backups are read off a dedicated volume snapshot not"},{"line_number":33,"context_line":"  affecting the volume itself."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":5,"id":"99a51fdf_a78c6be8","line":32,"range":{"start_line":32,"start_character":47,"end_line":32,"end_character":72},"in_reply_to":"d836a361_24bab9d3","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":47,"context_line":"There are two sides to the use-cases of decoupling backup tasks from other tasks"},{"line_number":48,"context_line":"on a volume:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"1. For cloud operators - Currently the re-attachment change of a volume as it"},{"line_number":51,"context_line":"happens during an instance live-migration is blocked by a concurrently run volume"},{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5b736a50_fa2534ed","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":52},"updated":"2023-06-09 15:21:30.000000000","message":"I think we should avoid using this term since it\u0027s not a known cinder terminology. We can probably describe it briefly as,\n\nCurrently detaching volume from source compute node and attaching it to the destination compute node during an instance live-migration is...","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":47,"context_line":"There are two sides to the use-cases of decoupling backup tasks from other tasks"},{"line_number":48,"context_line":"on a volume:"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"1. For cloud operators - Currently the re-attachment change of a volume as it"},{"line_number":51,"context_line":"happens during an instance live-migration is blocked by a concurrently run volume"},{"line_number":52,"context_line":"backup. To make matters worse, the potentially long running backup (task) could"},{"line_number":53,"context_line":"also have been triggered by the user and then be blocking administrative actions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"66815925_d754254b","line":50,"range":{"start_line":50,"start_character":39,"end_line":50,"end_character":52},"in_reply_to":"5b736a50_fa2534ed","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"For volumes there shall be field `backup_status` to hold the backup related"},{"line_number":72,"context_line":"values currently stored in `volume_status`:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* \u0027backing-up\u0027"},{"line_number":75,"context_line":"* \u0027error_backing-up\u0027"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2ac677df_d69ac9e4","line":72,"range":{"start_line":72,"start_character":28,"end_line":72,"end_character":41},"updated":"2023-06-09 15:21:30.000000000","message":"it\u0027s the \u0027status\u0027 field","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"For volumes there shall be field `backup_status` to hold the backup related"},{"line_number":72,"context_line":"values currently stored in `volume_status`:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* \u0027backing-up\u0027"},{"line_number":75,"context_line":"* \u0027error_backing-up\u0027"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a3fc00cb_5884aa6f","line":72,"range":{"start_line":72,"start_character":28,"end_line":72,"end_character":41},"in_reply_to":"2ac677df_d69ac9e4","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":76,"context_line":"* \u0027restoring-backup\u0027"},{"line_number":77,"context_line":"* \u0027error_restoring\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Those shall then be removed from the list of (valid) values of `volume_status`"},{"line_number":80,"context_line":"and be values for `backup_status`."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"There will be some changes to the conditional checks for certain tasks to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8a5e157f_0dc57fa2","line":79,"range":{"start_line":79,"start_character":64,"end_line":79,"end_character":77},"updated":"2023-06-09 15:21:30.000000000","message":"status","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* \u0027restoring-backup\u0027"},{"line_number":77,"context_line":"* \u0027error_restoring\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Those shall then be removed from the list of (valid) values of `volume_status`"},{"line_number":80,"context_line":"and be values for `backup_status`."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"There will be some changes to the conditional checks for certain tasks to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7c834e84_f61f2696","line":79,"range":{"start_line":79,"start_character":64,"end_line":79,"end_character":77},"in_reply_to":"8a5e157f_0dc57fa2","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b73dd8d75942f03ca904cbafe7e81d49210ec32b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"There will be some changes to the conditional checks for certain tasks to be"},{"line_number":83,"context_line":"started, but most usually depend on those volume status values that would remain"},{"line_number":84,"context_line":"in the volume_status field anyways."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"d4d5250d_6ec3def0","line":85,"updated":"2023-06-09 20:01:10.000000000","message":"Maybe I\u0027m not thinking of this the right way, but isn\u0027t there an asymmetry between backup and restore?  What I mean is:\n\nbackup - basically, take a snapshot of the volume, then you should be able to do anything you want with the volume while the snapshot is being used to upload backup data to the backup backend\n\nrestore - by hypothesis, the volume data isn\u0027t available in the volume backend, so if I\u0027m restoring an 8TB backup, I can\u0027t really use the volume until the data is restored to it\n\nSo it doesn\u0027t seem like we can move all four values (backing-up, error_backing-up, restoring-backup, error_restoring) out of the volume_status and into the backup_status.  For the restore case, I think we do need some kind of volume_status to indicate that the volume isn\u0027t ready yet.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":82,"context_line":"There will be some changes to the conditional checks for certain tasks to be"},{"line_number":83,"context_line":"started, but most usually depend on those volume status values that would remain"},{"line_number":84,"context_line":"in the volume_status field anyways."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Alternatives"},{"line_number":88,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"91945894_426235e3","line":85,"in_reply_to":"d4d5250d_6ec3def0","updated":"2023-06-12 20:10:34.000000000","message":"Very good point. The change is about externalizing the backup status, NOT the restore. Either it\u0027s a new volume that is created out of a backup and that volume is then \"restoring\" until the restore is done. Or it\u0027s the original volume that is restored to, then the volume is also restoring and cannot be used (independently) until this process is done.\n\nIn the implementation section there already was a volume status of \"restoring\" mentioned, but I removed \"restoring-backup\" and \"error_restoring\" from the newly suggested field backup_status","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":104,"context_line":"* This change is then followed by an online update/upgrade to split up the"},{"line_number":105,"context_line":"  \"moved out\" status related to backups in their newly dedicated fields."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* The valid values for volume_status would then also have to be reduced."},{"line_number":108,"context_line":"  https://opendev.org/openstack/cinder/src/commit/5c23c9fbe41baef22a71eac4406fd9db269d1271/cinder/objects/fields.py#L168-L190"},{"line_number":109,"context_line":"  As the status `backing-up`, `restoring-backup`, `error_backing-up` and"},{"line_number":110,"context_line":"  `error_restoring` are only to be stored in the backup status."}],"source_content_type":"text/x-rst","patch_set":5,"id":"85ab925c_9c763cc3","line":107,"range":{"start_line":107,"start_character":23,"end_line":107,"end_character":36},"updated":"2023-06-09 15:21:30.000000000","message":"nit: volume status","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* This change is then followed by an online update/upgrade to split up the"},{"line_number":105,"context_line":"  \"moved out\" status related to backups in their newly dedicated fields."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"* The valid values for volume_status would then also have to be reduced."},{"line_number":108,"context_line":"  https://opendev.org/openstack/cinder/src/commit/5c23c9fbe41baef22a71eac4406fd9db269d1271/cinder/objects/fields.py#L168-L190"},{"line_number":109,"context_line":"  As the status `backing-up`, `restoring-backup`, `error_backing-up` and"},{"line_number":110,"context_line":"  `error_restoring` are only to be stored in the backup status."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5922a0de_e4dec122","line":107,"range":{"start_line":107,"start_character":23,"end_line":107,"end_character":36},"in_reply_to":"85ab925c_9c763cc3","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":124,"context_line":"introduced."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In general the translation layer will translate from"},{"line_number":127,"context_line":"(status, backup_status) -\u003e status and status -\u003e (status, backup_status) to"},{"line_number":128,"context_line":"maintain compatibility with older clients expecting all states to be in just one"},{"line_number":129,"context_line":"status field."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"f0111c30_2246c9bd","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":71},"updated":"2023-06-09 15:21:30.000000000","message":"I don\u0027t completely understand this translation? can you explain\nIn the old microversion, only the status field will be there and in new MV, there will be two fields so the translation should be from backup_status field to status field.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[{"line_number":124,"context_line":"introduced."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In general the translation layer will translate from"},{"line_number":127,"context_line":"(status, backup_status) -\u003e status and status -\u003e (status, backup_status) to"},{"line_number":128,"context_line":"maintain compatibility with older clients expecting all states to be in just one"},{"line_number":129,"context_line":"status field."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"70f0bf3e_6cf558c9","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":71},"in_reply_to":"869fe7af_ad010aed","updated":"2024-04-16 09:08:19.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":true,"context_lines":[{"line_number":124,"context_line":"introduced."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"In general the translation layer will translate from"},{"line_number":127,"context_line":"(status, backup_status) -\u003e status and status -\u003e (status, backup_status) to"},{"line_number":128,"context_line":"maintain compatibility with older clients expecting all states to be in just one"},{"line_number":129,"context_line":"status field."},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"869fe7af_ad010aed","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":71},"in_reply_to":"f0111c30_2246c9bd","updated":"2023-06-12 20:10:34.000000000","message":"Good point. This was confusing. I suppose any translation should only be required for the older micro-versions, presenting all status via the single field \"status\".\n\nI did change the section a bit to make this clear.\n\n\nBut to start a bit of a discussion around this.\n\nSince, after this spec is implemented, a volume can be in \"attaching\" and \"backing up\" at the same time ... there really seems to be no way to make this translation perfect with just a single field to return. This is due to the nature of de-coupling this.\n\nSo question then is: Which value has priority over other values?","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":129,"context_line":"status field."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"The additional field of a backup_status would need to be sent to the user. The"},{"line_number":132,"context_line":"valid status of a volume would only allow the reduced set. In addition"},{"line_number":133,"context_line":"endpoints have to be created to update the backup_status (by the admin only,"},{"line_number":134,"context_line":"like the current update status endpoints)."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"**NOTE**: The list of endpoints to be changed is based on the current proposed"},{"line_number":137,"context_line":"change and is subject to change."}],"source_content_type":"text/x-rst","patch_set":5,"id":"0e8dca2b_295b09ac","line":134,"range":{"start_line":132,"start_character":59,"end_line":134,"end_character":42},"updated":"2023-06-09 15:21:30.000000000","message":"I think this can be covered in the reset-state command?","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":129,"context_line":"status field."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"The additional field of a backup_status would need to be sent to the user. The"},{"line_number":132,"context_line":"valid status of a volume would only allow the reduced set. In addition"},{"line_number":133,"context_line":"endpoints have to be created to update the backup_status (by the admin only,"},{"line_number":134,"context_line":"like the current update status endpoints)."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"**NOTE**: The list of endpoints to be changed is based on the current proposed"},{"line_number":137,"context_line":"change and is subject to change."}],"source_content_type":"text/x-rst","patch_set":5,"id":"02ac2d87_c3f4f8b1","line":134,"range":{"start_line":132,"start_character":59,"end_line":134,"end_character":42},"in_reply_to":"0e8dca2b_295b09ac","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b73dd8d75942f03ca904cbafe7e81d49210ec32b","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* List volumes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  * show additional field for the task_status"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  * additional filter for the task_status"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ad47af1_cdb67d25","line":145,"range":{"start_line":145,"start_character":34,"end_line":145,"end_character":45},"updated":"2023-06-09 20:01:10.000000000","message":"Do you mean \u0027backup_status\u0027 here, or is your idea to keep the name general for possible expansion to other volume processes?","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* List volumes"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  * show additional field for the task_status"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"  * additional filter for the task_status"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"de5492af_35fe2c90","line":145,"range":{"start_line":145,"start_character":34,"end_line":145,"end_character":45},"in_reply_to":"1ad47af1_cdb67d25","updated":"2023-06-12 20:10:34.000000000","message":"No, I meant to say \"backup_status\" here. Thanks for noticing!","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Unset volume backup_status"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Security impact"},{"line_number":167,"context_line":"---------------"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bbefe469_b48fdf1e","line":165,"updated":"2023-06-09 15:21:30.000000000","message":"can we also add a volume response JSON body?\nIt should be same as volume show but with additional backup_status field","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Unset volume backup_status"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Security impact"},{"line_number":167,"context_line":"---------------"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"f0877fbe_7c931099","line":165,"in_reply_to":"bbefe469_b48fdf1e","updated":"2023-06-12 20:10:34.000000000","message":"You mean like a full example as in the API documentation at https://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003dget-volumes-summary-detail,show-a-volume-s-details-detail#show-a-volume-s-details ?\n\nGladly added.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":195,"context_line":"----------------"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"The state of a volume can only be set to the reduced list of status."},{"line_number":198,"context_line":"All other status have to be set to the task_status field."},{"line_number":199,"context_line":"In addition a backup_status can be added, updated or removed to only the"},{"line_number":200,"context_line":"list of valid backup_status."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"2d4058d0_adda3419","line":198,"range":{"start_line":198,"start_character":39,"end_line":198,"end_character":50},"updated":"2023-06-09 15:21:30.000000000","message":"you mean backup_status field?","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":195,"context_line":"----------------"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"The state of a volume can only be set to the reduced list of status."},{"line_number":198,"context_line":"All other status have to be set to the task_status field."},{"line_number":199,"context_line":"In addition a backup_status can be added, updated or removed to only the"},{"line_number":200,"context_line":"list of valid backup_status."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"2cb0e4e4_22e75892","line":198,"range":{"start_line":198,"start_character":39,"end_line":198,"end_character":50},"in_reply_to":"2d4058d0_adda3419","updated":"2023-06-12 20:10:34.000000000","message":"I removed this sentence. The next one explained it already.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":239,"context_line":"* Reject volume deletion while volume is currently being backed up"},{"line_number":240,"context_line":"* Reject concurrent backups of a volume if one is already in progress"},{"line_number":241,"context_line":"* Reject volume or \"block storage\" migration if a backup is currently running"},{"line_number":242,"context_line":"* Return a volume status of `restoring` when there is a backup being restored to"},{"line_number":243,"context_line":"  this particular volume."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ef6b2a24_61aa23be","line":243,"range":{"start_line":242,"start_character":0,"end_line":243,"end_character":25},"updated":"2023-06-09 15:21:30.000000000","message":"are we only planning to move backup states in the backup_status field? also currently we have the \u0027restoring\u0027 state in volume stats, did you mean backup_status?","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":239,"context_line":"* Reject volume deletion while volume is currently being backed up"},{"line_number":240,"context_line":"* Reject concurrent backups of a volume if one is already in progress"},{"line_number":241,"context_line":"* Reject volume or \"block storage\" migration if a backup is currently running"},{"line_number":242,"context_line":"* Return a volume status of `restoring` when there is a backup being restored to"},{"line_number":243,"context_line":"  this particular volume."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"96a8811a_ab0ac8c3","line":243,"range":{"start_line":242,"start_character":0,"end_line":243,"end_character":25},"in_reply_to":"ef6b2a24_61aa23be","updated":"2023-06-12 20:10:34.000000000","message":"Yes, absolutely. Just like Brian mentioned, restore status are kept in the volume status, as this is really a state of the volume itself and not some independent snapshot or clone.\n\nI removed this detail as returning \"restoring\" via the volume state just remains as is currently - this is NOT part of any new implementation.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Assignee(s)"},{"line_number":251,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"afa83431_cd700200","line":248,"updated":"2023-06-09 15:21:30.000000000","message":"nit: too many blank lines","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Assignee(s)"},{"line_number":251,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ccb907fa_0c54326c","line":248,"in_reply_to":"afa83431_cd700200","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":262,"context_line":"* Split up the status field to the above mentioned status and backup_status"},{"line_number":263,"context_line":"  fields"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Data model in python"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * Sql data model and constraints"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  * additional method(s) for the model to allow a online migration of the database"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5065221b_6151a836","line":267,"range":{"start_line":265,"start_character":0,"end_line":267,"end_character":34},"updated":"2023-06-09 15:21:30.000000000","message":"can we be specific with the work items? like adding a backup_status field in the volumes table","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":262,"context_line":"* Split up the status field to the above mentioned status and backup_status"},{"line_number":263,"context_line":"  fields"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"  * Data model in python"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  * Sql data model and constraints"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"  * additional method(s) for the model to allow a online migration of the database"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"6f30aa92_be21eca2","line":267,"range":{"start_line":265,"start_character":0,"end_line":267,"end_character":34},"in_reply_to":"5065221b_6151a836","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* Introduce the API-Layer as a translator to serve older micro versions"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"* Change the API-endpoints including query parameters"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* Documentation"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"8983b128_1fd2afed","line":280,"range":{"start_line":280,"start_character":0,"end_line":280,"end_character":53},"updated":"2023-06-09 15:21:30.000000000","message":"i still think this should be a part of reset-state operation","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"* Introduce the API-Layer as a translator to serve older micro versions"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"* Change the API-endpoints including query parameters"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* Documentation"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"4eab6759_9b1cd034","line":280,"range":{"start_line":280,"start_character":0,"end_line":280,"end_character":53},"in_reply_to":"8983b128_1fd2afed","updated":"2023-06-12 20:10:34.000000000","message":"Ack","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":278,"context_line":"* Introduce the API-Layer as a translator to serve older micro versions"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"* Change the API-endpoints including query parameters"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* Documentation"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  * Breaking changes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f947a1cd_ffeba53c","line":281,"updated":"2023-06-09 15:21:30.000000000","message":"One item: Introduce a new microversion to allow backups to be performed in isolation from other operations that use volume\u0027s status field as a locking mechanism.","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":278,"context_line":"* Introduce the API-Layer as a translator to serve older micro versions"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"* Change the API-endpoints including query parameters"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"* Documentation"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  * Breaking changes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b6ac25ed_52743bec","line":281,"in_reply_to":"f947a1cd_ffeba53c","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":308,"context_line":"Testing"},{"line_number":309,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"* Since only a reduced set of states are handled via the `volume_status` field"},{"line_number":312,"context_line":"  and with `backup_status` newly introduced field, some functional tests"},{"line_number":313,"context_line":"  have to be adapted to use the new data model."},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"c400920a_3d52f2a9","line":311,"range":{"start_line":311,"start_character":58,"end_line":311,"end_character":71},"updated":"2023-06-09 15:21:30.000000000","message":"status","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":308,"context_line":"Testing"},{"line_number":309,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"* Since only a reduced set of states are handled via the `volume_status` field"},{"line_number":312,"context_line":"  and with `backup_status` newly introduced field, some functional tests"},{"line_number":313,"context_line":"  have to be adapted to use the new data model."},{"line_number":314,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"de102f83_c518ee1d","line":311,"range":{"start_line":311,"start_character":58,"end_line":311,"end_character":71},"in_reply_to":"c400920a_3d52f2a9","updated":"2023-06-12 20:10:34.000000000","message":"Ack","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c3490c3addfafb397febed7d9b61c8b9c98b56ae","unresolved":true,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"* Further tests have to be added to ensure the translation layer for older API"},{"line_number":316,"context_line":"  microversions work as expected. E.g. the backup status is presented via either"},{"line_number":317,"context_line":"  `volume_status` for an older microversion and then via `backup_status` for the"},{"line_number":318,"context_line":"  new version."},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"* Because the `conditional_update`` method needs to support versioning in this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c8d0cfb7_9d96d23d","line":317,"range":{"start_line":317,"start_character":3,"end_line":317,"end_character":16},"updated":"2023-06-09 15:21:30.000000000","message":"nit: status","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"* Further tests have to be added to ensure the translation layer for older API"},{"line_number":316,"context_line":"  microversions work as expected. E.g. the backup status is presented via either"},{"line_number":317,"context_line":"  `volume_status` for an older microversion and then via `backup_status` for the"},{"line_number":318,"context_line":"  new version."},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"* Because the `conditional_update`` method needs to support versioning in this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4297d771_9e313660","line":317,"range":{"start_line":317,"start_character":3,"end_line":317,"end_character":16},"in_reply_to":"c8d0cfb7_9d96d23d","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b73dd8d75942f03ca904cbafe7e81d49210ec32b","unresolved":true,"context_lines":[{"line_number":338,"context_line":"References"},{"line_number":339,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"[1] Previously propoesed spec to add a task status: https://review.opendev.org/c/openstack/cinder-specs/+/818551"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6f394fe1_3e52ec51","line":341,"range":{"start_line":341,"start_character":15,"end_line":341,"end_character":24},"updated":"2023-06-09 20:01:10.000000000","message":"proposed","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"30fd50e4007dd57af631132d0e0c90f3bbcabf23","unresolved":false,"context_lines":[{"line_number":338,"context_line":"References"},{"line_number":339,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"[1] Previously propoesed spec to add a task status: https://review.opendev.org/c/openstack/cinder-specs/+/818551"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"History"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c6f44769_dbb752c3","line":341,"range":{"start_line":341,"start_character":15,"end_line":341,"end_character":24},"in_reply_to":"6f394fe1_3e52ec51","updated":"2023-06-12 20:10:34.000000000","message":"Done","commit_id":"39b8be033e6eb2767022944faed5c1762647ef3b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume attachment workflows i.e. \u0027reserved\u0027, \u0027attaching\u0027, \u0027in-use\u0027, etc."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"52d042d0_790aec13","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":75},"updated":"2023-06-20 20:26:09.000000000","message":"not exactly what i wanted here but should be good. if you do an update, we can leave it upto \"... attachment workflow.\"","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"c4afe667293e5e1bd3d49b242cfa8454337137ec","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This spec proposes to introduce a new `backup_status` field for volumes"},{"line_number":12,"context_line":"to remove the blocking or serialization that active backup tasks impose"},{"line_number":13,"context_line":"on volume attachment workflows i.e. \u0027reserved\u0027, \u0027attaching\u0027, \u0027in-use\u0027, etc."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bafb183e_4b0c4015","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":75},"in_reply_to":"52d042d0_790aec13","updated":"2023-06-21 13:28:26.000000000","message":"Done","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently all cinder tasks use the status field to check for suitable"},{"line_number":20,"context_line":"volume status while performing any particular operation. During the active phase"},{"line_number":21,"context_line":"of a task, its status is also held and updated via the same volume status field."},{"line_number":22,"context_line":"And finally also certain errors thrown by a task are communicated back via this"},{"line_number":23,"context_line":"field. This single field in essence creates a locking or synchronization"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ea368c95_397a6bcf","line":20,"range":{"start_line":20,"start_character":7,"end_line":20,"end_character":13},"updated":"2023-06-20 20:26:09.000000000","message":"nit: can be enclosed in double back quotes (`) to highlight it","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently all cinder tasks use the status field to check for suitable"},{"line_number":20,"context_line":"volume status while performing any particular operation. During the active phase"},{"line_number":21,"context_line":"of a task, its status is also held and updated via the same volume status field."},{"line_number":22,"context_line":"And finally also certain errors thrown by a task are communicated back via this"},{"line_number":23,"context_line":"field. This single field in essence creates a locking or synchronization"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4af2c30f_97e3c6b8","line":20,"range":{"start_line":20,"start_character":7,"end_line":20,"end_character":13},"in_reply_to":"ea368c95_397a6bcf","updated":"2024-04-16 09:08:19.000000000","message":"Acknowledged","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":true,"context_lines":[{"line_number":27,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."}],"source_content_type":"text/x-rst","patch_set":6,"id":"983c2cf7_048adb9c","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"updated":"2023-06-20 20:26:09.000000000","message":"nit: redundant word","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"c4afe667293e5e1bd3d49b242cfa8454337137ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."}],"source_content_type":"text/x-rst","patch_set":6,"id":"20559b9d_3c16d389","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"in_reply_to":"983c2cf7_048adb9c","updated":"2023-06-21 13:28:26.000000000","message":"Done","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":true,"context_lines":[{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0863acb1_57008dae","line":32,"range":{"start_line":32,"start_character":41,"end_line":32,"end_character":42},"updated":"2023-06-20 20:26:09.000000000","message":"can we use double back quotes (`) instead of single ones, it highlights text in rst","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df847336571b71ac1849f3290e32902b86075411","unresolved":true,"context_lines":[{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6bc55ceb_f787de7d","line":32,"range":{"start_line":32,"start_character":66,"end_line":32,"end_character":67},"updated":"2023-06-20 20:26:09.000000000","message":"same","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"c4afe667293e5e1bd3d49b242cfa8454337137ec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":6,"id":"54151938_7a0ead6b","line":32,"range":{"start_line":32,"start_character":41,"end_line":32,"end_character":42},"in_reply_to":"0863acb1_57008dae","updated":"2023-06-21 13:28:26.000000000","message":"Done","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"c4afe667293e5e1bd3d49b242cfa8454337137ec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option \u0027backup_use_temp_snapshot\u0027 is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c9d13fce_6e663d99","line":32,"range":{"start_line":32,"start_character":66,"end_line":32,"end_character":67},"in_reply_to":"6bc55ceb_f787de7d","updated":"2023-06-21 13:28:26.000000000","message":"Done","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ab2e79687e6de9aaa3294591a6a270daf87d37d5","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"},{"line_number":36,"context_line":"  happing for the volume in the meantime. If we assume a 8TB volume is being"},{"line_number":37,"context_line":"  backed up in full and even if the backup was running at 1 GB/s the"},{"line_number":38,"context_line":"  volume backup will still take ~2.5 hrs to complete. Decoupling this from a state"},{"line_number":39,"context_line":"  machine perspective (since it already is for most drivers / implementations"}],"source_content_type":"text/x-rst","patch_set":6,"id":"d81b990f_478c59a4","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":9},"updated":"2023-06-19 23:24:27.000000000","message":"I understand from context that the task is waiting for the volume, but I don\u0027t know what \"happing\" is.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"63844585ff8fd78bb64503f66698abb0ac384538","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  false, a clone of the volume."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* A backup might take quite a long time to finish and is blocking any other task"},{"line_number":36,"context_line":"  happing for the volume in the meantime. If we assume a 8TB volume is being"},{"line_number":37,"context_line":"  backed up in full and even if the backup was running at 1 GB/s the"},{"line_number":38,"context_line":"  volume backup will still take ~2.5 hrs to complete. Decoupling this from a state"},{"line_number":39,"context_line":"  machine perspective (since it already is for most drivers / implementations"}],"source_content_type":"text/x-rst","patch_set":6,"id":"a70a7577_1b6ad68e","line":36,"range":{"start_line":36,"start_character":2,"end_line":36,"end_character":9},"in_reply_to":"d81b990f_478c59a4","updated":"2023-06-21 13:24:10.000000000","message":"Done","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ab2e79687e6de9aaa3294591a6a270daf87d37d5","unresolved":true,"context_lines":[{"line_number":69,"context_line":"For volumes there shall be field `backup_status` to hold the backup related"},{"line_number":70,"context_line":"values currently stored in `status`:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* \u0027backing-up\u0027"},{"line_number":73,"context_line":"* \u0027error_backing-up\u0027"},{"line_number":74,"context_line":"* \u0027restoring-backup\u0027"},{"line_number":75,"context_line":"* \u0027error_restoring\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Those shall then be removed from the list of (valid) values of `status`"},{"line_number":78,"context_line":"and be values for `backup_status`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"78668ec9_e541b2f9","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":19},"updated":"2023-06-19 23:24:27.000000000","message":"And no \"idle\" state? The example below has:\n  \"backup_status\": null\n\nPerhaps this needs to be touched upon. Under what conditions this is appropriate.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"63844585ff8fd78bb64503f66698abb0ac384538","unresolved":false,"context_lines":[{"line_number":69,"context_line":"For volumes there shall be field `backup_status` to hold the backup related"},{"line_number":70,"context_line":"values currently stored in `status`:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* \u0027backing-up\u0027"},{"line_number":73,"context_line":"* \u0027error_backing-up\u0027"},{"line_number":74,"context_line":"* \u0027restoring-backup\u0027"},{"line_number":75,"context_line":"* \u0027error_restoring\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Those shall then be removed from the list of (valid) values of `status`"},{"line_number":78,"context_line":"and be values for `backup_status`."}],"source_content_type":"text/x-rst","patch_set":6,"id":"b2a7ee06_7e8f32d1","line":75,"range":{"start_line":72,"start_character":0,"end_line":75,"end_character":19},"in_reply_to":"78668ec9_e541b2f9","updated":"2023-06-21 13:24:10.000000000","message":"Yeah, this is more a question of style in writing this spec. The list as the values related to the backup that shall be move to this new field. But yes, certainly there also as to be  \"backup_status\": null to allow for no currently running backup.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ab2e79687e6de9aaa3294591a6a270daf87d37d5","unresolved":true,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* Update volume"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* List volumes"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  * show additional field for the backup_status"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c499bf40_8ab7cd68","line":187,"updated":"2023-06-19 23:24:27.000000000","message":"Is something supposed to be here? Maybe \"not possible to update status or backup_status using `Update volume\u0027\"? If not, delete the empty clause.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"63844585ff8fd78bb64503f66698abb0ac384538","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* Update volume"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"* List volumes"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"  * show additional field for the backup_status"}],"source_content_type":"text/x-rst","patch_set":6,"id":"c82f875d_f5b8cccb","line":187,"in_reply_to":"c499bf40_8ab7cd68","updated":"2023-06-21 13:24:10.000000000","message":"The response of an update API call should contain the new field as well. I added this.","commit_id":"96adb1c5d940aa84a5dfc566e26e3cb2e73a1013"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2eb69468741cb80f65894d261aae25f317bb09ff","unresolved":true,"context_lines":[{"line_number":27,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option `backup_use_temp_snapshot` is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."}],"source_content_type":"text/x-rst","patch_set":9,"id":"46c4aa34_36c9e756","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"updated":"2023-06-22 11:09:50.000000000","message":"nit: remove this","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e4b15a7a19625bcf8e8db07630358e1e9dca2d90","unresolved":false,"context_lines":[{"line_number":27,"context_line":"applying the same logic to backups is actually not required or helpful:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* Actions on the volume itself (such as `resize` or `attaching`) and backups"},{"line_number":30,"context_line":"  backups (backing-up) not techically relate to each other. The backup-driver"},{"line_number":31,"context_line":"  and block device-driver act independently and backups are read off a volume"},{"line_number":32,"context_line":"  snapshot or, in case the config option `backup_use_temp_snapshot` is set to"},{"line_number":33,"context_line":"  false, a clone of the volume."}],"source_content_type":"text/x-rst","patch_set":9,"id":"7b1fff29_c7fa3bf5","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"in_reply_to":"46c4aa34_36c9e756","updated":"2024-04-16 09:08:19.000000000","message":"Acknowledged","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2eb69468741cb80f65894d261aae25f317bb09ff","unresolved":true,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    * online migration"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    * schema updatesspecs/2023.2/dedicated-volume-backup-status-field.rst"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Dependencies"},{"line_number":344,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"0b9bc88c_eac75b7e","line":341,"range":{"start_line":341,"start_character":20,"end_line":341,"end_character":73},"updated":"2023-06-22 11:09:50.000000000","message":"nit: this part isn\u0027t needed","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2cc25f255454c350d8ad9ff929aeb17da70d6fe3","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    * online migration"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    * schema updatesspecs/2023.2/dedicated-volume-backup-status-field.rst"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Dependencies"},{"line_number":344,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f0fb2132_c7801c0d","line":341,"range":{"start_line":341,"start_character":20,"end_line":341,"end_character":73},"in_reply_to":"0b9bc88c_eac75b7e","updated":"2023-06-22 11:11:44.000000000","message":"Done","commit_id":"55c16bf398b28fe202c33fbdaf999b1d5603182a"}]}