)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f1b3634cd1dd4d0ffaacd594e8a69de0fdf79d5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa054366_010c12b9","updated":"2023-01-27 14:54:13.000000000","message":"looks like I\u0027m unable to put that spec under bobcat directory which doesn\u0027t exist for now. I\u0027m leaving it under untargeted","commit_id":"facb9a4d34b5227007b6371e5393393ae9739cb7"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c58cb8dc2ba554b158d736d1a07897552368a4c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb57d068_4d18f90d","updated":"2023-02-09 14:28:38.000000000","message":"I thought the current PowerFlex driver could only create volumes that were rounded to 8Gb anyway:https://github.com/openstack/cinder/blob/393c2e4ad90c05ebf28cc3a2c65811d7e1e0bc18/cinder/volume/drivers/dell_emc/powerflex/options.py#L109\nso there currently is no way to create a 5GB volume and extend to 7GB as the inital 5GB creation would fail. This means that there is no need for this.\nPlus, I am only aware of PowerFlex having size rounding requirements, so this seems a lot of trouble in core code for one vendor specific \u0027feature\u0027.\n-1 so you can comment.","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0b781410a32b8870cb8adc33fad48104310d3759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7cb7baf_7da5edd7","in_reply_to":"44e04a68_49c2243b","updated":"2023-02-09 14:42:07.000000000","message":"OK - I didn\u0027t attend the PTG so wasn\u0027t aware of this discussion.\nIf the rest of the team are happy with it, then I\u0027ll remove my -1 and review the spec again.","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4b7151c0cabc5152e9cbffaaaeedccbcf185febb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"279b1cc1_b42bf9ed","in_reply_to":"a7cb7baf_7da5edd7","updated":"2023-02-09 14:44:49.000000000","message":"thank you, let\u0027s wait for the rest of team to give their feedback. Then we can decide whether or not to proceed.","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b73c4c8cfda57de1024c0b254978d4b29e743067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44e04a68_49c2243b","in_reply_to":"bb57d068_4d18f90d","updated":"2023-02-09 14:32:51.000000000","message":"Hi Simon, you are right, powerflex uses 8GB only as volume size.\nThe need here is to have both sizes (what the user wants, and what is actually allocated on the backend) displayed to the user.\nWe have discussed it in our PTG, and it was the solution that we all agreed. Let me know I have misunderstood.","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3663e67e1fa09df77cb86b2083ecc99bb69c9ca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5614002_28c81498","updated":"2023-06-09 20:27:01.000000000","message":"A few questions inline.","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ea7011683e04d2b9e9082d693baa5e390bee95c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"68d1c1d5_9c6d0d4c","updated":"2023-06-14 14:16:10.000000000","message":"In today\u0027s cinder meeting[1], there was a concern raised regarding the developer bandwidth due to which this wouldn\u0027t be able to complete in 2023.2 Bobcat cycle.\nLet\u0027s get back to it in CC release.\n\n[1] https://meetings.opendev.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2023-06-14.log.html#t2023-06-14T14:12:21","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8bc9dc6e343dd386337a6a835127260f745148df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"278d0208_092c3330","updated":"2023-06-13 11:59:54.000000000","message":"Minor comments inline.","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"483ea812_cf71ac71","updated":"2023-06-13 11:58:07.000000000","message":"Thanks for working on this.\nApart from the inline comments, please move the spec file to specs/2023.2/... directory","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2b257e562f0f5c48e9dc01b8ed23418dd183e760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c7489964_f385cee2","updated":"2023-11-22 12:03:05.000000000","message":"This needs to be reproposed in the 2024.1 specs directory","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"}],"specs/untargeted/sizing-capacity-rounded-volumes.rst":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"81cab697acc5bb157e8ff97b6cfbf7cd9968c391","unresolved":true,"context_lines":[{"line_number":61,"context_line":"Vendor-specific changes"},{"line_number":62,"context_line":"-----------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Dell PowerFlex driver should be updated to use that new functionality"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"957aeecc_ff69ae2c","line":64,"updated":"2023-04-26 17:09:26.000000000","message":"Have you confirmed that this change does not affect any other vendors?","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"04eeacba9e4eeab511522452eaeb3a28ddc5e240","unresolved":true,"context_lines":[{"line_number":66,"context_line":"Alternatives"},{"line_number":67,"context_line":"------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Datave everything as it is but the volume size reported by cinder doesn\u0027t reflect"},{"line_number":70,"context_line":"what\u0027s been allocated on the backend. As a side-effect, allocation monitoring is"},{"line_number":71,"context_line":"quite hard to follow for end users, extension of capacity can sometimes fail and"},{"line_number":72,"context_line":"quota is also affected."}],"source_content_type":"text/x-rst","patch_set":3,"id":"685e00f2_916b5e9f","line":69,"updated":"2023-03-21 18:59:59.000000000","message":"Dataverse  or dataV right?","commit_id":"d614688d8b1c3c24235d131015cf269bd3dd833d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3663e67e1fa09df77cb86b2083ecc99bb69c9ca4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"This introduces multiple side effects:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"* Allocation capacity not being monitored correctly."},{"line_number":23,"context_line":"* Extension of volume withing the same range will fail as the volume is already"},{"line_number":24,"context_line":"  at that size (Example: volume extention from 5 to 7, backend already set to 8)"},{"line_number":25,"context_line":"* Quota also affected."},{"line_number":26,"context_line":"* Data usage when migrating volumes will be hard to get accurately."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e1d2d87c_ced6fc39","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":29},"updated":"2023-06-09 20:27:01.000000000","message":"within","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"35e109ea584863c552e6974024ab02b43b89a8cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"This introduces multiple side effects:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"* Allocation capacity not being monitored correctly."},{"line_number":23,"context_line":"* Extension of volume withing the same range will fail as the volume is already"},{"line_number":24,"context_line":"  at that size (Example: volume extention from 5 to 7, backend already set to 8)"},{"line_number":25,"context_line":"* Quota also affected."},{"line_number":26,"context_line":"* Data usage when migrating volumes will be hard to get accurately."}],"source_content_type":"text/x-rst","patch_set":4,"id":"e43ccabf_9ac25592","line":23,"range":{"start_line":23,"start_character":22,"end_line":23,"end_character":29},"in_reply_to":"e1d2d87c_ced6fc39","updated":"2023-06-12 14:01:43.000000000","message":"Done","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3663e67e1fa09df77cb86b2083ecc99bb69c9ca4","unresolved":true,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Add a new field in the database called \u0027allocated_size\u0027. This size will be the"},{"line_number":39,"context_line":"  size allocated on the backend and will be the result of the rounding increment"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The volume is created at the size the user has request and will be shown"},{"line_number":42,"context_line":"  in two different values. The \u0027size\u0027 which displays the size that cinder is aware"}],"source_content_type":"text/x-rst","patch_set":4,"id":"c3e99adb_c9f0b0ff","line":39,"updated":"2023-06-09 20:27:01.000000000","message":"How will this be communicated back to cinder?","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"35e109ea584863c552e6974024ab02b43b89a8cd","unresolved":true,"context_lines":[{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* Add a new field in the database called \u0027allocated_size\u0027. This size will be the"},{"line_number":39,"context_line":"  size allocated on the backend and will be the result of the rounding increment"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* The volume is created at the size the user has request and will be shown"},{"line_number":42,"context_line":"  in two different values. The \u0027size\u0027 which displays the size that cinder is aware"}],"source_content_type":"text/x-rst","patch_set":4,"id":"eec3f1a7_9f230cc5","line":39,"in_reply_to":"c3e99adb_c9f0b0ff","updated":"2023-06-12 14:01:43.000000000","message":"Don\u0027t get your point. the driver will compute the result and send it to the database.","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3663e67e1fa09df77cb86b2083ecc99bb69c9ca4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  in two different values. The \u0027size\u0027 which displays the size that cinder is aware"},{"line_number":43,"context_line":"  of and the \u0027allocated_size\u0027 which displays the size created in the backend"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* The \u0027allocated_size\u0027 is not displayed by default the cinder-client and the"},{"line_number":46,"context_line":"  information is shown using the \u0027--long\u0027 option"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Add a new field in the API to fetch the \u0027allocated_size\u0027 value"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9286aae9_e4a1a7d2","line":46,"range":{"start_line":45,"start_character":2,"end_line":46,"end_character":48},"updated":"2023-06-09 20:27:01.000000000","message":"I think what you want to say here is that the allocated_size will only be returned in appropriate API responses when the API call is being made by an administrator (because they may need to use it for capacity computations or something).","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"35e109ea584863c552e6974024ab02b43b89a8cd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  in two different values. The \u0027size\u0027 which displays the size that cinder is aware"},{"line_number":43,"context_line":"  of and the \u0027allocated_size\u0027 which displays the size created in the backend"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* The \u0027allocated_size\u0027 is not displayed by default the cinder-client and the"},{"line_number":46,"context_line":"  information is shown using the \u0027--long\u0027 option"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"* Add a new field in the API to fetch the \u0027allocated_size\u0027 value"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f4939708_8515e41b","line":46,"range":{"start_line":45,"start_character":2,"end_line":46,"end_character":48},"in_reply_to":"9286aae9_e4a1a7d2","updated":"2023-06-12 14:01:43.000000000","message":"Done","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3663e67e1fa09df77cb86b2083ecc99bb69c9ca4","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"},{"line_number":57,"context_line":"  access to the portion of volume asked by the end-user by using privsep library"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* When extending the volume, os-brick will moodify the partition accordingly"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"82db4366_2b3d56d1","line":57,"updated":"2023-06-09 20:27:01.000000000","message":"How is os-brick going to know that it needs to do this?","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"35e109ea584863c552e6974024ab02b43b89a8cd","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"},{"line_number":57,"context_line":"  access to the portion of volume asked by the end-user by using privsep library"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* When extending the volume, os-brick will moodify the partition accordingly"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d8072595_8b9b89ca","line":57,"in_reply_to":"82db4366_2b3d56d1","updated":"2023-06-12 14:01:43.000000000","message":"\u003e How is os-brick going to know that it needs to do this?\n\nGood point. Can\u0027t we trigger the partitioning from within the driver itself?","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  size"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"},{"line_number":57,"context_line":"  access to the portion of volume asked by the end-user by using privsep library"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"* When extending the volume, os-brick will moodify the partition accordingly"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"a7c2db3c_06c21cf7","line":57,"in_reply_to":"d8072595_8b9b89ca","updated":"2023-06-13 11:58:07.000000000","message":"If we are referring to attachment here, we can send something in the connection_info telling os-brick about the size and allocated size so that we can do the partition accordingly","commit_id":"466087ef3fe4d8d7ef26a2b2abfda319604a1b04"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8bc9dc6e343dd386337a6a835127260f745148df","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"When creating a volume, Dell PowerFlex will round the value of the capacity by"},{"line_number":17,"context_line":"a multiple of 8GB leaving inconsistency between cinder which shows the value"},{"line_number":18,"context_line":"requested by the user and powerflex which shows the current allocation."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This introduces multiple side effects:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"af75e474_811120e4","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":35},"updated":"2023-06-13 11:59:54.000000000","message":"nit: PowerFlex","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  at that size (Example: volume extention from 5 to 7, backend already set to 8)"},{"line_number":25,"context_line":"* Quota also affected."},{"line_number":26,"context_line":"* Data usage when migrating volumes will be hard to get accurately."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"6a7a8328_3395e7e8","line":27,"updated":"2023-06-13 11:58:07.000000000","message":"One more case here could be that nova will see the whole LUN size irrespective of the volume size i.e. if we attach a 1GB volume to nova, the LUN is actually 8GB in size which will be visible to nova instead of 1GB.","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":28,"context_line":"Use Cases"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"The main use-case here is when creating or extending a volume with"},{"line_number":32,"context_line":"a size which is not a multiplier of an increment size. This is typically the"},{"line_number":33,"context_line":"case with Dell PowerFlex storage provider which uses an increment size of 8GB."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":5,"id":"82efe53e_12991be3","line":32,"range":{"start_line":31,"start_character":62,"end_line":32,"end_character":12},"updated":"2023-06-13 11:58:07.000000000","message":", the operation fails when the provided size","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  the API call is being made by an administrator (because they may need to use"},{"line_number":47,"context_line":"  it for capacity computations for example) by using the \u0027--long\u0027 option"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Add a new field in the API to fetch the \u0027allocated_size\u0027 value"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* The create_volume.py will update the database volume reference according to the"},{"line_number":52,"context_line":"  computation of the rounded size"}],"source_content_type":"text/x-rst","patch_set":5,"id":"a8c66d0f_cf3a2a7a","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":64},"updated":"2023-06-13 11:58:07.000000000","message":"this will require a new microversion","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"* Add a new field in the API to fetch the \u0027allocated_size\u0027 value"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* The create_volume.py will update the database volume reference according to the"},{"line_number":52,"context_line":"  computation of the rounded size"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* The manager.py will update the table according to the computation of the rounded"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7c2c95de_5d5f6e17","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":22},"updated":"2023-06-13 11:58:07.000000000","message":"it might not be a good idea to mention file names since name/location of files can change with time\nAlso this is ambiguous since we have 2 files with same name, one in API layer[1] and another in volume layer[2]\nbetter is we can mention that in the API layer, we will update the database volume reference according to the computation of the rounded size\n\n[1] https://github.com/openstack/cinder/tree/master/cinder/volume/flows/api\n[2] https://github.com/openstack/cinder/tree/master/cinder/volume/flows/manager","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":51,"context_line":"* The create_volume.py will update the database volume reference according to the"},{"line_number":52,"context_line":"  computation of the rounded size"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* The manager.py will update the table according to the computation of the rounded"},{"line_number":55,"context_line":"  size"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"}],"source_content_type":"text/x-rst","patch_set":5,"id":"8268b1b5_e1134d34","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":17},"updated":"2023-06-13 11:58:07.000000000","message":"same as above","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":54,"context_line":"* The manager.py will update the table according to the computation of the rounded"},{"line_number":55,"context_line":"  size"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"},{"line_number":58,"context_line":"  access to the portion of volume asked by the end-user by using privsep library"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* When extending the volume, os-brick will moodify the partition accordingly"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4c4ab029_d363be0e","line":57,"range":{"start_line":57,"start_character":7,"end_line":57,"end_character":26},"updated":"2023-06-13 11:58:07.000000000","message":"you mean during attaching? os-brick isn\u0027t involved during creation of volume","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8bc9dc6e343dd386337a6a835127260f745148df","unresolved":true,"context_lines":[{"line_number":57,"context_line":"* When creating the volume, os-brick will partition the volume in order to provide"},{"line_number":58,"context_line":"  access to the portion of volume asked by the end-user by using privsep library"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* When extending the volume, os-brick will moodify the partition accordingly"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Vendor-specific changes"},{"line_number":63,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7635c903_cabf61ab","line":60,"range":{"start_line":60,"start_character":43,"end_line":60,"end_character":50},"updated":"2023-06-13 11:59:54.000000000","message":"typo: modify","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":62,"context_line":"Vendor-specific changes"},{"line_number":63,"context_line":"-----------------------"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Dell PowerFlex driver should be updated to use that new functionality"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b247bf0f_882be62c","line":65,"range":{"start_line":65,"start_character":47,"end_line":65,"end_character":51},"updated":"2023-06-13 11:58:07.000000000","message":"nit: the","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":75,"context_line":"Data model impact"},{"line_number":76,"context_line":"-----------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"New field in the cinder/volumes table"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"REST API impact"},{"line_number":81,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"42092fcb_61266e2a","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":9},"updated":"2023-06-13 11:58:07.000000000","message":"good to mention the field name here i.e. allocated_size","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":80,"context_line":"REST API impact"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"New field in the API"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Security impact"},{"line_number":86,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"70febb65_e2c77f0c","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":20},"updated":"2023-06-13 11:58:07.000000000","message":"we should have the volume API response here with the new field","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":124,"context_line":"Work Items"},{"line_number":125,"context_line":"----------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Modify SQL structure"},{"line_number":128,"context_line":"* Implement new logic in cinder"},{"line_number":129,"context_line":"* Implement new logic in os-brick/privsep"},{"line_number":130,"context_line":"* Unit-tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"07d459f3_bd71a280","line":127,"range":{"start_line":127,"start_character":2,"end_line":127,"end_character":22},"updated":"2023-06-13 11:58:07.000000000","message":"this is pretty vague, can we just say\n\nmodify the volumes table to add a new filed \"allocated_size\" (replace \" with back quotes)","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":125,"context_line":"----------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Modify SQL structure"},{"line_number":128,"context_line":"* Implement new logic in cinder"},{"line_number":129,"context_line":"* Implement new logic in os-brick/privsep"},{"line_number":130,"context_line":"* Unit-tests"},{"line_number":131,"context_line":"* Tempest tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"76403fd7_a2901053","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":31},"updated":"2023-06-13 11:58:07.000000000","message":"can we add 1-2 lines for this new logic","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"* Modify SQL structure"},{"line_number":128,"context_line":"* Implement new logic in cinder"},{"line_number":129,"context_line":"* Implement new logic in os-brick/privsep"},{"line_number":130,"context_line":"* Unit-tests"},{"line_number":131,"context_line":"* Tempest tests"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"e2a48edf_136e8f9c","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":41},"updated":"2023-06-13 11:58:07.000000000","message":"same, new logic seems too vague","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":127,"context_line":"* Modify SQL structure"},{"line_number":128,"context_line":"* Implement new logic in cinder"},{"line_number":129,"context_line":"* Implement new logic in os-brick/privsep"},{"line_number":130,"context_line":"* Unit-tests"},{"line_number":131,"context_line":"* Tempest tests"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Dependencies"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"55e69705_cf1202b0","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":15},"updated":"2023-06-13 11:58:07.000000000","message":"this should be under testing so no need to add it here","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":129,"context_line":"* Implement new logic in os-brick/privsep"},{"line_number":130,"context_line":"* Unit-tests"},{"line_number":131,"context_line":"* Tempest tests"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Dependencies"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"d46a5f7e_d27e238d","line":132,"updated":"2023-06-13 11:58:07.000000000","message":"we also need to add a new microversion for the API response of \"allocated_size\"","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"df4e350da9586507b94b02cf273af8f3c991ce15","unresolved":true,"context_lines":[{"line_number":150,"context_line":"References"},{"line_number":151,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"* Antelope PTG https://etherpad.opendev.org/p/antelope-ptg-cinder"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1c2b6c16_16f47e02","line":153,"range":{"start_line":153,"start_character":15,"end_line":153,"end_character":65},"updated":"2023-06-13 11:58:07.000000000","message":"we can mention a specific link like this\n\nhttps://wiki.openstack.org/wiki/CinderAntelopePTGSummary#Allocation_size_vs_requested_size_for_specific_storage_provider_like_Dell_PowerFlex","commit_id":"9ce0b6c99b9bd122ad3b412627a2fa1d2c8b3f14"}]}