)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc1df565_6741251b","updated":"2024-02-22 14:13:31.000000000","message":"Some grammatical and spelling issues","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f55ce85c_f88735d7","updated":"2024-03-05 08:39:28.000000000","message":"I fixed the spelling issues","commit_id":"ada8d015fa0b3855f010893cdef65678580d88d5"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"760ee2d85f3754b8f4a5db42a69fc1db50490df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0549ff4b_a09f8f91","updated":"2024-05-21 07:25:43.000000000","message":"Thank you for the findings, I clarified the problem with CLI (properties) and API (extra_specs) within the spec.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2239a9a1_b6a86d87","updated":"2024-05-17 22:47:50.000000000","message":"This is a good proposal.  A few things to address noted inline.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6186035b5dbfe29d5d4385e915cfe3f45cc57db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc626ce6_adf526ce","updated":"2024-06-08 17:15:55.000000000","message":"I think this mostly looks fine, though I still think we should allow the volume-type metadata to be modified on volume types, even if those volume types are currently in use.  I think operators will want to add metadata to their current volume types, and since the metadata aren\u0027t actionable for the scheduler, it should be OK to change them, unless I\u0027m missing something.","commit_id":"d0d988c637c82d7aa93efb9ba5a09c24f3c86331"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"439ca7253ba517e305f5acf21df84bf4e2b843c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b10dfd3b_3af3ac67","updated":"2024-06-20 12:33:26.000000000","message":"Typo and clarification noted inline; otherwise LGTM.  It might be worth asking at the next cinder weekly meeting whether anyone has an objection to allowing the volume-type-metadata to be mutable while the volume-type is in use.  (I can\u0027t think of a problem, but it\u0027s worth asking for broader feedback.)","commit_id":"0904701324aa676f13ccad65370213ad8040f1de"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0a3fd2fc_24b17569","updated":"2024-06-27 23:56:43.000000000","message":"I wish to see the new table specified, not only mentioned.","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"791b5ac1ddb121168ee925f64ca7634a4913116f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec84bca4_a501f46e","updated":"2024-06-26 14:05:20.000000000","message":"Revisions LGTM.","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b128bcfa493cb217be0e1a88ae0619fac2786c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a0be3b62_57b0bacf","updated":"2024-06-26 08:27:39.000000000","message":"We are past cinder spec freeze[1], would be good to discuss in today\u0027s Cinder meeting if we want to extend the deadline.\n\n[1] https://releases.openstack.org/dalmatian/schedule.html#d-cinder-spec-freeze","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ea73ca06865cabb4add9d7d76e3099f44b5255c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9d17cba8_3a318088","updated":"2024-06-26 14:14:03.000000000","message":"we agreed in the meeting that we can extend the deadline","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37b916246fc7f9359829e5388962e2d6bc2cbbb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0a7df743_e7eaf572","updated":"2024-07-01 12:26:27.000000000","message":"Revisions LGTM.","commit_id":"ebf6a9650b3119bfadd322f880b62681ca7b5766"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"debc28010caf2453f40fa4cd44ddc84b07b021ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"767231e9_38f8db08","updated":"2024-06-28 15:36:31.000000000","message":"Seems to have completed all the requested changes","commit_id":"ebf6a9650b3119bfadd322f880b62681ca7b5766"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"4f1440da3ed919173e35f24d6f46618f523b58ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5bac4df2_3dd4b711","updated":"2024-07-08 14:49:44.000000000","message":"This looks good to me, the review sequence and responses are sound, no objection here.","commit_id":"ebf6a9650b3119bfadd322f880b62681ca7b5766"}],"specs/2024.1/user-visible-information-in-volume-types.rst":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/user-visible-information-in-volume-types"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Volume types are used to find a fitting backend when creating a volume. But"},{"line_number":14,"context_line":"they also imply a few configurations to the volume to be created, that are"},{"line_number":15,"context_line":"good to know for anyone who has to choose from various volume types."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Please do not delete any of the sections in this template.  If you have"},{"line_number":18,"context_line":"  nothing to say for a whole section, just write: None"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* If your specification proposes any changes to the Cinder REST API such"},{"line_number":21,"context_line":"  as changing parameters which can be returned or accepted, or even"},{"line_number":22,"context_line":"  the semantics of what happens when a client calls into the API, then"},{"line_number":23,"context_line":"  you should add the APIImpact flag to the commit message. Specifications with"},{"line_number":24,"context_line":"  the APIImpact flag can be found with the following query:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  https://review.openstack.org/#/q/status:open+project:openstack/cinder-specs+message:apiimpact,n,z"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"08cf5b8e_72d5dee0","line":26,"range":{"start_line":13,"start_character":0,"end_line":26,"end_character":99},"updated":"2024-02-22 14:13:31.000000000","message":"this is part of the template and can be removed","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/cinder/+spec/user-visible-information-in-volume-types"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Volume types are used to find a fitting backend when creating a volume. But"},{"line_number":14,"context_line":"they also imply a few configurations to the volume to be created, that are"},{"line_number":15,"context_line":"good to know for anyone who has to choose from various volume types."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"* Please do not delete any of the sections in this template.  If you have"},{"line_number":18,"context_line":"  nothing to say for a whole section, just write: None"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* If your specification proposes any changes to the Cinder REST API such"},{"line_number":21,"context_line":"  as changing parameters which can be returned or accepted, or even"},{"line_number":22,"context_line":"  the semantics of what happens when a client calls into the API, then"},{"line_number":23,"context_line":"  you should add the APIImpact flag to the commit message. Specifications with"},{"line_number":24,"context_line":"  the APIImpact flag can be found with the following query:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  https://review.openstack.org/#/q/status:open+project:openstack/cinder-specs+message:apiimpact,n,z"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":2,"id":"94867d78_4b147ac4","line":26,"range":{"start_line":13,"start_character":0,"end_line":26,"end_character":99},"in_reply_to":"08cf5b8e_72d5dee0","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":48,"context_line":"directly seen in the volume type extra_specs or is indirectly a part of the"},{"line_number":49,"context_line":"configuration of the backend."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"There might be more use cases, that sould benefit from a solution allowing"},{"line_number":52,"context_line":"an admin to add certain user facing information into the volume type in a"},{"line_number":53,"context_line":"uniform way."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9155277c_920b5444","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":42},"updated":"2024-02-22 14:13:31.000000000","message":"nit: should","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"directly seen in the volume type extra_specs or is indirectly a part of the"},{"line_number":49,"context_line":"configuration of the backend."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"There might be more use cases, that sould benefit from a solution allowing"},{"line_number":52,"context_line":"an admin to add certain user facing information into the volume type in a"},{"line_number":53,"context_line":"uniform way."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"2bc2f679_89adf2d8","line":51,"range":{"start_line":51,"start_character":36,"end_line":51,"end_character":42},"in_reply_to":"9155277c_920b5444","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":53,"context_line":"uniform way."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"As there are more and more tools that automatically create IaaS resources,"},{"line_number":56,"context_line":"those information should be accessible in a uniform way and could best be"},{"line_number":57,"context_line":"used to filter for fitting volume types in the client."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c484c4e3_10822ddb","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":6},"updated":"2024-02-22 14:13:31.000000000","message":"nit: that","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"uniform way."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"As there are more and more tools that automatically create IaaS resources,"},{"line_number":56,"context_line":"those information should be accessible in a uniform way and could best be"},{"line_number":57,"context_line":"used to filter for fitting volume types in the client."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f37a4d9_8d2ea9ed","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":6},"in_reply_to":"c484c4e3_10822ddb","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":78,"context_line":"put every key\u003dvalue pair in there at the time of their creation, that should"},{"line_number":79,"context_line":"not be used in the scheduling process. The \"properties\" field would then be"},{"line_number":80,"context_line":"build in the API from a merge of the extra_specs and the metadata table."},{"line_number":81,"context_line":"(This may also prevent the volume type from getting unusable, when some adds"},{"line_number":82,"context_line":"a key\u003dvalue pair to the \"properties\", that is not meant for the scheduler -"},{"line_number":83,"context_line":"right now this would break the volume creation process)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a193d0ad_ebab3d50","line":81,"range":{"start_line":81,"start_character":44,"end_line":81,"end_character":52},"updated":"2024-02-22 14:13:31.000000000","message":"nit: becoming","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":78,"context_line":"put every key\u003dvalue pair in there at the time of their creation, that should"},{"line_number":79,"context_line":"not be used in the scheduling process. The \"properties\" field would then be"},{"line_number":80,"context_line":"build in the API from a merge of the extra_specs and the metadata table."},{"line_number":81,"context_line":"(This may also prevent the volume type from getting unusable, when some adds"},{"line_number":82,"context_line":"a key\u003dvalue pair to the \"properties\", that is not meant for the scheduler -"},{"line_number":83,"context_line":"right now this would break the volume creation process)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"98499fad_65c18f82","line":81,"range":{"start_line":81,"start_character":67,"end_line":81,"end_character":72},"updated":"2024-02-22 14:13:31.000000000","message":"nit: someone","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"put every key\u003dvalue pair in there at the time of their creation, that should"},{"line_number":79,"context_line":"not be used in the scheduling process. The \"properties\" field would then be"},{"line_number":80,"context_line":"build in the API from a merge of the extra_specs and the metadata table."},{"line_number":81,"context_line":"(This may also prevent the volume type from getting unusable, when some adds"},{"line_number":82,"context_line":"a key\u003dvalue pair to the \"properties\", that is not meant for the scheduler -"},{"line_number":83,"context_line":"right now this would break the volume creation process)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ff04070_278184a8","line":81,"range":{"start_line":81,"start_character":67,"end_line":81,"end_character":72},"in_reply_to":"98499fad_65c18f82","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"put every key\u003dvalue pair in there at the time of their creation, that should"},{"line_number":79,"context_line":"not be used in the scheduling process. The \"properties\" field would then be"},{"line_number":80,"context_line":"build in the API from a merge of the extra_specs and the metadata table."},{"line_number":81,"context_line":"(This may also prevent the volume type from getting unusable, when some adds"},{"line_number":82,"context_line":"a key\u003dvalue pair to the \"properties\", that is not meant for the scheduler -"},{"line_number":83,"context_line":"right now this would break the volume creation process)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"21383033_7c7c6e8b","line":81,"range":{"start_line":81,"start_character":44,"end_line":81,"end_character":52},"in_reply_to":"a193d0ad_ebab3d50","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":121,"context_line":"sufficient."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"For 3.b the volume type table would need to get a new column: `encryption_set`"},{"line_number":124,"context_line":"with a boolean option. This could defealt to false but has to be set to true"},{"line_number":125,"context_line":"for every volume type that has an associated encryption type."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For 3.c it is not yet clear what changes need to be done."}],"source_content_type":"text/x-rst","patch_set":2,"id":"410882fa_22e830d5","line":124,"range":{"start_line":124,"start_character":34,"end_line":124,"end_character":42},"updated":"2024-02-22 14:13:31.000000000","message":"nit: default","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"sufficient."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"For 3.b the volume type table would need to get a new column: `encryption_set`"},{"line_number":124,"context_line":"with a boolean option. This could defealt to false but has to be set to true"},{"line_number":125,"context_line":"for every volume type that has an associated encryption type."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"For 3.c it is not yet clear what changes need to be done."}],"source_content_type":"text/x-rst","patch_set":2,"id":"d707bf11_6abfb5f5","line":124,"range":{"start_line":124,"start_character":34,"end_line":124,"end_character":42},"in_reply_to":"410882fa_22e830d5","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Additionally for 1.a, 1.b, 2 and 3.b in case of an upgrade from a previous"},{"line_number":130,"context_line":"OpenStack version, all volume types need to be checked and for volume types"},{"line_number":131,"context_line":"with associated encryption types, there need to be a the encryption parameter"},{"line_number":132,"context_line":"set in the database according to the chosen option."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"00a6f9ff_875e9a11","line":131,"range":{"start_line":131,"start_character":40,"end_line":131,"end_character":56},"updated":"2024-02-22 14:13:31.000000000","message":"nit: needs to be an","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Additionally for 1.a, 1.b, 2 and 3.b in case of an upgrade from a previous"},{"line_number":130,"context_line":"OpenStack version, all volume types need to be checked and for volume types"},{"line_number":131,"context_line":"with associated encryption types, there need to be a the encryption parameter"},{"line_number":132,"context_line":"set in the database according to the chosen option."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"REST API impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"996acbd6_6d0e4e96","line":131,"range":{"start_line":131,"start_character":40,"end_line":131,"end_character":56},"in_reply_to":"00a6f9ff_875e9a11","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":137,"context_line":"Each API method which is either added or changed should have the following"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"For 1.a and 1.b there would only be minor changes in already existing API"},{"line_number":140,"context_line":"calls as creating a new key-value pair and writing it to the database when"},{"line_number":141,"context_line":"creating an encryption type."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"For 1.b and 3.a the list and show calls for the volume type would get an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ee969ce5_35998256","line":140,"range":{"start_line":140,"start_character":6,"end_line":140,"end_character":9},"updated":"2024-02-22 14:13:31.000000000","message":"nit: such as","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Each API method which is either added or changed should have the following"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"For 1.a and 1.b there would only be minor changes in already existing API"},{"line_number":140,"context_line":"calls as creating a new key-value pair and writing it to the database when"},{"line_number":141,"context_line":"creating an encryption type."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"For 1.b and 3.a the list and show calls for the volume type would get an"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9cadff6c_73452ddc","line":140,"range":{"start_line":140,"start_character":6,"end_line":140,"end_character":9},"in_reply_to":"ee969ce5_35998256","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":156,"context_line":"For 3.c it is not yet clear what changes need to be done."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"In general there should be a clear separation of information being set by"},{"line_number":159,"context_line":"admins versus information being set through OpenStack workflows. Latter should"},{"line_number":160,"context_line":"not be setable via `openstack volume type set`. Instead a 403 Error should be"},{"line_number":161,"context_line":"presented."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"03fb7186_02fc57ed","line":159,"range":{"start_line":159,"start_character":65,"end_line":159,"end_character":72},"updated":"2024-02-22 14:13:31.000000000","message":"nit: The latter","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"For 3.c it is not yet clear what changes need to be done."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"In general there should be a clear separation of information being set by"},{"line_number":159,"context_line":"admins versus information being set through OpenStack workflows. Latter should"},{"line_number":160,"context_line":"not be setable via `openstack volume type set`. Instead a 403 Error should be"},{"line_number":161,"context_line":"presented."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"db440ca2_1f8729ae","line":159,"range":{"start_line":159,"start_character":65,"end_line":159,"end_character":72},"in_reply_to":"03fb7186_02fc57ed","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"There might be additional notifications when database entries are made or"},{"line_number":181,"context_line":"removed. They will behave the same way as the notifications of extra_specs."},{"line_number":182,"context_line":"Those will be notification are sent, whenever an encryption_type is created"},{"line_number":183,"context_line":"or deleted adn thus a new kea-value pair is written into the extra_specs"},{"line_number":184,"context_line":"database tbale or in general when a key-value pair is added to a possible new"},{"line_number":185,"context_line":"metadata DB table."}],"source_content_type":"text/x-rst","patch_set":2,"id":"57e13557_c0d9a30a","line":182,"range":{"start_line":182,"start_character":14,"end_line":182,"end_character":30},"updated":"2024-02-22 14:13:31.000000000","message":"nit: unnecessary","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"There might be additional notifications when database entries are made or"},{"line_number":181,"context_line":"removed. They will behave the same way as the notifications of extra_specs."},{"line_number":182,"context_line":"Those will be notification are sent, whenever an encryption_type is created"},{"line_number":183,"context_line":"or deleted adn thus a new kea-value pair is written into the extra_specs"},{"line_number":184,"context_line":"database tbale or in general when a key-value pair is added to a possible new"},{"line_number":185,"context_line":"metadata DB table."}],"source_content_type":"text/x-rst","patch_set":2,"id":"65649c42_b6b7e056","line":182,"range":{"start_line":182,"start_character":14,"end_line":182,"end_character":30},"in_reply_to":"57e13557_c0d9a30a","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":180,"context_line":"There might be additional notifications when database entries are made or"},{"line_number":181,"context_line":"removed. They will behave the same way as the notifications of extra_specs."},{"line_number":182,"context_line":"Those will be notification are sent, whenever an encryption_type is created"},{"line_number":183,"context_line":"or deleted adn thus a new kea-value pair is written into the extra_specs"},{"line_number":184,"context_line":"database tbale or in general when a key-value pair is added to a possible new"},{"line_number":185,"context_line":"metadata DB table."},{"line_number":186,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aad5979_fc2c09f7","line":183,"range":{"start_line":183,"start_character":11,"end_line":183,"end_character":15},"updated":"2024-02-22 14:13:31.000000000","message":"nit: and","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"There might be additional notifications when database entries are made or"},{"line_number":181,"context_line":"removed. They will behave the same way as the notifications of extra_specs."},{"line_number":182,"context_line":"Those will be notification are sent, whenever an encryption_type is created"},{"line_number":183,"context_line":"or deleted adn thus a new kea-value pair is written into the extra_specs"},{"line_number":184,"context_line":"database tbale or in general when a key-value pair is added to a possible new"},{"line_number":185,"context_line":"metadata DB table."},{"line_number":186,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"42db6418_30cd4d29","line":183,"range":{"start_line":183,"start_character":11,"end_line":183,"end_character":15},"in_reply_to":"1aad5979_fc2c09f7","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":206,"context_line":"Other deployer impact"},{"line_number":207,"context_line":"---------------------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Discuss things that will affect how you deploy and configure OpenStack"},{"line_number":210,"context_line":"that have not already been mentioned, such as:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"There will be no new config options."},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f3ff5c94_62b7ecc5","line":210,"range":{"start_line":209,"start_character":0,"end_line":210,"end_character":46},"updated":"2024-02-22 14:13:31.000000000","message":"Remove","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"Other deployer impact"},{"line_number":207,"context_line":"---------------------"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"Discuss things that will affect how you deploy and configure OpenStack"},{"line_number":210,"context_line":"that have not already been mentioned, such as:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"There will be no new config options."},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a3e06c3e_5e91fef6","line":210,"range":{"start_line":209,"start_character":0,"end_line":210,"end_character":46},"in_reply_to":"f3ff5c94_62b7ecc5","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":268,"context_line":"References"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":272,"context_line":"reference. Moreover, this specification should still make sense when your"},{"line_number":273,"context_line":"references are unavailable. Examples of what you could include are:"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* `Mailing list discussion \u003chttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/PP7IMXVOO2SM47JRMDYYVB2IA3XIEZD5/\u003e`_"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"489759b4_dd2286e8","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":67},"updated":"2024-02-22 14:13:31.000000000","message":"Remove","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"References"},{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Please add any useful references here. You are not required to have any"},{"line_number":272,"context_line":"reference. Moreover, this specification should still make sense when your"},{"line_number":273,"context_line":"references are unavailable. Examples of what you could include are:"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* `Mailing list discussion \u003chttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/PP7IMXVOO2SM47JRMDYYVB2IA3XIEZD5/\u003e`_"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"c7dcf863_8f29b556","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":67},"in_reply_to":"489759b4_dd2286e8","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"fd70207f705874143e944e0e90a0cf02d13d2453","unresolved":true,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* `Mailing list discussion \u003chttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/PP7IMXVOO2SM47JRMDYYVB2IA3XIEZD5/\u003e`_"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"* `Discussion in the Cinde Midcycle \u003chttps://etherpad.opendev.org/p/cinder-caracal-midcycles#L93\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"57e098ba_254a6684","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":27},"updated":"2024-02-22 14:13:31.000000000","message":"nit: Cinder","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"735f0bbc281569d64027167aad17ba39c932b03f","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* `Mailing list discussion \u003chttps://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/PP7IMXVOO2SM47JRMDYYVB2IA3XIEZD5/\u003e`_"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"* `Discussion in the Cinde Midcycle \u003chttps://etherpad.opendev.org/p/cinder-caracal-midcycles#L93\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c4e8738a_821d2b52","line":277,"range":{"start_line":277,"start_character":21,"end_line":277,"end_character":27},"in_reply_to":"57e098ba_254a6684","updated":"2024-03-05 08:39:28.000000000","message":"Done","commit_id":"59a8b7c422c86e6ef3fcd1df04fcf95ad959a649"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"65742bcd3c1b55a20d3755209f517a52eecc00e0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"When a non-admin user is creating a volume they would like to see various"},{"line_number":21,"context_line":"information about the volume type. Some of them are already available"},{"line_number":22,"context_line":"(e.g. multiattach), while others are either not available at all or not"},{"line_number":23,"context_line":"available for non-admin users. This is a problem when trying to choose a"},{"line_number":24,"context_line":"fitting volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"477d2106_4e3eadf3","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":58},"updated":"2024-03-13 14:57:41.000000000","message":"@Josephine Seifert, \n\nIt might be clearer to be more specific here about what \"them\" is referring to (e.g. volume type, volume, other) -- \"Some volume information is already available ...\"","commit_id":"ada8d015fa0b3855f010893cdef65678580d88d5"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"When a non-admin user is creating a volume they would like to see various"},{"line_number":21,"context_line":"information about the volume type. Some of them are already available"},{"line_number":22,"context_line":"(e.g. multiattach), while others are either not available at all or not"},{"line_number":23,"context_line":"available for non-admin users. This is a problem when trying to choose a"},{"line_number":24,"context_line":"fitting volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"570e2f4b_45d6553d","line":21,"range":{"start_line":21,"start_character":35,"end_line":21,"end_character":58},"in_reply_to":"477d2106_4e3eadf3","updated":"2024-06-19 14:04:17.000000000","message":"Done","commit_id":"ada8d015fa0b3855f010893cdef65678580d88d5"}],"specs/2024.2/user-visible-information-in-volume-types.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"As having two field, that will contain user facing information: \"properties\""},{"line_number":58,"context_line":"and \"metadata\", this might confuse people. In API as well as in CLI and"},{"line_number":59,"context_line":"documentation this needs to be stated clearly. The limit for this change is,"},{"line_number":60,"context_line":"that key-value pairs not meant for scheduling purposes can still be put into"},{"line_number":61,"context_line":"the properties/extra_specs and will lead to Errors in the scheduling process"}],"source_content_type":"text/x-rst","patch_set":7,"id":"c504aedf_1425c81c","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":42},"updated":"2024-05-17 22:47:50.000000000","message":"The volume_type does not have a \"properties\" field; it\u0027s currently got name, description, extra_specs, os-volume-type-access:is_public.  So I think adding \"metadata\" won\u0027t be confusing.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"760ee2d85f3754b8f4a5db42a69fc1db50490df3","unresolved":true,"context_lines":[{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"As having two field, that will contain user facing information: \"properties\""},{"line_number":58,"context_line":"and \"metadata\", this might confuse people. In API as well as in CLI and"},{"line_number":59,"context_line":"documentation this needs to be stated clearly. The limit for this change is,"},{"line_number":60,"context_line":"that key-value pairs not meant for scheduling purposes can still be put into"},{"line_number":61,"context_line":"the properties/extra_specs and will lead to Errors in the scheduling process"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cecf9e68_cfa2cc2a","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":42},"in_reply_to":"c504aedf_1425c81c","updated":"2024-05-21 07:25:43.000000000","message":"I meant in the CLI, you will see the extra_specs as properties. I will clarify this in the spec.\nWe do not have a functional problem here, as the `extra_specs` / `properties` are different from `metadata`. I just wanted to address that documentation is necessary.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"As having two field, that will contain user facing information: \"properties\""},{"line_number":58,"context_line":"and \"metadata\", this might confuse people. In API as well as in CLI and"},{"line_number":59,"context_line":"documentation this needs to be stated clearly. The limit for this change is,"},{"line_number":60,"context_line":"that key-value pairs not meant for scheduling purposes can still be put into"},{"line_number":61,"context_line":"the properties/extra_specs and will lead to Errors in the scheduling process"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bebba307_174fad24","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":42},"in_reply_to":"cecf9e68_cfa2cc2a","updated":"2024-06-19 14:04:17.000000000","message":"Done","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We evaluated using the already existing user facing \"properties\" field."},{"line_number":71,"context_line":"Administrators can already set key-value pairs here and user visible"},{"line_number":72,"context_line":"extra_specs can be seen in this field. But this would lead to a problem in the"},{"line_number":73,"context_line":"volume scheduler, as EVERY input in the extra_specs table will be evaluated by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"8413b03d_370e452f","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":71},"updated":"2024-05-17 22:47:50.000000000","message":"I don\u0027t think the volume_type has this?","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We evaluated using the already existing user facing \"properties\" field."},{"line_number":71,"context_line":"Administrators can already set key-value pairs here and user visible"},{"line_number":72,"context_line":"extra_specs can be seen in this field. But this would lead to a problem in the"},{"line_number":73,"context_line":"volume scheduler, as EVERY input in the extra_specs table will be evaluated by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"572649f6_7470577a","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":71},"in_reply_to":"20ee10d3_89b3c8a1","updated":"2024-06-19 14:04:17.000000000","message":"Done","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"760ee2d85f3754b8f4a5db42a69fc1db50490df3","unresolved":true,"context_lines":[{"line_number":67,"context_line":"Alternatives"},{"line_number":68,"context_line":"------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"We evaluated using the already existing user facing \"properties\" field."},{"line_number":71,"context_line":"Administrators can already set key-value pairs here and user visible"},{"line_number":72,"context_line":"extra_specs can be seen in this field. But this would lead to a problem in the"},{"line_number":73,"context_line":"volume scheduler, as EVERY input in the extra_specs table will be evaluated by"}],"source_content_type":"text/x-rst","patch_set":7,"id":"20ee10d3_89b3c8a1","line":70,"range":{"start_line":70,"start_character":19,"end_line":70,"end_character":71},"in_reply_to":"8413b03d_370e452f","updated":"2024-05-21 07:25:43.000000000","message":"I meant the `extra_specs` field in API, what is converted to `properties` in CLI. I will adjust this.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- a POST method to set new key-value pairs"},{"line_number":126,"context_line":"- a DELETE method to delete a key-value pair."},{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ea10cc1c_edd8fa9c","line":127,"updated":"2024-05-17 22:47:50.000000000","message":"I\u0027m not saying that you have to do this as part of this spec, but I think we\u0027ll ultimately want the list volume types call to be able to filter on metadata (so a user can see all the replicated types, for example), sort of like what microversion 3.52 did for extra_specs filtering.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- a POST method to set new key-value pairs"},{"line_number":126,"context_line":"- a DELETE method to delete a key-value pair."},{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."}],"source_content_type":"text/x-rst","patch_set":7,"id":"47a1c0a0_e0ccf25d","line":127,"in_reply_to":"ea10cc1c_edd8fa9c","updated":"2024-06-19 14:04:17.000000000","message":"Acknowledged","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":true,"context_lines":[{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":133,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":7,"id":"fbd0a4a9_5b4d2749","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":69},"updated":"2024-05-17 22:47:50.000000000","message":"I wonder about this ... what you are proposing in this spec is going to be very useful functionality, and I think that operators will want to add metadata to existing (in-use) volume types.  I\u0027m pretty sure that we allow changing the description of in-use volume types because it doesn\u0027t have any effect on existing volumes; the same would be true of volume-type metadata.  And since the idea is that the metadata will be completely ignored by the scheduler, modifying the metadata on a volume type should be OK (though I may be missing something).","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":133,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":7,"id":"88cc129c_19f4b3ed","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":69},"in_reply_to":"fbd0a4a9_5b4d2749","updated":"2024-06-19 14:04:17.000000000","message":"Acknowledged","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d50b45e0771c490319cbb56c661b025049c570e","unresolved":true,"context_lines":[{"line_number":223,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"There will be a documentation needed to separate between the extra specs"},{"line_number":226,"context_line":"and the handling of user visible information. I"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":7,"id":"32c86972_ff4c559b","line":226,"range":{"start_line":226,"start_character":45,"end_line":226,"end_character":47},"updated":"2024-05-17 22:47:50.000000000","message":"extraneous \"I\"?\n\nI do agree about this, it will be important for operators to understand the differences between extra_specs, user-visible extra_specs, and metadata.","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"760ee2d85f3754b8f4a5db42a69fc1db50490df3","unresolved":false,"context_lines":[{"line_number":223,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"There will be a documentation needed to separate between the extra specs"},{"line_number":226,"context_line":"and the handling of user visible information. I"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":7,"id":"616df724_a83acbca","line":226,"range":{"start_line":226,"start_character":45,"end_line":226,"end_character":47},"in_reply_to":"32c86972_ff4c559b","updated":"2024-05-21 07:25:43.000000000","message":"Done","commit_id":"45a1e869fdf3a1073c3e66d374bf7c7ffe4143c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6186035b5dbfe29d5d4385e915cfe3f45cc57db6","unresolved":true,"context_lines":[{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":133,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":8,"id":"b9debc2b_a50cb21c","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":69},"updated":"2024-06-08 17:15:55.000000000","message":"See my comment on PS7.  I still think we do *not* want immutability for volume_type metadata (operators may want to add helpful metadata to their existing volume types).","commit_id":"d0d988c637c82d7aa93efb9ba5a09c24f3c86331"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"9121ed21a4f062a253abb427d370a75d6fc34c3a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":130,"context_line":"This also includes immutability as soon as the volume type is in use."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":133,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":8,"id":"7ed82fa3_710fa6b6","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":69},"in_reply_to":"b9debc2b_a50cb21c","updated":"2024-06-19 14:04:17.000000000","message":"Done","commit_id":"d0d988c637c82d7aa93efb9ba5a09c24f3c86331"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"439ca7253ba517e305f5acf21df84bf4e2b843c7","unresolved":true,"context_lines":[{"line_number":128,"context_line":"- optionally add filtering for certain metadata for the GET volume types method"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":131,"context_line":"Except for th immutability as soon as the volume type is in use."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":134,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":9,"id":"364bc99c_b26a9055","line":131,"range":{"start_line":131,"start_character":11,"end_line":131,"end_character":13},"updated":"2024-06-20 12:33:26.000000000","message":"Since you have to fix the typo anyway, I think you should explicitly say something like:\n\nThe volume-type-metadata will be handled like the volume-type description, that is, we will allow it to be modified even if the volume-type is in use.  We can do this because the volume-type-metadata is only descriptive, as opposed to the volume-type extra_specs that affect the scheduler.","commit_id":"0904701324aa676f13ccad65370213ad8040f1de"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"33e113c608e0f8533700063707d9a95a1bc261e1","unresolved":false,"context_lines":[{"line_number":128,"context_line":"- optionally add filtering for certain metadata for the GET volume types method"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"These new calls should behave the same way as for the volume type extra specs."},{"line_number":131,"context_line":"Except for th immutability as soon as the volume type is in use."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Additionally the create volume type API call should be able to handle key-value"},{"line_number":134,"context_line":"pairs for the new metadata field."}],"source_content_type":"text/x-rst","patch_set":9,"id":"a3bcae29_25bfb0f3","line":131,"range":{"start_line":131,"start_character":11,"end_line":131,"end_character":13},"in_reply_to":"364bc99c_b26a9055","updated":"2024-06-21 06:58:29.000000000","message":"Done","commit_id":"0904701324aa676f13ccad65370213ad8040f1de"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":true,"context_lines":[{"line_number":52,"context_line":"readable, we introduce a new field in the volume type object called \"metadata\"."},{"line_number":53,"context_line":"This will include API changes to address the new view of the volume type as"},{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In API there will be two fields: \"extra_specs\" and \"metadata\" and in CLI those"},{"line_number":58,"context_line":"fields will be \"properties\" and \"metadata\". The latter might confuse users, so"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fdd491e0_2583f2ff","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":74},"updated":"2024-06-27 23:56:43.000000000","message":"This does not make sense to me. I expected a new column, but why have a whole table?\n\nAlso, what is the key of the new table? Let\u0027s say, I have types D1 and D2. One has metadata \"encripted\u003d1\" and another has \"encrypted\u003d0\". How do you propose to place this into a database table?","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"c92403f9a26323e770340e129702a63bee9bc063","unresolved":true,"context_lines":[{"line_number":52,"context_line":"readable, we introduce a new field in the volume type object called \"metadata\"."},{"line_number":53,"context_line":"This will include API changes to address the new view of the volume type as"},{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In API there will be two fields: \"extra_specs\" and \"metadata\" and in CLI those"},{"line_number":58,"context_line":"fields will be \"properties\" and \"metadata\". The latter might confuse users, so"}],"source_content_type":"text/x-rst","patch_set":10,"id":"760f3cd2_7ab31d5b","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":74},"in_reply_to":"0be134e3_1f500d43","updated":"2024-06-28 15:29:45.000000000","message":"Thanks for the explanation and the update.","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"a0dbda4b0b3f870332bd9cc838425db17794fa69","unresolved":true,"context_lines":[{"line_number":52,"context_line":"readable, we introduce a new field in the volume type object called \"metadata\"."},{"line_number":53,"context_line":"This will include API changes to address the new view of the volume type as"},{"line_number":54,"context_line":"well as a new API endpoint to set information as key value pairs for this"},{"line_number":55,"context_line":"metadata field. A new database table for those metadata is also necessary."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In API there will be two fields: \"extra_specs\" and \"metadata\" and in CLI those"},{"line_number":58,"context_line":"fields will be \"properties\" and \"metadata\". The latter might confuse users, so"}],"source_content_type":"text/x-rst","patch_set":10,"id":"0be134e3_1f500d43","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":74},"in_reply_to":"fdd491e0_2583f2ff","updated":"2024-06-28 07:57:51.000000000","message":"A new table is necessary, because you can add more than one  key value pair to each volume type.\nThis was already done for the extra specs (they also have an extra table). The table for the metadata will look very much like the extra specs table:\n\n| id (primary key) | volume_type_id (foreign key) | key | value |\n\nadditional columns are:\n| created_at | updated_at | deleted_at | deleted |\n\nWith a volume type v1 that is encrypted, a volume type v2 that is encrypted and replicated and a volume type v3 that is neither encrypted nor replicated, it will look like this:\n\n| uuid1 | v1 | encrypted  | True |...\n| uuid2 | v2 | encrypted  | True |...\n| uuid3 | v2 | replicated | True |...","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":true,"context_lines":[{"line_number":73,"context_line":"volume scheduler, as EVERY input in the extra_specs table will be evaluated by"},{"line_number":74,"context_line":"the scheduler when looking for a fitting backend for the volume. While this"},{"line_number":75,"context_line":"problem could be solved through a whitelisting or blacklisting approach,"},{"line_number":76,"context_line":"maintaining and evaluating such lists is very intransparant for users. Overall"},{"line_number":77,"context_line":"this approach may lead to even more confusion in users."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Another option is to face use cases individually:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"d1e122f8_5e6b527b","line":76,"updated":"2024-06-27 23:56:43.000000000","message":"opaque","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"a0dbda4b0b3f870332bd9cc838425db17794fa69","unresolved":false,"context_lines":[{"line_number":73,"context_line":"volume scheduler, as EVERY input in the extra_specs table will be evaluated by"},{"line_number":74,"context_line":"the scheduler when looking for a fitting backend for the volume. While this"},{"line_number":75,"context_line":"problem could be solved through a whitelisting or blacklisting approach,"},{"line_number":76,"context_line":"maintaining and evaluating such lists is very intransparant for users. Overall"},{"line_number":77,"context_line":"this approach may lead to even more confusion in users."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Another option is to face use cases individually:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8851627c_d2a27463","line":76,"in_reply_to":"d1e122f8_5e6b527b","updated":"2024-06-28 07:57:51.000000000","message":"Done","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":true,"context_lines":[{"line_number":86,"context_line":"2. Creating an extra field for the encryption in the volume type table, that"},{"line_number":87,"context_line":"is automatically set when creating or deleting an encryption type. This"},{"line_number":88,"context_line":"would need a database change and a change of the view of the volume_types."},{"line_number":89,"context_line":"3 Looking into the different drivers and how they handle internal"},{"line_number":90,"context_line":"configurable replication and whether there are ways to let OpenStack know"},{"line_number":91,"context_line":"this and propagate it to users. This is very hard to achieve, maybe even"},{"line_number":92,"context_line":"impossible without input from an operator, who configured the backends and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"57a446c8_061b28fc","line":89,"updated":"2024-06-27 23:56:43.000000000","message":"3.","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"a0dbda4b0b3f870332bd9cc838425db17794fa69","unresolved":false,"context_lines":[{"line_number":86,"context_line":"2. Creating an extra field for the encryption in the volume type table, that"},{"line_number":87,"context_line":"is automatically set when creating or deleting an encryption type. This"},{"line_number":88,"context_line":"would need a database change and a change of the view of the volume_types."},{"line_number":89,"context_line":"3 Looking into the different drivers and how they handle internal"},{"line_number":90,"context_line":"configurable replication and whether there are ways to let OpenStack know"},{"line_number":91,"context_line":"this and propagate it to users. This is very hard to achieve, maybe even"},{"line_number":92,"context_line":"impossible without input from an operator, who configured the backends and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fdd2e3ba_97676bd2","line":89,"in_reply_to":"57a446c8_061b28fc","updated":"2024-06-28 07:57:51.000000000","message":"Done","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":true,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"To adhere the case of an upgrade from a previous OpenStack version, all volume"},{"line_number":112,"context_line":"types need to be checked and for volume types with associated encryption types,"},{"line_number":113,"context_line":"there need to be an encryption parameter set in the database accordingto the"},{"line_number":114,"context_line":"chosen option. This should not be doable through an API call but will need"},{"line_number":115,"context_line":"direct DB access, as changing the metadata of volume types in use should be"},{"line_number":116,"context_line":"prohibited."}],"source_content_type":"text/x-rst","patch_set":10,"id":"148ceede_59a3a1df","line":113,"updated":"2024-06-27 23:56:43.000000000","message":"\"according to\"","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"a0dbda4b0b3f870332bd9cc838425db17794fa69","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"To adhere the case of an upgrade from a previous OpenStack version, all volume"},{"line_number":112,"context_line":"types need to be checked and for volume types with associated encryption types,"},{"line_number":113,"context_line":"there need to be an encryption parameter set in the database accordingto the"},{"line_number":114,"context_line":"chosen option. This should not be doable through an API call but will need"},{"line_number":115,"context_line":"direct DB access, as changing the metadata of volume types in use should be"},{"line_number":116,"context_line":"prohibited."}],"source_content_type":"text/x-rst","patch_set":10,"id":"60fca169_05baceb4","line":113,"in_reply_to":"148ceede_59a3a1df","updated":"2024-06-28 07:57:51.000000000","message":"Done","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cc21e1cc95060f5a8933b1d13dcc1880bf3f8b3a","unresolved":true,"context_lines":[{"line_number":126,"context_line":"- a DELETE method to delete a key-value pair."},{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":"- optionally add filtering for certain metadata for the GET volume types method"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The volume type metadata will be handled like the volume type description, that"},{"line_number":131,"context_line":"is, we will allow it to be modified even if the volume-type is in use. We can"},{"line_number":132,"context_line":"do this because the volume type metadata is only descriptive, as opposed to the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"e92d0682_19ecc8b0","line":129,"updated":"2024-06-27 23:56:43.000000000","message":"I see why you might want a table, but at least explain its schema.","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"a0dbda4b0b3f870332bd9cc838425db17794fa69","unresolved":false,"context_lines":[{"line_number":126,"context_line":"- a DELETE method to delete a key-value pair."},{"line_number":127,"context_line":"- optionally a GET method to show a key-value pair."},{"line_number":128,"context_line":"- optionally add filtering for certain metadata for the GET volume types method"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The volume type metadata will be handled like the volume type description, that"},{"line_number":131,"context_line":"is, we will allow it to be modified even if the volume-type is in use. We can"},{"line_number":132,"context_line":"do this because the volume type metadata is only descriptive, as opposed to the"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ff4f8f44_470f81aa","line":129,"in_reply_to":"e92d0682_19ecc8b0","updated":"2024-06-28 07:57:51.000000000","message":"Acknowledged","commit_id":"fb7ddbc484a59b23f4a0dd63fd240deab5941a24"}]}