)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"133d7016b088133c01d31e7816f08559299cb3bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9c9b40a0_85f489db","updated":"2026-08-25 13:31:28.000000000","message":"recheck","commit_id":"635294e4672f1776c3bd3d9bd01c7fc08dd8cd04"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc12566cccb5a2ff60739d86b5205e2f3599b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e55bd942_68237906","updated":"2026-08-25 14:43:07.000000000","message":"recheck dependent patch updated","commit_id":"635294e4672f1776c3bd3d9bd01c7fc08dd8cd04"}],"cinder_tempest_plugin/scenario/test_volume_encrypted.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"80642a61aa24fa701649d4f9b74935267a035091","unresolved":true,"context_lines":[{"line_number":192,"context_line":"          filesystem with data, so the underlying RBD image is genuinely"},{"line_number":193,"context_line":"          sparse (interleaved zero and non-zero regions -- a LUKS volume"},{"line_number":194,"context_line":"          with a journal is the normal case)"},{"line_number":195,"context_line":"        * Detach the volume and create a backup of it (the deployment is"},{"line_number":196,"context_line":"          expected to use cinder.backup.drivers.ceph.CephBackupDriver)"},{"line_number":197,"context_line":"        * Restore the backup WITHOUT an existing target, so Cinder creates"},{"line_number":198,"context_line":"          a new volume (volume_is_new \u003d True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc80d05a_529c4ed3","line":195,"updated":"2026-08-24 09:11:48.000000000","message":"I don\u0027t think we can have an implicit dependency on a specific backend, not this way anyway. Maybe a conditional on a variable (cinder_backup_supports_sparse?)","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c55f5ecc0b7f499b91296582c39bff7d8c52f8bb","unresolved":true,"context_lines":[{"line_number":192,"context_line":"          filesystem with data, so the underlying RBD image is genuinely"},{"line_number":193,"context_line":"          sparse (interleaved zero and non-zero regions -- a LUKS volume"},{"line_number":194,"context_line":"          with a journal is the normal case)"},{"line_number":195,"context_line":"        * Detach the volume and create a backup of it (the deployment is"},{"line_number":196,"context_line":"          expected to use cinder.backup.drivers.ceph.CephBackupDriver)"},{"line_number":197,"context_line":"        * Restore the backup WITHOUT an existing target, so Cinder creates"},{"line_number":198,"context_line":"          a new volume (volume_is_new \u003d True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d442cd97_006a8838","line":195,"in_reply_to":"cc80d05a_529c4ed3","updated":"2026-08-24 11:10:03.000000000","message":"Right, right. Maybe we can use the get-capabilities operation to check whether the backend supports this, instead of adding a new configuration parameter.","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c4cd3903bc598a96335ac8e7eb09bc5c01f1b4be","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Restore the backup without a target -\u003e Cinder creates a new volume"},{"line_number":240,"context_line":"        restore \u003d self.restore_backup(backup[\u0027id\u0027])"},{"line_number":241,"context_line":"        restored_volume \u003d self.volumes_client.show_volume("},{"line_number":242,"context_line":"            restore[\u0027volume_id\u0027])[\u0027volume\u0027]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8a2f4708_4c924f3f","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":51},"updated":"2026-08-25 09:39:46.000000000","message":"This is the place where the tests are failing due to the following reason\n\nThe volume ID used to create the source volume (before backup) was tempest-scenario-type-luks-1598011299 which was an encrypted volume type\n\nid\u003d6d282ff5-cc6c-4377-b9c0-b9d7cb80820d, name\u003d\u0027tempest-scenario-type-luks-1598011299\u0027\n\nDuring restore we don\u0027t provide any volume type so it takes the default volume type that is unencrypted i.e. ceph\n\ndefault_volume_type \u003d ceph\n\nid\u003d17a3943c-1521-432a-bb92-5cd621b3abd3,name\u003d\u0027ceph\u0027\n\nHence we fail with the following error\n\nAug 24 08:47:02.281349 np314868711ef84 cinder-backup[109400]: ERROR cinder.backup.manager cinder.exception.EncryptedBackupOperationFailed: The source volume type \u00276d282ff5-cc6c-4377-b9c0-b9d7cb80820d\u0027 is different than the destination volume type \u002717a3943c-1521-432a-bb92-5cd621b3abd3\u0027.\n\nIf we pass the source volume type during restore, this should make the test pass\n\nhere is the code that causes this to fail\n\nhttps://github.com/openstack/cinder/blob/b7831e8de01aa78801a53a534ef75b88680a8722/cinder/backup/driver.py#L235-L245","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"deb03dc4e5788845e8cff324c0647a98a8bc548f","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Restore the backup without a target -\u003e Cinder creates a new volume"},{"line_number":240,"context_line":"        restore \u003d self.restore_backup(backup[\u0027id\u0027])"},{"line_number":241,"context_line":"        restored_volume \u003d self.volumes_client.show_volume("},{"line_number":242,"context_line":"            restore[\u0027volume_id\u0027])[\u0027volume\u0027]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b83fbd67_da58c34e","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":51},"in_reply_to":"1d8ab57b_bee7a0d6","updated":"2026-08-25 13:41:47.000000000","message":"It doesn\u0027t seem to have fixed the issue.\n\nThe source volume type \u002779d5a75a-f86c-40ef-841f-fcc0748c3b48\u0027 is different than the destination volume type \u00272c57905a-cfdc-4ac5-ab2e-4edf6aca2720\u0027.","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"86c3d9ec3f1f30930eae7a06353e101f1e950ee5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Restore the backup without a target -\u003e Cinder creates a new volume"},{"line_number":240,"context_line":"        restore \u003d self.restore_backup(backup[\u0027id\u0027])"},{"line_number":241,"context_line":"        restored_volume \u003d self.volumes_client.show_volume("},{"line_number":242,"context_line":"            restore[\u0027volume_id\u0027])[\u0027volume\u0027]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1d8ab57b_bee7a0d6","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":51},"in_reply_to":"36b3b367_2576a80e","updated":"2026-08-25 12:11:40.000000000","message":"Done","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"610fbccbeb09cc8c3885b59776996ac39ca06909","unresolved":true,"context_lines":[{"line_number":237,"context_line":"        backup \u003d self.create_backup(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Restore the backup without a target -\u003e Cinder creates a new volume"},{"line_number":240,"context_line":"        restore \u003d self.restore_backup(backup[\u0027id\u0027])"},{"line_number":241,"context_line":"        restored_volume \u003d self.volumes_client.show_volume("},{"line_number":242,"context_line":"            restore[\u0027volume_id\u0027])[\u0027volume\u0027]"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"36b3b367_2576a80e","line":240,"range":{"start_line":240,"start_character":8,"end_line":240,"end_character":51},"in_reply_to":"8a2f4708_4c924f3f","updated":"2026-08-25 10:57:12.000000000","message":"So the backup restore API doesn\u0027t accept volume type so this looks like a bug when restoring we don\u0027t set the right type but we\u0027ve 2 options\n1. add depends-on the patch and see if it fixes the issue https://review.opendev.org/c/openstack/cinder/+/1002251\n2. Use the create API to restore the backup which accepts a volume type","commit_id":"7a5589b4c1e06e8a0c8df103dfbeccf261340686"}]}