)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f70743ff6236a289e7b2183264b85e247d4a1a63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test to restore from an incremental backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of f7409cdb429a55d8a6ea766ae4dc124fae76106f"},{"line_number":10,"context_line":"it\u0027s important to test restore from incremental"},{"line_number":11,"context_line":"backups."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_d1eb89d9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":51},"updated":"2019-04-16 11:28:44.000000000","message":"the dependency of the linked patch cannot be seen in the added test case.\nto show dependency between the two, either we can \n1) create a second full backup\n2) create incr backup on top of it\n3) restore that incr backup\n(also would require Depends-On: Tag as commented on the other patch)\n\nor just modify the commit msg to mention extending the testing scope by adding test to restore from incr backup.","commit_id":"42fc11f4b2806b8d4f6d1982ba408c49fd311f0b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2e11c56a8040912b90847f9f319417981e218ba2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-16 21:52:57 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extending the testing scope by adding test to restore from incr backup."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because of f7409cdb429a55d8a6ea766ae4dc124fae76106f"},{"line_number":10,"context_line":"it\u0027s important to test restore from incremental"},{"line_number":11,"context_line":"backups."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Steps:"},{"line_number":14,"context_line":"1. create a second full backup"},{"line_number":15,"context_line":"2. create incr backup on top of it"},{"line_number":16,"context_line":"3. restore that incr backup"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: I516b7c82b05b26e81195f7f106d43a9e0804082d"},{"line_number":19,"context_line":"Change-Id: I10272d737bbe3b196dfaf6ce242c8ccdf0787f5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fce034c_40db301a","line":16,"range":{"start_line":7,"start_character":0,"end_line":16,"end_character":27},"updated":"2019-04-17 07:29:43.000000000","message":"i think my comment was completely misunderstood.\nyou can do this patch in 2 ways :\n\nThe steps i wrote was to be implemented in the test case\n\nOR\n\nwe can keep the test case same but update the commit msg with the line written as the heading here L#7","commit_id":"57d649d10140369fc0d5b056ef091726d028d3a3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d0e185a58b6a5ab86ff23b373e894ef3ab44ddde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajat Dhasmana \u003crajatdhasmana@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-17 07:31:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extending testing scope of Incremental Backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the test to restore from an incremental backup."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I10272d737bbe3b196dfaf6ce242c8ccdf0787f5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fce034c_802838e2","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":63},"updated":"2019-04-17 07:33:26.000000000","message":"I\u0027ve updated the commit msg for your current test.\nIf you feel like updating the test case, then kindly update the commit msg from my past comments.","commit_id":"f53e1ab604b9bcb76916ff1624247f346dc21fc1"}],"cinder_tempest_plugin/api/volume/test_volume_backup.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a6502bba1c1335a038b838e7e5843790be841e63","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027b5d837b0-7066-455d-88fc-4a721a899306\u0027)"},{"line_number":71,"context_line":"    def test_incr_backup_create_and_restore_to_an_existing_volume(self):"},{"line_number":72,"context_line":"        \"\"\"Test incr backup create and restore to an existing volume.\"\"\""},{"line_number":73,"context_line":"        # Create volume"},{"line_number":74,"context_line":"        src_vol \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_bde7bbe4","line":71,"updated":"2020-04-15 14:55:47.000000000","message":"Really would be nice to write some data in between these steps and verify, but that can be an exercise for the future.","commit_id":"efef4f5feceadb7f114e277c934ef3b3721fa331"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5a4209691eaa310b6f7b8156e0ae8c274e7713ba","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027b5d837b0-7066-455d-88fc-4a721a899306\u0027)"},{"line_number":71,"context_line":"    def test_incr_backup_create_and_restore_to_an_existing_volume(self):"},{"line_number":72,"context_line":"        \"\"\"Test incr backup create and restore to an existing volume.\"\"\""},{"line_number":73,"context_line":"        # Create volume"},{"line_number":74,"context_line":"        src_vol \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_4808772b","line":71,"in_reply_to":"3f4c43b2_08db0fed","updated":"2020-04-15 15:52:07.000000000","message":"Yeah, either nova, or we can use some mechanism like we have today where the volumes get mapped to the cinder node for image transfers.","commit_id":"efef4f5feceadb7f114e277c934ef3b3721fa331"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4fc34ddce6c2906daade13023f673c3b4f1116dc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027b5d837b0-7066-455d-88fc-4a721a899306\u0027)"},{"line_number":71,"context_line":"    def test_incr_backup_create_and_restore_to_an_existing_volume(self):"},{"line_number":72,"context_line":"        \"\"\"Test incr backup create and restore to an existing volume.\"\"\""},{"line_number":73,"context_line":"        # Create volume"},{"line_number":74,"context_line":"        src_vol \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_5b5afc4e","line":71,"in_reply_to":"3f4c43b2_4808772b","updated":"2020-04-15 18:58:31.000000000","message":"Hi Sean, I\u0027ve been looking for this mechanism without luck. Is it on the Tempest project?","commit_id":"efef4f5feceadb7f114e277c934ef3b3721fa331"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"91c7c6f5a1d6017ebb203052d7880af9c0459f78","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        self.assertEqual(backup[\u0027id\u0027], restore[\u0027backup_id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @decorators.idempotent_id(\u0027b5d837b0-7066-455d-88fc-4a721a899306\u0027)"},{"line_number":71,"context_line":"    def test_incr_backup_create_and_restore_to_an_existing_volume(self):"},{"line_number":72,"context_line":"        \"\"\"Test incr backup create and restore to an existing volume.\"\"\""},{"line_number":73,"context_line":"        # Create volume"},{"line_number":74,"context_line":"        src_vol \u003d self.create_volume()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_08db0fed","line":71,"in_reply_to":"3f4c43b2_bde7bbe4","updated":"2020-04-15 15:44:32.000000000","message":"We need that also for test_backup_create_and_restore_to_an_existing_volume, so both could be fixed. But then won\u0027t the tests require nova, as the test below?","commit_id":"efef4f5feceadb7f114e277c934ef3b3721fa331"}]}