)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9ee0ddc43f31562c400db877cafc4bdbc863b3c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Benny Kopilov \u003cbkopilov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-24 15:03:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add testcase to verify disk size after snapshot create"},{"line_number":8,"context_line":"when attached to an instance."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"testcase for clear volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_71579b5b","line":7,"updated":"2019-11-25 10:28:52.000000000","message":"Also, please reduce the \"subject\" part of the commit message to just one line.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Benny Kopilov \u003cbkopilov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-24 15:03:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add testcase to verify disk size after snapshot create"},{"line_number":8,"context_line":"when attached to an instance."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"testcase for clear volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_75e8e479","line":7,"in_reply_to":"3fa7e38b_71579b5b","updated":"2019-11-25 13:47:39.000000000","message":"ok","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"}],"cinder_tempest_plugin/scenario/manager.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class ScenarioTest(manager.ScenarioTest):"},{"line_number":25,"context_line":"    \"\"\"This class inherits from tempest ScenarioTest\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \"admin\"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_71523b14","line":27,"updated":"2019-11-25 10:07:40.000000000","message":"nit: can you please use the same quote style also for admin? \u0027admin\u0027","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class ScenarioTest(manager.ScenarioTest):"},{"line_number":25,"context_line":"    \"\"\"This class inherits from tempest ScenarioTest\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    credentials \u003d [\u0027primary\u0027, \"admin\"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cc65981e","line":27,"in_reply_to":"3fa7e38b_71523b14","updated":"2019-11-25 13:47:39.000000000","message":"Done","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                            server\u003dserver)"},{"line_number":47,"context_line":"        lsblk \u003d ssh_client.exec_command(\"/usr/bin/sudo lsblk /dev/%s -lb|\""},{"line_number":48,"context_line":"                                        \" grep -v NAME|\""},{"line_number":49,"context_line":"                                        \" awk \u0027{print $4}\u0027\" % dev_name)"},{"line_number":50,"context_line":"        lsblk_bytes \u003d lsblk.strip()"},{"line_number":51,"context_line":"        return lsblk_bytes"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_71047b14","line":49,"updated":"2019-11-25 10:07:40.000000000","message":"In other please where sudo is used there is no path, it\u0027s just \"sudo\".\n\nYou can pass -n to lsblk to suppress the header line, so you don\u0027t need the grep (and in any case awk supports negative matching with \u0027!/PATTERN/ {...}\u0027.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                            server\u003dserver)"},{"line_number":47,"context_line":"        lsblk \u003d ssh_client.exec_command(\"/usr/bin/sudo lsblk /dev/%s -lb|\""},{"line_number":48,"context_line":"                                        \" grep -v NAME|\""},{"line_number":49,"context_line":"                                        \" awk \u0027{print $4}\u0027\" % dev_name)"},{"line_number":50,"context_line":"        lsblk_bytes \u003d lsblk.strip()"},{"line_number":51,"context_line":"        return lsblk_bytes"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cc4ef894","line":49,"in_reply_to":"3fa7e38b_71047b14","updated":"2019-11-25 13:47:39.000000000","message":"thanks , doing it","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        lsblk \u003d ssh_client.exec_command(\"/usr/bin/sudo lsblk /dev/%s -lb|\""},{"line_number":48,"context_line":"                                        \" grep -v NAME|\""},{"line_number":49,"context_line":"                                        \" awk \u0027{print $4}\u0027\" % dev_name)"},{"line_number":50,"context_line":"        lsblk_bytes \u003d lsblk.strip()"},{"line_number":51,"context_line":"        return lsblk_bytes"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9107b717","line":50,"updated":"2019-11-25 10:07:40.000000000","message":"Force a int() here?","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        lsblk \u003d ssh_client.exec_command(\"/usr/bin/sudo lsblk /dev/%s -lb|\""},{"line_number":48,"context_line":"                                        \" grep -v NAME|\""},{"line_number":49,"context_line":"                                        \" awk \u0027{print $4}\u0027\" % dev_name)"},{"line_number":50,"context_line":"        lsblk_bytes \u003d lsblk.strip()"},{"line_number":51,"context_line":"        return lsblk_bytes"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ac305c08","line":50,"in_reply_to":"3fa7e38b_9107b717","updated":"2019-11-25 13:47:39.000000000","message":"sure ,why not. done","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e8fe4003520491025a7c914f4521332a60d666ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2013 Redhat Corp."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d32bc9e7","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"updated":"2019-11-27 16:01:54.000000000","message":"OpenStack Foundation is incorrect here","commit_id":"7898cfb9ad7e151cef7650d6e072c5a929f5034b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"23e2f53a6f1f183014fe482af58004eeafa1ebda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2013 Redhat Corp."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d37989fb","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":37},"in_reply_to":"3fa7e38b_d32bc9e7","updated":"2019-11-27 16:03:27.000000000","message":"For reference: https://wiki.openstack.org/wiki/LegalIssuesFAQ#OpenStack_Foundation_Copyright_Headers","commit_id":"7898cfb9ad7e151cef7650d6e072c5a929f5034b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e8fe4003520491025a7c914f4521332a60d666ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2013 Redhat Corp."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5337d94c","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":29},"updated":"2019-11-27 16:01:54.000000000","message":"This would be \"Red Hat, Inc.\" but probably better to just drop these...","commit_id":"7898cfb9ad7e151cef7650d6e072c5a929f5034b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70f7f114503859df8d0abad805e95e74c4619166","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"},{"line_number":31,"context_line":"        super(ScenarioTest, cls).resource_setup()"},{"line_number":32,"context_line":"        cls.VOLUME_SIZE_BYTES \u003d 1073741824 * CONF.volume.volume_size"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_9e522612","line":32,"range":{"start_line":32,"start_character":32,"end_line":32,"end_character":42},"updated":"2019-11-28 16:17:27.000000000","message":"nit: would be good to use oslo_utils.units.Gi for this, or even 1024 ** 3 -- makes it easier to be sure a digit isn\u0027t dropped or transposed here.","commit_id":"e5c5dee762fa17e33627bf19f854e77bdd148f7b"}],"cinder_tempest_plugin/scenario/test_volume_disk_size_when_attached.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(TestVolumeDiskSizeWhenAttached, self).setUp()"},{"line_number":36,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":37,"context_line":"        self.volume \u003d self.create_volume(volume_type\u003dself.volume_type[\u0027name\u0027])"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d191af47","line":36,"updated":"2019-11-25 10:07:40.000000000","message":"See the other comment about create_volume_type","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(TestVolumeDiskSizeWhenAttached, self).tearDown()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"},{"line_number":43,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":44,"context_line":"        # prepare for booting an instance"},{"line_number":45,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        volume_from_snapshot \u003d self.create_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3676f9d9","line":43,"updated":"2019-11-25 10:07:40.000000000","message":"I think that a check against CONF.compute_feature_enabled.snapshot is needed\n    @testtools.skipUnless(CONF.compute_feature_enabled.snapshot,\n                          \u0027Snapshotting is not available.\u0027)","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(TestVolumeDiskSizeWhenAttached, self).tearDown()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"},{"line_number":43,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":44,"context_line":"        # prepare for booting an instance"},{"line_number":45,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        volume_from_snapshot \u003d self.create_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7220fa9a","line":43,"in_reply_to":"3fa7e38b_3676f9d9","updated":"2019-11-25 13:47:39.000000000","message":"Compute snapshots are for glance (snapshot from instance)  your point is clear and i will fix it.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4271926c2c9e935bd5373a8eade59bd02fc9f708","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        super(TestVolumeDiskSizeWhenAttached, self).tearDown()"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"},{"line_number":43,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":44,"context_line":"        # prepare for booting an instance"},{"line_number":45,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        volume_from_snapshot \u003d self.create_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9b27d1b6","line":43,"in_reply_to":"3fa7e38b_7220fa9a","updated":"2019-11-25 14:43:49.000000000","message":"You are right, wrong copy-and-paste; I meant volume-feature-enabled.snapshot.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"},{"line_number":43,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":44,"context_line":"        # prepare for booting an instance"},{"line_number":45,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":47,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dself.volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b1d19359","line":44,"updated":"2019-11-25 10:07:40.000000000","message":"Can you please add a long description of the test case here? Something along the lines of:\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_volume_migrate_attached.py#L27\n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_object_storage_basic_ops.py#L25","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @decorators.idempotent_id(\u00273d59f8ef-ff5e-4563-8741-d194cda4ab6a\u0027)"},{"line_number":43,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":44,"context_line":"        # prepare for booting an instance"},{"line_number":45,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":46,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":47,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dself.volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_120d063d","line":44,"in_reply_to":"3fa7e38b_b1d19359","updated":"2019-11-25 13:47:39.000000000","message":"Done","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"}],"cinder_tempest_plugin/scenario/test_volume_encrypted_disk_size_when_attached.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).setUp()"},{"line_number":40,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":41,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":42,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":43,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_51785f29","line":40,"updated":"2019-11-25 10:07:40.000000000","message":"create_volume_type randomizes the backend by default. \nWhile we may want to run this test with just one backend, it would be worth to use a specific backend.\n\nWe could always use CONF.volume.backend_names[0], if CONF.volume.backend_names is defined?","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4271926c2c9e935bd5373a8eade59bd02fc9f708","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).setUp()"},{"line_number":40,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":41,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":42,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":43,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_db178945","line":40,"in_reply_to":"3fa7e38b_156970bc","updated":"2019-11-25 14:43:49.000000000","message":"It does affect this test. If this test is executed against a system where multiple backends are defined, then right now it will run against a random one.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9ed68036c5a657269b017b8ffa62155150a66165","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).setUp()"},{"line_number":40,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":41,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":42,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":43,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_26fec437","line":40,"in_reply_to":"3fa7e38b_1be68117","updated":"2019-11-27 15:59:48.000000000","message":"Or just pass the backend here for now. create_volume_type supports it.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).setUp()"},{"line_number":40,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":41,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":42,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":43,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_156970bc","line":40,"in_reply_to":"3fa7e38b_51785f29","updated":"2019-11-25 13:47:39.000000000","message":"This is a good issue you raise but why to do it in this test case only, what about other tests. we may define this in more global way to all tests when having multiple backends. \nNot sure if its the scope of this test .","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"b9ef59fe3dbc04cd3da6c73d46ac75c4c8e471f3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).setUp()"},{"line_number":40,"context_line":"        self.volume_type \u003d self.create_volume_type()"},{"line_number":41,"context_line":"        kwargs \u003d {\u0027provider\u0027: \u0027nova.volume.encryptors.luks.LuksEncryptor\u0027,"},{"line_number":42,"context_line":"                  \u0027key_size\u0027: 256,"},{"line_number":43,"context_line":"                  \u0027cipher\u0027: \u0027aes-xts-plain64\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1be68117","line":40,"in_reply_to":"3fa7e38b_db178945","updated":"2019-11-25 15:04:34.000000000","message":"Yes , its true to all tests when having multiple backend , we can add a tweak in create function and push there the backend[location] .....  i like the idea . one day when we will have a big setup we can do it","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":54,"context_line":"    @decorators.skip_because(bug\u003d\"1852168\")"},{"line_number":55,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":56,"context_line":"        # prepare for booting an instance"},{"line_number":57,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f1994b79","line":54,"updated":"2019-11-25 10:07:40.000000000","message":"This skip bug depends on a specific backend; maybe we need to depend on the backend, somehow (see above)\nhttps://bugs.launchpad.net/cinder/+bug/1852168","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(TestVolumeEncryptedDiskSizeWhenAttached, self).tearDown()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":54,"context_line":"    @decorators.skip_because(bug\u003d\"1852168\")"},{"line_number":55,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":56,"context_line":"        # prepare for booting an instance"},{"line_number":57,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b59dfcbb","line":54,"in_reply_to":"3fa7e38b_f1994b79","updated":"2019-11-25 13:47:39.000000000","message":"Agree , i will skip this test only for ceph.","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"898bb5303041aade0df4b7806af9d0da93723408","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":54,"context_line":"    @decorators.skip_because(bug\u003d\"1852168\")"},{"line_number":55,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":56,"context_line":"        # prepare for booting an instance"},{"line_number":57,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":58,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":59,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dself.volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d18c4f36","line":56,"updated":"2019-11-25 10:07:40.000000000","message":"As this basically the same code as the previous test, and it is intended to be, couldn\u0027t the shared code be refactored somehow? \n(as a side effect, it could be easily used also by a future hypothetical test in barbican_tempest_plugin without duplicating the logic.)","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"68750f2373ac0290b1679f41925f78fb12396872","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":54,"context_line":"    @decorators.skip_because(bug\u003d\"1852168\")"},{"line_number":55,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":56,"context_line":"        # prepare for booting an instance"},{"line_number":57,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":58,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":59,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dself.volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_55a048f3","line":56,"in_reply_to":"3fa7e38b_d18c4f36","updated":"2019-11-25 13:47:39.000000000","message":"Done","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"b9ef59fe3dbc04cd3da6c73d46ac75c4c8e471f3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":54,"context_line":"    @decorators.skip_because(bug\u003d\"1852168\")"},{"line_number":55,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":56,"context_line":"        # prepare for booting an instance"},{"line_number":57,"context_line":"        snapshot \u003d self.create_volume_snapshot(volume_id\u003dself.volume[\u0027id\u0027])"},{"line_number":58,"context_line":"        volume_from_snapshot \u003d self.create_volume("},{"line_number":59,"context_line":"            snapshot_id\u003dsnapshot[\u0027id\u0027], volume_type\u003dself.volume_type[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5b7f1916","line":56,"in_reply_to":"3fa7e38b_d18c4f36","updated":"2019-11-25 15:04:34.000000000","message":"Yes , i thought about re-using the code here. setup() will run the volume create or encrypted one but i would like to add more tests for verify disks like backup /  restore and more.  the name of the testcase is disk_size_when_attached.. so we can add here many cases .\nwhat do you think ?","commit_id":"250a8da56528d6a4777785f5f45c11bffe0ce4a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"84a223772b204c10d2529a33c87e7dfc73f02e85","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":53,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":54,"context_line":"                          \u0027Snapshotting is not available.\u0027)"},{"line_number":55,"context_line":"    @decorators.skip_because(bug\u003d\u00271852168\u0027)"},{"line_number":56,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":57,"context_line":"        \"\"\"Test to verify disk size for encrypted volume created from snapshot"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7d5a7b50","line":55,"updated":"2019-12-05 14:24:38.000000000","message":"IMO if we are going to always skip this test, we should just split this one into a second patch and merge it later rather than in this review...","commit_id":"8381bb90a22faef047987e19a7c62285ab42d497"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a05f1b630fa8ff8f27581f143c6e0d359c971a2b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":53,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":54,"context_line":"                          \u0027Snapshotting is not available.\u0027)"},{"line_number":55,"context_line":"    @decorators.skip_because(bug\u003d\u00271852168\u0027)"},{"line_number":56,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":57,"context_line":"        \"\"\"Test to verify disk size for encrypted volume created from snapshot"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_031cf674","line":55,"in_reply_to":"3fa7e38b_7bc92058","updated":"2019-12-11 16:55:01.000000000","message":"We don\u0027t have any way to run this and see if it works, and if we merge it, it will just be here and nobody will run it -- so why merge it now?","commit_id":"8381bb90a22faef047987e19a7c62285ab42d497"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"004cdc623629a5964259b8f80c7d03d1a792c2cd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @decorators.idempotent_id(\u002708b00328-35cc-4b19-8705-1a2bd6280680\u0027)"},{"line_number":53,"context_line":"    @testtools.skipUnless(CONF.volume_feature_enabled.snapshot,"},{"line_number":54,"context_line":"                          \u0027Snapshotting is not available.\u0027)"},{"line_number":55,"context_line":"    @decorators.skip_because(bug\u003d\u00271852168\u0027)"},{"line_number":56,"context_line":"    def test_volume_disk_create_volume_from_snapshot(self):"},{"line_number":57,"context_line":"        \"\"\"Test to verify disk size for encrypted volume created from snapshot"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_7bc92058","line":55,"in_reply_to":"3fa7e38b_7d5a7b50","updated":"2019-12-05 18:00:03.000000000","message":"is something that blocking us for merging this code ?\nThe code is the same as the other class. \nPlease let me know.","commit_id":"8381bb90a22faef047987e19a7c62285ab42d497"}]}