)]}'
{"id":"openstack%2Fcinder-tempest-plugin~695970","triplet_id":"openstack%2Fcinder-tempest-plugin~master~I67eb5a97dc6cc96db5d4283f4d577de9f12653eb","project":"openstack/cinder-tempest-plugin","branch":"master","hashtags":[],"change_id":"I67eb5a97dc6cc96db5d4283f4d577de9f12653eb","subject":"Remove duplicate code - base inherited from tempest","status":"ABANDONED","created":"2019-11-25 18:53:11.000000000","updated":"2021-03-02 13:33:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7cfc5ad0af788840adeb4d3b7f80e632d09d4326","_number":695970,"virtual_id_number":695970,"owner":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2019-11-26 06:17:47.000000000","_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"date":"2019-11-25 21:28:10.000000000","_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-11-25 20:15:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"date":"2019-11-25 23:10:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},{"value":0,"date":"2021-03-02 13:32:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":-1,"date":"2019-11-25 22:57:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-12-16 17:15:10.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},{"value":0,"date":"2019-11-25 20:22:23.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"value":0,"date":"2019-11-25 20:22:13.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"date":"2019-11-25 20:22:00.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-25 20:15:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-25 20:22:00.000000000","updated_by":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"reviewer":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"state":"REVIEWER"},{"updated":"2019-11-25 20:22:13.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-11-25 20:22:23.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-11-25 21:28:10.000000000","updated_by":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-11-25 22:57:20.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2019-11-25 23:10:30.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-11-25 23:21:21.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2020-12-16 17:15:10.000000000","updated_by":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"reviewer":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"state":"REVIEWER"}],"messages":[{"id":"1ddb336949998ee48b1a6448145f9280ffb5455d","author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"date":"2019-11-25 18:53:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"157404b72564ce849dbf02b50b821df6ff1ce383","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-25 20:15:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cd2c373c956e4e1ba7701fc48756c8b1 : SUCCESS in 3m 24s\n- cinder-tempest-plugin-lvm-lio https://zuul.opendev.org/t/openstack/build/0ae0e8c245f14b2599e259220f2b8e66 : SUCCESS in 1h 16m 14s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/c4953ff619354bc89641fb5800f03dc6 : SUCCESS in 1h 19m 59s","accounts_in_message":[],"_revision_number":1},{"id":"a5e3c52cc785ffe3e1e003ef90795f1c56bff327","author":{"_account_id":25243,"name":"NetApp CI","username":"NetApp-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2019-11-25 21:28:10.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- cinder-cDOT-iSCSI-cinder-tempest-plugin http://logs.openstack.netapp.com/logs/70/695970/1/upstream-check/cinder-cDOT-iSCSI-cinder-tempest-plugin/0f16892/ : SUCCESS in 53m 20s\n- cinder-cDOT-NFS-cinder-tempest-plugin http://logs.openstack.netapp.com/logs/70/695970/1/upstream-check/cinder-cDOT-NFS-cinder-tempest-plugin/7dfe3aa/ : SUCCESS in 34m 58s\n- cinder-cDOT-NFS-cinder-tempest-plugin-IPv6 http://logs.openstack.netapp.com/logs/70/695970/1/upstream-check/cinder-cDOT-NFS-cinder-tempest-plugin-IPv6/fce463b/ : SUCCESS in 1h 12m 42s\n- cinder-cDOT-FCP-cinder-tempest-plugin http://logs.openstack.netapp.com/logs/70/695970/1/upstream-check/cinder-cDOT-FCP-cinder-tempest-plugin/9955782/ : FAILURE in 53m 43s\n- cinder-solidfire-iSCSI-cinder-tempest-plugin http://logs.openstack.netapp.com/logs/70/695970/1/upstream-check/cinder-solidfire-iSCSI-cinder-tempest-plugin/3b06851/ : SUCCESS in 38m 55s\n\nComment \u0027run-netapp-ci\u0027 or \u0027netapp-ci-recheck\u0027 to rerun these tests. https://wiki.openstack.org/wiki/ThirdPartySystems/NetApp_CI","accounts_in_message":[],"_revision_number":1},{"id":"15716ca6079cee85b602ef609243b5e56e5d6553","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-11-25 21:52:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ae7a8faca3113c9f164d8595fe7adfdbfda935d4","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-11-25 22:04:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"839d55537ddbe524416f5a863286fcaf66e97ba9","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-11-25 22:05:52.000000000","message":"Patch Set 1:\n\nNow that I notice it, we should also discuss (in future) whether switch _api_version to 3 instead of 2.","accounts_in_message":[],"_revision_number":1},{"id":"dc19b9dcd76de07c0a2fb43f79facdf61387ae07","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2019-11-25 22:57:20.000000000","message":"Patch Set 1: Code-Review-1\n\nThis was done intentionally in https://review.opendev.org/#/c/533118/1\n\nTempest plugins should use only stable interfaces from Tempest otherwise it will break the plugin.\nstable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use","accounts_in_message":[],"_revision_number":1},{"id":"de60d22a47c4915d04619236741632a4fbd9f160","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-11-25 23:10:30.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"8901c22ab27ea8f5b42fe3f0319208cee9a4de13","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-11-25 23:21:21.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"9ec38174dd94af6d68ba7f008d3e202cb42effe9","author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"date":"2019-11-26 06:17:35.000000000","message":"Patch Set 1:\n\n\u003e This was done intentionally in https://review.opendev.org/#/c/533118/1\n \u003e \n \u003e Tempest plugins should use only stable interfaces from Tempest\n \u003e otherwise it will break the plugin.\n \u003e stable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use\n\n\nSo what would you suggest ? there are many plugins and they dulicate the same code ... ?? it does not a good practice.  Anyway if someone change the \"base\" code it should support backward.  Cant we add the Base codeto stable ?","accounts_in_message":[],"_revision_number":1},{"id":"00dd2ecc0559fa7ca380329a43cd196109043911","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2019-11-26 17:36:57.000000000","message":"Patch Set 1:\n\n\u003e \u003e This was done intentionally in https://review.opendev.org/#/c/533118/1\n \u003e \u003e\n \u003e \u003e Tempest plugins should use only stable interfaces from Tempest\n \u003e \u003e otherwise it will break the plugin.\n \u003e \u003e stable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use\n \u003e \n \u003e \n \u003e So what would you suggest ? there are many plugins and they\n \u003e dulicate the same code ... ?? it does not a good practice.  Anyway\n \u003e if someone change the \"base\" code it should support backward.  Cant\n \u003e we add the Base codeto stable ?\n\nThere should not be duplicate code for more than one or two  plugins as those base class are very specific to single services test cases. for example tempest/api/volume/base.py is only for volume API common method. \n\nWe did not make them stable because it is hard to maintain them in stable way. These keep changing or new tests case added and break plugins. \n\nTo avoid plugin break, few duplicate code is ok which is not so hard to maintain. If there is a function that is used by majority of plugins then we can check possibility of making that function only as stable interface.","accounts_in_message":[],"_revision_number":1},{"id":"57e0f0259b2740388d8b61e9229eb9205f69879a","author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"date":"2020-12-16 17:15:10.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e \u003e This was done intentionally in https://review.opendev.org/#/c/533118/1\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e Tempest plugins should use only stable interfaces from Tempest\n\u003e  \u003e \u003e otherwise it will break the plugin.\n\u003e  \u003e \u003e stable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use\n\u003e  \u003e \n\u003e  \u003e \n\u003e  \u003e So what would you suggest ? there are many plugins and they\n\u003e  \u003e dulicate the same code ... ?? it does not a good practice.  Anyway\n\u003e  \u003e if someone change the \"base\" code it should support backward.  Cant\n\u003e  \u003e we add the Base codeto stable ?\n\u003e \n\u003e There should not be duplicate code for more than one or two  plugins as those base class are very specific to single services test cases. for example tempest/api/volume/base.py is only for volume API common method. \n\u003e \n\u003e We did not make them stable because it is hard to maintain them in stable way. These keep changing or new tests case added and break plugins. \n\u003e \n\u003e To avoid plugin break, few duplicate code is ok which is not so hard to maintain. If there is a function that is used by majority of plugins then we can check possibility of making that function only as stable interface.\n\nI guess we should close this patch then.","accounts_in_message":[],"_revision_number":1},{"id":"ddd7d2e8bfa74b153f8b24465601493dba08ee30","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2020-12-17 09:55:12.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e \u003e This was done intentionally in https://review.opendev.org/#/c/533118/1\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e Tempest plugins should use only stable interfaces from Tempest\n\u003e  \u003e \u003e otherwise it will break the plugin.\n\u003e  \u003e \u003e stable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use\n\u003e  \u003e \n\u003e  \u003e \n\u003e  \u003e So what would you suggest ? there are many plugins and they\n\u003e  \u003e dulicate the same code ... ?? it does not a good practice.  Anyway\n\u003e  \u003e if someone change the \"base\" code it should support backward.  Cant\n\u003e  \u003e we add the Base codeto stable ?\n\u003e \n\u003e There should not be duplicate code for more than one or two  plugins as those base class are very specific to single services test cases. for example tempest/api/volume/base.py is only for volume API common method. \n\u003e \n\u003e We did not make them stable because it is hard to maintain them in stable way. These keep changing or new tests case added and break plugins. \n\u003e \n\u003e To avoid plugin break, few duplicate code is ok which is not so hard to maintain. If there is a function that is used by majority of plugins then we can check possibility of making that function only as stable interface.\n\nBefore closing this: the manager interface is in the process of becoming stable. This change is/was about base classes in the api/ code. Does it means that plugins will be use the stable manager code even for their \"api\" tests, or that tests are incorrectly classified as \"api\" tests and they just need are \"scenario\" ones?","accounts_in_message":[],"_revision_number":1},{"id":"8339eac739337218ea8ddadda7ab85371487a79d","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-01 14:57:13.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\n\u003e \u003e \n\u003e \u003e To avoid plugin break, few duplicate code is ok which is not so hard to maintain. If there is a function that is used by majority of plugins then we can check possibility of making that function only as stable interface.\n\u003e \n\u003e Before closing this: the manager interface is in the process of becoming stable. This change is/was about base classes in the api/ code. Does it means that plugins will be use the stable manager code even for their \"api\" tests, or that tests are incorrectly classified as \"api\" tests and they just need are \"scenario\" ones?\n\nPing about the question above ^^ (and then I will close this review)","accounts_in_message":[],"_revision_number":1},{"id":"8cd1a8526e7fe83c99ede0efac4570d9dbe28a32","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-03-02 13:26:21.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e \u003e \u003e This was done intentionally in https://review.opendev.org/#/c/533118/1\n\u003e \u003e  \u003e \u003e\n\u003e \u003e  \u003e \u003e Tempest plugins should use only stable interfaces from Tempest\n\u003e \u003e  \u003e \u003e otherwise it will break the plugin.\n\u003e \u003e  \u003e \u003e stable interfaces: https://docs.openstack.org/tempest/latest/plugin.html#stable-tempest-apis-plugins-may-use\n\u003e \u003e  \u003e \n\u003e \u003e  \u003e \n\u003e \u003e  \u003e So what would you suggest ? there are many plugins and they\n\u003e \u003e  \u003e dulicate the same code ... ?? it does not a good practice.  Anyway\n\u003e \u003e  \u003e if someone change the \"base\" code it should support backward.  Cant\n\u003e \u003e  \u003e we add the Base codeto stable ?\n\u003e \u003e \n\u003e \u003e There should not be duplicate code for more than one or two  plugins as those base class are very specific to single services test cases. for example tempest/api/volume/base.py is only for volume API common method. \n\u003e \u003e \n\u003e \u003e We did not make them stable because it is hard to maintain them in stable way. These keep changing or new tests case added and break plugins. \n\u003e \u003e \n\u003e \u003e To avoid plugin break, few duplicate code is ok which is not so hard to maintain. If there is a function that is used by majority of plugins then we can check possibility of making that function only as stable interface.\n\u003e \n\u003e Before closing this: the manager interface is in the process of becoming stable. This change is/was about base classes in the api/ code. Does it means that plugins will be use the stable manager code even for their \"api\" tests, or that tests are incorrectly classified as \"api\" tests and they just need are \"scenario\" ones?\n\nIt should be used in scenario tests as test need to be inherited from ScenarioManager which is base class for all scenario tests and for API test you use the other base class like this one.","accounts_in_message":[],"_revision_number":1},{"id":"9a4a6fb23ca11e91250ed43b20474f46cec02a99","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-02 13:32:59.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\n\n\u003e \u003e \n\u003e \u003e Before closing this: the manager interface is in the process of becoming stable. This change is/was about base classes in the api/ code. Does it means that plugins will be use the stable manager code even for their \"api\" tests, or that tests are incorrectly classified as \"api\" tests and they just need are \"scenario\" ones?\n\u003e \n\u003e It should be used in scenario tests as test need to be inherited from ScenarioManager which is base class for all scenario tests and for API test you use the other base class like this one.\n\nAck, thanks","accounts_in_message":[],"_revision_number":1},{"id":"7cfc5ad0af788840adeb4d3b7f80e632d09d4326","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-03-02 13:33:36.000000000","message":"Abandoned\n\nNo more needed (please check the discussion: the base code for API tests may be duplicated)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1faa72591d9bf53b9809eb467160f2f6cdb4d709","revisions":{"1faa72591d9bf53b9809eb467160f2f6cdb4d709":{"kind":"REWORK","_number":1,"created":"2019-11-25 18:53:11.000000000","uploader":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"ref":"refs/changes/70/695970/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-tempest-plugin","ref":"refs/changes/70/695970/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/70/695970/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/70/695970/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/70/695970/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/70/695970/1"}}},"commit":{"parents":[{"commit":"975953f794c65ab1124b7c42abdd5f9886b814f9","subject":"Merge \"Sync Sphinx requirement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/975953f794c65ab1124b7c42abdd5f9886b814f9"}]}],"author":{"name":"Benny Kopilov","email":"bkopilov@redhat.com","date":"2019-11-25 18:51:55.000000000","tz":120},"committer":{"name":"Benny Kopilov","email":"bkopilov@redhat.com","date":"2019-11-25 18:51:55.000000000","tz":120},"subject":"Remove duplicate code - base inherited from tempest","message":"Remove duplicate code - base inherited from tempest\n\nThere is no reason to re-write the code.\nNeed to inherit from tempest and local base will be for adding\ncapabilities\n\nChange-Id: I67eb5a97dc6cc96db5d4283f4d577de9f12653eb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/1faa72591d9bf53b9809eb467160f2f6cdb4d709"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/1faa72591d9bf53b9809eb467160f2f6cdb4d709"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}