)]}'
{"cinder_tempest_plugin/api/volume/base.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"031c0c06487343d83434097ccbbd196c9a9c98cc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     test.BaseTestCase):"},{"line_number":31,"context_line":"    \"\"\"Base test case class for all Cinder API tests.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    _api_version \u003d 2"},{"line_number":34,"context_line":"    # Use both the old and the new variables"},{"line_number":35,"context_line":"    if ((CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027) or"},{"line_number":36,"context_line":"        (not CONF.volume_feature_enabled.api_v2 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_beea8271","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":16},"updated":"2019-11-28 16:56:31.000000000","message":"Do we need to update this value too?","commit_id":"f5a86c124cff9c9148fe3a2ba8eacc4ad1224ca1"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d222c5b0991e688237718b781d2bfa284b868986","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     test.BaseTestCase):"},{"line_number":31,"context_line":"    \"\"\"Base test case class for all Cinder API tests.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    _api_version \u003d 2"},{"line_number":34,"context_line":"    # Use both the old and the new variables"},{"line_number":35,"context_line":"    if ((CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027) or"},{"line_number":36,"context_line":"        (not CONF.volume_feature_enabled.api_v2 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_880aa924","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":16},"in_reply_to":"3fa7e38b_b4286133","updated":"2019-12-04 15:27:06.000000000","message":"Thanks for the detailed answer, Luigi.","commit_id":"f5a86c124cff9c9148fe3a2ba8eacc4ad1224ca1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"51458d857885ac79d303491766ec8e85b5dc6224","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     test.BaseTestCase):"},{"line_number":31,"context_line":"    \"\"\"Base test case class for all Cinder API tests.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    _api_version \u003d 2"},{"line_number":34,"context_line":"    # Use both the old and the new variables"},{"line_number":35,"context_line":"    if ((CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027) or"},{"line_number":36,"context_line":"        (not CONF.volume_feature_enabled.api_v2 and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b4286133","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":16},"in_reply_to":"3fa7e38b_beea8271","updated":"2019-11-28 19:23:46.000000000","message":"Good question. I kept it to mimic tempest\u0027s behavior:\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/base.py#L33\n\nThe condition below is an updated version of the tempest condition (see above). Maybe we should update it only when we will remove the v2 API, or maybe earlier, not sure. But probably it should follow the same behavior as tempest. I\u0027m sure gmann can help with some direction.","commit_id":"f5a86c124cff9c9148fe3a2ba8eacc4ad1224ca1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed317f4aa04c6dabdb1dbc192ad644bd6025d4fa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    _api_version \u003d 2"},{"line_number":34,"context_line":"    # Use both the old and the new variables"},{"line_number":35,"context_line":"    if ((CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027) or"},{"line_number":36,"context_line":"        (not CONF.volume_feature_enabled.api_v2 and"},{"line_number":37,"context_line":"         CONF.volume_feature_enabled.api_v3)):"},{"line_number":38,"context_line":"        _api_version \u003d 3"},{"line_number":39,"context_line":"    credentials \u003d [\u0027primary\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3dd6dc54","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":24},"updated":"2019-12-12 17:05:46.000000000","message":"These deprecated config options are confusing and you can remove use of config options also. I am doing for other plugins - https://review.opendev.org/#/c/698760/","commit_id":"f5a86c124cff9c9148fe3a2ba8eacc4ad1224ca1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f8f3895e2b3795ec2842251830e3df6b826c5543","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                     test.BaseTestCase):"},{"line_number":31,"context_line":"    \"\"\"Base test case class for all Cinder API tests.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    _api_version \u003d 2"},{"line_number":34,"context_line":"    # Use both the old and the new variables"},{"line_number":35,"context_line":"    if ((CONF.volume.catalog_type \u003d\u003d \u0027volumev3\u0027) or"},{"line_number":36,"context_line":"        (not CONF.volume_feature_enabled.api_v2 and"},{"line_number":37,"context_line":"         CONF.volume_feature_enabled.api_v3)):"},{"line_number":38,"context_line":"        _api_version \u003d 3"},{"line_number":39,"context_line":"    credentials \u003d [\u0027primary\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_672fe5f4","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":24},"updated":"2019-12-12 15:52:28.000000000","message":"cinder testing has been moved to v3 API[1] using catalog_type and config options api_v2 and api_v3 are deprecated for removal.\n\nThese condition of _api_version is actually unused and have no effect. we should remove them.\nall existing tests should run for v3 and v2 job should eb ok as microversion tests should be skipped for v2 via l60 check_skip_with_microversion\n\nyou can see test running onv3 APIs[2].\n\n[1] https://review.opendev.org/#/q/topic:volume-default-testing-v3+(status:open+OR+status:merged)\n\n[2] https://zuul.opendev.org/t/openstack/build/693af085122a4f2995c5e105ce2559fd/log/controller/logs/tempest_log.txt.gz#57987","commit_id":"f5a86c124cff9c9148fe3a2ba8eacc4ad1224ca1"}]}