)]}'
{"cinder_tempest_plugin/api/volume/admin/test_volume_retype.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.volume.admin.test_volume_retype import VolumeRetypeTest"},{"line_number":17,"context_line":"from tempest.common import waiters"},{"line_number":18,"context_line":"from tempest import config"},{"line_number":19,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_5cf2559b","line":16,"range":{"start_line":16,"start_character":24,"end_line":16,"end_character":29},"updated":"2020-04-30 16:46:05.000000000","message":"I guess this is why you\u0027re putting these in with the \u0027admin\u0027 tests even though retype is allowed to non-admins by default.","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @decorators.idempotent_id(\u0027b90412ee-465d-46e9-b249-ec84a47d5f26\u0027)"},{"line_number":52,"context_line":"    def test_retype_to_encrypted_type(self):"},{"line_number":53,"context_line":"        # Create/get/update/delete encryption type."},{"line_number":54,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":55,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"},{"line_number":56,"context_line":"                         \u0027key_size\u0027: 256,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_9cf21d6f","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":51},"updated":"2020-04-30 16:46:05.000000000","message":"This comment doesn\u0027t really describe the point of this test (you may not need a comment, the test name is very descriptive).","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @decorators.idempotent_id(\u0027b90412ee-465d-46e9-b249-ec84a47d5f26\u0027)"},{"line_number":52,"context_line":"    def test_retype_to_encrypted_type(self):"},{"line_number":53,"context_line":"        # Create/get/update/delete encryption type."},{"line_number":54,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":55,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"},{"line_number":56,"context_line":"                         \u0027key_size\u0027: 256,"},{"line_number":57,"context_line":"                         \u0027cipher\u0027: \u0027aes-xts-plain64\u0027}"},{"line_number":58,"context_line":"        volume_type_name \u003d \u0027luks\u0027"},{"line_number":59,"context_line":"        volume_type_id \u003d self.create_volume_type(name\u003dvolume_type_name)[\u0027id\u0027]"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_f099c5c3","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":53},"updated":"2020-04-30 16:46:05.000000000","message":"These aren\u0027t used until you make the call at line 63 -- it\u0027s less confusing if you move this down to after the comment at line 61.","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        encryption_type \u003d \\"},{"line_number":63,"context_line":"            self.admin_encryption_types_client.create_encryption_type("},{"line_number":64,"context_line":"                volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":65,"context_line":"        self.assertIn(\u0027volume_type_id\u0027, encryption_type)"},{"line_number":66,"context_line":"        for key in create_kwargs:"},{"line_number":67,"context_line":"            self.assertEqual(create_kwargs[key], encryption_type[key],"},{"line_number":68,"context_line":"                             \u0027The created encryption_type %s is different \u0027"},{"line_number":69,"context_line":"                             \u0027from the requested encryption_type\u0027 % key)"},{"line_number":70,"context_line":"        # Get encryption type"},{"line_number":71,"context_line":"        encrypt_type_id \u003d encryption_type[\u0027volume_type_id\u0027]"},{"line_number":72,"context_line":"        fetched_encryption_type \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_902321a7","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":72},"updated":"2020-04-30 16:46:05.000000000","message":"I don\u0027t think you need to check this -- there are other tests to make sure encryption_type CRUD works.  You really want to focus on the retyping in this test, the extra stuff is distracting.","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                             \u0027The created encryption_type %s is different \u0027"},{"line_number":69,"context_line":"                             \u0027from the requested encryption_type\u0027 % key)"},{"line_number":70,"context_line":"        # Get encryption type"},{"line_number":71,"context_line":"        encrypt_type_id \u003d encryption_type[\u0027volume_type_id\u0027]"},{"line_number":72,"context_line":"        fetched_encryption_type \u003d ("},{"line_number":73,"context_line":"            self.admin_encryption_types_client.show_encryption_type("},{"line_number":74,"context_line":"                encrypt_type_id))"},{"line_number":75,"context_line":"        for key in create_kwargs:"},{"line_number":76,"context_line":"            self.assertEqual(create_kwargs[key], fetched_encryption_type[key],"},{"line_number":77,"context_line":"                             \u0027The fetched encryption_type %s is different \u0027"},{"line_number":78,"context_line":"                             \u0027from the created encryption_type\u0027 % key)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":81,"context_line":"        volume_source \u003d self.admin_volume_client.show_volume("}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_b0557dfc","line":78,"range":{"start_line":71,"start_character":0,"end_line":78,"end_character":70},"updated":"2020-04-30 16:46:05.000000000","message":"same here, we don\u0027t need to check that the encryption type was created correctly in this test","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"21ffc73a8d94f91e6438c4b3d1771bbae3e26958","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.volumes_client.retype_volume("},{"line_number":85,"context_line":"            src_vol[\u0027id\u0027],"},{"line_number":86,"context_line":"            new_type\u003d\u0027volume-type-1\u0027,"},{"line_number":87,"context_line":"            migration_policy\u003d\u0027never\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.addCleanup(self._wait_for_internal_volume_cleanup, src_vol)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_30e5ed38","line":86,"range":{"start_line":86,"start_character":22,"end_line":86,"end_character":35},"updated":"2020-04-30 16:46:05.000000000","message":"This is a non-encrypted volume type.  The encrypted volume type is named \u0027luks\u0027 (lines 58-59)\n\nI think that\u0027s why this test is passing.  If you look at https://github.com/openstack/cinder/blob/07a4dd548c0cfe573121e3104b5f7cea430f9155/cinder/volume/manager.py if one type is encrypted and the other isn\u0027t, the condition at line 2865 will fail and you\u0027ll start execution at line 2892 (\"# We could not change the type, so we need to migrate the volume\")","commit_id":"d161a504df6d87aaa4daf68b44089d09362ca07c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"545af343cd0dbf2ac88238627fa81d3778962912","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"},{"line_number":61,"context_line":"                         \u0027key_size\u0027: 256,"},{"line_number":62,"context_line":"                         \u0027cipher\u0027: \u0027aes-xts-plain64\u0027}"},{"line_number":63,"context_line":"        encryption_type \u003d \\"},{"line_number":64,"context_line":"            self.admin_encryption_types_client.create_encryption_type("},{"line_number":65,"context_line":"                volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f493fa4_5997fdec","line":63,"updated":"2020-05-01 00:01:23.000000000","message":"pep8: F841 local variable \u0027encryption_type\u0027 is assigned to but never used","commit_id":"574a3c19fb3be1b81359d8ab1af536d8355d042f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edac2e1c82451900350a6c00140cd413f16283a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeRetypeWithoutMigrationTest(VolumeRetypeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_3345a518","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":38},"updated":"2020-05-05 21:48:58.000000000","message":"It might be a good idea to rename this so it\u0027s easier to find in the logs--right now it clashes with the other tempest tests that have the same class name.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29ba13c4a3e32fa6d683d04406367d091ed67ad8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeRetypeWithoutMigrationTest(VolumeRetypeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_39944de8","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":38},"in_reply_to":"1f493fa4_10d5edb7","updated":"2020-05-07 02:20:43.000000000","message":"Check with Luigi, maybe it\u0027s a tempest convention to have the same names -- I didn\u0027t realize that we were already doing it somewhere else.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6e5ea85eb3802346eae5fa8d2c134cec95bc264c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeRetypeWithoutMigrationTest(VolumeRetypeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_10d5edb7","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":38},"in_reply_to":"1f493fa4_3345a518","updated":"2020-05-06 18:00:45.000000000","message":"Oh, I thought that was mandatory to use the same class name:\n- https://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/test_volumes_backup.py#L29\n- https://opendev.org/openstack/cinder-tempest-plugin/src/branch/master/cinder_tempest_plugin/api/volume/test_volume_backup.py#L26\n\nI\u0027ll update the names then.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"db8fef227cf15b1efaa44301e0701aabea552f57","unresolved":false,"context_lines":[{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumeRetypeWithoutMigrationTest(VolumeRetypeTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_ae7db06f","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":38},"in_reply_to":"1f493fa4_39944de8","updated":"2020-05-07 08:30:15.000000000","message":"The main way to identify a test is the idempotent_id, which must be unique.\n\nApart from that, the secondary way to identify the test is the full path, which is different:\n\ntempest.api.volume.test_volumes_backup.VolumeRetypeWithoutMigrationTest.test_*\n\nvs\n\ncinder_tempest_plugin.api.volumes.test_volume_backup.VolumeRetypeWithoutMigrationTest.test_*\n\nSo we can keep it as it is.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"edac2e1c82451900350a6c00140cd413f16283a6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                         \u0027cipher\u0027: \u0027aes-xts-plain64\u0027}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":64,"context_line":"            volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # Create encrypted volume"},{"line_number":67,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dvolume_type_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_d0d9d722","line":64,"range":{"start_line":64,"start_character":44,"end_line":64,"end_character":58},"updated":"2020-05-05 21:48:58.000000000","message":"I don\u0027t think you need to do this since you\u0027re not looking at the value here.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"fb162dd59c3ddfb70d5c3bfe21f7418cc2628c1d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._wait_for_internal_volume_cleanup, src_vol)"},{"line_number":78,"context_line":"        waiters.wait_for_volume_retype(self.volumes_client, src_vol[\u0027id\u0027],"},{"line_number":79,"context_line":"                                       volume_type_name)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        volume_dest \u003d self.admin_volume_client.show_volume("},{"line_number":82,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_6b21e4fb","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":55},"updated":"2020-05-06 18:35:11.000000000","message":"This should be the destination volume type: self.src_vol_type[\u0027name\u0027]","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"29ba13c4a3e32fa6d683d04406367d091ed67ad8","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.addCleanup(self._wait_for_internal_volume_cleanup, src_vol)"},{"line_number":78,"context_line":"        waiters.wait_for_volume_retype(self.volumes_client, src_vol[\u0027id\u0027],"},{"line_number":79,"context_line":"                                       volume_type_name)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        volume_dest \u003d self.admin_volume_client.show_volume("},{"line_number":82,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_9982c1a4","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":55},"in_reply_to":"1f493fa4_6b21e4fb","updated":"2020-05-07 02:20:43.000000000","message":"Good catch -- that explains the timeout you\u0027re seeing.","commit_id":"51735ebcf449a87208379296505b0b3ea360c75e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8b393559f1ef68c6687f04a538a8f87e10950519","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"import time"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_log import log as logging"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_5a001d68","line":12,"updated":"2020-05-07 15:33:44.000000000","message":"pep8: F401 \u0027time\u0027 imported but unused","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5c8ffcf11b46a885aaddee59e33c65c53a262261","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumeRetypeWithMigrationTest(VolumeRetypeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_977600d8","line":26,"updated":"2020-05-07 15:18:48.000000000","message":"I think we can try a different approach, create a class VolumeRetype and implement there verify_migration once. we dont need to write those functions twice. you can inherit from the class .\nexample:\nclass VolumeRetypeHelper(VolumeRetypeTest):\ndef _verify_migration(self, volume_source, volume_dest):\n.....\nMore service \n\nclass YourClass(VolumeRetypeHelper)\nYou already have the verify_migration once and you dont need to define it again .","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"66787e94cb822abf7afb3d362cd092238af1c4cf","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumeRetypeWithMigrationTest(VolumeRetypeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_c04f2032","line":26,"in_reply_to":"1f493fa4_002bc881","updated":"2020-05-08 18:46:49.000000000","message":"Ohh, it was only an idea but its ok .its, not the issue here.\ni thought they are the same ...","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b46a7b3c191de17d23cfd7bfb852b23ba6b2e6ed","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumeRetypeWithMigrationTest(VolumeRetypeTest):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_002bc881","line":26,"in_reply_to":"1f493fa4_977600d8","updated":"2020-05-07 16:36:29.000000000","message":"Hi Benny, thank you for the review. Maybe I\u0027m not understanding how this works but I think I\u0027m overriding parent methods because the asserts in both methods check different things. \n\nWithMigration check that migration were used L60. However, WithoutMigration check the opposite L126.","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5c8ffcf11b46a885aaddee59e33c65c53a262261","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":84,"context_line":"            volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Create encrypted volume"},{"line_number":87,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":88,"context_line":"        volume_source \u003d self.admin_volume_client.show_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_5aa5bd03","line":85,"updated":"2020-05-07 15:18:48.000000000","message":"Well if you decide to call directly to admin_encryption_types_client directly , you need to add a clean up function otherwise you test may fails.\nself.addCleaup(self.admin_encryption_types_client.delete ... )","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b46a7b3c191de17d23cfd7bfb852b23ba6b2e6ed","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":84,"context_line":"            volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Create encrypted volume"},{"line_number":87,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dself.src_vol_type[\u0027name\u0027])"},{"line_number":88,"context_line":"        volume_source \u003d self.admin_volume_client.show_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_60572c04","line":85,"in_reply_to":"1f493fa4_5aa5bd03","updated":"2020-05-07 16:36:29.000000000","message":"Sure, I\u0027ll update the patch.","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"6ac104859a17c64ac4f8d1c757d82f893db78fa4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self._verify_migration(volume_source, volume_dest)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server \u003d self.create_server()"},{"line_number":107,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume_dest[\u0027id\u0027])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_1a6055a5","line":105,"updated":"2020-05-07 15:21:46.000000000","message":"Honestly, if you decide to create an instance and attach the volume, it appears to be a scenario test and not a simple API. We can add write_to_the attach volume, migrate it and attach again and see that the data is still there","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"66787e94cb822abf7afb3d362cd092238af1c4cf","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self._verify_migration(volume_source, volume_dest)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server \u003d self.create_server()"},{"line_number":107,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume_dest[\u0027id\u0027])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_2be98519","line":105,"in_reply_to":"1f493fa4_009e28b7","updated":"2020-05-08 18:46:49.000000000","message":"Let\u0027s try it manually first","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b46a7b3c191de17d23cfd7bfb852b23ba6b2e6ed","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self._verify_migration(volume_source, volume_dest)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server \u003d self.create_server()"},{"line_number":107,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume_dest[\u0027id\u0027])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_009e28b7","line":105,"in_reply_to":"1f493fa4_1a2b35eb","updated":"2020-05-07 16:36:29.000000000","message":"File \"/opt/stack/tempest/.tox/tempest/lib/python3.6/site-packages/cinder_tempest_plugin/api/volume/admin/test_volume_retype.py\", line 182, in test_retype_from_encrypted_type\n    self.src_vol_type[\u0027name\u0027])\n\n      File \"/opt/stack/tempest/tempest/common/waiters.py\", line 283, in wait_for_volume_retype\n    raise lib_exc.TimeoutException(message)\n\n    tempest.lib.exceptions.TimeoutException: Request timed out\nDetails: Volume 7b3611a8-ad54-402d-8fe4-dbe59892296e failed to reach volume-type-3 volume type (current luks) within the required time (196 s).","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a8990b81c5d77f2946f303a5ad29068dc6a2dfd6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            src_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        self._verify_migration(volume_source, volume_dest)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        server \u003d self.create_server()"},{"line_number":107,"context_line":"        self.attach_volume(server[\u0027id\u0027], volume_dest[\u0027id\u0027])"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_1a2b35eb","line":105,"in_reply_to":"1f493fa4_1a6055a5","updated":"2020-05-07 15:34:11.000000000","message":"We can surely move it to scenario/, sure.\n\nHowever, the problem right now is that the test does not work. Let\u0027s focus on making it work, and the decide where to put it before merging.","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"5c8ffcf11b46a885aaddee59e33c65c53a262261","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":167,"context_line":"            volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # Create encrypted volume"},{"line_number":170,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dvolume_type_name)"},{"line_number":171,"context_line":"        volume_source \u003d self.admin_volume_client.show_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_3af6f1fa","line":168,"updated":"2020-05-07 15:18:48.000000000","message":"Add cleanup after create otherwise it will fail on delete actions ...","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b46a7b3c191de17d23cfd7bfb852b23ba6b2e6ed","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.admin_encryption_types_client.create_encryption_type("},{"line_number":167,"context_line":"            volume_type_id, **create_kwargs)[\u0027encryption\u0027]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        # Create encrypted volume"},{"line_number":170,"context_line":"        src_vol \u003d self.create_volume(volume_type\u003dvolume_type_name)"},{"line_number":171,"context_line":"        volume_source \u003d self.admin_volume_client.show_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_e0b85c2b","line":168,"in_reply_to":"1f493fa4_3af6f1fa","updated":"2020-05-07 16:36:29.000000000","message":"OK, I\u0027ll update the patch.","commit_id":"db988d5456da5057859729852b1d7a70885488a7"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"66787e94cb822abf7afb3d362cd092238af1c4cf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        extra_specs_src \u003d {\"volume_backend_name\": backend_src}"},{"line_number":71,"context_line":"        encryption_type \u003d self.create_volume_type("},{"line_number":72,"context_line":"            extra_specs\u003dextra_specs_src,"},{"line_number":73,"context_line":"            name\u003d\u0027luks\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":76,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_9a1ded11","line":73,"updated":"2020-05-08 18:46:49.000000000","message":"Please do not use hardcoded names , it must be random . remove the name and it will do it by class name","commit_id":"9065baea256f0aa66d82d3c93df99af6a9cadd51"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7b4b92493c69e9cc6785a31e9ff3ec6ee05b85d6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        extra_specs_src \u003d {\"volume_backend_name\": backend_src}"},{"line_number":71,"context_line":"        encryption_type \u003d self.create_volume_type("},{"line_number":72,"context_line":"            extra_specs\u003dextra_specs_src,"},{"line_number":73,"context_line":"            name\u003d\u0027luks\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":76,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_a037dee3","line":73,"in_reply_to":"ff570b3c_9a1ded11","updated":"2020-05-08 21:02:17.000000000","message":"Hi Benny, OK. I\u0027ll remove the name. I hardcoded the name because I though this was a possible way to do it[1]\n\n[1]https://review.opendev.org/#/c/453144/4/tempest/scenario/test_encrypted_cinder_volumes.py@61","commit_id":"9065baea256f0aa66d82d3c93df99af6a9cadd51"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"939176c41902aad94fce25a1daf9b5302aae1f7c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        extra_specs_src \u003d {\"volume_backend_name\": backend_src}"},{"line_number":71,"context_line":"        encryption_type \u003d self.create_volume_type("},{"line_number":72,"context_line":"            extra_specs\u003dextra_specs_src,"},{"line_number":73,"context_line":"            name\u003d\u0027luks\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":76,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_a0f51e86","line":73,"in_reply_to":"ff570b3c_a037dee3","updated":"2020-05-08 21:32:05.000000000","message":"The two parameters used by create_encryption_volume method are encryption_provider and volume_type, not the name:\n\nhttps://opendev.org/openstack/tempest/src/commit/a857880423ebc705bc9e5c921721b224ad83d308/tempest/scenario/manager.py#L1395\n\ncreate_volume_type seems to create a random name, so maybe you can not pass \u0027name\u0027 and read the generated name from the encryption_type object.","commit_id":"9065baea256f0aa66d82d3c93df99af6a9cadd51"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"66787e94cb822abf7afb3d362cd092238af1c4cf","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        extra_specs_src \u003d {\"volume_backend_name\": backend_src}"},{"line_number":112,"context_line":"        encryption_type \u003d self.create_volume_type("},{"line_number":113,"context_line":"            extra_specs\u003dextra_specs_src,"},{"line_number":114,"context_line":"            name\u003d\u0027luks\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":117,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_3ad2e135","line":114,"updated":"2020-05-08 18:46:49.000000000","message":"Please random name","commit_id":"9065baea256f0aa66d82d3c93df99af6a9cadd51"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7b4b92493c69e9cc6785a31e9ff3ec6ee05b85d6","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        extra_specs_src \u003d {\"volume_backend_name\": backend_src}"},{"line_number":112,"context_line":"        encryption_type \u003d self.create_volume_type("},{"line_number":113,"context_line":"            extra_specs\u003dextra_specs_src,"},{"line_number":114,"context_line":"            name\u003d\u0027luks\u0027)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        create_kwargs \u003d {\u0027provider\u0027: \u0027luks\u0027,"},{"line_number":117,"context_line":"                         \u0027control_location\u0027: \u0027front-end\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_a0935ea3","line":114,"in_reply_to":"ff570b3c_3ad2e135","updated":"2020-05-08 21:02:17.000000000","message":"OK","commit_id":"9065baea256f0aa66d82d3c93df99af6a9cadd51"}]}