)]}'
{"cinder_tempest_plugin/api/volume/base.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c8f840f40121a77c8c20d9e689c4e18921a2a68","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @classmethod"},{"line_number":180,"context_line":"    def _clear_volume_type(cls, volume_type):"},{"line_number":181,"context_line":"        # If image caching is enabled, we must delete the cached volume"},{"line_number":182,"context_line":"        # before cinder will allow us to delete the volume_type.  This function"},{"line_number":183,"context_line":"        # solves that problem by taking the brute-force approach of deleting"},{"line_number":184,"context_line":"        # any volumes of this volume_type that exist *no matter what project"},{"line_number":185,"context_line":"        # they are in*.  Since this won\u0027t happen until the teardown of the"},{"line_number":186,"context_line":"        # test class, that should be OK."},{"line_number":187,"context_line":"        type_id \u003d volume_type[\u0027id\u0027]"},{"line_number":188,"context_line":"        type_name \u003d volume_type[\u0027name\u0027]"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_92b6228a","line":186,"range":{"start_line":181,"start_character":8,"end_line":186,"end_character":40},"updated":"2020-07-23 04:38:44.000000000","message":"I wish there was a better way to handle this","commit_id":"3e093d2df7206d8c8926f0cf79ccdd1152e6939b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"352086d707d1be1b25fff4399dea6e9e1d878366","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @classmethod"},{"line_number":180,"context_line":"    def _clear_volume_type(cls, volume_type):"},{"line_number":181,"context_line":"        # If image caching is enabled, we must delete the cached volume"},{"line_number":182,"context_line":"        # before cinder will allow us to delete the volume_type.  This function"},{"line_number":183,"context_line":"        # solves that problem by taking the brute-force approach of deleting"},{"line_number":184,"context_line":"        # any volumes of this volume_type that exist *no matter what project"},{"line_number":185,"context_line":"        # they are in*.  Since this won\u0027t happen until the teardown of the"},{"line_number":186,"context_line":"        # test class, that should be OK."},{"line_number":187,"context_line":"        type_id \u003d volume_type[\u0027id\u0027]"},{"line_number":188,"context_line":"        type_name \u003d volume_type[\u0027name\u0027]"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_4e668957","line":186,"range":{"start_line":181,"start_character":8,"end_line":186,"end_character":40},"in_reply_to":"bf51134e_92b6228a","updated":"2020-07-23 18:04:57.000000000","message":"Yeah, I didn\u0027t like this at first either, but since it happens at class teardown time, it won\u0027t interfere with any tests in that class.  And by the time this is called, we want to delete the volume_type, so we\u0027d have to delete all these volumes anyway, or the test will fail during cleanup.  So I think this is safe (though this technique certainly shouldn\u0027t be used outside of a testing context!).","commit_id":"3e093d2df7206d8c8926f0cf79ccdd1152e6939b"}],"cinder_tempest_plugin/api/volume/test_create_from_image.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c8f840f40121a77c8c20d9e689c4e18921a2a68","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":156,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":157,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":158,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":159,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_fc15a59c","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":47},"updated":"2020-07-23 04:38:44.000000000","message":"We\u0027re defining this on L#154 (just above) and we can see it doesn\u0027t contain a volume type key so my question is, is this line necessary?","commit_id":"3e093d2df7206d8c8926f0cf79ccdd1152e6939b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"352086d707d1be1b25fff4399dea6e9e1d878366","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                           \u00276e9266ff-a917-4dd5-aa4a-c36e59e7a2a6\u0027),"},{"line_number":156,"context_line":"                  \u0027imageRef\u0027: image[\u0027id\u0027]}"},{"line_number":157,"context_line":"        # this is the whole point of the test, so make sure this is true"},{"line_number":158,"context_line":"        self.assertNotIn(\u0027volume_type\u0027, kwargs)"},{"line_number":159,"context_line":"        volume \u003d self.create_volume(**kwargs)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        found_volume_type \u003d volume[\u0027volume_type\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_6eceed83","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":47},"in_reply_to":"bf51134e_fc15a59c","updated":"2020-07-23 18:04:57.000000000","message":"I suppose not.  I could have just added a comment saying \"make sure this doesn\u0027t contain volume_type\", but this makes the same point (and would fail if someone ignored the comment).  I guess it\u0027s misleading because I\u0027m using a testcase assert, whereas this is probably the place to have a \"regular\" python assert statement.","commit_id":"3e093d2df7206d8c8926f0cf79ccdd1152e6939b"}]}