)]}'
{"cinder_tempest_plugin/scenario/test_volume_encrypted.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1473291fd8416897bff1e7a926e993604acd1221","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @classmethod"},{"line_number":27,"context_line":"    def skip_checks(cls):"},{"line_number":28,"context_line":"        super(TestEncryptedCinderVolumes, cls).skip_checks()"},{"line_number":29,"context_line":"        # TODO(enriquetaso): remove this after g597148"},{"line_number":30,"context_line":"        if CONF.volume.storage_protocol \u003d\u003d \u0027nfs\u0027:"},{"line_number":31,"context_line":"            raise cls.skipException(\u0027nfs is not supported.\u0027)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_70af8d29","line":29,"updated":"2020-06-25 10:48:00.000000000","message":"Maybe add a Depends-On: to the commit message for this instead?","commit_id":"8f14adb83d4224a7f4e63d927185552cc0761215"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"02bb2d68722bae5cb10a1459b5e6c9a23fa81e3e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @decorators.idempotent_id(\u00275bb622ab-5060-48a8-8840-d589a548b7e4\u0027)"},{"line_number":51,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":52,"context_line":"    def test_boot_encrypted_source_volid_with_image_instance(self):"},{"line_number":53,"context_line":"        \"\"\"Create encrypted volume from image"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":56,"context_line":"        Verify secret payload equal for both barbican keys"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_9b2672ba","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":45},"updated":"2020-07-01 15:02:11.000000000","message":"Not from image?","commit_id":"1c12b971bd4cdfa63488473067e9411585a750ab"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8260250f9f98214d5d1cbb0fa47722909b174273","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @decorators.idempotent_id(\u00275bb622ab-5060-48a8-8840-d589a548b7e4\u0027)"},{"line_number":51,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":52,"context_line":"    def test_boot_encrypted_source_volid_with_image_instance(self):"},{"line_number":53,"context_line":"        \"\"\"Create encrypted volume from image"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":56,"context_line":"        Verify secret payload equal for both barbican keys"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_0f1664f2","line":53,"range":{"start_line":53,"start_character":40,"end_line":53,"end_character":45},"in_reply_to":"bf51134e_9b2672ba","updated":"2020-07-06 20:56:57.000000000","message":"You are right, i think this should be something like \"create clone from volume or create volume with source_volid\"","commit_id":"1c12b971bd4cdfa63488473067e9411585a750ab"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"02bb2d68722bae5cb10a1459b5e6c9a23fa81e3e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Create encrypted volume from image"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":56,"context_line":"        Verify secret payload equal for both barbican keys"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_fb0dee35","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":58},"updated":"2020-07-01 15:02:11.000000000","message":"This is irrelevant here","commit_id":"1c12b971bd4cdfa63488473067e9411585a750ab"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8260250f9f98214d5d1cbb0fa47722909b174273","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Create encrypted volume from image"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":56,"context_line":"        Verify secret payload equal for both barbican keys"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_afdc9846","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":58},"in_reply_to":"bf51134e_fb0dee35","updated":"2020-07-06 20:56:57.000000000","message":"I\u0027ll remote it.","commit_id":"1c12b971bd4cdfa63488473067e9411585a750ab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b1619613d0fde69f51a2630db98acaddf427b8ee","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(TestEncryptedCinderVolumes, cls).resource_cleanup()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def launch_instance(self):"},{"line_number":41,"context_line":"        image \u003d self.glance_image_create()"},{"line_number":42,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return self.create_server(image_id\u003dimage, key_name\u003dkeypair[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_743f4b86","line":41,"updated":"2020-11-17 18:19:19.000000000","message":"this should just be self.image_create() (it\u0027s inherited from SecnarioTest) ... we need to make sure CONF.scenario.img_file is set, though.","commit_id":"0561b5095c73bace0a9e7fd726406237673f5b19"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"82e33b666a4d5fd27efd3db5c884334e7723bd5e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        super(TestEncryptedCinderVolumes, cls).resource_cleanup()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def launch_instance(self):"},{"line_number":41,"context_line":"        image \u003d self.glance_image_create()"},{"line_number":42,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return self.create_server(image_id\u003dimage, key_name\u003dkeypair[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_74a90b8e","line":41,"in_reply_to":"1f621f24_743f4b86","updated":"2020-11-17 18:27:50.000000000","message":"default\u003d\u0027/opt/stack/new/devstack/files/images\u0027\n               \u0027/cirros-0.3.1-x86_64-disk.img\u0027,","commit_id":"0561b5095c73bace0a9e7fd726406237673f5b19"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b947e304abc6869c131c8a7fba3d58d94922bd87","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.nova_volume_detach(server, attached_volume)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @decorators.idempotent_id(\u00275bb622ab-5060-48a8-8840-d589a548b7e4\u0027)"},{"line_number":51,"context_line":"    @utils.services(\u0027volume\u0027)"},{"line_number":52,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":53,"context_line":"        \"\"\"Create clone from volume"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_55031fbf","line":51,"updated":"2020-11-18 14:28:05.000000000","message":"we also need \u0027compute\u0027","commit_id":"ef3f5a28c0837a4088ecdd086c85ceb12b7b7cb4"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9d0f14ac3624ec3367fd9eaab0cabe68ceb436fc","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":53,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":54,"context_line":"        \"\"\"Create clone from volume"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"c6bf7b25_b79ec8d7","line":55,"updated":"2021-01-12 14:34:10.000000000","message":"Thanks for the patch, i would ask to extend the testing here to cover source-vol (cloned volume) tests .\nMaybe the flow can be :\n1. Create an encrypted volume from image \n2. Boot an instance from the volume\n3. Write data to the volume.\n4. Detach volume\n5. Create another encrypted volume from --source-volid [step #1]\n6. Boot an instance from the volume from step #5 .\n7. Are we expecting to get the data was written in step #3 ??? \n\nI think this scenario will cover the feature and the source-vol feature .\n\nThanks, Benny","commit_id":"fbbcbeaee5600d712466ada3c77b2fd3bb590d92"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"77c3ddfa0fe01b1bdde4274b4fec245bf846cde2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":53,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":54,"context_line":"        \"\"\"Create clone from volume"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"d05d8d65_34e3965b","line":55,"in_reply_to":"8eb1f795_af8717f8","updated":"2021-01-18 16:36:52.000000000","message":"They are slightly different, yes. I forgot about the attachment, so I guess It makes sense to keep both tests.","commit_id":"fbbcbeaee5600d712466ada3c77b2fd3bb590d92"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fca18ad59d9d4ecc260b737fca9a07f2390d7154","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":53,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":54,"context_line":"        \"\"\"Create clone from volume"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"8eb1f795_af8717f8","line":55,"in_reply_to":"9ffe9412_17a5c8f6","updated":"2021-01-18 15:31:15.000000000","message":"Sorry, but isn\u0027t it a different test case? We moved from a test case which deals with cloning a volume, which is then attached, to a different case where we boot a volume from an image and change it (so no attachement).\n\nAren\u0027t those two different test cases that should be both implemented? Moreover, doesn\u0027t the current (new) code also depend on the image service?","commit_id":"fbbcbeaee5600d712466ada3c77b2fd3bb590d92"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"93936e1e4709ca9b61801324f256e752286dccf1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":53,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":54,"context_line":"        \"\"\"Create clone from volume"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"9ffe9412_17a5c8f6","line":55,"in_reply_to":"acc5d18e_6d8cb6ef","updated":"2021-01-13 07:01:05.000000000","message":"Yes very good , thanks. it covers much more now .  i would move all function that use create_enc_vol (from image) and others to manager or try to use existing code from tempest directly ... just for give others the option re-use this code .","commit_id":"fbbcbeaee5600d712466ada3c77b2fd3bb590d92"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e218e41a79ee6afd8692697a19b545e0bebb4a7e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @utils.services(\u0027compute\u0027)"},{"line_number":53,"context_line":"    def test_attach_cloned_encrypted_volume(self):"},{"line_number":54,"context_line":"        \"\"\"Create clone from volume"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        Create another encrypted volume from source_volumeid"},{"line_number":57,"context_line":"        Boot an instance from volume and verify its up."},{"line_number":58,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"acc5d18e_6d8cb6ef","line":55,"in_reply_to":"c6bf7b25_b79ec8d7","updated":"2021-01-13 04:11:14.000000000","message":"Hi Benny, I\u0027ve extended the test scenario. Let me know what you think. Thanks, Sofi","commit_id":"fbbcbeaee5600d712466ada3c77b2fd3bb590d92"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e88544785aff4ecb6ef0328d9dd8a86ef97390c3","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            \u0027$classname-volume-origin\u0027 by default"},{"line_number":66,"context_line":"        :param **kwargs: additional parameters"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        volume_type \u003d self.create_volume_type(name\u003dvolume_type)"},{"line_number":69,"context_line":"        self.create_encryption_type(type_id\u003dvolume_type[\u0027id\u0027],"},{"line_number":70,"context_line":"                                    provider\u003dencryption_provider,"},{"line_number":71,"context_line":"                                    key_size\u003dkey_size,"}],"source_content_type":"text/x-python","patch_set":11,"id":"b95f4b66_9461af59","line":68,"updated":"2021-01-13 21:15:10.000000000","message":"Is this volume_type cleaned up somewhere?","commit_id":"9443c9dc13449dc07e5834a81837b9b808f9b5ec"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"746a3adf32f366d76fcd540a1a5343f79756477c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027$classname-volume-origin\u0027 by default"},{"line_number":66,"context_line":"        :param **kwargs: additional parameters"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        volume_type \u003d self.create_volume_type(name\u003dvolume_type)"},{"line_number":69,"context_line":"        self.create_encryption_type(type_id\u003dvolume_type[\u0027id\u0027],"},{"line_number":70,"context_line":"                                    provider\u003dencryption_provider,"},{"line_number":71,"context_line":"                                    key_size\u003dkey_size,"}],"source_content_type":"text/x-python","patch_set":11,"id":"70602393_2cb6d1e5","line":68,"in_reply_to":"1f7d439c_194b2b56","updated":"2021-01-19 14:57:35.000000000","message":"Thanks!","commit_id":"9443c9dc13449dc07e5834a81837b9b808f9b5ec"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0d46d0143160a83a9b3a7906666337c13ad877aa","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027$classname-volume-origin\u0027 by default"},{"line_number":66,"context_line":"        :param **kwargs: additional parameters"},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        volume_type \u003d self.create_volume_type(name\u003dvolume_type)"},{"line_number":69,"context_line":"        self.create_encryption_type(type_id\u003dvolume_type[\u0027id\u0027],"},{"line_number":70,"context_line":"                                    provider\u003dencryption_provider,"},{"line_number":71,"context_line":"                                    key_size\u003dkey_size,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f7d439c_194b2b56","line":68,"in_reply_to":"b95f4b66_9461af59","updated":"2021-01-15 17:20:46.000000000","message":"Hi Brian, thanks for your review. AFAIK, the create_volume_type from manager.ScenarioTest do the clean up[1] \n\nhttps://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/manager.py#L515","commit_id":"9443c9dc13449dc07e5834a81837b9b808f9b5ec"}]}