)]}'
{"cinder_tempest_plugin/scenario/test_volume_extend_while_attached.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def skip_checks(cls):"},{"line_number":39,"context_line":"        super(TestVolumeExtendWhileAttached, cls).skip_checks()"},{"line_number":40,"context_line":"        if not CONF.volume_feature_enabled.extend_attached_volume:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9d904351","line":37,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def create_encrypted_volume(self, volumes_client\u003dNone,"},{"line_number":87,"context_line":"        encryption_provider\u003dCONF.volume_encryption.encryption_prov,"},{"line_number":88,"context_line":"        volume_type\u003dNone,"},{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fd9dff66","line":87,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def create_encrypted_volume(self, volumes_client\u003dNone,"},{"line_number":87,"context_line":"        encryption_provider\u003dCONF.volume_encryption.encryption_prov,"},{"line_number":88,"context_line":"        volume_type\u003dNone,"},{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dd9abb6c","line":88,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def create_encrypted_volume(self, volumes_client\u003dNone,"},{"line_number":87,"context_line":"        encryption_provider\u003dCONF.volume_encryption.encryption_prov,"},{"line_number":88,"context_line":"        volume_type\u003dNone,"},{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"},{"line_number":92,"context_line":"        imageRef\u003dNone, snapshot_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3d893726","line":89,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        encryption_provider\u003dCONF.volume_encryption.encryption_prov,"},{"line_number":88,"context_line":"        volume_type\u003dNone,"},{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"},{"line_number":92,"context_line":"        imageRef\u003dNone, snapshot_id\u003dNone,"},{"line_number":93,"context_line":"        size\u003dCONF.volume.volume_size):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1d8ef32d","line":90,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        volume_type\u003dNone,"},{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"},{"line_number":92,"context_line":"        imageRef\u003dNone, snapshot_id\u003dNone,"},{"line_number":93,"context_line":"        size\u003dCONF.volume.volume_size):"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7d83af05","line":91,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        key_size\u003dCONF.volume_encryption.key_size,"},{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"},{"line_number":92,"context_line":"        imageRef\u003dNone, snapshot_id\u003dNone,"},{"line_number":93,"context_line":"        size\u003dCONF.volume.volume_size):"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not size:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5d886b1e","line":92,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"048e77dd838753f09e522df52945dd02b3bd0a0a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        cipher\u003dCONF.volume_encryption.cipher,"},{"line_number":91,"context_line":"        control_location\u003dCONF.volume_encryption.control_location,"},{"line_number":92,"context_line":"        imageRef\u003dNone, snapshot_id\u003dNone,"},{"line_number":93,"context_line":"        size\u003dCONF.volume.volume_size):"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not size:"},{"line_number":96,"context_line":"            size \u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_bd7c2721","line":93,"updated":"2020-07-24 17:45:49.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"7562c5e7b46e0c146b220a1af5f2034580db8378"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"8ee9b5f6d6c440c0e8af1c5673cdcd2cee477663","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                  \u0027security_groups\u0027: [{\u0027name\u0027: security_group1[\u0027name\u0027]}]}"},{"line_number":54,"context_line":"        server \u003d self.create_server(**kwargs)"},{"line_number":55,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":56,"context_line":"        volume_size_before \u003d self.volume[\u0027size\u0027]"},{"line_number":57,"context_line":"        extend_size \u003d self.volume[\u0027size\u0027] * 2"},{"line_number":58,"context_line":"        # extend volume while attahced to instance"},{"line_number":59,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_340b372a","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":26},"updated":"2020-08-07 16:04:03.000000000","message":"nit: original_size","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"df6d75e526598df5cd9a849a72f3197a21cc98f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                  \u0027security_groups\u0027: [{\u0027name\u0027: security_group1[\u0027name\u0027]}]}"},{"line_number":54,"context_line":"        server \u003d self.create_server(**kwargs)"},{"line_number":55,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":56,"context_line":"        volume_size_before \u003d self.volume[\u0027size\u0027]"},{"line_number":57,"context_line":"        extend_size \u003d self.volume[\u0027size\u0027] * 2"},{"line_number":58,"context_line":"        # extend volume while attahced to instance"},{"line_number":59,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9e030774","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":26},"in_reply_to":"9f560f44_340b372a","updated":"2020-08-12 19:13:24.000000000","message":"Done","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"8ee9b5f6d6c440c0e8af1c5673cdcd2cee477663","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        server \u003d self.create_server(**kwargs)"},{"line_number":55,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":56,"context_line":"        volume_size_before \u003d self.volume[\u0027size\u0027]"},{"line_number":57,"context_line":"        extend_size \u003d self.volume[\u0027size\u0027] * 2"},{"line_number":58,"context_line":"        # extend volume while attahced to instance"},{"line_number":59,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"},{"line_number":60,"context_line":"                                          new_size\u003dextend_size)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9406831f","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":19},"updated":"2020-08-07 16:04:03.000000000","message":"nit: requested_size or expected_size","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"df6d75e526598df5cd9a849a72f3197a21cc98f1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        server \u003d self.create_server(**kwargs)"},{"line_number":55,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":56,"context_line":"        volume_size_before \u003d self.volume[\u0027size\u0027]"},{"line_number":57,"context_line":"        extend_size \u003d self.volume[\u0027size\u0027] * 2"},{"line_number":58,"context_line":"        # extend volume while attahced to instance"},{"line_number":59,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"},{"line_number":60,"context_line":"                                          new_size\u003dextend_size)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_fef7a38b","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":19},"in_reply_to":"9f560f44_9406831f","updated":"2020-08-12 19:13:24.000000000","message":"Done","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"8ee9b5f6d6c440c0e8af1c5673cdcd2cee477663","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":65,"context_line":"        # verify disk size"},{"line_number":66,"context_line":"        self.assertEqual(volume[\u0027size\u0027], extend_size)"},{"line_number":67,"context_line":"        volume_size_after \u003d self.volume[\u0027size\u0027]"},{"line_number":68,"context_line":"        # verify lsklk disk size same as new size"},{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ef0a8a1d","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":25},"updated":"2020-08-07 16:04:03.000000000","message":"nit: actual_size or resulting_size","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"df6d75e526598df5cd9a849a72f3197a21cc98f1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":65,"context_line":"        # verify disk size"},{"line_number":66,"context_line":"        self.assertEqual(volume[\u0027size\u0027], extend_size)"},{"line_number":67,"context_line":"        volume_size_after \u003d self.volume[\u0027size\u0027]"},{"line_number":68,"context_line":"        # verify lsklk disk size same as new size"},{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_def45f8a","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":25},"in_reply_to":"9f560f44_ef0a8a1d","updated":"2020-08-12 19:13:24.000000000","message":"Done","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"8ee9b5f6d6c440c0e8af1c5673cdcd2cee477663","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(volume[\u0027size\u0027], extend_size)"},{"line_number":67,"context_line":"        volume_size_after \u003d self.volume[\u0027size\u0027]"},{"line_number":68,"context_line":"        # verify lsklk disk size same as new size"},{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class TestEncryptedVolumeExtendWhileAttached(TestVolumeExtendWhileAttached,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_cf3066a2","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":47},"updated":"2020-08-07 16:04:03.000000000","message":"it\u0027s somewhat easier to understand if you use extend_size (or requested_size / expected_size) here","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"df6d75e526598df5cd9a849a72f3197a21cc98f1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(volume[\u0027size\u0027], extend_size)"},{"line_number":67,"context_line":"        volume_size_after \u003d self.volume[\u0027size\u0027]"},{"line_number":68,"context_line":"        # verify lsklk disk size same as new size"},{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class TestEncryptedVolumeExtendWhileAttached(TestVolumeExtendWhileAttached,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3ef2bb9b","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":47},"in_reply_to":"9f560f44_cf3066a2","updated":"2020-08-12 19:13:24.000000000","message":"Done","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"8ee9b5f6d6c440c0e8af1c5673cdcd2cee477663","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class TestEncryptedVolumeExtendWhileAttached(TestVolumeExtendWhileAttached,"},{"line_number":73,"context_line":"                                             manager.EncryptionScenarioTest):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    \"\"\"This test case attempts to reproduce the following steps:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_0faa5e83","line":72,"updated":"2020-08-07 16:04:03.000000000","message":"+1, very neat way to test the same thing with encrypted vols :-)","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"df6d75e526598df5cd9a849a72f3197a21cc98f1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.assertEqual(volume_size_before * 2, volume_size_after)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class TestEncryptedVolumeExtendWhileAttached(TestVolumeExtendWhileAttached,"},{"line_number":73,"context_line":"                                             manager.EncryptionScenarioTest):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    \"\"\"This test case attempts to reproduce the following steps:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7e29d3f0","line":72,"in_reply_to":"9f560f44_0faa5e83","updated":"2020-08-12 19:13:24.000000000","message":"Kudos to Benny for this.\nThanks for the review Lucio!","commit_id":"06e2842122423713b0255b7a3ce385443c029a6f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"24ec2104c7e289e8de61799950c91d7afa4fe76f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"     * Check volume size."},{"line_number":33,"context_line":"     * Check the extend operation is correct."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    volume_min_microversion \u003d \u00273.42\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_88346cfd","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":27},"updated":"2020-08-13 01:39:29.000000000","message":"it worked [0][1] :-)\n\n\nBut the test failed [2]:\n\n    testtools.matchers._impl.MismatchError: 2 !\u003d 1\n\n[0] https://zuul.opendev.org/t/openstack/build/2b167e1e84ae4e3985428d642c17845c/log/controller/logs/tempest_log.txt#7463\n[1] https://zuul.opendev.org/t/openstack/build/2b167e1e84ae4e3985428d642c17845c/log/controller/logs/screen-c-vol.txt#5244\n[2] https://bcea0bf698f9ac8ecf5f-af7ad034e23a6070cda0175bca7f3e22.ssl.cf5.rackcdn.com/742943/6/check/cinder-tempest-plugin-basic-ussuri/2b167e1/testr_results.html","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"657533fdc03c624eb65d06f422e3e224f0c5ec7a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"     * Check volume size."},{"line_number":33,"context_line":"     * Check the extend operation is correct."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    volume_min_microversion \u003d \u00273.42\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_275906fe","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":27},"in_reply_to":"9f560f44_88346cfd","updated":"2020-08-13 13:31:11.000000000","message":"\\o/","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"24ec2104c7e289e8de61799950c91d7afa4fe76f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":65,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":66,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":67,"context_line":"        self.assertEqual(volume[\u0027size\u0027], expected_size)"},{"line_number":68,"context_line":"        resulting_size \u003d self.volume[\u0027size\u0027]"},{"line_number":69,"context_line":"        self.assertEqual(expected_size, resulting_size)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_eb6ec2c7","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":55},"updated":"2020-08-13 01:39:29.000000000","message":"This assertion is sufficient, right?","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"657533fdc03c624eb65d06f422e3e224f0c5ec7a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":65,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":66,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":67,"context_line":"        self.assertEqual(volume[\u0027size\u0027], expected_size)"},{"line_number":68,"context_line":"        resulting_size \u003d self.volume[\u0027size\u0027]"},{"line_number":69,"context_line":"        self.assertEqual(expected_size, resulting_size)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_075e82e5","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":55},"in_reply_to":"9f560f44_eb6ec2c7","updated":"2020-08-13 13:31:11.000000000","message":"Done","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"24ec2104c7e289e8de61799950c91d7afa4fe76f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":66,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":67,"context_line":"        self.assertEqual(volume[\u0027size\u0027], expected_size)"},{"line_number":68,"context_line":"        resulting_size \u003d self.volume[\u0027size\u0027]"},{"line_number":69,"context_line":"        self.assertEqual(expected_size, resulting_size)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_4b46ce51","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":44},"updated":"2020-08-13 01:39:29.000000000","message":"Seems that self.volume is not updated automatically, and thus the subsequent assertion fails.","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"657533fdc03c624eb65d06f422e3e224f0c5ec7a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":66,"context_line":"        volume \u003d self.volumes_client.show_volume(self.volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":67,"context_line":"        self.assertEqual(volume[\u0027size\u0027], expected_size)"},{"line_number":68,"context_line":"        resulting_size \u003d self.volume[\u0027size\u0027]"},{"line_number":69,"context_line":"        self.assertEqual(expected_size, resulting_size)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_476fda91","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":44},"in_reply_to":"9f560f44_4b46ce51","updated":"2020-08-13 13:31:11.000000000","message":":o","commit_id":"c013ffbad9779d2766b0affb4ccaa4713f465eec"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9f0ecb596b392be1be866d3346da39ecef6eca9a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \"\"\"This test case attempts to reproduce the following steps:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"     * Create a server."},{"line_number":30,"context_line":"     * Create in Cinder some bootable volume and attach it."},{"line_number":31,"context_line":"     * Extend the attached volume."},{"line_number":32,"context_line":"     * Check volume size."},{"line_number":33,"context_line":"     * Check the extend operation is correct."}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c8b48d38","line":30,"updated":"2020-08-14 07:45:00.000000000","message":"I would add to this test case:\nCreate an instance and attach volume.\nWrite to the volume data .\nextend the volume.\nVerify disk size changed in the instance\nread data from volume after extend and verify the data is still there and valid.","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9f0ecb596b392be1be866d3346da39ecef6eca9a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        kwargs \u003d {\u0027key_name\u0027: keypair1[\u0027name\u0027],"},{"line_number":55,"context_line":"                  \u0027security_groups\u0027: [{\u0027name\u0027: security_group1[\u0027name\u0027]}]}"},{"line_number":56,"context_line":"        server \u003d self.create_server(**kwargs)"},{"line_number":57,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":58,"context_line":"        original_size \u003d self.volume[\u0027size\u0027]"},{"line_number":59,"context_line":"        expected_size \u003d original_size * 2"},{"line_number":60,"context_line":"        # extend volume while attahced to instance"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c85f6d0c","line":57,"updated":"2020-08-14 07:45:00.000000000","message":"The cleanup for detaching must be in line 58 , after attach. if attach fails it should clean it before extend","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9f0ecb596b392be1be866d3346da39ecef6eca9a","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def setUp(self):"},{"line_number":100,"context_line":"        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()"},{"line_number":101,"context_line":"        self.volume \u003d self.create_encrypted_volume()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_285f09e6","line":101,"updated":"2020-08-14 07:45:00.000000000","message":"I like the idea here of reusing the code but here you will first create the parent volume and you will override it again with self.colume. \nI would recommend to do :\ndef setUP(self):\nself.volume \u003d self_.create_volume()\n\nand inside of each of the classes implement the inner function. it will prevent calling twice.","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"458078ee8d4c5b2c25186437da7428fc59afd55e","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def setUp(self):"},{"line_number":100,"context_line":"        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()"},{"line_number":101,"context_line":"        self.volume \u003d self.create_encrypted_volume()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_513ae1e6","line":101,"in_reply_to":"9f560f44_285f09e6","updated":"2020-08-15 06:26:48.000000000","message":"Not inside setUP() , function called from each class with same name but one clear vol and other encrypted","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d7262b6d459a9e0577030038078ab06f985b772a","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def setUp(self):"},{"line_number":100,"context_line":"        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()"},{"line_number":101,"context_line":"        self.volume \u003d self.create_encrypted_volume()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_c3daf548","line":101,"in_reply_to":"9f560f44_513ae1e6","updated":"2020-08-26 22:28:26.000000000","message":"Hi Benny, thanks for your review. I don\u0027t really understand how to do what you are proposing.\n\nShould I change the setUp method and create a new one for the encryption case scenario? Something like this:\n\n\n    def setUp(self):\n        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()\n        self.volume \u003d self.create_volume()\n\n    def test_encrypt_volume_extend_while_attached_to_instance()\n        self.volume \u003d self.create_encrypted_volume()        ...","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"0a1687aa1956a87fa9a92144247262d316f7d638","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def setUp(self):"},{"line_number":100,"context_line":"        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()"},{"line_number":101,"context_line":"        self.volume \u003d self.create_encrypted_volume()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_b268e020","line":101,"in_reply_to":"9f560f44_c3daf548","updated":"2020-08-27 13:23:10.000000000","message":"Not sure if it\u0027s exactly what Benny is saying, but we could do:\n\nclass Parent:\n    def _create_volume(self):\n        return self.create_volume()\n\n    def setUp(self):\n        # parent will return an unencrypted volume\n        # child will return an encrypted volume\n        self.volume \u003d self._create_volume()\n\nclass Child(Parent):\n    def _create_volume(self):  # override just the priv method\n        return self.create_encrypted_volume()\n\n    def setUp(self):\n        super(Child, self).setUp()  # Parent\u0027s setUp will take care of everything","commit_id":"8219208a181cb9e8a8dc41215aea3d3dd9b52892"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"a3e168e477602be634c89bff7322b47c81025e04","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"\"\"This test case attempts to reproduce the following steps:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"     * Create a server"},{"line_number":30,"context_line":"     * Create a Cinder volume"},{"line_number":31,"context_line":"     * Create an instance and attach the volume"},{"line_number":32,"context_line":"     * Write some data to the volume"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_17d5341c","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":22},"updated":"2020-08-27 21:26:40.000000000","message":"You\u0027re already creating an instance in the 3rd step.","commit_id":"c261eca4db6285776e44c93a5a57b9a4536e637f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"a3e168e477602be634c89bff7322b47c81025e04","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.nova_volume_attach(server, self.volume)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # write content to volume on instance"},{"line_number":70,"context_line":"        timestamp \u003d self.create_timestamp(ip_server,"},{"line_number":71,"context_line":"                                          private_key\u003dkeypair1[\u0027private_key\u0027],"},{"line_number":72,"context_line":"                                          server\u003dserver)"},{"line_number":73,"context_line":"        self.addCleanup(self.nova_volume_detach, server, self.volume)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_97e024fb","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":41},"updated":"2020-08-27 21:26:40.000000000","message":"wow, this is very handy :-)","commit_id":"c261eca4db6285776e44c93a5a57b9a4536e637f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"a3e168e477602be634c89bff7322b47c81025e04","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        timestamp \u003d self.create_timestamp(ip_server,"},{"line_number":71,"context_line":"                                          private_key\u003dkeypair1[\u0027private_key\u0027],"},{"line_number":72,"context_line":"                                          server\u003dserver)"},{"line_number":73,"context_line":"        self.addCleanup(self.nova_volume_detach, server, self.volume)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # extend volume while attahced to instance"},{"line_number":76,"context_line":"        original_size \u003d self.volume[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_379e7869","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":23},"updated":"2020-08-27 21:26:40.000000000","message":"The cleanup should be added right after nova_volume_attach. Otherwise, the attachment will remain there if create_timestamp fails for some reason.","commit_id":"c261eca4db6285776e44c93a5a57b9a4536e637f"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"a3e168e477602be634c89bff7322b47c81025e04","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    \"\"\"This test case attempts to reproduce the following steps:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"     * Create a server."},{"line_number":100,"context_line":"     * Create in Cinder some encrypted bootable volume and attach it."},{"line_number":101,"context_line":"     * Write some data to the volume"},{"line_number":102,"context_line":"     * Extend the attached volume."},{"line_number":103,"context_line":"     * Check volume\u0027s data"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_b79f2850","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":28},"updated":"2020-08-27 21:26:40.000000000","message":"an","commit_id":"c261eca4db6285776e44c93a5a57b9a4536e637f"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"c5698f9308f65bae13ffbe1e198f14cd7d9d67d5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                  imageRef\u003dimageRef, size\u003dsize)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _create_volume(self):"},{"line_number":126,"context_line":"        return self.create_encrypted_volume()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def setUp(self):"},{"line_number":129,"context_line":"        super(TestEncryptedVolumeExtendWhileAttached, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_eb2ff985","line":126,"updated":"2020-08-28 04:54:26.000000000","message":"Looks good","commit_id":"c261eca4db6285776e44c93a5a57b9a4536e637f"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"9afab2c86e7d5c6ba93925bff35aefbf685ad07a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        original_size \u003d self.volume[\u0027size\u0027]"},{"line_number":76,"context_line":"        expected_size \u003d original_size * 2"},{"line_number":77,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"},{"line_number":78,"context_line":"                                          new_size\u003dexpected_size)"},{"line_number":79,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":80,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_5e8ccf34","line":78,"updated":"2020-08-29 03:40:33.000000000","message":"Since the volume attached to an instance and you extend the volume size, it will be perfect if we can verify that the attached volume inside the instance was changed (guest os disk size)","commit_id":"fcb13790c4330b8daf6d8caab3b462d4eeabf0c0"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"3466fcfae58d5eda0bfab84ea624b7a0f6bb41bc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        original_size \u003d self.volume[\u0027size\u0027]"},{"line_number":76,"context_line":"        expected_size \u003d original_size * 2"},{"line_number":77,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"},{"line_number":78,"context_line":"                                          new_size\u003dexpected_size)"},{"line_number":79,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":80,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_263911d8","line":78,"in_reply_to":"9f560f44_0bf4d686","updated":"2020-09-01 05:25:48.000000000","message":"yes, we need to take the disk size from the guest os and verify it was really increased.... this will close the extend while attached for sure","commit_id":"fcb13790c4330b8daf6d8caab3b462d4eeabf0c0"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"3d86b22cef6ab5b028f6be2dec04036b1d4e6158","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        original_size \u003d self.volume[\u0027size\u0027]"},{"line_number":76,"context_line":"        expected_size \u003d original_size * 2"},{"line_number":77,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"},{"line_number":78,"context_line":"                                          new_size\u003dexpected_size)"},{"line_number":79,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":80,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_0bf4d686","line":78,"in_reply_to":"9f560f44_5e8ccf34","updated":"2020-08-29 23:42:51.000000000","message":"Hmmm we could do ssh_client.exec_command(\u0027df /dev/vdb | awk bla\u0027).","commit_id":"fcb13790c4330b8daf6d8caab3b462d4eeabf0c0"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"3466fcfae58d5eda0bfab84ea624b7a0f6bb41bc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":81,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        cmd \u003d \"df -h /dev/vdb | awk \u0027{ s\u003d$(NF-4) ;} END { print s}\u0027\""},{"line_number":84,"context_line":"        ssh_client \u003d self.get_remote_client(ip_server,"},{"line_number":85,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":86,"context_line":"                                            server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4bea37ac","line":83,"updated":"2020-09-01 05:25:48.000000000","message":"I don\u0027t think its the right approach here, it might be none vdb device .... (if you have multiple attachments to instance)\nWe should capture the devices before attachment and after and use set() (to remove duplications) and you will get the right device.","commit_id":"85343cb945d479d861fb779db28f94e7693f10ba"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5853eda9e71c04dc543d447eefaf8370aaa87383","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":81,"context_line":"                                                self.volume[\u0027id\u0027], \u0027in-use\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        cmd \u003d \"df -h /dev/vdb | awk \u0027{ s\u003d$(NF-4) ;} END { print s}\u0027\""},{"line_number":84,"context_line":"        ssh_client \u003d self.get_remote_client(ip_server,"},{"line_number":85,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":86,"context_line":"                                            server\u003dserver)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_07763d0d","line":83,"in_reply_to":"9f560f44_4bea37ac","updated":"2020-10-05 21:24:20.000000000","message":"you\u0027re right. Luckily nova_volume_attach returns the device name. However, the test doesn\u0027t mount it and I can\u0027t see it using \u0027df -h\u0027.","commit_id":"85343cb945d479d861fb779db28f94e7693f10ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"319ee330763faf7739ebbc6892a0946b63d52c9b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":82,"context_line":"                                            server\u003dserver)"},{"line_number":83,"context_line":"        cmd \u003d \"ls -lhs \""},{"line_number":84,"context_line":"        cmd+\u003d device"},{"line_number":85,"context_line":"        cmd+\u003d \" | awk \u0027{print $3}\u0027\""},{"line_number":86,"context_line":"        self.assertEqual(original_size, int(ssh_client.exec_command(cmd)))"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_7de34607","line":84,"updated":"2020-10-06 01:20:15.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"79deae8b8d03afd99623769194c8f98c5d118452"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"319ee330763faf7739ebbc6892a0946b63d52c9b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                                            server\u003dserver)"},{"line_number":83,"context_line":"        cmd \u003d \"ls -lhs \""},{"line_number":84,"context_line":"        cmd+\u003d device"},{"line_number":85,"context_line":"        cmd+\u003d \" | awk \u0027{print $3}\u0027\""},{"line_number":86,"context_line":"        self.assertEqual(original_size, int(ssh_client.exec_command(cmd)))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # extend volume while attahced to instance"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_5dde423c","line":85,"updated":"2020-10-06 01:20:15.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"79deae8b8d03afd99623769194c8f98c5d118452"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"47ba619cfa91cefcb51c68c618f70bd36e7d42d7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        cmd \u003d \"ls -lhs \""},{"line_number":84,"context_line":"        cmd+\u003d device"},{"line_number":85,"context_line":"        cmd+\u003d \" | awk \u0027{print $3}\u0027\""},{"line_number":86,"context_line":"        self.assertEqual(original_size, int(ssh_client.exec_command(cmd)))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # extend volume while attahced to instance"},{"line_number":89,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f560f44_67fbb947","line":86,"range":{"start_line":86,"start_character":40,"end_line":86,"end_character":73},"updated":"2020-10-05 21:34:01.000000000","message":"I\u0027m not sure if I\u0027m doing something wrong but when I check this value after extending the volume it always returns 1GB.","commit_id":"79deae8b8d03afd99623769194c8f98c5d118452"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ce52b2fbb41f54a313c165d0a9600e74d3b58b63","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        ssh_client \u003d self.get_remote_client(ip_server,"},{"line_number":81,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":82,"context_line":"                                            server\u003dserver)"},{"line_number":83,"context_line":"        cmd \u003d \"ls -lhs \""},{"line_number":84,"context_line":"        cmd +\u003d device"},{"line_number":85,"context_line":"        cmd +\u003d \" | awk \u0027{print $3}\u0027\""},{"line_number":86,"context_line":"        self.assertEqual(original_size, int(ssh_client.exec_command(cmd)))"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_aa61043b","line":83,"updated":"2020-10-06 21:32:40.000000000","message":"\"ls -s\" will only show the size of the block device node and not the device itself.\n\nInstead try\n    cmd \u003d \"blockdev --getsize64 \" + device","commit_id":"513870f32c00e9f668238f21486565d57420e255"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c06e7a08cc7b9be784004a6a70ec9bd5fe8868f4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                                            server\u003dserver)"},{"line_number":83,"context_line":"        cmd \u003d \"sudo blockdev --getsize64 \" + device"},{"line_number":84,"context_line":"        device_size \u003d int(ssh_client.exec_command(cmd)) / (1024**3)"},{"line_number":85,"context_line":"        self.assertEqual(original_size, int(round(device_size,0)))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # extend volume while attahced to instance"},{"line_number":88,"context_line":"        self.volumes_client.extend_volume(self.volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_88b68888","line":85,"updated":"2020-10-11 16:47:30.000000000","message":"pep8: E231 missing whitespace after \u0027,\u0027","commit_id":"6442b19d56f64cbb9092e188e3c09872dc97e8aa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e47e9068e5912b7eb5ff0a1d74e33301c851105f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # Create a security group"},{"line_number":57,"context_line":"        name \u003d data_utils.rand_name(\u0027secgroup-\u0027)"},{"line_number":58,"context_line":"        group_create_body \u003d ("},{"line_number":59,"context_line":"            base.security_groups_client.create_security_group(name\u003dname))"},{"line_number":60,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":61,"context_line":"                        self._delete_security_group,"},{"line_number":62,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"6e093567_08903d1a","line":59,"updated":"2021-04-08 01:09:00.000000000","message":"Any reason we call to base from API and not calling scenario manager clients , i think its not a good practice to mix between both.","commit_id":"fad012e328e6e3dc3202654bc281d0fb746a3b46"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8287819cec3d0a37dde42ff444544779f7a36a51","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # Create a security group"},{"line_number":57,"context_line":"        name \u003d data_utils.rand_name(\u0027secgroup-\u0027)"},{"line_number":58,"context_line":"        group_create_body \u003d ("},{"line_number":59,"context_line":"            base.security_groups_client.create_security_group(name\u003dname))"},{"line_number":60,"context_line":"        self.addCleanup(test_utils.call_and_ignore_notfound_exc,"},{"line_number":61,"context_line":"                        self._delete_security_group,"},{"line_number":62,"context_line":"                        group_create_body[\u0027security_group\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"d3c6db5b_10413828","line":59,"in_reply_to":"6e093567_08903d1a","updated":"2021-04-08 19:12:55.000000000","message":"If you check the CI, the current manager doesn\u0027t have _create_security_group\n```\n    AttributeError: \u0027TestVolumeExtendWhileAttached\u0027 object has no attribute \u0027_create_security_group\u0027\n```\n\nI\u0027m not sure what to do, maybe I should wait for the manager in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/620577","commit_id":"fad012e328e6e3dc3202654bc281d0fb746a3b46"}]}