)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9a059f038b69dca7218eb793014cef99649c261d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"191d446d_f8f16d6a","updated":"2022-05-06 12:19:41.000000000","message":"recheck requirements-check","commit_id":"7ed2cc5651fbb75fac6a7a3703baa1843f4e08c2"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"00d88a0da7ac461082b5b12bae80a84919210f29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8b1c859d_b5d326ca","updated":"2022-06-24 06:39:55.000000000","message":"Forcing the cinder plugin to use barbican is not the right approach unless we know that we have always barbican with cinder","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"474d4523ccd922ea2e909b080b50e979f5e47518","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4657b984_4b47533f","updated":"2022-06-24 06:31:49.000000000","message":"Hi Luigi , \nI think we should verify that barbican is installed on the setup , please note that your code should run encryption with barbican and key_manager if its old version.\n\nFirst we have to check if the endpoint of brabican exists and they try to use their code.\n\n","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7961322f07ba10319cd9a3e388dbda0da88553a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"927a2b0f_3c090fef","in_reply_to":"4657b984_4b47533f","updated":"2022-06-24 08:02:47.000000000","message":"This is a heavy WIP (and Do Not Merge) test just to check if the tests work when moved here, and the goal is to make sure they run as expected.","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7961322f07ba10319cd9a3e388dbda0da88553a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"702c0d11_5be8b1a0","in_reply_to":"8b1c859d_b5d326ca","updated":"2022-06-24 08:02:47.000000000","message":"We have discussed this in the past with the team and decided this is a good approach for some tests. This is about having the cinder-related tests of barbican in one place.","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"866ed6ef3614686541bdffca34634d7d83b45075","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0c5e7eba_9b63213a","updated":"2022-07-01 23:11:55.000000000","message":"recheck","commit_id":"336a95129b04dc3dcd2bfaee18b40ce64447447e"}],"cinder_tempest_plugin/scenario/test_volume_encryption.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"4cb59c86cd8d79a0c0b09203c2272bcf8475bcf7","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def resource_setup(cls):"},{"line_number":51,"context_line":"        super(VolumeEncryptionTest, cls).resource_setup()"},{"line_number":52,"context_line":"        cls.request_microversion \u003d ("},{"line_number":53,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":54,"context_line":"                cls.compute_min_microversion,"},{"line_number":55,"context_line":"                CONF.compute.min_microversion))"}],"source_content_type":"text/x-python","patch_set":7,"id":"c70d2aa3_83ee9c96","line":52,"updated":"2022-06-24 06:33:57.000000000","message":"We can hook it here maybe, get endpoint clients and see if barbican exists , else skip it.","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7961322f07ba10319cd9a3e388dbda0da88553a8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    @classmethod"},{"line_number":50,"context_line":"    def resource_setup(cls):"},{"line_number":51,"context_line":"        super(VolumeEncryptionTest, cls).resource_setup()"},{"line_number":52,"context_line":"        cls.request_microversion \u003d ("},{"line_number":53,"context_line":"            api_version_utils.select_request_microversion("},{"line_number":54,"context_line":"                cls.compute_min_microversion,"},{"line_number":55,"context_line":"                CONF.compute.min_microversion))"}],"source_content_type":"text/x-python","patch_set":7,"id":"b5f27de9_84056c96","line":52,"in_reply_to":"c70d2aa3_83ee9c96","updated":"2022-06-24 08:02:47.000000000","message":"If barbican is not found we can skip this, of course, just like we do for cinder-backup tests. But this will come later.","commit_id":"f64095d81d2f9afdea4be1e81dca34f61584a92d"}]}
