)]}'
{"id":"openstack%2Fcinder-tempest-plugin~777040","triplet_id":"openstack%2Fcinder-tempest-plugin~master~I5e98dfe22b107e56bd00f285d8cd527adadb206b","project":"openstack/cinder-tempest-plugin","branch":"master","topic":"bp/would","hashtags":[],"change_id":"I5e98dfe22b107e56bd00f285d8cd527adadb206b","subject":"Copy scenario manager and avoid using the Tempest unstable interface","status":"ABANDONED","created":"2021-02-23 01:26:45.000000000","updated":"2021-02-23 14:19:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"216e528ed6fe68805757eb327ccdc776b541514d","_number":777040,"virtual_id_number":777040,"owner":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-02-23 02:20:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"all":[{"value":-1,"date":"2021-02-23 09:29:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":-1,"date":"2021-02-23 14:03:42.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-23 02:20:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-23 08:23:49.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"CC"},{"updated":"2021-02-23 08:24:04.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"CC"},{"updated":"2021-02-23 09:29:09.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"}],"messages":[{"id":"eb984bb283981f2cb81b7fca3395c085e640434b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 01:26:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e42e125046a18039ce8b827bea1af7c6f7173198","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 01:27:40.000000000","message":"Topic bp/would removed","accounts_in_message":[],"_revision_number":1},{"id":"c2ca5594bbbf4fa45f5829d289a6f8702568b642","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 01:27:44.000000000","message":"Topic set to bp/tempest-scenario-manager-stable","accounts_in_message":[],"_revision_number":1},{"id":"e080284792f4e1b39ea75a6b230b7f16cf7487e2","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 01:27:55.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"04e65d6d571650eaf7666e0aa9609ff4075147f3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 01:38:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ba0f9c7c553363f0833bdc577f97316ab1295c4f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-23 02:20:24.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3ce09da8c6cb4dbea118873e771fda44 : SUCCESS in 4m 14s\n- cinder-tempest-plugin-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/a9c5cc226d684365b99bb484207c0416 : FAILURE in 33m 50s\n- cinder-tempest-plugin-lvm-lio-barbican-centos-8 https://zuul.opendev.org/t/openstack/build/8d3edd42c6d341d9b4b391dc5f81ecaa : FAILURE in 40m 05s (non-voting)\n- cinder-tempest-plugin-lvm-tgt-barbican https://zuul.opendev.org/t/openstack/build/f713e07c3e454505932971b5dbf3fb56 : FAILURE in 37m 47s\n- cinder-tempest-plugin-cbak-ceph https://zuul.opendev.org/t/openstack/build/18d019f4e9734871bd064b2c3166e57a : FAILURE in 30m 57s\n- cinder-tempest-plugin-basic-victoria https://zuul.opendev.org/t/openstack/build/8c483ebc9d6342d8a3613ccd187c6158 : FAILURE in 36m 08s\n- cinder-tempest-plugin-basic-ussuri https://zuul.opendev.org/t/openstack/build/1db25af8f2764dd5a65cb684fe48e788 : FAILURE in 27m 36s\n- cinder-tempest-plugin-basic-train https://zuul.opendev.org/t/openstack/build/d36269d16dd14d74bdc9273a2b8182c2 : FAILURE in 38m 51s","accounts_in_message":[],"_revision_number":2},{"id":"09c685c3196ccabedf9881673a6264d6f0e0a890","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2021-02-23 08:23:49.000000000","message":"Patch Set 2:\n\nIf we go this way, older releases of cinder-tempest-plugin won\u0027t be compatible with new tempest release(s) - that might not be a problem, but if it is, we will have delay the scenario manager work about a release or 2 so that we don\u0027t break the relation between cinder-tempest-plugin and tempest. This approach was good years back, when it was implemented in all the plugins at once and there was a huge refactoring plan planned for tempest\u0027s scenario.manager, however, now when we\u0027re almost finished with that and only a few plugins (cinder-tempest-plugin, maybe a few others) are dependent on tempest.scenario.manager, I\u0027m not so sure this is the right way to go.\n\nThis patch is supposed to help with a rename on tempest\u0027s side: https://review.opendev.org/c/openstack/tempest/+/776932\nWhy don\u0027t we do the following on tempest\u0027s side instead:\n```\n_foo():\n    # TODO delete in 27 release (whatever release we feel is appropriate)\n    warning()\n    foo()\nfoo()\n   \u003c_foo\u0027s logic\u003e\n```\nThat way ^^ any combination of tempest and cinder-tempest-plugin will have no problem to interact with each other.","accounts_in_message":[],"_revision_number":2},{"id":"eb4a09a6b9437780297e26200d0f2ea3d26713a0","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-02-23 08:54:35.000000000","message":"Patch Set 2:\n\nIf we merge https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495, wouldn\u0027t that be enough?","accounts_in_message":[],"_revision_number":2},{"id":"e73c87b384c8adbd0c693919a250e61da0658563","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-02-23 09:02:10.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e If we go this way, older releases of cinder-tempest-plugin won\u0027t be compatible with new tempest release(s) \n\n\nIn the past, when breaking changes happened in an unstable interface, it was the plugin responsibility to fix them and restore the compatibility.\nWhile I agree that, given the long-standing unresolved status of the scenario manager, a smoother transition may be planned instead, I can\u0027t really block this change.","accounts_in_message":[],"_revision_number":2},{"id":"d2c0dbe97577af9bd1f01b10869825ab46943610","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2021-02-23 09:29:09.000000000","message":"Patch Set 2: Code-Review-1\n\nLet\u0027s do it in different patches; we need \nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495 (hopefully merging soon)\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777074 (may need a few fixes)","accounts_in_message":[],"_revision_number":2},{"id":"953f465b5a8df74d60d9a9503be7483f8b84cf90","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 14:02:59.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e If we go this way, older releases of cinder-tempest-plugin won\u0027t be compatible with new tempest release(s) - that might not be a problem, but if it is, we will have delay the scenario manager work about a release or 2 so that we don\u0027t break the relation between cinder-tempest-plugin and tempest. This approach was good years back, when it was implemented in all the plugins at once and there was a huge refactoring plan planned for tempest\u0027s scenario.manager, however, now when we\u0027re almost finished with that and only a few plugins (cinder-tempest-plugin, maybe a few others) are dependent on tempest.scenario.manager, I\u0027m not so sure this is the right way to go.\n\u003e \n\u003e This patch is supposed to help with a rename on tempest\u0027s side: https://review.opendev.org/c/openstack/tempest/+/776932\n\u003e Why don\u0027t we do the following on tempest\u0027s side instead:\n\u003e ```\n\u003e _foo():\n\u003e     # TODO delete in 27 release (whatever release we feel is appropriate)\n\u003e     warning()\n\u003e     foo()\n\u003e foo()\n\u003e    \u003c_foo\u0027s logic\u003e\n\u003e ```\n\u003e That way ^^ any combination of tempest and cinder-tempest-plugin will have no problem to interact with each other.\n\nyeah we do not need to maintain the compatibility of old cinder-tempest-plugin and tempest master. In every release we release the tempest and plugins compatible versions which is what we will use in our CI/CD and in production testing also. \n\nAlso scenario manager was never a stable interface and every plugins had copy of that to avoid any break and so does this plugin can also do. I think bets way is to merge this asap and then we can merge the https://review.opendev.org/c/openstack/tempest/+/776932","accounts_in_message":[],"_revision_number":2},{"id":"fde5616ad41649444e24feb6df90982f5b410bb3","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 14:03:42.000000000","message":"Patch Set 2: Workflow-1\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e Let\u0027s do it in different patches; we need \n\u003e https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495 (hopefully merging soon)\n\u003e https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777074 (may need a few fixes)\n\nnice, let\u0027s wait for 702495","accounts_in_message":[],"_revision_number":2},{"id":"216e528ed6fe68805757eb327ccdc776b541514d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-23 14:19:27.000000000","message":"Abandoned\n\nin favor of https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c7af44031ddecfc676597a73ea2b0f2ef9fc85c0","revisions":{"d4733f48ad127ab3c8442598e7a8250b653f153a":{"kind":"REWORK","_number":1,"created":"2021-02-23 01:26:45.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/40/777040/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-tempest-plugin","ref":"refs/changes/40/777040/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/1"}}},"commit":{"parents":[{"commit":"ec742c8cb74779c85c064fd5a57026f30948e38a","subject":"Merge \"Add test idempotent IDs when missing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/ec742c8cb74779c85c064fd5a57026f30948e38a"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-02-23 01:23:28.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-02-23 01:23:28.000000000","tz":-360},"subject":"Copy scenario manager and avoid using the Tempest unstable interface","message":"Copy scenario manager and avoid using the Tempest unstable interface\n\nTempest.scenaio.manager is not stable interface yet and Tempest\nteam is making many changes in that to make it stable for\nplugins. Until then we need make a copy of it so that any\nchange done as part of below BP would not cause any break in\ncinder-tempest-plugin\n\n- https://review.opendev.org/q/topic:%22bp%252Ftempest-scenario-manager-stable%22+(status:open%20OR%20status:merged)\n\nRelated blueprint tempest-scenario-manager-stable\n\nChange-Id: I5e98dfe22b107e56bd00f285d8cd527adadb206b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/d4733f48ad127ab3c8442598e7a8250b653f153a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/d4733f48ad127ab3c8442598e7a8250b653f153a"}]},"branch":"refs/heads/master"},"c7af44031ddecfc676597a73ea2b0f2ef9fc85c0":{"kind":"REWORK","_number":2,"created":"2021-02-23 01:38:32.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/40/777040/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder-tempest-plugin","ref":"refs/changes/40/777040/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder-tempest-plugin refs/changes/40/777040/2"}}},"commit":{"parents":[{"commit":"ec742c8cb74779c85c064fd5a57026f30948e38a","subject":"Merge \"Add test idempotent IDs when missing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/ec742c8cb74779c85c064fd5a57026f30948e38a"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-02-23 01:23:28.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-02-23 01:38:08.000000000","tz":-360},"subject":"Copy scenario manager and avoid using the Tempest unstable interface","message":"Copy scenario manager and avoid using the Tempest unstable interface\n\nTempest.scenaio.manager is not stable interface yet and Tempest\nteam is making many changes in that to make it stable for\nplugins. Until then we need make a copy of it so that any\nchange done as part of below BP would not cause any break in\ncinder-tempest-plugin\n\n- https://review.opendev.org/q/topic:%22bp%252Ftempest-scenario-manager-stable%22+(status:open%20OR%20status:merged)\n\nThis keep only cinder related methods.\n\nRelated blueprint tempest-scenario-manager-stable\n\nChange-Id: I5e98dfe22b107e56bd00f285d8cd527adadb206b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/c7af44031ddecfc676597a73ea2b0f2ef9fc85c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder-tempest-plugin/commit/c7af44031ddecfc676597a73ea2b0f2ef9fc85c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}