)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"a99118d15739665ca5bdd5902200db98a79146bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"99b91cc1_f3dad681","updated":"2022-05-25 08:31:40.000000000","message":"-1 Not because of the code ... only because we should re-think and sync about\nthe approach.\n","commit_id":"7ebaa31bccb838d605736317e8d1c28507743854"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d8f24ef1feb1cf86f51535746c44ad5b17dddb9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f4f92a94_5e0b1b73","updated":"2022-05-25 09:39:50.000000000","message":"if the command output should be the same for different persona , as for today we have a schema validator for os_primary and os_admin clients, so adding a test to check the fields ? \n\nMaybe change the validaor schema if really needed\n","commit_id":"7ebaa31bccb838d605736317e8d1c28507743854"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"44b90f539b7c29dbc0113d247615cf619546d0d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2b1758f1_7ecb9fd8","updated":"2021-12-02 16:38:39.000000000","message":"recheck","commit_id":"7ebaa31bccb838d605736317e8d1c28507743854"}],"cinder_tempest_plugin/rbac/v3/test_volumes.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"a99118d15739665ca5bdd5902200db98a79146bb","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        volume[\u0027size\u0027] \u003d 1"},{"line_number":75,"context_line":"        return volume"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _create_encrypted_volume_type(self):"},{"line_number":78,"context_line":"        # Create a generic volume type we can use in the next step to setup an"},{"line_number":79,"context_line":"        # encrypted type"},{"line_number":80,"context_line":"        volume_type \u003d self.admin_types_client.create_volume_type("}],"source_content_type":"text/x-python","patch_set":18,"id":"270569c1_68cf0136","line":77,"updated":"2022-05-25 08:31:40.000000000","message":"Not sure i understnad the idea behind overriding code, ciner_tempest_plugin already implements base code for volume creation and others with cleanup . the missing part is the \"client\" object code which can be : self.persona.[client_name] , same for all different credentials.\nproject_memeber, system_admin, os_admin , these groups can refer to the same client \nproject_memeber.volumes_client_latest\nsystem_admin.volumes_client_latest\nos_admin.volumes_client_latest (current in tempest)\n\n\nCan you take a look in :\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/842954\n\nOnce base_api command in cinder_tempest_plugin will support client as param we can re-use the code and run many tests without duplicating code.","commit_id":"7ebaa31bccb838d605736317e8d1c28507743854"}]}