)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f6a73abe80149839ad52c0873ae33dcdf96f57f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve snapshot data integrity test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the test require lot of resources i.e. 4 instance."},{"line_number":10,"context_line":"This patch uses recommendation from the comments of initial patch[1]"},{"line_number":11,"context_line":"i.e. creates 1 instance, attach volumes to it, snapshot etc"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a2548248_9373149a","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":30},"updated":"2021-12-03 10:26:34.000000000","message":"requires a lot","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a65a8b252e96c1f3c6d36461161f58e122745e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a73c318_dc1885c7","updated":"2021-12-12 17:35:41.000000000","message":"Hi Gorka, thanks for mentioning the good improvements. I\u0027ve addressed them in a followup patch here https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/821498","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5ec0554f72f7c74834de6d94f443e0516f354684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aad1040a_8a82c826","updated":"2021-11-26 13:31:23.000000000","message":"Thanks, less resources","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f6a73abe80149839ad52c0873ae33dcdf96f57f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"766a87c8_1af598b5","updated":"2021-12-03 10:26:34.000000000","message":"There are a couple of improvements that I think would make the tests more readable, but \"perfect is the enemy of good\", and this change in itself is going to save time in gate jobs.","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"47a10373ddadf7cdbf49c20c4d0fe6a48f7a7898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"74b204c0_b1c37ed8","updated":"2021-11-12 09:53:10.000000000","message":"recheck","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7816fc6e2a3bf16ded72cf2e2220b1670669fbec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b064b3b1_95d43d3c","updated":"2021-12-03 13:18:17.000000000","message":"recheck","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fa6077bd0ddfd9b039be3973c581270f105626dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db7de6bf_6f6750a5","updated":"2021-11-26 13:32:04.000000000","message":"recheck","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"}],"cinder_tempest_plugin/scenario/test_snapshots.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f6a73abe80149839ad52c0873ae33dcdf96f57f","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":56,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":57,"context_line":"                                            server\u003dserver)"},{"line_number":58,"context_line":"        if dev_name is not None:"},{"line_number":59,"context_line":"            ssh_client.exec_command(\u0027sudo mount /dev/%s %s\u0027 % (dev_name,"},{"line_number":60,"context_line":"                                                               mount_path))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        md5_sum \u003d ssh_client.exec_command("},{"line_number":63,"context_line":"            \u0027sudo md5sum %s/%s|cut -c 1-32\u0027 % (mount_path, filename))"}],"source_content_type":"text/x-python","patch_set":5,"id":"d6e601dd_6c89cc5a","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":75},"updated":"2021-12-03 10:26:34.000000000","message":"nit: This looks like a good candidate to create a new context manager method (e.g. mount_path) that does the mount and unmount if dev_name:\n\n  with mount_path(ssh_client, dev_name, mount_path):\n      md5 \u003d ssh_client.exec_command(\n          \u0027sudo md5sum %s/%s|cut -c 1-32\u0027 % (mount_path, filename))\n\nAfter all we are using this pattern at least 3 times in this patch.","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a65a8b252e96c1f3c6d36461161f58e122745e9d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ssh_client \u003d self.get_remote_client(ip_address,"},{"line_number":56,"context_line":"                                            private_key\u003dprivate_key,"},{"line_number":57,"context_line":"                                            server\u003dserver)"},{"line_number":58,"context_line":"        if dev_name is not None:"},{"line_number":59,"context_line":"            ssh_client.exec_command(\u0027sudo mount /dev/%s %s\u0027 % (dev_name,"},{"line_number":60,"context_line":"                                                               mount_path))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        md5_sum \u003d ssh_client.exec_command("},{"line_number":63,"context_line":"            \u0027sudo md5sum %s/%s|cut -c 1-32\u0027 % (mount_path, filename))"}],"source_content_type":"text/x-python","patch_set":5,"id":"352b2ff5_c34de5fa","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":75},"in_reply_to":"d6e601dd_6c89cc5a","updated":"2021-12-12 17:35:41.000000000","message":"Done","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f6a73abe80149839ad52c0873ae33dcdf96f57f","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        1) Create an instance with ephemeral disk"},{"line_number":145,"context_line":"        2) Create a volume, attach it to the instance and create a filesystem"},{"line_number":146,"context_line":"           on it and mount it"},{"line_number":147,"context_line":"        3) Mount the volume, create a file and write data into it, Unmount it"},{"line_number":148,"context_line":"        4) create snapshot"},{"line_number":149,"context_line":"        5) repeat 3 and 4 two more times (simply creating 3 snapshots)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f74a7c9_bc6400ca","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":27},"updated":"2021-12-03 10:26:34.000000000","message":"nit: Wasn\u0027t it already mounted at the end of step #2?","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a65a8b252e96c1f3c6d36461161f58e122745e9d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        1) Create an instance with ephemeral disk"},{"line_number":145,"context_line":"        2) Create a volume, attach it to the instance and create a filesystem"},{"line_number":146,"context_line":"           on it and mount it"},{"line_number":147,"context_line":"        3) Mount the volume, create a file and write data into it, Unmount it"},{"line_number":148,"context_line":"        4) create snapshot"},{"line_number":149,"context_line":"        5) repeat 3 and 4 two more times (simply creating 3 snapshots)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"de0249ee_8562da2f","line":147,"range":{"start_line":147,"start_character":12,"end_line":147,"end_character":27},"in_reply_to":"7f74a7c9_bc6400ca","updated":"2021-12-12 17:35:41.000000000","message":"Done","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f6a73abe80149839ad52c0873ae33dcdf96f57f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ffcd1b11_1796b125","line":242,"range":{"start_line":201,"start_character":0,"end_line":242,"end_character":0},"updated":"2021-12-03 10:26:34.000000000","message":"nit: This seems like a good opportunity to use a loop, since we are doing the same thing 3 times.","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a65a8b252e96c1f3c6d36461161f58e122745e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ca85aab_1d8e534d","line":242,"range":{"start_line":201,"start_character":0,"end_line":242,"end_character":0},"in_reply_to":"ffcd1b11_1796b125","updated":"2021-12-12 17:35:41.000000000","message":"Done","commit_id":"d9e5925bf6f3ee1ea2d5f562bbe7accd9229bd73"}]}