)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"aed4ce6f1215914d316c23223b09062b660adf21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c74fcbc6_05e0da39","updated":"2021-12-03 18:48:20.000000000","message":"In the end, this needed a rebase anyway :/","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"21348113ecdb6c1775467ede524164b2ebe4cace","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a71e071f_934b4cd5","updated":"2021-11-12 09:54:12.000000000","message":"It seems this change depends on an older version of https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/790899/ - I wonder if the dependency could be removed.","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f5ac9acaec3805a647512a0c61a6956dedf6b87b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0b02ed5_a22beb31","updated":"2021-10-18 14:37:28.000000000","message":"Thanks!","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f62c534918da70ccfcbfb5e293fd8bae499ef721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"597d35a5_ca5fac76","updated":"2021-11-11 23:34:51.000000000","message":"Upgrading my vote since all comments had been addressed. ","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"eb753e4fa98c679cc655fb04d253a7721db262be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f6b94f07_62f734f3","updated":"2021-10-18 14:37:38.000000000","message":"recheck","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2839dd0104c644deb54fe66316ceb595a751f334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"543a75a7_8800161a","updated":"2021-10-19 16:17:01.000000000","message":"thanks","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"75f28e17192f8a1952df750a79852924697d043c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efdd2386_f71d503c","in_reply_to":"c74fcbc6_05e0da39","updated":"2021-12-03 18:53:58.000000000","message":"Yeah but it\u0027s not one of those rebase that requires manual merge conflict resolution and is still preserving votes so it looks good.","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"52f3b9e302c8413190f7a588a12a6dea5375699a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5273cfdd_cd59c39f","updated":"2021-12-06 09:05:50.000000000","message":"recheck","commit_id":"638f2308a178d84a57b1c6c9af2cbabab7a56d63"}],"cinder_tempest_plugin/scenario/manager.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"14ce24e6090eae6172bdba76bea6cc69597f4396","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"94cf80c8_24fa140d","line":1,"updated":"2021-08-02 12:46:23.000000000","message":"Did you remove the old copyright because the file is basically rewritten from scratch?\n\nOtherwise I think the old lines shouldn\u0027t be removed.\n\nOr, if they are removed, all of them should be removed at the same time. Please ask -tc.","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5931969f6ff87191620dc14ca6d8f336e1eb1042","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"2a287eed_c1438af7","line":1,"in_reply_to":"94cf80c8_24fa140d","updated":"2021-08-02 17:58:08.000000000","message":"This file is written from scratch by me and it only contains new methods that I\u0027ve implemented as a helper for cinder tempest plugin tests, just base class is tempest scenario manager hence the copyright.","commit_id":"c947cc659da2bce64004559641fe5596c9b795c0"}],"cinder_tempest_plugin/scenario/scenario_utils.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b7b4284248c3dca96748c9d125fbdf079c4fbe51","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ScenarioUtils(manager.ScenarioTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _attached_volume_name("},{"line_number":28,"context_line":"            self, disks_list_before_attach, ip_address, private_key):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bb2fe0c2_b03e655c","line":25,"updated":"2021-05-12 10:28:30.000000000","message":"long term we may want to cleanup and reuse cinder_tempest_plugin/scenario/manager.py","commit_id":"03341ce27c3efc8d7c376d5c9b0575ea1d2b60dd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6d46912b4e8c3f896d09c175c00dd2258b6fc6e8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class ScenarioUtils(manager.ScenarioTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _attached_volume_name("},{"line_number":28,"context_line":"            self, disks_list_before_attach, ip_address, private_key):"}],"source_content_type":"text/x-python","patch_set":1,"id":"798f8e04_f1b883df","line":25,"in_reply_to":"bb2fe0c2_b03e655c","updated":"2021-05-12 10:38:41.000000000","message":"I might not understand correctly but are you suggesting to do this in cinder_tempest_plugin/scenario/manager.py ?\nIIRC the tempest scenario manager is declared stable so we might delete that file soon hence created this file for cinder tempest plugin common methods.\nAlso I can rename it to manager after we remove the copy of tempest manager.","commit_id":"03341ce27c3efc8d7c376d5c9b0575ea1d2b60dd"}]}