)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2a1bb6faf87607aeede2a900e5da8f3a51c23c3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6f55f44_a8c52a8b","updated":"2021-12-13 19:02:22.000000000","message":"Thanks Rajat","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5eced41c3a78136743ab718f7dc19ba5418b1ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2c6fcdfe_69573194","updated":"2021-12-12 16:15:49.000000000","message":"recheck","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0346912b1e8fa3a424d6e18914340517a3a46a6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3d1c8d1_f05795aa","updated":"2021-12-07 15:35:18.000000000","message":"recheck","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f6c456bbbfcaa9ecc2d84c5ddee84ea4e3fc93a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf5cb85b_2f635a4e","updated":"2021-12-13 10:38:56.000000000","message":"recheck\n\nthe multiattach job and tests passed\n\ncinder_tempest_plugin.scenario.test_volume_multiattach.VolumeMultiattachTests\t2\t2\t0\t0\t0\tDetail\t\ntest_multiattach_data_integrity\npass\ntest_volume_multiattach_same_host_negative\npass","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"083e731f04e32b94ddc1e4c9f3a0c89f04aa7262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"974c7a0e_fdbfb9c3","updated":"2022-03-03 15:36:59.000000000","message":"the -1 is for the missing UUID","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2a1bb6faf87607aeede2a900e5da8f3a51c23c3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"46d82fad_67aefe59","in_reply_to":"cf5cb85b_2f635a4e","updated":"2021-12-13 19:02:22.000000000","message":"Looks good!","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc428a9f07cb324a1e642e14510bb6379ccc430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3fc0ef7_578715ff","updated":"2022-03-09 08:02:32.000000000","message":"Thanks Eric and Benny for review.","commit_id":"bbc7e797838db8ea83d214052b76db2c7fb4ecf3"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"98d5eff611c4899004fda90c120cafe154f7c080","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8220df5_2843830f","updated":"2022-03-09 08:21:57.000000000","message":"The code looks good to me but i would recommend to put the dd stuff in a method and not as hardcoded ","commit_id":"bbc7e797838db8ea83d214052b76db2c7fb4ecf3"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"f8d6aa08d36d11fe757e536f2a8fd5761c091300","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2e418dae_d1f33697","updated":"2022-03-09 09:46:47.000000000","message":"Thanks a lot , Once we merge it we are going to add more tests.\n\nBenny","commit_id":"275286492c3d06d2f2dca4c42f16bdb8c9690043"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4ff04ce0ec20b90c93290722eaab9663b66b04ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71383ec8_d01ed368","updated":"2022-03-24 00:42:19.000000000","message":"recheck","commit_id":"376b674902273ad84a57466ed88f285a6493f35a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"deb2400ace1df4b33fc5c78114ce827e2423b6b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"58b90955_68ac27b9","updated":"2022-03-25 07:16:56.000000000","message":"Thanks Eric","commit_id":"4ff857addf10073272502bd88f035db0397e2813"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c288b50ea3179d77aa9bad553e682ec6daef9345","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"eba4cdf7_2eabb1af","updated":"2022-05-19 17:21:46.000000000","message":"lgtm and cinder-tempest-plugin-lvm-multiattach passed ","commit_id":"6dc9a2faccc8815d5a9ff5202ff68d5491b8bd0a"}],"cinder_tempest_plugin/scenario/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c966051c0bfd6581cbb52dffa12ad063ba09d293","unresolved":true,"context_lines":[{"line_number":125,"context_line":"                                  server\u003dinstance)"},{"line_number":126,"context_line":"        return count, md5_sum"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def write_data_to_device(self, ip_address, out_dev, in_dev\u003d\u0027/dev/zero\u0027,"},{"line_number":129,"context_line":"                             bs\u003d1024, count\u003d100, private_key\u003dNone,"},{"line_number":130,"context_line":"                             server\u003dNone):"},{"line_number":131,"context_line":"        ssh_client \u003d self.get_remote_client("}],"source_content_type":"text/x-python","patch_set":6,"id":"26513d8d_ed8759d2","line":128,"range":{"start_line":128,"start_character":63,"end_line":128,"end_character":74},"updated":"2022-03-11 18:19:56.000000000","message":"/dev/zero is probably a poor choice for Cinder tests like this -- a block written from that looks like a block that was never written to.\n\nI think this should be /dev/urandom instead.","commit_id":"275286492c3d06d2f2dca4c42f16bdb8c9690043"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"deb2400ace1df4b33fc5c78114ce827e2423b6b3","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                  server\u003dinstance)"},{"line_number":126,"context_line":"        return count, md5_sum"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def write_data_to_device(self, ip_address, out_dev, in_dev\u003d\u0027/dev/zero\u0027,"},{"line_number":129,"context_line":"                             bs\u003d1024, count\u003d100, private_key\u003dNone,"},{"line_number":130,"context_line":"                             server\u003dNone):"},{"line_number":131,"context_line":"        ssh_client \u003d self.get_remote_client("}],"source_content_type":"text/x-python","patch_set":6,"id":"c846577e_3238e8fd","line":128,"range":{"start_line":128,"start_character":63,"end_line":128,"end_character":74},"in_reply_to":"26513d8d_ed8759d2","updated":"2022-03-25 07:16:56.000000000","message":"Done","commit_id":"275286492c3d06d2f2dca4c42f16bdb8c9690043"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4882dae32b61e8cdb91bd2aec714f77a8cf136a3","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Write data to device"},{"line_number":135,"context_line":"        write_command \u003d ("},{"line_number":136,"context_line":"            \u0027sudo dd bs\u003d%s count\u003d%s if\u003d%s | sha1sum | sudo dd of\u003d%s\u0027 %"},{"line_number":137,"context_line":"            (str(bs), str(count), in_dev, out_dev))"},{"line_number":138,"context_line":"        ssh_client.exec_command(write_command)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a5f7da79_f36a0f13","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":68},"updated":"2022-03-28 14:21:11.000000000","message":"This is writing the sha1sum to the device instead of the data.\n\nWhat you actually want is something more like:\n    sudo dd bs\u003d%s count\u003d%s if\u003d%(in_dev)s of\u003d%(out_dev)s \u0026\u0026 sudo sha1sum $(out_dev)s","commit_id":"4ff857addf10073272502bd88f035db0397e2813"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"93d7c83ec5f4b4a39450ed5e3136142d5b153c3f","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Write data to device"},{"line_number":135,"context_line":"        write_command \u003d ("},{"line_number":136,"context_line":"            \u0027sudo dd bs\u003d%s count\u003d%s if\u003d%s | sha1sum | sudo dd of\u003d%s\u0027 %"},{"line_number":137,"context_line":"            (str(bs), str(count), in_dev, out_dev))"},{"line_number":138,"context_line":"        ssh_client.exec_command(write_command)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"374f9239_82d2bc1b","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":68},"in_reply_to":"03a3de85_6d0d85b8","updated":"2022-03-30 06:06:55.000000000","message":"Done\nI\u0027m using the second command to to take sha1sum of only the data written and not the whole device since taking sha1sum of whole device takes significantly more time in my local run.","commit_id":"4ff857addf10073272502bd88f035db0397e2813"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"265bd23578363d9f0550594be70cff031b52cf8e","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Write data to device"},{"line_number":135,"context_line":"        write_command \u003d ("},{"line_number":136,"context_line":"            \u0027sudo dd bs\u003d%s count\u003d%s if\u003d%s | sha1sum | sudo dd of\u003d%s\u0027 %"},{"line_number":137,"context_line":"            (str(bs), str(count), in_dev, out_dev))"},{"line_number":138,"context_line":"        ssh_client.exec_command(write_command)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"03a3de85_6d0d85b8","line":136,"range":{"start_line":136,"start_character":12,"end_line":136,"end_character":68},"in_reply_to":"a5f7da79_f36a0f13","updated":"2022-03-28 14:23:49.000000000","message":"Note that this suggesting is checksumming the whole device instead of just the data block written, as I think the previous code was doing -- I think that is ok, but if not, the second command should be more like\n    \u0026\u0026 sudo dd bs\u003d%s count\u003d%s if\u003d%(out_dev)s | sha1sum","commit_id":"4ff857addf10073272502bd88f035db0397e2813"}],"cinder_tempest_plugin/scenario/test_volume_multiattach.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"98d5eff611c4899004fda90c120cafe154f7c080","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"c92463a5_c2d30143","line":1,"updated":"2022-03-09 08:21:57.000000000","message":"2022","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3950eb4ef7e6589b0063497916c9237cd7c9f246","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2021 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"5e741ee8_a2f040bd","line":1,"in_reply_to":"c92463a5_c2d30143","updated":"2022-03-09 09:33:38.000000000","message":"It\u0027s been sitting here long enough that the year changed :)","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"083e731f04e32b94ddc1e4c9f3a0c89f04aa7262","unresolved":true,"context_lines":[{"line_number":43,"context_line":"            [attachment[\u0027server_id\u0027] for attachment in volume[\u0027attachments\u0027]])"},{"line_number":44,"context_line":"        self.assertIn(server_id, server_ids)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_multiattach_data_integrity(self):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create an instance"},{"line_number":49,"context_line":"        server_1 \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"54901fe6_9af57dd8","line":46,"updated":"2022-03-03 15:36:59.000000000","message":"The test is without UUID","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc428a9f07cb324a1e642e14510bb6379ccc430","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            [attachment[\u0027server_id\u0027] for attachment in volume[\u0027attachments\u0027]])"},{"line_number":44,"context_line":"        self.assertIn(server_id, server_ids)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_multiattach_data_integrity(self):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create an instance"},{"line_number":49,"context_line":"        server_1 \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"af8e56b5_d52bb6f4","line":46,"in_reply_to":"54901fe6_9af57dd8","updated":"2022-03-09 08:02:32.000000000","message":"Done","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"083e731f04e32b94ddc1e4c9f3a0c89f04aa7262","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        volume \u003d self.create_volume(volume_type\u003dvol_type[\u0027id\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        instance_ip \u003d self.get_server_ip(server_1)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Attach volume to instance and find it\u0027s device name (eg: /dev/vdb)"},{"line_number":63,"context_line":"        volume_device_name_inst_1, __ \u003d ("},{"line_number":64,"context_line":"            self._attach_and_get_volume_device_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"3e686883_d6d08f0d","line":61,"updated":"2022-03-03 15:36:59.000000000","message":"Very nice test , i would recommend to add in the background:\n- Attach regular type to the instance (not multi-attach)\n- Attach encrypted volume ... \n- Attach multi-attach volume (as you are doing)\n\nI think we can see that all volumes mounted successfully and we are able to delete or detach when having volumes .","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc428a9f07cb324a1e642e14510bb6379ccc430","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        volume \u003d self.create_volume(volume_type\u003dvol_type[\u0027id\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        instance_ip \u003d self.get_server_ip(server_1)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        # Attach volume to instance and find it\u0027s device name (eg: /dev/vdb)"},{"line_number":63,"context_line":"        volume_device_name_inst_1, __ \u003d ("},{"line_number":64,"context_line":"            self._attach_and_get_volume_device_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"dd95f595_26c09455","line":61,"in_reply_to":"3e686883_d6d08f0d","updated":"2022-03-09 08:02:32.000000000","message":"This doesn\u0027t seem to be related to the testing I was aiming for with this test but it\u0027s good for emulating a real world scenario where a VM would\u0027ve all kinds of volumes attached to it. Updating in next PS.","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"69e3d49806f1a0a9e24880ac993d520578b70a62","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            self._attach_and_get_volume_device_name("},{"line_number":87,"context_line":"                server_2, volume, instance_2_ip, self.keypair[\u0027private_key\u0027]))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        md5_file_1 \u003d self._get_file_md5("},{"line_number":90,"context_line":"            instance_2_ip, filename\u003d\u0027file1\u0027,"},{"line_number":91,"context_line":"            dev_name\u003dvolume_device_name_inst_2,"},{"line_number":92,"context_line":"            private_key\u003dself.keypair[\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7eecb076_311c3792","line":89,"updated":"2022-03-03 15:35:58.000000000","message":"This will break some of the time -- it isn\u0027t safe to mount a normal FS on two instances at once and manipulate files.\n\nIt would be better to just do block operations w/ dd or so and not use an FS.","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc428a9f07cb324a1e642e14510bb6379ccc430","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            self._attach_and_get_volume_device_name("},{"line_number":87,"context_line":"                server_2, volume, instance_2_ip, self.keypair[\u0027private_key\u0027]))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        md5_file_1 \u003d self._get_file_md5("},{"line_number":90,"context_line":"            instance_2_ip, filename\u003d\u0027file1\u0027,"},{"line_number":91,"context_line":"            dev_name\u003dvolume_device_name_inst_2,"},{"line_number":92,"context_line":"            private_key\u003dself.keypair[\u0027private_key\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"82724bbd_6e6aab7d","line":89,"in_reply_to":"7eecb076_311c3792","updated":"2022-03-09 08:02:32.000000000","message":"Done","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"083e731f04e32b94ddc1e4c9f3a0c89f04aa7262","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        self._verify_attachment(volume[\u0027id\u0027], server_1[\u0027id\u0027])"},{"line_number":96,"context_line":"        self._verify_attachment(volume[\u0027id\u0027], server_2[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertEqual(file1_md5, md5_file_1)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_volume_multiattach_same_host_negative(self):"},{"line_number":100,"context_line":"        # Create an instance"},{"line_number":101,"context_line":"        server \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"b616371c_f3f3518a","line":98,"updated":"2022-03-03 15:36:59.000000000","message":"Need to add UUID to the testcase","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfc428a9f07cb324a1e642e14510bb6379ccc430","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self._verify_attachment(volume[\u0027id\u0027], server_1[\u0027id\u0027])"},{"line_number":96,"context_line":"        self._verify_attachment(volume[\u0027id\u0027], server_2[\u0027id\u0027])"},{"line_number":97,"context_line":"        self.assertEqual(file1_md5, md5_file_1)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_volume_multiattach_same_host_negative(self):"},{"line_number":100,"context_line":"        # Create an instance"},{"line_number":101,"context_line":"        server \u003d self.create_server("}],"source_content_type":"text/x-python","patch_set":4,"id":"1015c298_330a7c64","line":98,"in_reply_to":"b616371c_f3f3518a","updated":"2022-03-09 08:02:32.000000000","message":"Done","commit_id":"349311c37630b82dd8ddd20438533fe31f4fc96c"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"98d5eff611c4899004fda90c120cafe154f7c080","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            server\u003dserver_1)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Write data to volume device"},{"line_number":89,"context_line":"        ssh_client.exec_command("},{"line_number":90,"context_line":"            \u0027sudo dd bs\u003d1024 count\u003d100 if\u003d/dev/zero of\u003d/dev/%s\u0027 %"},{"line_number":91,"context_line":"            (volume_device_name_inst_1))"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"88d36c2b_dfab7812","line":89,"updated":"2022-03-09 08:21:57.000000000","message":"Any reason we use it here as hard coded and not with create_md5_new_file or other functions ? means we should wrap it somehow in method. we will be able to change the count as param .","commit_id":"bbc7e797838db8ea83d214052b76db2c7fb4ecf3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3950eb4ef7e6589b0063497916c9237cd7c9f246","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            server\u003dserver_1)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Write data to volume device"},{"line_number":89,"context_line":"        ssh_client.exec_command("},{"line_number":90,"context_line":"            \u0027sudo dd bs\u003d1024 count\u003d100 if\u003d/dev/zero of\u003d/dev/%s\u0027 %"},{"line_number":91,"context_line":"            (volume_device_name_inst_1))"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f465829_74f8e319","line":89,"in_reply_to":"88d36c2b_dfab7812","updated":"2022-03-09 09:33:38.000000000","message":"create_md5_new_file does multiple things which are not applicable for raw block devices rather than filesystems like mounting the device FS, creating/writing file etc\nI\u0027ve added new helper methods that will work on block devices.","commit_id":"bbc7e797838db8ea83d214052b76db2c7fb4ecf3"}]}