)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"18680530ec74831330e096a11d97d7801c181e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4aab6a76_4ae0a2c7","updated":"2022-04-12 17:43:23.000000000","message":"https://review.opendev.org/c/openstack/tempest/+/837603\n\nThis patch should be fix the issue when merged","commit_id":"3673c3e41ca23c37b501628d845cced13de14680"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4020ee98c490aa06e83597a54fce8d35daa2aed4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3295ae0_02e2ad23","in_reply_to":"4aab6a76_4ae0a2c7","updated":"2022-04-22 08:46:31.000000000","message":"Done","commit_id":"3673c3e41ca23c37b501628d845cced13de14680"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4020ee98c490aa06e83597a54fce8d35daa2aed4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e138b9f_e3863f23","updated":"2022-04-22 08:46:31.000000000","message":"Thanks Benny for the review.","commit_id":"006b738f1aeff847d66d0d2f5557147914965a35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"623521b787d55512b5832b1816abe464bc7c5a1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6bcfa663_e67db09f","updated":"2022-04-26 06:27:26.000000000","message":"Thanks Benny.","commit_id":"ffa26ebb3d32ce35f1dfead65b07b8a0d1bea0b9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"146e50f69a1d7e21fbdc6a2cd06e2f7f3c6e803d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"adaf78ce_bbb924be","updated":"2022-05-03 15:25:32.000000000","message":"Follow-up patch looks good.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0a4a02a3031ae2b464f7038012491593ac4186be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"185fe1d6_af3c9578","updated":"2022-04-29 03:53:41.000000000","message":"Thanks Eric, see my reply inline.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b226a5d9af16bffbed6fa6ff64b55ec641a45fc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"231f5953_e1614271","updated":"2022-04-28 20:17:48.000000000","message":"The way I see it, this patch adds some stress tests for volumes with the same volume type. This looks like an important set of tests. It would be nice if you could merge this path soon. \nI am waiting for the parent to be merged first.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"783d77171c61662c862a41fe16304b761c0c9f70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"769b75f0_7a5fb787","updated":"2022-04-27 15:38:28.000000000","message":"Waiting for the tempest fix to land...","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b83d6b804c61c0bef4fd73f272f43adea6e00094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"78bdc7f6_7c5dba13","updated":"2022-06-07 16:59:22.000000000","message":"I\u0027m very late to the party and I hate to be ThatOneThatBlocksAtTheEnd, so feel free to ignore this.","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e666c90339b30b5bf347bbecafac14b18ae7bf3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fff608ca_fefd1224","updated":"2022-05-12 05:04:52.000000000","message":"Thanks Ghanshyam for the review, I\u0027ve avoided using tempest/api/base and did changes in plugin itself. If it leads to a lot of duplicate code, we can move towards making these methods stable in tempest. Thanks!","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"94dc03cd126abe8db3288e5f9b9ff4893c06c29a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"44b8e258_f76379a9","updated":"2022-05-12 07:36:42.000000000","message":"recheck\n\nunrelated failure\n\n  File \"/opt/stack/tempest/tempest/lib/services/identity/v3/token_client.py\", line 172, in request\n    raise exceptions.IdentityError(\ntempest.lib.exceptions.IdentityError: Got identity error","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f331450f47028cb2f7ddec9799d14e407339524e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c3f0df42_18151a4d","updated":"2022-06-07 16:38:16.000000000","message":"thanks, lgtm","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"846d307fca5c261f6b8419bc203ca8957c8e1032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fbfb4dd5_e9194f21","updated":"2022-06-08 07:53:49.000000000","message":"\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/cinder_tempest_plugin/scenario/test_snapshots.py\", line 27, in setUp\n    self.security_group \u003d self.create_security_group()\nAttributeError: \u0027SnapshotDataIntegrityTests\u0027 object has no attribute \u0027create_security_group\u0027\n\nWe need to merge https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 before.","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"79d35ae0660532467380171e5b8f9e566b1d559b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ab40f9d1_278bd610","updated":"2022-06-20 20:53:34.000000000","message":"Benny, Ghanshyam, any additional comment after the last change? I will merge before the end of the week if there are no objections.","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"e1db99d947fc675eaf7971942ffc812e8dbf5255","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"95e748db_463898d8","updated":"2022-06-21 03:57:56.000000000","message":"Its ok , we can set the multiple resouce count to config.py , the default is 5 and allowing it as external param will help to flush 10, 20 volume creation ... \nbut it can be done in a seperate patch","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"801f9357299fd5aace64a53e7973080bd98df89c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5d9e690d_c5a6f7b2","updated":"2022-06-09 13:55:03.000000000","message":"LGMT, thanks for working on this ","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"675af3700d65510f5443b0eef7bf2cfa6a6495cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a2a72da_292c92fd","updated":"2022-06-07 17:11:14.000000000","message":"Thanks Luigi","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"686fdbc13a416eaa5b381245d9624b013f6801f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da6bb01b_2b33160a","updated":"2022-06-21 12:15:43.000000000","message":"Thanks!","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5545f5cd6f0eee77ef6a6063616cd4da8bd21933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"32278076_3c0ac9a3","updated":"2022-06-08 10:18:01.000000000","message":"recheck","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"359cb170415fae30e1c5edc3cc778d938c7cd5bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cc80d1e3_4a7f99c0","updated":"2022-06-08 04:31:30.000000000","message":"recheck","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bad01a416d11200fc1682a23216c5f0c7a808a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dc4b1446_dc342acd","updated":"2022-06-21 14:17:57.000000000","message":"recheck\n\ntempest.api.volume.test_volumes_snapshots.VolumesSnapshotTestJSON.test_snapshot_create_delete_with_volume_in_use in the ceph job, probably just flakiness (timeout?)","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5c15958b9a6dc367274b178fb9ced2eeb58e4d7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"933728a4_5c096065","updated":"2022-06-07 20:32:11.000000000","message":"recheck cinder-tempest-plugin-basic-victoria","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"299244a80a35ab185300cccc10df9f9f42e0342d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"51ecee64_1ced6948","in_reply_to":"ab40f9d1_278bd610","updated":"2022-06-20 21:14:16.000000000","message":"ok from my side.","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5545f5cd6f0eee77ef6a6063616cd4da8bd21933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"104a70b3_638b7a9d","in_reply_to":"fbfb4dd5_e9194f21","updated":"2022-06-08 10:18:01.000000000","message":"Merged","commit_id":"f6b9cf6cf8fa86d130ec0ea45a7064666ff2d8f2"}],"cinder_tempest_plugin/api/volume/base.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"43b7961809572b1fb758e53bde484c35b06e2016","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        return snapshot"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def create_volume_no_wait(cls, **kwargs):"},{"line_number":120,"context_line":"        \"\"\"Returns a test volume."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        This does not wait for volume creation to finish,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8531f0fa_2544d67a","line":119,"updated":"2022-04-12 17:19:22.000000000","message":"Looks like this is something that should be extended in tempest base code but if we decide to handle it lets use create_volume with a flag for not-waiting.\nYou can override the name with out additional flags.\n\nor we can change the waiter and when we accept status\u003dNone the code returns.\n\nif status:\n waiters.wait_for_volume_resource_status(cls.volumes_client,\n                                                 volume[\u0027id\u0027], wait_until)\n\nthe second approach is a better solution IMO instead of re-writing the code .\nthe change should come from tempest","commit_id":"3673c3e41ca23c37b501628d845cced13de14680"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4020ee98c490aa06e83597a54fce8d35daa2aed4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return snapshot"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @classmethod"},{"line_number":119,"context_line":"    def create_volume_no_wait(cls, **kwargs):"},{"line_number":120,"context_line":"        \"\"\"Returns a test volume."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        This does not wait for volume creation to finish,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7925847e_3fae869e","line":119,"in_reply_to":"8531f0fa_2544d67a","updated":"2022-04-22 08:46:31.000000000","message":"Done","commit_id":"3673c3e41ca23c37b501628d845cced13de14680"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d64907683df0413b4fcc073ad180d7f68b2a50c2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.volume import base as tempest_base"},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":6,"id":"75be40ff_bcb8d377","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":51},"updated":"2022-05-06 15:51:53.000000000","message":"I will suggest not to do this but if we do we should be aware that this is unstable interface and can be changed anytime and that can break the cinder-tempest-plugin.\n\nThat is reason we added this base class here and remvoe the usage of tempest one - https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/533118","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71e7223ac2d10fa0220846098b83d46aa58231a4","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.volume import base as tempest_base"},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":6,"id":"eb1bb2b6_aa80a299","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":51},"in_reply_to":"75be40ff_bcb8d377","updated":"2022-05-06 15:56:39.000000000","message":"I know it will lead to duplicate code but that is better than using private interface gets broken which was the case earlier.\n\nIf that is too much of duplicate code then we can think of making the common code as stable in tempest and then plugins can use it but that will be tempest.volume.base as complete.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e666c90339b30b5bf347bbecafac14b18ae7bf3f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.api.volume import base as tempest_base"},{"line_number":17,"context_line":"from tempest.common import compute"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest import config"}],"source_content_type":"text/x-python","patch_set":6,"id":"d5d852ff_683dfac6","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":51},"in_reply_to":"eb1bb2b6_aa80a299","updated":"2022-05-12 05:04:52.000000000","message":"Done","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"}],"cinder_tempest_plugin/api/volume/test_multiple_volume_from_resource.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"4c8b9285df1e0ac144038ab60f249ca8c1434d73","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CreateMultipleVolumeTest(base.BaseVolumeTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _create_multiple_volume_from_resource(self, resource, resource_id):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        vols \u003d []"},{"line_number":26,"context_line":"        for _ in range(5):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e4a9d980_ff4b6ff5","line":23,"updated":"2022-04-22 11:08:12.000000000","message":"Nice , few comments:\n# the 5 is hardcoded and wont allow to change it in other tests , maybe send it as param.\n\n# the resource\u003dresource_id are kwargs, please change it to:\nkwargs \u003d {\"\u0027snapshot_id\": snapshot[\u0027id\u0027]}\ndef _create_multiple_volume_from_resource(self, **kwargs)\n\nIt will allow as to extend the create volumes from example images.\nif the number of volumes is same for all create , please take it out from function , not 5\n\nI like the code and it might open for us allocation for multiple resources with callback...\n\nsomething like:\n_create_multiple_resource(self, callback, **kwargs):\n\n  res \u003d []\n        for _ in range(repeat_count):\n            res.append(callback(**kwargs)[\u0027id\u0027])\n\n        return res\n\n_wait_for_multiple_resource(self, callback, wait_list, **kwargs):\n        for r in wait_list:\n            callback(**kwargs)\n\nkwargs_create\u003d{\u0027backup_id\u0027: backup[\u0027id\u0027], \"wait_until\": None}\nlist_ids \u003d self._create_multiple_resource(self,self.create_volume, **kwargs_create)\n.........\n\nBenny","commit_id":"006b738f1aeff847d66d0d2f5557147914965a35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"623521b787d55512b5832b1816abe464bc7c5a1c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CreateMultipleVolumeTest(base.BaseVolumeTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _create_multiple_volume_from_resource(self, resource, resource_id):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        vols \u003d []"},{"line_number":26,"context_line":"        for _ in range(5):"}],"source_content_type":"text/x-python","patch_set":4,"id":"23b883bd_eebdc412","line":23,"in_reply_to":"e4a9d980_ff4b6ff5","updated":"2022-04-26 06:27:26.000000000","message":"Done\n\nThanks for the suggestion, I liked the idea of making it generic so we can easily extend it.\nWe already have tests for images and I will move them in this file in next PS.","commit_id":"006b738f1aeff847d66d0d2f5557147914965a35"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"10d4ebbeb84c58bd3525aebff21e811d40603096","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":46,"context_line":"        kwargs_create \u003d {\"\u0027snapshot_id\": snapshot[\u0027id\u0027], \"wait_until\": None}"},{"line_number":47,"context_line":"        res \u003d self._create_multiple_resource(self.create_volume,"},{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f8da9b6_884e9bb8","line":46,"range":{"start_line":46,"start_character":57,"end_line":46,"end_character":75},"updated":"2022-05-03 15:34:13.000000000","message":"Don\u0027t you now have to bump cinder-tempest-plugin\u0027s requirements.txt to a sufficiently new tempest version that supports this field?  (Currently states \u003e\u003d27.0.0.)","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d64907683df0413b4fcc073ad180d7f68b2a50c2","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":46,"context_line":"        kwargs_create \u003d {\"\u0027snapshot_id\": snapshot[\u0027id\u0027], \"wait_until\": None}"},{"line_number":47,"context_line":"        res \u003d self._create_multiple_resource(self.create_volume,"},{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"d37ccce8_8cbee57c","line":46,"range":{"start_line":46,"start_character":57,"end_line":46,"end_character":75},"in_reply_to":"5f8da9b6_884e9bb8","updated":"2022-05-06 15:51:53.000000000","message":"We do not need to at least for upstream CI. Tempest master is used to test the upstream CI including the supported stable branch and any new things in tempest will be available to use in plugins.\n\nWe usually do the same in other plugins also and when new tempest tag is released then you can update the requriement also while releasing of Zed cycle but that will be mainly for the downstream testing and if anyone want to ref it.\n\nIs that work for cinder-tempest-plugin too?","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e666c90339b30b5bf347bbecafac14b18ae7bf3f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        volume \u003d self.create_volume()"},{"line_number":45,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":46,"context_line":"        kwargs_create \u003d {\"\u0027snapshot_id\": snapshot[\u0027id\u0027], \"wait_until\": None}"},{"line_number":47,"context_line":"        res \u003d self._create_multiple_resource(self.create_volume,"},{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"}],"source_content_type":"text/x-python","patch_set":6,"id":"99a7a4ea_3cd2336b","line":46,"range":{"start_line":46,"start_character":57,"end_line":46,"end_character":75},"in_reply_to":"d37ccce8_8cbee57c","updated":"2022-05-12 05:04:52.000000000","message":"Ack, since I\u0027m not using tempest/api/base anymore, this shouldn\u0027t be required but should work for us for any future patch.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5caf1fc0b0dc929ba867233a8ec0cb96fab7e3f","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"},{"line_number":50,"context_line":"        self._wait_for_multiple_resources("},{"line_number":51,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateVolumesFromSourceVolumeTest(CreateMultipleResourceTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bcae1266_e6749eaf","line":51,"updated":"2022-04-28 20:41:26.000000000","message":"This is good, but it seems like a missed opportunity to not have this test also issue simultaneous deletions for these volumes... would be great to have this in the same test rather than needing another test that builds a handful of volumes just to test deletes.","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e3834dd953b277e5bf0881c092a6f92637c45d8c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"},{"line_number":50,"context_line":"        self._wait_for_multiple_resources("},{"line_number":51,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateVolumesFromSourceVolumeTest(CreateMultipleResourceTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"c1417d9e_a40cab27","line":51,"in_reply_to":"32468d31_1c1a2057","updated":"2022-04-29 07:56:14.000000000","message":"Proposed a followup here: https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/839871","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0a4a02a3031ae2b464f7038012491593ac4186be","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                                             **kwargs_create)"},{"line_number":49,"context_line":"        kwargs_wait \u003d {\"client\": self.volumes_client, \"status\": \"available\"}"},{"line_number":50,"context_line":"        self._wait_for_multiple_resources("},{"line_number":51,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateVolumesFromSourceVolumeTest(CreateMultipleResourceTest):"}],"source_content_type":"text/x-python","patch_set":6,"id":"32468d31_1c1a2057","line":51,"in_reply_to":"bcae1266_e6749eaf","updated":"2022-04-29 03:53:41.000000000","message":"That is a good case to add but the main purpose of this patch is intended to stress test the creation part. I agree that adding the deletion testing will be good but that i think can be addressed in a followup and should not be a blocking change for this patch? wdyt?\nAlso this change has been sitting here since 1 year with a good amount of reviews received recently, I would rather not want to lose that and then this patch might take months again to merge...","commit_id":"461f76e5f1c6d90759bf8ff42719f3faccdec375"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b83d6b804c61c0bef4fd73f272f43adea6e00094","unresolved":true,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CreateMultipleResourceTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _create_multiple_resource(self, callback, repeat_count\u003d5,"},{"line_number":28,"context_line":"                                  **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a25af95_0bf50a64","line":25,"updated":"2022-06-07 16:59:22.000000000","message":"I would move this class to base, it may be useful elsewhere.","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"675af3700d65510f5443b0eef7bf2cfa6a6495cb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CreateMultipleResourceTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _create_multiple_resource(self, callback, repeat_count\u003d5,"},{"line_number":28,"context_line":"                                  **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"2e0dc310_bed4d7dd","line":25,"in_reply_to":"7a25af95_0bf50a64","updated":"2022-06-07 17:11:14.000000000","message":"Done","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b83d6b804c61c0bef4fd73f272f43adea6e00094","unresolved":true,"context_lines":[{"line_number":95,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class VolumeFromImageTest(CreateMultipleResourceTest):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @classmethod"},{"line_number":101,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3134f852_be176518","line":98,"updated":"2022-06-07 16:59:22.000000000","message":"just a small consistency note:\nThis class keeps the old name (\u003can_object\u003eFrom\u003csomethingelse\u003eTest), where \u003can_object\u003e is singolar but should be plural.\nThe new classes use a different pattern (Create\u003csomeobject\u003eFrom\u003csomethingelse\u003eTest)\n\nI suggest to unify the pattern.\n- either change VolumeFromImageTest to CreateVolumesFromImageTest (the python path is already broken by moving to a new file)\n- or change the other classes to, for example, VolumesFromBackupTest, but then this class should be changed to as VolumesFromImageTest.","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"675af3700d65510f5443b0eef7bf2cfa6a6495cb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            waiters.wait_for_volume_resource_status, res, **kwargs_wait)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class VolumeFromImageTest(CreateMultipleResourceTest):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @classmethod"},{"line_number":101,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f86b93c_b53a2ba6","line":98,"in_reply_to":"3134f852_be176518","updated":"2022-06-07 17:11:14.000000000","message":"Done","commit_id":"d85a2fa63e17047c5bcb6ecfc481497505d511ad"}]}