)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"dd5babc702828216a6b4fe8f065e401eb39305fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ded5b9a_6870c6c7","updated":"2022-09-19 16:21:02.000000000","message":"The Ceph job is failing because we should enable v2 clone on CI: https://review.opendev.org/c/openstack/cinder/+/848013","commit_id":"b2eda088e8d411ca58c62003b6c59b80e6eb0c5e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d542e2621569a40e52134a1f27b2cde12d3f2998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"614bf414_f1ba84f0","in_reply_to":"8ded5b9a_6870c6c7","updated":"2024-03-14 14:58:31.000000000","message":"Done","commit_id":"b2eda088e8d411ca58c62003b6c59b80e6eb0c5e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2da89da4dba6099b6f860de4f16abc12be7d7d9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef500233_24b9d94d","updated":"2024-03-08 15:59:36.000000000","message":"recheck","commit_id":"d71337a951a4a9c74895e9a8040d74f279ad9084"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b83fcb41024acdf7979b804e28a5f95b5571c392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"25efdbb6_9fe67eda","updated":"2024-05-23 16:13:08.000000000","message":"I looked through the existing tests in the cinder-tempest-plugin, and don\u0027t see anything exactly like these new tests, so they\u0027re definitely worth adding.  Question (or more of a comment) inline.\n\nI guess the only open issue is whether the rbd driver in older than Bobcat releases will be able to pass this test?","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5cbca5f6287f4aba2f3c0799f6430180afb7512d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0c5ec720_a48e89cd","updated":"2024-05-28 12:09:22.000000000","message":"check experimental","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2c2a2130a659d8ba7193172bd370f0980ae21f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9c545231_3c5b420f","in_reply_to":"25efdbb6_9fe67eda","updated":"2024-05-28 12:10:28.000000000","message":"I think it will fail on the older releases w/ RBD.  \"check experimental\" below should confirm this.","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cfe7ec833f7dfed4b82db6ba1a23f19353d51171","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2d8199b_d06aaf9b","in_reply_to":"2c689109_d7551bf3","updated":"2024-05-28 14:11:35.000000000","message":"Done","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b723aeadabac921872c229c4d23c5b9550067319","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c9177705_d2cf1b12","in_reply_to":"9c545231_3c5b420f","updated":"2024-05-28 12:10:52.000000000","message":"(didn\u0027t mean to resolve this thread)","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7f009987e2d50e9e3a55603b03f727c2fbc64081","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c689109_d7551bf3","in_reply_to":"c9177705_d2cf1b12","updated":"2024-05-28 12:48:43.000000000","message":"So should we run the tests conditionally based on CONF.volume_feature_enabled.volume_image_dep_tests ?","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b818c413bd3b7c6b2c8dbf8d94da539bd9c4526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"703cdeda_241bf99f","updated":"2024-05-28 16:02:01.000000000","message":"Problem noted inline.","commit_id":"2c89c136745443af5f0f9ff5bd3bda774789fdd1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"622d5b9b08693e50cc32b16a102fae8cb533754b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2a4389e6_4a22b469","updated":"2024-05-29 12:55:15.000000000","message":"LGTM","commit_id":"92e0b851deda54469a1da4fb60990897eb86ff58"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"26d02860b938ddfebd6f388837adf6bc0d57751c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ea656dc8_b5cfc9aa","updated":"2024-05-28 21:43:06.000000000","message":"bad copy ... the failed test was tempest.api.volume.test_volumes_actions.VolumesActionsTest.test_volume_upload","commit_id":"92e0b851deda54469a1da4fb60990897eb86ff58"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"26fd8268a29c97dbcd2e35af60deed0808497241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4794c312_210d470d","updated":"2024-05-29 00:44:36.000000000","message":"recheck cinder-tempest-plugin-lvm-multiattach - tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_image_defined_boot_from_volume : server failed to build","commit_id":"92e0b851deda54469a1da4fb60990897eb86ff58"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"66fe58c528524a906506bffa118f07cdd91ca085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6c0a847c_ebb4a918","updated":"2024-05-28 21:42:27.000000000","message":"recheck recheck cinder-tempest-plugin-lvm-lio-barbican - cinder-tempest-plugin-lvm-lio-barbican : image went from queued to deleted status","commit_id":"92e0b851deda54469a1da4fb60990897eb86ff58"}],"cinder_tempest_plugin/scenario/test_snapshots.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"88a7af099755200ad990273e57d8f8178253e3ca","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotDataIntegrityTests(manager.ScenarioTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(SnapshotDataIntegrityTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"565d0d10_af137326","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"updated":"2021-08-24 20:37:01.000000000","message":"The new test isn\u0027t a data integrity test, figure out if this should be renamed or if it should go in a new class.","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a49bdc9c0eaf5b7c0da2208a97cd823a85b153a9","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotDataIntegrityTests(manager.ScenarioTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(SnapshotDataIntegrityTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7fb695b_afd39693","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"in_reply_to":"323cd04a_e65f6586","updated":"2024-03-14 09:24:21.000000000","message":"So what about a new class? Otherwise it looks fine.","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"dd5babc702828216a6b4fe8f065e401eb39305fe","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotDataIntegrityTests(manager.ScenarioTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(SnapshotDataIntegrityTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"323cd04a_e65f6586","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"in_reply_to":"565d0d10_af137326","updated":"2022-09-19 16:21:02.000000000","message":"Maybe new class","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"62337b7bc7e6e071e2f9cef1dc8ba980f1dd8073","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SnapshotDataIntegrityTests(manager.ScenarioTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def setUp(self):"},{"line_number":26,"context_line":"        super(SnapshotDataIntegrityTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"e87b6145_4f72b079","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":32},"in_reply_to":"e7fb695b_afd39693","updated":"2024-03-14 14:58:23.000000000","message":"Done","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"40ec905f47bc23ae623a0af16729573893c5990f","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":185,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"},{"line_number":188,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_1[\u0027id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.volumes_client.delete(volume_2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"26037435_9a652213","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":3},"updated":"2021-08-24 21:46:16.000000000","message":"I need to double check this again but as far as I understand cinder always returns success when deleting even if it fails. Maybe we need to check if the volume is still showing when listing volumes.","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"37a0eee9381b2a40c426ba423d1fd037abc5ff1b","unresolved":true,"context_lines":[{"line_number":184,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":185,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"},{"line_number":188,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_1[\u0027id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.volumes_client.delete(volume_2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1b7f52d_f9a4468f","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":3},"in_reply_to":"26037435_9a652213","updated":"2021-09-02 18:26:15.000000000","message":"I think wait_for_resource_deletion() below accomplishes this.","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"52642e9b13a345c69bcb82af026ee3f154260073","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":185,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"},{"line_number":188,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_1[\u0027id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.volumes_client.delete(volume_2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"34c38715_326d4c55","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":3},"in_reply_to":"b1b7f52d_f9a4468f","updated":"2022-09-19 16:12:59.000000000","message":"Done","commit_id":"dc0fe89d876710c769cd70d79eb4f03c309d4ee4"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"204fe38061090cc5bfab4dd8314b641cf5642ed6","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            self.volumes_client, volume_2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":131,"context_line":"        volume_2 \u003d self.volumes_client.show_volume(volume_2[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":134,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"92e8d939_0f19d22a","line":133,"updated":"2024-03-11 09:01:59.000000000","message":"it seems this test is failing in all jobs on this line:\n\nself.snapshots_client.delete(snapshot_1[\u0027id\u0027])\n\nwith the following exception:\n\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 70, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/cinder_tempest_plugin/scenario/test_snapshots.py\", line 143, in test_snapshot_removal\n    self.snapshots_client.delete(snapshot_1[\u0027id\u0027])\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 339, in delete\n    return self.request(\u0027DELETE\u0027, url, extra_headers, headers, body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 742, in request\n    self._error_checker(resp, resp_body)\n  File \"/opt/stack/tempest/tempest/lib/common/rest_client.py\", line 852, in _error_checker\n    raise exceptions.NotFound(resp_body, resp\u003dresp)\ntempest.lib.exceptions.NotFound: Object not found\nDetails: {\u0027message\u0027: \u0027The resource could not be found.\u003cbr /\u003e\u003cbr /\u003e\\n\\n\\n\u0027, \u0027code\u0027: \u0027404 Not Found\u0027, \u0027title\u0027: \u0027Not Found\u0027}","commit_id":"d71337a951a4a9c74895e9a8040d74f279ad9084"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"33c1b5d78cd7fab36366f257c9f17306fec7bfc2","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            self.volumes_client, volume_2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":131,"context_line":"        volume_2 \u003d self.volumes_client.show_volume(volume_2[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":134,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2efadc8_cdf19509","line":133,"in_reply_to":"92e8d939_0f19d22a","updated":"2024-03-13 19:51:13.000000000","message":"This calls\n404 DELETE https://10.209.99.254/volume/v3/ff4c773ab98d4559ab5eade91a179d0c/f7c4ff88-ac58-4857-a178-65b39ae6c3ba\n\nbut should call\n202 DELETE https://10.209.99.254/volume/v3/ff4c773ab98d4559ab5eade91a179d0c/snapshots/f7c4ff88-ac58-4857-a178-65b39ae6c3ba\n\n(because it should have been self.snapshots_client.delete_snapshot() instead of delete().)\n\nThanks for pointing this out!","commit_id":"d71337a951a4a9c74895e9a8040d74f279ad9084"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d030cc8b3f0256084b7a393f66ef36106a3ee0c2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self.volumes_client, volume_2[\u0027id\u0027], \u0027available\u0027)"},{"line_number":131,"context_line":"        volume_2 \u003d self.volumes_client.show_volume(volume_2[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        self.snapshots_client.delete(snapshot_1[\u0027id\u0027])"},{"line_number":134,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"f6c5c3b2_43f51530","line":133,"in_reply_to":"a2efadc8_cdf19509","updated":"2024-03-13 19:51:56.000000000","message":"Done","commit_id":"d71337a951a4a9c74895e9a8040d74f279ad9084"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b70d202b6840963f25f17cd62fe95f914b3ac533","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        self.snapshots_client.delete_snapshot(snapshot_1[\u0027id\u0027])"},{"line_number":134,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"},{"line_number":137,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_1[\u0027id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.volumes_client.delete(volume_2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"2e6fa6d9_ebb68b43","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":34},"updated":"2024-03-13 20:52:37.000000000","message":"Need to use delete_volume here...","commit_id":"4347300bb1ed28026a14f930a2314e33514d63da"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"62337b7bc7e6e071e2f9cef1dc8ba980f1dd8073","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.snapshots_client.delete_snapshot(snapshot_1[\u0027id\u0027])"},{"line_number":134,"context_line":"        self.snapshots_client.wait_for_resource_deletion(snapshot_1[\u0027id\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.volumes_client.delete(volume_1[\u0027id\u0027])"},{"line_number":137,"context_line":"        self.volumes_client.wait_for_resource_deletion(volume_1[\u0027id\u0027])"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.volumes_client.delete(volume_2[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"499fb057_0dc6c4c4","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":34},"in_reply_to":"2e6fa6d9_ebb68b43","updated":"2024-03-14 14:58:23.000000000","message":"Done","commit_id":"4347300bb1ed28026a14f930a2314e33514d63da"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1539aaa519022377a9189d17ffc560e6098ae35f","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            self.assertEqual(file_map[i], md5_file)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @decorators.idempotent_id(\u0027e7028f52-f6d4-479c-8809-6f6cf96cfe0f\u0027)"},{"line_number":117,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":118,"context_line":"    def test_snapshot_removal(self):"},{"line_number":119,"context_line":"        volume_1 \u003d self.create_volume_from_image()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"107a3e96_0bbb989e","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":29},"updated":"2024-03-14 13:17:04.000000000","message":"I think this is wrong, should be \u0027image\u0027?","commit_id":"049c3d2bd5bb67b302379549387bd9f8126ec522"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4f5ea7aabde9f08e6eb794c5f3af745e1facd17d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            self.assertEqual(file_map[i], md5_file)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @decorators.idempotent_id(\u0027e7028f52-f6d4-479c-8809-6f6cf96cfe0f\u0027)"},{"line_number":117,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027)"},{"line_number":118,"context_line":"    def test_snapshot_removal(self):"},{"line_number":119,"context_line":"        volume_1 \u003d self.create_volume_from_image()"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4a6903d6_35e5e8c1","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":29},"in_reply_to":"107a3e96_0bbb989e","updated":"2024-03-14 13:23:04.000000000","message":"Done","commit_id":"049c3d2bd5bb67b302379549387bd9f8126ec522"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b83fcb41024acdf7979b804e28a5f95b5571c392","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    @decorators.idempotent_id(\u0027e7028f52-f6d4-479c-8809-6f6cf96cfe0f\u0027)"},{"line_number":129,"context_line":"    @utils.services(\u0027image\u0027, \u0027volume\u0027)"},{"line_number":130,"context_line":"    def test_snapshot_removal(self):"},{"line_number":131,"context_line":"        volume_1 \u003d self.create_volume_from_image()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        snapshot_1 \u003d self.create_volume_snapshot(volume_1[\u0027id\u0027], force\u003dTrue)"},{"line_number":134,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"eca0bf82_96e3be64","line":131,"range":{"start_line":131,"start_character":24,"end_line":131,"end_character":48},"updated":"2024-05-23 16:13:08.000000000","message":"This will use whatever is configured as CONF.compute.image_ref for the image.  I guess you\u0027re creating a volume from an image so that it\u0027s got something in it, and this is a good way because you don\u0027t have to attach the volume \u0026 write stuff into it like in the test class above.  I was thinking this could put a dependency on the image when using ceph, but since we\u0027re not deleting the image, I guess it doesn\u0027t matter.  And since you explicitly delete all the resources created in the test, you won\u0027t be leaving anything around to prevent the image from being deleted (though I imagine that the default tempest image isn\u0027t going to be deleted by any tests, anyway).\n\nJust thinking out loud here ... i think this is all OK.  (But leaving the comment so you can check my work.)","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d0825cfe16b7a5ce9c08eb24acc8c250fb324428","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    @decorators.idempotent_id(\u0027e7028f52-f6d4-479c-8809-6f6cf96cfe0f\u0027)"},{"line_number":129,"context_line":"    @utils.services(\u0027image\u0027, \u0027volume\u0027)"},{"line_number":130,"context_line":"    def test_snapshot_removal(self):"},{"line_number":131,"context_line":"        volume_1 \u003d self.create_volume_from_image()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        snapshot_1 \u003d self.create_volume_snapshot(volume_1[\u0027id\u0027], force\u003dTrue)"},{"line_number":134,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"9482466e_86b97eba","line":131,"range":{"start_line":131,"start_character":24,"end_line":131,"end_character":48},"in_reply_to":"eca0bf82_96e3be64","updated":"2024-05-28 12:01:09.000000000","message":"I think it is indeed all OK, but it would probably be better for this test to just create a blank volume (and therefore be a lighter-weight test as far as resources used) since creating the volume from an image isn\u0027t really needed here.","commit_id":"95e64bd9e873773230dceae5ab28dadf8c80c1e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b818c413bd3b7c6b2c8dbf8d94da539bd9c4526","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.common import utils"},{"line_number":17,"context_line":"from tempest.common import waiters"},{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"683d071d_c9a41f8f","line":18,"updated":"2024-05-28 16:02:01.000000000","message":"looks like you need:\n\n```\nfrom tempest import config\n\nCONF \u003d config.CONF\n```","commit_id":"2c89c136745443af5f0f9ff5bd3bda774789fdd1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae57eb411946e3e1225023d79013e50d3db68866","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.common import utils"},{"line_number":17,"context_line":"from tempest.common import waiters"},{"line_number":18,"context_line":"from tempest.lib import decorators"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder_tempest_plugin.scenario import manager"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"db0a4819_662a6647","line":18,"in_reply_to":"683d071d_c9a41f8f","updated":"2024-05-28 16:24:29.000000000","message":"Done","commit_id":"2c89c136745443af5f0f9ff5bd3bda774789fdd1"}]}