)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"facdb555cc9f4049931c9f0ba2b8e096e5060f18","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume: fix wrong snapshot_id for revert_to_snapshot_after_extended_negative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"revert_to_snapshot receive snapshot_id not a snapshot object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ibccc48c5afb402e899ebbb471e2fc2e90d4d8886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dbb2f900_76b47d45","line":9,"updated":"2021-11-02 15:24:28.000000000","message":"I think this commit message needs a more detailed explanation of why you\u0027re proposing this fix. Is this patch related to https://review.opendev.org/c/openstack/cinder-specs/+/736111 or is it a bugfix ?","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"3ef041b7724608b303207fa554d0282caaf6daa5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume: fix wrong snapshot_id for revert_to_snapshot_after_extended_negative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"revert_to_snapshot receive snapshot_id not a snapshot object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ibccc48c5afb402e899ebbb471e2fc2e90d4d8886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c3d7dca5_2bdeb8de","line":9,"in_reply_to":"27f5121e_5f8325e5","updated":"2021-11-04 11:36:01.000000000","message":"Any plan for the merge? :)","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9cab3e0feb0451fcd6d6e4fadc7e9bc33282f59d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume: fix wrong snapshot_id for revert_to_snapshot_after_extended_negative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"revert_to_snapshot receive snapshot_id not a snapshot object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ibccc48c5afb402e899ebbb471e2fc2e90d4d8886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"27f5121e_5f8325e5","line":9,"in_reply_to":"bfdc0498_6c8a5c2c","updated":"2021-11-02 16:05:13.000000000","message":"Dismiss my last comment, I mixed up patches... my bad.\nFrom https://opendev.org/openstack/cinder-tempest-plugin/src/branch/master/cinder_tempest_plugin/services/volume_revert_client.py#L30 this looks good to me!","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2f769b58bb6ecba85a7f2af2b47fe17747c536b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume: fix wrong snapshot_id for revert_to_snapshot_after_extended_negative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"revert_to_snapshot receive snapshot_id not a snapshot object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ibccc48c5afb402e899ebbb471e2fc2e90d4d8886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"76edeb9a_2696e1f1","line":9,"in_reply_to":"c3d7dca5_2bdeb8de","updated":"2021-11-12 09:56:12.000000000","message":"Done","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"43ff3bc796ce1cb849880f24478da7d47e5fda33","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume: fix wrong snapshot_id for revert_to_snapshot_after_extended_negative"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"revert_to_snapshot receive snapshot_id not a snapshot object"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Ibccc48c5afb402e899ebbb471e2fc2e90d4d8886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdc0498_6c8a5c2c","line":9,"in_reply_to":"dbb2f900_76b47d45","updated":"2021-11-02 15:27:29.000000000","message":"\u003e I think this commit message needs a more detailed explanation of why you\u0027re proposing this fix. Is this patch related to https://review.opendev.org/c/openstack/cinder-specs/+/736111 or is it a bugfix ?\n\nIt\u0027s a general bug fix. I faced it in my PR to a cinder.","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b10db9e003d509695ac8cf20e187f0623d9bf889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"244a97e4_25f8b52a","updated":"2021-11-11 15:40:55.000000000","message":"As Sofia pointed out, the signature of VolumeRevertClient.revert_to_snapshot() expects an id, not an object, so this change looks correct.","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"facdb555cc9f4049931c9f0ba2b8e096e5060f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51f717f0_f4c40175","updated":"2021-11-02 15:24:28.000000000","message":"Greetings Seena Fallah.","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"476c1f8f47ae603f07b4374b2850ef88d7789709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"345e0b72_f0bffecc","updated":"2021-11-11 15:59:47.000000000","message":"Tricky bug: the exception is raised also in the current state, even though the associated error message is different.\n\nRight now it would be;\n\n    b\u0027tempest.lib.exceptions.BadRequest: Bad request\u0027                                                                                                                                        \n    b\u0027Details: {\\\u0027code\\\u0027: 400, \\\u0027message\\\u0027: \"Specified snapshot {\\\u0027id\\\u0027: \\\u0027baf34b7f-a068-4cd9-a0e2-7992c4867281\\\u0027, \\\u0027created_at\\\u0027: \\\u00272021-11-11T15:55:58.146460\\\u0027, \\\u0027updated_at\\\u0027: None, \\\u0027na\nme\\\u0027: \\\u0027tempest-VolumeRevertTests-Snapshot-636362430\\\u0027, \\\u0027description\\\u0027: None, \\\u0027volume_id\\\u0027: \\\u0027f86a06c7-1e63-47bc-af7e-d269dbd8c223\\\u0027, \\\u0027status\\\u0027: \\\u0027creating\\\u0027, \\\u0027size\\\u0027: 1, \\\u0027metadata\\\u0027: \n{\\\u0027mykey1\\\u0027: \\\u0027value1\\\u0027}} is None or not the latest one of volume f86a06c7-1e63-47bc-af7e-d269dbd8c223.\"}\u0027                                                                                   \n    b\u0027\u0027 \n    \n\nAfter the fix it would become:\n\n    b\u0027tempest.lib.exceptions.BadRequest: Bad request\u0027                                                                                                                                        \n    b\u0027Details: {\\\u0027code\\\u0027: 400, \\\u0027message\\\u0027: \"Can\\\u0027t revert volume 81c19734-cfe0-4d68-a463-cbdcd6f6b0ca to its latest snapshot d6770bef-8202-43f8-b151-7623b182a0ff. The volume size must be e\nqual to the snapshot size.\"}\u0027\n\n","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ae7a2358e6f45b243559df751f7427a4481fca92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b365fd4_11ab2e27","updated":"2021-11-12 09:56:44.000000000","message":"recheck","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"61082d4a3ed1e49baa5b84a1c480e72d694804a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3d31969_8535ca6c","updated":"2021-11-11 15:34:19.000000000","message":"recheck","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"59a607c229d6afa51bdfe0e38b831beb25a4258e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ab5dfad_82ce269c","in_reply_to":"345e0b72_f0bffecc","updated":"2021-11-12 13:50:52.000000000","message":"Thanks Luigi, I\u0027ll open a proper launchpad bug to track this.","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"e86c9c3329ccacecdffd348302908b10f26abcf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"930100ea_799a29b1","in_reply_to":"39dc38fe_7c304157","updated":"2021-11-12 14:17:17.000000000","message":"Oh, but it\u0027s not a bug - it\u0027s expected. I was just trying to say that it was difficult to find that the wrong parameter was passed, because that wrong parameter triggered the same expected exception as in the regular case.","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c58d04ee4b405c8b289c80d55e21f3fdd7cc8382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"39dc38fe_7c304157","in_reply_to":"3ab5dfad_82ce269c","updated":"2021-11-12 13:56:04.000000000","message":"https://bugs.launchpad.net/cinder-tempest-plugin/+bug/1950790","commit_id":"a30dd6ea3397602cee62847ab493837ecc32fd8c"}]}