)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b4d63830a3154fe39ebe877c166115493bcb07a0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"the job template change in openstack-zuul-job and you"},{"line_number":12,"context_line":"can see the updated template job in gate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/818609"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"this commit makes other required changes in setup.cfg metadata."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d137ed5c_e366c30f","line":14,"updated":"2021-12-03 09:29:22.000000000","message":"This change and the governance shows a removal of py3.6, and the commit message doesn\u0027t explain why it is kept (no reference to this change being branchless, or the tempest commit). Also, the TC has changed the runtimes again, making this reference a bit outdated:\n\nhttp://lists.openstack.org/pipermail/openstack-discuss/2021-December/026164.html (which links to https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286 ) but this again doesn\u0027t change what tempest and its plugin tests (as they need to cover several openstack releases).\n\n\nMy suggestion is to simply write a proper custom commit message which reference the tempest one, explaining exactly what\u0027s going on here.","commit_id":"797474513654131bbfa3f6a961a5d17eecdb2118"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7cba16e2df54e6fbc57a8c6fc7209789d2712234","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32cde3b4_3cb9abc6","updated":"2021-11-26 13:29:20.000000000","message":"Except we can\u0027t do this, because this is branchless and it\u0027s still testing the released version which required py36 (leaving aside ussuri which is EM, victoria, wallaby and xena all use it).","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"91d398ff2ff84b21d2b88542edc773e1f698ec1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7d2e98a6_5542595c","updated":"2021-11-29 09:54:26.000000000","message":"In fact tempest added 3.9 without removing the old runtimes: https://review.opendev.org/c/openstack/tempest/+/816553","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a01d3df7d25ec50fcc90f7ea82db65e235e610cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3727c513_23b64970","updated":"2021-12-02 17:42:12.000000000","message":"yeah, cinder-tempest-plugin is branchless so let\u0027s tests all version explicitly as done in https://review.opendev.org/c/openstack/tempest/+/816553 ","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"34346fa227e2ed7b9b43cad32c0fdf13592a19b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac376a81_6a6cfb14","in_reply_to":"737490f2_816fead4","updated":"2021-12-03 08:38:37.000000000","message":"The commit message needs to be tuned then, because it doesn\u0027t match the change.","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"20110e2de49c6be21bef306db94e3a93f95ad841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"737490f2_816fead4","in_reply_to":"7d2e98a6_5542595c","updated":"2021-12-03 06:30:45.000000000","message":"i\u0027ve updated it would you take a look","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"9b1fa67f8364bdb968240d207ffb2e4f7b1c8063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbff41fd_a4e78581","in_reply_to":"ac376a81_6a6cfb14","updated":"2021-12-03 08:48:13.000000000","message":"done","commit_id":"6a166acb1b91b37e5ae2a9e5689ce698dd902752"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b4d63830a3154fe39ebe877c166115493bcb07a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0951a170_6f3cc6b8","updated":"2021-12-03 09:29:22.000000000","message":"The update you reference","commit_id":"797474513654131bbfa3f6a961a5d17eecdb2118"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a98de7342f61000c88886c31b8fc5f2fa455eae2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"173169cc_ec0d9cc3","updated":"2021-12-09 13:17:59.000000000","message":"Can you please keep it simple and just add the setup.cfg change? \nWe don\u0027t run unit tests here because the repositories only contains (integration/scenario) tests, not unit tests. And there are no unit tests for the tests themselves.\nI provided https://review.opendev.org/c/openstack/tempest/+/816553 as an example, it doesn\u0027t mean that all the changes applies. That job already had openstack-python3-xena-jobs which we don\u0027t have at all, so the commit message needs to be changes as well.","commit_id":"fd8d4d90d71f73c7a0e7e3fc9f8608d97549bfe0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"558bdca941146279c26736eb0cda6b1a0021cec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec74d403_fc2b55c3","in_reply_to":"173169cc_ec0d9cc3","updated":"2021-12-09 17:18:00.000000000","message":"yeah, i missed that this plugin does not have unit tests(which is most of plugins but not all as they have unit tests for the service clients or common method).\n\nNow question is how to update the setup.cfg for python version tested as we are not testing all the versions. By default all these tests(cinder-tempest-plugin code) run under python 3.6 in stable branch (ubuntu 18.04) and python 3.8 on master(ubuntu 20.04). With these two versions we can consider py3.7 also tested like we consider for any service unit tests.\n\nBut question is where we tests the py3.9? do we have any cinder-tempest-plugin job running on debian11 or centos stream 9 or with py3.9 ? Which i do not think as of now so we can just leave this change as it is and add py3.9 when we started running tests on py3.9 on some job.","commit_id":"fd8d4d90d71f73c7a0e7e3fc9f8608d97549bfe0"}]}