)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"65f86f76046cb3b97edb96dae010234f14e486e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb2988da_f0fb07c8","updated":"2022-04-29 07:57:36.000000000","message":"Somehow I\u0027ve a feeling this might fail for ceph due to the resource dependency (hence a different patch is safer) but let\u0027s see.","commit_id":"dcf3af45dfade486a22bdb235e8612995d87ed18"}],"cinder_tempest_plugin/api/volume/test_multiple_volume_from_resource.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"410b0e8022db6900b588ef84d2c122b42b7dd2ea","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class CreateMultipleResourceTest(base.BaseVolumeTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _create_multiple_resource(self, callback, repeat_count\u003d5,"},{"line_number":25,"context_line":"                                  **kwargs):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        res \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3227cae_d9315e46","line":24,"updated":"2022-04-29 10:51:54.000000000","message":"if we really want to make it extendable we can move the repeat_count to config.py and change request by scale .\nLooks like in tempest the cleanup for volume creation is done in class level. \nMeans if we have multiple tests for create bulk of volumes but the deletion will be done on resource_cleanup in class level. i think that we may hit on quota limits in such tests.\n\nSee from tempest:\ncls.addClassResourceCleanup(test_utils.call_and_ignore_notfound_exc,\n                                    cls.volumes_client.delete_volume,\n                                    volume[\u0027id\u0027])\n\nSo evrey time we create a volume in testcase under class it keeps it up till class resource_cleaup .  we have here two options IMO:\n#1 change tempest code to instance level deletion means on testcase teardown delete the volume\nthere are fuction like def create_volume_snapshot that add to testcase level. self.addCleanup(self.snapshots_client.delete_snapshot\n\nHonestly i dont full understand why , i would expect to delete the resources at the end of the testcase and not keep it till class teardown ... \nI think i am going to change it (at least to try to do it in tempest)\n\n#2 delete the volume bulks at the end of the testcase as you suggested and it will allow us to keep track on failures and keep resources available.\n\n\nBenny","commit_id":"dcf3af45dfade486a22bdb235e8612995d87ed18"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"aab5630a5ee1c2e14fa54527b8a002257afbc0ac","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _delete_multiple_resource(self, callback, resources, client):"},{"line_number":38,"context_line":"        for r in resources:"},{"line_number":39,"context_line":"            callback(client, r)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class CreateVolumesFromSnapshotTest(CreateMultipleResourceTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"210a0bd4_39f0fd5a","line":39,"updated":"2022-04-29 10:32:55.000000000","message":"Please add a waiter when deleting the resouces and verify it was done.\nYou can add self.client.wait_for_resource_deletion(..)\n\nThe best approach will be to fire delete in a bulk and another loop to verify deletion\nYou can controll here the deletion order.","commit_id":"dcf3af45dfade486a22bdb235e8612995d87ed18"}]}