)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c59bd050439246a320813c17b9c62422100496cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4554d754_7f8db191","updated":"2022-08-10 00:31:18.000000000","message":"recheck\n\nUpdated tempest\u0027s volume schema for latest microversions.","commit_id":"0145d68c57af1ef55f0f121402e84b391a2f4633"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c32949b03fcf570fb03084235a3d324f55f36a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4844b4c_6b2d93b1","updated":"2022-08-10 18:55:13.000000000","message":"recheck","commit_id":"cbcdf2669378729b22cc0ce35d83b0f02a4122ff"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"defe02bc643fd67b4cb9cbd93cc0114d1ad65d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5439f9c5_f7bc51f6","updated":"2022-08-11 23:26:29.000000000","message":"Encrypted volume transfer tests pass \\o/","commit_id":"e4af755dd76eb1fe6dce4241a2ef345a432be4c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a896b8ecb0a9cefdca65693a3b00bd2ff533e59e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d1fed08d_98179b5a","updated":"2022-09-23 10:00:14.000000000","message":"I understand that we\u0027re testing the encrypted volume transfer here but we are testing the \"transfer\" operation so it bothers me that we\u0027re not asserting project id before/after the transfer but not a major blocker for me. everything else LGTM.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6ee77357a1b742aa7ca33fc964a3e67c60b0b05e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2612d504_50f0192e","updated":"2022-08-30 18:27:06.000000000","message":"Suggestion inline for updating the api-ref.  Test looks good.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"aeb028f505be99bfa15b55cb50677449285de100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f4feb7aa_e206a1c0","updated":"2022-09-22 21:58:49.000000000","message":"This tests a new Zed feature.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1a6a5d7c787b686f7c2f679012d8288a4abc532e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dda6e6a7_7f4922e5","updated":"2022-08-18 04:28:16.000000000","message":"recheck\n\nlibvirt failure to detach volume","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"613ab3542154be9b4bca06d9e3286f4467af9cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a895be13_165af705","updated":"2022-08-18 01:08:38.000000000","message":"recheck\n\nspurious failure in one backup test cleanup routines.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"}],"cinder_tempest_plugin/scenario/test_encrypted_volume_transfer.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a896b8ecb0a9cefdca65693a3b00bd2ff533e59e","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    def setup_clients(cls):"},{"line_number":34,"context_line":"        super(TransferEncryptedVolumeTest, cls).setup_clients()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # We need the \"mv355\" volume transfers client"},{"line_number":37,"context_line":"        cls.client \u003d cls.os_primary.volume_transfers_mv355_client_latest"},{"line_number":38,"context_line":"        cls.alt_client \u003d cls.os_alt.volume_transfers_mv355_client_latest"},{"line_number":39,"context_line":"        cls.alt_volumes_client \u003d cls.os_alt.volumes_client_latest"}],"source_content_type":"text/x-python","patch_set":7,"id":"0c5f7471_409cde39","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":53},"updated":"2022-09-23 10:00:14.000000000","message":"nit: would\u0027ve been good to add \"as it allows us to transfer volumes with snapshots.\"","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a896b8ecb0a9cefdca65693a3b00bd2ff533e59e","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        return transfer"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _accept_transfer(self, transfer, transfer_client, volumes_client):"},{"line_number":84,"context_line":"        _ \u003d transfer_client.accept_volume_transfer("},{"line_number":85,"context_line":"            transfer[\u0027id\u0027], auth_key\u003dtransfer[\u0027auth_key\u0027])"},{"line_number":86,"context_line":"        waiters.wait_for_volume_resource_status(volumes_client,"},{"line_number":87,"context_line":"                                                transfer[\u0027volume_id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"58df30ed_e9827e3f","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":12},"updated":"2022-09-23 10:00:14.000000000","message":"nit: we can remove this","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a896b8ecb0a9cefdca65693a3b00bd2ff533e59e","unresolved":true,"context_lines":[{"line_number":88,"context_line":"                                                \u0027available\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _delete_transfer(self, transfer, transfer_client, volumes_client):"},{"line_number":91,"context_line":"        _ \u003d transfer_client.delete_volume_transfer(transfer[\u0027id\u0027])"},{"line_number":92,"context_line":"        waiters.wait_for_volume_resource_status(volumes_client,"},{"line_number":93,"context_line":"                                                transfer[\u0027volume_id\u0027],"},{"line_number":94,"context_line":"                                                \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9b2409cc_9839c774","line":91,"range":{"start_line":91,"start_character":8,"end_line":91,"end_character":11},"updated":"2022-09-23 10:00:14.000000000","message":"nit: same","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a896b8ecb0a9cefdca65693a3b00bd2ff533e59e","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        # only because it\u0027s awkward in tempest to boot an instance and"},{"line_number":128,"context_line":"        # access it (to read the timestamp) in another project without"},{"line_number":129,"context_line":"        # setting up another security group and group rules."},{"line_number":130,"context_line":"        transfer \u003d self._create_transfer(volume,"},{"line_number":131,"context_line":"                                         self.alt_client,"},{"line_number":132,"context_line":"                                         self.alt_volumes_client)"},{"line_number":133,"context_line":"        self._accept_transfer(transfer, self.client, self.volumes_client)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # Create another instance from the volume and read the timestamp."}],"source_content_type":"text/x-python","patch_set":7,"id":"60f38944_2ef09dd8","line":132,"range":{"start_line":130,"start_character":8,"end_line":132,"end_character":65},"updated":"2022-09-23 10:00:14.000000000","message":"I think it would be good to assert that the project ID in the volume has changed from the original project id before doing this","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6ee77357a1b742aa7ca33fc964a3e67c60b0b05e","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual(timestamp_1, timestamp_2)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Verify the volume has a new encryption_key_id."},{"line_number":181,"context_line":"        encryption_key_id_1 \u003d volume[\u0027encryption_key_id\u0027]"},{"line_number":182,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":183,"context_line":"        encryption_key_id_2 \u003d volume[\u0027encryption_key_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"a75d1a16_7ca00102","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":56},"updated":"2022-08-30 18:27:06.000000000","message":"We should mention this in the transfer-delete section of the api-ref:\nhttps://docs.openstack.org/api-ref/block-storage/v3/?expanded\u003did382-detail#volume-transfers-volume-transfers-3-55-or-later\n\nThat way everyone will know that it\u0027s expected behavior.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a128495b8850dbc554314d076523306dd2725a9","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual(timestamp_1, timestamp_2)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Verify the volume has a new encryption_key_id."},{"line_number":181,"context_line":"        encryption_key_id_1 \u003d volume[\u0027encryption_key_id\u0027]"},{"line_number":182,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":183,"context_line":"        encryption_key_id_2 \u003d volume[\u0027encryption_key_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a88082d_f3541e81","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":56},"in_reply_to":"12f68329_a6095234","updated":"2022-09-21 14:20:45.000000000","message":"Yeah, I don\u0027t know.  Three weeks ago it seemed like a good idea, but I\u0027m not sure why anymore!","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b325c8a4f01118452838bbf157e611ac8f538561","unresolved":true,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.assertEqual(timestamp_1, timestamp_2)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # Verify the volume has a new encryption_key_id."},{"line_number":181,"context_line":"        encryption_key_id_1 \u003d volume[\u0027encryption_key_id\u0027]"},{"line_number":182,"context_line":"        volume \u003d self.volumes_client.show_volume(volume[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":183,"context_line":"        encryption_key_id_2 \u003d volume[\u0027encryption_key_id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"12f68329_a6095234","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":56},"in_reply_to":"a75d1a16_7ca00102","updated":"2022-08-30 19:22:08.000000000","message":"Hmm. Any action like this one can update many fields, and I don\u0027t think all of the updates are necessarily \"expected.\" Do we really want to draw attention to this field without mentioning any others? Bear in mind that until mv 3.64 the encryption_key_id wasn\u0027t even exposed in the volume details.","commit_id":"40104c78f8cfdd945f4cd68e4ff3de9718b29b1a"}]}