)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c41629371bd7104998eab493be70ecbdb90f519e","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: I9e6ea838fa7a93fcfc3d4ef7f807224aadee187b"},{"line_number":13,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"99f811d6_5b19e2bd","line":13,"updated":"2023-04-03 08:32:05.000000000","message":"this signed-off-by header is not needed here, but if you want to keep it, please make sure that the last line is the Change-Id: one. There is an extra line here.","commit_id":"8583c1e05059a70dd748816d6de9202fcef6c68f"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f423e13be5a4fc0bc354e36e5c12d30b433f29e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"},{"line_number":12,"context_line":"Change-Id: I9e6ea838fa7a93fcfc3d4ef7f807224aadee187b"},{"line_number":13,"context_line":"Signed-off-by: Yosi Ben Shimon \u003cybenshim@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"66a1f633_72fb22c8","line":13,"in_reply_to":"99f811d6_5b19e2bd","updated":"2023-05-03 05:58:31.000000000","message":"Ack","commit_id":"8583c1e05059a70dd748816d6de9202fcef6c68f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d2e2aa68686a669550c4ea61c54f885a516eea3d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ad11fc0_8eeb09bd","updated":"2023-04-23 10:53:20.000000000","message":"Commit message not clear.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"84198400616444798409bda44a8b9b71e7e1f8fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fb7fb8bd_59ad9b73","updated":"2023-04-23 09:50:51.000000000","message":"Created general naming tests without naming with srbac persona.If test fail it\u0027s not clear to that persona belongs failed test.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab0fee577b76f54ad40011d1ea7342d2aa5dd267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"854ba969_5331a984","updated":"2023-04-23 13:47:16.000000000","message":"Missing tests for : backup snapshot, backup in use volume, incremental backup.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"8550de13e0c3790fbef83c560e0d36de3abd6687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6356aa57_dc43ed3a","updated":"2023-04-23 10:23:02.000000000","message":"Please add skip_checks method as below:\n    @classmethod\n    def skip_checks(cls):\n        super(VolumesBackupsTest, cls).skip_checks()\n        if not CONF.volume_feature_enabled.backup:\n            raise cls.skipException(\"Cinder backup feature disabled\")","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3029aa2d1fd930b66765bfc5b7e82d47d5c62ce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a32b692f_4aa57209","in_reply_to":"3ad11fc0_8eeb09bd","updated":"2023-04-24 09:46:39.000000000","message":"Done","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"791ae3cae787e6744855ab3e744ab618e4b0bfc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"daa34913_dae0e16c","updated":"2023-04-24 12:46:56.000000000","message":"recheck","commit_id":"1bca7430c6ffbf483596563c666aace448e31bc6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"678fdd0ed2a14460ae592fe5d6806c9ee964685c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6fed6c6f_f1ad2193","in_reply_to":"daa34913_dae0e16c","updated":"2023-04-24 14:26:54.000000000","message":"This patch fails as test_capabilities uses the \"old\" inheritance.\nAdded this patch to fix it:\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/881383","commit_id":"1bca7430c6ffbf483596563c666aace448e31bc6"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5f5594a264ec6d33c81657954842ef91093d80f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aafe90bc_c8492959","updated":"2023-04-27 14:11:24.000000000","message":"So this patch needs to be rebased on top of https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/881383","commit_id":"b9b4ecb28a742ef70b8eab568cf0a25653f4ab90"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"38be95d5fb3349d5c0265f8bc5ddafe5e40b522e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"016e11e2_70997a1f","in_reply_to":"aafe90bc_c8492959","updated":"2023-05-03 05:55:33.000000000","message":"Fix conflicts and rebased on my local repo","commit_id":"b9b4ecb28a742ef70b8eab568cf0a25653f4ab90"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"33cb4f425e09ca0fc89b097091dfc441d49f5064","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"16299536_770c78f9","updated":"2023-05-03 07:26:54.000000000","message":"You need to rebase the patch","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"208fa4aa2a7c281662aec526ba7e4b932bb1a8b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"43aecd5d_486b13e4","updated":"2023-05-07 11:49:06.000000000","message":"Thanks Yosi! LGTM!\nPlease see a small comment.","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c0c832905d03c3a7f46fb04a33a61c57ab473ba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"1035ef0f_354991c7","updated":"2023-05-07 05:20:22.000000000","message":"recheck","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"805a72ec86b790168042db6bc76966a4c97ae645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7131c9a3_bfbee615","updated":"2023-05-04 12:48:04.000000000","message":"recheck","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"125fc0b74240d6a6522b684f14b07dcad0c77732","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e07903a6_ecae89aa","updated":"2023-05-04 08:53:20.000000000","message":"recheck","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"8dda4fa7a246a463246f02afd61d1ad3487078aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1ed78c52_b3fdf141","updated":"2023-05-08 05:37:44.000000000","message":"Missing Force delete a backup test","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"32293ae009c7284e1780bf7d45fab98fe1051bcc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"eb703a7c_45f1eed5","updated":"2023-05-08 05:39:25.000000000","message":"Missing Force delete a backup test","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6c06ea81_0b27688c","updated":"2023-05-08 06:01:03.000000000","message":"Missing test for system-reader and system-admin.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"fc29283c83f8c8a4acf554c8b1f9f44b280518e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"612aea7d_7b9f2632","updated":"2023-05-08 05:38:39.000000000","message":"Missing tests with backup attributes","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"624a47a9_54aa0be5","in_reply_to":"612aea7d_7b9f2632","updated":"2023-05-08 17:09:12.000000000","message":"I\u0027m not sure I understand what you mean","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"1cf19d06_39c37be0","in_reply_to":"6c06ea81_0b27688c","updated":"2023-05-08 17:09:12.000000000","message":"Not in this scope. We\u0027re testing the API only","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d48a2a5a321676d8d026f590b52996571bf2ae16","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5fe4c2e3_1584fab4","in_reply_to":"7e5b5b49_114b6724","updated":"2023-05-15 11:29:51.000000000","message":"Is good practice to keep naming test uniformity.From name of test I can\u0027t find to which scope is test belong.Ex. from cinder-snapshot srbac  \"ProjectReaderTests\" \u003e\u003e  \u003cScope-Name\u003e\u003cRole\u003eTests","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7e5b5b49_114b6724","in_reply_to":"eb703a7c_45f1eed5","updated":"2023-05-08 17:09:12.000000000","message":"It\u0027s out of the scope for this phase as it\u0027s not implemented in Tempest plugin.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"93db47e4f58268e21821caf20fd0a04e63be6335","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"33bab0b0_98a82a83","updated":"2023-05-09 09:46:44.000000000","message":"From log NetApp-ci the cinder-backup tests skipped.Why?","commit_id":"dfd30a69b8fcab990bd45adf3cf7975196b9ee7b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"7fe2e6080c648811666ead56789180decab6ac75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"969494ae_cff89597","updated":"2023-05-09 07:11:48.000000000","message":"Thanks LGTM!","commit_id":"dfd30a69b8fcab990bd45adf3cf7975196b9ee7b"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"f2bc518672be18da0158d398c690536d91f26fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"243c29f0_402de5f4","updated":"2023-05-08 19:47:06.000000000","message":"recheck","commit_id":"dfd30a69b8fcab990bd45adf3cf7975196b9ee7b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c0969853ae2357d3cb8daf146ad895404ceee329","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"84634834_625df1b3","in_reply_to":"33bab0b0_98a82a83","updated":"2023-05-09 13:10:33.000000000","message":"Because rbac is not enabled in this gate.\nrbac is enabled in \"cinder-tempest-plugin-protection-functional\" gate.","commit_id":"dfd30a69b8fcab990bd45adf3cf7975196b9ee7b"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"ebd21e7fe2525f260cdbab169b007136e4f8163e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"fa437000_6881c301","updated":"2023-05-15 08:47:56.000000000","message":"LGTM!","commit_id":"aaf2762ea154748d1720dcd04ca8b3dc781bb7a6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ebc7a94162d52b749a58e5b6bf3b5f336fe9fb8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"63c5dadc_f910f9b2","updated":"2023-05-16 11:27:39.000000000","message":"recheck","commit_id":"65af6aa4ba5850595be08510cb922d8433539a3a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"6eada2de04154438a2f97cba39904eb2dd4c9fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"68d51037_5d1892e6","updated":"2023-05-23 08:20:52.000000000","message":"LGTM!","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e4184dfcca12aa758d9da1f947228d4d48687741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5505cced_81b4355e","updated":"2023-05-23 10:00:03.000000000","message":"Please let me know which is going to be the base implementation and I\u0027ll review again!","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"dfd5230e5d62a4e8d6a081dfcf776a26f0d99ffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"de876226_34dcd494","updated":"2023-05-23 08:45:50.000000000","message":"So, this patch and https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/872986 have slightly different implementation of create_volume, and the same implementation of delete_resource. If this is merged, the other would conflict. Please either sync the two implementation, or (better and preferred) stack this patch on top of the other. But I guess you two need to discuss :)","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4f724d411ed5b8c51b81a6613c995b4bc50072d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"338379b4_19bc54c3","updated":"2023-05-22 13:24:43.000000000","message":"recheck","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"4f8d8e11c23e3f0243f3736362d399beebfa2a06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"25e516d3_82edcb08","in_reply_to":"5505cced_81b4355e","updated":"2023-05-23 11:22:03.000000000","message":"we will keep the create_backup here, and the create_volume and delete_resource in https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/872986/32/cinder_tempest_plugin/rbac/v3/base.py","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"b07b731cf39f23f5f0f38832630b26d02065cff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"08d4ba85_3b452da9","in_reply_to":"6bed08f5_ae9a096d","updated":"2023-05-30 13:21:52.000000000","message":"Done","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e4184dfcca12aa758d9da1f947228d4d48687741","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6bed08f5_ae9a096d","in_reply_to":"de876226_34dcd494","updated":"2023-05-23 10:00:03.000000000","message":"Please update 😊","commit_id":"d7fe5f2c66d5ab8f3b0ae5c0a8006517f4045f35"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"8fa2fe27fe53aa1b1e35fb38194e236c00d98b21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"bce92210_7159964e","updated":"2023-05-31 06:40:48.000000000","message":"recheck\n\nunrelated failure in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-lio-barbican","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5407092cc419ed7267e7b0fa09eddd95b51ffc62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"820f47b6_85e98748","updated":"2023-05-31 12:51:23.000000000","message":"two small nits, but let\u0027s wait for others","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"137b49f9501d0c5a2d271f3e968a438dd461f834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"ae4ccd26_a70ef62e","updated":"2023-05-31 14:19:31.000000000","message":"Looks like comments have been addressed. I\u0027ll review again after Zuul vote","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"30b06df96aa988e4b65e3d04cdf2447ff7b2a40a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"0f6b32b4_40b87e01","updated":"2023-05-31 17:15:38.000000000","message":"recheck\n\n3 tests failed on cinder-tempest-plugin-lvm-multiattach, unrelated to this change, probably an issue with the limited resources","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a7ae8d364093aaaf11ddd683ce83d901895a24d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"7925213e_d0b830d5","updated":"2023-05-31 22:18:14.000000000","message":"recheck\n\n3 unrelated test failures in cinder-tempest-plugin-lvm-multiattach and 4 unrelated test failures in cinder-tempest-plugin-lvm-lio-barbican","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"7f6a94c5dc0d11cede680a734994663827f720b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"920f29ce_bfc8deeb","updated":"2023-06-05 10:58:54.000000000","message":"recheck\n\nunrelated failures in cinder-tempest-plugin-lvm-lio-barbican","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"98d1b6ff5c53dce771f20282eb435361c857940d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"6849aa8b_b4010b79","updated":"2023-06-05 07:29:19.000000000","message":"recheck\n\nunrelated server side failures in cinder-tempest-plugin-lvm-multiattach","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3b8c1ea0a37ebd5d84b22134fea20a9b32c89654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"c08ad49f_6b8fe509","updated":"2023-06-11 06:57:39.000000000","message":"LGTM!","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"130bbed60d03023e4e48ba757735228de144c986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"32fef975_40378afe","updated":"2023-06-12 08:20:29.000000000","message":"Looks like all the comments have been addressed except for Eric\u0027s https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/878587/comment/a41f331e_a4849639/. I\u0027ll vote +2 after that one is closed.","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"19f3e4465dd21431209bc5430677e6ded76fd423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"093352f0_13bbf164","updated":"2023-06-21 03:34:06.000000000","message":"recheck","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5563736582e292b6ccadd36a7ff4606d5a354a4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"251f697b_b1e0efc9","updated":"2023-06-22 04:57:16.000000000","message":"recheck","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"87cd63088f94faa28c4a51957e18a202579dba21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"80a35db5_309f1b82","updated":"2023-06-22 08:21:00.000000000","message":"recheck","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4d0b7681c02ab287cf41b10a240eb481cf14199e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"d84167c1_78d8f200","updated":"2023-06-25 12:08:32.000000000","message":"recheck","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a3e3b267f8c26b819eb828a66e40f426e874c683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"cd6804fc_c068e59a","updated":"2023-07-03 11:24:51.000000000","message":"recheck\n\n\nunrelated failures in gate (everything passed in check and this was the first patch in the queue)\ncinder-tempest-plugin-lvm-nvmet-barbican https://zuul.opendev.org/t/openstack/build/a9f9462589fd40a389be629e09dd97e6 : FAILURE in 2h 14m 07s\ncinder-tempest-plugin-cbak-ceph https://zuul.opendev.org/t/openstack/build/dd9b6c09ccb74ee7bb9c08008f509df3 : FAILURE in 2h 14m 42s","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c236be490636b3afad363e27552c1f4dc84814fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"3d9bead1_36c70f0d","updated":"2023-07-03 14:50:09.000000000","message":"recheck\n\n\nunrelated timeout: cinder-tempest-plugin-lvm-nvmet-barbican https://zuul.opendev.org/t/openstack/build/5575088621984d558cfcd4555ec88b64 : TIMED_OUT in 3h 03m 27s","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"90cded7a13b8b03c71e74ab51cb98499b7f0bc83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"8564352a_7463d2cc","updated":"2023-07-04 11:38:03.000000000","message":"recheck\n\nFailure in cinder-tempest-plugin-lvm-lio-barbican","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"03ce02095afbab60b6de0bac57f0a85331ab2a1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"3ee4170b_741736c4","updated":"2023-06-26 08:03:20.000000000","message":"recheck\n\nThis time it was cinder-tempest-plugin-lvm-multiattach and cinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3a30137e440a9f2322536876a97adc612a6c32d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"bf458690_ef0210e9","updated":"2023-06-27 12:02:05.000000000","message":"recheck\n\nUnrelated error in cinder-tempest-plugin-lvm-multiattach","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"4211b93cf0809e3f1547fb2e155702ad68e52b97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"a649fb8b_f534deb5","updated":"2023-07-02 11:03:01.000000000","message":"recheck\n\nUnrelated failures in cinder-tempest-plugin-lvm-multiattach and cinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"34feeef921971236cf895bea77b1ca58fce693ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e1c3e5a1_d6cccf42","updated":"2023-07-03 05:41:22.000000000","message":"recheck\n\nUnrelated failures in cinder-tempest-plugin-lvm-nvmet-barbican and cinder-tempest-plugin-cbak-ceph","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"904a06c61de6b15be0326d2dfe37c938a37fc7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"7c9159b5_c9641873","updated":"2023-07-04 07:52:20.000000000","message":"recheck\n\nfailures because of timeouts","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cf8ccc88b80f23ade1f300342c9f5296f9ddc6c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"ca67b1ec_b9e5c2f0","updated":"2023-06-21 11:40:26.000000000","message":"recheck\n\nlvm job unrelated failure: cinder_tempest_plugin.scenario.test_volume_multiattach.VolumeMultiattachTests.test_multiattach_data_integrity","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"492da2914cfe78e09f8fc97e646f5af8db978e6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"4b1925f4_473b88ef","updated":"2023-06-23 10:56:58.000000000","message":"recheck\n\nthis is becoming annoying (see the previous messages)","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6d02dd7e49c83de606a434af50fbfe3bc44b75dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"88d7e0ee_20c7890c","updated":"2023-06-22 12:55:38.000000000","message":"recheck\n\nthis time everything passed but cinder-tempest-plugin-lvm-nvmet-barbican which terminated with a timeout","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2aa9ac972f8433bc999cf1e6ef608119807daeb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"cdb969cd_e108f24e","updated":"2023-06-23 08:16:50.000000000","message":"recheck\n\ntons of unrelated failures (cinder-tempest-plugin-lvm-multiattach cinder-tempest-plugin-lvm-nvmet-barbican cinder-tempest-plugin-cbak-ceph)","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"0d526bb8f6388a6ca32ca4d6163c0508f48da1c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"6eebe354_121104fa","updated":"2023-06-07 11:50:31.000000000","message":"recheck\n\nunrelated and inconsistent failure in a few tests of cinder-tempest-plugin-lvm-multiattach","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"11a28b20b657e321df38981092916fe8daffe954","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"6a54c581_2c138092","updated":"2023-06-20 18:49:19.000000000","message":"recheck\n\nunrelated failures in cinder-tempest-plugin-lvm-lio-barbican","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ae1ba266c065b306ed923373a94e0327040a31a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"3e099049_13b16399","updated":"2023-06-21 06:33:17.000000000","message":"recheck\n\nunrelated failures in:\ncinder-tempest-plugin-lvm-multiattach\ncinder-tempest-plugin-lvm-nvmet-barbican","commit_id":"bbb3cd612418ec5df17944b00f4e82c172aff821"}],"cinder_tempest_plugin/rbac/v3/base.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a7572db321f9f489b8a16f25842bc70c9f37545b","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        )"},{"line_number":137,"context_line":"        return backup"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def delete_volume(cls, volume_id, volumes_client):"},{"line_number":141,"context_line":"        volumes_client.delete_volume(volume_id)"},{"line_number":142,"context_line":"        volumes_client.wait_for_resource_deletion(volume_id)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @classmethod"},{"line_number":145,"context_line":"    def delete_backup(cls, backup_id, backups_client):"},{"line_number":146,"context_line":"        backups_client.delete_backup(backup_id)"},{"line_number":147,"context_line":"        backups_client.wait_for_resource_deletion(backup_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"192152d4_2e3c6191","line":147,"range":{"start_line":139,"start_character":0,"end_line":147,"end_character":60},"updated":"2023-05-03 12:20:35.000000000","message":"You can create one method that deletes the desired resource.","commit_id":"1a254f508c92feed0c7e22564f1ec73b3d68d8af"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"9a8865e7cd940ec35f943c0f022d6f5d7ee02327","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        )"},{"line_number":137,"context_line":"        return backup"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @classmethod"},{"line_number":140,"context_line":"    def delete_volume(cls, volume_id, volumes_client):"},{"line_number":141,"context_line":"        volumes_client.delete_volume(volume_id)"},{"line_number":142,"context_line":"        volumes_client.wait_for_resource_deletion(volume_id)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @classmethod"},{"line_number":145,"context_line":"    def delete_backup(cls, backup_id, backups_client):"},{"line_number":146,"context_line":"        backups_client.delete_backup(backup_id)"},{"line_number":147,"context_line":"        backups_client.wait_for_resource_deletion(backup_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"e2ecacb6_a8e0f179","line":147,"range":{"start_line":139,"start_character":0,"end_line":147,"end_character":60},"in_reply_to":"192152d4_2e3c6191","updated":"2023-05-03 13:08:09.000000000","message":"Done","commit_id":"1a254f508c92feed0c7e22564f1ec73b3d68d8af"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aaa49e0811acee2a0cd259275c86ae9aa335b210","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            kwargs[\u0027size\u0027] \u003d CONF.volume.volume_size"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if \u0027imageRef\u0027 in kwargs:"},{"line_number":88,"context_line":"            image \u003d cls.os_primary.image_client_v2.show_image("},{"line_number":89,"context_line":"                kwargs[\u0027imageRef\u0027]"},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":"            min_disk \u003d image[\u0027min_disk\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"a51dd0a9_490493c3","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":34},"updated":"2023-05-04 05:16:23.000000000","message":"You don\u0027t initialize this client and beyond that I also don\u0027t think it\u0027s necessary for the rbac tests. So I think you can remove this snippet.","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ce76663ff6720c493a26e17290aece22a250263b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            kwargs[\u0027size\u0027] \u003d CONF.volume.volume_size"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if \u0027imageRef\u0027 in kwargs:"},{"line_number":88,"context_line":"            image \u003d cls.os_primary.image_client_v2.show_image("},{"line_number":89,"context_line":"                kwargs[\u0027imageRef\u0027]"},{"line_number":90,"context_line":"            )"},{"line_number":91,"context_line":"            min_disk \u003d image[\u0027min_disk\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"b3badde0_2cdae4d4","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":34},"in_reply_to":"a51dd0a9_490493c3","updated":"2023-05-04 06:04:38.000000000","message":"Done","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aaa49e0811acee2a0cd259275c86ae9aa335b210","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            client\u003dvolume_client,"},{"line_number":106,"context_line":"            volume_id\u003dvolume[\u0027id\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        if wait_until:"},{"line_number":109,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":110,"context_line":"                volume_client, volume[\u0027id\u0027], wait_until"},{"line_number":111,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"9e60e12e_d84fe409","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":22},"updated":"2023-05-04 05:16:23.000000000","message":"Why do we need a condition here?","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ce76663ff6720c493a26e17290aece22a250263b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            client\u003dvolume_client,"},{"line_number":106,"context_line":"            volume_id\u003dvolume[\u0027id\u0027]"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        if wait_until:"},{"line_number":109,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":110,"context_line":"                volume_client, volume[\u0027id\u0027], wait_until"},{"line_number":111,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":18,"id":"a0c00386_9df559ca","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":22},"in_reply_to":"9e60e12e_d84fe409","updated":"2023-05-04 06:04:38.000000000","message":"Done","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aaa49e0811acee2a0cd259275c86ae9aa335b210","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            volume_id\u003dvolume_id, **kwargs"},{"line_number":127,"context_line":"        )[\u0027backup\u0027]"},{"line_number":128,"context_line":"        if add_cleanup:"},{"line_number":129,"context_line":"            cls.addClassResourceCleanup("},{"line_number":130,"context_line":"                backup_client.wait_for_resource_deletion, backup[\u0027id\u0027]"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"            cls.addClassResourceCleanup("},{"line_number":133,"context_line":"                test_utils.call_and_ignore_notfound_exc,"},{"line_number":134,"context_line":"                cls.delete_resource,"}],"source_content_type":"text/x-python","patch_set":18,"id":"22ae11a2_a3978476","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":13},"updated":"2023-05-04 05:16:23.000000000","message":"It\u0027s already been done in \"delete_resouse\" method.","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ce76663ff6720c493a26e17290aece22a250263b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            volume_id\u003dvolume_id, **kwargs"},{"line_number":127,"context_line":"        )[\u0027backup\u0027]"},{"line_number":128,"context_line":"        if add_cleanup:"},{"line_number":129,"context_line":"            cls.addClassResourceCleanup("},{"line_number":130,"context_line":"                backup_client.wait_for_resource_deletion, backup[\u0027id\u0027]"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"            cls.addClassResourceCleanup("},{"line_number":133,"context_line":"                test_utils.call_and_ignore_notfound_exc,"},{"line_number":134,"context_line":"                cls.delete_resource,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1602c42d_bbd9d560","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":13},"in_reply_to":"22ae11a2_a3978476","updated":"2023-05-04 06:04:38.000000000","message":"Done","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"208fa4aa2a7c281662aec526ba7e4b932bb1a8b9","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from tempest import config"},{"line_number":13,"context_line":"from tempest import test"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.common import waiters"},{"line_number":16,"context_line":"from tempest.lib.common import api_microversion_fixture"},{"line_number":17,"context_line":"from tempest.lib.common import api_version_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"680fe990_9de75be8","line":14,"updated":"2023-05-07 11:49:06.000000000","message":"Please remove the new line.\nYou will have to reorder the import lines.","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"0522fcb1be6f49e16c2b3d830cd38a9f66b43928","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from tempest import config"},{"line_number":13,"context_line":"from tempest import test"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.common import waiters"},{"line_number":16,"context_line":"from tempest.lib.common import api_microversion_fixture"},{"line_number":17,"context_line":"from tempest.lib.common import api_version_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"ce101615_d7b78ab4","line":14,"in_reply_to":"680fe990_9de75be8","updated":"2023-05-07 15:17:10.000000000","message":"Done","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5407092cc419ed7267e7b0fa09eddd95b51ffc62","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":27,"id":"49e37efa_746f33a3","line":1,"updated":"2023-05-31 12:51:23.000000000","message":"uhm, interesting enough the linter did not complain about this blank line, why keep it?","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"86ea7562630ae3169e97b75c7e52ca8558f522fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":27,"id":"d0102661_93e7034f","line":1,"in_reply_to":"49e37efa_746f33a3","updated":"2023-05-31 14:04:17.000000000","message":"Done","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"}],"cinder_tempest_plugin/rbac/v3/test_backups.py":[{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9596c5833694f162a3ebadfe8998e7f1f7802c89","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":89,"context_line":"    def test_list_backups(self):"},{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"881fb585_df0b3296","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":32},"updated":"2023-04-03 12:45:12.000000000","message":"You don\u0027t really validate that the backup is listed.","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9bec8f0fe1d81780bbb997892f2b45b99da35217","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":89,"context_line":"    def test_list_backups(self):"},{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d0ae739_c24420d4","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":32},"in_reply_to":"1cf4941b_ae5e3fa6","updated":"2023-04-04 04:27:31.000000000","message":"Right, but I think specific in list operation we should verified that the resource is really visible.","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f3ec8ab4a189b8f12eb4da2b7c7a78f89e5342ab","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":89,"context_line":"    def test_list_backups(self):"},{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ddd9c77c_68db2770","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":32},"in_reply_to":"7d0ae739_c24420d4","updated":"2023-04-04 04:50:20.000000000","message":"In case we test list operation while the resource was created in another project.\nThe reader has permissions to the list operation, however, the resource should not be visible.","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7d5b69c666b9bfee496ecae5ffdb0156fb1e9b81","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":89,"context_line":"    def test_list_backups(self):"},{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1cf4941b_ae5e3fa6","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":32},"in_reply_to":"881fb585_df0b3296","updated":"2023-04-03 13:05:08.000000000","message":"Isn\u0027t the test about being able to run the operation?","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2d159c8e52ff4e24f97aff63c7cdc3df2c2ea67e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":89,"context_line":"    def test_list_backups(self):"},{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"53add752_701e5631","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":32},"in_reply_to":"ddd9c77c_68db2770","updated":"2023-04-20 11:51:25.000000000","message":"Done","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9596c5833694f162a3ebadfe8998e7f1f7802c89","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":93,"context_line":"    def test_list_project_backups(self):"},{"line_number":94,"context_line":"        self.do_request("},{"line_number":95,"context_line":"            method\u003d\u0027list_backups\u0027,"},{"line_number":96,"context_line":"            expected_status\u003d200,"}],"source_content_type":"text/x-python","patch_set":3,"id":"15cb263a_4a5b8c32","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":33},"updated":"2023-04-03 12:45:12.000000000","message":"Same.","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2d159c8e52ff4e24f97aff63c7cdc3df2c2ea67e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.do_request(method\u003d\u0027list_backups\u0027, expected_status\u003d200)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @decorators.idempotent_id(\u00274a3722ec-c34e-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":93,"context_line":"    def test_list_project_backups(self):"},{"line_number":94,"context_line":"        self.do_request("},{"line_number":95,"context_line":"            method\u003d\u0027list_backups\u0027,"},{"line_number":96,"context_line":"            expected_status\u003d200,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7f0240e_3c0de36d","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":33},"in_reply_to":"15cb263a_4a5b8c32","updated":"2023-04-20 11:51:25.000000000","message":"Done","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9596c5833694f162a3ebadfe8998e7f1f7802c89","unresolved":true,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027c7546736-c366-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":142,"context_line":"    def test_import_backup(self):"},{"line_number":143,"context_line":"        export_backup \u003d ("},{"line_number":144,"context_line":"            self.admin_backups_client.export_backup("},{"line_number":145,"context_line":"                self.backup[\u0027id\u0027]"},{"line_number":146,"context_line":"            )[\u0027backup-record\u0027]"},{"line_number":147,"context_line":"        )"},{"line_number":148,"context_line":"        self.assertTrue("},{"line_number":149,"context_line":"            export_backup[\u0027backup_service\u0027].startswith(\u0027cinder.backup.drivers\u0027)"},{"line_number":150,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec7c381f_a00b46f5","line":147,"range":{"start_line":143,"start_character":0,"end_line":147,"end_character":9},"updated":"2023-04-03 12:45:12.000000000","message":"Please wait for the backup operation to finish.","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2d159c8e52ff4e24f97aff63c7cdc3df2c2ea67e","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @decorators.idempotent_id(\u0027c7546736-c366-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":142,"context_line":"    def test_import_backup(self):"},{"line_number":143,"context_line":"        export_backup \u003d ("},{"line_number":144,"context_line":"            self.admin_backups_client.export_backup("},{"line_number":145,"context_line":"                self.backup[\u0027id\u0027]"},{"line_number":146,"context_line":"            )[\u0027backup-record\u0027]"},{"line_number":147,"context_line":"        )"},{"line_number":148,"context_line":"        self.assertTrue("},{"line_number":149,"context_line":"            export_backup[\u0027backup_service\u0027].startswith(\u0027cinder.backup.drivers\u0027)"},{"line_number":150,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"8910bbf6_b1465785","line":147,"range":{"start_line":143,"start_character":0,"end_line":147,"end_character":9},"in_reply_to":"ec7c381f_a00b46f5","updated":"2023-04-20 11:51:25.000000000","message":"Done","commit_id":"9c324ef43e5a5bcbf636237f782db26ec7ff0b2a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0d24be59f7cc448e7b51e51ceb6c338162764acb","unresolved":true,"context_lines":[{"line_number":180,"context_line":"    def test_import_backup(self):"},{"line_number":181,"context_line":"        export_backup \u003d ("},{"line_number":182,"context_line":"            self.admin_backups_client.export_backup("},{"line_number":183,"context_line":"                self.backup[\u0027id\u0027]"},{"line_number":184,"context_line":"            )[\u0027backup-record\u0027]"},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5c8d5e_3a1282bb","line":183,"range":{"start_line":183,"start_character":16,"end_line":183,"end_character":33},"updated":"2023-04-17 13:51:29.000000000","message":"Please don\u0027t use the shared backup, but create a new one for this test to avoid race condition.","commit_id":"c4900cbdf3d3cf50d63f6c8d297eac2df1b5ae88"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"383cbbd3395108164bf2395e7e226140e006ce41","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    def test_import_backup(self):"},{"line_number":181,"context_line":"        export_backup \u003d ("},{"line_number":182,"context_line":"            self.admin_backups_client.export_backup("},{"line_number":183,"context_line":"                self.backup[\u0027id\u0027]"},{"line_number":184,"context_line":"            )[\u0027backup-record\u0027]"},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"8756d4de_aef50d3a","line":183,"range":{"start_line":183,"start_character":16,"end_line":183,"end_character":33},"in_reply_to":"5a935e6e_9ecb6a99","updated":"2023-04-24 09:45:20.000000000","message":"Done","commit_id":"c4900cbdf3d3cf50d63f6c8d297eac2df1b5ae88"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"2d159c8e52ff4e24f97aff63c7cdc3df2c2ea67e","unresolved":true,"context_lines":[{"line_number":180,"context_line":"    def test_import_backup(self):"},{"line_number":181,"context_line":"        export_backup \u003d ("},{"line_number":182,"context_line":"            self.admin_backups_client.export_backup("},{"line_number":183,"context_line":"                self.backup[\u0027id\u0027]"},{"line_number":184,"context_line":"            )[\u0027backup-record\u0027]"},{"line_number":185,"context_line":"        )"},{"line_number":186,"context_line":"        waiters.wait_for_volume_resource_status("}],"source_content_type":"text/x-python","patch_set":6,"id":"5a935e6e_9ecb6a99","line":183,"range":{"start_line":183,"start_character":16,"end_line":183,"end_character":33},"in_reply_to":"ba5c8d5e_3a1282bb","updated":"2023-04-20 11:51:25.000000000","message":"Done and added the same for a few other tests","commit_id":"c4900cbdf3d3cf50d63f6c8d297eac2df1b5ae88"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"d2e2aa68686a669550c4ea61c54f885a516eea3d","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8bb395c7_f344b78b","line":102,"range":{"start_line":102,"start_character":2,"end_line":102,"end_character":53},"updated":"2023-04-23 10:53:20.000000000","message":"What about?\n - system-reader\n - system-admin\n - (old \"owner\")\n - (old \"admin\")","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab0fee577b76f54ad40011d1ea7342d2aa5dd267","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"631c6a01_87b4c837","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"updated":"2023-04-23 13:47:16.000000000","message":"^^^^                                                                      Authorized readers,Unauthorized readers,Authorized members,Unauthorized members","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6a40048_a062dc7a","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"in_reply_to":"136d6feb_c8661c2d","updated":"2023-05-08 06:01:03.000000000","message":"What I mean here tests between Project A to Project B.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"5bec26f167c4125f219975b10bef39d0abc1b095","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ceb54694_418e60a5","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"in_reply_to":"4bdf9bdc_086e37b1","updated":"2023-06-19 08:40:21.000000000","message":"I can\u0027t find the patch.\nCould please attach url to patch?","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"72b7e5f09616a8777f0c2a030a9ece3ef8fad076","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"72eecae2_d4219257","line":102,"range":{"start_line":102,"start_character":2,"end_line":102,"end_character":53},"in_reply_to":"5fbd5fc5_0251edd3","updated":"2023-04-24 08:21:17.000000000","message":"The initial scope is about project reader and project admin.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"72b7e5f09616a8777f0c2a030a9ece3ef8fad076","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"136d6feb_c8661c2d","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"in_reply_to":"631c6a01_87b4c837","updated":"2023-04-24 08:21:17.000000000","message":"can you please explain? The project reader persona, for example, has a specific set of operation that they can perform.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3029aa2d1fd930b66765bfc5b7e82d47d5c62ce6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"556d46f7_1d87a9f0","line":102,"range":{"start_line":102,"start_character":2,"end_line":102,"end_character":53},"in_reply_to":"72eecae2_d4219257","updated":"2023-04-24 09:46:39.000000000","message":"Done","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab0fee577b76f54ad40011d1ea7342d2aa5dd267","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fbd5fc5_0251edd3","line":102,"range":{"start_line":102,"start_character":2,"end_line":102,"end_character":53},"in_reply_to":"8bb395c7_f344b78b","updated":"2023-04-23 13:47:16.000000000","message":"Do not refer to srbac personas in ( ). ^^^^","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e8caa16c951f4aa0af7ab66df7f7b041b3323e5b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"a84371ea_7308a03b","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"in_reply_to":"ceb54694_418e60a5","updated":"2023-06-19 09:08:13.000000000","message":"No patch has been uploaded yet. It\u0027s less critical in this phase.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"e7d3adf26f7215314bae0822c6b6641a4ad742cc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"class BackupReaderTests(RbacV3BackupsTests, base.BaseVolumeTest):"},{"line_number":100,"context_line":"    \"\"\"Test API with microversion greater than 3.3\"\"\""},{"line_number":101,"context_line":"    min_microversion \u003d \u00273.3\u0027"},{"line_number":102,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":105,"context_line":"    def test_list_backups(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"4bdf9bdc_086e37b1","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":2},"in_reply_to":"e6a40048_a062dc7a","updated":"2023-05-18 15:11:19.000000000","message":"of course, but will be done later in another patch, this one is to cover phase1 tests.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"ab0fee577b76f54ad40011d1ea7342d2aa5dd267","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u0027505a0bf2-c354-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":249,"context_line":"    @decorators.skip_because(bug\u003d\u00272017110\u0027)"},{"line_number":250,"context_line":"    def test_update_backup(self):"},{"line_number":251,"context_line":"        \"\"\"Update a backup\"\"\""},{"line_number":252,"context_line":"        update_kwargs \u003d {\"description\": \"Updated backup description\"}"},{"line_number":253,"context_line":"        self.do_request("}],"source_content_type":"text/x-python","patch_set":8,"id":"cef38ed6_6c824463","line":250,"range":{"start_line":250,"start_character":1,"end_line":250,"end_character":33},"updated":"2023-04-23 13:47:16.000000000","message":"Not clear why test_update_backup function here.Please add comment.","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"72b7e5f09616a8777f0c2a030a9ece3ef8fad076","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @decorators.idempotent_id(\u0027505a0bf2-c354-11ed-a7ea-84c5a6290b8f\u0027)"},{"line_number":249,"context_line":"    @decorators.skip_because(bug\u003d\u00272017110\u0027)"},{"line_number":250,"context_line":"    def test_update_backup(self):"},{"line_number":251,"context_line":"        \"\"\"Update a backup\"\"\""},{"line_number":252,"context_line":"        update_kwargs \u003d {\"description\": \"Updated backup description\"}"},{"line_number":253,"context_line":"        self.do_request("}],"source_content_type":"text/x-python","patch_set":8,"id":"34d71b1d_581a3a96","line":250,"range":{"start_line":250,"start_character":1,"end_line":250,"end_character":33},"in_reply_to":"cef38ed6_6c824463","updated":"2023-04-24 08:21:17.000000000","message":"IIf this is unclear, then all the other comments of this class are unclear. \n\nIt has the same name of the same test which set https://opendev.org/openstack/tempest/src/branch/master/tempest/api/volume/test_volumes_backup.py#L177","commit_id":"4c53de7bdcb19cf53032dd2d6da4bade1625e18c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"08ee52ea98e56e0ffa34b337e8e64eecadde1a80","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"},{"line_number":39,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_credentials(cls):"},{"line_number":43,"context_line":"        super().setup_credentials()"},{"line_number":44,"context_line":"        cls.os_primary \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"66af5e4a_e8d47b81","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":67},"updated":"2023-04-24 09:17:29.000000000","message":"You don\u0027t need it.","commit_id":"775aad077d43f67ae3a31c51dacdb1f11d8f8a7e"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"383cbbd3395108164bf2395e7e226140e006ce41","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"},{"line_number":39,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"},{"line_number":42,"context_line":"    def setup_credentials(cls):"},{"line_number":43,"context_line":"        super().setup_credentials()"},{"line_number":44,"context_line":"        cls.os_primary \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"0fcf4de0_842358cb","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":67},"in_reply_to":"66af5e4a_e8d47b81","updated":"2023-04-24 09:45:20.000000000","message":"Done","commit_id":"775aad077d43f67ae3a31c51dacdb1f11d8f8a7e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"08ee52ea98e56e0ffa34b337e8e64eecadde1a80","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        backups \u003d self.do_request("},{"line_number":111,"context_line":"            method\u003d\u0027list_backups\u0027, expected_status\u003dexpected_status"},{"line_number":112,"context_line":"        )[\u0027backups\u0027]"},{"line_number":113,"context_line":"        backup_list \u003d list("},{"line_number":114,"context_line":"            filter(lambda x: x[\u0027name\u0027] \u003d\u003d self.backup_name, backups)"},{"line_number":115,"context_line":"        )"},{"line_number":116,"context_line":"        self.assertNotEmpty("},{"line_number":117,"context_line":"            backup_list, f\"Backup {self.backup_name} not found\""},{"line_number":118,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"341a8092_395b42ea","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":9},"updated":"2023-04-24 09:17:29.000000000","message":"You don\u0027t really need the whole object, so you can simply use list comprehension:\nbackup_list \u003d [\n    b[\u0027id\u0027] for b in backups\n]","commit_id":"775aad077d43f67ae3a31c51dacdb1f11d8f8a7e"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"383cbbd3395108164bf2395e7e226140e006ce41","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        backups \u003d self.do_request("},{"line_number":111,"context_line":"            method\u003d\u0027list_backups\u0027, expected_status\u003dexpected_status"},{"line_number":112,"context_line":"        )[\u0027backups\u0027]"},{"line_number":113,"context_line":"        backup_list \u003d list("},{"line_number":114,"context_line":"            filter(lambda x: x[\u0027name\u0027] \u003d\u003d self.backup_name, backups)"},{"line_number":115,"context_line":"        )"},{"line_number":116,"context_line":"        self.assertNotEmpty("},{"line_number":117,"context_line":"            backup_list, f\"Backup {self.backup_name} not found\""},{"line_number":118,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"87394731_c74230e1","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":9},"in_reply_to":"341a8092_395b42ea","updated":"2023-04-24 09:45:20.000000000","message":"Done","commit_id":"775aad077d43f67ae3a31c51dacdb1f11d8f8a7e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"33cb4f425e09ca0fc89b097091dfc441d49f5064","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from tempest.lib import decorators"},{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest.config import CONF"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder_tempest_plugin.rbac.v3 import base as rbac_base"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"608cb230_bbf4971b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":31},"updated":"2023-05-03 07:26:54.000000000","message":"I know this is very minor but please keep it consistent like other places:\nfrom tempest import config\n\nCONF \u003d config.CONF","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c725aac852ae8d3d44c3cceef591f339bc1f32a0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from tempest.lib import decorators"},{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest.config import CONF"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder_tempest_plugin.rbac.v3 import base as rbac_base"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"96a4a822_0d9c03aa","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":31},"in_reply_to":"608cb230_bbf4971b","updated":"2023-05-03 09:18:23.000000000","message":"Done","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"33cb4f425e09ca0fc89b097091dfc441d49f5064","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"},{"line_number":39,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # @classmethod"},{"line_number":42,"context_line":"    # def setup_credentials(cls):"},{"line_number":43,"context_line":"    #     super().setup_credentials()"},{"line_number":44,"context_line":"    #     cls.os_primary \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"c7053502_8ee2f23f","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":69},"updated":"2023-05-03 07:26:54.000000000","message":"Please remove it.","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c725aac852ae8d3d44c3cceef591f339bc1f32a0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"},{"line_number":39,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # @classmethod"},{"line_number":42,"context_line":"    # def setup_credentials(cls):"},{"line_number":43,"context_line":"    #     super().setup_credentials()"},{"line_number":44,"context_line":"    #     cls.os_primary \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def resource_setup(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"019fbd78_0caa8b47","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":69},"in_reply_to":"c7053502_8ee2f23f","updated":"2023-05-03 09:18:23.000000000","message":"Done","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d4ec4c8b95d1c1f7c47578adca8d3d06f416fbed","unresolved":true,"context_lines":[{"line_number":267,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":268,"context_line":"                backup_id\u003dbackup[\u0027id\u0027]"},{"line_number":269,"context_line":"            )[\u0027backup\u0027]"},{"line_number":270,"context_line":"            assert backup[\u0027status\u0027] \u003d\u003d new_status, ("},{"line_number":271,"context_line":"                f\"Backup {backup[\u0027name\u0027]} status should be {new_status}\""},{"line_number":272,"context_line":"            )"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # Cleanup backup and volume"}],"source_content_type":"text/x-python","patch_set":14,"id":"c43ebf19_9cf76d16","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":72},"updated":"2023-05-03 08:18:37.000000000","message":"Please use self.assertEqual","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c725aac852ae8d3d44c3cceef591f339bc1f32a0","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":268,"context_line":"                backup_id\u003dbackup[\u0027id\u0027]"},{"line_number":269,"context_line":"            )[\u0027backup\u0027]"},{"line_number":270,"context_line":"            assert backup[\u0027status\u0027] \u003d\u003d new_status, ("},{"line_number":271,"context_line":"                f\"Backup {backup[\u0027name\u0027]} status should be {new_status}\""},{"line_number":272,"context_line":"            )"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # Cleanup backup and volume"}],"source_content_type":"text/x-python","patch_set":14,"id":"21ab1eb3_aebb3cfd","line":271,"range":{"start_line":270,"start_character":0,"end_line":271,"end_character":72},"in_reply_to":"c43ebf19_9cf76d16","updated":"2023-05-03 09:18:23.000000000","message":"Done","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d4ec4c8b95d1c1f7c47578adca8d3d06f416fbed","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":448,"context_line":"                backup_id\u003dself.backup_id"},{"line_number":449,"context_line":"            )[\u0027backup\u0027]"},{"line_number":450,"context_line":"            assert backup[\u0027description\u0027] \u003d\u003d new_description, ("},{"line_number":451,"context_line":"                f\"Backup {backup[\u0027name\u0027]} description should be \""},{"line_number":452,"context_line":"                f\"{new_description}\""},{"line_number":453,"context_line":"            )"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9b115b71_f4ddec2b","line":452,"range":{"start_line":450,"start_character":0,"end_line":452,"end_character":36},"updated":"2023-05-03 08:18:37.000000000","message":"Please use self.assertEqual","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c725aac852ae8d3d44c3cceef591f339bc1f32a0","unresolved":false,"context_lines":[{"line_number":447,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":448,"context_line":"                backup_id\u003dself.backup_id"},{"line_number":449,"context_line":"            )[\u0027backup\u0027]"},{"line_number":450,"context_line":"            assert backup[\u0027description\u0027] \u003d\u003d new_description, ("},{"line_number":451,"context_line":"                f\"Backup {backup[\u0027name\u0027]} description should be \""},{"line_number":452,"context_line":"                f\"{new_description}\""},{"line_number":453,"context_line":"            )"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1537479d_2a98ef3b","line":452,"range":{"start_line":450,"start_character":0,"end_line":452,"end_character":36},"in_reply_to":"9b115b71_f4ddec2b","updated":"2023-05-03 09:18:23.000000000","message":"Done","commit_id":"8e6765c12b61c955237d1e56a0dabeaf0183afb3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a7572db321f9f489b8a16f25842bc70c9f37545b","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":222,"context_line":"            status\u003dnew_status"},{"line_number":223,"context_line":"        )"},{"line_number":224,"context_line":"        if res \u003d\u003d {}:"},{"line_number":225,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":226,"context_line":"                backup_id\u003dbackup[\u0027id\u0027]"},{"line_number":227,"context_line":"            )[\u0027backup\u0027]"},{"line_number":228,"context_line":"            self.assertEqual("},{"line_number":229,"context_line":"                backup[\u0027status\u0027], new_status,"},{"line_number":230,"context_line":"                f\"Backup {backup[\u0027name\u0027]} status should be {new_status}\""},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class BackupReaderTests33(RbacV3BackupsTests33):"}],"source_content_type":"text/x-python","patch_set":16,"id":"cfd1cf09_6a01d24b","line":231,"range":{"start_line":224,"start_character":0,"end_line":231,"end_character":13},"updated":"2023-05-03 12:20:35.000000000","message":"No need to check if the status has changed.","commit_id":"1a254f508c92feed0c7e22564f1ec73b3d68d8af"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"9a8865e7cd940ec35f943c0f022d6f5d7ee02327","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":222,"context_line":"            status\u003dnew_status"},{"line_number":223,"context_line":"        )"},{"line_number":224,"context_line":"        if res \u003d\u003d {}:"},{"line_number":225,"context_line":"            backup \u003d self.admin_backups_client.show_backup("},{"line_number":226,"context_line":"                backup_id\u003dbackup[\u0027id\u0027]"},{"line_number":227,"context_line":"            )[\u0027backup\u0027]"},{"line_number":228,"context_line":"            self.assertEqual("},{"line_number":229,"context_line":"                backup[\u0027status\u0027], new_status,"},{"line_number":230,"context_line":"                f\"Backup {backup[\u0027name\u0027]} status should be {new_status}\""},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class BackupReaderTests33(RbacV3BackupsTests33):"}],"source_content_type":"text/x-python","patch_set":16,"id":"0aaf9c48_70001314","line":231,"range":{"start_line":224,"start_character":0,"end_line":231,"end_character":13},"in_reply_to":"cfd1cf09_6a01d24b","updated":"2023-05-03 13:08:09.000000000","message":"Done","commit_id":"1a254f508c92feed0c7e22564f1ec73b3d68d8af"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aaa49e0811acee2a0cd259275c86ae9aa335b210","unresolved":true,"context_lines":[{"line_number":161,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":162,"context_line":"            backup_id\u003dself.backup_id"},{"line_number":163,"context_line":"        )"},{"line_number":164,"context_line":"        if expected_status !\u003d exceptions.Forbidden:"},{"line_number":165,"context_line":"            self.assertNotEmpty("},{"line_number":166,"context_line":"                res, f\"Failed to export backup {self.backup_name}\""},{"line_number":167,"context_line":"            )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def _import_backup(self, expected_status):"},{"line_number":170,"context_line":"        \"\"\"Import a backup\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"275bac3e_e73c811f","line":167,"range":{"start_line":164,"start_character":0,"end_line":167,"end_character":13},"updated":"2023-05-04 05:16:23.000000000","message":"Why is this necessary?\n\"do_request\" suppose to raise the exception.","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"ce76663ff6720c493a26e17290aece22a250263b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":162,"context_line":"            backup_id\u003dself.backup_id"},{"line_number":163,"context_line":"        )"},{"line_number":164,"context_line":"        if expected_status !\u003d exceptions.Forbidden:"},{"line_number":165,"context_line":"            self.assertNotEmpty("},{"line_number":166,"context_line":"                res, f\"Failed to export backup {self.backup_name}\""},{"line_number":167,"context_line":"            )"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def _import_backup(self, expected_status):"},{"line_number":170,"context_line":"        \"\"\"Import a backup\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"f6c7c6be_23088f5b","line":167,"range":{"start_line":164,"start_character":0,"end_line":167,"end_character":13},"in_reply_to":"275bac3e_e73c811f","updated":"2023-05-04 06:04:38.000000000","message":"Done","commit_id":"0e04f3923fab87d6d80d0eb4c6373a869c168c3c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"208fa4aa2a7c281662aec526ba7e4b932bb1a8b9","unresolved":true,"context_lines":[{"line_number":14,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":20,"id":"c665932b_77700f57","line":17,"updated":"2023-05-07 11:49:06.000000000","message":"Same","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"0522fcb1be6f49e16c2b3d830cd38a9f66b43928","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest import config"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":20,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":20,"id":"f87abb15_dd6e7447","line":17,"in_reply_to":"c665932b_77700f57","updated":"2023-05-07 15:17:10.000000000","message":"Done","commit_id":"3f774d32e912dd620e53e4e4b3f34f74bf3dc2b8"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            backup_id\u003dself.backup_id"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _import_backup(self, expected_status):"},{"line_number":167,"context_line":"        \"\"\"Import a backup\"\"\""},{"line_number":168,"context_line":"        volume \u003d self.create_volume(volume_client\u003dself.admin_volumes_client)"},{"line_number":169,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":21,"id":"dd9f558f_d16514eb","line":166,"range":{"start_line":166,"start_character":2,"end_line":166,"end_character":46},"updated":"2023-05-08 06:01:03.000000000","message":"You can combine export and imports in one test","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            backup_id\u003dself.backup_id"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _import_backup(self, expected_status):"},{"line_number":167,"context_line":"        \"\"\"Import a backup\"\"\""},{"line_number":168,"context_line":"        volume \u003d self.create_volume(volume_client\u003dself.admin_volumes_client)"},{"line_number":169,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":21,"id":"24451de2_356b7b7c","line":166,"range":{"start_line":166,"start_character":2,"end_line":166,"end_character":46},"in_reply_to":"8142d9f2_8071cac5","updated":"2023-05-08 17:09:12.000000000","message":"Ack","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ff1403a83220ffa82b122d081daa64db81ca2e90","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            backup_id\u003dself.backup_id"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _import_backup(self, expected_status):"},{"line_number":167,"context_line":"        \"\"\"Import a backup\"\"\""},{"line_number":168,"context_line":"        volume \u003d self.create_volume(volume_client\u003dself.admin_volumes_client)"},{"line_number":169,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":21,"id":"8142d9f2_8071cac5","line":166,"range":{"start_line":166,"start_character":2,"end_line":166,"end_character":46},"in_reply_to":"dd9f558f_d16514eb","updated":"2023-05-08 08:07:23.000000000","message":"not necessarily, because the export operation may fail for a specific persona and we want to see that result separately. In this import operation the code makes sure that the export works and focuses on the import.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        self.assertTrue("},{"line_number":183,"context_line":"            export_backup[\u0027backup_service\u0027].startswith(\u0027cinder.backup.drivers\u0027)"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        new_id \u003d data_utils.rand_uuid()"},{"line_number":186,"context_line":"        new_url \u003d self._modify_backup_url("},{"line_number":187,"context_line":"            export_backup[\u0027backup_url\u0027], {\u0027id\u0027: new_id})"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        res \u003d self.do_request("},{"line_number":190,"context_line":"            method\u003d\u0027import_backup\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"40b22d53_0280e20c","line":187,"range":{"start_line":185,"start_character":8,"end_line":187,"end_character":56},"updated":"2023-05-08 06:01:03.000000000","message":"Add comment why you fake here id.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertTrue("},{"line_number":183,"context_line":"            export_backup[\u0027backup_service\u0027].startswith(\u0027cinder.backup.drivers\u0027)"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        new_id \u003d data_utils.rand_uuid()"},{"line_number":186,"context_line":"        new_url \u003d self._modify_backup_url("},{"line_number":187,"context_line":"            export_backup[\u0027backup_url\u0027], {\u0027id\u0027: new_id})"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        res \u003d self.do_request("},{"line_number":190,"context_line":"            method\u003d\u0027import_backup\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"b1b4f552_d6a54713","line":187,"range":{"start_line":185,"start_character":8,"end_line":187,"end_character":56},"in_reply_to":"40b22d53_0280e20c","updated":"2023-05-08 17:09:12.000000000","message":"Done","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        )"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class BackupReaderTests33(RbacV3BackupsTests33):"},{"line_number":223,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"9855ccea_6083fbfe","line":222,"updated":"2023-05-08 06:01:03.000000000","message":"Not clear why you add number to name of class.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        )"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class BackupReaderTests33(RbacV3BackupsTests33):"},{"line_number":223,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"b50b3a35_e70e35aa","line":222,"in_reply_to":"701540a8_c256bed0","updated":"2023-05-08 17:09:12.000000000","message":"Ack","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ff1403a83220ffa82b122d081daa64db81ca2e90","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        )"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"class BackupReaderTests33(RbacV3BackupsTests33):"},{"line_number":223,"context_line":"    credentials \u003d [\u0027project_reader\u0027, \u0027project_admin\u0027]"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @decorators.idempotent_id(\u00275287f280-c328-11ed-a7ea-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"701540a8_c256bed0","line":222,"in_reply_to":"9855ccea_6083fbfe","updated":"2023-05-08 08:07:23.000000000","message":"Those are microversions. As you can see the class RbacV3BackupsTests33 defines \n\nmin_microversion \u003d \u00273.3\u0027\n\n(which in tempest.git would be volume_min_microversion).\n\nThis is a common pattern to test the same API with different microversions.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"9c68cd515f02e937de21aec88b4e0af49f46e7e0","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        self._reset_backup_status(expected_status\u003dexceptions.Forbidden)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class BackupMemberTests33(RbacV3BackupsTests33):"},{"line_number":275,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @decorators.idempotent_id(\u0027ba25a750-e1c0-11ed-a078-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"a66304b9_9fd14d60","line":274,"updated":"2023-05-08 06:01:03.000000000","message":"Not clear why you add number to name of class.","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ff1403a83220ffa82b122d081daa64db81ca2e90","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        self._reset_backup_status(expected_status\u003dexceptions.Forbidden)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class BackupMemberTests33(RbacV3BackupsTests33):"},{"line_number":275,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @decorators.idempotent_id(\u0027ba25a750-e1c0-11ed-a078-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"efc45157_59bee509","line":274,"in_reply_to":"a66304b9_9fd14d60","updated":"2023-05-08 08:07:23.000000000","message":"see above","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"15f88f399cf5d918cd6b7d478ad5e92df1f8c1ff","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        self._reset_backup_status(expected_status\u003dexceptions.Forbidden)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"class BackupMemberTests33(RbacV3BackupsTests33):"},{"line_number":275,"context_line":"    credentials \u003d [\u0027project_member\u0027, \u0027project_admin\u0027]"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    @decorators.idempotent_id(\u0027ba25a750-e1c0-11ed-a078-84c5a6290b8f\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"9421f480_33108a36","line":274,"in_reply_to":"efc45157_59bee509","updated":"2023-05-08 17:09:12.000000000","message":"Ack","commit_id":"f946dc58fbb9d9277ff2bdd5867ebf7f2943dd1c"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"12dc8d540d473790a4e2dd4c63c3d42eac494cb4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(self):"},{"line_number":46,"context_line":"        super(RbacV3BackupsTests, self).resource_setup()"},{"line_number":47,"context_line":"        volume \u003d self.create_volume(volume_client\u003dself.admin_volumes_client)"},{"line_number":48,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":23,"id":"4fc65fa5_58dad642","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":27},"updated":"2023-05-16 05:07:53.000000000","message":"cls","commit_id":"aaf2762ea154748d1720dcd04ca8b3dc781bb7a6"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"3db834384a4ee5cad99ef011c906103caf0f4fa5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        cls.admin_volumes_client \u003d admin_client.volumes_client_latest"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @classmethod"},{"line_number":45,"context_line":"    def resource_setup(self):"},{"line_number":46,"context_line":"        super(RbacV3BackupsTests, self).resource_setup()"},{"line_number":47,"context_line":"        volume \u003d self.create_volume(volume_client\u003dself.admin_volumes_client)"},{"line_number":48,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":23,"id":"2019716a_69c41db2","line":45,"range":{"start_line":45,"start_character":23,"end_line":45,"end_character":27},"in_reply_to":"4fc65fa5_58dad642","updated":"2023-05-16 08:52:22.000000000","message":"Done","commit_id":"aaf2762ea154748d1720dcd04ca8b3dc781bb7a6"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"e7d3adf26f7215314bae0822c6b6641a4ad742cc","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"},{"line_number":36,"context_line":"        super().setup_clients()"},{"line_number":37,"context_line":"        cls.persona \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":38,"context_line":"        cls.client \u003d cls.persona.backups_client_latest"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        admin_client \u003d cls.os_project_admin"},{"line_number":41,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"}],"source_content_type":"text/x-python","patch_set":24,"id":"cb370a0a_128f6b9f","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":54},"updated":"2023-05-18 15:11:19.000000000","message":"please setup the clients per role class as was suggested by gmann:\ndef setup_clients(cls):\nsuper().setup_clients()\n----\u003e cls.client \u003d cls.os_project_\u003crole\u003e.backups_client_latest","commit_id":"65af6aa4ba5850595be08510cb922d8433539a3a"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"c159dd4d8b65bc11662028d4e6ac802d27984a25","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @classmethod"},{"line_number":35,"context_line":"    def setup_clients(cls):"},{"line_number":36,"context_line":"        super().setup_clients()"},{"line_number":37,"context_line":"        cls.persona \u003d getattr(cls, \u0027os_%s\u0027 % cls.credentials[0])"},{"line_number":38,"context_line":"        cls.client \u003d cls.persona.backups_client_latest"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        admin_client \u003d cls.os_project_admin"},{"line_number":41,"context_line":"        cls.admin_backups_client \u003d admin_client.backups_client_latest"}],"source_content_type":"text/x-python","patch_set":24,"id":"1eebe3fd_548751f3","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":54},"in_reply_to":"cb370a0a_128f6b9f","updated":"2023-05-22 06:42:15.000000000","message":"Done","commit_id":"65af6aa4ba5850595be08510cb922d8433539a3a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5407092cc419ed7267e7b0fa09eddd95b51ffc62","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _delete_backup(self, expected_status):"},{"line_number":106,"context_line":"        \"\"\"Delete a backup\"\"\""},{"line_number":107,"context_line":"        add_cleanup \u003d True if expected_status \u003d\u003d exceptions.Forbidden\\"},{"line_number":108,"context_line":"            else False"},{"line_number":109,"context_line":"        volume_id \u003d self.create_volume(client\u003dself.admin_volumes_client)"},{"line_number":110,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":27,"id":"a5e15aae_391d1bc4","line":107,"updated":"2023-05-31 12:51:23.000000000","message":"why not just \nadd_cleanup \u003d  expected_status \u003d\u003d exceptions.Forbidden\n\n?","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"86ea7562630ae3169e97b75c7e52ca8558f522fb","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _delete_backup(self, expected_status):"},{"line_number":106,"context_line":"        \"\"\"Delete a backup\"\"\""},{"line_number":107,"context_line":"        add_cleanup \u003d True if expected_status \u003d\u003d exceptions.Forbidden\\"},{"line_number":108,"context_line":"            else False"},{"line_number":109,"context_line":"        volume_id \u003d self.create_volume(client\u003dself.admin_volumes_client)"},{"line_number":110,"context_line":"        backup \u003d self.create_backup("}],"source_content_type":"text/x-python","patch_set":27,"id":"9a216b98_d688613f","line":107,"in_reply_to":"a5e15aae_391d1bc4","updated":"2023-05-31 14:04:17.000000000","message":"Done","commit_id":"b91e0c24deb69f42bb192f837e1f8dfe49357702"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"931ed97ce8f808d0521b03b8f01e51b0ba21a1bf","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":126,"context_line":"            backup_id\u003dself.backup_id,"},{"line_number":127,"context_line":"            name\u003d\u0027new-backup-vol\u0027"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        if res:"},{"line_number":130,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":131,"context_line":"                self.admin_backups_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"a41f331e_a4849639","line":128,"updated":"2023-06-05 15:49:08.000000000","message":"Doesn\u0027t there need to be a test for when \"res\" is None here, that raises an assertion?\n\nWhat happens if the server returns an empty but successful response?","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7c0c594dd428e099d131eb49d42237aa46c8de10","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":126,"context_line":"            backup_id\u003dself.backup_id,"},{"line_number":127,"context_line":"            name\u003d\u0027new-backup-vol\u0027"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        if res:"},{"line_number":130,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":131,"context_line":"                self.admin_backups_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"a7aaf7b6_b1b8822a","line":128,"in_reply_to":"7b0c275f_fa956eae","updated":"2023-06-05 16:31:26.000000000","message":"\u003e if restore backup succeeded, it should return something (backup_id, volume_id, volume_name...)\n\nIt should, but the test code shouldn\u0027t assume that it will.  Maybe the Cinder service returned success but didn\u0027t include the expected fields in the response.","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35621,"name":"Evelina Shames","display_name":"Evelina Shames","email":"ESHAMES@REDHAT.COM","username":"eshames"},"change_message_id":"b21d60ead5c59caecacf6a5cc9643550dbe1fe81","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":126,"context_line":"            backup_id\u003dself.backup_id,"},{"line_number":127,"context_line":"            name\u003d\u0027new-backup-vol\u0027"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        if res:"},{"line_number":130,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":131,"context_line":"                self.admin_backups_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"7b0c275f_fa956eae","line":128,"in_reply_to":"a41f331e_a4849639","updated":"2023-06-05 15:58:05.000000000","message":"if restore backup succeeded, it should return something (backup_id, volume_id, volume_name...)\nin such a case, from srbac pov, it means that this operation is permitted for this persona, and the resource was created successfully and we need to delete it. \n\nif operation wasn\u0027t successful, the resource wasn\u0027t created and there is nothing to delete - in such a case that means that operation is forbidden for this persona.\n\nin which case the operation can succeed but will return an empty response?","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"cff7b7cc55e310a39c9ff47e60e98c0e18ea0317","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            expected_status\u003dexpected_status,"},{"line_number":126,"context_line":"            backup_id\u003dself.backup_id,"},{"line_number":127,"context_line":"            name\u003d\u0027new-backup-vol\u0027"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        if res:"},{"line_number":130,"context_line":"            waiters.wait_for_volume_resource_status("},{"line_number":131,"context_line":"                self.admin_backups_client,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3d809d24_53e578b8","line":128,"in_reply_to":"a7aaf7b6_b1b8822a","updated":"2023-06-13 08:11:31.000000000","message":"Response fields/structure validation is out of this scope.\nWe test permissions here, not functional operations.\nNone of the tests includes response validation.","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"35a9cf977e63bac69849fdf204defa00edfb658d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                self.admin_backups_client,"},{"line_number":132,"context_line":"                self.backup_id, \u0027available\u0027"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":"            self.delete_resource("},{"line_number":135,"context_line":"                client\u003dself.admin_volumes_client,"},{"line_number":136,"context_line":"                volume_id\u003dres[\u0027restore\u0027][\u0027volume_id\u0027]"},{"line_number":137,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"ea4e7951_1f6790c7","line":134,"updated":"2023-06-05 16:40:04.000000000","message":"Does this mean that the volume isn\u0027t deleted if the backup restore fails, and it is left behind after the tempest run?","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"a8d4d06d50d2baff166d87f994af86e5a939ce3d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                self.admin_backups_client,"},{"line_number":132,"context_line":"                self.backup_id, \u0027available\u0027"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":"            self.delete_resource("},{"line_number":135,"context_line":"                client\u003dself.admin_volumes_client,"},{"line_number":136,"context_line":"                volume_id\u003dres[\u0027restore\u0027][\u0027volume_id\u0027]"},{"line_number":137,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"643cb297_d48ce403","line":134,"in_reply_to":"8997d787_e4c4b13c","updated":"2023-06-07 08:38:12.000000000","message":"Sorry for that.\nWhat I\u0027ve meant is that if the restore shouldn\u0027t succeed (using reader role in this case), then there will be no volume to delete.\nI changed all similar places to:\nif expected_status !\u003d exceptions.Forbidden:","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ea58aae066d3596fb75b6c1fc6ce6be20a215add","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                self.admin_backups_client,"},{"line_number":132,"context_line":"                self.backup_id, \u0027available\u0027"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":"            self.delete_resource("},{"line_number":135,"context_line":"                client\u003dself.admin_volumes_client,"},{"line_number":136,"context_line":"                volume_id\u003dres[\u0027restore\u0027][\u0027volume_id\u0027]"},{"line_number":137,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"8997d787_e4c4b13c","line":134,"in_reply_to":"8e790e23_fd3e862c","updated":"2023-06-06 13:29:25.000000000","message":"Doesn\u0027t the test need to fail in that situation?","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"7b48f21dfb70565feeaa5813e4b4b5902227b59d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                self.admin_backups_client,"},{"line_number":132,"context_line":"                self.backup_id, \u0027available\u0027"},{"line_number":133,"context_line":"            )"},{"line_number":134,"context_line":"            self.delete_resource("},{"line_number":135,"context_line":"                client\u003dself.admin_volumes_client,"},{"line_number":136,"context_line":"                volume_id\u003dres[\u0027restore\u0027][\u0027volume_id\u0027]"},{"line_number":137,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"8e790e23_fd3e862c","line":134,"in_reply_to":"ea4e7951_1f6790c7","updated":"2023-06-06 07:11:04.000000000","message":"If the backup restore fails, it means that the new volume (restore) is not created.\nThe original volume (the one that the backup was created from) gets deleted on the create_volume() cleanup in rbac/v3/base.py","commit_id":"a3150b526728f497a5e1deacfa23d4ac859be623"}]}